- 12 Jul, 2017 40 commits
-
-
Jia authored
Implement parseShorthand for -webkit-border-[start|end|before|after], -webkit-text-stroke and outline. All these shorthand properties call the same helper function ConsumeShorthandGreedilyViaLonghandAPIs. Hence these properties are grouped in one cl. Bug: 668012 Change-Id: I4341dd88c9e69ef0105846094324f673adffa967 Diff: https://gist.github.com/56c80c6712e00d58983a557381f20664/revisions Reviewed-on: https://chromium-review.googlesource.com/567605Reviewed-by:
Darren Shen <shend@chromium.org> Reviewed-by:
Suzy Howlett <suzyh@chromium.org> Reviewed-by:
meade_UTC10 <meade@chromium.org> Commit-Queue: Jia Meng <jiameng@chromium.org> Cr-Commit-Position: refs/heads/master@{#485878}
-
Eric Roman authored
Bug: 740871 Change-Id: I8571bf9448da2a257c45da7f1943226095ab08b7 Reviewed-on: https://chromium-review.googlesource.com/567638 Commit-Queue: Eric Roman <eroman@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#485877}
-
Tsuyoshi Horo authored
I removed the UMA (ServiceWorker.NavigationHintPrecision) when we stopped "Speculatively start Service Workers on UI-events" experiment (crbug.com/616502). But we will start "Warm-up service worker on omnibox signal" experiment (crbug.com/732681). So this CL revive the UMA as ServiceWorker.StartHintPrecision. Bug: 740102 Change-Id: I84034f9a3c8edb9ff25e5644d6b94c624ae00f1c Reviewed-on: https://chromium-review.googlesource.com/566138 Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#485876}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/4f9afdad..f2c153fc Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org Change-Id: I1bb1a398e0422df6ab613f7de030a5a6b3d23fe5 Reviewed-on: https://chromium-review.googlesource.com/567709Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#485875}
-
Giovanni Ortuño Urquidi authored
This flag will be used to develop new windowing related behavior for Desktop PWAs. Bug: 729923 Change-Id: I594eadbdf9f00928e9c1963f510e4b7c7b7788f7 Reviewed-on: https://chromium-review.googlesource.com/566263 Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Matt Giuca <mgiuca@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#485874}
-
Makoto Shimazu authored
This is 4th patch of script streaming project split off from https://chromium-review.googlesource.com/c/538477. This patch adds Mojo's interface to stream installed scripts to the renderer during launching up. This patch implements: - WebServiceWorkerInstalledScriptsManagerImpl::Internal as a receiver of streamed scripts which lives on the io thread on the renderer - ServiceWorkerInstalledScriptsSender as a sender of installed scripts on the browser process Bug: 683037 Change-Id: I6d7ae63aea670c37fe00c0c81afceb71dd70c62a Reviewed-on: https://chromium-review.googlesource.com/558529Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
-
dougt authored
This CL moves all ia2_role handling from BrowserAccessibilityComWin to AXPlatformNodeWin. In addition, we now forward IAccessible2::role() to AXPlatformNodeWin as well. BUG=703369 Review-Url: https://codereview.chromium.org/2965873002 Cr-Commit-Position: refs/heads/master@{#485872}
-
Yuki Awano authored
- unzReadCurrentFile in third_party/minizip/src/unzip.c supports to read a data up to UINT16_MAX at a time. BUG=359837 TEST=enable --zip-archiver-on-filer-manager flag and try to open and read a file with zip archiver. Change-Id: If92948199c6c3077ce35c0d4fdc60b20406acb1f Reviewed-on: https://chromium-review.googlesource.com/566767Reviewed-by:Tomasz Mikolajewski <mtomasz@chromium.org> Commit-Queue: Yuki Awano <yawano@chromium.org> Cr-Commit-Position: refs/heads/master@{#485871}
-
zhenw authored
This is the 1st CL for staggered background tab opening feature. It adds TabNavigationThrottle, which plumbs navigation information into TabManager and enables TabManager to defer navigation for background tabs. This CL uses a simple algorithm, which defers background tab's navigation when some tab is loading. After a tab finishes loading, it will resume another pending navigation. TabManager will also resume a pending navigation when a background tab is selected. This feature is currently implemented behind a flag. This feature will not be enabled until the corresponding metrics are ready. This CL focuses on plumbing navigation into TabManager. The actual algorithm to delay background tab opening is simple. But it should be fine because the whole feature is behind a flag right now. There will be follow-up CLs to consider system resources and refine the algorithm. Design doc: https://docs.google.com/document/d/1_CS5kcY00CE3pzDTtW5Ny221gWfk4mFXYGiezoYSCBI/ BUG=730098 Review-Url: https://codereview.chromium.org/2931023002 Cr-Commit-Position: refs/heads/master@{#485870}
-
Yoshifumi Inoue authored
This patch changes "undo-{combined-,forward-,}delete-boundary.html" to use |assert_selection()| and integrate into "undo-delete-boundary.html" since these test are similar for improving readability. Bug: 230267, 679977 Change-Id: I7f07399e83ee02ca9e945eeef5163e278cb9a10a Reviewed-on: https://chromium-review.googlesource.com/567615Reviewed-by:Yoichi Osato <yoichio@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#485869}
-
rnephew authored
Should never have been re-enabled on android. Did not read the bug associated with the disabling close enough. Will need to be more careful in the future. TBR=charliea@chromium.org Bug: 713222 Change-Id: Ib8908be570e772791167b38a57e7a96358ae8274 Reviewed-on: https://chromium-review.googlesource.com/567110Reviewed-by:
rnephew <rnephew@chromium.org> Commit-Queue: rnephew <rnephew@chromium.org> Cr-Commit-Position: refs/heads/master@{#485868}
-
Nicolas Capens authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/a781af7..4d97f36 BUG=738298 TEST=bots CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel,linux_chromium_cfi_rel_ng;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: Ida9f06b57f57a77676da21e6542640916db6bae6 Reviewed-on: https://chromium-review.googlesource.com/566949Reviewed-by:
Alexis Hétu <sugoi@chromium.org> Commit-Queue: Nicolas Capens <nicolascapens@google.com> Cr-Commit-Position: refs/heads/master@{#485867}
-
Joel Hockey authored
Code in LayoutEmbeddedContent::UpdateGeometry which is checking whether view is LocalFrameView or PluginView and then applying type-specific logic is moved into new virtual method EmbeddedContentView::UpdateGeometry and implemented by the relevant subtype (LocalFrameView, PluginView). Update RootScrollerController::UpdateIFrameGeometryAndLayoutSize to call LocalFrameView::UpdateGeometry rather than calling it on the Layout. Remove PluginView::GeometryMayHaveChanged, instead call plugin->ReportGeometry from PluginView::SetFrameRects. PluginView::GeometryMayHaveChanged was called as a special case in LayoutEmbeddedContent::UpdateGeometry, but it can be handled by PluginView::SetFrameRect which is also called at the same time. Remove unneeded protector from LayoutEmbeddedContent::UpdateGeometry. Bug: 637460 Change-Id: I2f9b4cab874e167afe9e4fb860351e92881f7bc6 Reviewed-on: https://chromium-review.googlesource.com/527862Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Stefan Zager <szager@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#485866}
-
wychen authored
The following tests are re-enabled: - testValid - testNoMeta - testCache All flaky failures in CopylessPasteTest are due to timeout in CallbackHelper.waitForCallback(). Wait for longer to see if it gets better. Reference: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=chrome_public_test_apk%20(with%20patch)&showAllRuns=true&tests=org.chromium.chrome.browser.CopylessPasteTest%23 BUG=713172,713895,713878,693650 Review-Url: https://codereview.chromium.org/2826253004 Cr-Commit-Position: refs/heads/master@{#485865}
-
yhanada authored
- Remove unused include_rule. - Restrict access to content/ and media/audio under ui/keyboard/content. - Move "+ui/gl/test/..." rule to ui/keyboard/test/DEPS. Test: trybots pass. Change-Id: I4cb1f8a34f8bd8cf6e1202bd0d1751af0f270367 Reviewed-on: https://chromium-review.googlesource.com/558591Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Tommi <tommi@chromium.org> Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/heads/master@{#485864}
-
Koji Ishii authored
Currently, NGLayoutInputNode::IsInline() uses a bit field in LayoutObject. This can mis-behave when NGBlockNode and NGInlineNode share a LayoutNGBlockFLow. This patch adds a type field back to NGLayoutInputNode. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_layout_ng Bug: 739087 Change-Id: I137ee5a5233d96fbb3297f1054f2cab7e4c06d33 Reviewed-on: https://chromium-review.googlesource.com/566984Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#485863}
-
dougt authored
This CL moves all ia2_state handling from BrowserAccessibilityComWin to AXPlatformNodeWin. In addition, we now forward get_states() to AXPlatformNodeWin as well. BUG=703369 Review-Url: https://codereview.chromium.org/2968833002 Cr-Commit-Position: refs/heads/master@{#485862}
-
hkamila authored
Bug: Change-Id: Ib2ced6b11cf9fe1736c8e97c8f06005d660ce028 Reviewed-on: https://chromium-review.googlesource.com/567173 Commit-Queue: Kamila Hasanbega <hkamila@google.com> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Luke Z <lpz@chromium.org> Cr-Commit-Position: refs/heads/master@{#485861}
-
Peter Collingbourne authored
This roll includes only a single revision: https://chromium.googlesource.com/chromium/buildtools/+/3d2d34dde457f07ca410d1c06f4f3b9063c28643 TBR=michaelpg@chromium.org Bug: 701919 Change-Id: I2924e4db1cad21ce8aa4c99f5090dea69d53a720 Reviewed-on: https://chromium-review.googlesource.com/567777 Commit-Queue: Peter Collingbourne <pcc@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#485860}
-
Hiroki Nakagawa authored
This CL implements the "module responses map" concept defined in the Worklet spec. This map caches module scripts to ensure that WorkletGlobalScopes created at different times contain the same set of script source text and have the same behaviour. The map is not used yet in this CL. Following CLs will wire it up with ModuleScriptLoader via WorkletModuleResponsesMapProxy (see the design doc for details). Worklet spec: https://drafts.css-houdini.org/worklets/#module-responses-map Design doc: https://docs.google.com/document/d/1cgLcrua7H_7x_o5GlzYrAi2qt-TqTzgtOeixFAugR6g/edit?usp=sharing Bug: 726576 Change-Id: Ib2af974e4b48eaf23ed2a38c74da5f2a503568d9 Reviewed-on: https://chromium-review.googlesource.com/549601Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#485859}
-
Hidehiko Abe authored
Now ArcIntentHelperBridge can be obtained via ArcServiceManager. So, LocalActivityResolver can be merged into ArcServiceManager to get rid of unnecessary reference from ArcServiceManager to it. BUG=739097 TEST=Ran trybot. Change-Id: Idaee93706e14b268feb28d98811f7b290de2165e Reviewed-on: https://chromium-review.googlesource.com/566785Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> Cr-Commit-Position: refs/heads/master@{#485858}
-
Naoki Fukino authored
The default ripple color for toolbar buttons is white, which is invisible on white background. We need to set custom style to make the ripple visible. Bug: 740836 Change-Id: I7dc62bef120d5a06e8f42247cc1e5c604c6fd4ff Reviewed-on: https://chromium-review.googlesource.com/566981Reviewed-by:
Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Commit-Queue: Naoki Fukino <fukino@chromium.org> Cr-Commit-Position: refs/heads/master@{#485857}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/cc60e4e3..4f9afdad Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org Change-Id: I99b6876fe0f0eb934ab1f7df234be4232b210b25 Reviewed-on: https://chromium-review.googlesource.com/567623Reviewed-by:
-
John Abd-El-Malek authored
TBR=yzshen@chromium.org NOTRY=true Change-Id: I2d987a880c31dfb97f37935e3f5d41a8b273f6bd Reviewed-on: https://chromium-review.googlesource.com/567647Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#485855}
-
Yoland Yan authored
For more on JUnit4 migration, please check src/testing/android/docs/junit4.md BUG: 640116 Change-Id: I1f2ed7d46f173ff84f6d3d284c3b0fcdb0657e8f Reviewed-on: https://chromium-review.googlesource.com/567461Reviewed-by:
Lambros Lambrou <lambroslambrou@chromium.org> Reviewed-by:
Zijie He <zijiehe@chromium.org> Commit-Queue: Yoland Yan <yolandyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#485854}
-
Keishi Hattori authored
This reverts commit 2096391c. Reason for revert: Maybe caused jingle_unittests to fail crbug.com/741256 Original change's description: > Reimplement base::WaitableEvent with a kqueue on Mac. > > For a single WaitableEvent, a custom EVFILT_USER kevent is used to wait and > signal. This replaces the default POSIX implementation that uses a > pthread_cond_t and a boolean flag. > > To implement WaitMany, a new kqueue is created to wait on all the individual > WaitableEvent's kqueue descriptor. This replaces a complex locking algorithm > used in the default POSIX implementation. > > For the asynchronous WaitableEventWatcher, a TYPE_READ dispatch_source_t is > used to watch the WaitableEvent's kqueue. This replaces the POSIX > implementation of a reference-counted list of async watchers guarded by a lock. > > Microbenchmarks show that the kqueue implementation is significantly faster in > most cases. The one potential drawback is hitting the low RLIMIT_NOFILE on > macOS, since each WaitableEvent and WaitableEventWatcher requires a new > descriptor. > > Bug: 681167 > Change-Id: I135012fdd25e547ffb911fc7adc97c203df38241 > Reviewed-on: https://chromium-review.googlesource.com/553497 > Reviewed-by: Robert Liao <robliao@chromium.org> > Reviewed-by: Mark Mentovai <mark@chromium.org> > Commit-Queue: Robert Sesek <rsesek@chromium.org> > Cr-Commit-Position: refs/heads/master@{#485788} TBR=robliao@chromium.org,rsesek@chromium.org,mark@chromium.org Change-Id: I5b8740bf353f86b0ac5b600793826cd7724cd784 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 681167 Reviewed-on: https://chromium-review.googlesource.com/566700Reviewed-by:
Keishi Hattori <keishi@chromium.org> Commit-Queue: Keishi Hattori <keishi@chromium.org> Cr-Commit-Position: refs/heads/master@{#485853}
-
Peiyong Lin authored
This patch moves values_struct_traits into a separate target to be shared by the chromium and blink variant, and adds values.typemap to blink's typemap config. BUG=740288 Change-Id: Iae1bf24dd90ca16af6f7b3e0d3e83d255ae41b16 Reviewed-on: https://chromium-review.googlesource.com/565337 Commit-Queue: lpy <lpy@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Yuzhu Shen <yzshen@chromium.org> Cr-Commit-Position: refs/heads/master@{#485852}
-
Dirk Pranke authored
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I0b58757a8c56cf1ae9a5ba82fe2d485651f3c52e Bug: 662541 Reviewed-on: https://chromium-review.googlesource.com/558381 Commit-Queue: Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Paweł Hajdan Jr. <phajdan.jr@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#485851}
-
Ke He authored
Remove the "if(ServiceManagerConnection::GetForProcess())", use the DCHECK() instead to make sure the ServiceManagerConnection is always initialized in production code. BUG=689415 Change-Id: I85dc481a80ddbef9faa0b5c99d8da8991d4f85be Reviewed-on: https://chromium-review.googlesource.com/545436Reviewed-by:
Yuri Wiitala <miu@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Ke He <ke.he@intel.com> Cr-Commit-Position: refs/heads/master@{#485850}
-
Thanh Pham authored
Bug: 730828 Change-Id: Ibf29dfcac0180a1c5240e47ad59f6c6f6c9479de Reviewed-on: https://chromium-review.googlesource.com/567703Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#485849}
-
dpapad authored
Bug: 730904 Change-Id: Id37a8a9c5d9e7ec5d5112ad2567a6c376c6e591e Reviewed-on: https://chromium-review.googlesource.com/567332Reviewed-by:
Dave Schuyler <dschuyler@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#485848}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/51b2f1b64c4d..d96ed9d0def2 $ git log 51b2f1b64..d96ed9d0d --date=short --no-merges --format='%ad %ae %s' 2017-07-11 herb Experimental blur code. 2017-07-11 bungeman Check first deserialized verb of path is a move. Created with: roll-dep src/third_party/skia BUG=740789 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=ethannicholas@chromium.org Change-Id: Ieacea59c9b71b45e1ab7ac21194f69d5bc37e131 Reviewed-on: https://chromium-review.googlesource.com/567813Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#485847}
-
Cooper Knaak authored
Added constants to FeatureEngagementTracker demo arrays. This allows the tracker's demo mode to interact with the new features. R=edchin@chromium.org, gchatz@chromium.org Bug: 738164 Change-Id: Ib29370c7d8e68af2021b8e8b77c78270cf86b577 Reviewed-on: https://chromium-review.googlesource.com/556466Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Ed Chin <edchin@chromium.org> Reviewed-by:
Gregory Chatzinoff <gchatz@chromium.org> Commit-Queue: Cooper Knaak <cooperknaak@google.com> Cr-Commit-Position: refs/heads/master@{#485846}
-
Sergey Ulanov authored
Previously there was a lot of platform-specific code in network_interfaces_unittest.cc, which made it hard to work with. Moved that code to separate files. Change-Id: I5e3827a42b78895ddf6007ca73f46053b9c45916 Reviewed-on: https://chromium-review.googlesource.com/562363Reviewed-by:
Eric Roman <eroman@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#485845}
-
Changwan Ryu authored
Currently, there are two types of callsites: 1) onSelectionChanged / onTextChanged: these should update user-visible autocompletetext. 2) Inside endBatchEdit(): these should only internally update states. We can call separate methods to serve these purposes better, and make notification path a bit clearer. Also, this CL polishes up test, by 1) removing unnecessary null check and 2) removing unnecessary method overriding for hasFocus() - now we're calling requestFocus() anyways. BUG=539536 Change-Id: If116ba53ec15a378545f3faa0f8cb0357d0dec85 Reviewed-on: https://chromium-review.googlesource.com/567392Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Changwan Ryu <changwan@chromium.org> Cr-Commit-Position: refs/heads/master@{#485844}
-
Suchit Agrawal authored
Create new BUILD.gn file for media/cdm and moved respective media component changes from media/BUILD.gn file to new BUILD.gn file. BUG=613033,739673 Signed-off-by:
Suchit Agrawal <a.suchit@samsung.com> Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I944b712791833edf6417db308225295c6cb3bdbf Reviewed-on: https://chromium-review.googlesource.com/561265Reviewed-by:
Alexander Potapenko <glider@chromium.org> Reviewed-by:
Nick Carter <nick@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: SUCHIT AGRAWAL <a.suchit@chromium.org> Cr-Commit-Position: refs/heads/master@{#485843}
-
Hiroshige Hayashizaki authored
Previously, XMLDOcumentParser uses ScriptResource directly. This CL replaces the ScriptResource with PendingScript, in order to: - Replace a call of ScriptLoader::ExecuteScript() with ExecuteScriptBlock() to unify load/error event handling within ExecuteScriptBlock(), as follow-up of https://chromium-review.googlesource.com/c/554098 (Issue 686281), - Prepare for module script support in XHTMLs (Issue 717643), and - Enable SRI check in XHTMLs (Issue 684306). Bug: 686281, 717643, 684306 Change-Id: Ibedded79223d30952dee4c8370fc9eed2201a462 Reviewed-on: https://chromium-review.googlesource.com/557304 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Daniel Vogelheim <vogelheim@chromium.org> Reviewed-by:
-
Christopher Cameron authored
This was already present, now use it to populate the information read by the compositor and renderers. Bug: 735613 Change-Id: Id5c85b2bc3a0891e35760dd27b65d85c898d9176 Reviewed-on: https://chromium-review.googlesource.com/564392Reviewed-by:
Fredrik Hubinette <hubbe@chromium.org> Commit-Queue: ccameron chromium <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#485841}
-
Bettina Dea authored
Added Steven because of file ownership. Added Catherine and Robert for file overview. Bug: 734248 Change-Id: I64eeabf9785d1b98ac0d5c615c0e082db327b1e5 Reviewed-on: https://chromium-review.googlesource.com/564184Reviewed-by:
-
Tsuyoshi Horo authored
In the current implementation, when SiteInstance was used to get the process, the Service Worker UMAs are recorded as NEW_PROCESS. But This is not accurate. SiteInstance can reuse the existing process. This CL also splits the EXISTING_PROCESS UMAs to EXISTING_READY_PROCESS and EXISTING_UNREADY_PROCESS. When PlzNavigate is enabled, the service worker is likely to be started in an existing unready process which was newly created for the navigation. We should record this case apart from starting in an existing ready process. Bug: 740102 Change-Id: I523cea926fb78eb25e2669cfa0a3d56ca003e08c Reviewed-on: https://chromium-review.googlesource.com/564912Reviewed-by:
-
