- 10 Sep, 2018 17 commits
-
-
Noel Gordon authored
Add an Ash EnableVirtualKeyboard mojo test API, and use it in FilesApp browser test fixtures that run in Ash tablet mode. No change in behavior: this is laying scaffold to allow testing of the Virtual Keyboard and its use in Files App in tablet mode [1]. [1] No tests of the Virtual Keyboard feature from Files App currently, and issue 762664, issue 762694 indicate this gap in test coverage. Test: browser_tests --gtest_filter="*FilesApp*TabletMode" Bug: 879434 Change-Id: I8c0c2ee8ef8e208cb721019c3cdca85f9448c5c8 Reviewed-on: https://chromium-review.googlesource.com/1210422 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#589828}
-
Hwanseung Lee authored
When RemovedFrom called, ContainerNode object was passed as a parameter. and it is never nullptr. so it can be changed to reference instead of pointer. Bug: 874385 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I231b13529f83540c7ad64d023d7421bc7a3f8ef6 Reviewed-on: https://chromium-review.googlesource.com/1215142Reviewed-by:
Hayato Ito <hayato@chromium.org> Commit-Queue: Hwanseung Lee <hs1217.lee@samsung.com> Cr-Commit-Position: refs/heads/master@{#589827}
-
Stuart Langley authored
The introduction of team drives means that calling DriveAPIService::GetChangeList can return a ChangeList object that contains both FileResource and TeamDriveResource entries. The sync engine code is not TeamDriveResource aware and assumes that ChangeList can only contain FileResource entries, and calling ChangeResource::File() will return a nullptr that later causes an AV in PopulateFileDetailsByFileResource. This CL filters out TeamDriveResource from the ChangeList object. Verified with new unit test. Bug: 850228 Change-Id: I1d8f4e8a99df8b8b04683eccaaceae4843020bda Reviewed-on: https://chromium-review.googlesource.com/1212366 Commit-Queue: Stuart Langley <slangley@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#589826}
-
angle-chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/1cee042197da..a735ee2f6df8 git log 1cee042197da..a735ee2f6df8 --date=short --no-merges --format='%ad %ae %s' 2018-09-10 jiajia.qin@intel.com ES31: Support shader storage block in D3D11 compiler - Part1 Created with: gclient setdep -r src/third_party/angle@a735ee2f6df8 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ynovikov@chromium.org Change-Id: I77c24b27ae8524de79664eb2d3cbc46ab9afa354 Reviewed-on: https://chromium-review.googlesource.com/1215462Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#589825}
-
depot-tools-chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/66badbd1cb28..25c380cf9d2d git log 66badbd1cb28..25c380cf9d2d --date=short --no-merges --format='%ad %ae %s' 2018-09-10 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@25c380cf9d2d The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: Ifeec74e766adeac734e462d05544a42bbab6e8ec Reviewed-on: https://chromium-review.googlesource.com/1215421Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#589824}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=govind@chromium.org Change-Id: Ife4121f6a478b2dc215a86e45b141722ed38bc6d Reviewed-on: https://chromium-review.googlesource.com/1215383Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#589823}
-
Tatsuhisa Yamaguchi authored
Changes the RequestCaptureState() to send media capture state bundled with account id, so that receiver can identify which one represents which user's status. Test: manual Test: ash_unittest --gtest_filter=MultiProfileMediaTrayItemTest.* Bug: 879269 Change-Id: I4e808d7e88d7904673869f282b41d7c37ecc8b12 Reviewed-on: https://chromium-review.googlesource.com/1203756 Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Cr-Commit-Position: refs/heads/master@{#589822}
-
Yutaka Hirano authored
Bug: 882292 Change-Id: I1baaabbe07a8eeaa5dd42fb6d657c1f77861bd56 Tbr: toyoshim@chromium.org No-Try: true Reviewed-on: https://chromium-review.googlesource.com/1214970Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#589821}
-
Yuki Yamada authored
This reverts commit 9f87a1ee. https://chromium-review.googlesource.com/c/chromium/src/+/1212202 Regarding to crbug.com/881688 : This CL adds the check for if listener is empty or not before calling it, but it should not be empty at that time. This is because listener object could be collected prematurally by garbage collection. This will be fixed after unified GC is launched, or wrapper-tracing is applied appropriately to all the EventTarget (some of EventTargets need to be ActiveScriptWrappable). Bug: 872138, 881688, 878658, 606900, 849236 Change-Id: I9b224e0d261e1567c4c4f7778bd0d6044b7f6202 Reviewed-on: https://chromium-review.googlesource.com/1212376Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Yuki Yamada <yukiy@google.com> Cr-Commit-Position: refs/heads/master@{#589820}
-
Chromium WPT Sync authored
Using wpt-import in Chromium f4e5d36f. With Chromium commits locally applied on WPT: 488a36e8 "[IntersectionObserver] Fix the concept of "tracking document"" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/24432 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=raphael.kubo.da.costa@intel.com No-Export: true Change-Id: I0109a5cac31b4c7698672d598340de96d5389924 Reviewed-on: https://chromium-review.googlesource.com/1215419 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#589819}
-
Kenichi Ishibashi authored
ServiceWorkerSubresourceLoader records loading milestones. These milestones are used to create web-exposed PerformanceResourceTiming. Before this CL, ServiceWorkerSubresourceLoader recorded |service_worker_ready_time| before calling GetControllerServiceWorker(). This doesn't seem a good timing to record it because: - |service_worker_ready_time| is used to create `fetchStart` of PerformanceResourceTiming. - `fetchStart` should be recorded after the controller service worker is ready to handle fetch event. - But the worker may not be running until we call GetControllerServiceWorker(). This CL moves the timing to record |service_worker_raedy_time| and some others after calling GetControllerServiceWorker(), as calling it makes sure that the controller is running and ready to handle a fetch event. The wpt ervice-workers/service-worker/resource-timing.https.html should cover this change. Bug: 782958 Change-Id: Ic6f6abd34ffdc84e002357a905e7a7726e6b5870 Reviewed-on: https://chromium-review.googlesource.com/1212244 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
-
Yutaka Hirano authored
This reverts commit 488a36e8. Reason for revert: Speculative revert for - http/tests/intersection-observer/v2/cross-origin-effects.html - http/tests/intersection-observer/v2/cross-origin-occlusion.html Original change's description: > [IntersectionObserver] Fix the concept of "tracking document" > > As explained in the bug, "tracking document" should be associated with > IntersectionObservation, not IntersectionObserver. > > One side effect of this change is that for a given observer, each of its > observations runs its algorithm independently, so that notifications may > not be generated in the order in which the observations were created > (i.e., the order of calls to observer.observe()). To preserve the > idiomatic web platform behavior that notifications are delivered in > the order in which the targets were observed, this patch moves the > storage of pending notifications from IntersectionObserver to > IntersectionObservation. > > BUG=879798 > R=chrishtr@chromium.org > > Change-Id: I9b6f6ad8a26387f0c072ccdff7f18cea9a88004c > Reviewed-on: https://chromium-review.googlesource.com/1200388 > Reviewed-by: Chris Harrelson <chrishtr@chromium.org> > Commit-Queue: Stefan Zager <szager@chromium.org> > Cr-Commit-Position: refs/heads/master@{#589678} TBR=szager@chromium.org,chrishtr@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 879798, 882280 Change-Id: I885276c561c8d6f21afdc059d080d58fac3b899e Reviewed-on: https://chromium-review.googlesource.com/1215423Reviewed-by:
-
Ben Wells authored
Bug: 881634 Change-Id: Id275bfe3ff4ceb6b4989f03a96b13fcb68fd460f Reviewed-on: https://chromium-review.googlesource.com/1212209Reviewed-by:
Darren Shen <shend@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Ben Wells <benwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#589816}
-
depot-tools-chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/f022f91453f7..66badbd1cb28 git log f022f91453f7..66badbd1cb28 --date=short --no-merges --format='%ad %ae %s' 2018-09-09 kbr@chromium.org Increase timeout to Http instance passed to authenticator. Created with: gclient setdep -r src/third_party/depot_tools@66badbd1cb28 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:882266 TBR=agable@chromium.org Change-Id: Iacb3446ec5eec19c9163a4be685bb50fe2de509c Reviewed-on: https://chromium-review.googlesource.com/1214815Reviewed-by:
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/d22a4ff1f201..038f252b7691 git log d22a4ff1f201..038f252b7691 --date=short --no-merges --format='%ad %ae %s' 2018-09-09 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 3b9680534909..1cee042197da (1 commits) Created with: gclient setdep -r src/third_party/skia@038f252b7691 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=caryclark@chromium.org Change-Id: Ic1a04883bf3f44b88e727da36cdf5a8f0be62249 Reviewed-on: https://chromium-review.googlesource.com/1214817Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#589814}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 7d0daa8a. With Chromium commits locally applied on WPT: 488a36e8 "[IntersectionObserver] Fix the concept of "tracking document"" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/24431 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=raphael.kubo.da.costa@intel.com No-Export: true Change-Id: Iae4bcc7cfc51b7a0ebf7ea3a1b2b40cf06da78de Reviewed-on: https://chromium-review.googlesource.com/1214816 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
-
Julie Jeongeun Kim authored
When the mouse cursor exits from the browser window, 'CompoundEventFilter' doesn't update the cursor and it doesn't know whether ET_MOUSE_EXITED happens when the window is destroying or the mouse exits from the window. WindowTreeHostPlatform keeps the previous cursor and WaylandWindow, one of PlatformWindows, also keeps it. This patch resets the cursor from WindowTreeHostPlatform on ET_MOUSE_EXITED to update it when it reenters the window. Test: aura_unittests Bug: 879448 Change-Id: I52919aaadef4a0934eb6ad88c1f4d4ba75f802b0 Reviewed-on: https://chromium-review.googlesource.com/1198714 Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#589812}
-
- 09 Sep, 2018 22 commits
-
-
angle-chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/3b9680534909..1cee042197da git log 3b9680534909..1cee042197da --date=short --no-merges --format='%ad %ae %s' 2018-09-09 fjhenigman@chromium.org Suppress ...shaders.builtin_variable.fragcoord_w. Created with: gclient setdep -r src/third_party/angle@1cee042197da The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ynovikov@chromium.org Change-Id: Id567387eb78fe024672025e0eca7ea5cd744e956 Reviewed-on: https://chromium-review.googlesource.com/1214814Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium dce6d45e. With Chromium commits locally applied on WPT: 488a36e8 "[IntersectionObserver] Fix the concept of "tracking document"" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/24430 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=raphael.kubo.da.costa@intel.com No-Export: true Change-Id: I6c42e6d3324b37af4b756bb183be37070f7284c9 Reviewed-on: https://chromium-review.googlesource.com/1214813 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
-
Koji Ishii authored
The code to paint the background of scrolling contents layer was missing in NGBoxFragmentPainter. This patch copies the logic from BoxPainter. Issue 861623 found that this code path runs when all of the following conditions are true: * In Chrome (not in content_shell). * When display / CSS pixel >= 1.5. * When background is set to 'overflow: auto' box. This patch also fixes 3 CSS contain tests that has 'contain: paint', 'overflow-[xy]: scroll', and background color to an inline formatting context. Bug: 861623 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I31d0b407e794409552dcf89f5c8005fafc5f99a6 Reviewed-on: https://chromium-review.googlesource.com/1215143Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#589809}
-
Jungshik Shin authored
This roll has two Changes: https://chromium.googlesource.com/chromium/deps/icu/+/8b8d2590a https://chromium.googlesource.com/chromium/deps/icu/+/7ca3ffa77 The former is to add 'quarter'-related items to the locale data for Ecma 402 Intl implementation. The latter is to fix locale id handling API bugs in ICU also required by v8. It also defines USE_CHROMIUM_ICU to 1 so that builds NOT using Chromium's copy of ICU can take a different code path if necessary (e.g. Node.js with system ICU or ICU without the above two fixes; see https://chromium-review.googlesource.com/1215223 ). In a follow-up CL, USING_SYSTEM_ICU check in Blink will be replaced by checking USE_CHROMIUM_ICU. TBR=ftang@chromium.org, gsathya@chromium.org Bug: v8:7869, v8:8135 Test: v8's RelativeTime format test Test: test262/intl402/Intl/getCanonicalLocales/* Change-Id: Ie0475df396639ad3333de38ad1cdd24e9bfe252c Reviewed-on: https://chromium-review.googlesource.com/1215362 Commit-Queue: Jungshik Shin <jshin@chromium.org> Reviewed-by:
Jungshik Shin <jshin@chromium.org> Cr-Commit-Position: refs/heads/master@{#589808}
-
Ehsan Karamad authored
The initial attempt was causeing build failures in "mac-rel" bot. The cause seems to be the use of static initializers. This CL moves them to a method. This is a reland of 92df23c1 Original change's description: > Implement MimeHandlerViewFrameController > > This CL implements the renderer side of MimeHandlerView based on > cross-process frames (behind a flag). > > The new subclass of MimeHandlerViewContainerBase will use a content > frame inside a plugin element for loading the MimeHandlerViewGuest's > extension. > > The current implementation is not complete and the missing features > such as postMessage support will be added in the follow-up CLs. > > This CL also introduces a new class of parametric browser tests > (MimeHandlerViewCrossProcessTest) which will be the destination of > the current MimeHandlerViewTests as more features are integrated into > the frame-based version. The new test class runs the test on both > BrowserPlugin-based and cross-process-frame-based versions. > > Document: https://docs.google.com/document/d/10g7Y9cprYKkch9JZ0TBUWaEnHBJT1nzhskQIt1nHbWM/edit#heading=h.qw81a2bk3v6w > > Bug: 659750 > TBR=thestig@chromium.org > > Change-Id: Ia69aeed47f4fa1c7f5b81cdde71a8d8b5ff59165 > Reviewed-on: https://chromium-review.googlesource.com/1187231 > Commit-Queue: Ehsan Karamad <ekaramad@chromium.org> > Reviewed-by: Sam McNally <sammc@chromium.org> > Reviewed-by: Ehsan Karamad <ekaramad@chromium.org> > Reviewed-by: Alex Moshchuk <alexmos@chromium.org> > Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org> > Reviewed-by: James MacLean <wjmaclean@chromium.org> > Cr-Commit-Position: refs/heads/master@{#589284} TBR=alexmos@chromium.org,lazyboy@chromium.org,sammc@chromium.org,wjmaclean@chromium.org Bug: 659750, 881696 Change-Id: I94c779664981738222c8d79ca0b10ab06174a4a7 Reviewed-on: https://chromium-review.googlesource.com/1213369Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Ehsan Karamad <ekaramad@chromium.org> Commit-Queue: Ehsan Karamad <ekaramad@chromium.org> Cr-Commit-Position: refs/heads/master@{#589807}
-
perfetto-chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/660b95093bcd..5313adfefcab git log 660b95093bcd..5313adfefcab --date=short --no-merges --format='%ad %ae %s' 2018-09-09 primiano@google.com TraceProcessor: Add clipping support to sched table + minor fixes 2018-09-09 primiano@google.com trace_processor: Counters table Created with: gclient setdep -r src/third_party/perfetto@5313adfefcab The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:111252261 TBR=perfetto-bugs@google.com Change-Id: I76bf99a197ad1e4b159cb456fa821f93401acf0e Reviewed-on: https://chromium-review.googlesource.com/1214812Reviewed-by:
perfetto-chromium-autoroll <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: perfetto-chromium-autoroll <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#589806}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 8ea72f74. With Chromium commits locally applied on WPT: 488a36e8 "[IntersectionObserver] Fix the concept of "tracking document"" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/24414 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=raphael.kubo.da.costa@intel.com No-Export: true Change-Id: Iae8963abcf0120f1c700494c795abf32371ca806 Reviewed-on: https://chromium-review.googlesource.com/1214809 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/40c7c64572bc..d22a4ff1f201 git log 40c7c64572bc..d22a4ff1f201 --date=short --no-merges --format='%ad %ae %s' 2018-09-09 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update SKP version Created with: gclient setdep -r src/third_party/skia@d22a4ff1f201 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=caryclark@chromium.org Change-Id: I6395cbf6cdb1a7a19f213b9597142b04d1926aeb Reviewed-on: https://chromium-review.googlesource.com/1214807Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium aab3f480. With Chromium commits locally applied on WPT: 488a36e8 "[IntersectionObserver] Fix the concept of "tracking document"" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/24413 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=raphael.kubo.da.costa@intel.com No-Export: true Change-Id: I20a181d2c33f14c3703efef091ae41d5e002c5a3 Reviewed-on: https://chromium-review.googlesource.com/1214808 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
-
https://chromium-review.googlesource.com/c/chromium/src/+/1213525Nico Weber authored
I meant '\s*', not '\w*'. Also remove a \b that has no effect. TBR=tikuta Bug: 330263 Change-Id: I91595cf10c67281ebc023d66bddfd940b85f6381 Reviewed-on: https://chromium-review.googlesource.com/1214629Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#589802}
-
Ned Nguyen authored
** PERF SHERIFF: this CL may cause perf graphs to regress but it's expected ** Previously, there is a big discrepancy between the predicted timing of generate_perf_sharding's output & the actual timing. For details, see: * Predicted timing: https://logs.chromium.org/v/?s=chrome%2Fbuildbucket%2Fcr-buildbucket.appspot.com%2F8935880309586521856%2F%2B%2FBenchmarks_Shard_Map_ca71405d-0fb3-4722-a815-af11b3f08318 * Actual timing: https://ci.chromium.org/p/chrome/builders/luci.chrome.ci/android-go-perf/182 After debugging, I found the root cause of this discrepancy is due to the order of stories input in generate_perf_sharding isn't the same of the order of stories which are meant to be run. This is because we mistakenly sort the list of story names in benchmark_utils.GetBenchmarkStoryNames(..) method. This CL fixes it by removing the sorting logic. It also add unittest to ensure that the order of story names return by the method always matches with the order of stories to be run. Bug:863768 Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi Change-Id: I769ff867b0ee10a9afafafebbd4cb2621e0ab93f TBR=jbudorick@chromium.org, perezju@chromium.org NOTRY=true # content_browsertests flake Change-Id: I769ff867b0ee10a9afafafebbd4cb2621e0ab93f Reviewed-on: https://chromium-review.googlesource.com/1214806 Commit-Queue: Ned Nguyen <nednguyen@google.com> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#589801}
-
Greg Thompson authored
Also moves some consumes of InstallDetails to the new convenience functions in install_static. BUG=879568 Change-Id: I01c5c05f10a57407b3981ab64c6d4da2bb8de088 Reviewed-on: https://chromium-review.googlesource.com/1213145 Commit-Queue: Greg Thompson <grt@chromium.org> Reviewed-by:
Patrick Monette <pmonette@chromium.org> Cr-Commit-Position: refs/heads/master@{#589800}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/dd27ece0..abc91d41 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I9d9acafcd0f81a1c626693962ab542aa2daa7633 Reviewed-on: https://chromium-review.googlesource.com/1214804Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#589799}
-
Thomas Tangl authored
Screenshot before: https://drive.google.com/file/d/1gxhx2eGVfqwOi6GQFmyMTPaJkVtWIZXL/view?usp=sharing Screenshot after: https://drive.google.com/file/d/1bvwkIfvfCu0Jo3H04HRISWSp0xNmotO1/view?usp=sharing Bug: 872807 Change-Id: Ic0f6edee667e86661245105fd8f8a159f5674773 Reviewed-on: https://chromium-review.googlesource.com/1213176Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/heads/master@{#589798}
-
Ned Nguyen authored
Note: the old Telemetry decorators no longer work on benchmarks TBR=pasko@chromium.org NOTRY=true # flake Bug: 760498 Change-Id: I514ebefb488db9934adcdde77c2f307a571183d6 Reviewed-on: https://chromium-review.googlesource.com/1215244 Commit-Queue: Ned Nguyen <nednguyen@google.com> Reviewed-by:
-
Jeremy Roman authored
Chromium is presently the only major vendor not to support it. Bug: 689891 Change-Id: Ibc7b0f1bf0da06f77d16cd9aeace44c2674807cc Reviewed-on: https://chromium-review.googlesource.com/1215242 Commit-Queue: Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#589796}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=govind@chromium.org Change-Id: I4d393c774db0c54782f315ef46404857c245fcdb Reviewed-on: https://chromium-review.googlesource.com/1214926Reviewed-by:
-
Alexei Filippov authored
Followup to fix test failure after r589730. BUG=878604 TBR=erikchen@chromium.org,thestig@chromium.org Change-Id: I55ae973e2d3b2204549ce67be24dfdd929b6f374 Reviewed-on: https://chromium-review.googlesource.com/1215054Reviewed-by:
Alexei Filippov <alph@chromium.org> Commit-Queue: Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#589794}
-
Justin Donnelly authored
This reverts commit f3334641. Reason for revert: Reason for revert: Introduces static initializers according to https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/mac-rel/549. Original change's description: > RemoteMacViews: Remove browser deps from NativeWidgetMacNSWindow > > Update NativeWidgetMacNSWindow to use the mojo BridgeNativeWidgetHost > interface instead of directly dereferencing views structures. Make > similar changes to ViewsNSWindowDelegate. Update the mojo interfaces > to include these functions. > > Remove the nativeWidgetMac property from ViewsNSWindowDelegate. > Replace it with an "id" uint64_t on NativeWidgetMacNSWindow, which > can be used to look up a corresponding > - BridgedNativeWidgetImpl (in the app/viewer process) > - BridgedNativeWidgetHostImpl (in the browser process) > - a follow-on patch will add a "shadow" NativeWidgetMacNSWindow > in the browser process which will use this id > - that window will not be visible, but will be used for state > tracking and bounds computations > > Bug: 859152 > Change-Id: I9f62aefa1d4eba9961f691b5bd9247871e121355 > Reviewed-on: https://chromium-review.googlesource.com/1205477 > Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> > Reviewed-by: Robert Sesek <rsesek@chromium.org> > Commit-Queue: ccameron <ccameron@chromium.org> > Cr-Commit-Position: refs/heads/master@{#589415} TBR=ellyjones@chromium.org,ccameron@chromium.org,rsesek@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 859152 Change-Id: I597859c3dc3c11f231d21de73799c99481d28f36 Reviewed-on: https://chromium-review.googlesource.com/1214759Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Reviewed-by:
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/a3dc329d1db1..40c7c64572bc git log a3dc329d1db1..40c7c64572bc --date=short --no-merges --format='%ad %ae %s' 2018-09-09 fmalita@chromium.org [skottie] Skip group nodes for single-draw shapes Created with: gclient setdep -r src/third_party/skia@40c7c64572bc The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=caryclark@chromium.org Change-Id: Ib667dca8116d5e09de07c16b822c5912a929f11a Reviewed-on: https://chromium-review.googlesource.com/1215085Reviewed-by:
-
Bin Wu authored
Initially QuicInlinedVector will be a absl::InlinedVector in Google3, and a std::vector in Chromium. Once Chromium can use absl, we can switch it to absl::InlinedVector as well. Merge internal change: 208999480 R=rch@chromium.org Change-Id: If341f868ca911439ae3ed36256d46138787456d5 Reviewed-on: https://chromium-review.googlesource.com/1177917Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Bin Wu <wub@chromium.org> Cr-Commit-Position: refs/heads/master@{#589791}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 63a7666b. With Chromium commits locally applied on WPT: 488a36e8 "[IntersectionObserver] Fix the concept of "tracking document"" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/24344 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: jsbell@chromium.org: external/wpt/resources NOAUTOREVERT=true TBR=raphael.kubo.da.costa@intel.com No-Export: true Change-Id: I0be4af53a909667ba29bd0565a29aca5f219825e Reviewed-on: https://chromium-review.googlesource.com/1215057 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
-
- 08 Sep, 2018 1 commit
-
-
Koji Ishii authored
Following bot results are included. 9492 9497 9498 9499 9500 9502 9503 9508 9514 9515 9516 9517 9518 2 lines were removed and 3 lines were deflaked by consecutive results since 9497. TBR=eae@chromium.org, mstensho@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I62b7d6aee9f94364de2a09fec17448ed470eec34 Reviewed-on: https://chromium-review.googlesource.com/1212242 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#589789}
-
