- 13 Mar, 2018 6 commits
-
-
Aleks Totic authored
This makes ~50 additional tests to pass, and 3 to fail. Paint invalidation can cause styles on a NGPhysicalFragment to get out of sync with LayoutObject styles. There were two ways to fix this, I found a) to be cleaner for now. a) Make PhysicalFragments fetch style from LayoutObject Tricky part here is that :first-line and overflow:ellipsis get special styles. b) Rebuild PhysicalFragment tree with a shallow clonewithstyle I was unable to find a clean way to trigger tree rebuild here. Sample experiment to convert paint invalidations into layout invalidations triggered 100s DCHECK(!NeedsLayout()) Possible fix would be to trap all places that call NeedsLayout() with intent to relayout, and replace them with NeedsLayout() || NeedsNGLayout() This does not fix all invalidation bugs. DisplayItems outside of LayoutObject tree do not get invalidated correctly. fast/css/first-letter-hover.html fast/history/visited-link-hover-emphasis-color.html Bug: 819372 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_layout_ng;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Ia11f8288b8f45423762c870a43615707d6a0cc93 Reviewed-on: https://chromium-review.googlesource.com/956552 Commit-Queue: Aleks Totic <atotic@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#542664}
-
https://chromium.googlesource.com/angle/angle.git/+log/203d6365c567..64e5ed2abd8a $ git log 203d6365c..64e5ed2ab --date=short --no-merges --format='%ad %ae %s' 2018-03-09 lucferron Vulkan: Fix scissor clears + enable dEQP tests 2018-02-25 lfy GLES1: state: Define / initialize GLES1-specific states 2018-03-12 lucferron Vulkan: Enable culling rasterization state dEQP tests Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: Ia29eef8615b5037089380eb2e8eda2afe4eed7cc Reviewed-on: https://chromium-review.googlesource.com/959633 Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#542663}
-
Dan Harrington authored
This cuts down on some of the boilerplate in task unit tests, and is similar to how the prefetch task tests are written. Also added TestTaskRunner in TestTaskBase, which is now used in prefetch task tests. Bug: 802892 Change-Id: I352713d3d9940965bbe0654af57093d12085f3a3 Reviewed-on: https://chromium-review.googlesource.com/953326Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Commit-Queue: Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#542662}
-
Wez authored
These tests were flakey due to messages being dropped by the receiver occasionally when the underlying plaform-specific Channel was closed. Bug: 764015, 764018, 756112, 810448, 815314, 816620 Change-Id: I2b6cfb105660a570c09b29555da7811541d49ec9 Reviewed-on: https://chromium-review.googlesource.com/959674 Commit-Queue: Wez <wez@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#542661}
-
Derek Cheng authored
Currently the icon type is always hard coded to CAST, but it should be determined using the Cast device capabilities. This patch implements that logic so that with the CastMediaRouteProvider feature enabled, the right icon type will be displayed on the device list. Note this does not impact the MR extension since it has its own logic to determine icon type. Bug: 698940 Change-Id: I6afa8eb9db1553fabaf2a8ee617812edb354ae8c Reviewed-on: https://chromium-review.googlesource.com/956538 Commit-Queue: Derek Cheng <imcheng@chromium.org> Reviewed-by:
Bin Zhao <zhaobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#542660}
-
Benjamin Pastene authored
Bug: 817779 Change-Id: I652c928db764e106a5e94a3bbcce6f11cd9f2d87 Reviewed-on: https://chromium-review.googlesource.com/959593Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Benjamin Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#542659}
-
- 12 Mar, 2018 34 commits
-
-
Weidong Guo authored
Before the change, when the launcher receives located events outside its bounds, the launcher will be closed. This change makes the launcher go back instead of being closed in that case. Going back means that the launcher will close the folder or search results page if they exist, and will close itself otherwise. BUG=814806 Change-Id: I977011bca34e17cb041dd5a598a4b88ec093a930 Reviewed-on: https://chromium-review.googlesource.com/953585Reviewed-by:
Yury Khmel <khmel@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Weidong Guo <weidongg@chromium.org> Cr-Commit-Position: refs/heads/master@{#542658}
-
Allen Vicencio authored
This CL implements NetworkScanner and adds tests. This allows the use of multiple HostLocators by registering it with NetworkScanner. Bug: chromium:757625 Change-Id: I5c607450196f3f1751cab44ff42b94057d142442 Reviewed-on: https://chromium-review.googlesource.com/952369Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Commit-Queue: Allen Vicencio <allenvic@chromium.org> Cr-Commit-Position: refs/heads/master@{#542657}
-
Pavel Feldman authored
Bug: 819449 Change-Id: I492b98d296a2646a79c34c21d6c2a265dff7cc13 Reviewed-on: https://chromium-review.googlesource.com/953144Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#542656}
-
Jialiu Lin authored
1. Move all safe browsing realted policy to M67 2. Add password form guideline to PasswordProtectionLoginURLs and PasswordProtectionChangePasswordURL settings 3. Fix type "SAML" Bug: 804490 Change-Id: Ib35bf249eed1e9bd1f1aa03835f5c6ec627af8aa Reviewed-on: https://chromium-review.googlesource.com/959042Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Nathan Parker <nparker@chromium.org> Commit-Queue: Jialiu Lin <jialiul@chromium.org> Cr-Commit-Position: refs/heads/master@{#542655}
-
Achuith Bhandarkar authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/7ed5549cfa7b..3b75c9d82ebf $ git log 7ed5549cf..3b75c9d82 --date=short --no-merges --format='%ad %ae %s' 2018-03-10 phobbs metrics: Fix DistributionMetric 2018-03-06 dgarrett cbuildbot_run: Adjust GetVersion to use CIDB Id. 2018-03-08 achuith cbuildbot: Generate and upload uploaded.json. 2018-03-08 yunlian cros_setup_toolchain: add elfutils to sdk. 2018-03-06 cmtice chrome_sdk: Disable CFI on SimpleChrome 2018-03-08 ahassani paygen: calculate metadata size after signing 2018-03-08 xiaohuic Add libassistant.so to chrome paths 2018-03-06 cmtice Enable cfi on caroline and terra release builds. 2018-03-05 phobbs metrics: Add Distribution wrapper function 2018-03-09 pprabhu Revert "cros tryjob: Add --json option." 2018-03-09 chrome-bot Update config settings by config-updater. 2018-03-08 dgarrett cros tryjob: Set email_notify property. 2018-03-08 dgarrett cros tryjob: Cleanup tag/properties. 2018-03-07 dgarrett cros tryjob: Add --json option. 2018-03-07 ahassani auto_updater: cros flash starts update_engine 2018-03-07 achuith [chrome_chromeos_lkgm_unittest]: Remove cruft. 2018-03-08 davidriley remote_access: Log reboot checks as DEBUG. 2018-03-08 davidriley auto_updater: Do not warn if quick-provision.log cannot be copied. 2018-03-07 dgarrett cros buildresult: Improve help messages. 2018-03-07 pprabhu chromeos_config: Mark more flaky paladins experimental. 2018-03-07 linben android_stage: Stop using different URL template for master-arc. 2018-03-07 achuith cros_build_lib_unittest: Fix failure in tearDown. 2018-03-06 manojgupta cros_setup_toolchains: Build compiler-rt in armv7m-cros-eabi. 2018-03-07 pprabhu doc: Add more troubleshooting help for moblabvm. 2018-03-07 pprabhu docs: Add instructions for using existing moblabvm workspace. 2018-03-05 pwang commands: Strip arcnext label from board 2018-03-05 xueweiz vm_test_stages: Increase timeout for GCETest. 2018-03-06 pprabhu cbuildbot: Mark whirlwind-paladin experimental. 2018-02-02 ahassani paygen: Run inside chroot 2018-02-02 ahassani paygen: Add InitSDK stage 2018-03-05 pwang betty-vmtest-informational: Fallback to run CtsDeqp 2018-03-01 laszio DebugInfoTest: perform tests based on debug info 2018-03-02 linben Add support for more master-arc-dev builds 2018-03-05 chrome-bot Update config settings by config-updater. 2018-03-03 chrome-bot Update config settings by config-updater. 2018-03-03 chrome-bot Update config settings by config-updater. 2018-03-02 davidriley merge_logs: Additional trimming support. 2018-03-02 shapiroc Revert "Add support for yaml in cbuildbot" 2018-02-27 achuith [chrome_chromeos_lkgm]: Use CQ to land changes. 2018-03-01 yunlian add terra-chrome-pfq builder to experimental. 2018-02-21 bhthompson Remove Sandybridge boards which are deprecated 2017-11-03 dgarrett cbuildbot: Update CIDB selection logic. 2018-02-28 dgarrett cbuildbot_config: Add debug-cidb option. 2018-02-28 dgarrett cbuildbot: Add --debug-cidb. 2018-02-08 ayatane Reland "Move sysmon to vpython" 2018-02-05 bmgordon cbuildbot_launch: Add post-build chroot cleanup stage 2018-02-23 laszio afdo: update the heuristic of profile selection 2018-02-27 briannorris cros tryjob: fixup --help suggestions for paladin names 2018-02-22 achuith [chrome_chromeos_lkgm]: Rename LGTM to LKGM. 2018-02-13 dgarrett commands: Add GenerateDebugTarball unittests. 2018-02-23 laszio afdo: enroll 14 boards to use field profiles Created with: roll-dep src/third_party/chromite Bug: 762650 Change-Id: I3a8aaca6d850b54605a9e0d323677d0aa70f938c Reviewed-on: https://chromium-review.googlesource.com/959424Reviewed-by:
Greg Levin <glevin@chromium.org> Commit-Queue: Achuith Bhandarkar <achuith@chromium.org> Cr-Commit-Position: refs/heads/master@{#542654}
-
Scott Violet authored
EventRewriters don't honor the target, and so generally expect the root_location and location to be the same. This patch changes EventSource::SendEventToSink() to create a new Event if the existing has differing locations (and a target). BUG=817112 TEST=covered by tests Change-Id: Iaabe019fed4350610306576a054b7d395def92ff Reviewed-on: https://chromium-review.googlesource.com/956925Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#542653}
-
Tom Sepez authored
This reverts commit 5ff974fc. Original CL was https://chromium-review.googlesource.com/953979 This CL differs from the original in that in the test framework, PDFs are loaded into separate tabs, instead of on top of each other. Under slow test infrastructure (e.g. MSAN), the plugin processes would exit before we could complete the loads and count them. This fixes the test (and the shipping code is unchanged from the original). TBR=jam@chromium.org Bug: 809614 Change-Id: Id13a97023a60d86fb72c47d580c001b737bf17bf Reviewed-on: https://chromium-review.googlesource.com/959236 Commit-Queue: Tom Sepez <tsepez@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#542652}
-
Andrii Shyshkalov authored
We decided not to migrate master.chromium.webkit builders. R=dpranke@chromium.org Bug: 790322, 790325 Change-Id: I0bb3547b62fd2c51b6edbaddf8767960e6682d5a No-Try: True Reviewed-on: https://chromium-review.googlesource.com/958231Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> Cr-Commit-Position: refs/heads/master@{#542651}
-
Wez authored
This is a reland of cdcb0262, which was reverted pending a fix for an underlying Mojo message-loss issue on channel shutdown. Original change's description: > Add missing message-received expectation to IPCMojoBootstrapTest. > > Some of these tests expected a message from the child process, and would > verify that it was valid/invalid as expected, but would still pass if > no message were received at all. > > Bug: 816620 > Change-Id: Ie8acf85086f4416c7023118673c40d00a2e190d7 > Reviewed-on: https://chromium-review.googlesource.com/955554 > Reviewed-by: Ken Rockot <rockot@chromium.org> > Commit-Queue: Wez <wez@chromium.org> > Cr-Commit-Position: refs/heads/master@{#542296} TBR: rockot Bug: 816620 Change-Id: Ifdf10581091be31a6c9d1aa53542f2ed6c2ccbfa Reviewed-on: https://chromium-review.googlesource.com/958016Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#542650}
-
Chris Nardi authored
Many tests of CSS.registerProperty were written, but none have been upstreamed to WPT. Upstream these tests to ensure interoperability. Bug: 641877 Change-Id: I8272b14c78cb75bb6f5f3cedb770091cbcba522a Reviewed-on: https://chromium-review.googlesource.com/959422Reviewed-by:
Robert Ma <robertma@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Chris Nardi <cnardi@chromium.org> Cr-Commit-Position: refs/heads/master@{#542649}
-
CrystalFaith authored
Included additional code samples for local and sync. Bug: 229359 Change-Id: I9d503ba83241ca717b7684afd41e431d09f45b92 Reviewed-on: https://chromium-review.googlesource.com/953377 Commit-Queue: Crystal Lambert <crystallambert@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#542648}
-
https://chromium.googlesource.com/catapult.git/+log/6eaec901b986..4b356c746683 $ git log 6eaec901b..4b356c746 --date=short --no-merges --format='%ad %ae %s' 2018-03-12 simonhatch Dashboard - Missing comma in api whitelist. Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=sullivan@chromium.org Change-Id: Id2ab20886e54fa8938f106da04234d6537c04a5c Reviewed-on: https://chromium-review.googlesource.com/959581 Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#542647}
-
Thomas Guilbert authored
This CL adds the ability to get a MediaControllerBridge from a presentation ID. The presentation ID is first converted to a route ID, before being sent to the MediaRouterAndroid. The MediaControllerBridge allows native code to forward commands to a Java MediaController. Currently, only RemotePlayback will use this path, and the Java MediaController interface is only implemented by the RemoteMediaPlayerWrapper. Bug: 790766 Change-Id: Ie089aff905fffd2521053620f79fe739ab6eb3a1 Reviewed-on: https://chromium-review.googlesource.com/930472Reviewed-by:
Nick Carter <nick@chromium.org> Reviewed-by:
Derek Cheng <imcheng@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#542646}
-
Balazs Engedy authored
Before this CL, content::FrameTreeNode used to classify only the literal `about:blank` as the URL corresponding to the initial empty document. However, navigations from the initial empty document to URLs such as `about:blank#ref` are same-document and therefore re-use the initial empty document, so committing any such same-document navigations should not be considered "real loads" by FrameTreeNode (given they are not considered "real loads" by Blink). This CL changes FrameTreeNode::SetCurrentURL() to use !IsAboutBlank() to determine whether the first real load is currently taking place in a frame, that is, whether it is a first time a URL is being committed that is not the initial empty document (modulo an optional #fragment). Bug: 821022, 729021 Change-Id: I040a11f58bf27174e0c450377f8cd81a7abeac70 Reviewed-on: https://chromium-review.googlesource.com/958925Reviewed-by:
Charlie Reis <creis@chromium.org> Commit-Queue: Balazs Engedy <engedy@chromium.org> Commit-Queue: Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#542645}
-
Peter Boström authored
Makes unfocused popover dialogs keyboard accessible on non-MacOS where F6 is used to cycle between different panes. Follow-ups changes that are necessary are: * Choose and utilize a different (non-function key) on MacOS. * Update keyboard shortcut help documentation so users who search the web for "chrome dialog keyboard shortcut" has a chance of finding it. This intentionally locks user focus inside the inactive bubble instead of adding it to the pane cycle. Users who intend to use pane cycling will need to accept or dismiss the dialog (normally using ESC) before continuing pane cycling. Bug: chromium:764918 Change-Id: Ib0144c9f914b63758f23454547c26907747f5939 Reviewed-on: https://chromium-review.googlesource.com/956528Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#542644}
-
Lukasz Anforowicz authored
This CL moves the call to canonical_mime_type_ = network::CrossOriginReadBlocking::GetCanonicalMimeType(mime_type); closer to the point where the value of the |canonical_mime_type_| field is needed for the 1st time. The move helps with the following: - Makes unit tests more robust against shuffling of chucks inside ShouldBlockBasedOnHeaders (some shuffling will be needed when moving some checks into //services/network). - Makes the code of ShouldBlockBasedOnHeaders closer to the promise to perform less expensive checks first (the GetCanonicalMimeType has medium cost - it has to compare the mime type against multiple hardcoded strings). The move necessitates some small follow-up tweaks in unit tests. Bug: 792546 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: Ib21add69443dd0748aafd57da89a3cc16ffcdec1 Reviewed-on: https://chromium-review.googlesource.com/957804Reviewed-by:
Nick Carter <nick@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#542643}
-
https://webrtc.googlesource.com/src.git/+log/3e77afd0d29b..15fb915917f7 $ git log 3e77afd0d..15fb91591 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc BUG=None The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I3ba00c4094f930ed70fb207d17d1b988d76833a9 Reviewed-on: https://chromium-review.googlesource.com/959544 Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#542642}
-
Xianzhu Wang authored
Previously the scale and clip operations were outputted with TransformRecorder and ClipRecorder which were no-op on SPv175. Change them to direct canvas operations. Bug: 815075 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I0f31640563aa09f37e68028413a7dacbb74f506a Reviewed-on: https://chromium-review.googlesource.com/957595Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#542641}
-
Robert Iannucci authored
R=jbudorick@chromium.org, nodir@chromium.org Bug: 811974 Change-Id: I2f13b98fb0f82e38aa526ff4b8696614e6ef0746 Reviewed-on: https://chromium-review.googlesource.com/959586 Commit-Queue: Robbie Iannucci <iannucci@chromium.org> Reviewed-by:
Nodir Turakulov <nodir@chromium.org> Cr-Commit-Position: refs/heads/master@{#542640}
-
Kevin Bailey authored
For dispositions of singleton and switch-to-tab, allow URLs which only differ between http and https to match. This is done to allow suggestions of http to find their ultimate destination. Also happens to remove the enum NavigationPararms::IGNORE_AND_STAY_PUT since it wasn't really being used, and enum NavigationParams:: RefBehavior since we force IGNORE_REF now. Bug: 780835 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I73e7db51fdbef710b804966b482cb2cf0d6139ab Reviewed-on: https://chromium-review.googlesource.com/949569Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Kevin Bailey <krb@chromium.org> Cr-Commit-Position: refs/heads/master@{#542639}
-
Balazs Engedy authored
This is a reland of bae82629 Original change's description: > Reland "Don't have two copies of //device/fido." > > This is a reland of e23bd4d7, now without > `dllimport`-annotated classes with inline MOCK_METHODs. > > Original change's description: > > Don't have two copies of //device/fido. > > > > Prior to this change, both libcontents.so and content_unittests would > > each have a copy of //device/fido because the test_support code would > > pull in a copy directly. This caused there two be two copies of > > |U2fDiscovery::g_factory_func_| – one used by the test_support code and > > one by the code that's used for actual processing. That obviously breaks > > things. > > > > This CL makes //device/fido a `component` instead of a `source_set`, > > which, however, necessitates adding COMPONENT_EXPORT annotations to all > > exported classes/functions/constants. > > > > The CL also cleans up the components by: > > -- adding some missing #includes and DISALLOW_COPY_AND_ASSIGNs, and > > -- moving dependencies included in public headers into `public_deps`. > > > > Bug: 785955, 820441 > > Change-Id: I7a2ab0977a3090ff91fcd8bb53b16d13419d434a > > Reviewed-on: https://chromium-review.googlesource.com/955698 > > Commit-Queue: Balazs Engedy <engedy@chromium.org> > > Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org> > > Reviewed-by: Adam Langley <agl@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#542472} > > TBR=jdoerrie@chromium.org > > Bug: 785955, 820441 > Change-Id: I9ed13c7d1105f133c5f54cce7f0a4d74f1d57904 > Reviewed-on: https://chromium-review.googlesource.com/958863 > Commit-Queue: Balazs Engedy <engedy@chromium.org> > Reviewed-by: Balazs Engedy <engedy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#542523} TBR=jdoerrie@chromium.org Bug: 785955, 820441 Change-Id: I28ca8b09d2af26dbc2375a42d97c3191bb7ac26e Reviewed-on: https://chromium-review.googlesource.com/958868 Commit-Queue: Balazs Engedy <engedy@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#542638}
-
prasadv authored
TBR=mmoss@chromium.org Change-Id: I7e4f37f33702eebccf199bec997ec9e9e23fb33a Reviewed-on: https://chromium-review.googlesource.com/959573Reviewed-by:
Prasad Vuppalapu <prasadv@chromium.org> Commit-Queue: Prasad Vuppalapu <prasadv@chromium.org> Cr-Commit-Position: refs/heads/master@{#542637}
-
Nektarios Paisios authored
Screen readers now announce the correct role for the zoom in and zoom out buttons and also announce the zoom level if changed. Announcing that these controls are buttons sends a signal to screen reader users that the menu will not close when these controls are activated. The drawback is that the word "Alert" is prepended to the announcement of the new zoom level. R=aleventhal@chromium.org, pbos@chromium.org Bug: 779304 Change-Id: Ie078d63c318a70fa64db268ac748dc2700995f55 Tested: Use zoom in and zoom out while Jaws and NVDA are running Reviewed-on: https://chromium-review.googlesource.com/957902Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Commit-Queue: Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#542636}
-
Alexei Filippov authored
The TLS version has the same performance compared to lock-free version, and also has the following benefits: - simpler code - handles multithreaded allocations with higher accuracy It although has a potential corner case issue when there are lots or short living threads each allocating small amount of memory. BUG=803276,812262 Change-Id: Ie868f07b99559d8cc95d134eed6592bffe1f63aa Reviewed-on: https://chromium-review.googlesource.com/944052 Commit-Queue: Alexei Filippov <alph@chromium.org> Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Reviewed-by:
Primiano Tucci <primiano@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#542635}
-
Wez authored
Write() operations to a Channel can fail due to the peer having closed it, while there are still messages waiting to be read from it. We must therefore defer notifying the caller of the Channel::Error until we observe end-of-stream via a readable notification, otherwise those messages may be dropped (depending on whether the posted OnError task is processed before or after a pending Channel-readable event). Bug: 816620 Change-Id: I75bd34a48edf4022809d27ce49f9cfba7a5d4daf Reviewed-on: https://chromium-review.googlesource.com/956932 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#542634}
-
Robert Iannucci authored
R=nodir@chromium.org Change-Id: If7d4793523d7ada7e08722b5442988568554d5c1 Reviewed-on: https://chromium-review.googlesource.com/959603Reviewed-by:
Nodir Turakulov <nodir@chromium.org> Commit-Queue: Robbie Iannucci <iannucci@chromium.org> Cr-Commit-Position: refs/heads/master@{#542633}
-
Sergey Berezin authored
This is a reland of https://crrev.com/c/953591 with a fix. BUG=813163 TBR=jochen@chromium.org Reviewed-on: https://chromium-review.googlesource.com/953591Reviewed-by:
Sergey Berezin <sergeyberezin@chromium.org> Commit-Queue: Sergey Berezin <sergeyberezin@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#541636} Change-Id: I2683369ef68c198a954488b2aaa7d66eb63c9b2f Reviewed-on: https://chromium-review.googlesource.com/958036 Cr-Commit-Position: refs/heads/master@{#542632}
-
https://skia.googlesource.com/skia.git/+log/24f25dc8bca7..67f62b1a6101 $ git log 24f25dc8b..67f62b1a6 --date=short --no-merges --format='%ad %ae %s' 2018-03-12 brianosman Add SkColorSpaceXform_skcms 2018-03-12 bungeman Revert "IWYU for some test files starting with 'C'." 2018-03-12 skcms-skia-autoroll Roll skia/third_party/externals/skcms/ 3ca91a31d..6cecdee60 (2 commits) 2018-03-12 bungeman IWYU for some test files starting with 'C'. Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=stephana@chromium.org Change-Id: I2c9341bc6f134e265a20f670bc78d5fc066c33c8 Reviewed-on: https://chromium-review.googlesource.com/959458 Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#542631}
-
Wei Li authored
There are two cases that PDF files are being printed: from print preview or directly from PDF plugin extension. Our previous way of identifying a PDF file being printed replies on the printed document's setting 'is_modifiable' is correctly set up. However, it was only set up when print preview is enabled, not when using system dialog. This CL fixed that by directly checking the web URL. Also since the web url can be checked for print preview, we no longer need to keep the flag 'for_preview' inside print composite client. So removed that. BUG=820143 Change-Id: I8c9051d5e2945b1d5a4b9f74494fbe3f6ad795f2 Reviewed-on: https://chromium-review.googlesource.com/958298 Commit-Queue: Wei Li <weili@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#542630}
-
Johann authored
nicholss@chromium.org shows "No longer on Chrome" in Gerrit. zijiehe@ has left per jamiewalch@ Change-Id: I3d4b5dae03a0e16f6d3322c0994a901039bd7546 Reviewed-on: https://chromium-review.googlesource.com/959563Reviewed-by:
Zijie He <zijiehe@chromium.org> Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Commit-Queue: Johann Koenig <johannkoenig@google.com> Cr-Commit-Position: refs/heads/master@{#542629}
-
Brian Anderson authored
Adds constants and helpers for upcomming frame metrics. The Accumulator96b class accumulates values with 96 bits of precision, which will be important when accumulating 32-bit values that are squared and weighted. Bug: 790761 Change-Id: Ie88800bef37c6103dd2becd9f85402b3e5fd34d4 Reviewed-on: https://chromium-review.googlesource.com/949823Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: Brian Anderson <brianderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#542628}
-
Nektarios Paisios authored
Fixed AXObject IndexInParent by retrieving the unignored parent since all children are unignored by default R=dmazzoni@chromium.org, aboxhall@chromium.org Change-Id: Ib8b391fd938eee6dc0b48fc08791dd01f68e7faf Reviewed-on: https://chromium-review.googlesource.com/956298 Commit-Queue: Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#542627}
-
Pavel Feldman authored
This reverts commit f70764f0. Reason for revert: https://ci.chromium.org/buildbot/chromium.webkit/Android%20Builder/133606 Android build failed. Original change's description: > Adds a class that encapsulates a range in Blink's accessibility tree. > > This is just a basic class that can convert from a DOM selection to an AX range and vice versa. It can also perform a selection on the AX range. > This class doesn't still handle any of the many corner cases that I will be looking at next, cases that will be covered by tests. > R=dmazzoni@chromium.org > > Bug: > Change-Id: I7c98617e8ef3b8bcca8cfc0d2e5518f2da771063 > Reviewed-on: https://chromium-review.googlesource.com/678016 > Commit-Queue: Nektarios Paisios <nektar@chromium.org> > Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> > Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Nektarios Paisios <nektar@chromium.org> > Cr-Commit-Position: refs/heads/master@{#542619} TBR=dmazzoni@chromium.org,yosin@chromium.org,haraken@chromium.org,mlamouri@chromium.org,yoichio@chromium.org,nektar@chromium.org,xiaochengh@chromium.org,xiaochengh@google.com Change-Id: I9aa2b6ecde4df092f73255e22155087a1f87486b No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/959429Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#542626}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/fc5740ae..10c5b8fc Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I2410d09aeb483619fc8e21b55846de85f7f24532 Reviewed-on: https://chromium-review.googlesource.com/959428Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#542625}
-