- 23 Jun, 2017 40 commits
-
-
proberge authored
This removes a //chrome dependency in base (process_version_rc_template), allowing //base to be used by targets that do not have access to //chrome. BUG=642115 TEST=eventlog_provider.dll is installed and SYSLOG works. Review-Url: https://codereview.chromium.org/2946983002 Cr-Commit-Position: refs/heads/master@{#481878}
-
Greg Thompson authored
This reverts commit 2878e36f. Reason for revert: This is checking for a feature before FeatureList::InitializeInstance is called, causing a crash at startup; see https://crbug.com/736251. Original change's description: > Disable the buggy RSA parser by default. > > In doing so, fix the error mapping in openssl_ssl_util.cc. An SSL > connection may fail due to errors in other modules as well (notably the > RSA parser lives in libcrypto). Map any unknown error to > ERR_SSL_PROTOCOL_ERROR, rather than ERR_FAILED and continue to > report the error info. > > Bug: 735616 > Change-Id: Icb587e66987ddd9d5445d30d456de1c029cda21a > Reviewed-on: https://chromium-review.googlesource.com/540536 > Commit-Queue: Steven Valdez <svaldez@chromium.org> > Reviewed-by: Steven Valdez <svaldez@chromium.org> > Cr-Commit-Position: refs/heads/master@{#481640} TBR=davidben@chromium.org,svaldez@chromium.org Change-Id: If7f24fa8a99bfd7a8daa2efad926b06350d5d9a6 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 735616 Reviewed-on: https://chromium-review.googlesource.com/545715Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#481877}
-
kojii authored
Following bot results are included. 510 511 520 523 525 531 543 544 Skipped some results due to instabilities of the bot. 1341 lines removed by 12 consecutive passes since 495 (Jun 20.) BUG=591099 TBR=eae@chromium.org NOTRY=true Review-Url: https://codereview.chromium.org/2951063002 Cr-Commit-Position: refs/heads/master@{#481876}
-
Marc Treib authored
This removes the plumbing in LogoBridge for using components/doodle. The actual components/doodle code will be deleted separately later. TBRing deletion of the c/b/doodle folder (which I in fact own, but the commit queue doesn't seem to care :) TBR=jochen Bug: 690467 Change-Id: Ie9b52bb3ab79f14795cbdd70d3fba4b9ada5032f Reviewed-on: https://chromium-review.googlesource.com/544311 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#481875}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/eb64b9b201d0..f3b9d4b033a6 $ git log eb64b9b20..f3b9d4b03 --date=short --no-merges --format='%ad %ae %s' 2017-06-22 halcanary SkPDF: add some TRACE_EVENTs 2017-06-22 mtklein fix repeat/mirror sampling bleed 2017-06-22 jvanverth Remove static initializer restriction for Vulkan tests 2017-06-22 jvanverth Blacklist TransferPixelsTest on NVIDIA Shield 2017-06-22 ethannicholas Revert "Revert "clean up sksl dead variable handling"" Created with: roll-dep src/third_party/skia Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=halcanary@chromium.org Change-Id: I7659925327b24524ad321b46f4669de9266f994d Reviewed-on: https://chromium-review.googlesource.com/545456Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#481874}
-
Scott Violet authored
This was a subclass purely because WindowTargeter implements EventTargeter functions in a protected block. Given it is expected that WindowTargeter is an EventTargeter and EventTargeter is not an implementation detail it seems the overrides should be in the public section. BUG=none TEST=none Change-Id: Ib93232ad50a072a63a4beb982e9f265a606b6cbe Reviewed-on: https://chromium-review.googlesource.com/544680Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#481873}
-
robertshield authored
Mention that env var overrides don't work in Google Chrome builds. BUG=710575 Review-Url: https://codereview.chromium.org/2958463002 Cr-Commit-Position: refs/heads/master@{#481872}
-
xunjieli authored
This CL: - incorporates the feedback (see linked bug) that memory_benchmarks.md doesn't mention where to find the trace files on perf dashboard. - adds "memory:chrome:all_processes:reported_by_chrome:net:effective_size_avg" string in a comment in url_request_context.h, so it's greppable in code and makes it easier to find where the metric comes from. BUG=734619 Review-Url: https://codereview.chromium.org/2952203002 Cr-Commit-Position: refs/heads/master@{#481871}
-
Xida Chen authored
TBR=msramek@chromium.org NOTRY=true Bug: 736345 Change-Id: I74ec229f350a540aa6641d8e0b53c36b4af4498e Reviewed-on: https://chromium-review.googlesource.com/545615Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#481870}
-
Markus Heintz authored
This cl adds a is_video_suggestions field to the ContentSuggestions class and the Java equivalent SnippetArticle. The field is set based on the content_type of a RemoteSnippet. RemoteSnippet is now supporting the content_type field of suggestions sent by the server. Bug: 735072 Change-Id: I02401c2856bb2ff3c7bb95cc4cb91e67dc464e0d Reviewed-on: https://chromium-review.googlesource.com/543142 Commit-Queue: Markus Heintz <markusheintz@chromium.org> Reviewed-by:
vitaliii <vitaliii@chromium.org> Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Cr-Commit-Position: refs/heads/master@{#481869}
-
ajith.v authored
Smart Go/Next brings better user experience to the user during form submitting applications. For navigating between form elements, user can use NEXT/PREVIOUS button from IME without touching on individual fields. This will avoid unnecessary form submissions before filling or visiting all fields in the form. Additionally it will save user time and avoid redundant network requests before actually filling/attending entire fields in the form Design Document: https://docs.google.com/document/d/1h0diigZ8LUi7A3UKJ_zwNUbvNQoe-Nwr55_p6ivSPNg/edit?usp=sharing Initial patch is reviewed @ https://codereview.chromium.org/2839993002/ BUG=410785,648986, 733222 Review-Url: https://codereview.chromium.org/2948593002 Cr-Commit-Position: refs/heads/master@{#481868}
-
Florin Malita authored
There's no need to go through an intermediate SharedBuffer, because we start with a flat Vector<char> in FontPlatformData::OpenTypeTable(). Refactor the validation code to use Vector<char> instead of SharedBuffer. BUG=728627 Change-Id: I81892c0c5c42b4f2e2abdeeabaca20979cd60eeb Reviewed-on: https://chromium-review.googlesource.com/544317Reviewed-by:
Ben Wagner <bungeman@google.com> Reviewed-by:
Hajime Hoshi <hajimehoshi@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/master@{#481867}
-
Marc Treib authored
Before, we'd clear the cached data when the refresh request failed due to e.g. missing network connectivity. Now, we keep the cache in that case. We still clear the cache if the server responds with an HTTP error, or when it returns invalid/unexpected data. Bug: 583292 Change-Id: I974ec774591d77bb11417a7cafdb511934250fcb Reviewed-on: https://chromium-review.googlesource.com/541357 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#481866}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/a7e622ba..753d46ee Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,vogelheim@chromium.org Review-Url: https://codereview.chromium.org/2949103007 Cr-Commit-Position: refs/heads/master@{#481865}
-
droger authored
BUG=730589 Review-Url: https://codereview.chromium.org/2947853002 Cr-Commit-Position: refs/heads/master@{#481864}
-
Kenichi Ishibashi authored
Before this CL the base lexer treated comments as tokens and the base parser had some custom rules to handle special comments like copyrights. Blink's lexer/parser needed to extend the base lexer/parser to remove comments as otherwise comments must be explicitly included in the grammar. Since the base parser is only used by Blink and Blink doesn't need comments (at least now), it makes sense to ignore comments in the base lexer/parser. This enables us to remove all custom rules from BlinkIDLParser. BUG=617899 Change-Id: I6ead510680457dfb13ed9797ac056c34c185e292 Reviewed-on: https://chromium-review.googlesource.com/544424 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#481863}
-
Xida Chen authored
TBR=foolip@chromium.org NOTRY=true Bug: 736255 Change-Id: I5c44e037aa86f8de3060f97cc9326544a79f12c0 Reviewed-on: https://chromium-review.googlesource.com/545278Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#481862}
-
Alex Clarke authored
This is very similar to the ExpeditedDispatcher except you can pause and resume requests. Bug: Change-Id: Ia53d4187d97e2c263fb46a14e970083f4da10ada Reviewed-on: https://chromium-review.googlesource.com/545001Reviewed-by:
Eric Seckler <eseckler@chromium.org> Commit-Queue: Alex Clarke <alexclarke@chromium.org> Cr-Commit-Position: refs/heads/master@{#481861}
-
Colin Blundell authored
Happened to notice that this code is no longer used anywhere. It was added in https://chromiumcodereview.appspot.com/12380006, where it was used by PushMessagingAPI. However, the push messaging implementation no longer uses this class. TBR=thakis Change-Id: I41c427f1a539ac7ed5e0f8b7e6c2cd49b19564b9 Reviewed-on: https://chromium-review.googlesource.com/539455Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Peter Williamson <petewil@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#481860}
-
Takashi Toyoshima authored
In usual cases, ResourceFetcher::StopFetching and ClearContext are called by DocumentLoader or FrameLoader in the disposal sequence. But, when we use WorkerFetchContext by enabling off-main-thread-fetch, ResourceFetcher is owned by WorkerFetchContext instead of Loaders. Thus, ResourceFetcher isn't finalized correctly. This patch runs ResourceFetcher finalization steps in WorkerOrWorkletGlobalScope instead of Loaders so that WorkerOrWorkletGlobalScope can be disposed safely even in the case of having active loading tasks on GC collecting it. This problem can be observed in the layout test, http/tests/serviceworker/chromium/stop-worker-during-respond-with.html, when off-main-thread-fetch feature is enabled. But test itself can pass on the head. BUG=735410 Change-Id: Ib5526b0e35c0ebe9a55589f0ff44e0180db19f91 Reviewed-on: https://chromium-review.googlesource.com/544637 Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#481859}
-
Vitalii Iarko authored
This CL improves some fetcher-related tests located in remote suggestions provider unittests. The ones, which duplicate RemoteSuggestionsFetcherTest, were removed. The ones missing there were moved there. Some were adapted to test provider bit only. This is preparation for using only MockFetcher in provider tests. Bug: 733129 Change-Id: If344dd064dce40e1a7231edf3c443693466784a4 Reviewed-on: https://chromium-review.googlesource.com/544989Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Commit-Queue: vitaliii <vitaliii@chromium.org> Cr-Commit-Position: refs/heads/master@{#481858}
-
pkl authored
These are no longer being used. BUG=721921 Review-Url: https://codereview.chromium.org/2897213002 Cr-Commit-Position: refs/heads/master@{#481857}
-
Yutaka Hirano authored
This will be needed to implement fetch API preloading support. Bug: 652228 Change-Id: Icc7719a137731552cce5613fe006097d657af7ef Reviewed-on: https://chromium-review.googlesource.com/544377Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#481856}
-
Peter K. Lee authored
Now that Google App Launcher has been deprecated, there's nothing left to be cleared. Bug: 721921,227636 Change-Id: I32cf9f3ea7b458f80ef91e24984db379d9abe4cb Reviewed-on: https://chromium-review.googlesource.com/544848 Commit-Queue: Peter Lee <pkl@chromium.org> Commit-Queue: Louis Romero <lpromero@chromium.org> Reviewed-by:
Louis Romero <lpromero@chromium.org> Cr-Commit-Position: refs/heads/master@{#481855}
-
mastiz authored
Fixes an undesirable side effect of https://codereview.chromium.org/2891333002 by overriding the desired size for manifest icons regardless of handler_type_. BUG=735354 Review-Url: https://codereview.chromium.org/2948963002 Cr-Commit-Position: refs/heads/master@{#481854}
-
Rune Lillesveen authored
This is split out of [1]. In order to avoid backtracking past out-of- flow, display:none, and display:contents nodes of attached siblings for whitespace re-attachment, we keep track of the last attached in- flow box for an AttachLayoutTree(). The AttachContent is made non-const to pass on previous in-flow past slot, content, and display:contents ancestors. This CL does not have behavioral changes on its own. [1] https://chromium-review.googlesource.com/c/517940/ BUG=399816 Change-Id: I7bf5faaf3e9fe3d1b4f62c22076be6ad31790cfe Reviewed-on: https://chromium-review.googlesource.com/543037Reviewed-by:
nainar <nainar@chromium.org> Commit-Queue: Rune Lillesveen <rune@opera.com> Cr-Commit-Position: refs/heads/master@{#481853}
-
Colin Blundell authored
As part of the move toward eliminating AccountTracker entirely (see bug), this CL removes two AccountTracker::Observer methods that are essentially unused in the codebase (their one production implementation simply uses them to print logging messages, which could happen just as easily in AccountTracker itself if needed). The third method (OnSignInChanged()) is actually used. Eliminating this method will likely require porting its consumers to observe the OAuth2TokenService instead. TBR=rockot@chromium.org Bug: 729590 Change-Id: I2300f83e8f402ac54783eae212efc8debe598e0b Reviewed-on: https://chromium-review.googlesource.com/538618Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Nicolas Zea <zea@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#481852}
-
tansell authored
BUG=706091 TBR=dpranke@chromium.org,mcgreevy@chromium.org,qyearsley@chromium.org,jeffcarp@chromium.org,sahel@chromium.org,ricea@chromium.org NOTRY=true Review-Url: https://codereview.chromium.org/2954643002 Cr-Commit-Position: refs/heads/master@{#481851}
-
Yutaka Hirano authored
It was not allowed before, but I loosened the restriction in order to support "keepalive" requests. Let's recover the restriction for other requests. Bug: 735963, 735456 Change-Id: I7fd31838afd7426ea211bf98fd9266f950f149cd Reviewed-on: https://chromium-review.googlesource.com/544746 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#481850}
-
tansell authored
These tests fail on Mac 10.9 in different ways. To get LayoutTests on Swarming working for Mac 10.9 we need to disable them. BUG=736257 TBR=dpranke@chromium.org,mcgreevy@chromium.org,qyearsley@chromium.org,jeffcarp@chromium.org NOTRY=true Review-Url: https://codereview.chromium.org/2959463002 Cr-Commit-Position: refs/heads/master@{#481849}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/4162e53c..a7e622ba Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,vogelheim@chromium.org Review-Url: https://codereview.chromium.org/2958513002 Cr-Commit-Position: refs/heads/master@{#481848}
-
Colin Blundell authored
As part of porting the Identity extension API impl to use the Identity Service to fulfill all its needed signin functionality, this CL ports IdentityGetAuthTokenFunction to obtain the account ID that it should use from the Identity Service rather than directly from SigninManager and AccountTrackerService. The only subtlety is in handling the case where the extension is using a GAIA ID that does not correspond to that of the primary (authenticated) account. To handle that case, we introduce IdentityManager::GetAccountInfoFromGaiaId(). Bug: 729556 Test: Install a Chrome extension with the identity permissions in its manifest. Go to chrome://extensions, enable developer mode, and inspect the background page of the above app. At the JS console that that brings up, execute: chrome.identity.getAuthToken((token) => {console.log(token);} ) Verify that a long alphanumeric string appears rather than an error being reported. Change-Id: I9247c3a73d9049994eb9d41c9b440830c4e9fc92 Reviewed-on: https://chromium-review.googlesource.com/536754 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#481847}
-
Takeshi Yoshino authored
The bunch of if-clauses are hard to read. Reorganize them for better readability. Unify the multiple checks on IsExternalRequest. Early return for IsExternalRequest(). Don't check CORS-safelisted-ness when either of the external request or forced preflight condition is already met. Clarify where the ServiceWorkerMode configuration is required and its reason for each place. Bug: 695808, 604084 Change-Id: I2a056afeebea4d6472e60c52cc72fd58c6bef703 Reviewed-on: https://chromium-review.googlesource.com/542676Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Commit-Queue: Takeshi Yoshino <tyoshino@chromium.org> Cr-Commit-Position: refs/heads/master@{#481846}
-
tansell authored
* external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests/flexbox/flexbox-baseline-multi-item-vert-001b.html * external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests/writing-modes-3/text-combine-upright-compression-001.html * external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests/writing-modes-3/text-combine-upright-compression-004.html BUG=736255 TBR=jsbell@chromium.org,dpranke@chromium.org,mcgreevy@chromium.org,qyearsley@chromium.org,jeffcarp@chromium.org NOTRY=true Review-Url: https://codereview.chromium.org/2954103002 Cr-Commit-Position: refs/heads/master@{#481845}
-
lizeb authored
This sets up Custom Tabs for hidden tab benchmarking: - Force the prerendering mode - Force prerendering on cellular - Optionally set a different speculated URL and launched URL Also removes support for no state prefetch and speculative prefetch testing. Review-Url: https://codereview.chromium.org/2946913002 Cr-Commit-Position: refs/heads/master@{#481844}
-
Jochen Eisinger authored
BUG=689520 R=primiano@chromium.org Change-Id: Id7a87939f7df7b86e6b8e6a02ce0ea226e02a573 Reviewed-on: https://chromium-review.googlesource.com/544864Reviewed-by:
Primiano Tucci <primiano@chromium.org> Commit-Queue: Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#481843}
-
Kinuko Yasuda authored
Add some more code from ServiceWorkerContextRequestHandler to ScriptURLLoaderFactory. Also added small cleanup around IsInstalled. BUG=715640 patch from issue 2953763002 at patchset 1 (http://crrev.com/2953763002#ps1) Change-Id: Ib0b578378a957e911bf7a36b2929d2723e0b35f7 Reviewed-on: https://chromium-review.googlesource.com/544720Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#481842}
-
Andrii Shyshkalov authored
TBR=machenbach@chromium.org Bug: 736215 Change-Id: I30b49f478c8c6ba9a6507092924a6f05a5f6ea8e No-Try: True Reviewed-on: https://chromium-review.googlesource.com/544867Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> Cr-Commit-Position: refs/heads/master@{#481841}
-
Andrii Shyshkalov authored
This reverts commit 0a2e609c. Reason for revert: typo && not useful any more. Original change's description: > Temporary remove android_arm64_dbg_recipe from CQ. > > TBR=jochen@chromium.org,mgiuca@chromium.org > > Bug: 736215 > Change-Id: I10fe5c623fdedd51ab0039132a07b8a413a06978 > No-Try: True > Reviewed-on: https://chromium-review.googlesource.com/544885 > Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> > Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> > Cr-Commit-Position: refs/heads/master@{#481837} TBR=mgiuca@chromium.org,tandrii@chromium.org,jochen@chromium.org Change-Id: Ie58bf3ed01bc35899ec73a63dd1db90ec797becd No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 736215 Reviewed-on: https://chromium-review.googlesource.com/544826Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> Cr-Commit-Position: refs/heads/master@{#481840}
-
tandrii authored
Revert of Roll buildtools 7f2cacbbe2..38477c2e10 (patchset #1 id:1 of https://codereview.chromium.org/2953643004/ ) Reason for revert: Probably broke incremental builds on trybots. BUG=736215 Original issue's description: > Roll buildtools 7f2cacbbe2..38477c2e10 > > In order to roll GN 7c9bd5f0..bedb4b20 (r465654:r481731) and pick up > the following changes: > > a104997e Allow overriding script executable in .gn file > 18697c83 Move if, else, true, false into a keyword category > d4a5e982 [tracing] Switch to new heap dump format. > 8480d866 tools/gn: Implement Windows SDK version command line switch > 3e0d5228 Use ContainsValue() instead of std::find() in tools/ > e4a28698 Fix GN bootstrap > 11857736 [spelling] existance to existence > 21886543 Fix a bug in `gn analyze` for host-only file mods. > f8bf5083 Fix gn get_label_info comment > 05f56d41 allocator: remove ENABLE_MEMORY_TASK_PROFILER and use only USE_ALLOCATOR_SHIM > e329e9ec Fix GN bootstrap > 2928b5dc Add information on the requirements for a new Chromium port. > 73228cd4 allocator: rename use_experimental_allocator_shim to use_allocator_shim > 797723cd Fix GN bootstrap > 84fa8b08 Replace sanitizers:deps with exe_and_shlib_deps (Chromium repo only) > d77555bc GN: Fix single-file compilations in VS2017 projects > cbbd560a gn: get rid of GetRealPath() function > cf2a4bf9 gn: convert WrapUnique calls to MakeUnique where possible > dfb837a9 gn: fix bootstrap on windows > 777e1cd5 Fix gn bootstrap after https://codereview.chromium.org/2872503003 > 25e10941 gn: Document gen's --check flag. > 14525201 Add a GUID to base::SharedMemoryHandle. > b154afcb memory-infra: Move dump level check to observer and rename session state > 9b718c79 Fix GN bootstrap > 643d6bc9 gn: fix bootstrap.py after https://codereview.chromium.org/2846893003 > dd1ae15f gn docs: Add a missing closing paren. > 0088ee50 GN: aix port along with linux_s390x, linux_ppc64 and linux_ppc64le support. > 4a4589fc memory-infra: Start disentangling tracing from memory-infra > 7fd3f671 Add curly brackets to list of characters that gn needs to escape > ca2ec763 Improvements to uses of base::SmallMap > ddb3babc Use $root:default as a "default" rule > > TBR=brettw@chromium.org > > Review-Url: https://codereview.chromium.org/2953643004 > Cr-Commit-Position: refs/heads/master@{#481774} > Committed: https://chromium.googlesource.com/chromium/src/+/3391d2ce4059ebe801dd8310d13d8dc59293600e TBR=brettw@chromium.org,dpranke@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review-Url: https://codereview.chromium.org/2956623002 Cr-Commit-Position: refs/heads/master@{#481839}
-