- 20 Nov, 2017 16 commits
-
-
Yoshifumi Inoue authored
This patch makes |LayoutObject::EnclosingNGBlockFlow()| to return |nullptr| if LayoutNG runtime feature enabled without calling |EnclosingBox())|, which requires traversing ancestors, for ease of writing LayoutNG enabled code and improving readability. Before this patch, we should write: if (RuntimeEnabledFeatures::LayoutNGEnabled()) { if (LayoutBlock* block_flow = EnclosingNGBlockFlow()) { ... code for LayoutNG return; } } ... code for legacy layout After this patch, we can write: if (LayoutBlock* block_flow = EnclosingNGBlockFlow()) { ... code for LayoutNG return; } ... code for legacy layout } This patch also changes |LayoutInline::DirtyLinesFromChangedChild()| as demonstration of shorter code and correctness of |EnclosingNGBlockFlow()| change. This patch is a preparation of the patch[1]. [1] http://crrev.com/c/768599: [LayoutNG] Make LayoutInline::LinesBoundingBox() to work with fragments Change-Id: Ic36f84d3f5a1e65ac432ff0df65fe2449d8830a9 Reviewed-on: https://chromium-review.googlesource.com/776413Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#517754}
-
oka@chromium.org authored
The new demo app uses chromeosInfoPrivate API (only) to get the board name. BUG=782139 Change-Id: I92504073044d3b0f2b963d0acdbb4a8d67a2cd7b Reviewed-on: https://chromium-review.googlesource.com/771450Reviewed-by:
Toni Barzic <tbarzic@chromium.org> Reviewed-by:
Greg Levin <glevin@chromium.org> Commit-Queue: Keigo Oka <oka@chromium.org> Cr-Commit-Position: refs/heads/master@{#517753}
-
Samuel Huang authored
Previously Supersize archive for binaries linked with LLD (no LTO) did not support string literals, and required '--no-string-literals' to avoid triggering assert. This CL fixes this this by adding preliminary support for merged strings. Wrinkles: - LLD .map files does not discern string literals from data literals (and testing align=1 seems insufficient), so we count everything as string literals for now. - llvm-readobj (AKA llvm-readelf)'s dump for .a files is missing 'File: libray.a(file.o)' output. For now we work around this by using regular readelf instead. Bug: 723798 Change-Id: Ic0c9a48dfd9ab157ed19471127a5216ee98b8d65 Reviewed-on: https://chromium-review.googlesource.com/777441 Commit-Queue: Samuel Huang <huangs@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#517752}
-
Vasilii Sukhanov authored
It was caused by dereferencing an invalid URL during parsing. Bug: 770734 Change-Id: I4fedd3f310aaf7e1e1d2384aa64939d46b8b2a5a Reviewed-on: https://chromium-review.googlesource.com/773902 Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#517751}
-
Takeshi Yoshino authored
This reverts commit 26bf6f9f. Reason for revert: See https://bugs.chromium.org/p/chromium/issues/detail?id=722928#c52 Original change's description: > Adjust RenderFrameHostManagerTest to use mojo input. > > SetFocus for non-proxy frames are sent input message over mojo. > RenderFrameProxyHost based messages are still sent via > InputMsg_SetFocus chrome IPC since there is no widget input handler > for these situations. > > In order to grab the mojo input message we are required to subclass > the RenderWidgetHostImpl to be able to provide a mock interface. > > BUG=722928 > > Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation > Change-Id: Ieb34b0e1948583c433891edb9bfc5618b03952ad > Reviewed-on: https://chromium-review.googlesource.com/762156 > Commit-Queue: Dave Tapuska <dtapuska@chromium.org> > Reviewed-by: Nick Carter <nick@chromium.org> > Cr-Commit-Position: refs/heads/master@{#517505} TBR=creis@chromium.org,nick@chromium.org,dtapuska@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 722928 Change-Id: Iec95771149743822ba653dc6d1c5125abf0aed19 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation Reviewed-on: https://chromium-review.googlesource.com/778619Reviewed-by:
Takeshi Yoshino <tyoshino@chromium.org> Commit-Queue: Takeshi Yoshino <tyoshino@chromium.org> Cr-Commit-Position: refs/heads/master@{#517750}
-
Takeshi Yoshino authored
Bug: 674329 Change-Id: Ia815eb26487c09b69dabf61db018eb075c6b19e1 Reviewed-on: https://chromium-review.googlesource.com/773759 Commit-Queue: Takeshi Yoshino <tyoshino@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#517749}
-
Bugs Nash authored
This is preparation for moving generated style builder methods to property class header files for properties that use the 'border-image-modifier' template. These style buider methods are unique to each property and therefore require separate property classes. Created new property classes for the following previously grouped properties: - WebkitMaskBoxImageWidth - WebkitMaskBoxImageSlice - WebkitMaskBoxImageRepeats - WebkitMaskBoxImageOutsets Bug: 751354 Change-Id: Iaf2f782086b13b4f4d84a3e3f16890aa264badd2 Reviewed-on: https://chromium-review.googlesource.com/775913Reviewed-by:
nainar <nainar@chromium.org> Reviewed-by:
meade_UTC10 <meade@chromium.org> Commit-Queue: meade_UTC10 <meade@chromium.org> Commit-Queue: Bugs Nash <bugsnash@chromium.org> Cr-Commit-Position: refs/heads/master@{#517748}
-
Blake O'Hare authored
Currently the callback will run immediately at the end of the function when RespondNow is encountered. There's still work to pass the callback through to the KeyboardController animation. Bug: Change-Id: Ie732ce933987b1cfb2303e1e3e1c67961ee112c4 Reviewed-on: https://chromium-review.googlesource.com/776296Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Reviewed-by:
Toni Barzic <tbarzic@chromium.org> Commit-Queue: Blake O'Hare <blakeo@chromium.org> Cr-Commit-Position: refs/heads/master@{#517747}
-
Zhongyi Shi authored
this in particular controls migration with platform notification. Bug: 774622 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I410bcc3f5ee0280465b3c592cbf81cb0fea15c27 Reviewed-on: https://chromium-review.googlesource.com/776331 Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
Misha Efimov <mef@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#517746}
-
Maxim Podgorodskiy authored
On mac_views_browser fix bugs: 1. Return focus to location_bar throught "TAB"(key) pressing. 2. Saving focus on tabs(in tab_strip_model) swithing. By handle associated methods in ChromeWebContentsViewDelegateViewsMac. Make all focus changes in WebContentsView: 1. Move FocusThroughTabTraversal realization from WebContentsImpl to WebContentsView. 2. Remove SetInitialFocus realizaton from WebContentsViewDelegate. Reset stored focused view on any web_contens focus changing. R=tapted@chromium.org Bug: 782715 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation Change-Id: I1ec95b655f7b5ee52fcc3a8cfea617a1ccab6f02 Reviewed-on: https://chromium-review.googlesource.com/758401Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#517745}
-
Peter Kotwicz authored
This CL: - Plumbs the version of EmbeddedTestServer::GetURL() which takes a host name to Java - Switches WebappNavigationTests from navigating to live www.google.com to navigating to a page hosted on the test server. Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I28bf48914d77acd7033ee858fc7794da4875bc6d Reviewed-on: https://chromium-review.googlesource.com/771539Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#517744}
-
Daichi Hirono authored
Seat is corresponding to wl_saet and will be used to synchronize wl_data_device#selection and wl_keyboard#enter events Bug: 773978 Change-Id: Iaca10177f95aebac3822e6e534b9e640852e4ead Reviewed-on: https://chromium-review.googlesource.com/770453Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Reviewed-by:
David Reveman <reveman@chromium.org> Commit-Queue: Daichi Hirono <hirono@chromium.org> Cr-Commit-Position: refs/heads/master@{#517743}
-
Ben Wells authored
This was only used for plugin settings, which are not needed any more. Bug: 754178 Change-Id: I24a9d1d08fd5a00fca088ed7ac212148af6c30e0 Reviewed-on: https://chromium-review.googlesource.com/773898 Commit-Queue: Ben Wells <benwells@chromium.org> Reviewed-by:
Raymes Khoury <raymes@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#517742}
-
Raymes Khoury authored
Records creation of the broker resource and calls to the Connect function. Bug: 756138 Change-Id: Ib5624a6469123e156677d75d7dfe59c5b3a70677 Reviewed-on: https://chromium-review.googlesource.com/773919Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Raymes Khoury <raymes@chromium.org> Cr-Commit-Position: refs/heads/master@{#517741}
-
Robert Sesek authored
This will replace the base/debug/crash_logging.h interface with an API that is based off Crashpad's Annotations (https://crbug.com/crashpad/192). Platforms that use Crashpad for crash reporting will indirectly use the new Annotation API. Platforms still using Breakpad are provided a source-compatible API that stores the data in the old NonAllocatingMap/ SimpleStringDictionary. The InitializedArray template is courtesy of sdy@chromium.org. Bug: 598854 Change-Id: Ic1b13ed9b3d504a1f90e119fa816d74fe3bdbff5 Reviewed-on: https://chromium-review.googlesource.com/757637Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#517740}
-
Xiaocheng Hu authored
Since offset mapping must work with inline painting enabled, its unit tests must also work. This patch parameterizes the unit tests to verify this. Bug: 699017 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: Ifcb03aa1992498b973e2cf9e59e136be0e93fe63 Reviewed-on: https://chromium-review.googlesource.com/777724Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#517739}
-
- 19 Nov, 2017 14 commits
-
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/cbcb0a12ad00..f9ec4707ee13 $ git log cbcb0a12a..f9ec4707e --date=short --no-merges --format='%ad %ae %s' 2017-11-19 bsalomon Exclude tools/gpu/atlastext from public.bzl Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=herb@chromium.org Change-Id: I1ebf18c0681b072194e610befade3ab920d4dabb Reviewed-on: https://chromium-review.googlesource.com/777412Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#517738}
-
Zhongyi Shi authored
packet on new path. The manager will send out a new connectivity probing packet if there is no response from the server on the probed path. The manager will retry after a silent period from the previous sent event with exponential backoff. 1 unit timeout is the smaller of 2 smoothed rtt from old path, or 600ms. Bug: 774622 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I623b8a5aa8da6d553ca16d9f67655d4a32a4a1c9 Reviewed-on: https://chromium-review.googlesource.com/774299 Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#517737}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/b07b06e14819..cbcb0a12ad00 $ git log b07b06e14..cbcb0a12a --date=short --no-merges --format='%ad %ae %s' 2017-11-19 bsalomon Revert "Revert "Add Atlas Text interface for rendering SDF glyphs."" Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=herb@chromium.org Change-Id: I891903e85c32119e0dae3218a40662db727fb616 Reviewed-on: https://chromium-review.googlesource.com/778114Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#517736}
-
Mathieu Perreault authored
Move initialization of members to .h too. Bug: None Test: Existing Change-Id: I76924652c98fecb97e04a3e5a51a97688a9ae5f5 Reviewed-on: https://chromium-review.googlesource.com/777507 Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#517735}
-
Mike West authored
Basically copy-pasting from Anne's suggestions at https://github.com/whatwg/html/pull/2373#issuecomment-332503536 Bug: 680419 Change-Id: I9fee18d46dc00ff3ec8ec90f3d8acd80ab015622 Reviewed-on: https://chromium-review.googlesource.com/771151Reviewed-by:
Andy Paicu <andypaicu@chromium.org> Commit-Queue: Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#517734}
-
Ian Vollick authored
This reverts commit 14d631ca. Reason for revert: speculative revert to address launch issue on Windows Original change's description: > Enable OpenVR devices behind a runtime flag on Windows > > BUG=782445 > > Change-Id: Iec695a4db2bf2851f8f23b2c8ab1568a5bbfa588 > Reviewed-on: https://chromium-review.googlesource.com/757859 > Reviewed-by: Brandon Jones <bajones@chromium.org> > Reviewed-by: Michael Thiessen <mthiesse@chromium.org> > Reviewed-by: David Dorwin <ddorwin@chromium.org> > Commit-Queue: Bill Orr <billorr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#517684} TBR=ddorwin@chromium.org,mthiesse@chromium.org,bajones@chromium.org,billorr@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 782445 Change-Id: Ib344cc9763d822ebe5ee47b33e751270b6a9e489 Reviewed-on: https://chromium-review.googlesource.com/777858Reviewed-by:
Ian Vollick <vollick@chromium.org> Commit-Queue: Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#517733}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/700d93e9..f4f2b219 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I2ca69d1ea94e462a46fcecf8633d5a8f84a14c77 Reviewed-on: https://chromium-review.googlesource.com/778144Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#517732}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/df8408836be0..b07b06e14819 $ git log df8408836..b07b06e14 --date=short --no-merges --format='%ad %ae %s' 2017-11-18 egdaniel Fix assert in blink chromeos 2017-11-18 angle-deps-roller Roll skia/third_party/externals/angle2/ 90ed1e497..dc7bffd06 (1 commit) 2017-11-17 egdaniel Revert "Revert "Revert "Revert "Revert "Revert "Add private grpixelconfigs for alpha_8 and alpha_half"""""" 2017-11-18 egdaniel Revert "Add Atlas Text interface for rendering SDF glyphs." 2017-11-18 angle-deps-roller Roll skia/third_party/externals/angle2/ c622833c5..90ed1e497 (1 commit) Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=herb@chromium.org Change-Id: I4d89aeb9a0161a690fe759f083d6c76ed57b09dd Reviewed-on: https://chromium-review.googlesource.com/777810Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#517731}
-
Peter K. Lee authored
Only one of two calls to decisionHandler was converted to async in http://crrev/c/773570. This changes the other call. Bug: 774736 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ie72c6efc42e5921eae8983d01f4be29fd3934d98 Reviewed-on: https://chromium-review.googlesource.com/777400Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Peter Lee <pkl@chromium.org> Cr-Commit-Position: refs/heads/master@{#517730}
-
chrome-release-bot authored
TBR=govind@chromium.org Change-Id: I3dfc18ff22d4cfcef352641c20fbcd0c46907cbf Reviewed-on: https://chromium-review.googlesource.com/777928Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#517729}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/49b87e46..700d93e9 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I97fcd18d5363abda60c3d1e1c9525bf27d19f808 Reviewed-on: https://chromium-review.googlesource.com/778301Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#517728}
-
Peter Lee authored
This reverts commit beecf799. Reason for revert: The following tests from ios_internal_chrome_external_url_egtests are broken: ExternalURLSSLTestCase/testReloadInterstitial ExternalURLSSLTestCase/testGoBackFromInterstitialUsingInterstitialButton ExternalURLSSLTestCase/testLoadNTPAfterDontProceed ExternalURLSSLTestCase/testAcceptingBadSSLCert ExternalURLSSLTestCase/testRememberingAcceptUserDecision ExternalURLSSLTestCase/testGoBackFromInterstitialUsingToolbarButton ExternalURLSSLTestCase/testHostnameMismatchInterstitial stdout from bot run here: https://logs.chromium.org/v/?s=chrome%2Fbb%2Finternal.bling.main%2Fiphone11-simulator-x64%2F1975%2F%2B%2Frecipes%2Fsteps%2Fios_internal_chrome_external_url_egtests__iPhone_5s_iOS_11.0__on_Mac%2F0%2Fstdout Original change's description: > Enable iOS Captive Portal feature by default. > > Bug: 750228 > Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs > Change-Id: I0fa138e855d71ac256759d75f3e84d390cd2c896 > Reviewed-on: https://chromium-review.googlesource.com/777468 > Reviewed-by: Eugene But <eugenebut@chromium.org> > Commit-Queue: Mike Dougherty <michaeldo@chromium.org> > Cr-Commit-Position: refs/heads/master@{#517579} TBR=eugenebut@chromium.org,michaeldo@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 750228 Change-Id: Ic15218338b16eede6572cbe157d982942de0a625 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/778283Reviewed-by:
Peter Lee <pkl@chromium.org> Commit-Queue: Peter Lee <pkl@chromium.org> Cr-Commit-Position: refs/heads/master@{#517727}
-
John Budorick authored
This reverts commit e0b4355f. Reason for revert: Breaks chrome_public_test_apk in debug builds. Will explain more in crbug.com/786743. Original change's description: > Add Android OOP HP end-to-end tests. > > This CL has three components: > 1) The bulk of the logic in OOP HP was refactored into ProfilingTestDriver. > 2) Adds a java instrumentation test, along with a JNI shim that forwards into > ProfilingTestDriver. > 3) Creates a new apk: chrome_public_apk_for_test that contains the same > content as chrome_public_apk, as well as native files needed for (2). > chrome_public_apk_test now targets chrome_public_apk_for_test instead of > chrome_public_apk. > > Other ideas, discarded: > * Originally, I attempted to make the browser_tests target runnable on > Android. The primary problem is that native test harness cannot fork > or spawn processes. This is difficult to solve. > > More details on each of the components: > (1) ProfilingTestDriver > * The TracingController test was migrated to use ProfilingTestDriver, but the > write-to-file test was left as-is. The latter behavior will likely be phased > out, but I'll clean that up in a future CL. > * gtest isn't supported for Android instrumentation tests. ProfilingTestDriver > has a single function RunTest that returns a 'bool' indicating success. On > failure, the class uses LOG(ERROR) to print the nature of the error. This will > cause the error to be printed out on browser_test error. On instrumentation > test failure, the error will be forwarded to logcat, which is available on all > infra bot test runs. > (2) Instrumentation test > * For now, I only added a single test for the "browser" mode. Furthermore, I'm > only testing the start with command-line path. > (3) New apk > * libchromefortest is a new shared library that contains all content from > libchrome, but also contains native sources for the JNI shim. > * chrome_public_apk_for_test is a new apk that contains all content from > chrome_public_apk, but uses a single shared library libchromefortest rather > than libchrome. This also contains java sources for the JNI shim. > * There is no way to just add a second shared library to chrome_public_apk > that just contains the native sources from the JNI shim without causing ODR > issues. > * chrome_public_test_apk now has apk_under_test = chrome_public_apk_for_test. > * There is no way to add native JNI sources as a shared library to > chrome_public_test_apk without causing ODR issues. > > Finally, this CL drastically increases the timeout to wait for native > initialization. The previous timeout was 2 * > CriteriaHelper.DEFAULT_MAX_TIME_TO_POLL, which flakily failed for this test. > This suggests that this step/timeout is generally flaky. I increased the timeout > to 20 * CriteriaHelper.DEFAULT_MAX_TIME_TO_POLL. > > Bug: 753218 > Change-Id: Ic224b7314fff57f1770a4048aa5753f54e040b55 > Reviewed-on: https://chromium-review.googlesource.com/770148 > Commit-Queue: Erik Chen <erikchen@chromium.org> > Reviewed-by: John Budorick <jbudorick@chromium.org> > Reviewed-by: Brett Wilson <brettw@chromium.org> > Cr-Commit-Position: refs/heads/master@{#517541} TBR=brettw@chromium.org,erikchen@chromium.org,jbudorick@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 753218 Change-Id: I0ce13ddac560fc685bce8798a59d2e1c784e08af Reviewed-on: https://chromium-review.googlesource.com/778339Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#517726}
-
Aleks Totic authored
This reverts commit 4e68cd40. Reason for revert: Couple of outstanding bugs. Sorry I did not get to code review this before landing. Original change's description: > [layout test results.html] Small UI tweaks and tiny bug fixes > > - When click the toolbar to select a view during animation, show the > view for 1 second. This is convenient to briefly view a specific view > without stopping the animation. Previously the time showing the clicked > view was random. > > - Let GUI.getExpectation(el) handle cases that the el is under > result-frame, so that keyboard navigation still works when the focus > is under result-frame (e.g. after the toolbar or the image result is > clicked). > > - Let GUI.activeExpectation() return the open expectation if no > expectation line can be found from the focused element, so that keyboard > navigation can be based on the open expectation if the focus is neither > under the expectation line nor result-frame. > > - Correct total count. Previously the total count didn't include expected > failures, skipped and wontfix tests, etc. > > Change-Id: Ibc4b697c52a7b5d37f0ebbfb5c925cc478f15f06 > Reviewed-on: https://chromium-review.googlesource.com/777469 > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > Reviewed-by: Quinten Yearsley <qyearsley@chromium.org> > Cr-Commit-Position: refs/heads/master@{#517674} TBR=wangxianzhu@chromium.org,qyearsley@chromium.org,atotic@chromium.org Change-Id: I214a79799ab0c5744c00c0cbd85f1ecd7978159f No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/777808Reviewed-by:
Aleks Totic <atotic@chromium.org> Commit-Queue: Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#517725}
-
- 18 Nov, 2017 10 commits
-
-
Mohamad Ahmadi authored
Bug: 738938 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I75950dc5af48af4dcb8b26db9c093cc8837034fd Reviewed-on: https://chromium-review.googlesource.com/776035 Commit-Queue: Moe Ahmadi (OOO until Nov. 27) <mahmadi@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#517724}
-
Yuta Kitamura authored
This is a reland of d9e35229 Original change's description: > Move out threading DCHECK from WTF::Function. > > This patch is largely based on tzik's WIP patch: > https://chromium-review.googlesource.com/c/chromium/src/+/742824 > > Bug: 771087 > Change-Id: I20e2eb5ef09911a19e3b268e45ce6187d8edeffa > Reviewed-on: https://chromium-review.googlesource.com/765749 > Commit-Queue: Yuta Kitamura <yutak@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Taiju Tsuiki <tzik@chromium.org> > Cr-Commit-Position: refs/heads/master@{#517030} Bug: 771087 Change-Id: I15731f6d91447796c7082d42ff9d979c9b4e40a3 Reviewed-on: https://chromium-review.googlesource.com/778219Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Yuta Kitamura <yutak@chromium.org> Cr-Commit-Position: refs/heads/master@{#517723}
-
Peter Laurens authored
This tools menu constants header file is moving to a public folder, but has downstream dependencies. This change provides for both the new and old path to reach the header. Bug: 782936 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ia6de01254c025940c827e94216ce09ac82139c64 Reviewed-on: https://chromium-review.googlesource.com/772785Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Peter Laurens <peterlaurens@chromium.org> Cr-Commit-Position: refs/heads/master@{#517722}
-
John Budorick authored
This reverts commit a8671260. TBR=katydek@google.com,dmazzoni@chromium.org Bug: 786621 Change-Id: I5429cafee92658626e826dd998404c3edc25918f Reviewed-on: https://chromium-review.googlesource.com/778131Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#517721}
-
Hans Wennborg authored
This reverts commit cb2b13fb. Reason for revert: It broke the build due to an enhanced warning, e.g. https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Linux%20x64/builds/24153 ../../third_party/ffmpeg/libavcodec/bitstream.c:169:5: error: if statement has empty body [-Werror,-Wempty-body] ff_dlog(NULL, "new table index=%d size=%d\n", table_index, table_size); ^ ../../third_party/ffmpeg/libavutil/internal.h:276:80: note: expanded from macro 'ff_dlog' # define ff_dlog(ctx, ...) do { if (0) av_log(ctx, AV_LOG_DEBUG, __VA_ARGS__); } while (0) I believe this is fixed in a later revision of Clang that our ToT bots had already picked up, which is why I didn't see it. Original change's description: > Roll clang 317263:318575. > > Bug: 782281 > > Change-Id: Ifad82da68a7356bd6463fd9b944f796a5a3f798c > Reviewed-on: https://chromium-review.googlesource.com/777640 > Reviewed-by: Peter Collingbourne <pcc@chromium.org> > Commit-Queue: Hans Wennborg <hans@chromium.org> > Cr-Commit-Position: refs/heads/master@{#517719} TBR=eugenis@chromium.org,hans@chromium.org,rnk@chromium.org,pcc@chromium.org Change-Id: I922f3b1f30b7119fa17d257a1ab29339ac8576ee No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 782281 Reviewed-on: https://chromium-review.googlesource.com/778281Reviewed-by:
Hans Wennborg <hans@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#517720}
-
Hans Wennborg authored
Bug: 782281 Change-Id: Ifad82da68a7356bd6463fd9b944f796a5a3f798c Reviewed-on: https://chromium-review.googlesource.com/777640Reviewed-by:
Peter Collingbourne <pcc@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#517719}
-
Bruce Dawson authored
This reverts commit ab3de2ef. Reason for revert: ODR violation - content::SessionStorageNamespace already exists. Original change's description: > [SessionStorage] Renderer piping & browser stubs for mojofication. > > This change adds a feature flag and the piping to hook up & run a mojo > implementation of SessionStorage. Nothing is implemented yet and all > calls trip a NOTREACHED - this is just the setup for the renderer side > of the feature. > > Bug: 716490 > Change-Id: Id3ad5cf3fa1e27bf7e5ef9369818d94a1a5364d3 > Reviewed-on: https://chromium-review.googlesource.com/767287 > Reviewed-by: Oliver Chang <ochang@chromium.org> > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Reviewed-by: Marijn Kruisselbrink <mek@chromium.org> > Commit-Queue: Daniel Murphy <dmurph@chromium.org> > Cr-Commit-Position: refs/heads/master@{#517619} TBR=dmurph@chromium.org,jam@chromium.org,mek@chromium.org,ochang@chromium.org Change-Id: I51f09c1bc483ec16e3ae038d9117523c788b9442 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 716490 Reviewed-on: https://chromium-review.googlesource.com/777411Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#517718}
-
Jamie Madill authored
Disables breaking tests on Mac and Windows 7. TBR=kbr@chromium.org Bug: 786716, 786717 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I7b547ea97bf357fcce0da4d0e0ff949a78f9565c Reviewed-on: https://chromium-review.googlesource.com/778280 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by:
Jamie Madill <jmadill@chromium.org> Cr-Commit-Position: refs/heads/master@{#517717}
-
depot-tools-roller@chromium.org authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/8762632eb725..ddfead3483f2 $ git log 8762632eb..ddfead348 --date=short --no-merges --format='%ad %ae %s' 2017-11-15 tandrii bot_update: mooore refactor around _git_checkout. 2017-11-17 tandrii bot_update: don't crash badly if there no json outpot. Created with: roll-dep src/third_party/depot_tools The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=phajdan.jr@chromium.org Change-Id: I95f5fc922b282569e6e551a5b66923383d1d0daa Reviewed-on: https://chromium-review.googlesource.com/777486Reviewed-by:
depot-tools-roller . <depot-tools-roller@chromium.org> Commit-Queue: depot-tools-roller . <depot-tools-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#517716}
-
Carlos Knippschild authored
Bug: Change-Id: I41728ba1b17d5020178f7adac7997cc2f0662dbc Reviewed-on: https://chromium-review.googlesource.com/777035Reviewed-by:
Justin Schuh <jschuh@chromium.org> Commit-Queue: Justin Schuh <jschuh@chromium.org> Cr-Commit-Position: refs/heads/master@{#517715}
-