- 27 Nov, 2018 40 commits
-
-
Andrew Luo authored
Bug: 816708 Change-Id: I0477ba7d3c93bef726c9bf0bc9879882ebedbfd9 Reviewed-on: https://chromium-review.googlesource.com/c/1290144Reviewed-by:
Sky Malice <skym@chromium.org> Reviewed-by:
Gang Wu <gangwu@chromium.org> Commit-Queue: Andrew Luo <aluo@chromium.org> Cr-Commit-Position: refs/heads/master@{#611266}
-
Eric Stevenson authored
Change-Id: Iefb439e6437a8589599155097365d9dd9cb17bb3 Reviewed-on: https://chromium-review.googlesource.com/c/1349853 Commit-Queue: Eric Stevenson <estevenson@chromium.org> Reviewed-by:
Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#611265}
-
Vladimir Levin authored
This updates the layout test and some code changes to make those tests pass to be mode 2 tests (ie append after lock). R=chrishtr@chromium.org Bug: 882663 Change-Id: I44554d486c5af0db1c680d5be719d687fd2745d2 Reviewed-on: https://chromium-review.googlesource.com/c/1344263Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#611264}
-
Yaron Friedman authored
P is now being build with SDK code 28 and we're moving to targeting Q. BUG=908821 Change-Id: I316883e0b1bf6cad2157a73a68c0ee567263c543 Reviewed-on: https://chromium-review.googlesource.com/c/1351479Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#611263}
-
Philipp Hancke authored
Firefox does not support addTrack(track). Add a track whereever it makes sense. The addTrack tests itself might rightfully use this. The following grep shows most affected places: git grep addTrack *.html | grep -v , | grep -v "\.\.\." Bug: None Change-Id: Ib225e6d51184c3ccc446ccf93447e2ac7be080c3 Reviewed-on: https://chromium-review.googlesource.com/c/1346394Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Philipp Hancke <philipp.hancke@googlemail.com> Cr-Commit-Position: refs/heads/master@{#611262}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/df4ad0d1e00a..05744b47d94a git log df4ad0d1e00a..05744b47d94a --date=short --no-merges --format='%ad %ae %s' 2018-11-27 lalitm@google.com trace_processor: fix bugs with Chrome scoped slices Created with: gclient setdep -r src/third_party/perfetto@05744b47d94a The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I01252b69b066f0534de69f1fb4b9936d56bf6dce Reviewed-on: https://chromium-review.googlesource.com/c/1352242Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#611261}
-
Aaron Leventhal authored
Do not suppress events on descendants of leaf nodes on Android, otherwise necessary events are not fired. This is because Android treats a lot more nodes as leaves. Bug: 907866 Change-Id: If93d55747249d9084c57a091647f8d4860df6d3c Reviewed-on: https://chromium-review.googlesource.com/c/1351494Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#611260}
-
Shuotao Gao authored
This reverts commit 03982f12. Reason for revert: Caused compile failure on code coverage bot https://bugs.chromium.org/p/chromium/issues/detail?id=908937 Original change's description: > base: Make TraceEvent a movable class. > > This is a small cleanup of the TraceEvent class performed > which is part of a larget bug allowing cleaning up and > reducing the generated machine code for TRACE_EVENTXXX() > macro calls (see related bug). > > A first CL to perform this refactor was submitted as [1], but > later reverted because it made some tests fail mysteriously > (see http://crbug.com/899813). So the original CL was split into > several independent ones. > > A first CL was submitted as [2], which actually fixed some > potential dangling pointer issues that were created from the > Initialize() and MoveFrom() methods. > > This second CL removes this methods by making TraceEvent a > proper C++11 movable type, which should prevent (or at least > make it more difficult) introducing invalid states for its > instances. The goal is to see if this introduces new unexpected > test failures (which would indicate that there are still invalid > instance states used in the code base). > > The third CL is [3] and re-introduces the TraceArguments helper > class on top of this one. > > [1] https://chromium-review.googlesource.com/c/chromium/src/+/1318919 > [2] https://chromium-review.googlesource.com/c/chromium/src/+/1340308 > [3] https://chromium-review.googlesource.com/c/chromium/src/+/1318919 > > BUG=898794 > R=primiano@chromium.org,oysteine@chromium.org,alexilin@chromium.org,chiniforooshan@chromium.org > > Change-Id: I2b36885e2485d23cca199c48b2bd07d5745b00c5 > Reviewed-on: https://chromium-review.googlesource.com/c/1346305 > Commit-Queue: David Turner <digit@chromium.org> > Reviewed-by: Ehsan Chiniforooshan <chiniforooshan@chromium.org> > Reviewed-by: Alexandr Ilin <alexilin@chromium.org> > Reviewed-by: oysteine <oysteine@chromium.org> > Cr-Commit-Position: refs/heads/master@{#611185} TBR=digit@chromium.org,primiano@chromium.org,chiniforooshan@chromium.org,oysteine@chromium.org,alexilin@chromium.org Change-Id: I73d85745e3b67cbcecddd25cb78a8e22ba031965 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 898794 Reviewed-on: https://chromium-review.googlesource.com/c/1351557Reviewed-by:
Shuotao Gao <stgao@chromium.org> Commit-Queue: Shuotao Gao <stgao@chromium.org> Cr-Commit-Position: refs/heads/master@{#611259}
-
Fredrik Söderquist authored
Don't create a Pattern just to have it create a PaintShader - just create the PaintShader directly. Change-Id: I85b96ed9becea31e93d62191baac263f08f53f91 Reviewed-on: https://chromium-review.googlesource.com/c/1352258 Commit-Queue: Fredrik Söderquist <fs@opera.com> Commit-Queue: Florin Malita <fmalita@chromium.org> Reviewed-by:
Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/master@{#611258}
-
Eric Willigers authored
Test parsing, serialiation and computed values for properties defined in CSS Fragmentation Module Level 3 https://drafts.csswg.org/css-break/ Blink has expected failures for keywords relating to CSS Regions. Change-Id: Ie5a930ba2d805c7bd45aa84c293bc8ff5922da98 Reviewed-on: https://chromium-review.googlesource.com/c/1351190 Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#611257}
-
David Benjamin authored
https://boringssl.googlesource.com/boringssl/+log/f241a59dcca617c5b9d9880a8a9fd92996a654be..6965d25602754bc419c5f757d008ba1f4da49ae4 The following commits have Chromium bugs associated: 4f746a907 Move ARM cpuinfo functions to the header. 09f5a040d No longer set CQ-Verified label on CQ success/failure. This additionally includes some manual follow-up tweaks to BUILD.gn for 4f746a907. Bug: 906576, 907115 Change-Id: If066a9fdd873edbad773cc8db7a8aadd679f269b Reviewed-on: https://chromium-review.googlesource.com/c/1347096 Commit-Queue: David Benjamin <davidben@chromium.org> Reviewed-by:
Steven Valdez <svaldez@chromium.org> Cr-Commit-Position: refs/heads/master@{#611256}
-
Leszek Swirski authored
Check for an edge case where a ScriptResource may have a null resource buffer without having been loaded. As part of this, extract the inspector's logic for accessing a ScriptResource's text into the ScriptResource, as it relies on ScriptResource internal state. Bug: 865098 Bug: 899217 Change-Id: I5ceb6f105e21e4eeb7ce5f9bc82c7d7c7f7f6aad Reviewed-on: https://chromium-review.googlesource.com/c/1352183 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#611255}
-
Eric Stevenson authored
For secondary abis the thinlto-cache directory is a sub-directory of the secondary abi directory. Change-Id: I1a87df0aec52f0550efa203be3ff0abb00a770d3 Reviewed-on: https://chromium-review.googlesource.com/c/1349852Reviewed-by:
-
Roberto Carrillo authored
R=stgao,liaoyuke,jbudorick Change-Id: Ib6b8e78e90511cd5699194adba1414fbbf8985e3 Reviewed-on: https://chromium-review.googlesource.com/c/1350884Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Roberto Carrillo <robertocn@chromium.org> Cr-Commit-Position: refs/heads/master@{#611253}
-
Scott Violet authored
AFAICT gpu_process_transport_factory is not compiled on android, (see https://chromium.googlesource.com/chromium/src/+/master/content/browser/BUILD.gn#2454 ), yet it has some ifdefs for android. This removes the ifdefs as well as moving an include to match where gpu_process_transport_factory is compiled. BUG=none TEST=none Change-Id: I005fb4db009b36383079faf2c41bb19d89e20e84 Reviewed-on: https://chromium-review.googlesource.com/c/1350981Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#611252}
-
Jered Gray authored
The task runner being used in PreviewsOptimizationGuide was UI, but it was named IO. The name has been updated to reflect the actual task runner passed in. Change-Id: Iab6e07c148ca087194d9b876dff4f4f5b285a153 Reviewed-on: https://chromium-review.googlesource.com/c/1338727Reviewed-by:
Doug Arnett <dougarnett@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Jered Gray <jegray@chromium.org> Cr-Commit-Position: refs/heads/master@{#611251}
-
Henrique Nakashima authored
This is a reland of a061c829 Reverted due to being a suspect in crbug.com/906242, but after reverting the bug persists and was bisected to another CL. Original change's description: > Flatten UpdateMetricsUsagePrefs - skip Metrics and Reporting service. > > UpdateMetricsUsagePrefs() is a chain of calls: > - ChromeDataUseMeasurement::UpdateDataUseToMetricsService() > -> UpdateMetricsUsagePrefs() > -> MetricsService::UpdateMetricsUsagePrefs() > -> ReportingService::UpdateMetricsUsagePrefs() > -> DataUseTracker::UpdateMetricsUsagePrefs() > > It can be reduced to: > - ChromeDataUseMeasurement::UpdateDataUseToMetricsService() > -> UpdateMetricsUsagePrefs() > -> DataUseTracker::UpdateMetricsUsagePrefs() > > This removes the dependency from ChromeDataUseMeasurement to > MetricsService and ReportingService. > > Bug: 902791 > Change-Id: I38a6d22d1ff823134c79bc342ea32be0f89cda77 > Reviewed-on: https://chromium-review.googlesource.com/c/1334267 > Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> > Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> > Reviewed-by: rajendrant <rajendrant@chromium.org> > Cr-Commit-Position: refs/heads/master@{#608567} Bug: 902791 Change-Id: I27abaac1d265e63ae5a921ab2839a77ae8582720 Reviewed-on: https://chromium-review.googlesource.com/c/1348249Reviewed-by:
rajendrant <rajendrant@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#611250}
-
Christos Froussios authored
Subprocesses set their encryption key by getting it from the browser with GetRawEncryptionKey and setting it locally with SetRawEncryptionKey Since GetRawEncryptionKey may return an empty string (e.g. because the lookup into Keychain failed), SetRawEncryptionKey should not expect that the key is never empty. Bug: 908431 Change-Id: Id9eece1bdf4492778c18178efc97380b800f5034 Reviewed-on: https://chromium-review.googlesource.com/c/1350915 Commit-Queue: Christos Froussios <cfroussios@chromium.org> Reviewed-by:
Chris Mumford <cmumford@chromium.org> Cr-Commit-Position: refs/heads/master@{#611249}
-
Mike Dougherty authored
This CL removes macro usage from /ios/chrome/browser/webui. This CL was uploaded by git cl split. R=eugenebut@chromium.org Bug: 589840 Change-Id: I047edb54ce7991b4aefd3af99a89affaa53f7a56 Reviewed-on: https://chromium-review.googlesource.com/c/1351956Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#611248}
-
Daniel Nicoara authored
When creating a video frame for the video hole, the compositor creates a TextureDrawQuad. This is generic enough that the overlay strategy can't distinguish between a video frame and a EXO texture. Add a hint to the TextureDrawQuad that the video frame requires an overlay and use that to differentiate the video hole quad. TBR=kaznacheev@chromium.org hole. correctly. Bug: 899246 Test: Ran on device and ensured EXO content doesn't trigger the video Test: Ran updated viz_unittests to verify new strategy filters content Change-Id: I4e275550efa287fd2b491d31028a1dead9fbc053 Reviewed-on: https://chromium-review.googlesource.com/c/1316088 Commit-Queue: Daniel Nicoara <dnicoara@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Maggie Chen <magchen@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Reviewed-by:
enne <enne@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#611247}
-
Scott Violet authored
This reverts commit e45a6ef0. Reason for revert: This triggers DCHECKs on device, so reverting. Here's the stack: [13255:13255:1127/111259.548287:FATAL:tray_bluetooth_helper.cc(50)] Check failed: !timer_.IsRunning(). #0 0x5abde8c02cef base::debug::StackTrace::StackTrace() #1 0x5abde8b586cb logging::LogMessage::~LogMessage() #2 0x5abdeb50f0a5 ash::TrayBluetoothHelper::StartOrStopRefreshingDeviceList() #3 0x5abde9b4ac48 device::BluetoothAdapter::NotifyAdapterPoweredChanged() #4 0x5abde9b55a5f bluez::BluetoothAdapterBlueZ::SetAdapter() #5 0x5abde9b7d3d5 bluez::BluetoothAdapterClientImpl::ObjectAdded() #6 0x5abde9a471be dbus::ObjectManager::AddInterface() #7 0x5abde9a46d2e dbus::ObjectManager::UpdateObject() #8 0x5abde9a457fb dbus::ObjectManager::OnGetManagedObjects() #9 0x5abde505efdc _ZN4base8internal7InvokerINS0_9BindStateIMN8chromeos14BiodClientImplEFvPN4dbus6SignalEEJNS_7WeakPtrIS4_EEEEEFvS7_EE3RunEPNS0_13BindStateBaseES7_ #10 0x5abde9a486bf dbus::ObjectProxy::OnCallMethod() #11 0x5abde9a4cb43 _ZN4base8internal7InvokerINS0_9BindStateIMN4dbus11ObjectProxyEFvRKNSt3__112basic_stringIcNS5_11char_traitsIcEENS5_9allocatorIcEEEESD_NS_12OnceCallbackIFvPNS3_8ResponseEEEESG_PNS3_13ErrorResponseEEJ13scoped_refptrIS4_ESB_SB_SI_EEEFvSG_SK_EE7RunOnceEPNS0_13BindStateBaseESG_SK_ #12 0x5abde9a49074 dbus::ObjectProxy::RunResponseOrErrorCallback() #13 0x5abde9a4db5e _ZN4base8internal13FunctorTraitsIMN4dbus11ObjectProxyEFvNS3_19ReplyCallbackHolderENS_9TimeTicksEPNS2_8ResponseEPNS2_13ErrorResponseEEvE6InvokeISB_13scoped_refptrIS3_EJS4_S5_S7_S9_EEEvT_OT0_DpOT1_ #14 0x5abde9a4da80 _ZN4base8internal7InvokerINS0_9BindStateIMN4dbus11ObjectProxyEFvNS4_19ReplyCallbackHolderENS_9TimeTicksEPNS3_8ResponseEPNS3_13ErrorResponseEEJ13scoped_refptrIS4_ES5_S6_S8_SA_EEEFvvEE7RunOnceEPNS0_13BindStateBaseE #15 0x5abde8bd218b base::(anonymous namespace)::PostTaskAndReplyRelay::RunTaskAndPostReply() #16 0x5abde8bd260b _ZN4base8internal7InvokerINS0_9BindStateIPFvNS_12_GLOBAL__N_121PostTaskAndReplyRelayEEJS4_EEEFvvEE7RunOnceEPNS0_13BindStateBaseE #17 0x5abde8c28597 base::debug::TaskAnnotator::RunTask() #18 0x5abde8b6242f base::MessageLoopImpl::RunTask() #19 0x5abde8b62ae2 base::MessageLoopImpl::DoWork() #20 0x5abde8c24189 base::MessagePumpLibevent::Run() #21 0x5abde8b61f05 base::MessageLoopImpl::Run() #22 0x5abde8b8c576 base::RunLoop::Run() #23 0x5abde86a22e5 ChromeBrowserMainParts::MainMessageLoopRun() #24 0x5abde5eebb04 content::BrowserMainLoop::RunMainMessageLoopParts() #25 0x5abde5eee503 content::BrowserMainRunnerImpl::Run() #26 0x5abde5ee828f content::BrowserMain() Original change's description: > bluetooth: Query for devices every second in TrayBluetoothHelper > > Before TrayBluetoothHelper would get notified of any changes to devices. > This caused problems in busy environments because TrayBluetoothHelper > would get notified hundreds or even thousands of times per second of > devices changes. > > This CL changes to a "pull" pattern where TrayBluetootHelper queries > for devices every second. The devices are then cached so that clients > of TrayBluetoothHelper can access them synchronously. > > TrayBluetoothHelper queries for devices as long as the state is > kPoweredOn. If the state changes, the device list is cleared. > > Bug: 882346 > > TEST=The following actions should be performed: > > 1. Turn bluetooth on and off in system tray. > 2. Open device list in system menu. > 3. Connect to a device. > 4. See that the pod feature button in the system tray indicates a > device is connected when connected to a device. > > Change-Id: Id9028546a627f260527aa737f51c032f74a447ec > Reviewed-on: https://chromium-review.googlesource.com/c/1347638 > Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> > Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org> > Cr-Commit-Position: refs/heads/master@{#611069} TBR=ortuno@chromium.org,tetsui@chromium.org Change-Id: I5b5ca3f227ab7616321047b3a8ade17bfa30b29a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 882346 Reviewed-on: https://chromium-review.googlesource.com/c/1352340Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#611246}
-
David Bokan authored
If we have a candidate implicit root scroller, we should only promote it if it doesn't have a scrollable ancestor. The reason for this is that we end scroll chaining at the root scroller. This is necessary as the root scroller consumes all scroll in the form of overscroll effects. A (user) scrollable ancestor would be broken in this case, as shown in the example on the attached bug. Note: overflow in an ancestor is still allowed, as long as its overflow style is hidden or visible. Bug: 837007 Change-Id: Ied7a9f02eab76c4ea59fced94d0804ba47ef4e4a Reviewed-on: https://chromium-review.googlesource.com/c/1351590Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#611245}
-
Mike Dougherty authored
This CL removes macro usage from /ios/chrome/browser/translate. This CL was uploaded by git cl split. R=toyoshim@chromium.org Bug: 589840 Change-Id: Ia199152845344221db491b895f44ea5a885046f1 Reviewed-on: https://chromium-review.googlesource.com/c/1351080Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/115df409efa1..bd884bbd8385 git log 115df409efa1..bd884bbd8385 --date=short --no-merges --format='%ad %ae %s' 2018-11-27 yueherngl@google.com octopus: add firmware branch builder Created with: gclient setdep -r src/third_party/chromite@bd884bbd8385 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I4ce842c0195caca7a5bba293c2d54fd67526303e Reviewed-on: https://chromium-review.googlesource.com/c/1352240Reviewed-by:
-
Seth Hampson authored
Bug: 874296 Change-Id: I33e79a0641e38b420a23d0ff42933cd26bc0b368 Reviewed-on: https://chromium-review.googlesource.com/c/1341153 Commit-Queue: Seth Hampson <shampson@chromium.org> Reviewed-by:
Steve Anton <steveanton@chromium.org> Cr-Commit-Position: refs/heads/master@{#611242}
-
Charlie Harrison authored
Simple CL which moves more control of the radio group into the actual RadioGroup struct rather than the owning class. Also: - Removes unused |title| member - Constructs radio items using initializer lists. Bug: None Change-Id: I421e42f044a89bd1dd87bb11130d79b18aefe144 Reviewed-on: https://chromium-review.googlesource.com/c/1351504Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#611241}
-
David Bienvenu authored
This CL attempts to handle the unexpected situation we were CHECKING for. The windows native window occlusion finch experiment is causing a lot of check fails with |window_is_moving_| true when we receive a EVENT_SYSTEM_MOVESIZESTART event. I'm unable to reproduce this, but this CL should prevent us from getting stuck in the |window_is_moving_| state while still avoiding calculating occlusion during moves. Also attempt to detect when we've possibly missed an end move event, because we got an unexpected event while we think we're moving, and set |window_is_moving_| to false. I've also moved the setting of |window_is_moving_| to false at the start of UnregisterEventHooks in the unlikely event that UnhookWinEvent is causing the event hook callback to get called reentrantly. Some crash reports show UnregisterEventHooks on the stack, but looking at the same crash dump in VS doesn't show UnregisterEventHooks. Bug: 907365 Change-Id: Iec41dbbe656d0acea0c161b45ec5b7812eb32233 Reviewed-on: https://chromium-review.googlesource.com/c/1348829Reviewed-by:
-
Mike Dougherty authored
This CL removes macro usage from /ios/chrome/browser/web. This CL was uploaded by git cl split. R=eugenebut@chromium.org Bug: 589840 Change-Id: Ide0379a61902c122eb75481ea4902a0b777ee76f Reviewed-on: https://chromium-review.googlesource.com/c/1351078Reviewed-by:
-
Tatiana Buldina authored
Bug: chromedriver:2676 Change-Id: I41dcde8b296c5eacf6a49c6c37faf9de2e8f3202 Reviewed-on: https://chromium-review.googlesource.com/c/1351879Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Tatiana Buldina <buldina@chromium.org> Cr-Commit-Position: refs/heads/master@{#611238}
-
Francois Doray authored
The imprecise logging caused confusion in the interpretaion of at least one user report. Change-Id: I50a80ef6e322072ae9143f11e6e86b314d1fb263 Reviewed-on: https://chromium-review.googlesource.com/c/1349771Reviewed-by:
Cheng-Yu Lee <cylee@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#611237}
-
Sam Maier authored
Bug: 872904 Change-Id: Ia376f6beb1072d46189954decf7696cb980b4639 Reviewed-on: https://chromium-review.googlesource.com/c/1340364Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#611236}
-
Krishna Govind authored
R=cmasso@chromium.org Change-Id: Ida42b8e93e569176ddfdaeeb961d3dd50b4e6fd0 Reviewed-on: https://chromium-review.googlesource.com/c/1352435Reviewed-by:
Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#611235}
-
Peter Boström authored
Avoids having additional high-frequency post tasking for no-op tasks in the background. To keep track of when to stop animating without an AnimationEnded callback, we keep track of the last-drawn animation state. This also has the side effect of allowing us to avoid repainting the loading-progress bar if would paint the same pixels we drew last time. This should avoid a lot of repaints for slow-loading sites. This also ends up fixing backwards-jumping indicators. Probably because the logic for clamping the loading-progress timer got easier. Bug: chromium:907044, chromium:905020, chromium:905452 Change-Id: Ic83748bad83115ef2283c881a89ed65e3d3938ab Reviewed-on: https://chromium-review.googlesource.com/c/1346831Reviewed-by:
Sidney San Martín <sdy@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#611234}
-
Mohamed Amir Yosef authored
Bug: 902349 Change-Id: Ibd685911d52ae19c62b06caf47688abad081d243 Reviewed-on: https://chromium-review.googlesource.com/c/1333760 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#611233}
-
Georges Khalil authored
Change-Id: Icfd4b43ed64252e0530ee033fc06f12186bcc2b6 Reviewed-on: https://chromium-review.googlesource.com/c/1347059Reviewed-by:
Greg Thompson <grt@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: Georges Khalil <georgesak@chromium.org> Cr-Commit-Position: refs/heads/master@{#611232}
-
Sergey Poromov authored
Previously "CorruptPolicyExtensionDetected" was reported every time when policy extension was corrupted even if it's already scheduled to be reinstalled. So it might've lead to multiple "CorruptPolicyExtensionDetected" events per one "CorruptPolicyExtensionResolved" event. Now when new entry is added to |expected_policy_reinstalls_| map, one metric is reported, when removed - another, so it's more 1:1. Change-Id: I2cb4ad2ae043f4ad01d061c8eb63614a24db0a4a Reviewed-on: https://chromium-review.googlesource.com/c/1335604 Commit-Queue: Sergey Poromov <poromov@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#611231}
-
Andrey Lushnikov authored
Start using disk cache directory for default headless profile. Bug: 882431 Change-Id: I1790a58fa2da6cb0fd114897d082e289d7a01bc5 Reviewed-on: https://chromium-review.googlesource.com/c/1350881Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#611230}
-
Mike Dougherty authored
This CL removes macro usage from /ios/chrome/browser/reading_list. This CL was uploaded by git cl split. R=olivierrobin@chromium.org Bug: 589840 Change-Id: Ia0b05a38e3daa883a1ebb3d2255df84d9f30eb45 Reviewed-on: https://chromium-review.googlesource.com/c/1351953Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#611229}
-
Alexei Filippov authored
The current 1024-bit keys do not work with openssl 1.1.1 BUG=907677 Change-Id: I9abce240d09fc0baf6ea567d71f37c48787b3ceb Reviewed-on: https://chromium-review.googlesource.com/c/1347201Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#611228}
-
Kristi Park authored
Move the ripple animation handler to a new animations file, and move common helper functions into a new utils file. This enables us to add ripple animations to the edit custom link dialog buttons. Bug: 874201 Change-Id: I5e3d72bf3fa282faf0068122f1a660e8ad72bab3 Reviewed-on: https://chromium-review.googlesource.com/c/1347776 Commit-Queue: Kristi Park <kristipark@chromium.org> Reviewed-by:
Ramya Nagarajan <ramyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#611227}
-
