- 19 Oct, 2017 40 commits
-
-
Hidehiko Abe authored
Taking two callbacks API (CallMethodWithErrorCallback()) is not familiar with OnceCallback unfortunately. So, instead, this CL introduces a ResponseOrErrorCallback, which takes either Response* or ErrorResponse*, and it is called on completion of CallMethod task regardless of whether it is success or fail. CallMethodWithErrorCallback() is deprecated now, and the callers will be migarted into CallMethodWithErrorResponse() in following CLs. BUG=739622 TEST=Build. Change-Id: Ib12e27de0d1dc09f2878679c53e0ad741c916fe9 Reviewed-on: https://chromium-review.googlesource.com/704794Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> Cr-Commit-Position: refs/heads/master@{#510166}
-
Eric Roman authored
Bug: 649017,649000,762380 Change-Id: Ic80908a4b883fbae23ba60f67c422d95478836db Reviewed-on: https://chromium-review.googlesource.com/721850 Commit-Queue: Eric Roman <eroman@chromium.org> Reviewed-by:
Matt Mueller <mattm@chromium.org> Cr-Commit-Position: refs/heads/master@{#510165}
-
Karan Bhatia authored
This CL removes some un-used info map instances from test fixtures in web_request_api_unittest.cc BUG=None Change-Id: I6bf743e06ae6297676e8c9cbd1cfb596f63225cb Reviewed-on: https://chromium-review.googlesource.com/722119Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#510164}
-
Misha Efimov authored
- Unused after https://codereview.chromium.org/2911513002 - Causing compilation error with use_asan=true on iOS. Bug: 593874 Change-Id: I448cdcc472faaa44fa914efe56219b2448ed0b71 Reviewed-on: https://chromium-review.googlesource.com/728395Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Misha Efimov <mef@chromium.org> Cr-Commit-Position: refs/heads/master@{#510163}
-
Eugene Ostroukhov authored
Bug: 738065 Change-Id: I1ca301942f151bea6a1665a02bc58a89b0eb2ad7 Reviewed-on: https://chromium-review.googlesource.com/726840Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Eugene Ostroukhov <eostroukhov@chromium.org> Cr-Commit-Position: refs/heads/master@{#510162}
-
David Trainor authored
Trim the query parameters to make the URL easier to visualize. BUG=776146 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Id5b13c27a20e868b67bb121d9339e1be0ca893ad Reviewed-on: https://chromium-review.googlesource.com/727359 Commit-Queue: David Trainor <dtrainor@chromium.org> Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Cr-Commit-Position: refs/heads/master@{#510161}
-
Gyuyoung Kim authored
This CL is to remove unused local variable which was added by c752fed4. - Original CL: https://codereview.chromium.org/2449583002 Bug: None Change-Id: I569d82abe3ebfcacb20b6466ec242206533cfd93 Reviewed-on: https://chromium-review.googlesource.com/727859Reviewed-by:
Florin Malita <fmalita@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung.kim@chromium.org> Cr-Commit-Position: refs/heads/master@{#510160}
-
Alexander Alekseev authored
This reverts commit 5dfbdc57. Reason for revert: error in code. Original change's description: > Chrome OS: Fix BootTimesRecorder crash on renderer crash. > > This CL adds NULL checks to BootTimesRecorder so that it won't crash > on renderer crash. > > Bug: 768446 > Change-Id: Ia5c6ef4d2963f6dbf71227a39486a9a5d4a0b1f6 > Reviewed-on: https://chromium-review.googlesource.com/727192 > Reviewed-by: Mitsuru Oshima <oshima@chromium.org> > Commit-Queue: Alexander Alekseev <alemate@chromium.org> > Cr-Commit-Position: refs/heads/master@{#510150} TBR=oshima@chromium.org,alemate@chromium.org Change-Id: I445a61033b98a5660d234441f845af88e6103c2b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 768446 Reviewed-on: https://chromium-review.googlesource.com/728624Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#510159}
-
Quinten Yearsley authored
Bug: 658880 Change-Id: I8f03010037dbc45daa9165e9e5ae8c47ade889d0 Reviewed-on: https://chromium-review.googlesource.com/726970Reviewed-by:
Stefan Zager <szager@chromium.org> Commit-Queue: Quinten Yearsley <qyearsley@chromium.org> Cr-Commit-Position: refs/heads/master@{#510158}
-
Francois Doray authored
Bug: 766678 Change-Id: Id38d07cc60a5a97f2e60903449050032ea0a6cb8 Reviewed-on: https://chromium-review.googlesource.com/696124 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#510157}
-
Philip Rogers authored
Dialog element centering used the frame view's scroll offset but needed to use the scrollable area's scroll offset to work with root layer scrolling. Dialog centering is not very intuitive in that it does not re-center when the frame is resized. For this reason, it is not associated with the viewport constrained object set on LocalFrameView. Because of this, it is safe to use the local frame view's size instead of the (unavailable) scrollable area size. A comment has been added about this discrepancy. Bug: 776129 Change-Id: I356e75799165cd3ee6202ce0ce54a638dacdfcae Reviewed-on: https://chromium-review.googlesource.com/726851Reviewed-by:
Stefan Zager <szager@chromium.org> Reviewed-by:
Steve Kobes <skobes@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#510156}
-
Daniel Bratell authored
The jpeg decoder uses libjpeg_turbo which uses a "boolean" type defined to be int. At the same time Windows has "boolean" type which is unsigned char. If those headers meet in a translation unit you get compilation errors. An alternative fix would be to redefine libjpeg_turbo to use unsigned char for its boolean type. Bug: 775979 Change-Id: I268e0890dfc2fae79d0abe54bbd7bf5c0c23226f Reviewed-on: https://chromium-review.googlesource.com/727980Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#510155}
-
Sammie Quon authored
Behaviour matches android now. Test: ash_unittests SplitViewWindowSelectorTest.SelectUnsnappableWindowInSplitView Bug: 775682 Change-Id: I9e3a6c321ea2c871b1cc7d438f8b70228030a2a1 Reviewed-on: https://chromium-review.googlesource.com/724212Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#510154}
-
Dave Tapuska authored
Delete relevant code now that rAF aligned touch and mouse have both shipped for a couple of releases. BUG=642368 Change-Id: Ib61e7023cc311e3967427566a5beb2875d7db469 Reviewed-on: https://chromium-review.googlesource.com/726406Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Reviewed-by:
Daniel Bratell <bratell@opera.com> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#510153}
-
Florin Malita authored
svg/custom/radialGradient-focal-radius.svg (https://skia-review.googlesource.com/c/skia/+/616600 BUG=776383 TBR= Change-Id: Iecdda691c56e318966fffb5b7cb8ee9600ee908e Reviewed-on: https://chromium-review.googlesource.com/727628Reviewed-by:
Mike Klein <mtklein@chromium.org> Commit-Queue: Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/master@{#510152}
-
rbpotter authored
To prevent JS console errors, ensure that all CDDs obtained from extension and privet printers are sane. Do not need to check CDDs from local printers, since they are generated by SemanticCapsAndDefaultsToCdd. Bug: None Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Idbbd9470cd966a47bb4b16472f05f30fe4990c4c Reviewed-on: https://chromium-review.googlesource.com/679283 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#510151}
-
Alexander Alekseev authored
This CL adds NULL checks to BootTimesRecorder so that it won't crash on renderer crash. Bug: 768446 Change-Id: Ia5c6ef4d2963f6dbf71227a39486a9a5d4a0b1f6 Reviewed-on: https://chromium-review.googlesource.com/727192Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#510150}
-
Aleks Totic authored
Add LayoutNGBlockFlow::CachedLayoutResultForTesting method to enable fragment access from unit tests. # Reason for patch: Legacy has a fast layout code path that does not call LayoutNGBlockFlow::UpdateBlockLayout. This path updates overflow, and position of OOF descendants. Because of this, Legacy containers must know about all OOF descendants. Existing code did not let Legacy containers know about NG OOF descendants. This CL fixes this. # Unit tests problems. This patch will affect future webkit_unit_tests. NGBlockNode::Layout will DCHECK if done outside of the performLayout cycle if NGBlockNode has OOF descendants. The core cause is this: NGBlockNode::CopyFragmentToLegacyLayout calls LayoutBox::LayoutPositionedObjects. LayoutPositionedObjects asserts that View()->IsInPerformLayout() This patch fixes four existing failing tests. 1) NGBlockLayoutAlgorithmTest.CollapsingMarginsEmptyBlockWithClearance Fixed by inspecting LayoutObjects instead of fragments. 2) NGOutOfFlowLayoutPartTest.FixedInsideAbs Fixed by 3) NGOutOfFlowLayoutPartTest.OrthogonalWritingMode1 4) NGOutOfFlowLayoutPartTest.OrthogonalWritingMode2 Removed, code already covered by existing LayoutTests. Bug: 740993 Change-Id: I3a87ef5cdac883517bc3db33e0569668161ff806 Reviewed-on: https://chromium-review.googlesource.com/722760 Commit-Queue: Aleks Totic <atotic@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#510149}
-
Rob Buis authored
Seems this is not used (anymore). Change-Id: I3ac38799038231537d4fbc16428d1b523c7528b1 Reviewed-on: https://chromium-review.googlesource.com/728319Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Rob Buis <rob.buis@samsung.com> Cr-Commit-Position: refs/heads/master@{#510148}
-
rnephew authored
Requires https://codereview.chromium.org/3008203003/ Bug: 723636 Change-Id: I3bda0037af48c78fd7b80912f4a84d0542a782e8 Reviewed-on: https://chromium-review.googlesource.com/655361 Commit-Queue: rnephew <rnephew@chromium.org> Reviewed-by:
rnephew <rnephew@chromium.org> Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Reviewed-by:
Charlie Andrews <charliea@chromium.org> Cr-Commit-Position: refs/heads/master@{#510147}
-
wutao authored
The observers in scoped_layer_animation_settings, CacheRenderSurfaceObserver, DeferredPaintObserver, and TrilinearFilteringObserver, share the very similar pattern. This cl abstracts the observers and reduces the duplication of the code. Bug: 774332 Test: local builds works with caching and trilinear filtering. Change-Id: Idc4119d6ec680145c05161b504a7baf45080058b Reviewed-on: https://chromium-review.googlesource.com/724362Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
David Reveman <reveman@chromium.org> Commit-Queue: Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#510146}
-
tzik authored
This CL contains: - Moves WTF::GetPtr overload for RefPtr to wtf/GetPtr.h, - Moves RefPtrValuePeeker to wtf/HashFunctions.h - Merges WTF::AdoptRef and base::AdoptRef. as a preparation of RefPtr.h removal. Bug: 763844 Change-Id: Iac2cfe6af0304ed4ea180f6ed50a08e9065672b9 Reviewed-on: https://chromium-review.googlesource.com/727683Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#510145}
-
Ian Vollick authored
Previously, we'd sorted along world-space z which provided a stable ordering given that the elements did not move in world space in a way that would upset the element ordering. However, with viewport-aware elements, this has now changed. With this change, we instead order the elements semantically. When we add effects which require sorting by depth (i.e., where elements dynamically change their ordering), we can augment UiRenderer::GetElementsInDrawOrder to account for the view vector. Currently, however, this is not required. Bug: 765460 Change-Id: If17a9b19b35ff6c1e998694f2677cb5c19170d96 Reviewed-on: https://chromium-review.googlesource.com/727342Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#510144}
-
Stephen Lanham authored
This test is flaking on the CQ. Disable it on desktop until we can assess the root cause. BUG= b/67975693 Bug: 67975693 Test: CQ Change-Id: I76ad684140460b10b819c45f77a75bff5a7fb935 Reviewed-on: https://chromium-review.googlesource.com/727076 Commit-Queue: Stephen Lanham <slan@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#510143}
-
Hidehiko Abe authored
This has two changes. - Remove gmock from document_scan_interface_chromeos_unittest. - Remove friend from the testee class. Instead, pass LorgnetteManagerClient via ctor. BUG=None TEST=Ran bots. Change-Id: I8bb910efb045ba6124fc0a42b70cd729e80c16bf Reviewed-on: https://chromium-review.googlesource.com/727504Reviewed-by:
Toni Barzic <tbarzic@chromium.org> Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> Cr-Commit-Position: refs/heads/master@{#510142}
-
Khushal authored
At the end of the catch up loop, we notify observers that the image is dirty and schedule a task for the next frame. The latter is unnecessary since when the image is repainted, it will call StartAnimation to tick itself at the end of the draw call. The original intent of the code was to catch up to the desired frame and synchronously draw it (see [1]). The assumption at the time was that since this draw will happen synchronously, there will be no StartAnimation call to schedule the next frame and it needed to be done immediately after the catch up loop. This is no longer true. We notify observers async after catching up and when they draw, we will get a StartAnimation call to tick the animation. So this additional bit of code is unnecessary complexity. [1]: https://bugs.webkit.org/show_bug.cgi?id=19663#c6 R=pdr@chromium.org Change-Id: If9684b9aa92dd69b5e3b87cadea5fc7582e4e7a4 Reviewed-on: https://chromium-review.googlesource.com/727198Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#510141}
-
Xiaocheng Hu authored
Bug: 699017 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I0ad635a08ffed1fdca4e370a320e12854e2ef227 Reviewed-on: https://chromium-review.googlesource.com/727406 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#510140}
-
tzik authored
scoped_refptr is allowed in Blink now, and WTF::RefPtr is an alias of scoped_refptr for migration. This CL inlines the alias to the RefPtr users in core/frame to remove RefPtr. Bug: 763844 Change-Id: I4cd5877a45c20aba61018c532b09336aa24050f7 Reviewed-on: https://chromium-review.googlesource.com/727447Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#510139}
-
Jinsong Fan authored
Bug: Change-Id: I39ab598aae721bdd8f88c0dd9b1668c45d7e0559 Reviewed-on: https://chromium-review.googlesource.com/727599Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#510138}
-
Becca Hughes authored
Creation of <div>'s is a repeated part of the media controls so this refactors it into a single function (there are more uses of the function coming). BUG=761305 Change-Id: If3530a416fd6f169100072899fbe3fcfb159155a Reviewed-on: https://chromium-review.googlesource.com/727897Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#510137}
-
Ben Chan authored
Bug: 776236 Change-Id: I41f84b07f6ebd28434897bb77edcc9254987ec1b Reviewed-on: https://chromium-review.googlesource.com/727024Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Ben Chan <benchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#510136}
-
Frank Henigman authored
https://chromium.googlesource.com/angle/angle.git/+log/d042fba..cbcb96f BUG=765919 TEST=bots CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: Ie29f5ce96fd63f1c1f9c51a5646cfa5da12d17f6 Reviewed-on: https://chromium-review.googlesource.com/726756Reviewed-by:
Jamie Madill <jmadill@chromium.org> Commit-Queue: Frank Henigman <fjhenigman@chromium.org> Cr-Commit-Position: refs/heads/master@{#510135}
-
Changwan Ryu authored
This extends what we did for ChromeHome at https://chromium-review.googlesource.com/520712: when moving focus from an EditText to non-editable placeholder does not automatically hide keyboard, but restart input with TYPE_NULL, which results in a visual glitch such as flickering of number panel on keyboard app. This can be prevented by hiding soft input ourselves. BUG=708259 Change-Id: I05d3714202381e42af04b3fa4ed1bf4452908beb Reviewed-on: https://chromium-review.googlesource.com/728389Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Changwan Ryu <changwan@chromium.org> Cr-Commit-Position: refs/heads/master@{#510134}
-
Raymond Toy authored
For low frequencies, use a 3-point or 5-point Lagrange interpolation scheme to improve the accuracy of the oscillator instead of using simple linear interpolation. For a typical context, the linear interpolator is used if the frequency >= 3.2 Hz; the 3-point, for 3.2 > frequency > 1.7 Hz; and the 5-point for all other cases. Thus, typical use-cases are not impaired by this change. Some benchmark results from running an oscillator for 1000 seconds in an offline context. This is the time measured from startRendering() until the promise is delivered. The SNR is the measured SNR between the test signal and a reference 440 Hz signal. The linear time was the same before and after this CL. linear: time: 1844.6 ms, stddev: 154.4 SNR: 27.7 dB 3-point: time: 2426.5 ms, stddev: 265.0 SNR: 37.2 dB 5-point: time: 2752.6 ms, stddev: 215.1 SNR: 59.3 dB 7-point (for reference, not used now): time: 3239.4 ms, stddev: 263.8 SNR: 82.5 dB Bug: 773507 Test: Oscillator/osc-440hz.html Change-Id: Ib49fab4fb27738f4f02bd41f8adcc2e3b2dd2137 Reviewed-on: https://chromium-review.googlesource.com/713576 Commit-Queue: Raymond Toy <rtoy@chromium.org> Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#510133}
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/catapult.git/+log/2713d6d5f30d..22e74ebb13a5 $ git log 2713d6d5f..22e74ebb1 --date=short --no-merges --format='%ad %ae %s' 2017-10-19 perezju [devil] Fix forwarder.py to work on newer psutil versions Created with: roll-dep src/third_party/catapult Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I051f3d3dd2a4fa73b0020b3d4f742492d5beba06 Reviewed-on: https://chromium-review.googlesource.com/727662 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#510132}
-
David Tseng authored
TBR=dtseng@chromium.org Bug: 773866 Original change Reviewed-on: https://chromium-review.googlesource.com/723606 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#509911} Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I1a1be30f3e430f2417ab3ff4b9733de1b8004077 Reviewed-on: https://chromium-review.googlesource.com/728302Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#510131}
-
Xiaocheng Hu authored
This patch adds LayoutNG alternatives of LayoutText::ContainsCaretOffset for both "common" LayoutText and ::first-letter LayoutTextFragments, with an extensive set of unit tests. Bug: 771398 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I59b17046c271bf8c5c1fb4fdf7421b37a3183073 Reviewed-on: https://chromium-review.googlesource.com/724262Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#510130}
-
Min Qin authored
Without network service, pausing a download is handled by DownloadRequestCore. It defers reading the response until download is resumed. With network service enabled, we can pause download by stopping reading from the data pipe. BUG=715630 Change-Id: I231d273828a82a401a9cd3d2773fd75a3166cfbd Reviewed-on: https://chromium-review.googlesource.com/726302 Commit-Queue: Min Qin <qinmin@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#510129}
-
Weidong Guo authored
Changes: Change the role of app list folder to GENERIC_CONTAINER from BUTTON. BUG=776238 Change-Id: I3c0395678478c873e7328d1cb26bfe1d78043286 Reviewed-on: https://chromium-review.googlesource.com/727562Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Weidong Guo <weidongg@chromium.org> Cr-Commit-Position: refs/heads/master@{#510128}
-
Will Chen authored
This fixes TestRunner.navigate(...) which is used by a handful of tests currently and will be needed by more because of the new test structure. This migrates debug-inlined-scripts-fragment-id.js to verify that this method works. Bug: 667560 Change-Id: I658736139aed90e20836cebea016f20ddfa8d9fb Reviewed-on: https://chromium-review.googlesource.com/727471Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Will Chen <chenwilliam@chromium.org> Cr-Commit-Position: refs/heads/master@{#510127}
-