- 19 Nov, 2020 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/5c2ea4d80c2b..438d44197a4f 2020-11-19 kahinds@microsoft.com [Loc] Migrate security to Localization V2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1136655 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I28d666aa92a8811bc3cc65424fc8875bb68d651a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2548410Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#829088}
-
Jeffrey Young authored
This is a reland of 6d681c88 AmbientController close all ui widgets in destructor. Prevents use-after-free in PhotoView destructor if Shell is destructed while Ambient mode is on. Original change's description: > ambient: support multiple displays > > Run ambient mode UI on each connected display. > RootWindowController construction handles adding ambient widgets > to new displays while ambient mode is running, and destructing them > on display removed. > > BUG=b:139953389 > > Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome > Change-Id: Ic57c33491098b66c7c0e90ef1f3d12c71f1fc303 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2516968 > Commit-Queue: Jeffrey Young <cowmoo@chromium.org> > Reviewed-by: Mitsuru Oshima <oshima@chromium.org> > Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org> > Reviewed-by: Tao Wu <wutao@chromium.org> > Cr-Commit-Position: refs/heads/master@{#828329} Bug: b:139953389 Change-Id: I1a7acccb0325c2c65b3d9f57db3d4c4bde03dc63 Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546971Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Jeffrey Young <cowmoo@chromium.org> Cr-Commit-Position: refs/heads/master@{#829087}
-
Jeffrey Young authored
On shutdown, MetricsService may attempt to finalize logs and calls |ProvideCurrentSessionData|. |AmbientClient| may have been destructed by then. BUG=1150479 TEST=on about://flags, change a flag and restart ui Change-Id: I216b522ca1dd8c2c09a4f1350098b9c18620338c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547331Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Jeffrey Young <cowmoo@chromium.org> Cr-Commit-Position: refs/heads/master@{#829086}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/021b77e7f0c7..3a578ae35233 2020-11-19 treehugger-gerrit@google.com Merge "Include FrameTimelineTest in TEST_MAPPING" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: Id1bdd172e774a837de59f987489149f03f682b4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2548505Reviewed-by:
-
Yann Dago authored
Bug: 1149989 Change-Id: I1f8857abde83ab07576a6a272d6918adbf712bc1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547444Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Yann Dago <ydago@chromium.org> Cr-Commit-Position: refs/heads/master@{#829084}
-
Jeffrey Kardatzke authored
This adds a few things to the VaapiVideoDecoder for protected content. -Accepts encrypted/CDM configurations in Initialize -Registers a callback with the CDM to get notified when new decryptions keys are available -When in protected mode, configures VaapiWrapper that way -Adds a new kWaitingForProtected state when it is waiting for keys, hw config, full sample decryption. -Callback to be used by accelerators to notify when protected decode should resume BUG=b:153111783,b:155509236 TEST=Builds, protected playback works w/ full set of changes Change-Id: Ibd52ddd90af732d5ae736989c2008f4f4fdcd38f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535578 Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com> Reviewed-by:
Jao-ke Chin-Lee <jchinlee@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#829083}
-
Harry Cutts authored
The pointing stick sensitivity metric got missed when I added the utility functions in https://crrev.com/c/2491973 (since it was being reviewed simultaneously). Bug: none Test: change a preference and check chrome://histograms shows the sample Change-Id: I25679180189f1a889c886b74169ac8693c996976 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2548385 Auto-Submit: Harry Cutts <hcutts@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#829082}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=lakpamarthy@chromium.org Change-Id: Ide8e47dcf9103524d93b22a9cb4fca40501a1761 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2548248Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#829081}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/2d31db0b3751..021b77e7f0c7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I91793981bd9752cec745d79cb938c9f0898c8084 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2548188Reviewed-by:
-
Wei Lee authored
This reverts commit 5dec0310. Reason for revert: LKGM update: crbug.com/1148527 Original change's description: > Revert "[CCA] Run CCA as SWA by default" > > This reverts commit 46b6fd15. > > Reason for revert: > > camera.CCAUISmoke.fake is failing on chromeos-eve-chrome and camera.CCAUI* is listed as test coverage for this CL, so I am speculating that it is the cause. See: > https://ci.chromium.org/p/chrome/builders/ci/chromeos-eve-chrome/11136 > > Original change's description: > > [CCA] Run CCA as SWA by default > > > > Bug: b/172345161 > > Test: tast run [DUT] camera.CCAUI* > > Change-Id: I10484c9263f3e4c560028aef272cd3db88c47b31 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2509834 > > Commit-Queue: Wei Lee <wtlee@chromium.org> > > Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> > > Auto-Submit: Wei Lee <wtlee@chromium.org> > > Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#825657} > > TBR=ortuno@chromium.org,wtlee@chromium.org > > Change-Id: I5464fbcd7f1a03cd157122ad66c6ee13ad111630 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: b/172345161 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2529360 > Reviewed-by: Henrik Boström <hbos@chromium.org> > Commit-Queue: Henrik Boström <hbos@chromium.org> > Cr-Commit-Position: refs/heads/master@{#825818} TBR=hbos@chromium.org,ortuno@chromium.org,wtlee@chromium.org Bug: b/172345161 Change-Id: Ie6d18656a2b247d8eec260319594e7355337c5af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547645Reviewed-by:
Wei Lee <wtlee@chromium.org> Reviewed-by:
Shik Chen <shik@chromium.org> Commit-Queue: Wei Lee <wtlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#829079}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/78d59130877b..efe28dbf48ad If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC keishi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1131897,chromium:1150547 Tbr: keishi@google.com Change-Id: Iab64dc9e40400de4c272926b78f18262fcbdb290 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2548605Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#829078}
-
Xianzhu Wang authored
This is to refresh data for reordering overlay overflow controls. Bug: 1149793 Change-Id: I94fc45373ba3e5aad684283c6fda6ae5e31581f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547435Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#829077}
-
David authored
With cl/343193875 app_main.js reads window.loadTimeData. Re-order our imports so window.loadTimeData always exists before we try read it (see the chat thread from https://buganizer.corp.google.com/issues/172985712#comment5) Note: this needs to land before cl/343193875. Bug: b/172985712 Change-Id: I884426062c255470a226d75a2d479ce858a2c11d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2548582Reviewed-by:
David Lei <dlei@google.com> Reviewed-by:
Rachel Carpenter <carpenterr@chromium.org> Commit-Queue: David Lei <dlei@google.com> Commit-Queue: Rachel Carpenter <carpenterr@chromium.org> Auto-Submit: David Lei <dlei@google.com> Cr-Commit-Position: refs/heads/master@{#829076}
-
Chromium WPT Sync authored
Using wpt-import in Chromium ab895957. With Chromium commits locally applied on WPT: 0977dd12 "Move native paint worklet off thread" 957cd8a0 "[TablesNG] Sticky position" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=smcgruer@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-payments-fyi-rel Change-Id: Ifcec9c962b4b5e14407274a093de774c1595aa47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547332Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#829075}
-
Darren Shen authored
The observer for this API is never called, so the event never triggers. We suspect that the API never worked, see the investigation in the bug. Bug: 1148579 Change-Id: Ie38c3de517cfeb44dcd2f8f900b971406e08a0f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535893 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by:
Keith Lee <keithlee@chromium.org> Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Reviewed-by:
Jing Wang <jiwan@chromium.org> Cr-Commit-Position: refs/heads/master@{#829074}
-
Joel Hockey authored
Add support for FilesApp to be a drop target for files which have originated dragging from other apps such as crostini, plugin vm, or arc. FilesApp seems to be using custom fs/* mime types such as fs/sources for DataTransfer used in drag and drop. This appears to pass around lists of entry URLs as strings. The URLs are later resolved to FileEntry using webkitResolveLocalFileSystemURL. When files are provided from other systems besides FilesApp, the URLs provided are not compatible, but DataTransferItem.webkitGetAsEntry() can be used to get a FileEntry which can be used in the drop-copy operation. This CL now allows DataTransfer with type 'Files', and refactors FileTransferController.PastePlan to allow sourceEntries to be provided as an alternative to sourceURLs. Bug: 1144138 Change-Id: I6b160eef7140d824b816076c71f1bd3a455a4415 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542938Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#829073}
-
Michael Lippautz authored
These methods are needed by macros for PA but never in places that would require a stub for HeapAllocator. Bug: 1056170 Change-Id: I3c9a73f58d3a822ab44fdf5c185750c59112ece9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547722 Auto-Submit: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#829072}
-
Jan Wilken Dörrie authored
This change adds an entry for EnablePasswordGenerationForClearTextFields to the testing/variations/fieldtrial_testing_config.json. Bug: 1021897 Change-Id: I0e328629babc5f81c7bee05ea669598fd7ff69ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543392 Auto-Submit: Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1605722062-63dbc729233b875bed4d9f1fa158097610c580cf.profdata to chrome-linux-master-1605743960-c6eb23d92bd5ebb2b738686f930937312c075c5e.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ic85ed2d9e064b956db22e20ebd80723e97202a7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2548411Reviewed-by:
-
Joey Arhar authored
The UKM this goes next to doesn't get emitted in iframes due to the UKM policy, so this UseCounter will let us get the same metric from iframes. Bug: 1150619 Change-Id: Ib892978142f34010d8a8f3f489cd95957e362603 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2548346 Commit-Queue: Joey Arhar <jarhar@chromium.org> Reviewed-by:
-
Yicheng Li authored
This enables WebAuthn flow to be properly cancelled on ChromeOS. timeout and observe that ChromeOS UI is dismissed (and Chrome shows the timeout message). Bug: 1150656 Test: Started MakeCredential with test website then waited till Change-Id: I5403b03dd99fe329ea9009f7544bfefade39815c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2548185 Commit-Queue: Yicheng Li <yichengli@chromium.org> Reviewed-by:Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#829068}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/7e050e9a..458ab69a Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I3fc7b3a2f2152ee94b9fe55848c2901c1991fc83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2548760Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#829067}
-
Ben Joyce authored
Certain suites like ui_junit_tests and base_junit_tests need less shards, time differences are more apparent on bots than when run locally. Bug: 1138506 Change-Id: I5c5cbf019300f9b438c5d23b996e7d326e8e050d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545570 Auto-Submit: benjamin joyce <bjoyce@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#829066}
-
Joel Hockey authored
This reverts commit 8fd7b85d. Reason for revert: relanding after creating fix for M88 Original change's description: > Revert "Support Arc, crostini, and Plugin VM in drag drop FileHelper" > > This reverts commit 54e85384. > > Reason for revert: Reverting in order to create a patch for M88. > > Original change's description: > > Support Arc, crostini, and Plugin VM in drag drop FileHelper > > > > The current code in FileHelper assumes all windows are Arc. We now > > check the source and target aura::Window to detect and do the > > appropriate path translations and share files when necessary with > > crostini/pluginvm. > > > > For example, when crostini is the drag source, we will convert paths > > such as: > > > > <homedir>/file => /media/fuse/crostini_<hash>_termina_penguin/file > > > > And do the opposite translation when crostini is the drop target. > > > > We also convert paths and share files such as: > > > > <cryptohome>/MyFiles/file => /mnt/chromeos/MyFiles/file > > /media/removable/MyUSB => /mnt/chromeos/removable/MyUSB > > > > For PluginVM, the translation is > > > > <cryptohome>/MyFiles/file => //ChromeOS/MyFiles/file > > /media/removable/MyUSB => //ChromeOS/removable/MyUSB > > > > Bug: 1144138 > > Change-Id: I2bb38336537acf13c4797374d6dabe6e518d689e > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517346 > > Commit-Queue: Joel Hockey <joelhockey@chromium.org> > > Reviewed-by: Jason Lin <lxj@google.com> > > Reviewed-by: Mitsuru Oshima <oshima@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#827956} > > TBR=oshima@chromium.org,joelhockey@chromium.org,niwa@chromium.org,lxj@google.com > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 1144138 > Change-Id: I212ae8759e9069e52837fd1bc324ea5f9046b6b5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547743 > Reviewed-by: Joel Hockey <joelhockey@chromium.org> > Reviewed-by: Mitsuru Oshima <oshima@chromium.org> > Commit-Queue: Joel Hockey <joelhockey@chromium.org> > Cr-Commit-Position: refs/heads/master@{#829031} TBR=oshima@chromium.org,joelhockey@chromium.org,niwa@chromium.org,lxj@google.com # Not skipping CQ checks because this is a reland. Bug: 1144138 Change-Id: I0a735fb4e17679f735c11ecab427f7ba624db399 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547844Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#829065}
-
Nicholas Verne authored
This is a reland of 7b6fabaa We appear to be going for a record of reland/revert of strings. The relevant tast tests are submitted and have survived rollback. The chromeos LKGM uprev is stil not successful (for the last two weeks). I'll wait for that before submitting. Original change's description: > Reland "Reland "Crostini settings string changes."" > > This is a reland of 6b11534a > > OK, this time for sure. The tast-test change below was submitted, but the > relevant ChromeOS uprev was blocked for days. This is now through so we > can reland again, for real this time. > > Original change's description: > > Reland "Crostini settings string changes." > > > > This is a reland of da531d49 > > > > Now that https://chromium-review.googlesource.com/c/chromiumos/platform/tast-tests/+/2505407 > > is landed, this should be safe. > > > > Original change's description: > > > Crostini settings string changes. > > > > > > Instead of "Linux (Beta)", now shows as "Developers" > > > > > > Bug: 1140370 > > > Change-Id: Id4e076b5d918e41e22e5c59d65958da9e75a3f55 > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486528 > > > Commit-Queue: Nicholas Verne <nverne@chromium.org> > > > Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> > > > Reviewed-by: David Munro <davidmunro@google.com> > > > Auto-Submit: Nicholas Verne <nverne@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#820205} > > > > Bug: 1140370 > > Change-Id: Ibb5bd28f9647847dddaf109e9da86d91b17dd863 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505324 > > Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> > > Reviewed-by: David Munro <davidmunro@google.com> > > Commit-Queue: Nicholas Verne <nverne@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#822525} > > Bug: 1140370 > Change-Id: I76e0dfa45877db5d633a70126c0f5bd2a70a15f9 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515799 > Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> > Commit-Queue: Nicholas Verne <nverne@chromium.org> > Cr-Commit-Position: refs/heads/master@{#823503} Bug: 1140370 Change-Id: Id55048b7c50b3eaa3e13572d1dbde544708a4dcb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526864Reviewed-by:
David Munro <davidmunro@google.com> Commit-Queue: Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#829064}
-
Yuki Shiino authored
Runs PartitionAllocMemoryReclaimer for the PartitionRoot used by ShimMalloc, etc. (partition alloc as malloc). Change-Id: I636b7b2ca4fdda7de7b3a178e6193dea7c0605cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532476Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Benoit L <lizeb@chromium.org> Reviewed-by:
Bartek Nowierski <bartekn@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#829063}
-
Michael Crouse authored
This change adds tflite and its dependencies to third_party. The design and approval can be seen here: https://docs.google.com/document/d/1mT__9_vMhAPTov6O7ULNV5lyk_c83dAufveAhPXZPcE/edit Bug: 1121333 Change-Id: I0cd9da80d6c6a83a733b28d0055d09a2d71865cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523426Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Mirko Bonadei <mbonadei@chromium.org> Reviewed-by:
Alex Gough <ajgo@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Sophie Chang <sophiechang@chromium.org> Commit-Queue: Michael Crouse <mcrouse@chromium.org> Cr-Commit-Position: refs/heads/master@{#829062}
-
Jeroen Dhollander authored
Gaia id should never be an email address, and there is a dcheck to guard against this: https://source.chromium.org/chromium/chromium/src/+/master:google_apis/gaia/core_account_id.cc;l=34 I have no idea why this was not triggering previously. Bug: None Test: browser_tests --gtest_filter="Assistant*" Change-Id: I47775ec00afd67ea31d92ea09bdf02267ba06672 Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2548294 Commit-Queue: Jeroen Dhollander <jeroendh@chromium.org> Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Auto-Submit: Jeroen Dhollander <jeroendh@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/dda9c164cb3b..2d31db0b3751 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I89b1afd37600dd91b57a17828f3bc1169fca0bac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2548422Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/444733610032..5589652282f5 2020-11-19 linxinan@chromium.org Revert "Improve the setup logic for tryserver" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1146487 Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: I7fe2b46838ea28629eb25ae71aa7efda6dfc7440 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2548722Reviewed-by:
-
Dirk Pranke authored
This fixes various Python3 incompatibilities and updates the plist files to the new Python3 APIs. Bug: 1112471 Change-Id: Ie6239ab4454b39e7e65d02d3a2da4b3a1967a6d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522676 Commit-Queue: Dirk Pranke <dpranke@google.com> Reviewed-by:
Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#829058}
-
Hiroki Sato authored
Starting ARC R, ARC natively supports display density. As a result, when the client is ARC P, the bounds are always scaled by the default device scale factor, and when the client is ARC R and later, the bounds are always scaled by the screen scale of the display, which matches the browser behavior. This CL addresses the above change in accessibility layer. AX-Relnotes: n/a. (a part of preparation for ARC R) Bug: b:17251157 Test: manual. Open PlayStore and change scale factor by ctrl+shift+(+/-) with P and R. Change-Id: Iae39adaed7b3fc7a00962edc9da617b89dea7202 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2540266 Commit-Queue: Hiroki Sato <hirokisato@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Reviewed-by:
Sara Kato <sarakato@chromium.org> Cr-Commit-Position: refs/heads/master@{#829057}
-
Clark DuVall authored
This is a reland of c7a74ee0 Fix for Play Store upload issue is in http://crrev.com/c/2545725. Will submit this after that lands. Original change's description: > Enable isolated splits in canary and dev > > All major crashes have been fixed and numbers look good. M88 branch was > just cut, so should be safe to enable now. > > Bug: 1126301 > Change-Id: I351d565e68f14af2411c71fa80f34852bab5455a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2529729 > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Commit-Queue: Clark DuVall <cduvall@chromium.org> > Cr-Commit-Position: refs/heads/master@{#827387} Bug: 1126301 Change-Id: If28e00dae4bf5e81ef22751ae394c3bb4a200908 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545870Reviewed-by:
-
Shakti Sahu authored
This CL adds various IPHs for the read later feature. 1 - IPH to educate user about using the bookmark button on the app menu for saving articles to reading list. 2 - IPH to educate user about location of bookmarks in app menu. 3 - Notify IPH backend whenever read later option is selected in context menu. 4 - Notify IPH backend whenever user navigates to the read later folder in bookmarks. Bug: 1139076 Change-Id: Ib81e43a9746c3493bdd6f299e6a9e117aacc472c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537390Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#829055}
-
Maksim Ivanov authored
Fix the CHECK expression in color_space.cc to compare two signed ints, instead of a signed with an unsigned one. Excerpt from the error message: ../../base/check_op.h:191:26: error: comparison of integers of different signs: 'int' and 'unsigned int' [-Werror,-Wsign-compare] ../../components/exo/wayland/clients/color_space.cc:33:3: note: in instantiation of function template specialization 'logging::CheckEQImpl<int, unsigned int, 0>' requested here CHECK_EQ(gbm_bo_get_plane_count(bo), 1u); This was seen in the clang-tidy builds (probably they're using slightly different build settings than the regular Chrome builds). Bug: none Change-Id: I8e929691560b1485e4fd5c05a4fb83f2c4c1a5be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2548464 Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Auto-Submit: Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#829054}
-
James Hollyer authored
If Wifi is disabled Core Location does not work. In this case we will fallback to the Network Location Provider which can use the IP address to get an much less precise location. Bug: 1135766 Change-Id: I3f5fa8e78fbb34bcec36dbd6eeb0e6adc06c64c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453437Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: James Hollyer <jameshollyer@chromium.org> Cr-Commit-Position: refs/heads/master@{#829053}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/2d31db0b3751..021b77e7f0c7 2020-11-18 treehugger-gerrit@google.com Merge "Prevent traced from blocking on a unresponsive producer." 2020-11-18 primiano@google.com Merge "build: pass explicitly --changelog to write_version_header.py" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: If112e0bfa7a35f9af56dc752648b7e05f5341aab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547982Reviewed-by:
-
Mike Wasserman authored
Remove the fake scanning prompt; reply with kAllow automatically. This seems to resolve flaky crashes around prompt show/accept timing. Bug: 1147582 Test: No automated test flakes Change-Id: I889f9c97400901f235d6beebfa6a40e43bc8dc93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547842Reviewed-by:
-
Michael Hansen authored
This clears the controller in the OnClose() method to prevent a crash in the event that the OnClose() callback runs more than once before the animation is complete. This surfaced as a crash when sending a file. Fixed: 1150176 Change-Id: I13aa8eaf3bf3f5e382d31376825f647ab287a7dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2548373 Commit-Queue: Michael Hansen <hansenmichael@google.com> Reviewed-by:
James Vecore <vecore@google.com> Cr-Commit-Position: refs/heads/master@{#829050}
-
Jeffrey Kardatzke authored
BUG=b:153111783,chromium:1150515 TEST=Fuzzer passes now Change-Id: I0ef8a8a5dde0cf87ca70e0889e4d5707bc5ac2ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2548348Reviewed-by:
Sergey Volk <servolk@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com> Cr-Commit-Position: refs/heads/master@{#829049}
-
