GitLab

A dangerous download can be accepted by the user or rejected. If
rejected, the downloaded file used to be deleted. This change adds
DownloadItem::AcquireFileAndDeleteDownload() which allows the caller to
acquire the dangerous file.

The intended consumer of this feature is SafeBrowsing where the caller
may want to acquire a dangerous file that's being discarded for the
purpose of further analysis.

Also change the logic during shutdown to no longer delete dangerous
downloads, but to cancel them.

TBR=rdsmith
BUG=244604

Review URL: https://chromiumcodereview.appspot.com/14947007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202925 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202921 0039d316-1c4b-4281-b951-d872f2087c98

BUG=111316
R=piman@chromium.org

Review URL: https://chromiumcodereview.appspot.com/16026006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202920 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=151350:151394&mode=html
TBR=
BUG=

Review URL: https://chromiumcodereview.appspot.com/15881007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202919 0039d316-1c4b-4281-b951-d872f2087c98

* Parent classes in alphabetical order.
* Overrides as private as possible, and in same order as parent classes.  We
  also keep the .cc file order matching the .h file.
* Remove AlwaysDrawText() entirely as it was never called.  This also means we
  can remove |force_draw_text_|.
* Inline SetImage(), SetTooltipText(), StartLabelAnimation(), PauseAnimation(),
  and UnpauseAnimation() into their lone callers.  Inline AnimationOnClick()
  into OnClick() since the two were always called together.
* Remove the scoped_ptr<> on |slide_animator_| and initialize it in the
  constructor, instead of the first time we want to animate.
* Eliminate |font_color_| since it was never used.  (We will eventually use the
  color the parent supplies us, so the constructor arg sticks around.)
* Separate out three other members that will be going away in the future.  Put
  the other ones into some sort of hopefully-logical order.
* DISALLOW_IMPLICIT_CONSTRUCTORS -> DISALLOW_COPY_AND_ASSIGN.

The changes in the .cc file are basically just deleting and reordering code,
plus "->" to "." conversions for |slide_animator_|.  I avoided doing any other
cleanup/rewriting, to keep this change "basically mechanical".

BUG=none
TEST=none
R=sky@chromium.org

Review URL: https://codereview.chromium.org/15732018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202917 0039d316-1c4b-4281-b951-d872f2087c98

* Eliminte the distinction between "item to item padding" and "item to edge
  padding" because the two values are always equal.
* Don't bother supporting "height 0 = use preferred height" in
  location_bar_layout.*, since only one caller uses it at this point and it's
  easier to understand the code by just making it explicit.
* Switch to using a views::Painter for the popup mode background as well,
  instead of explicitly drawing the images.  This will make it easy to switch
  both modes to ninebox painting in the future.
* Try to reorder code in order to declare variables as close to their use as
  possible, and in the order that they're accessed.
* Visible change: Instead of assuming the edit always has 1 px. of "internal
  space", calculate the correct conditions for which that's true.  This results
  in the OmniboxViewViews text moving right by 1 px. in the LTR case.

BUG=231005,239902
TEST=With "views textfield" on, address bar text moves 1 px. right
R=sky@chromium.org

Review URL: https://codereview.chromium.org/16025004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202916 0039d316-1c4b-4281-b951-d872f2087c98

This should solve the flakiness we've been seeing.

BUG=236102

Review URL: https://chromiumcodereview.appspot.com/15688006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202915 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromedriver:271
R=craigdh@chromium.org

Review URL: https://codereview.chromium.org/16155004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202914 0039d316-1c4b-4281-b951-d872f2087c98

CryptoModulePasswordDialogView uses Widget::CreateWindow. 
Use DialogDelegate::CreateDialogWidget instead. 
See before/after pics at http://crbug.com/166075#c107 
Trigger with debug code in Patch Set 1. 

BUG=166075
TEST=Crtypo module password dialog does not have an extra border. 
R=sky@chromium.org

Review URL: https://chromiumcodereview.appspot.com/15673004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202913 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
R=chrisgao@chromium.org

Review URL: https://codereview.chromium.org/15859013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202912 0039d316-1c4b-4281-b951-d872f2087c98

This reverts commit r191582.

R=danno@chromium.org
BUG=225325

Review URL: https://chromiumcodereview.appspot.com/15951011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202911 0039d316-1c4b-4281-b951-d872f2087c98

This reverts r201447. SetOpacity() was hooked up backwards; I got confused
while reading the GTK+ code. However, if the "255 -" is simply removed, menus
stop showing. It looks like the menu system is still calling SetOpacity(0).

BUG=none
TBR=sidharthms@google.com,sky@chromium.org

Review URL: https://codereview.chromium.org/16189008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202910 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202908 0039d316-1c4b-4281-b951-d872f2087c98

TBR=yfriedman@chromium.org
BUG=239595

Review URL: https://codereview.chromium.org/16176003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202907 0039d316-1c4b-4281-b951-d872f2087c98

iOS should pull the new Blink headers used by all the other platforms
now that the mirror repo exists.

The old WebKit header pull will be removed once nothing references
headers in those locations any more.

BUG=242829
R=blundell@chromium.org

Review URL: https://codereview.chromium.org/15931004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202905 0039d316-1c4b-4281-b951-d872f2087c98

BUG=243957
TEST=BrowserTest.NoStopDuringTransferUntilCommit

Review URL: https://chromiumcodereview.appspot.com/15742019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202904 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202903 0039d316-1c4b-4281-b951-d872f2087c98

Picks up support for Blink header-only repo for iOS.

BUG=242829
R=blundell@chromium.org

Review URL: https://codereview.chromium.org/15651005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202901 0039d316-1c4b-4281-b951-d872f2087c98

They should be inclusive, not exclusive.

BUG=None
TEST=None

Review URL: https://chromiumcodereview.appspot.com/16093009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202900 0039d316-1c4b-4281-b951-d872f2087c98

Drive-by Clang warning fix.

BUG=82385

Review URL: https://chromiumcodereview.appspot.com/15952003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202899 0039d316-1c4b-4281-b951-d872f2087c98

Also sort setting the policies by key.

BUG=233135
R=joaodasilva@chromium.org

Review URL: https://chromiumcodereview.appspot.com/16072008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202898 0039d316-1c4b-4281-b951-d872f2087c98

Sample output:

Traceback (most recent call last):
  File "./tools/run-bisect-perf-regression.py", line 39, in LoadConfigFile
    local_vars)
  File "/usr/local/google/home/simonhatch/chromium/src/tools/run-bisect-perf-regression.cfg", line 64
    'truncate_percent':'',
                      ^
SyntaxError: invalid syntax

Error: Could not load config file. Double check your changes to run-bisect-perf-regression.cfg for syntax errors.


BUG=
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/16007011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202897 0039d316-1c4b-4281-b951-d872f2087c98

Run as "python tools\win\split_link\graph_dependencies.py output.html"

Outputs a standalone html file so it can go on simple bot storage (coming
at some point).

R=jamesr@chromium.org
BUG=237249

Review URL: https://codereview.chromium.org/16196002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202896 0039d316-1c4b-4281-b951-d872f2087c98

* Changed the output directory option to '-s' and '--skp-outdir' because this was broken, running run_multipage_benchmarks with skpicture_printer resulted in the following error: 
optparse.OptionConflictError: option -o/--outdir: conflicting option string(s): -o 

* Added additional browser options due on recent changes in Skia/Chromium code base.

Review URL: https://chromiumcodereview.appspot.com/15665003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202895 0039d316-1c4b-4281-b951-d872f2087c98

This contains the binary drawables related to the following
CL, which implements the color picker for Chromium for Android:
https://codereview.chromium.org/14170009

Patch by Paul Navin <paulnavin@google.com>

TBR=yfriedman
BUG=135771

Review URL: https://codereview.chromium.org/15773009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202894 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202893 0039d316-1c4b-4281-b951-d872f2087c98

BUG=138226

Review URL: https://chromiumcodereview.appspot.com/15690007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202891 0039d316-1c4b-4281-b951-d872f2087c98

 - fixed the suppression for libevent to contain the correct filename (issue 23244)
 - removed the race:base::Thread::ThreadMain suppression, which was too broad (issue 115540)
 - suppressed a race in skia::BeginPlatformPaint (issue 244368)
 - suppressed a race in unixTempFileDir (issue 244385)

BUG=23244,115540,244368,244385
R=timurrrr@chromium.org

Review URL: https://codereview.chromium.org/15771007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202890 0039d316-1c4b-4281-b951-d872f2087c98

BUG=234710
TBR=scherkus@chromium.org,qinmin@chromium.org

Review URL: https://codereview.chromium.org/16082004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202888 0039d316-1c4b-4281-b951-d872f2087c98

We should not allow attachment after an initial navigation.

Currently, we don't allow attachment after an instance ID is allocated. 

These two checks are not equivalent. We chould have requested an instance ID from
the browser process and then immediately attach a new winow to the <webview> on the next
line prior to getting an instance ID. This will cause attach to get called again.

BUG=244641
Test=manually, this is a race that is extremely hard to test reliably. I will avoid adding
an automated test to avoid introducing more flake.

Review URL: https://chromiumcodereview.appspot.com/16057004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202886 0039d316-1c4b-4281-b951-d872f2087c98

Try to expand the revision range to include a change to .DEPS.git if the script detects a change to DEPS

BUG=
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/16023021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202880 0039d316-1c4b-4281-b951-d872f2087c98

> Use totmaps if available on chromeos
>
> We currently use statm on linux. This provides less than great results.
> We take total resident memory and subtract "shared pages" from it instead of
> using a count of pages that only this process has mapped.
>
> On chromeos we've added totmaps which sums up the fields from the process'
> smaps.
>
> BUG=125150
> TEST=Examine memory reports from about:memory and task manager, and compare
>      them to the sums of the results in the smaps.
>
> R=thestig@chromium.org, willchan@chromium.org
>
> Review URL: https://codereview.chromium.org/15779007

TBR=davemoore@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202640

Review URL: https://codereview.chromium.org/16116003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202878 0039d316-1c4b-4281-b951-d872f2087c98

Simply restart WPR using the same port it was on before. The browser will still
be set up to point to that port.

I think we originally restarted the browser because we used to not explicitly
pass the ports to use to WPR. Now that those are stored in browser_backend,
they can stay stable across WPR restarts.

BUG=None
TEST=tools/perf/run_measurement --browser=android-content-shell page_cycler tools/perf/page_sets/top_25.json --page-filter="youtube|plus" --pageset-repeat=1 -v
NOTRY=True

Review URL: https://chromiumcodereview.appspot.com/15917016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202877 0039d316-1c4b-4281-b951-d872f2087c98

Symbols may now be in lib/ instead of lib.target/. I'm not sure whether this is
always the case or not.

BUG=None
TEST=None
NOTRY=True

Review URL: https://chromiumcodereview.appspot.com/16094010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202876 0039d316-1c4b-4281-b951-d872f2087c98

Previously, download rate was estimated as bytes_received/(current_time - download_start_time)

Although simple, this would react slowly to dynamic changes in download time, or user initiated pauses.

With this change, a ring buffer of the past 10 seconds of download time is used instead, and estimates are derived from that. It handles dynamic changes to bandwidth well. Pauses are handled reasonably well, as estimates are accurate after ten seconds - a better solution would be to clear the data rates when the user resumes from a pause. The main downside with this approach is it takes about 100 bytes of memory per active download, as well as adds some complexity.

BUG=16390
TEST=content_unittests

Review URL: https://chromiumcodereview.appspot.com/14697023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202874 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202873 0039d316-1c4b-4281-b951-d872f2087c98

Caused WebViewInteractiveTest.PopupPositioningMoved to fail on Mac dbg 10.6 and 10.7:
WebViewInteractiveTest.PopupPositioningMoved: 
[1326:263:0529/075351:INFO:gpu_command_buffer_stub.cc(468)] Created virtual GL context.
/Volumes/data/b/build/third_party/zope/__init__.py:19: UserWarning: Module twisted was already imported from /Volumes/data/b/build/third_party/twisted_10_2/twisted/__init__.pyc, but /System/Library/Frameworks/Python.framework/Versions/2.6/Extras/lib/python is being added to sys.path
import pkg_resources
/Volumes/data/b/build/third_party/zope/__init__.py:19: UserWarning: Module zope was already imported from /Volumes/data/b/build/third_party/zope/__init__.pyc, but /System/Library/Frameworks/Python.framework/Versions/2.6/Extras/lib/python is being added to sys.path
import pkg_resources
HTTP server started on 127.0.0.1:49950...
sending server_data: {"host": "127.0.0.1", "port": 49950} (36 bytes)
[1325:263:0529/075353:219402889538:INFO:CONSOLE(431)] "chrome.webRequest is not available: You do not have permission to access this API. Ensure that the required permission or manifest property is included in your manifest.json.", source: binding (431)
[1325:263:0529/075353:220201666944:INFO:CONSOLE(431)] "chrome.webRequest is not available: You do not have permission to access this API. Ensure that the required permission or manifest property is included in your manifest.json.", source: binding (431)
[1326:263:0529/075354:INFO:gpu_command_buffer_stub.cc(468)] Created virtual GL context.
[1326:263:0529/075355:INFO:gpu_command_buffer_stub.cc(468)] Created virtual GL context.
[1326:263:0529/075355:INFO:gpu_command_buffer_stub.cc(468)] Created virtual GL context.
[1325:263:0529/075356:222219659574:INFO:CONSOLE(18)] "webview.loadstop", source: chrome-extension://nnkmmcedebpphammhapimbckejdabddg/main.js (18)
[1325:263:0529/075356:222325071892:INFO:CONSOLE(33)] "onInput, value: C, step = 1", source: http://localhost:49950/files/extensions/platform_apps/web_view/popup_positioning_moved/guest.html (33)
[1325:263:0529/075356:222831052658:INFO:web_view_interactive_browsertest.cc(227)] DIFF: x = 42, y = 86
../../chrome/browser/extensions/web_view_interactive_browsertest.cc:237: Failure
Expected: (std::abs(diff.x() - left_spacing)) <= (threshold_px), actual: 18 vs 10
[1325:263:0529/075356:222837065116:INFO:CONSOLE(33)] "onInput, value: Chromium, step = 2", source: http://localhost:49950/files/extensions/platform_apps/web_view/popup_positioning_moved/guest.html (33)

> Blink roll 151349:151373
> 
> http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=151350:151373&mode=html
> TBR=
> BUG=
> 
> Review URL: https://chromiumcodereview.appspot.com/16194003

TBR=eseidel@chromium.org

Review URL: https://codereview.chromium.org/15904014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202872 0039d316-1c4b-4281-b951-d872f2087c98

BUG=244337

Review URL: https://chromiumcodereview.appspot.com/15915009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202871 0039d316-1c4b-4281-b951-d872f2087c98

Previously time calculations based on "now"-time taken when renderer processed resource notification messages.

Renderer time is calculated by interpolation based on taken values. Because of long JS evaluation or heavy rendering, "renderer" time range might be skewed.

To fix situation, "renderer" time should be taken when IPC messages are processed by renderer IO thread.

This patch adds message filter that supplies aforementioned messages with timestamps.


BUG=223836

Review URL: https://chromiumcodereview.appspot.com/14646006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202870 0039d316-1c4b-4281-b951-d872f2087c98

- delete prepopulated search engines from user prefs
- delete the default search engine from user prefs
- reset unmanaged and non-extension URLs to prepopulated list. 

New unit tests:
- TemplateURLPrepopulateDataTest.ClearProvidersFromPrefs
- TemplateURLServiceTest.ResetNonExtensionURLs
- TemplateURLServiceTest.ResetURLsWithManagedDefault

BUG=235037,244291

Review URL: https://chromiumcodereview.appspot.com/15572002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202869 0039d316-1c4b-4281-b951-d872f2087c98