- 25 Jul, 2020 40 commits
-
-
Peter Kotwicz authored
The flakiness is due to the timing-dependent value of TabStateBrowserControlsVisibilityDelegate#calculateVisibilityConstraints() the badly-named #mIsFullscreenWaitingForLoad in particular This CL also switches to using static imports for org.junit.Assert BUG=1108587 Change-Id: I6d87f7b2c0bd4e2402b49f43a2d9a96162f7c4da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314993 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Reviewed-by:
Glenn Hartmann <hartmanng@chromium.org> Cr-Commit-Position: refs/heads/master@{#791357}
-
David Bertoni authored
This CL splits an existing Cookies API test into two separate tests, which makes the bulk of the original test compatible with a Service Worker-based extension. It also adds that test to the other Cookies API tests that are run for both event page-based and Service Worker- based extensions. Bug: 1093066 Change-Id: If4ee1326a73a1c485d126bab54b2516f2892bc4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314876 Commit-Queue: David Bertoni <dbertoni@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#791356}
-
Anastasia Helfinstein authored
A bug was recently found where enabling Switch Access on the login screen leads to a series of crashes. This is a short-term fix which prevents the crash by removing the option to enable Switch Access when the login state is NOT_LOGGED_IN. R=katie@chromium.org TBR=skuhne@chromium.org AX-Relnotes: n/a. Bug: 1108808 Change-Id: Ie718cda7aaa8c544b0a0cc49615cd1b802f1d353 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316437 Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Reviewed-by:
Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#791355}
-
Lei Zhang authored
Bug: 61248,1094093 Change-Id: Id4afed57913d957a5f79e05c1720739d4cbccc32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316442Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#791354}
-
Avi Drissman authored
In the spirit of macOS Big Sur, which is labeled as macOS 11.0, introduce OS_MAC and OS_APPLE. OS_MACOSX implicitly included OS_IOS, which was confusing, so OS_APPLE is the new replacement for "macOS + iOS" and OS_MAC is the new replacement for "just macOS, not iOS". Bug: 1105907 Change-Id: I0f24ff5a74f07eaf2fe7b7fa17bdef7e82a514fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299189Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Leonard Grey <lgrey@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Auto-Submit: Avi Drissman <avi@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#791353}
-
Lan Wei authored
Since we will not use this experimental feature to transfer user activation through post message to autoplay videos in a cross-origin subframe without any user activation. We will delete the TransferUserActivationFrom function from browser and renderer, which is called from post message to transfer user activation from one frame to the other frame. We will also clean up the frame interfaces in browser/renderer in a follow-up CLs. Bug: 1067307 Change-Id: I10b960f7c68b7267013aa5ac78bab1ca5a1e8b13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293181Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Mustaq Ahmed <mustaq@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#791352}
-
Wez authored
Bug: 1078365 Change-Id: Ic1ebe2dea07d3329e6e66b243ea3261ee3c2a289 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309695 Auto-Submit: Wez <wez@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#791351}
-
Xiaoling Bao authored
Bug: 1068797 Change-Id: I93e9d0915abc26c89b2690122199002a0b55404f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2311041 Commit-Queue: Xiaoling Bao <xiaolingbao@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Reviewed-by:
S. Ganesh <ganesh@chromium.org> Cr-Commit-Position: refs/heads/master@{#791350}
-
Tomasz Wiszkowski authored
This change addresses the issue where zero suggestions are received ahead of onUrlFocusChange call being completed. As a result, both deferred keyboard popup and subsequent keyboard management may cease to function in the zero prefix state. Bug: 1109330 Change-Id: I5ff5c2ee2103b38ecf9c1b7d8cd53136b1f1a256 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2318312 Commit-Queue: Krishna Govind <govind@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#791349}
-
Piotr Pawliczek authored
In mDNS cache, names are compared in standard, case-sensitive way. However, according to RFC 6762 mDNS names are case-insensitive. As a result, chrome cannot resolve mDNS name if it has different capitalization than a corresponding field in mDNS record returned by a device. The only solution seems to be switching mDNS cache to a case-insensitive index. BUG=chromium:1108807 TEST=tested on atlas Change-Id: Ia641e82fd4f175c39d1a80f52b1111238bf50b4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315355 Auto-Submit: Piotr Pawliczek <pawliczek@chromium.org> Commit-Queue: Eric Orth <ericorth@chromium.org> Reviewed-by:
Eric Orth <ericorth@chromium.org> Cr-Commit-Position: refs/heads/master@{#791348}
-
Yicheng Li authored
This enables developing the dialog and related functionalities without having to worry too much about the view itself. Bug: b:156258540 Change-Id: If0dd36671742d9f2b3c576ef3d4f3a52577356ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298586 Commit-Queue: Yicheng Li <yichengli@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#791347}
-
Simon Zünd authored
R=petermarshall@chromium.org Bug: chromium:1063007 Change-Id: I85fcebe7a0934ee27270756ae02c6a06340bfad0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317227 Commit-Queue: Peter Marshall <petermarshall@chromium.org> Auto-Submit: Simon Zünd <szuend@chromium.org> Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#791346}
-
Aaron Colwell authored
Adding GetPartitionDomain() method to make it easier to determine the partition domain and reduce the need for calls to GetStoragePartitionConfigForSite(). There are a few cases where it is unclear whether the domain computed from the site URL actually matches what was returned by the new method, so these cases now call a new GetPartitionDomain() helper function on SiteInstance. This function preserves legacy behavior and will generate crash dumps if we encounter any situations where the config and storage partition disagree. Bug: 1085275 Change-Id: I4fd02a91cf702f3849010d3723bf7a223b723785 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252470 Commit-Queue: Aaron Colwell <acolwell@chromium.org> Reviewed-by:
-
Alice Wang authored
This CL adds subtitle to the web sign-in bottom sheet. Screenshot: https://crbug.com/1103328#c3 Bug: 1103328 Change-Id: I0a7bd47e069a9d1440805cb87c5e4e480eb95090 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310992Reviewed-by:
Alex Ilin <alexilin@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#791344}
-
Piotr Pawliczek authored
Quick fix for a bug introduced in CL:2204269. BUG=none, correction of typo made in other CL TEST=none, will be tested with other CL Change-Id: Ic97ac272545252942eb8f220336f414ac6cf90c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315347 Commit-Queue: Piotr Pawliczek <pawliczek@chromium.org> Auto-Submit: Piotr Pawliczek <pawliczek@chromium.org> Reviewed-by:
Sean Kau <skau@chromium.org> Cr-Commit-Position: refs/heads/master@{#791343}
-
Andrew Grieve authored
* Refactors more common logic for the three expectation file types into diff_utils.py * Changes sort order for proguard expectations so that they diff better * Output "actual_data" rather than .stamp files for expectation targets * Stop writing out .proguard_configs for all proguard runs * I don't think these files have been referenced for a long time, and the expectations file largely serves their purpose in a more discoverable way. * Don't define validate_expectations GN group unless it will have deps (to prevent thinking your GN args are correct when they are not). Bug: 1064151 Change-Id: I5394471e7defd2c2f7e2f2173097a11d830cde65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314265Reviewed-by:Mohamed Heikal <mheikal@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#791342}
-
Ilya Sherman authored
This header contains serialized and base64-encoded protocol buffers. This utility simply base64-decodes the serialized data, and then parses the proto via compiled JSPB parsing. THis is a reland of https://chromium-review.googlesource.com/c/chromium/src/+/2301121, restricting the new build target to only build on Linux. R=asvitkine, dpranke@google.com CC=mathias@chromium.org, yangguo@chromium.org Bug: 1103854 Change-Id: I30bd4d02f89b250c53c06068ab22e97d7fc279ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316448 Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Reviewed-by:
Mathias Bynens <mathias@chromium.org> Auto-Submit: Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#791341}
-
Maksim Sisov authored
Sets touch device list from cmd line only for non-ozone/X11 for now. ----- PS: Please note that this is a temp solution that will help to choose between ozone and non-ozone X11 build. The switch that will be used to choose the path is --enable-features=UseOzonePlatform. Once non-Ozone X11 path is removed (hopefully by Q1 2021 depending on how th finch trial goes), the wrapper will be removed. Please also note that it's impossible to build use_x11 && use_ozone without some hacks in PlatformCursor code. The changes to that are on their way to upstream. ---- Bug: 1085700 Change-Id: Iffc4c78d2911d13ace9cc5661c49b69243a6b63c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315886Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Maksim Sisov (GMT+3) <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#791340}
-
rbpotter authored
Fixed: 1060620 Change-Id: I5a2ba1bf079154436cab53fa3c3765b6948001ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317779Reviewed-by:
dpapad <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#791339}
-
Alex Rudenko authored
To test variable font support, an open source variable font Amstelvar is added to web_tests/third_party. The font is licensed under SIL Open Font License 1.1. The font contains 17 variable axes and multiple languages. Font source: https://github.com/TypeNetwork/Amstelvar Bug: 1101236 Change-Id: Ic3c2595a9952b98255ee2c38554384213b6e4565 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2291890Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Max Moroz <mmoroz@chromium.org> Commit-Queue: Alex Rudenko <alexrudenko@chromium.org> Cr-Commit-Position: refs/heads/master@{#791338}
-
Tim Judkins authored
Adds several user actions for interacting with the site access settings on an extension's settings page. The user actions are specific to the interface for extensions with "all_url" like host permissions requested and don't cover the interface for extensions with a specific list of hosts requested in their permissions. For descriptions of the new user actions, check the changes to actions.xml Bug: 1102658 Change-Id: Iaaa547f3eec40c7fa4db84ff0724076cc700f18e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298177 Commit-Queue: Tim Judkins <tjudkins@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#791337}
-
Asanka Herath authored
R=pauljensen@chromium.org Bug: 973801 Change-Id: I245cf214f86b56d1e304ae252e23039417db4631 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315168 Commit-Queue: Paul Jensen <pauljensen@chromium.org> Auto-Submit: Asanka Herath <asanka@chromium.org> Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Cr-Commit-Position: refs/heads/master@{#791336}
-
Will Cassella authored
This moves DefaultWebClientWorkerCallback out of the constructor for DefaultWebClientWorker and changes it to be a parameter for the `Start(CheckIs|SetAs)Default` methods. This allows it to be a base::OnceCallback instead of a base::RepeatingCallback. Bug: 1106803 Change-Id: I47887ce0ca1db3b469fd1edf86f4b824c45685eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315084Reviewed-by:
-
adamta authored
Loads action sheet on bottom of page when selecting the menu button from the NTP Discover feed header. Adds 2 actions: 'Manage Interests' and 'Learn More' which both open a URL in the current tab. Bug: 1085419 Change-Id: Ieaa7785d5dfb0c34575828d5551b53b4b8b1a0fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2305910Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Adam Trudeau-Arcaro <adamta@google.com> Cr-Commit-Position: refs/heads/master@{#791334}
-
Matt Menke authored
Bug: None Change-Id: I6320f03659e1da209182c3b2baa4b933c2946489 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316534Reviewed-by:
Eric Roman <eroman@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#791333}
-
Xing Liu authored
Currently we implement date time picker using clank modal dialog system and embedded the DatePicker and TimePicker view inside of it. However Android uses hard code width for the date picker, and these embedded view implementations will keep changing across Android versions. This CL adds an implementation that uses Android's DatePickerDialog and TimePickerDialog API to implement the download later date time picker. Test will be added in a separate CL. Bug: 1107611 Change-Id: If64cfe710ca509eff0c9591a3451ff34f30c8b00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315481Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#791332}
-
Wez authored
When launching the browser process for a new fuchsia.web.Context, set it to be the "critical" process for its job. This causes the kernel to automatically terminate all child processes of the Context, in the event of the browser process terminating unexpectedly. Bug: 1109148, fuchsia:56992 Change-Id: Ia4b5d51362039f301609dc9b23a4ffbe48a5d151 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316260 Commit-Queue: Wez <wez@chromium.org> Auto-Submit: Wez <wez@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#791331}
-
Alex Turner authored
Due to the extension of certain templates, the current header declaring the WTF::String overload of IdentifiabilityDigestHelper must be included before the main file, which complicates adding new users. We are also unable to add the template to the main file directly as that would be a layering violation and as we aim to reduce the usage of complicated templates. We thus change the approach to no longer define a template overload and to instead define a helper that converts the WTF::String into an IdentifiabilityToken. This helper is moved to blink/platform so that it is available outside of canvas2d. The canvas IdentifiabilityStudyHelper and its callers are modified correspondingly. They now use an IdentifiableTokenBuilder to incrementally compute its IdentifiableToken. Bug: 1102935 Change-Id: I5e7a56f629c9a5e15a07ec617932db9a4ef0b90f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212974Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Caleb Raitto <caraitto@chromium.org> Reviewed-by:
Asanka Herath <asanka@chromium.org> Commit-Queue: Alex Turner <alexmt@chromium.org> Cr-Commit-Position: refs/heads/master@{#791330}
-
Katie Dillon authored
This QueueType is unused. Change-Id: I1282a6edd341acd8530993341e2026f19108f186 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2305034Reviewed-by:
Scott Haseley <shaseley@chromium.org> Commit-Queue: Katie Dillon <kdillon@chromium.org> Cr-Commit-Position: refs/heads/master@{#791329}
-
Kyle Ju authored
Modify directory_owners_extractor.py to support the new format. See https://docs.google.com/document/d/12NIyfEpSZvVG95ypw78uA-1EiwSByVVZ-Xyl43EGpLI/preview for more information. Bug: 1102543 Change-Id: Icaa8f42f056d911f2800186826ccf695bcc988de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315216 Commit-Queue: Robert Ma <robertma@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#791328}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/4d9cadd58aea..0d158ac68107 2020-07-23 kainino@chromium.org Fix some bugs in buffer mapping in the wire client 2020-07-23 cwallez@chromium.org Implement sampleMask in D3D12 and OpenGL. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: Iefcd0695f25fa0109a97178ae655ffd135827522 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314842Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#791327}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1595505150-b920bff7e4a91d427dfc50f17f264391e8fbe691.profdata to chrome-mac-master-1595560196-304c2c3cd13e1a2835ed6d3cda951db2ffc9e342.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I3580e51a9ef8d740d553c2a37ddde8ca8b26b62c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316993Reviewed-by:
-
Utkarsh Patankar authored
This CL adds an error message to be shown when the DNR extension fails to load because the "rule_resources" in the manifest is not specified as a list of resource(s). This CL also updates PopulateItem util functions by removing the redundant checks to verify that the input is of dictionary type because that is verified by the Populate function that they call. Bug: 1105098 Change-Id: I94efca130f2c1937afd36e08f5efc4308dfbe761 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2297208 Commit-Queue: Utkarsh Patankar <utkpat@microsoft.com> Reviewed-by:
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=govind@chromium.org Change-Id: I3d11a3837bf3fb4a37a204aedbb36ca3386785b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2318727Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#791324}
-
Livvie Lin authored
This CL also componentizes the IDN spoof checker heuristic. Change-Id: I674775cbe8dd19a2ca02551d2a72b39c782ffb82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315082 Commit-Queue: Livvie Lin <livvielin@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#791323}
-
Ali Juma authored
This CL adds arguments related to real-time lookups to the version of SafeBrowsingUrlCheckerImpl's constructor that's used on iOS. Bug: 1103220 Change-Id: I9b095860b5801e48b77e55213a1ccfd88f39e7f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314690Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Ali Juma <ajuma@chromium.org> Cr-Commit-Position: refs/heads/master@{#791322}
-
Jonathan Freed authored
This CL fixes the following issues with the action upload: 1 - removes unnecessary URL params 2 - change content type to application/x-protobuf 3 - change the request body to use the FeedActionRequest proto instead of ActionRequest Bug: b/160975622, 1108999 Change-Id: I15343ee2dcb149417932323a51055e126ffd5075 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309002Reviewed-by:
Dan H <harringtond@chromium.org> Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Commit-Queue: Jonathan Freed <freedjm@chromium.org> Cr-Commit-Position: refs/heads/master@{#791321}
-
Alex Gough authored
On Windows 10 we can ask Windows to associate a process with a job at startup. This reduces the time during which the process handle can be used to launch more processes. Prior to Windows 10 we retain the existing call to AssignProcessToJobObject. Existing tests should cover this change. I have manually verified that processes are associated with Jobs using SysInternals ProcExp. Bug: 1050359 Change-Id: I339e42be7f30cf0e59554e89f4855dcd3af4d499 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308916Reviewed-by:
Will Harris <wfh@chromium.org> Commit-Queue: Alex Gough <ajgo@chromium.org> Cr-Commit-Position: refs/heads/master@{#791320}
-
Jun Mukai authored
Previously, ForceUiTabletModeState uses kLockInTabletMode and kLockInClamshellMode, and use forced_ui_mode_ to enforce the tablet-mode state. However, this turns out not correct on the handling of screen_orientation_controller. To make ScreenOrientationController (and maybe some other entities) work with testing situation, ForceUiTabletModeState should set is_in_tablet_physical_state flag. In this CL: - change a simple 'force_physical_tablet_state' boolean to tri-state. - introduce new TabletModeBehaviors for the new states. - since it is considered to be 'physically tablet' status but we don't want to auto-rotate the screen due to accelerometer, create a new callback and add a mechanism to suppress the auto rotation. This CL does not change all existing ash unit tests -- that will be done in another CL. Bug: b/161253230 Test: ScreenOrientationControllerTest, tast arc.WMNonresizableConversion, make sure the screen orientation Change-Id: Ic48f8570df103fe58336faa675f9c1753bb63ee8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310773 Commit-Queue: Jun Mukai <mukai@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#791319}
-
edchin authored
Change-Id: Ia3735d1eb3f475e74f913dad24aa4e109004f420 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317086 Commit-Queue: edchin <edchin@chromium.org> Reviewed-by:
Eric Noyau <noyau@chromium.org> Cr-Commit-Position: refs/heads/master@{#791318}
-
