GitLab

Convert remaining allocations from new to MakeGarbageCollected

R=haraken@chromium.org

Bug: 757708
Change-Id: I6528c69803088728cf4dfd89ed3b6b5ac4969ad8
Reviewed-on: https://chromium-review.googlesource.com/c/1356720Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Keishi Hattori <keishi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612641}

Using wpt-import in Chromium 460a5861.

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

NOAUTOREVERT=true
TBR=kyleju

No-Export: true
Change-Id: Ie486d5c1e36524030ba93276536636151d42f4f2
Reviewed-on: https://chromium-review.googlesource.com/c/1356819
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#612640}

MessageLoop will go away, eventually.

BUG=891670

Change-Id: I5911ca044c8632a77ed851a148892db34e8ed7c6
Reviewed-on: https://chromium-review.googlesource.com/c/1352416Reviewed-by: Martin Šrámek <msramek@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Commit-Queue: Carlos Caballero <carlscab@google.com>
Cr-Commit-Position: refs/heads/master@{#612639}

The previous logic depended on GetUploadToGoogleState, which we changed
to return false in Butter mode.

BUG=906630
R=treib,sebsg

Change-Id: I42c40c20d6d997d571b427b512fe1afc9fd50329
Reviewed-on: https://chromium-review.googlesource.com/c/1354448
Commit-Queue: Florian Uunk <feuunk@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612638}

This CL reorders calls in SyncTestRule so AndroidSyncSettings instance
is overridden before activity is started. This is done to prevent
classes initialized during activity initialization from grabbing
a reference to the default AndroidSyncSettings.

Bug: 903657, 903658, 906188, 906193, 906788
Change-Id: Ib412d7748a8ec6f48b80436051a932d6b7713940
Reviewed-on: https://chromium-review.googlesource.com/c/1356583Reviewed-by: Marc Treib <treib@chromium.org>
Commit-Queue: Boris Sazonov <bsazonov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612637}

This CL makes sure the bounds on the serialized node created
in ax_root_obj_wrapper.cc are set. Previously, this was left
as 0,0 and due to recent condition added to ui_event_generator.cc,
this was preventing auto generated LOAD_COMPLETE event from
firing on the desktop tree. (See ShouldFireEvent function).

Also removed all #if !defined(IS_CHROMECAST) as they had no
    effect anyway (the define was never set). No reason to omit
    this code for chromecast anyway.

Change-Id: Ifff95227a8b07349e5401678f9428a85b803ca01

      screen reader.  No issues detected.  Did the same on
      Chromecast smart display. Same.

Bug: 910325
Test: Manual install on Samus ChromeOS device, activated
Change-Id: Ifff95227a8b07349e5401678f9428a85b803ca01
Reviewed-on: https://chromium-review.googlesource.com/c/1355551Reviewed-by: David Tseng <dtseng@chromium.org>
Commit-Queue: Randy Rossi <rmrossi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612636}

...and update the tests that depended on overriding it.

Bug: 884159
Change-Id: Iac892550720e19ee5d334f0598413b7e225b8338
Reviewed-on: https://chromium-review.googlesource.com/c/1356704Reviewed-by: Florian Uunk <feuunk@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612635}

When Clear-Site-Data is triggered during a ServiceWorker update request,
there is a deadlock because the update task is waiting for the request,
the request is waiting for Clear-Site-Data, Clear-Site-Data is waiting
for the unregistration of the service worker and the unregistration is
waiting for the update task.
This is fixed by cancelling the update task and removing the service
worker without updating it.
Also requests from Service Workers are not associated with a
WebContents, so we need a better way to get a BrowserContext for these
requests.

Bug: 898465
Change-Id: I543b44e07720cf1849d1d4245ee7d36ec762efb6
Reviewed-on: https://chromium-review.googlesource.com/c/1348058Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Christian Dullweber <dullweber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612634}

Bug: 896125
Change-Id: I077a839ab900d3e8b966b50ed914b055be4c39eb
Reviewed-on: https://chromium-review.googlesource.com/c/1349221Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Reviewed-by: Sergey Poromov <poromov@chromium.org>
Commit-Queue: Vladislav Kuzkokov <vkuzkokov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612633}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/989acc20a7d1..397651f864da


Created with:
  gclient setdep -r src-internal@397651f864da

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: I1d7a0829ca2e2ab4f648622abc315a0337cb8b33
Reviewed-on: https://chromium-review.googlesource.com/c/1356621Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#612632}

This is better than onUrlUpdated for two reasons:
1. It's more correct as now we know whether the navigation was committed.
2. The timing is a bit closer to the moment the page content is rendered,
so there is less time when the new top bar shows on the old tab contents.

Bug: 882404
Change-Id: I571aaa2a38168e18b7c0c99feb818055d14add3b
Reviewed-on: https://chromium-review.googlesource.com/c/1355170Reviewed-by: Peter Conn <peconn@chromium.org>
Commit-Queue: Michael van Ouwerkerk <mvanouwerkerk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612631}

TBR: bsheedy@chromium.org
Bug: 910549
Change-Id: I92700a06daf98166dd6e0ebb6230748ecc9ee74a
Reviewed-on: https://chromium-review.googlesource.com/c/1356550Reviewed-by: Alexandr Ilin <alexilin@chromium.org>
Commit-Queue: Alexandr Ilin <alexilin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612630}

This CL removes ProcessInitializationHandler.initializePreNative call
from SigninTestUtil (it's no longer necessary to initialize
AccountManagerFacade before overriding it with a test instance).

Bug: 738533
Change-Id: Ieb9f3afe6b7ed59570b899b667e14a14293abebb
Reviewed-on: https://chromium-review.googlesource.com/c/1355197Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Commit-Queue: Boris Sazonov <bsazonov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612629}

RequestStop(KEEP_DATA) has been replaced by
SyncUserSettings::SetSyncRequested(false). RequestStop(CLEAR_DATA) is
being replaced in this CL by a new StopAndClear().

Bug: 884159
Change-Id: I0d94ee4e834114c062c79bfc10c188276cc294d8
Reviewed-on: https://chromium-review.googlesource.com/c/1353944Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612628}

Also in this CL:
- Refactored onboarding screen to use RelativeLayout (anchor bottom) instead of hard-coded paddings.
- Adjusted paddings according to the mocks.
- The link in the T&C section is currently a stub.
- The image is now centered (previously, it was slightly too far to the right).

Before: https://screenshot.googleplex.com/Od2OhcbKq8y.png
After: https://screenshot.googleplex.com/QdZMisVFK2V.png

Bug: 806868
Change-Id: I1868020aac94c856780069dfd912ffa7fac60758
Reviewed-on: https://chromium-review.googlesource.com/c/1350887
Commit-Queue: Clemens Arbesser <arbesser@google.com>
Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Mathias Carlen <mcarlen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612627}

This removes checks for !IsLocalSyncEnabled() and IsSignedIn(), which
are implied by IsAuthenticatedAccountPrimary().
With this, IsSyncConfirmationNeeded is implemented fully in terms of
the public SyncService interface, which means we'll be able to move it
out of ProfileSyncService in a followup.

Bug: 884159
Change-Id: I532065b4517e2156c32b8eb91bf613ba23c4a267
Reviewed-on: https://chromium-review.googlesource.com/c/1356543Reviewed-by: Florian Uunk <feuunk@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612626}

The decision of whether the next candidate needs to be downloaded or not
should be independent of possible errors in the last download. Let's
move that logic to a dedicated predicate (ShouldDownloadNextCandidate())
and make sure it's honored in all codepaths (e.g. 404s,
or if image_skia.isNull()).

Bug: 895175
Change-Id: Id4d41ea873b62559c3d191952045f9c714fe729f
Reviewed-on: https://chromium-review.googlesource.com/c/1350631
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Reviewed-by: Peter Kotwicz <pkotwicz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612625}

TBR=kojii@chromium.org,xioachengh@chromium.org,yosin@chromium.org

Change-Id: I062fb3026b2dd36aabc50f3f6334da9c9fb580b7
Reviewed-on: https://chromium-review.googlesource.com/c/1356701Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612624}

Also fixes Win7 AMD GPU bots to use win7-specific test suites and
not the generic test suite.

This adds the end2end tests to the following builders:
 - Mac FYI 10.14 Release (AMD)
 - Mac FYI 10.14 Release (Intel)
 - Mac FYI 10.14 Release (NVIDIA)
 - Mac FYI Debug (Intel)
 - Mac FYI Experimental Release (Intel)
 - Mac FYI Experimental Retina Release (AMD)
 - Mac FYI Experimental Retina Release (NVIDIA)
 - Mac FYI GPU ASAN Release
 - Mac FYI Release (Intel)
 - Mac FYI Retina Debug (AMD)
 - Mac FYI Retina Debug (NVIDIA)
 - Mac FYI Retina Release (AMD)
 - Mac FYI Retina Release (NVIDIA)
 - Mac Pro FYI Release (AMD)
 - Optional Mac Release (Intel)
 - Optional Mac Retina Release (AMD)
 - Optional Mac Retina Release (NVIDIA)
 - Optional Win10 Release (Intel HD 630)
 - Optional Win10 Release (NVIDIA)
 - Win10 FYI Debug (NVIDIA)
 - Win10 FYI Exp Release (Intel HD 630)
 - Win10 FYI Exp Release (NVIDIA)
 - Win10 FYI Release (Intel HD 630)
 - Win10 FYI Release (NVIDIA)

BUG=chromium:901830

Change-Id: I9ef3a3232f178c057f6d70dc3c989361967c4773
Reviewed-on: https://chromium-review.googlesource.com/c/1354923Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612623}

This CL enables _CheckForRelativeIncludes presubmit check for
third_party/blink.

Change-Id: Ida579dad3adb3d156b3ab6f800fdfd7e4c0559a2
Bug: 622551
Reviewed-on: https://chromium-review.googlesource.com/c/1356719Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612622}

Remove consent bump internals. This includes:
 - API + tests from UnifiedConsentService
 - Metrics
 - Feature state and flags

Bug: 906026
Change-Id: Ibc12bee6ea661061530e321fe9c9e45363792f9d
Reviewed-on: https://chromium-review.googlesource.com/c/1355162Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Commit-Queue: Thomas Tangl <tangltom@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612621}

Also:
 * make actions needed by CastWebContents{Fragment,View} in
   CastWebContentsIntentUtils public.
 * use generated annotation generated by java_cpp_enum on methods
   working with mentioned enums. This serves as documentation/pseudo
   type-safety and can be used by some tools (for example IDEs).

Test: NONE.
Bug: internal b/112463440.
Change-Id: I74c301c4bc20ae8c6c1353f5d082b533a93878ae
Reviewed-on: https://chromium-review.googlesource.com/c/1353932
Commit-Queue: Jan Lamecki <jachor@google.com>
Reviewed-by: Simeon Anfinrud <sanfin@chromium.org>
Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612620}

Using wpt-import in Chromium 7162ac5b.

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

NOAUTOREVERT=true
TBR=kyleju

No-Export: true
Change-Id: I939ae318d87ab3fa0b02c7e7127efbcb589dbb11
Reviewed-on: https://chromium-review.googlesource.com/c/1356639
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#612619}

AudioWorklet has "MessagePort" on the global object but not
"DOMException". The V8 Extras transferable streams implementation needs
"DOMException" to be on the global object so that it can copy it to the
bindings object and construct a DOMException when an object cannot be
cloned.

Disable transferable streams for audio worklet by not copying
"MessagePort" to the bindings object.

BUG=894838,910471

Change-Id: Ia3bd3a5610d4aa442671fab1c1dc9f20c5c4c5e9
Reviewed-on: https://chromium-review.googlesource.com/c/1356462Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Commit-Queue: Adam Rice <ricea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612618}

Add serialization and deserialization code for TransformStream. Each
TransformStream is serialized as two MessagePortChannels, one attached
to the readable side and the other attached to the writable. These
channels are stored in the |stream_ports| array after the channels for
ReadableStream and WritableStream objects.

Also add a two-argument (readable, writable) constructor for
TransformStream. This is used to create a TransformStream during
deserialization. The constructor does not touch JavaScript and cannot
fail. Also remove the |stream_| member from the TransformStream class as
it is no longer needed.

As with ReadableStream and WritableStream, the TransferableStreams blink
feature must be explicitly enabled to use this.

Rudimentary layout tests are included in this CL. Tests of backpressure
and other features will be added later.

A temporary copy of test-utils.js has been added to
http/tests/streams/resources to support the new tests. It will removed
again once they are upstreamed.

BUG=894838

Change-Id: I451d6a31947e8ea2df0178b5bd63300e9adc651e
Reviewed-on: https://chromium-review.googlesource.com/c/1354736Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Commit-Queue: Adam Rice <ricea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612617}

This CL moves
  //content/common/service_worker/controller_service_worker.mojom
to
  //third_party/blink/public/mojom/service_worker/controller_service_worker.mojom

Change-Id: I14e2c8619f7bb84ae839f1c8a2eb7c9e1aa9f6b4
Bug: 789846, 906991
Reviewed-on: https://chromium-review.googlesource.com/c/1355317Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612616}

TEST=unit_test
BUG=None

Change-Id: I4f349e770ed0d868cf967ab9dd99df1a4cc8e961
Reviewed-on: https://chromium-review.googlesource.com/c/1355909Reviewed-by: Yury Khmel <khmel@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Commit-Queue: Dominick Ng <dominickn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612615}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/46cbcf081bc5..989acc20a7d1


Created with:
  gclient setdep -r src-internal@989acc20a7d1

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: I65fa76cfeb732e27c410ee8d307383bab50d83fe
Reviewed-on: https://chromium-review.googlesource.com/c/1356619Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#612614}

Bug: 866868
Change-Id: I2c86c688d6d3df2a4506876724ba7c5fbc4290ad
Reviewed-on: https://chromium-review.googlesource.com/c/1347360Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Leszek Swirski <leszeks@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612613}

MessageLoop will go away, eventually.

BUG=891670

Change-Id: Ia3cab69f49adc2efd6cdec851186254aeb6e6e54
Reviewed-on: https://chromium-review.googlesource.com/c/1352756
Commit-Queue: Carlos Caballero <carlscab@google.com>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612612}

dice_browsertest.cc checks the |is_valid| param in its implementation of
IdentityManager::Observer::OnRefreshTokenUpdatedForAccount(). This param
is slated for removal (see bug), so we need to change this. Happily,
(or unhappily), the tests do not depend on this check; it can just be
removed.

Bug: 908412
Change-Id: Id59c9370bf8258d077de689ee5ba55fd67d89f2e
Reviewed-on: https://chromium-review.googlesource.com/c/1353893Reviewed-by: David Roger <droger@chromium.org>
Commit-Queue: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612611}

To simplify authentication error handling, this CL updates the
SigninErrorController to get its error state from the token service by
observing it.
This removes some coupling between the classes, and removes the
AuthStatusProvider mechanism, leading to an overall simplification of the code.

TBR=eugenebut

Bug: 836212
Change-Id: Ie9b849fcd804d4fe6b4787b277b27fb848cdf2dc
Reviewed-on: https://chromium-review.googlesource.com/c/1070154
Commit-Queue: David Roger <droger@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612610}

Clears the vertical constraints for reuse.
Removes extra vertical constraints from separator.

Bug: 878388, 845472
Change-Id: I5ba9efdacd2ac642361069b241a9e53956edc215
Reviewed-on: https://chromium-review.googlesource.com/c/1355137Reviewed-by: Yi Su <mrsuyi@chromium.org>
Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612609}

Bug: 845472
Change-Id: I3afc1e03c280c88cce039ac8d4a6b288edd7be78
Reviewed-on: https://chromium-review.googlesource.com/c/1355173Reviewed-by: Yi Su <mrsuyi@chromium.org>
Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612608}

Long-running bots have been removed and the buildbot master is gone.

Tbr: jbudorick@chromium.org
Bug: chromium:877018
Change-Id: If9e6ccbcf4ccb2e31ae1a76bb44ebdd22401a2fb
Reviewed-on: https://chromium-review.googlesource.com/c/1356580Reviewed-by: Patrik Höglund <phoglund@chromium.org>
Commit-Queue: Patrik Höglund <phoglund@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612607}

Convert (anonymous namespace), [A-C]* class allocations from new to MakeGarbageCollected

Bug: 757708
Change-Id: Ia7b39ef2c27c5b4e4f98086212de128a2fe1b3b4
Reviewed-on: https://chromium-review.googlesource.com/c/1348871Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Keishi Hattori <keishi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612606}

MessageLoop will go away, eventually.

BUG=891670

Change-Id: I81882f7148677e303550d5dc13bfffb74715ac57
Reviewed-on: https://chromium-review.googlesource.com/c/1352779Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Commit-Queue: Carlos Caballero <carlscab@google.com>
Cr-Commit-Position: refs/heads/master@{#612605}

HTMLElement::IsLabelable meant "this is a LabelableElement", and
now supersedes LabelableElement::SupportLabels.

This CL is a preparation to add support of <label> and 'labels' IDL
attribute to form-associated custom elements.

This CL has no behavior changes.

Bug: 905922
Bug: https://github.com/w3c/webcomponents/issues/187
Change-Id: I93868364d754df1b43b8269e539c29e29ab8e563
Reviewed-on: https://chromium-review.googlesource.com/c/1356177Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612604}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b75782c63717..46cbcf081bc5


Created with:
  gclient setdep -r src-internal@46cbcf081bc5

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:None
TBR=mmoss@chromium.org

Change-Id: I719d1705e776ae8f766f9bf56cf8a4940a3986f7
Reviewed-on: https://chromium-review.googlesource.com/c/1356381Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#612603}

TSAN will otherwise complain as this variable is accessed from multiple
threads.

This was found while running TSAN tests in https://crrev.com/c/1350917

Change-Id: I29761910a56ae8e29a205288ad1ddff57969d6ea

TBR=fdoray@chromium.org

Change-Id: I29761910a56ae8e29a205288ad1ddff57969d6ea
Reviewed-on: https://chromium-review.googlesource.com/c/1355183
Commit-Queue: Carlos Caballero <carlscab@google.com>
Reviewed-by: Alex Clarke <alexclarke@chromium.org>
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612602}