GitLab

TBR=nirnimesh@chromium.org
BUG=140760

Review URL: https://chromiumcodereview.appspot.com/10825197

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150078 0039d316-1c4b-4281-b951-d872f2087c98

BUG=139611
TEST=unit_tests

Review URL: https://chromiumcodereview.appspot.com/10843041

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150074 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150073 0039d316-1c4b-4281-b951-d872f2087c98

Depends on https://bugs.webkit.org/show_bug.cgi?id=92933
Not used anywhere yet, so no observable effect.

BUG=138550


Review URL: https://chromiumcodereview.appspot.com/10853010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150071 0039d316-1c4b-4281-b951-d872f2087c98

This depends on: http://codereview.chromium.org/10662003/

Based on the HTML to Platform Accessibility APIs Implementation Guide
(http://www.w3.org/TR/html-aapi/), add some new tests to assert the
correct behavior for computing the text alternative for a
checkbox, button, and text field, then fix the implementation to
match the test.

BUG=124314
TBR=dtseng

Review URL: https://chromiumcodereview.appspot.com/10823073

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150070 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150069 0039d316-1c4b-4281-b951-d872f2087c98

TBR=dimich@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10829187

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150068 0039d316-1c4b-4281-b951-d872f2087c98

TBR=oshima@chromium.org
BUG=104998
TEST=none

Review URL: https://chromiumcodereview.appspot.com/10836108

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150065 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150064 0039d316-1c4b-4281-b951-d872f2087c98

TBR=dimich@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10828171

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150063 0039d316-1c4b-4281-b951-d872f2087c98

Support for draggable regions hasn't landed yet, so we hard-code 20px of
draggable space at the top of the window.

BUG=130182
R=rsesek@chromium.org


Review URL: https://chromiumcodereview.appspot.com/10824004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150062 0039d316-1c4b-4281-b951-d872f2087c98

BUG=135197

Review URL: https://chromiumcodereview.appspot.com/10834168

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150061 0039d316-1c4b-4281-b951-d872f2087c98

They aren't compiled more, so it's safe to remove them. There references were
updated in previous patches.

BUG=125846
TBR=ben@chromium.org
NOTRY=True

Review URL: https://chromiumcodereview.appspot.com/10831173

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150060 0039d316-1c4b-4281-b951-d872f2087c98

Found with:

$ cppcheck --enable=all -j4 --force base 2> base-errors

R=jar@chromium.org
NOTRY=True


Review URL: https://chromiumcodereview.appspot.com/10827112

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150059 0039d316-1c4b-4281-b951-d872f2087c98

Switched to returning std::string instead of base::StringPiece in GetScaleFactorsAsString() as base::StringPiece does not take ownership of data passed to it in the constructor.

TBR=sky

Review URL: https://chromiumcodereview.appspot.com/10854003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150058 0039d316-1c4b-4281-b951-d872f2087c98

BUG=125846
TBR=ben@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10854002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150057 0039d316-1c4b-4281-b951-d872f2087c98

This change looks weird - sorry about that. On Mac, setNeedsDisplay-driven drawRect calls appear to be implemented with a software timer that is slightly slower than vsync. So in order to render aligned with Vsync we have to either use CVDisplayLink or call CGLFlushDrawable immediately when new frames arrive at the browser RWHVMac. CVDisplayLink adds a frame of latency, so we don't want to use that for rendering. So, we call CGLFlushDrawable immediately.

Calling CGLFlushDrawable is fine except when the window becomes non-visible, during which undocumented behavior kicks in: CGLFlushDrawable returns immediately, no longer throttled to vsync. So, we have the unfortunate task of manually throttling CGLFlushDrawable so that chrome doesn't spin while the window is hidden.

The implementation of manual throttling is to use CVDisplayLink to compute vsync frame counts, and compare that to the flush (swap) counts. If the swap count gets more than frames ahead of vsync, we sleep for 1 frame interval to simulate blocking on vsync.

NOTE: this code path is only for the non-threaded accelerated compositing path. It will not be triggered for the threaded compositing path because we won't render frames at faster than vsync unless there's a bug in the compositor thread scheduling logic.

BUG=139416

Review URL: https://chromiumcodereview.appspot.com/10828104

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150056 0039d316-1c4b-4281-b951-d872f2087c98

BUG=125846
TBR=ben@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10828170

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150055 0039d316-1c4b-4281-b951-d872f2087c98

However, Chrome generates images which are a combination of the toolbar icon from the default theme + a tint.
Added the ability for themes to store hidpi assets in the data pack such that the few hidpi assets which are generated are preserved when a user closes Chrome and reopens it.

Repro steps/steps for testing:
1) Run chrome with --force-device-scale-factor=2
2) Change the theme.
3) Close Chrome and relaunch with --force-device-scale-factor=2
4) Ensure that the toolbar buttons are still hidpi

Test=Manual, see instructions above
Bug=136888



Review URL: https://chromiumcodereview.appspot.com/10783015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150054 0039d316-1c4b-4281-b951-d872f2087c98

BUG=125846
R=ben@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10828151

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150053 0039d316-1c4b-4281-b951-d872f2087c98

This was left over from the transition to the IRT library: it is to
make the audio thread work when libppruntime is linked into the user
nexe (which is no longer supported) rather than into the IRT.

BUG=http://code.google.com/p/nativeclient/issues/detail?id=1691
TEST=run_ppapi_ppb_audio_browser_test (only run on Mac, not Windows or Linux)

Review URL: https://chromiumcodereview.appspot.com/10824171

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150052 0039d316-1c4b-4281-b951-d872f2087c98

R=pkasting@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10832107

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150051 0039d316-1c4b-4281-b951-d872f2087c98

This cl introduces a regression test for bug 138745, in which the
ftp_protocol_handler did not correctly return errors on requests with invalid
ports.

This bug was fixed in
http://codereview.chromium.org/10834053/

BUG=http://code.google.com/p/chromium/issues/detail?id=138735


Review URL: https://chromiumcodereview.appspot.com/10844004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150050 0039d316-1c4b-4281-b951-d872f2087c98

While registering the attached device path as file system, set the media
device name as file system name.

BUG=none
TEST=none
TBR=gbillock@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10824170

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150049 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150046 0039d316-1c4b-4281-b951-d872f2087c98

Change 143421 - Revert 142809 to re-enable Chrome to Mobile by default on trunk (after M21 branch).

Change 142809 - Revert 135840 to disable Chrome to Mobile by default on trunk (for M21 branch).

Change 135840 - Revert 135442 to re-enable Chrome to Mobile by default on trunk.
We passed the M20 branch point with Chrome to Mobile disabled, as intended.

Change 135442 - Disable Chrome To Mobile by default; enable via chrome://flags.
This feature should be disabled-by-default on M19; for immediate merge.

Don't revert http://crrev.com/130312 to keep the AboutFlags_disable-chrome-to-mobile UMA bin.
Note: Mac's ViewIDTests don't yet support VIEW_ID_CHROME_TO_MOBILE_BUTTON.

BUG=102709, 120905
TEST=Chrome To Mobile is disabled on trunk (for the M22 branch point).
TBR=msw@chromium.org,sky@chromium.org,nyquist@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10834171

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150041 0039d316-1c4b-4281-b951-d872f2087c98

BUG=http://wkb.urg/93186
TBR=tony

Review URL: https://chromiumcodereview.appspot.com/10852021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150037 0039d316-1c4b-4281-b951-d872f2087c98

R=atwilson@chromium.org
TBR=stevenjb@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10831155

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150036 0039d316-1c4b-4281-b951-d872f2087c98

It appears that the crash occurs when the V8ValueConverter is passed an object
that has a named callback (v8::Object::HasRealNamedCallbackProperty()) that
is an internal property (something that is not defined in JS, but intercepted by
the c++ side).

Something like a DOM input element is a good example of this.
The crash doesn't happen with every object that has internal properties and
named callbacks, but so far I am unable to figure out how to programatically
differentiate between the ones that will crash and the ones that won't.

My current solution is to not convert any named callback.
BUG=139933


Review URL: https://chromiumcodereview.appspot.com/10837066

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150035 0039d316-1c4b-4281-b951-d872f2087c98

The menu item ("Clear Local Cache") is on the menu only when pressing Ctrl key, as discussed at crbug.com/135197.

BUG=135197
TEST=manual

Review URL: https://chromiumcodereview.appspot.com/10850038

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150034 0039d316-1c4b-4281-b951-d872f2087c98

BUG=83382


Review URL: https://chromiumcodereview.appspot.com/10826153

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150033 0039d316-1c4b-4281-b951-d872f2087c98

TBR=finnur@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10832132

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150032 0039d316-1c4b-4281-b951-d872f2087c98

No idea why this doesn't work sometimes. It works for me but
not for others. Maybe which verison of XCode?

BUG=83382


Review URL: https://chromiumcodereview.appspot.com/10826152

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150029 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none


Review URL: https://chromiumcodereview.appspot.com/10829184

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150028 0039d316-1c4b-4281-b951-d872f2087c98

This change reduces ~800 lines from gdata_file_system.cc
Along the way move some functions to gdata_util.h, which
are needed for gdata_file_system.cc and gdata_wapi_feed_loader.cc

BUG=138268
TEST=none; just move code around. should not change the behaviors
TBR=ben@chromium.org
for chrome_browser.gypi

Review URL: https://chromiumcodereview.appspot.com/10834170

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150027 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150026 0039d316-1c4b-4281-b951-d872f2087c98

This reinstates r150007, which was reverted in r150009.

TBR=piman@chromium.org
BUG=140412


Review URL: https://chromiumcodereview.appspot.com/10827173

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150024 0039d316-1c4b-4281-b951-d872f2087c98

BUG=139853,140628
TBR=oshima
Review URL: https://chromiumcodereview.appspot.com/10831171

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150023 0039d316-1c4b-4281-b951-d872f2087c98

* Add methods InitFromDB and SaveToDB to GDataDirectoryService, along with other helper methods to save/load the directory service from level db instead of from a proto file.
* Add a wrapper class GDataDirectoryServiceDB to hold the level db, with methods Create, Save, Read, Truncate, etc. This object lives on the blocking thread.
* Add CreateDBParams to facilitate creation of GDataDirectoryServiceDB on the blocking thread.
* Add GDataDirectoryService::FromProtoString to create a GDataEntry from a string saved in the db.
* Add unit tests for the db methods.
* Move LoadRootFeedParams to gdata_params. Move typedefs before struct definitions.
* Add a timer to measure the time to restore the filesystem from db or proto. For hugefileman, it's 3000 msec for db, and 2500 for proto, with debug code on a z600. Measurements on device TBD.

BUG=127856
TEST=unit tests, manual tests with hugefileman.
TBR=sky@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10800092
Patch from Achuith Bhandarkar <achuith@chromium.org>.

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150022 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TBR=zelidrag

Review URL: https://chromiumcodereview.appspot.com/10823122

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150021 0039d316-1c4b-4281-b951-d872f2087c98