- 10 Aug, 2018 40 commits
-
-
Xi Cheng authored
Since SampleOrderingSpec::MAY_SHUFFLE is the only one used in production code, there is no need to specify the SampleOrderingSpec parameter hence SampleOrderingSpec enum is also retired. Bug: 851163 Change-Id: Ie9bf7c39d036db55b1533c4fe3b3f3293a2a8dbf Reviewed-on: https://chromium-review.googlesource.com/1171584 Commit-Queue: Xi Cheng <chengx@chromium.org> Reviewed-by:
Mike Wittman <wittman@chromium.org> Cr-Commit-Position: refs/heads/master@{#582379}
-
Christopher Cameron authored
Disalbing the CATransactionGPUCoordinator caused memory corruption bugs to go away. Fix two potential bugs: 1. Don't post tasks (and potentially change the reference count) inside CATransactionGPUCoordinator's constructor. Do this in a separate explicit Init function. 1a. Move this initialization to the end of GpuProcessHost:Init (instead of being at the beginning of the constructor). 2. Make CATransactionCoordinator explicitly retain PostCommitObserver (which includes CATransactionGPUCoordinator). This fixes a bug whereby at shutdown, destroying not-yet-executed posted tasks caused the CATransactionGPUCoordinator to be destroyed while the CATransactionCoordinator still had a raw pointer to it. Bug: 871430 Change-Id: Ie144071cce9ce48e0187cdaf1fcf32df7b62ed75 Reviewed-on: https://chromium-review.googlesource.com/1171657 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#582378}
-
Donn Denman authored
Change-Id: I100542f77eb1ebebf28db6c716733467be61c209 Reviewed-on: https://chromium-review.googlesource.com/1168503Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#582377}
-
Eric Roman authored
Change-Id: Ibbde1b31fdeade51caf0cb70fefbe915bd7a9af6 Reviewed-on: https://chromium-review.googlesource.com/1169693 Commit-Queue: Eric Roman <eroman@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#582376}
-
Erik Chen authored
Before this CL, DevTools would crash the browser if it did not get a response in 5 seconds. This timeout is too low for Windows. On Catapult perf tests on Windows, it takes ~3 seconds for the GPU process to respond on average, and sometimes it takes more than 5 seconds. Bug: 873112 Change-Id: I67ee82a1a75df0ba9e1b483a58c66c56a8bf2213 Reviewed-on: https://chromium-review.googlesource.com/1170584Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#582375}
-
Sarah Hu authored
This will be used by both oobe and settings. Bug: 873229 Change-Id: I1bb3ff8e9666e967ff5445d68085801d009894d5 Reviewed-on: https://chromium-review.googlesource.com/1171243 Commit-Queue: Xiaoyin Hu <xiaoyinh@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Cr-Commit-Position: refs/heads/master@{#582374}
-
Gabriel Charette authored
https://cs.chromium.org/search/?q=%22base/task_scheduler%22&sq=package:chromium&type=cs will be empty after this CL TBR=fdoray@chromium.org Change-Id: I636ff813e461379acfb2822f58034cdd756e7d49 Reviewed-on: https://chromium-review.googlesource.com/1171108Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#582373}
-
Travis Skare authored
-Use originalURL if provided to dedupe against history. -Fix "typo" for corpus restrict request param (I missed it was renamed). -Sanitize title, provide default match data. Bug: 873290 Change-Id: Idc2d0dd92a6afedc7086c283fe85bb4257a800d3 Reviewed-on: https://chromium-review.googlesource.com/1171550Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Travis Skare <skare@chromium.org> Cr-Commit-Position: refs/heads/master@{#582372}
-
Derek Cheng authored
We've seen cases where Cast discovery code fails to pick up services from the ServiceDiscoveryDeviceLister, whereas chrome://inspect (CastDeviceProvider) is able to do so. Since Cast discovery's ServiceDiscoveryDeviceLister is only created once and is long-lived, this suggests it has gone into a bad state after a prolonged period. Compared to the CastDeviceProvider's ServiceDiscoveryDeviceLister, which gets created/destroyed when the inspect page is loaded/unloaded. To mitigate this issue, this patch uses the ForceDiscovery() signal to recreate a new ServiceDiscoveryDeviceLister in DnsSdDeviceLister and kick off the discovery using the new object, and to clear the set of services in the cache. This puts DnsSdDeviceLister in a clean state which will the current set of services to get through to the Cast discovery code. Bug: 850770 Change-Id: I3183e9d80f1a4a047b607fe5f844cdfc892f1463 Reviewed-on: https://chromium-review.googlesource.com/1166022 Commit-Queue: Derek Cheng <imcheng@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/master@{#582371}
-
Scott Violet authored
VisibilityChanged() tests the is_visible_ member before it's been set to any value. BUG=none TEST=none TBR=xiaohuic@chromium.org Change-Id: Ic2e95e1f5e615f1621431ab0bd2b8126bcfb87d2 Reviewed-on: https://chromium-review.googlesource.com/1171553Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#582370}
-
Martin Kreichgauer authored
This changes the GetAssertion operation for the Touch ID authenticator to locate credential IDs in the keychain at the beginning of the request. If no matching credential exists, the user is not prompted for a fingerprint. A method to locate a credential by ID is extracted from the existing code and moved into the Keychain class. This is done in anticipation of adding the WebAuthn UI. With the new UI, GetAssertion requests will only be sent to the Touch ID authenticator, if we know a matching credential ID to exist in the keychain. Bug: 871370 Change-Id: Ie5e4916df2a68bc0e9d7552322d6b993069ce95b Reviewed-on: https://chromium-review.googlesource.com/1163927 Commit-Queue: Martin Kreichgauer <martinkr@google.com> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#582369}
-
Peter Wen authored
Bug: 620034 Change-Id: I33a4437e3fe54f9b7d7ce234a823d4bb05c2046b Reviewed-on: https://chromium-review.googlesource.com/1169425 Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Cr-Commit-Position: refs/heads/master@{#582368}
-
Adrienne Walker authored
Also, generally increase the timeout for layer tree tests. Most things don't need this, however the GL versions of pixel tests end up spending quite a bit of time to compile shaders. When run in parallel, this only exacerbates the problem and tests can time out. Be more generous so that folks stop turning off these tests. Bug: 872733 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I7c08212d454bf0d9ae6ea445fcb46b48b73aea88 Reviewed-on: https://chromium-review.googlesource.com/1171377Reviewed-by:
weiliangc <weiliangc@chromium.org> Commit-Queue: enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#582367}
-
Peter Kasting authored
Bug: 871812 Change-Id: I0e4ee3e6539a6e4fa6c48495782a75a74a71dbc3 TBR: mgiuca Reviewed-on: https://chromium-review.googlesource.com/1171681Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#582366}
-
Yuwei Huang authored
This CL finishes up the rest of the work of refactoring the audio playback logic on iOS. Bug: 868088 Change-Id: Iac4c240a8f98a1212bf65c056546f2f3ad14dd2d Reviewed-on: https://chromium-review.googlesource.com/1166339 Commit-Queue: Yuwei Huang <yuweih@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#582365}
-
Peter Kasting authored
Bug: 870732 Change-Id: I0c7c7a78d7acb2e96f0d0308a758a01059628aa7 TBR: mgiuca Reviewed-on: https://chromium-review.googlesource.com/1171738Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#582364}
-
Avi Drissman authored
This is platform convention. BUG=869564 TEST=as in bug Change-Id: I3a4dbec12c5047219f255694eb4251405422e8fe Reviewed-on: https://chromium-review.googlesource.com/1164307Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#582363}
-
Weidong Guo authored
Changes: Make the suggestion chip text length no longer than 192dip. Bug: 872948 Change-Id: I54bc24cfc5b0ecf50d05e8312413e72ca14276e9 Reviewed-on: https://chromium-review.googlesource.com/1171676 Commit-Queue: Weidong Guo <weidongg@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#582362}
-
Raphael Kubo da Costa authored
IWYU: std::unique_ptr needs <memory>. This fixes the libstdc++ build: In file included from ../../base/test/scoped_mock_clock_override.cc:5:0: ../../base/test/scoped_mock_clock_override.h:39:8: error: ‘unique_ptr’ in namespace ‘std’ does not name a template type std::unique_ptr<base::subtle::ScopedTimeClockOverrides> time_clock_overrides_; ^~~~~~~~~~ Bug: 818294 Change-Id: I3b92e51f2565b42869cf2400dd4d3654e112f0fb Reviewed-on: https://chromium-review.googlesource.com/1170837Reviewed-by:Charlie Andrews <charliea@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Raphael Kubo da Costa (CET) <raphael.kubo.da.costa@intel.com> Cr-Commit-Position: refs/heads/master@{#582361}
-
Yiming Zhou authored
This change allows the Captured Sites Automation Framework to replay interactions on iframes. As part of this change, I switched the automation framework to trigger the autofill popup by clicking on an input field instead of pressing the 'DOWN' key, which does not work in automation on some iframes. Also included in this change is a fix I made to address the issue that calling 'ASSERT' inside a test function does not abort the test. Change-Id: I15b30f878f04cb3ee2935879c2da4c474442ab27 Reviewed-on: https://chromium-review.googlesource.com/1161603 Commit-Queue: Yiming Zhou <uwyiming@google.com> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#582360}
-
Henrique Grandinetti authored
In some situations the next Time Window Limit was not calculated correctly, this caused the TimeLimitController to recalculate the time limit constantly. Bug: 873228 Change-Id: I6b88792aa6849774778d85d8dea2695192acc172 Reviewed-on: https://chromium-review.googlesource.com/1171114Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Reviewed-by:
Rahul Chaturvedi <rkc@chromium.org> Commit-Queue: Henrique Grandinetti <hgrandinetti@google.com> Cr-Commit-Position: refs/heads/master@{#582359}
-
Sam Maier authored
This reverts commit 108f9e6cb07bdf3327b8b62e3ad43703b854662d. Reason for revert: Just re landing now that gerrit is OK Original change's description: > Revert "Android: moving MediaUrlResolver tasks to thread pool" > > This reverts commit d20f6cb34484fbd5e7ca2c651974d71c62e2f4d0. > > Reason for revert:Due to Gerrit outage http://crbug.com/872722, we are reverting this CL. Please, re-land it after all clear is given. If you have questions, please ask on the bug. Sorry for the inconvenience. > > Original change's description: > > Android: moving MediaUrlResolver tasks to thread pool > > > > Currently, AsyncTask.execute() defaults to the SERIAL_EXECUTOR. This > > exector is good for preventing concurrency errors since it guarantees > > serial execution, but bad for performance since the entire app shares > > this single queue. > > > > It looks like this callsite can use the THREAD_POOL_EXECUTOR instead, > > since this use doesn't appear to rely on the concurrency guarantees that > > SERIAL_EXECUTOR provides. > > > > TBR= test file > > Bug: 869907 > > Change-Id: I5770f3f0211d2c10b28f2290973bbfd57bee53f0 > > Reviewed-on: https://chromium-review.googlesource.com/1159236 > > Commit-Queue: Sam Maier <smaier@chromium.org> > > Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> > > TBR=mlamouri@chromium.org,smaier@chromium.org > > Change-Id: I5cd823a033bb6443007734d4faf0e1ddf98de648 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 869907 > Reviewed-on: https://chromium-review.googlesource.com/1169854 > Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> TBR=mlamouri@chromium.org,tandrii@chromium.org,smaier@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 869907 Change-Id: I31b02f5b543f2fdb8b0b089f241d79ceb720a626 Reviewed-on: https://chromium-review.googlesource.com/1171702 Commit-Queue: Sam Maier <smaier@chromium.org> Reviewed-by:
Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#582358}
-
John Chen authored
TBR=crouleau@chromium.org Change-Id: Id77c7546989bed6f3fdb269abdc2bc2e976ca4cd Reviewed-on: https://chromium-review.googlesource.com/1171679Reviewed-by:
John Chen <johnchen@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#582357}
-
Joshua Bell authored
Spec work has moved into the WICG repository, so update links: Explainer: https://github.com/WICG/web-locks/ Spec: https://wicg.github.io/web-locks/ Bug: 161072 Change-Id: I450beb25d8a7c9c0a80b06b7e84d7ac8db3cece1 Reviewed-on: https://chromium-review.googlesource.com/1171213 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#582356}
-
Peter Kasting authored
This reverts commit 3963b98d. Reason for revert: Consistent failures in ProfileWindowWebUIBrowserTest.UserManagerFocusSingleProfile, see e.g. https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win7%20%2832%29%20Tests/36834 Original change's description: > cros: In OOBE, turn off scrolling if the screen fits in the container > > Bug: 855546 > Change-Id: I065c2bbd1e3db69dca3f8b18d40ce5beb09f9abd > Reviewed-on: https://chromium-review.googlesource.com/1162715 > Reviewed-by: Jacob Dufault <jdufault@chromium.org> > Reviewed-by: Alexander Alekseev <alemate@chromium.org> > Commit-Queue: Quan Nguyen <qnnguyen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#582312} TBR=alemate@chromium.org,jdufault@chromium.org,qnnguyen@chromium.org Change-Id: Icd9a6648582e8c49bcdbd4bd79d844745d54c2a9 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 855546 Reviewed-on: https://chromium-review.googlesource.com/1171703Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#582355}
-
Navid Zolghadr authored
We used to store whether the target of pointerevent has recieved pointerover event or not to handle this correctly when capture gets active or lost. But since then the spec has change which made this state unnecessary. Change-Id: I98eed286b47463d2e103495ec66750d01e3fe58b Reviewed-on: https://chromium-review.googlesource.com/1169918Reviewed-by:
Ella Ge <eirage@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Navid Zolghadr <nzolghadr@chromium.org> Cr-Commit-Position: refs/heads/master@{#582354}
-
Adrienne Walker authored
This could be handled in Skia, but there's already a context option for it, so just forward the workaround setting to that. Bug: 829614 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Iaeb625ea327b814d07854dd81eb0458598a0c137 Reviewed-on: https://chromium-review.googlesource.com/1169771 Commit-Queue: enne <enne@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#582353}
-
Sam Maier authored
This reverts commit c2af33f66d4079e4306fb698828d6d9d6d4fbe95. Reason for revert: Just re landing now that gerrit is OK Original change's description: > Revert "Android: moving FileEnumWorkerTask to thread pool" > > This reverts commit 5eb802f9e1b7c765f77ec4a61f7f448731c36811. > > Reason for revert: Due to Gerrit outage http://crbug.com/872722, we are reverting this CL. Please, re-land it after all clear is given. If you have questions, please ask on the bug. Sorry for the inconvenience. > > Original change's description: > > Android: moving FileEnumWorkerTask to thread pool > > > > Currently, AsyncTask.execute() defaults to the SERIAL_EXECUTOR. This > > exector is good for preventing concurrency errors since it guarantees > > serial execution, but bad for performance since the entire app shares > > this single queue. > > > > It looks like this callsite can use the THREAD_POOL_EXECUTOR instead, > > since this use doesn't appear to rely on the concurrency guarantees that > > SERIAL_EXECUTOR provides. > > > > Bug: 869907 > > Change-Id: I266476c44f16ade391dfef0e5a99d33494312598 > > Reviewed-on: https://chromium-review.googlesource.com/1161089 > > Reviewed-by: Finnur Thorarinsson <finnur@chromium.org> > > Commit-Queue: Sam Maier <smaier@chromium.org> > > TBR=finnur@chromium.org,smaier@chromium.org > > Change-Id: I890bfff82b7471f54948c03dea7d2820224e978f > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 869907 > Reviewed-on: https://chromium-review.googlesource.com/1169851 > Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> > Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> TBR=finnur@chromium.org,tandrii@chromium.org,smaier@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. TBR=Gerrit reland Bug: 869907 Change-Id: I4e07a7d43ae7f0af01a248f4c41d42699d041f30 Reviewed-on: https://chromium-review.googlesource.com/1171427Reviewed-by:
Sam Maier <smaier@chromium.org> Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#582352}
-
Max Moroz authored
Change-Id: I327542d2ec81be8d3d4240a82f7121c27c4994b3 Reviewed-on: https://chromium-review.googlesource.com/1169427Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Max Moroz <mmoroz@chromium.org> Cr-Commit-Position: refs/heads/master@{#582351}
-
Evan Stade authored
for both the active tab and the toolbar. This matches the bookmarks bar, i.e. PaintBackgroundAttachedMode. Bug: 866974 Change-Id: I3a86d2330bf09903f74359e433a4165e3e4d3e8e Reviewed-on: https://chromium-review.googlesource.com/1171216 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#582350}
-
Matt Menke authored
In particular, move Net.CertificateTransparency.MainFrameValidSCTCount from ResourceDispatcherHost to NavigationURLLoaderImpl. Bug: 859364 Change-Id: I2258fc36af30b64b76eb7c5bc2c1f9851bb0f1be Reviewed-on: https://chromium-review.googlesource.com/1168093 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Cr-Commit-Position: refs/heads/master@{#582349}
-
Luke Sorenson authored
This is to reflect non-forwards / non-backwards compatible changes to the interface between rtanalytics_main and librtanalytics.so due to the changes to incorporate the use of the Mojo IPC-based video capture service. Bug: 871884 Change-Id: I97c92be7143609026d34e824b29f524e1f386f11 Reviewed-on: https://chromium-review.googlesource.com/1165824Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Luke Sorenson <lasoren@chromium.org> Cr-Commit-Position: refs/heads/master@{#582348}
-
shyam authored
Creating an abstraction called CastAudioFocusRequest to handle backwards compatibility of AudioFocus methods in AudioManager. Merge-With: eureka-internal/191659 Bug: 112064938 Test: junit test Change-Id: I914cec6a6bd2179f02ab5fd6959fcf3157b3e637 Reviewed-on: https://chromium-review.googlesource.com/1165884Reviewed-by:
Simeon Anfinrud <sanfin@chromium.org> Commit-Queue: Shyamsundar Parthasarathy <shyamsundarp@chromium.org> Cr-Commit-Position: refs/heads/master@{#582347}
-
CJ DiMeglio authored
This CL allows for WebMediaPlayerMS to create a SurfaceLayerBridge and interface with it in order to use a Surface for video playback. Bug: 746182 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I39174499a7e659eeeef13a81f8f5679d5f73425a Reviewed-on: https://chromium-review.googlesource.com/1087587Reviewed-by:
Frank Liberato <liberato@chromium.org> Reviewed-by:
Emircan Uysaler <emircan@chromium.org> Commit-Queue: CJ DiMeglio <lethalantidote@chromium.org> Cr-Commit-Position: refs/heads/master@{#582346}
-
Ehsan Karamad authored
The WebViewBrowserPluginSpecificTest class includes tests which use a BrowserPluign-based GuestView. Since all GuestViews except MimeHandlerViewGuest are now based on cross-process frames, these tests should not be implemented as WebViewGuest tests anymore. This CL introduces a new chrome browser test target for such BrowserPluginSpecific tests where the tests instantiate a MimeHandlerViewGuest instead of a <webview>. Ideally, the tests should have lived with the rest of MimeHandlerViewTests in extension layer; however, due to chrome layer dependencies it is not possible. Bug: 659750, 533069, 330264, 870604 Change-Id: Ica252a60e94bad47cabbff8b9275b8f9fb05d7ae Reviewed-on: https://chromium-review.googlesource.com/1168734 Commit-Queue: Ehsan Karamad <ekaramad@chromium.org> Reviewed-by:
James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#582345}
-
Wez authored
The symbolization in the Fuchsia runner scripts is not set up to work with debug information partly split from the binary. Bug: 777008 Change-Id: Iedaf4fe56cc8092af21acfd0d244304982a6035c Reviewed-on: https://chromium-review.googlesource.com/1170440Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#582344}
-
Joe Mason authored
R=proberge Bug: 872748 Change-Id: I42ae9acf6bd189ef45543ddfa15521262c56b95f Reviewed-on: https://chromium-review.googlesource.com/1171549Reviewed-by:
proberge <proberge@chromium.org> Commit-Queue: Joe Mason <joenotcharles@chromium.org> Cr-Commit-Position: refs/heads/master@{#582343}
-
Peter K. Lee authored
Removed ExternalURLTabUsageRecorderTestCase since it contains only one disabled Earl Grey test. After some evaluation of the intention of the test, it is not clear what purpose it serves/served or whether the code being tested isn't already covered by unit tests. Bug: 852341 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I988f4fc5512b40f331db565af2424e03b5c23b79 Reviewed-on: https://chromium-review.googlesource.com/1171365Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Peter Lee <pkl@chromium.org> Cr-Commit-Position: refs/heads/master@{#582342}
-
Ehsan Karamad authored
Adding an entry 'guest_view' for all GuestView related files. Subscribing myself, wjmaclean@, and mcnee@ to the list. Bug: None Change-Id: I7751b3cb6d8b3163cdc7f1a11342a56a9cd2849b Reviewed-on: https://chromium-review.googlesource.com/1171215Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Ehsan Karamad <ekaramad@chromium.org> Cr-Commit-Position: refs/heads/master@{#582341}
-
Joanmarie Diggs authored
These three roles are part of reaching role parity with HTML5. As such, they should be exposed via platform accessibility APIs in the same way as their native host language counterparts. Thus just add them to the map of ARIA roles to internal roles. Bug: 849650 Change-Id: I9a513e187a5beccd57fc5c7306929b0fd194b6dd Reviewed-on: https://chromium-review.googlesource.com/1169476 Commit-Queue: Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#582340}
-