- 30 Nov, 2018 40 commits
-
-
Kurt Horimoto authored
FullscreenModel knows enough information to calculate these insets, so it makes sense for the calculation to occur there. Exposing the viewport insets in FullscreenController will allow chrome/ layer UI code to easily account for viewport adjustments. This API will be used to mask non-modal UIAlertController presentation. Bug: 674649 Change-Id: I469cb133ef5d27bffcd4de5070bd12820514740e Reviewed-on: https://chromium-review.googlesource.com/c/1339460 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#612538}
-
Sam McNally authored
Bug: 909056 Change-Id: If6daa91932bad99510e267ef91cc6808bceeccfa Reviewed-on: https://chromium-review.googlesource.com/c/1356162 Commit-Queue: Sam McNally <sammc@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#612537}
-
Kent Tamura authored
TBR=hiroshige@chromium.org Bug: 910139 No-Try: true Change-Id: Id37fd777ff192446fd37a1eec58f298b82334ca8 Reviewed-on: https://chromium-review.googlesource.com/c/1356170 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#612536}
-
Sammie Quon authored
Overview will show all windows related by transient on the same thumbnail. Currently we will get blank spaces since the MRU list may contain two windows related by transient, and the transient ancestor or descendant of the most recent window will get transformed onto the transient related windows thumbnail, leaving a blank space. Introduce a function which removes all transient descendants from a given list if their transient root exists in the same list. First usage is overview but may need to extend to alt tab in future. Test: ash_unittests WindowUtilTest.RemoveTransientDescendants Bug: 844829 Change-Id: Ic2f9b476bc353b50a197be8fcf7bb3f2e3d44c49 Reviewed-on: https://chromium-review.googlesource.com/c/1355249 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#612535}
-
Klaus Weidner authored
BUG=809826 Change-Id: I41250680f22aacac2c1f193276d5d0e0beaa2a00 Reviewed-on: https://chromium-review.googlesource.com/c/1356228Reviewed-by:
Matt Reynolds <mattreynolds@chromium.org> Commit-Queue: Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#612534}
-
Martin Kreichgauer authored
In [0], the U2F spec says to default the App ID to the originating site's Facet ID, which is (with some ambiguity) defined as the origin followed by a forward slash [1]. Firefox and cryptotoken, on the other hand, default the App ID to just the origin without any trailing path component. This change aligns Chrome's behavior for App IDs in WebAuthn with that of cryptotoken and Firefox. Also adds a check to ensure requests originating from cryptotoken do not have an empty App ID because they cannot be defaulted in any meaningful way. [0] https://fidoalliance.org/specs/fido-v2.0-id-20180227/fido-appid-and-facets-v2.0-id-20180227.html#determining-if-a-caller-s-facetid-is-authorized-for-an-appid [1] https://fidoalliance.org/specs/fido-v2.0-id-20180227/fido-appid-and-facets-v2.0-id-20180227.html#determining-the-facetid-of-a-calling-application Change-Id: Iab2c18f03fb92a150b00a56a1c39490e52188e0e Reviewed-on: https://chromium-review.googlesource.com/c/1356223 Commit-Queue: Martin Kreichgauer <martinkr@chromium.org> Reviewed-by:
Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#612533}
-
Sam McNally authored
Bug: 909056 Change-Id: I0134351962bb3332f90f9430751241f0bf6c2eb5 Reviewed-on: https://chromium-review.googlesource.com/c/1355304Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#612532}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a8224556fcd5..2913923e0dae Created with: gclient setdep -r src-internal@2913923e0dae The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:None TBR=mmoss@chromium.org Change-Id: Iceaec0eb03d97ed599a7d10e7cb91c00a15e71dd Reviewed-on: https://chromium-review.googlesource.com/c/1356127Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#612531}
-
Sam McNally authored
Bug: 909056 Change-Id: Ic571f2d16d9d906bc176d34f539e53f57b2acbb3 Reviewed-on: https://chromium-review.googlesource.com/c/1355301Reviewed-by:
-
Giovanni Ortuño Urquidi authored
The ArrayTraits specialization for base::span with a specified size was considered to be missing. This caused accessors in mojom traits that returned a base::span with a specified size to fail to compile with: error: static_assert failed due to requirement 'internal::AlwaysFalse<span<const unsigned char, 6> >::value' "Cannot find the mojo::ArrayTraits specialization. Did you forget to include the corresponding header file?" Change-Id: I61ab07f2a1f74ea2eb5073b2776c995ce86b6255 Reviewed-on: https://chromium-review.googlesource.com/c/1356159 Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#612529}
-
Noel Gordon authored
CL:1347648 removed google analytics from FilesApp so metrics_unittest, which was disabled on issue 842880, can now be deleted [1]. [1] The metrics_unittest test fixtures required a {analytics.Tracker}, which no longer exists in FilesApp. Bug: 847729, 860355 Change-Id: I0ec71ef837e747cd6647d7359546b9876d62dbc8 Reviewed-on: https://chromium-review.googlesource.com/c/1355303Reviewed-by:Stuart Langley <slangley@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#612528}
-
Robert Liao authored
From the available palette, this is the closest we can get to 4 without making the text actually look enabled. The contrast ratio of menus and textfields go from 2.61 to 3.68 and the contrast ratio of buttons go from 2.54 to 3.54. BUG=872524 TBR=pkasting@chromium.org Color change with accessibility approval. Change-Id: I3d5c917d5b4be193a78e950d021d97dceb4ab15d Reviewed-on: https://chromium-review.googlesource.com/c/1353947Reviewed-by:
Robert Liao <robliao@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#612527}
-
Dale Curtis authored
This is part 4/4 CLs to move the <audio>/<video> elements off of a synchronous API that can lead to renderer hangs and premature audio renderer errors. This changes the AudioRendererMixerPool API to require an AudioRendererSink and OutputDeviceInfo when providing a mixer. AudioRendererMixerInputs are subsequently changed to use the new API. Likewise AudioRendererImpl also now uses the asynchronous API. To simplify the async process, AudioRendererMixerInputs will only setup correctly when OutputDeviceInfo has been requested ahead of time, since that's the pattern that AudioRendererImpl will use. This also moves the NullAudioSink setup from WebAudioSourceProvider over to the AudioRendererImpl. This causes WebAudio to be disconnected from the element, but if audio isn't work anyways, it shouldn't matter. BUG=905506 TEST=updated tests, compiles, runs. R=olka Change-Id: I4edf89bb1e20cc91191a6eb97a0e38b6aeba68f8 Reviewed-on: https://chromium-review.googlesource.com/c/1347795 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Olga Sharonova <olka@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#612526}
-
Caleb Rouleau authored
This code doesn't do anything: The pageset_repeat option is used to set the default for the flag '--pageset-repeat'. The default is 1. If someone passes in --pageset-repeat=3 over the commandline then that will override this option either way. See https://goo.gl/JZ2yZQ. I am attempting to redesign this system a bit, and I noticed this code. Bug: 894254 Change-Id: I80da537180384f8b4b4ed25c87f9c9c8f814b2d5 Reviewed-on: https://chromium-review.googlesource.com/c/1356131Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#612525}
-
Sam McNally authored
Bug: 909056 Change-Id: I0ee41c828ba5c27c174dc51ade20d7b5fb6f0e80 Reviewed-on: https://chromium-review.googlesource.com/c/1351325Reviewed-by:
-
Giovanni Ortuño Urquidi authored
This reverts commit 92925c66. Reason for revert: WizardControllerDeviceState*Test timing out on linux-chromeos-dbg https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-dbg/9248 rowserTestBase received signal: Terminated. Backtrace: #0 0x7feb2e8b3fed base::debug::StackTrace::StackTrace() #1 0x7feb2e5addfa base::debug::StackTrace::StackTrace() #2 0x563fac6dc0f2 content::(anonymous namespace)::DumpStackTraceSignalHandler() #3 0x7feafb349cb0 <unknown> #4 0x7feafb4116d3 epoll_wait #5 0x7feb2e96353f epoll_dispatch #6 0x7feb2e956cc5 event_base_loop #7 0x7feb2e9073c9 base::MessagePumpLibevent::Run() #8 0x7feb2e63fbe6 base::MessageLoopImpl::Run() #9 0x7feb2e6eb322 base::RunLoop::Run() #10 0x563fa6018304 chromeos::WizardControllerDeviceStateTest::WaitForAutoEnrollmentState() #11 0x563fa5ffeb8f chromeos::WizardControllerDeviceStateExplicitRequirementTest_ControlFlowForcedReEnrollment_Test::RunTestOnMainThread() Original change's description: > cros: Remove WizardInProcessBrowserTest > > The base class convoluted the inheritance structure and it is simpler to > directly derive from InProcessBrowserTest. > > Bug: 899777 > Change-Id: I04b8e4d48d0a28a8d4481891d5379456df32d0d6 > Reviewed-on: https://chromium-review.googlesource.com/c/1345244 > Commit-Queue: Jacob Dufault <jdufault@chromium.org> > Reviewed-by: Maksim Ivanov <emaxx@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#612394} TBR=xiyuan@chromium.org,emaxx@chromium.org,jdufault@chromium.org Change-Id: I06cfea778c8246795a8bb8fdc9878812a1ab5d52 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 899777 Reviewed-on: https://chromium-review.googlesource.com/c/1356168Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#612523}
-
Luciano Pacheco authored
Fix |expandTreeItemInDirectoryTree| test helper function wait for folder to expand and set the focus on directory tree, this fixes the context menu tests that expects the focus in the directory tree to be able open context menu in the directory tree. Fix test |fileDisplayComputers| to pass the volume type because it was trying to expand Downloads volume and the wait for Downloads be expanded was failing, this test wants to expand Drive to be able to expand Computers within Drive. Change some selectors for Downloads to be compatible with MyFilesVolume flag enabled and disabled. Bug: 873539 Change-Id: I11ddd230746b8cc0804af818d9924146aa9b6da0 Reviewed-on: https://chromium-review.googlesource.com/c/1351977Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#612522}
-
Yoshifumi Inoue authored
This patch gets rid of unused function |PlainTextRangeTest::InsertHTMLElement()| for improving code health. Change-Id: I6f246b6a8f944acc3bfba119d08ad965edb5dd28 Reviewed-on: https://chromium-review.googlesource.com/c/1351320Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#612521}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 53095cfc. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: yhirano@chromium.org, mkwst@chromium.org, japhet@chromium.org: external/wpt/fetch NOAUTOREVERT=true TBR=kyleju No-Export: true Change-Id: I718561339218d07e74a35786d6d891194ccf654f Reviewed-on: https://chromium-review.googlesource.com/c/1356017 Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#612520}
-
Nate Fischer authored
This is necessary to remove downstream reflection which checks if the embedder is an instant app. We add the API upstream to avoid introducing another ApiHelperForO class downstream, since the base-layer one should be fine. R=paulmiller@chromium.org Bug: 910019 Test: None Change-Id: Ice29538bf15605e90bdff625fca4a85de2e4081e Reviewed-on: https://chromium-review.googlesource.com/c/1353997Reviewed-by:
Paul Miller <paulmiller@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#612519}
-
David Staessens authored
> This change splits up the test helpers target in separate encode, decode and > other helpers. Tests now only depend on what they actually need. This change > doesn't introduce any new code, but some things are moved to avoid weird > dependancies (such as encode helpers depending on frame mapper which depends on > decode helpers). > This change also moves code in the video_accelerator_unittest_helpers.h file > from the media to the media/test namespace. > > TEST=ran video/jpeg encode/decode tests on nocturne > > CQ-DEPEND=CL:1345670 > > BUG=879065,904337 > > Change-Id: I17704399c5724cbacc5611578e0dec22191e7a50 > Reviewed-on: https://chromium-review.googlesource.com/c/1345701 > Reviewed-by: Hirokazu Honda <hiroh@chromium.org> > Commit-Queue: David Staessens <dstaessens@chromium.org> > Cr-Commit-Position: refs/heads/master@{#610757} BUG=879065 Change-Id: I3c478745acdecc7bcbea089a079603c0c2472cdd Reviewed-on: https://chromium-review.googlesource.com/c/1351193Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Hans Wennborg <hans@chromium.org> Commit-Queue: David Staessens <dstaessens@chromium.org> Cr-Commit-Position: refs/heads/master@{#612518}
-
Jesse McKenna authored
Bug: 889029 Change-Id: I87d82881660aaec994fab40543463bf6e61963ee Reviewed-on: https://chromium-review.googlesource.com/c/1354322 Commit-Queue: Jesse McKenna <jessemckenna@google.com> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#612517}
-
Giovanni Ortuño Urquidi authored
Use a array<uint8, 6> in the BluetoothSystem mojom and std::array<uint8_t, 6> in the C++ Bindings. Bug: 870192 Change-Id: I3467a770646b9ea2587a8cbc656c2ff510e0149c Reviewed-on: https://chromium-review.googlesource.com/c/1341291Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
Ovidio Henriquez <odejesush@chromium.org> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#612516}
-
Scott Violet authored
They now get _client in the name. This is a straight move, without the name change. The name changes comes next (to preserve history). BUG=875111 TEST=covered by tests Change-Id: Idade23d886e9f79f641a03ce7e7ba0ea94e4a7df Reviewed-on: https://chromium-review.googlesource.com/c/1355493 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#612515}
-
Eric Roman authored
Bug: 906540 Change-Id: Ic0cae00166b1d3ffb85eb3dcae6f9df22a6252d8 Reviewed-on: https://chromium-review.googlesource.com/c/1356006Reviewed-by:
Tobias Sargeant <tobiasjs@chromium.org> Commit-Queue: Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#612514}
-
Giovanni Ortuño Urquidi authored
This reverts commit ff026011. Reason for revert: AddToHomescreen tests failing on Android CFI https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Android%20CFI/3851 JNI ERROR (app bug): expected jboolean (0/1) but got value of 255 as argument 2 to void org.chromium.chrome.browser.webapps.AddToHomescreenManager.onIconAvailable(android.graphics.Bitmap, boolean) Original change's description: >
👹 Add adaptable homescreen shortcuts for maskable icons. > > The Add to Homescreen feature will now consider "maskable" icons from > the web app manifest [1]. If a maskable icon is present and we are on > an Android O+ device, turn that "maskable" icon into an Android Adaptive > icon [2]. > > The icon is scaled to ensure that the safe zone is preserved [3]. > > [1]: https://w3c.github.io/manifest/#purpose-member > [2]: https://developer.android.com/guide/practices/ui_guidelines/icon_design_adaptive > [3]: https://github.com/w3c/manifest/issues/555#issuecomment-404097653 > > Bug: 904354 > Change-Id: Iedfe61ace0fda4ca7f3ed3da6a5d07f2bff81443 > Reviewed-on: https://chromium-review.googlesource.com/c/1341998 > Commit-Queue: Peter Conn <peconn@chromium.org> > Reviewed-by: Matt Giuca <mgiuca@chromium.org> > Reviewed-by: Peter Beverloo <peter@chromium.org> > Reviewed-by: Yaron Friedman <yfriedman@chromium.org> > Reviewed-by: Dominick Ng <dominickn@chromium.org> > Cr-Commit-Position: refs/heads/master@{#612218} TBR=yfriedman@chromium.org,peter@chromium.org,mgiuca@chromium.org,peconn@chromium.org,dominickn@chromium.org Change-Id: I2cccbcbd5fc01f68e1004516b470465db1e663ac No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 904354 Reviewed-on: https://chromium-review.googlesource.com/c/1356166Reviewed-by: -
Giovanni Ortuño Urquidi authored
This reverts commit 1d979043. Reason for revert: SandboxMacTests failing on Mac10.10 Tests https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.10%20Tests/36825 [ RUN ] SandboxMacTest.FontLoadingTest [1000:779:1129/160013.776478:988116558481:WARNING:test_suite.cc(257)] Test launcher output path /b/s/w/itucGTyo/.org.chromium.Chromium.qx9Sed/test_results.xml exists. Not adding test launcher result printer. Nov 29 16:00:13 vm132-m1.golo.chromium.org content_unittests[1000] <Error>: SeatbeltExecServer: Failed to initialize sandbox: -1 line 163: subpaths must not end with a slash [1000:779:1129/160013.839716:988179793263:FATAL:sandbox_mac_unittest.mm(177)] Check failed: result.server->InitializeSandbox(). 0 content_unittests 0x000000010519dc1f base::debug::StackTrace::StackTrace(unsigned long) + 31 1 content_unittests 0x00000001050d871f logging::LogMessage::~LogMessage() + 223 2 content_unittests 0x000000010170d8b2 content::(anonymous namespace)::CheckCreateSeatbeltServer() + 562 3 content_unittests 0x000000010170e389 content::FontLoadingProcess() + 473 4 content_unittests 0x0000000104587138 base::TestSuite::Run() + 104 5 content_unittests 0x000000010459f43a base::(anonymous namespace)::LaunchUnitTestsInternal(base::OnceCallback<int ()>, unsigned long, int, bool, base::OnceCallback<void ()>) + 282 6 content_unittests 0x000000010459f2ea base::LaunchUnitTests(int, char**, base::OnceCallback<int ()>) + 154 7 content_unittests 0x00000001044df9df main + 191 8 libdyld.dylib 0x00007fff8f5845c9 start + 1 ../../content/browser/sandbox_mac_unittest.mm:90: Failure Expected equality of these values: 0 rv Which is: 1 Stack trace: 0 content_unittests 0x0000000102cbd93b testing::internal::UnitTestImpl::CurrentOsStackTraceExceptTop(int) + 91 1 content_unittests 0x0000000102cbd2f9 testing::internal::AssertHelper::operator=(testing::Message const&) const + 89 2 content_unittests 0x000000010199ea19 content::(anonymous namespace)::SandboxMacTest::ExecuteWithParams(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, void (*)(sandbox::SeatbeltExecClient*)) + 1625 3 content_unittests 0x000000010199ca4c content::(anonymous namespace)::SandboxMacTest::ExecuteInRendererSandbox(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&) + 172 4 content_unittests 0x000000010199db5e content::SandboxMacTest_FontLoadingTest_Test::TestBody() + 1278 [ FAILED ] SandboxMacTest.FontLoadingTest (286 ms) Original change's description: > macOS Sandbox: Port fontloading test to V2 sandbox. > > This removes all of the obsolete unit testing code from the V1 sandbox. > > Bug: 902597 > Change-Id: I426e3b815e0bf23036815750aab350adbb22e068 > Reviewed-on: https://chromium-review.googlesource.com/c/1327527 > Commit-Queue: Greg Kerr <kerrnel@chromium.org> > Reviewed-by: Robert Sesek <rsesek@chromium.org> > Cr-Commit-Position: refs/heads/master@{#612416} TBR=kerrnel@chromium.org,rsesek@chromium.org Change-Id: I4731044d228c3b21778334b1ef2693baa1818239 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 902597 Reviewed-on: https://chromium-review.googlesource.com/c/1356165Reviewed-by:
-
bsheedy authored
Fixes an issue in the sizes script when converting from ChartJSON to HistogramSet. The data produced by the results collector does not contain the benchmark_name or format_version keys, which causes the conversion script to fail. Bug: 906685 Change-Id: I15258026651499ac2a7640958c7bd2d93a794a35 Reviewed-on: https://chromium-review.googlesource.com/c/1352395 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#612511}
-
Moe Ahmadi authored
- Creates a ARQuickLookCoordinator as the ARQuickLookTabHelperDelegate that presents a QLPreviewController in order to display USDZ format files. Bug: 908696 Change-Id: I7cee24392cd7133aa23127dd991b51694fabadfa Reviewed-on: https://chromium-review.googlesource.com/c/1353048 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#612510}
-
Leo Zhang authored
This flag is used by enabling an experimental IME Mojo service to replace the existing IME framework, the project might last for a few quarters until we are confident to get rid of old system. Before that, we want to keep the fallback possibility for users Change-Id: I010a8d3b21c7ff9e7a8a706bf604a1e501518717 Reviewed-on: https://chromium-review.googlesource.com/c/1345789Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Leo Zhang <googleo@chromium.org> Cr-Commit-Position: refs/heads/master@{#612509}
-
Esmael El-Moslimany authored
The position transitions cause a couple issues. 1. When the slider value is set after being retrieved asynchronously even if the retrieval is quick, the movement will transition from 0 to the retrieved value. This is a minor issue noted in https://crbug.com/896625. 2. Multiple arrow keyboard events, including repetition from holding down and arrow key, results in a delay in updating the position causing erratic movement of the knob. Bug: 910054 Change-Id: Ibc98638f1c9bda6531a8dea2648654e41a91e37f Reviewed-on: https://chromium-review.googlesource.com/c/1355760 Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#612508}
-
rajendrant authored
This CL creates a bool in WebSettings to enable lazyloading of frames and images. The bool is populated by WebContentsDelegate which offline pages listens to and disables lazy loading. Bug: 701884 Change-Id: I1ad1776adf3f9c7e6a8a3a68507aa9dc419e3955 Reviewed-on: https://chromium-review.googlesource.com/c/1352817 Commit-Queue: rajendrant <rajendrant@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Peter Williamson <petewil@chromium.org> Cr-Commit-Position: refs/heads/master@{#612507}
-
rbpotter authored
When the user changes focus between custom margins inputs, this causes the preview area to scroll, which should not occur since the iframe containing the plugin is in a fixed location. Work around this issue in the same way as in the old UI: manually set the offsets of the preview area element to 0. This workaround has the downside that the newly focused input is not visible to the user, and therefore key events cause another scroll, which is not addressed by the workaround. To address this issue, after setting the offsets, inform the plugin that it should scroll to make the input visible. Bug: 901777 Change-Id: If310b84229fd53ffaee449699b8ac8a13806101c Reviewed-on: https://chromium-review.googlesource.com/c/1351950Reviewed-by:
-
Alexei Filippov authored
BUG=901165 Change-Id: I1788e537ed29bab14558d12372bda59f2bfa8698 Reviewed-on: https://chromium-review.googlesource.com/c/1352850Reviewed-by:
Paul Irish <paulirish@chromium.org> Commit-Queue: Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#612505}
-
Donn Denman authored
Changes the title of the menu item from "Sneak peek" to "*New* Sneak peek" to help draw attention to the new choice. BUG=894619 Change-Id: I1446b191e8891f17452762b5dda4d6203c332510 Reviewed-on: https://chromium-review.googlesource.com/c/1355252Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#612504}
-
Ken Rockot authored
Replaces usage of the deprecated ServiceContext with ServiceBinding. Also adds support for a C++ ServiceMain which is passed a proper ServiceRequest instead of a raw Mojo handle. This makes writing ServiceMain slightly less awkward. Also cleans up service.gni using forward_variables_from, which was unsupported when it was originally written. Finally, removes the unused RegisterInProcessServices method from BrowserProcessPlatformPart/Base. Bug: 891780 Change-Id: I99734414586b6b3a355fa22afa85930249f8e62b Reviewed-on: https://chromium-review.googlesource.com/c/1355336 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
-
Vlad Tsyrklevich authored
The custom version of bits::CountTrailingZeroBits64 is deprecated by upstream support from https://crrev.com/c/1321253 Change-Id: Id091afc2c5bd2d8ba8969ec12248b4c89d4d9ee1 Reviewed-on: https://chromium-review.googlesource.com/c/1355248 Commit-Queue: Vitaly Buka <vitalybuka@chromium.org> Reviewed-by:
Vitaly Buka <vitalybuka@chromium.org> Cr-Commit-Position: refs/heads/master@{#612502}
-
Findit authored
This reverts commit faf5cdcc. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 612469 as the culprit for flakes in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vZmFmNWNkY2M4ZDJkODkwMDAzMzY5MmZhODYzNDAzYTE2ZTkwOTBjOQw Sample Failed Build: https://ci.chromium.org/buildbot/chromium.chromiumos/linux-chromeos-rel/16665 Sample Failed Step: single_process_mash_content_browsertests Sample Flaky Test: DumpAccessibilityTreeTest.AccessibilityVideoControls Original change's description: > Reland "[Accessibility] Volume slider reads out level in percentages." > > This is a reland of cf071719 > > Original change's description: > > [Accessibility] Volume slider reads out level in percentages. > > > > This CL makes it such that the volume level is read out as a percentage > > in aria. This CL also amplifies how the accessibility information is > > given to aria, by setting attributes instead of explicitly creating > > accessibility nodes. > > > > Bug: 905024 > > Change-Id: I0ee5a91215669f39c7394d3c8f113ae83a74cf00 > > Reviewed-on: https://chromium-review.googlesource.com/c/1337298 > > Reviewed-by: Nico Weber <thakis@chromium.org> > > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> > > Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> > > Commit-Queue: CJ DiMeglio <lethalantidote@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#612160} > > TBR=mlamouri@chromium.org, dmazzoni@chromium.org, thakis@chromium.org > > Bug: 905024 > Change-Id: Ie35c05c274dfd36f3e9ec0a32b587a98a62249d9 > Reviewed-on: https://chromium-review.googlesource.com/c/1356007 > Reviewed-by: CJ DiMeglio <lethalantidote@chromium.org> > Commit-Queue: CJ DiMeglio <lethalantidote@chromium.org> > Cr-Commit-Position: refs/heads/master@{#612469} Change-Id: Icc1f84da3c66189f0d3b30108e0ab4330d4061f5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 905024, 910442 Reviewed-on: https://chromium-review.googlesource.com/c/1356137 Cr-Commit-Position: refs/heads/master@{#612501}
-
Weidong Guo authored
After powerwash and sign in, the internal app item and page break item's positions may be out of sync because model updater is not set. Then the user has to wait til next sign in to get the most up to date position. During the first sign in, the user may reorder or install new apps which triggers single item page after next sign in. Changes: Set model updater for internal app and page break item. Bug: 873853 Change-Id: I492234ceaf107deffdba056856a4f0a3c5df59e0 Reviewed-on: https://chromium-review.googlesource.com/c/1355178Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Weidong Guo <weidongg@chromium.org> Cr-Commit-Position: refs/heads/master@{#612500}
-
Eric Roman authored
Bug: 721403 Change-Id: I879f2d2eb8a903bd59b459cb3267c890308da60d Reviewed-on: https://chromium-review.googlesource.com/c/1356220Reviewed-by:
rajendrant <rajendrant@chromium.org> Commit-Queue: Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#612499}
-
