GitLab

This patch contains a test page used for manually checking the
functionality of the Battery Status API. It is currently also
available at http://jsbin.com/battery-status-test.

BUG=

Review URL: https://codereview.chromium.org/464073003

Cr-Commit-Position: refs/heads/master@{#291203}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291203 0039d316-1c4b-4281-b951-d872f2087c98

BUG=403007
TBR=yurys@chromium.org

Review URL: https://codereview.chromium.org/493203003

Cr-Commit-Position: refs/heads/master@{#291202}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291202 0039d316-1c4b-4281-b951-d872f2087c98

(vs always opening on the first screen like it's happening now)

BUG=405602
TEST=Start Chrome with --enable-new-avatar-menu (if it's not own by default). If you've got to screens, when you press "Switch users" the User Manager should show up on whatever screen you triggered it from.

Review URL: https://codereview.chromium.org/489953002

Cr-Commit-Position: refs/heads/master@{#291201}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291201 0039d316-1c4b-4281-b951-d872f2087c98

BUG=405747

Review URL: https://codereview.chromium.org/493973002

Cr-Commit-Position: refs/heads/master@{#291200}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291200 0039d316-1c4b-4281-b951-d872f2087c98

This adds the ui/keyboard:keyboard_unittests target to the GN build and
adds the rest of ui/keyboard/webui/ to the build.  Since the webui bits
are the only parts that need mojo the mojo deps are restricted to that
source set.

R=sky@chromium.org

Review URL: https://codereview.chromium.org/493833002

Cr-Commit-Position: refs/heads/master@{#291199}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291199 0039d316-1c4b-4281-b951-d872f2087c98

The DataTypeManager is now in charge of reenabling previously failed types.

BUG=368834
R=maniscalco@chromium.org

Review URL: https://codereview.chromium.org/439903002

Cr-Commit-Position: refs/heads/master@{#291198}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291198 0039d316-1c4b-4281-b951-d872f2087c98

heap_profiler_unittests was previously a native executable target.
It turns out that we don't have the harness in place to run native
executable tests reliably on all Android versions due to the PIE
vs non-PIE issue (L vs ICS, see crbug.com/373219).
This caused a revert in crrev.com/416003005.
This change is making heap_profiler_unittests an apk target, following
the same pattern of the other tests we have in the codebase.
This change is also re-adding the tests to the the bot list.

BUG=393964

Review URL: https://codereview.chromium.org/465223005

Cr-Commit-Position: refs/heads/master@{#291197}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291197 0039d316-1c4b-4281-b951-d872f2087c98

A context factory is specific to a particular native viewport so we
shouldn't leak it between different WindowTreeHostImpl instances. This
fixes some crashes in mojo_view_manager_unittests.

R=sky@chromium.org

Review URL: https://codereview.chromium.org/494883002

Cr-Commit-Position: refs/heads/master@{#291196}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291196 0039d316-1c4b-4281-b951-d872f2087c98

- Some OEMs don't let us change the background, so the padding is incorrect.
- Also including sizing the menu too large causes clipping.

BUG=398837

Review URL: https://codereview.chromium.org/469673006

Cr-Commit-Position: refs/heads/master@{#291193}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291193 0039d316-1c4b-4281-b951-d872f2087c98

only when needed, and deleted as soon as they are no longer necessary.

Add methods to SSLClientSocketPool that are passed to the SSLConnectJob
and SSLConnectJobMessenger as callbacks. These allow the SSLConnectJob
to tell the SSLClientSocketPool to create a messenger for the job when
appropriate, and the SSLConnectJobMessenger to tell the
SSLCLientSocketPool to remove a messenger when appropriate. An
SSLConnectJob will now only create an SSLConnectJobMessenger if its
socket's session is not already in the session cache. The messenger
will then ask to be removed when there are no remaining pending or
connecting sockets in the messenger.

Written by Mackenzie Shelley <mshelley@chromium.org>
Original review URL: https://codereview.chromium.org/384873002/

R=rsleevi@chromium.org
TBR=mek@chromium.org
BUG=398967

Review URL: https://codereview.chromium.org/476313004

Cr-Commit-Position: refs/heads/master@{#291192}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291192 0039d316-1c4b-4281-b951-d872f2087c98

This CL enables usage of the Sync FakeServer in Android tests. This is
done by creating a new ChromeShell-based APK, ChromeSyncShell, and a
test APK that instruments it (ChromeSyncShellTest).

As part of this CL, previously-disabled tests (SyncTest.java) are
re-enabled. However, these tests will not run as part of the Chromium
waterfall/trybots as they are not configured to run ChromeSyncShellTest.

How to run the tests:
1) Build these targets:
   chrome_sync_shell_apk
   chrome_sync_shell_test_apk

2) Run test script
   build/android/adb_install_apk.py \
   --apk=ChromeSyncShell.apk && \
   build/android/test_runner.py instrumentation \
   --test-apk ChromeSyncShellTest

BUG=323265,348951,348117
TBR=cpu@chromium.org

Review URL: https://codereview.chromium.org/457883002

Cr-Commit-Position: refs/heads/master@{#291190}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291190 0039d316-1c4b-4281-b951-d872f2087c98

Shared Authentication is the only supported scheme starting with M39.
This CL removes the dependency on MutableProfileOAuth2TokenService
on iOS.

BUG=233117

Review URL: https://codereview.chromium.org/489113003

Cr-Commit-Position: refs/heads/master@{#291189}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291189 0039d316-1c4b-4281-b951-d872f2087c98

The code made assumptions about whether the window's root view was layer
backed. The CL that introduced the bug:
https://codereview.chromium.org/390503003/

BUG=NONE

Review URL: https://codereview.chromium.org/481273002

Cr-Commit-Position: refs/heads/master@{#291188}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291188 0039d316-1c4b-4281-b951-d872f2087c98

Some of the VDAs, like DXVA and AVDA, don't distinguish
between visible size and coded size. And given GVD is always
been used with container, we should keep using size from
config in GVD.

BUG=390048
TEST=Manually tested: flash player using youtube. html5
player with resolution 1280x720 and 1216x684, h264 and vp8.
apprtc with resolution 640x480 and 636x476. All tests are
performed on both daisy and link.
R=hshi@chromium.org, posciak@chromium.org

Review URL: https://codereview.chromium.org/426873004

Cr-Commit-Position: refs/heads/master@{#291187}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291187 0039d316-1c4b-4281-b951-d872f2087c98

Trackers for empty-title files were not handled in AddToPathIndexes()
and UpdateInPathIndexes(), while they are handled in RemoveFromPathIndexes().
So an entry in multi-backing lists could be inconsistent.

This CL fixes those two methods' behavior.


BUG=405448
TEST=./unit_tests --gtest_filter="MetadataDatabaseIndexOnDisk*"

Review URL: https://codereview.chromium.org/493643002

Cr-Commit-Position: refs/heads/master@{#291186}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291186 0039d316-1c4b-4281-b951-d872f2087c98

This patch implements Chart JSON for Telemetry, which represents a JSON format specifically for conveying data to Buildbot to be sent to the perf dashboard in charted/summarized form. 
Consult go/telemetry-json for further specs on this format.
This is an 0.1 since the overall metadata and description portions of the format are still in flux.

BUG=399970

Review URL: https://codereview.chromium.org/439613003

Cr-Commit-Position: refs/heads/master@{#291185}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291185 0039d316-1c4b-4281-b951-d872f2087c98

Galaxy S4 requires a surface texture in order for the media player to report correct video size.
So bind a texture to MediaPlayer whenever the video is HLS

BUG=400145

Review URL: https://codereview.chromium.org/478403002

Cr-Commit-Position: refs/heads/master@{#291184}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291184 0039d316-1c4b-4281-b951-d872f2087c98

permission and resource manager.

BUG=372607

Review URL: https://codereview.chromium.org/475193002

Cr-Commit-Position: refs/heads/master@{#291183}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291183 0039d316-1c4b-4281-b951-d872f2087c98

This test was flaking on ChromeOS ASAN bots.  See bug for details.

TBR=miu@chromium.org
NOTRY=true
BUG=406051

Review URL: https://codereview.chromium.org/496093002

Cr-Commit-Position: refs/heads/master@{#291182}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291182 0039d316-1c4b-4281-b951-d872f2087c98

Reason for revert:
http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Ozone%20Builder/builds/2322

Original issue's description:
> Add ui_unittests to GN build.
> 
> Adds os_exchange_data_win_unittest.cc to Windows (it was incorrecly excluded before). Fixed a compilation error in that file.
> 
> Remove special filtering out in GYP build of base/ime/chromeos/character_composer_unittest.cc and base/ime/input_method_chromeos_unittest.cc since the standard filtering patterns match both of these.
> 
> R=sky@chromium.org
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291154

TBR=sky@chromium.org,brettw@chromium.org
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/496843002

Cr-Commit-Position: refs/heads/master@{#291181}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291181 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Multiprofile security: Show a warning messagebox when desktop casting/sharing is turned on upon user (patchset #3 of https://codereview.chromium.org/496563002/)

Reason for revert:
Broke Linux ChromiumOS Tests on waterfall:

http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%281%29/builds/47585

Original issue's description:
> Multiprofile security: Show a warning messagebox when desktop
> casting/sharing is turned on upon user switch
> 
> Purpose of this change:
> 
> Asks the user with a system modal dialog box if he wants to
> turn off screen sharing/screen casting and then switch users
> or abort switching users.
> 
> BUG=353170
> TEST=TrySwitchingUserTest.*
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291152

TBR=jennyz@chromium.org,jamescook@chromium.org,skuhne@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=353170

Review URL: https://codereview.chromium.org/473953004

Cr-Commit-Position: refs/heads/master@{#291180}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291180 0039d316-1c4b-4281-b951-d872f2087c98

It's bouncing emails if you send mail directly (instead of from reitveld)

NOTRY=true

Review URL: https://codereview.chromium.org/492913003

Cr-Commit-Position: refs/heads/master@{#291178}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291178 0039d316-1c4b-4281-b951-d872f2087c98

BUG=402882

Review URL: https://codereview.chromium.org/467043003

Cr-Commit-Position: refs/heads/master@{#291177}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291177 0039d316-1c4b-4281-b951-d872f2087c98

When converting those bots to recipes in r287833, "unit" was replaced with
"unit_tests". In fact, "unit" is a composite step that includes 5 other targets
besides "unit_tests". This CL adds those targets back.

This CL also adds accessibility_unittests and gfx_unittests, which presently run
on the linux_asan trybot and on other waterfalls, but not on chromium.memory.
The same should be done to cast_unittests and google_apis_unittests, once they
are green under ASan.

BUG=none
R=glider@chromium.org
TBR=phajdan.jr@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/498443002

Cr-Commit-Position: refs/heads/master@{#291176}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291176 0039d316-1c4b-4281-b951-d872f2087c98

With the --extension-action-redesign switch, hiding an extension action should
cause it to go to the overflow menu (rather than disappearing completely).
Enable this functionality.

BUG=403824

Review URL: https://codereview.chromium.org/476873002

Cr-Commit-Position: refs/heads/master@{#291174}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291174 0039d316-1c4b-4281-b951-d872f2087c98

Previously, if you specified an empty resource ID file in the grit template in the GN build, it would send "-f" with no argument to grit, and this would cause the command line parsing to get messed up and it wouldn't generate any files.

This patch just omits the "-f" argument in this case.

R=jam@chromium.org

Review URL: https://codereview.chromium.org/495183002

Cr-Commit-Position: refs/heads/master@{#291173}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291173 0039d316-1c4b-4281-b951-d872f2087c98

Cr-Commit-Position: refs/heads/master@{#291172}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291172 0039d316-1c4b-4281-b951-d872f2087c98

TBR=yangguo@chromium.org

Review URL: https://codereview.chromium.org/470403005

Cr-Commit-Position: refs/heads/master@{#291171}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291171 0039d316-1c4b-4281-b951-d872f2087c98

BUG=404766
TEST=Using a sample extension,
"commands": {
  "foo": {
    "suggested_key": {
      "chromeos": "Search+Shift+L"
...

and adding a listener to onCommand, pressing Search+Shift+L results in triggering of the callback. (on linux, this is lwindows+shift+l).

Review URL: https://codereview.chromium.org/392313003

Cr-Commit-Position: refs/heads/master@{#291170}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291170 0039d316-1c4b-4281-b951-d872f2087c98

BUG=399146

Review URL: https://codereview.chromium.org/461323005

Cr-Commit-Position: refs/heads/master@{#291169}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291169 0039d316-1c4b-4281-b951-d872f2087c98

BUG=302040
TBR=noelallen@chromium.org

Review URL: https://codereview.chromium.org/357623003

Cr-Commit-Position: refs/heads/master@{#291168}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291168 0039d316-1c4b-4281-b951-d872f2087c98

This changes lastchange.py in two ways:
1) If the commit it finds is a Git hash, it outputs the whole hash, not just
   the first 7 characters.
2) It only looks at HEAD to see if there is a git-svn id. Previously, it used
   --grep=git-svn-id, which would find the most recent commit containing a
   git-svn id. This would be broken after the switch to git, as it would always
   find the last commit before the switch. Now, it only inspects the most recent
   commit, and falls through to pure-Git if that fails.

R=dilmah@chromium.org, stip@chromium.org
BUG=399113

Review URL: https://codereview.chromium.org/488733002

Cr-Commit-Position: refs/heads/master@{#291165}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291165 0039d316-1c4b-4281-b951-d872f2087c98

version of the tested websites.
Some of the tested websites have changed over the last weeks. This cl
updates the password manager python tests so they can support
the new version of websites.
This cl adds also the tests for Twitter.
BUG=404647

Review URL: https://codereview.chromium.org/483763002

Cr-Commit-Position: refs/heads/master@{#291164}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291164 0039d316-1c4b-4281-b951-d872f2087c98

Example flake here:http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_swarming/builds/8184/steps/%5Bswarming%5D%20content_browsertests%20%28with%20patch%29/logs/OverscrollNavigationTouchThrottling

BUG=

Review URL: https://codereview.chromium.org/491083002

Cr-Commit-Position: refs/heads/master@{#291163}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291163 0039d316-1c4b-4281-b951-d872f2087c98

When in fullscreen we should give back the fullscreen icon's width to the tabstrip.

Before: https://drive.google.com/open?id=0B1B1Up4p2NRMdXloQ3phSElBeEk&authuser=1
After: https://drive.google.com/open?id=0B1B1Up4p2NRMM2JNRE56aC1uRDA&authuser=1

BUG=403561

Review URL: https://codereview.chromium.org/493803002

Cr-Commit-Position: refs/heads/master@{#291162}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291162 0039d316-1c4b-4281-b951-d872f2087c98

This master CL lands recent SPDY changes through 73573949, extending them
with Chromium-specific updates to constants and enums, protocol negotiation
tokens, and tests.  This CL is intended to be commited but not reviewed, and is
the union of the following changes, which in turn are intended to be reviewed
but not commited.  (Most recent on top, oldest on bottom.)

Fix bug in HTTP/2 frame size limits.  This lands server change 73573949.
https://crrev.com/478903004

Update npn/alpn tokens to HTTP2-draft14.
https://crrev.com/486493003

Add kSpdyMaxControlFrameSize and kControlFrameSizeLimit constants.  This lands
server change 73427537.
https://crrev.com/486873002

Add TODO.  This lands server change 73426819.
https://crrev.com/479313002

Add an extra byte to the length field for HTTP/2 frame headers.  This lands
server change 73424406.
https://crrev.com/479303002

Change order of tests.
https://crrev.com/483863002

Remove reference set and exchange header and static table in HPACK.  This lands
server change 73299534.
https://crrev.com/480573003

Add new settings to SPDY4 for h2-14.  This lands server change 72726557.
https://crrev.com/480183002

Add kHttp2VersionString.  This lands server change 72173526.
https://crrev.com/485813002

HTTP2 draft 13: support unknown frame types and settings types as extensions.
This lands server change 70895882.
https://crrev.com/483843004

Allow unrecognized error codes as part of HTTP/2 extensions.  This lands server
change 70873693.
https://crrev.com/475043002

BUG=400336

Review URL: https://codereview.chromium.org/485833002

Cr-Commit-Position: refs/heads/master@{#291161}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291161 0039d316-1c4b-4281-b951-d872f2087c98

When user removes the last item (folder/page) from 'Other bookmarks' folder,
the folder itself is hidden; hence adding (empty) button is unnecessary. So
just close the folder before hiding it.

TEST=
1) Launch chrome and bookmark a page or folder into 'Other Bookmarks'.
2) Right-click on the bookmarked page/folder in the 'Other Bookmarks' from Bookmark bar.
3) Choose to 'Cut'/'Delete' and observe.
4) (empty) placeholder button should not remain after 'Other bookmarks' folder is hidden.

BUG=257538
R=asvitkine@chromium.org

Review URL: https://codereview.chromium.org/485003002

Cr-Commit-Position: refs/heads/master@{#291160}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291160 0039d316-1c4b-4281-b951-d872f2087c98

Followup to https://codereview.chromium.org/486283002/ which fixed only some of the cases. This CL ensures the bubble is updated also when the profile name is changed due to selecting a different avatar.

BUG=405050

Review URL: https://codereview.chromium.org/497453002

Cr-Commit-Position: refs/heads/master@{#291159}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291159 0039d316-1c4b-4281-b951-d872f2087c98

This CL is premised on the theory that the memory corruption and related
crashes are due to invalid input data being fed into the sessions sync
code.  See the linked bug for more details.

Adds two tests that expose the scenario that is believed to be the cause
of the bug.  If checked in on their own, they would crash during
destruction of the SyncedSessionTracker.

Adds a CHECK to prevent the SyncedSessionsTracker from getting in to
a bad state.  The goal of this CHECK is to ensure that all crashes
caused by misuse of the tracker cause a crash immediately, rather than
corrupting the memory allocator's internal data structures and possibly
causing crashes in unrelated code.  The newly added tests would trigger
this CHECK, if not for the last component of this CL.

Adds a filter for incoming sync_pb::SessionHeader values.  Before acting
on the session, the SessionsSyncManager will now verify that the header
does not contain any duplicate tab IDs.  If verification fails, the
header will be ignored.  This part of the CL allows the new tests to
pass.

BUG=360822

Review URL: https://codereview.chromium.org/495593003

Cr-Commit-Position: refs/heads/master@{#291158}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291158 0039d316-1c4b-4281-b951-d872f2087c98

Adds os_exchange_data_win_unittest.cc to Windows (it was incorrecly excluded before). Fixed a compilation error in that file.

Remove special filtering out in GYP build of base/ime/chromeos/character_composer_unittest.cc and base/ime/input_method_chromeos_unittest.cc since the standard filtering patterns match both of these.

R=sky@chromium.org

Review URL: https://codereview.chromium.org/496473003

Cr-Commit-Position: refs/heads/master@{#291154}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291154 0039d316-1c4b-4281-b951-d872f2087c98