GitLab

Make DragController to use VisibleSelection::toNormalizedEphemeralRange() instead of toNormalizedRange()

This patch changes |DragController| class to use |toNormalizedEphemeralRange()|
in |VisibleSelection| class instead of |toNormalizedRange()| as a preparation
of templatizing |VisibleSelection| to use templatized positions instead of
DOM position to represent range.

This patch is a preparation of making selection to handle granularity for web
component, http://crrev.com/1277863002

BUG=513568
TEST=n/a; no behavior changes

Review URL: https://codereview.chromium.org/1316603002

git-svn-id: svn://svn.chromium.org/blink/trunk@201115 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Remove the default case from the CSSValue::equals method, to enable the
compiler to check that every enum value is in the switch statement.

Review URL: https://codereview.chromium.org/1311843003

git-svn-id: svn://svn.chromium.org/blink/trunk@201114 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This CL re-enables tests and updates their expectations.

(1) Blink: https://codereview.chromium.org/1311113002/
(2) Chromium: https://codereview.chromium.org/1307133003/
(3) Blink: THIS PATCH

BUG=523904

Review URL: https://codereview.chromium.org/1311103002

git-svn-id: svn://svn.chromium.org/blink/trunk@201113 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Make EditingStyle to use VisibleSelection::toNormalizedEphemeralRange() instead of toNormalizedRange()

This patch changes |EditingStyle| class to use |toNormalizedEphemeralRange()|
in |VisibleSelection| class instead of |toNormalizedRange()| as a preparation
of templatizing |VisibleSelection| to use templatized positions instead of
DOM position to represent range and avoid registering temporary |Range|
object into |Document|.

This patch is a preparation of making selection to handle granularity for web
component, http://crrev.com/1277863002

BUG=388681, 513568
TEST=n/a; no behavior changes

Review URL: https://codereview.chromium.org/1314713004

git-svn-id: svn://svn.chromium.org/blink/trunk@201112 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=520742
NOTRY=true

Review URL: https://codereview.chromium.org/1312033002

git-svn-id: svn://svn.chromium.org/blink/trunk@201111 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch introduces |positionForPoint()| in |LocalFrame| class as replacement
of |visiblePositionForPoint()| to reduce doing visible position
canonicalization for increasing chance to delay canonicalization with changing
|setPosition()| in |DragCaretController| and |VisibleSelection| constructor to
take |PositionWithAffinity|.

Note: Both of |VisbilePosition| constructor and |VisibleSelection| constructor
do visible position canaonicalization.

This patch is a preparation of making selection to handle granularity for web
component, http://crrev.com/1277863002

BUG=513568
TEST=n/a; no behavior changes

Review URL: https://codereview.chromium.org/1310323004

git-svn-id: svn://svn.chromium.org/blink/trunk@201110 bbb929c8-8fbe-4397-9dbb-9b2b20218538

To reduce a mess of Heap.h, this CL splits Heap.h into Heap.h and HeapPage.h.

This CL just moves code around without any behavioral change.

BUG=437144

Review URL: https://codereview.chromium.org/1314793002

git-svn-id: svn://svn.chromium.org/blink/trunk@201109 bbb929c8-8fbe-4397-9dbb-9b2b20218538

NOTRY=true
R=fs@opera.com

Review URL: https://codereview.chromium.org/1318443002

git-svn-id: svn://svn.chromium.org/blink/trunk@201108 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This connects USBDevice interface methods to the embedder.

BUG=492204
R=reillyg@chromium.org

Review URL: https://codereview.chromium.org/1315683002

git-svn-id: svn://svn.chromium.org/blink/trunk@201107 bbb929c8-8fbe-4397-9dbb-9b2b20218538

With recent changes, it's dangerous to inject /deep/ selectors
to the page, as they get high priority. This patch stops injecting
backwards compatilibity code to the all-new frontned.

BUG=none

Review URL: https://codereview.chromium.org/1310653003

git-svn-id: svn://svn.chromium.org/blink/trunk@201106 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch fixes the raw pointer instances below:

    * StubFrameLoaderClientWithParent::m_parent
    * FrameLoaderClientImpl::m_webFrame
    * RemoteFrameClientImpl::m_webFrame

BUG=509911
R=haraken@chromium.org, oilpan-reviews@chromium.org, peria@chromium.org, sigbjornf@opera.com

Review URL: https://codereview.chromium.org/1306793003

git-svn-id: svn://svn.chromium.org/blink/trunk@201105 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch reduces interfaces of WI.CSSProperty and WI.CSSStyleDeclaration
classes.

The patch removes:
  - remove style.getLiveProperty() method and the whole notion of "live"
    properties
  - removes tripple state defined via property.active()/property.inactive()
    flags. (The state was tripple as !property.active() !== property.inactive()).
  - style.shorthandValue/style.shorthandIsImportant public methods
  - removes property.styleBased() property

The patch adds:
  - property.activeInStyle() method which defines if the current property
    has any effect in style.
  - style.leadingProperties() method which computes those properties
    which should be displayed in StylesSidebarPane.

BUG=496263
R=pfeldman
NOTRY=true

Review URL: https://codereview.chromium.org/1308663002

git-svn-id: svn://svn.chromium.org/blink/trunk@201104 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This CL temporary disables tests to be broken by (2).

(1) Blink: THIS PATCH
(2) Chromium: https://codereview.chromium.org/1307133003/
(3) Blink: https://codereview.chromium.org/1311103002/

BUG=523904
NOTRY=true

Review URL: https://codereview.chromium.org/1311113002

git-svn-id: svn://svn.chromium.org/blink/trunk@201103 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Reland of Take care of a FIXME in SecurityOrigin.cpp to check the validity (patchset #1 id:1 of https://codereview.chromium.org/1315793002/ )

Reason for revert:
Failure still present.

Original issue's description:
> Revert of Take care of a FIXME in SecurityOrigin.cpp to check the validity of any innerURL during constructio… (patchset #4 id:60001 of https://codereview.chromium.org/1294933004/ )
> 
> Reason for revert:
> Speculative revert for "Too many opened files in the system".
> 
> Original issue's description:
> > Take care of a FIXME in SecurityOrigin.cpp to check the validity of any innerURL during construction and to handle invalidity as a 'unique' origin.
> > 
> > TBR=mkwst
> > BUG=514076
> > 
> > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201022
> 
> TBR=jsbell@chromium.org,palmer@chromium.org,mkwst@chromium.org,brettw@chromium.org,michaeln@chromium.org
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=514076,524248
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201100

TBR=brettw@chromium.org,jsbell@chromium.org,michaeln@chromium.org,mkwst@chromium.org,palmer@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=514076,524248

Review URL: https://codereview.chromium.org/1309333004

git-svn-id: svn://svn.chromium.org/blink/trunk@201102 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch gets rid of |VisibleSelection| constructor with |Range| parameter
to templatize |VisibleSelection| easier.

This patch is a preparation of making selection to handle granularity for web
component, http://crrev.com/1277863002

BUG=513568
TEST=n/a; No behavior changes

Review URL: https://codereview.chromium.org/1307763003

git-svn-id: svn://svn.chromium.org/blink/trunk@201101 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Revert of Take care of a FIXME in SecurityOrigin.cpp to check the validity of any innerURL during constructio… (patchset #4 id:60001 of https://codereview.chromium.org/1294933004/ )

Reason for revert:
Speculative revert for "Too many opened files in the system".

Original issue's description:
> Take care of a FIXME in SecurityOrigin.cpp to check the validity of any innerURL during construction and to handle invalidity as a 'unique' origin.
> 
> TBR=mkwst
> BUG=514076
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201022

TBR=jsbell@chromium.org,palmer@chromium.org,mkwst@chromium.org,brettw@chromium.org,michaeln@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=514076,524248

Review URL: https://codereview.chromium.org/1315793002

git-svn-id: svn://svn.chromium.org/blink/trunk@201100 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Now that SkImage sports a lazy-decoding querying API (isLazyGenerated), we no longer
need the external mechanism introduced in http://crrev.com/1253483004.


BUG=523922
R=noel@chromium.org

Review URL: https://codereview.chromium.org/1308233002

git-svn-id: svn://svn.chromium.org/blink/trunk@201099 bbb929c8-8fbe-4397-9dbb-9b2b20218538

After landing https://codereview.chromium.org/1298113003/, we have four types
of GC callbacks:

- A callback for a minor GC
- A callback for incremental marking of a major GC
- A callback for atomic pause of a major GC
- A callback for weak processing

This CL distinguishes the four types of GC callbacks in V8GCController::gcPrologue/gcEpilogue.

This CL basically just moves code around. No substantial changes in behavior.

BUG=521946

Review URL: https://codereview.chromium.org/1288683005

git-svn-id: svn://svn.chromium.org/blink/trunk@201098 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The current flex-grow and flex-shrink interpolation code will not smoothly
interpolate values with 0.
This patch removes this special behaviour as there is no specification text
justifying this behaviour.
Without this behaviour we can simplify the Constraint enum out of AnimatableDouble.

BUG=522817

Review URL: https://codereview.chromium.org/1300323003

git-svn-id: svn://svn.chromium.org/blink/trunk@201097 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=475370

Review URL: https://codereview.chromium.org/1313733007

git-svn-id: svn://svn.chromium.org/blink/trunk@201096 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Change Counter to CSSValueCounter, and remove counters from
CSSPrimitiveValue.

BUG=523893

Review URL: https://codereview.chromium.org/1303153003

git-svn-id: svn://svn.chromium.org/blink/trunk@201095 bbb929c8-8fbe-4397-9dbb-9b2b20218538

WebDatabase used an extern "C" section to declare the monkey-patching
symbols it uses from our patched SQLite VFS code.  Switch to the items
exported from sqlite3.h.

Additionally, various modules were satisfying an implicit dependency on
icu via SQLite's static library (SQLite needs it for the REGEXP override
in sqlite/src/ext/icu/icu.c).  Change the modules depending on the
sqlite library to also depend on icu, so that sqlite can work with
component build.

BUG=489444

Review URL: https://codereview.chromium.org/1311913002

git-svn-id: svn://svn.chromium.org/blink/trunk@201093 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Reland of moved unused CascadeOrder. (patchset #1 id:1 of https://codereview.chromium.org/1306693007/ )

Reason for revert:
I don't think this contributes any of "too many opened files".
(as is commented bay jianli
https://code.google.com/p/chromium/issues/detail?id=524248#c7 )

Will revert and reland the original patch.



Original issue's description:
> Revert of Removed unused CascadeOrder. (patchset #1 id:1 of https://codereview.chromium.org/1291873005/ )
> 
> Reason for revert:
> Speculative revert for causing "Too many opened files in the system".
> 
> https://code.google.com/p/chromium/issues/detail?id=523598
> 
> 
> Original issue's description:
> > Removed unused CascadeOrder.
> > 
> > CascadeOrder is always ignoreCascadeOrder after [1] and can be removed.
> > 
> > [1] https://codereview.chromium.org/1298173004
> > 
> > BUG=487125
> > 
> > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201019
> 
> TBR=kochi@chromium.org,rune@opera.com
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=487125
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201082

TBR=rune@opera.com,jianli@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=487125

Review URL: https://codereview.chromium.org/1313713005

git-svn-id: svn://svn.chromium.org/blink/trunk@201092 bbb929c8-8fbe-4397-9dbb-9b2b20218538

" ".repeat(10) will produce string with one space in console output.
This CL changed this behavior by replacing white-space:nowrap rule to white-space:pre.

BUG=516989
R=pfeldman@chromium.org

Review URL: https://codereview.chromium.org/1304033003

git-svn-id: svn://svn.chromium.org/blink/trunk@201091 bbb929c8-8fbe-4397-9dbb-9b2b20218538

It is helpful to let Oilpan report its memory usage at each safe point.

BUG=

Review URL: https://codereview.chromium.org/1315603004

git-svn-id: svn://svn.chromium.org/blink/trunk@201090 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=200993

BUG=523403
TBR=pfeldman@chromium.org

Review URL: https://codereview.chromium.org/1309383002 .

git-svn-id: svn://svn.chromium.org/blink/trunk@201089 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=200920

BUG=509025
TBR=pfeldman@chromium.org

Review URL: https://codereview.chromium.org/1309373002 .

git-svn-id: svn://svn.chromium.org/blink/trunk@201088 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=200937

BUG=509025
TBR=leviw@chromium.org

Review URL: https://codereview.chromium.org/1315773002 .

git-svn-id: svn://svn.chromium.org/blink/trunk@201087 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=200938

BUG=509025
TBR=leviw@chromium.org

Review URL: https://codereview.chromium.org/1315763002 .

git-svn-id: svn://svn.chromium.org/blink/trunk@201086 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=200895

BUG=514751
TBR=drott@chromium.org

Review URL: https://codereview.chromium.org/1317453002 .

git-svn-id: svn://svn.chromium.org/blink/trunk@201085 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=201002

BUG=510492
TBR=wangxianzhu@chromium.org

Review URL: https://codereview.chromium.org/1316553002 .

git-svn-id: svn://svn.chromium.org/blink/trunk@201084 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch gets rid of an extra file "core/editing/commands/EditorCommand.h"
from "core.gypi" added by http://crrev.com/1294543005.

TBR=brucedawson@chromium.org
BUG=509527
TEST=n/a; no behavior changes
NOTRY=true

Review URL: https://codereview.chromium.org/1312003002

git-svn-id: svn://svn.chromium.org/blink/trunk@201083 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Revert of Removed unused CascadeOrder. (patchset #1 id:1 of https://codereview.chromium.org/1291873005/ )

Reason for revert:
Speculative revert for causing "Too many opened files in the system".

https://code.google.com/p/chromium/issues/detail?id=523598


Original issue's description:
> Removed unused CascadeOrder.
> 
> CascadeOrder is always ignoreCascadeOrder after [1] and can be removed.
> 
> [1] https://codereview.chromium.org/1298173004
> 
> BUG=487125
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201019

TBR=kochi@chromium.org,rune@opera.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=487125

Review URL: https://codereview.chromium.org/1306693007

git-svn-id: svn://svn.chromium.org/blink/trunk@201082 bbb929c8-8fbe-4397-9dbb-9b2b20218538

With M SDK, the output of "adb version" has changed, from:
"""Android Debug Bridge version 1.0.32"""

to:
"""Android Debug Bridge version 1.0.32
Revision 57224c5cff69-android"""

Update script regex to match both.

Review URL: https://codereview.chromium.org/1313773002

git-svn-id: svn://svn.chromium.org/blink/trunk@201081 bbb929c8-8fbe-4397-9dbb-9b2b20218538

While attempting to add a new css property, I ran into
ASSERT_WITH_SECURITY_IMPLICATION(index < arraySize) while calling
CSSAnimations::calculateTransitionUpdate. It looks like we normally don't
include CSSPropertyInvalid, and use firstCSSProperty to offset the index.

I've done the same here.

Review URL: https://codereview.chromium.org/1308053002

git-svn-id: svn://svn.chromium.org/blink/trunk@201080 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Initial UI is hidden behind "blockedURLs" experiment.

BUG=520259

Review URL: https://codereview.chromium.org/1295903005

git-svn-id: svn://svn.chromium.org/blink/trunk@201079 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=518816

Review URL: https://codereview.chromium.org/1292333004

git-svn-id: svn://svn.chromium.org/blink/trunk@201078 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Use simple Map<string, string> object Instead of utilizing
CSSStyleDeclaration for representation of computed style.

NOTRY=true
BUG=496263

Review URL: https://codereview.chromium.org/1310883002

git-svn-id: svn://svn.chromium.org/blink/trunk@201077 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=523910,490087

Review URL: https://codereview.chromium.org/1314643003

git-svn-id: svn://svn.chromium.org/blink/trunk@201076 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=524160

Review URL: https://codereview.chromium.org/1311893004

git-svn-id: svn://svn.chromium.org/blink/trunk@201075 bbb929c8-8fbe-4397-9dbb-9b2b20218538