- 10 Jan, 2020 27 commits
-
-
Jimmy Gong authored
- This is the final CL to remove all code that is deprecated by the new printer settings UI. - Adjusts browser tests to reflect this change. Bug: 1005905 Test: Browser tests Change-Id: Ic2cf98968ca2e4ed4c19462ba8d5da75adc13376 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1938043 Commit-Queue: jimmy gong <jimmyxgong@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#730005}
-
Evan Stade authored
This is the only place it's used, and it's view-specific logic so it belongs closer to the view. Bug: 1038415 Change-Id: I10bedda65753cff0b883efdff072afc683a7bc7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1989884 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#730004}
-
Kalon Hinds authored
Temporarily disable the DevTools Animation Timeline test in order to land: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1920984 Bug: 963183 Change-Id: Ia1db914f4e9acccf300788084f132c5d8e53a9eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993757Reviewed-by:
Robert Paveza <Rob.Paveza@microsoft.com> Commit-Queue: Kalon Hinds <kahinds@microsoft.com> Cr-Commit-Position: refs/heads/master@{#730003}
-
Glen Robertson authored
Change-Id: I055135607864517abb3a46c8976ccf025344444c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992959 Commit-Queue: Glen Robertson <glenrob@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#730002}
-
Eric Orth authored
This is done in lieu of spreading the new interface work (which allows multiple concurrent probe runs with different contexts) from DnsTransactionFactory to DnsClient. HostResolverManager now directly interacts with DnsTransactionFactory to start/cancel probes as well as restart probes on config or connection change. Still a single probe runner instance (now owned in HostResolverManager instead of DnsClient). The next CL will complete the chain to fully allow multiple runners by inserting them into the HostResolverManager::ProbeRequestImpl objects. Slight logic change in that triggering DoH probes is now disallowed when no DoH servers are configured. This allows reusing DnsClient::CanUseSecureDnsTransactions() for checking if DoH probes are enabled. This was only ever a noop scenario before, so no practical change other than that tests that check for running probes now need to set DoH servers in the test config. Bug: 1022059 Change-Id: I9ce65739abb8fc956973c6e184dd61c52b7e4eac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985125 Commit-Queue: Eric Orth <ericorth@chromium.org> Reviewed-by:
Asanka Herath <asanka@chromium.org> Cr-Commit-Position: refs/heads/master@{#730001}
-
Mason Freed authored
The [1] CL enabled the FormControlsRefresh feature by default for Windows, Linux, and ChromeOS. In the process, many layout tests were disabled, because the form controls have a different appearance with the feature enabled. This is one of several patches rebaselining those disabled tests. [1] http://crrev.com/c/1967608 Bug: 1035582 Change-Id: I99023619889a37d62ef45b74bb3267642aab0a5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993480 Auto-Submit: Mason Freed <masonfreed@chromium.org> Commit-Queue: Stephen Chenney <schenney@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#730000}
-
Ayu Ishii authored
This changes allows a page to have multiple input forms with autocomplete='one-time-code'. If subscribe has already been called for an SmsClient, it will silently ignore. Without this change, the page will crash upon trying to Subscribe again because each SmsClient is only allowed to be subscribed once in the SmsQueue[1]. This crash is also reproducible by reloading the page with the autocomplete input. [1] https://cs.chromium.org/chromium/src/content/browser/sms/sms_queue.cc?sq=package:chromium&g=0&l=16 Bug: 1037914 Change-Id: I130aeda2b8c9df2328393ec6b42a7cae608ef07f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981266Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Commit-Queue: Ayu Ishii <ayui@chromium.org> Cr-Commit-Position: refs/heads/master@{#729999}
-
Marijn Kruisselbrink authored
Bug: 1027737 Change-Id: Ifcce67116fc50a604b57dc7e73233eefd4729092 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993645 Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#729998}
-
Avery Musbach authored
See the videos linked in https://crbug.com/1027179. Fixed: 1027179 Change-Id: Ia4f4e112b02297f3d43da81935ee1e97215c3d85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979146Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Avery Musbach <amusbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#729997}
-
Liquan (Max) Gu authored
Triggering condition: * Serve a payment app in HTTP * Enable --ignore-certificate-errors: this allow the payment app to be served via HTTP. Description: JourneyLogger has the Java side and the native side. The native side categorizes the payment-methods into these categories exclusively: GCard, basic-card, other. However, the Java side exclude those served via non-HTTPS scheme from being "other", and thus some payment-methods are excluded from being one of the categories. The native side has a DCHECK for the exclusivity that triggering the bug this CL is to fix. Before change: closing the payment app would cause a DCHECK failure in JourneyLogger. After change: no DCHECK failure. Code change: the Java side to include the Payment Apps served via "http" in the "other" category. Bug: 1039408 Change-Id: Ic52f27af88198874791df5d8461318c1e9ee9a96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988751Reviewed-by:
Sahel Sharify <sahel@chromium.org> Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#729996}
-
Thomas Lukaszewicz authored
Removed unnecessary color initialization in the KeywordHintView constructor, eliminating the need to make calls to GetThemeProviderForProfile(). Performed basic cleanup and removal of unnecessary code duplication. Bug: None Change-Id: Ie8948e78cd38446f4248579626fa59a16290a8b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993485 Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#729995}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: I502bfd234506aa7977d34b04e5b6ac123edc59a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993566Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#729994}
-
Peter Kasting authored
This implements suggestions from https://chromium-review.googlesource.com/c/chromium/src/+/1983539 . Bug: none Change-Id: Id621d2bfa806c48d7efaa74b34f17a959dec898e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1989703 Commit-Queue: Peter Kasting <pkasting@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#729993}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/27db24581e9e..697b2241a6c7 git log 27db24581e9e..697b2241a6c7 --date=short --first-parent --format='%ad %ae %s' 2020-01-09 tobine@google.com Vulkan:Clarify volk license file name Created with: gclient setdep -r src/third_party/angle@697b2241a6c7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: cwallez@google.com Change-Id: Ib639d501e6031c3411b76fcfad4e17f86f2521d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994111Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#729992}
-
Kurt Horimoto authored
InfobarOverlayBrowserAgent is an OverlayBrowserAgent subclass that handles updating InfoBarDelegate state for user interaction with infobar UI presented via OverlayPresenter. For each InfobarType, an InfobarInteractionHandler will be created that updates the infobar model layer for interactions with the UI. These interaction handlers are provided to the InfobarBrowserAgent, which sets up OverlayRequestCallbackInstallers to forward responses from the UI to the interaction handlers. InfobarBannerOverlayRequestCallbackInstaller is used to forward user interaction events for infobar banner UI. The interaction handlers and the corresponding callback installers for detail sheet and modal UI will be implemented in follow-up CLs. This CL also updates AttachInfobarOverlayBrowserAgent() to install the browser agent if the feature is enabled. Subsequent CLs will be added to provide the browser agent with interaction handlers for each InfobarType. Bug: 1030357 Change-Id: I131b03e8dd1e5e4228ade4d9e01730114545fa5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1989855 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#729991}
-
Tim Song authored
There are many code sites which calculates the work area insets for positioning a tray bubble or pop-up notification. Now that the calculation is more complex, it makes sense to consolidate everything to one function. This CL also fixes insets for the message center bubble and lock screen in tablet mode. TEST=manually verified BUG=1040693 Change-Id: Ic8381a0b749e9e95b56717a239285f4bbddf7f08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993746Reviewed-by:
Ahmed Mehfooz <amehfooz@chromium.org> Commit-Queue: Tim Song <tengs@chromium.org> Cr-Commit-Position: refs/heads/master@{#729990}
-
Tim Song authored
For legacy reasons, there are many places that are manually drawing rounded corners in the message center, which can all be replaced by the fast rounded corner implementation in the bubble widget. Change-Id: Ife0d8f3fc74a059129cae1cd85c5bbea5ee8a2bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992016Reviewed-by:
Ahmed Mehfooz <amehfooz@chromium.org> Commit-Queue: Tim Song <tengs@chromium.org> Cr-Commit-Position: refs/heads/master@{#729989}
-
Allen Bauer authored
Bug: 245409 Change-Id: I751b017bfa5187f4d33d6eeff58d8e86eba15bc5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994264 Auto-Submit: Allen Bauer <kylixrd@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Commit-Queue: Allen Bauer <kylixrd@chromium.org> Cr-Commit-Position: refs/heads/master@{#729988}
-
meacer authored
Skeleton strings are used to detect confusable hostnames. They are generated in two places: 1. During build time in make_top_domain_skeletons: This binary takes a list of hostnames and generates their skeletons to be embedded statically to the Chrome binary. 2. During runtime idn_spoof_checker.cc: This class generates skeletons of a hostname to compare against a list of known skeleton strings. Before generating a skeleton string, this class applies a few additional transformations such as diacritic removal to the hostname to be able to detect more confusable hostnames. This CL extracts the skeleton generation in IDN spoof checker code to a separate file so that make_top_domain_skeletons can apply the same transformations to input hostnames when building the static top domain list. This CL also modifies top_domain_generator binary which generates the actual trie to be embedded to the binary. The trie currently doesn't allow non-ASCII characters in its fields. This CL stores unicode hostnames in punycode to overcome this restriction. Unicode hostnames may still have non-ASCII skeleton strings, and top_domain_generator still doesn't support that. However, the current top domain list doesn't have any IDN so this isn't a blocking issue. Bug: 1040607 Change-Id: I40c654152025d910cbeb8ba32bff5b7835f00104 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992011Reviewed-by:
Christopher Thompson <cthomp@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#729987}
-
Annie Sullivan authored
This also adds indexing per https://chromium.googlesource.com/chromium/src/+/master/services/metrics/ukm_api.md#controlling-the-aggregation-of-metrics Change-Id: Ib69d097d6b5c1ecd1a11c32ac709ec6c0ae59d3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1989966Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Commit-Queue: Annie Sullivan <sullivan@chromium.org> Cr-Commit-Position: refs/heads/master@{#729986}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/3b19b2734385..9a83dd729bf5 git log 3b19b2734385..9a83dd729bf5 --date=short --first-parent --format='%ad %ae %s' 2020-01-09 steveanton@webrtc.org Batch process pending tasks in the libevent TaskQueue Created with: gclient setdep -r src/third_party/webrtc@9a83dd729bf5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ie441a5b5874fea3dc6a550b7555770818b12e4ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994104Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#729985}
-
Henrique Nakashima authored
The cleanup period has already passed. Add the key to the deprecated list so it's not reused. Bug: 960767, 1022108 Change-Id: I8323c5bd897a041691f278da04861f4d799ca613 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993642Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#729984}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/12f8d69f1288..13928b7e7f1a git log 12f8d69f1288..13928b7e7f1a --date=short --first-parent --format='%ad %ae %s' 2020-01-09 ehmaldonado@chromium.org Revert "vpython: Specify interpreter to run." Created with: gclient setdep -r src/third_party/depot_tools@13928b7e7f1a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1036606 Tbr: agable@chromium.org Change-Id: Id5680e4c2400f9d73177347cee9e4e1fd57e749e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994115Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#729983}
-
Zhenyao Mo authored
We don't really care for devices where GPU process init takes more than 5 seconds. Even a low-end device like MS Surface Go only takes 1.2 seconds. With this CL, we can take a closer look at initialization time distribution. BUG=1039792 R=magchen@chromium.org,jwd@chromium.org Change-Id: I4363baa9743e55e27b48b48296029b305d95ddba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992692Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
Maggie Chen <magchen@chromium.org> Commit-Queue: Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#729982}
-
Ben Pastene authored
Needed to avoid "builders should be listed in this project's commit-queue.cfg" messages in CLs like crrev.com/c/1991950. Bug: 1037892 Change-Id: I9ca588b213822c5b40482a7239603f86ac7a7ccc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993903Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#729981}
-
Tibor Goldschwendt authored
Bug: 1040256 Change-Id: Ia8e1a17d65f85d5b6ae1218835fbdb1e308c6af8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1991809 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#729980}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/141fae8b9f4d..d9ef631c223a Created with: gclient setdep -r src-internal@d9ef631c223a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1040284 Tbr: jbudorick@google.com Change-Id: I43cb78ac1dc71133147d87eb69fc66163ef8a847 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994106Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#729979}
-
- 09 Jan, 2020 13 commits
-
-
Christopher Grant authored
As per discussion with ssid@, 64-bit browser builds should not have a 32-bit unwind asset in them. R=estevenson Bug: 1038962 Change-Id: I012138cff1071d74f2722277a90758d44bf8677b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993676 Auto-Submit: Christopher Grant <cjgrant@chromium.org> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Commit-Queue: Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#729978}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/f59495dd..bd2510d9 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ia3e28358e59d9ad271c08cd0069d9ffbc8245b88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993448Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#729977}
-
Matthew Denton authored
Bug: 1038828 Change-Id: I54fd66812c69937ef6d26770341eef147e861b80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992215 Commit-Queue: Matthew Denton <mpdenton@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Cr-Commit-Position: refs/heads/master@{#729976}
-
Mila Green authored
Bug: 1031552 Change-Id: I065956f2eb6cde4354fcff23d03912836b4a14c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993142Reviewed-by:
Sorin Jianu <sorin@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Mila Green <milagreen@chromium.org> Cr-Commit-Position: refs/heads/master@{#729975}
-
Victor Costan authored
https://chromium.googlesource.com/external/github.com/google/snappy.git/+log/156cd8939c5f..f5acee902c4d $ git log 156cd8939..f5acee902 --date=short --no-merges --format='%ad %ae %s' 2019-11-11 costan Move CI to Visual Studio 2019. 2019-11-07 costan Align CMake configuration with related projects. 2019-11-05 costan Remove redundant PROJECT_SOURCE_DIR usage from CMake config. 2019-11-04 costan Fix one forgotten instance of StringPrintf -> StrFormat. 2019-11-03 costan Fix build errors. 2019-11-03 costan Test CMake installation on Travis. 2019-10-30 no-reply Internal changes 2019-10-17 bitomaxsp Allow build with different standard if lib used as a subproject 2019-09-29 costan Fix Travis CI build. 2019-09-27 costan Remove snappy::string alias to std::string. 2019-09-26 costan Fully qualify std::string. 2019-08-20 costan Fix benchmarks. 2019-08-20 costan Fix benchmarks. 2019-08-20 costan Fix unused variable warnings in fuzzers. 2019-08-19 costan Rename zippy_*_fuzzer.cc -> snappy_*_fuzzer.cc. 2019-07-10 nafi Add BM_ZFlatAll, BM_ZFlatIncreasingTableSize benchmarks to see how good zippy performs when it is processing different data one after the other. 2019-07-27 bhargava.shastry Update travis config for fuzzer builds 2019-07-20 aman Updated to match .gitignore from google/leveldb 2019-07-13 aman Create .gitignore 2019-06-28 bshas3 Add libFuzzer harnesses, a cmake option to build them Created with: roll-dep src/third_party/snappy/src Change-Id: I2da25ef3b612cc68765065f0fb55df8c95254380 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993145 Auto-Submit: Victor Costan <pwnall@chromium.org> Reviewed-by:
Chris Mumford <cmumford@google.com> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#729974}
-
Takuto Ikuta authored
This is to fix base_unittests failure like https://luci-milo-dev.appspot.com/p/chromium/builders/ci/Mac%20Swarm/13268 Change-Id: I4c625d9aec7041ed8e688e4bceffa3dcba85b86e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993014 Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Marc-Antoine Ruel <maruel@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#729973}
-
rajendrant authored
This CL gets the estimated data savings due to SaveData and updates as LiteMode savings. The savings are retrieved from field trial as json. Bug: 923551 Change-Id: Ia7c5518edfeaedce33e957c19224f6a2350df6c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1990989 Commit-Queue: rajendrant <rajendrant@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#729972}
-
Nelson Billing authored
- Add '-Wl,-mllvm -Wl,-generate-type-units' to ldflags for Chrome Android builds using ThinLTO (use_thin_lto), which is typically the case just for official builds (is_official). - This brings the 32bit binary size of Chrome under the linker size limit, so symbol_level can be raised back to "2" for these builds. - Exclude builds with ThinLTO from the logic that lowers symbol_level to "1" for non-component Android builds. Change-Id: I26457985b26d0e84bf08640c5128b84eacdcc43e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992240 Commit-Queue: Nelson Billing <nbilling@google.com> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#729971}
-
Bo Liu authored
In r728805, SelectionPopupControllerImpl post task was converged from View to Handler. However one of the removeCallbacks calls was accidentally not converted, which means the task to dismiss the pop up was never removed as expected sometimes, causing a flicker. Fixed: 1040457 Change-Id: Iad16cc958b4adce599255de7596b2cbec568154a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994007 Commit-Queue: Bo <boliu@chromium.org> Commit-Queue: Shimi Zhang <ctzsm@chromium.org> Auto-Submit: Bo <boliu@chromium.org> Reviewed-by:
Shimi Zhang <ctzsm@chromium.org> Cr-Commit-Position: refs/heads/master@{#729970}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/3c04fb3a9464..9346b7c0ed1a git log 3c04fb3a9464..9346b7c0ed1a --date=short --first-parent --format='%ad %ae %s' 2020-01-09 tsepez@chromium.org Remove several unused enums and structs from public/fpdf_fwlevent.h. Created with: gclient setdep -r src/third_party/pdfium@9346b7c0ed1a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: pdfium-deps-rolls@chromium.org Change-Id: I8369932c058c266597ef82438d72a81711ad7f90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994109Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#729969}
-
Daniel Clark authored
Fixed the following issues that led to the revert: - Added missing mac image baseline updates - Some tests I added/extended were timing out in a linux MSAN run. I noticed that the color picker is slow to open in even a normal debug build, so I suspect that these are legit timeouts where the tests are just taking too long on the MSAN build. I've split the tests up to avoid this (color-picker-events-*, color-picker-escape-cancellation-*). Original change description follows: This CL updates the <input type="color"> popup UI in three related aspects per design feedback: 1) The in-page control now updates immediately as the selected color is changed in the popup, instead of waiting for the popup to be dismissed. The page can watch for these 'live' changes via the input event. 2) The UI is simplified by removal of the submit and cancel buttons. The popup is now dismissed only by clicking outside of it or with the Enter or Escape keys. 3) A 'double-escape' model is introduced in which if a user has opened the popup and changed the value, hitting Escape once will reset the value back to what it was when the popup was opened. Hitting Escape once more, when the popup value matches the value when opened, will dismiss the popup. Bug: 1001571 Change-Id: I1369851208c3da0231b6c1d6fb218b9c13e00ca5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992598 Commit-Queue: Dan Clark <daniec@microsoft.com> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#729968}
-
John Williams authored
This CL fixes a crash that can happen when closing a window after using the desktop media picker. In addition, async calls to OnPickerDialogResults are now done through a weak pointer. This change doesn't fix any specific issue I've observed, but it seems like a good defensive measure. Bug: 1032330 Change-Id: I9a2d6264becd805ae3d1ea66bd124c003f200fd9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988984 Commit-Queue: John Williams <jrw@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#729967}
-
Fabrice de Gans-Riberi authored
This reverts commit 27453d76. Reason for revert: Suspected cause for build failure: https://ci.chromium.org/p/chromium/builders/ci/chromeos-amd64-generic-asan-rel/23333 Original change's description: > Add a flag for building HWASAN splits. > > The new build_hwasan_splits flag causes HWASAN splits to be created for > the Monochrome6432 and TrichromeChrome6432 bundles, as well as any of its > DFMs that contain native code. The intent is that this flag will eventually > default to true in official builds. > > The library is deliberately installed in TrichromeChrome6432 rather than > TrichromeLibrary6432 (where the regular native library lives) because the > Android platform does not support splits for the library containing the > WebView implementation. This means that only Chrome will use the HWASANified > native library, and WebView will use the regular native library. > > Bug: 916828 > Change-Id: Ie92bb36e83df245ab431b0123a44b0f0a3182100 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769731 > Commit-Queue: Peter Collingbourne <pcc@chromium.org> > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Cr-Commit-Position: refs/heads/master@{#729945} TBR=torne@chromium.org,cjgrant@chromium.org,pcc@chromium.org,agrieve@chromium.org Change-Id: Ic8ee9206385f27941f1fa12e7927376c673e4149 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 916828 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993747Reviewed-by:
Fabrice de Gans-Riberi <fdegans@chromium.org> Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Cr-Commit-Position: refs/heads/master@{#729966}
-