GitLab

BUG=314889

Review URL: https://codereview.chromium.org/560983002

Cr-Commit-Position: refs/heads/master@{#294719}

First, it is a good cleanup to avoid an extra copy of all the variable info.
Second, this cleanup will make switching to ANGLE's new APIs to query variable
info much easier.

BUG=401311
TEST=gpu_unittests, webgl_conformance_tests
R=bajones@chromium.org,kbr@chromium.org,piman@chromium.org

Review URL: https://codereview.chromium.org/566023002

Cr-Commit-Position: refs/heads/master@{#294718}

 Added CHECKs in static methods in ash::Shell/RootWindowController to identify the chrome code accessing ash

BUG=410444
TBR=sky@chromium.org
TEST=tested on Pixel

Review URL: https://codereview.chromium.org/549453005

Cr-Commit-Position: refs/heads/master@{#294717}

https://skia.googlesource.com/skia/+log/83658305a1bda2d862f50145ecf5cb697b575e86..c34b0d4e9ad5806c1f882a1f85191f2ea8ddcdba

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=fmalita@google.com

Review URL: https://codereview.chromium.org/569803002

Cr-Commit-Position: refs/heads/master@{#294716}

BUG=413513

Review URL: https://codereview.chromium.org/568793002

Cr-Commit-Position: refs/heads/master@{#294715}

There's no functional change in this CL.

I clarified the behavior of resolution changes for video capture devices
by using an enum to describe resolution change policy instead of a
simple boolean.

BUG=388355

Review URL: https://codereview.chromium.org/541163002

Cr-Commit-Position: refs/heads/master@{#294714}

BUG=402728

Review URL: https://codereview.chromium.org/559103003

Cr-Commit-Position: refs/heads/master@{#294713}

TBR=cpu@chromium.org,jochen@chromium.org,piman@chromium.org,rockot@chromium.org,rsleevi@chromium.org,vrk@chromium.org
,zea@chromium.org

Review URL: https://codereview.chromium.org/563173002

Cr-Commit-Position: refs/heads/master@{#294712}

Previously, the TouchEventQueue would flush itself when notified that
all touch handlers have been removed. As that is no longer the case,
remove the assert verifying that the queue is empty when notified that
a touch handler has been added.

BUG=406916

Review URL: https://codereview.chromium.org/569793003

Cr-Commit-Position: refs/heads/master@{#294711}

Remove cc:RasterRequiredForActivation synthetic delays from raster
worker pools and disable pages that use it.

R=reveman@chromium.org, skyostil@chromium.org, brianderson@chromium.org
BUG=

Review URL: https://codereview.chromium.org/569733002

Cr-Commit-Position: refs/heads/master@{#294710}

In general, GN assumes that static libraries are intermediate targets and
will forward their child dependencies up the tree until a "final" target
is reached. Until now, this meant only shared_library and executable targets.
This change introduces the notion of a "complete" static_library target
which is linked and, as such, suitable for distribution.

BUG=413776
TEST=gn_unittests
R=brettw@chromium.org

Review URL: https://codereview.chromium.org/565283002

Cr-Commit-Position: refs/heads/master@{#294709}

An edge case around direction and playback rate is calculating the time
incorrectly. In particular, when the playback rate is negative and the
direction is set to AlternateReverse, the resulting iteration times
calculated are incorrect. This change brings the compositor in line
with the Web Animation Spec to calculate the iteration time.

Reference for calculations:
http://dev.w3.org/fxtf/web-animations/#core-animation-node-calculations

BUG=398330

Review URL: https://codereview.chromium.org/565353003

Cr-Commit-Position: refs/heads/master@{#294708}

Becuase base/strings/string_split.h defines:
typedef std::vector<std::pair<std::string, std::string> > StringPairs;

BUG=412250

Review URL: https://codereview.chromium.org/568173004

Cr-Commit-Position: refs/heads/master@{#294707}

Currently each render surface takes as its clip rect for visible content
rects as the clip rect directly clipping its own surface, but drops the
clip for visible content rects from outside the surface.

This means that the viewport does not clip the visible_content_rect of
any layers that aren't in the root surface. Fixed by intersecting this
clip for visible content rects with the one from outside the surface.

BUG=410625

Review URL: https://codereview.chromium.org/565353002

Cr-Commit-Position: refs/heads/master@{#294706}

The memory allocated for an enumeration should be freed when a backend
is deleted.

R=clamy@chromium.org,jkarlin@chromium.org
BUG=410276

Review URL: https://codereview.chromium.org/533293002

Cr-Commit-Position: refs/heads/master@{#294705}

No need to keep useless helper mocks around. This also helps clean up
VideoRendererImpl's unit tests in preparation for switching to the
scheduler.

Review URL: https://codereview.chromium.org/566853006

Cr-Commit-Position: refs/heads/master@{#294704}

Change PageTest.WillStartBrowser to depend on platform instead of browser object as it would not have been created at this point.

BUG=413481

Review URL: https://codereview.chromium.org/554583003

Cr-Commit-Position: refs/heads/master@{#294703}

Probably left over from code being moved around.

Review URL: https://codereview.chromium.org/569793002

Cr-Commit-Position: refs/heads/master@{#294702}

BUG=408493, 408534

Review URL: https://codereview.chromium.org/509313002

Cr-Commit-Position: refs/heads/master@{#294701}

 * Fix wrong header guard.
 * Remove or add explicit constructor
 * Remove unwanted semicolon

BUG=None

Review URL: https://codereview.chromium.org/563263002

Cr-Commit-Position: refs/heads/master@{#294700}

When windows are moved the underlying display controller changes. In these cases
we need to hide the cursor before moving and restore it after.

BUG=none
NOTRY=true

Review URL: https://codereview.chromium.org/566953002

Cr-Commit-Position: refs/heads/master@{#294699}

R=lcwu@chromium.org,byungchul@chromium.org
BUG=None

Review URL: https://codereview.chromium.org/563323003

Cr-Commit-Position: refs/heads/master@{#294698}

TCP FastOpen is currently turned on for all TCP connections when explicitly enabled from flags. This CL implements the plumbing required to turn it on for SSL connections by default. A subsequent CL will do the Finch plumbing.

BUG=402005

Review URL: https://codereview.chromium.org/451383002

Cr-Commit-Position: refs/heads/master@{#294697}

- Added a command line switch to enable quick locking mode.
- Refactored SessionStateAnimator into an interface, implementation, and a test double so that all the LockStateControllerTests could be re-enabled.
- Re-enabled LockStateControllerTests.

BUG=371608, 167048, 162645

Review URL: https://codereview.chromium.org/326813004

Cr-Commit-Position: refs/heads/master@{#294696}

Allow event modifier flags to propagate through the touch and/or
gestures derived from a MotionEvent. This allows, for example,
ctrl + tap to mimic ctrl + click. Note that, previously, Aura routed
these modifier flags separately, and Android failed to route them at
all.

BUG=398439,413335

Review URL: https://codereview.chromium.org/567783002

Cr-Commit-Position: refs/heads/master@{#294695}

The enhanced bookmarks extension is being updated to rely solely on
server-generated persistent IDs, eliminating the need to create IDs
in Chrome client code.

This is effectively a revert of 0f7d5081
and 224e1d18.

BUG=413378

Review URL: https://codereview.chromium.org/568923004

Cr-Commit-Position: refs/heads/master@{#294694}

This is preparing for a GN unit test target that shares the sources list. This change only moves the main files list to minimize merge conflicts in the future steps.

TBR=jamesr

Review URL: https://codereview.chromium.org/568923002

Cr-Commit-Position: refs/heads/master@{#294693}

This patch provides the minimal changes necessary to hook
WebMediaPlayerImpl into HTMLDocumentView so that <audio>/<video> tags
work. HTMLMediaElement will now function, but audio won't be audible
right now. Proper audio output will be added in a followup patch.

Review URL: https://codereview.chromium.org/567803002

Cr-Commit-Position: refs/heads/master@{#294692}

(Will make it easier to move the memory_cache_http_server ownership
from browser to platform.)

The page_cycler measurement was the only customer. This CL includes
an alternate implementation for that.

BUG=404771

Review URL: https://codereview.chromium.org/543243002

Cr-Commit-Position: refs/heads/master@{#294691}

R=dbeam@chromium.org
BUG=393873
TEST=GYP_GENERATORS=ninja gyp --depth . chrome/browser/resources/options/compiled_resources.gyp && ninja -C out/Default | grep ERROR | wc -l

Review URL: https://codereview.chromium.org/543493002

Cr-Commit-Position: refs/heads/master@{#294690}

This CL registers the webview tag in extensions, allowing it to be used inside app_shell. The webview browser sample should be working with this patch.

For now, not all the webview APIs are supported, the APIs that are not supported are: contextMenus, webrequest, declarativeWebRequest and permissions (videoCapture, pointerLock, geolocation).

BUG=352293

Review URL: https://codereview.chromium.org/566863004

Cr-Commit-Position: refs/heads/master@{#294689}

Use ExtensionManagement instead.

BUG=177351

Review URL: https://codereview.chromium.org/555323002

Cr-Commit-Position: refs/heads/master@{#294688}

Similar to https://codereview.chromium.org/385743002 , but in a file
that's also built in host targets. Depends on r#294584.

If your bot can't deal with this, please let me know!

BUG=none

Review URL: https://codereview.chromium.org/443483002

Cr-Commit-Position: refs/heads/master@{#294687}

This will make it set up a proxy message pipe, and is a stopgap measure
until we have proper message pipe passing (across multiple
channels/processes).

I don't know what bugs there might be, though I added a basic test
(across a single remote message pipe and back). I should add yet more
tests.

R=davemoore@chromium.org

Review URL: https://codereview.chromium.org/566783002

Cr-Commit-Position: refs/heads/master@{#294686}

BUG=278540
NOPRESUBMIT=true
R=isherman@chromium.org, rockot@chromium.org

Review URL: https://codereview.chromium.org/550913003

Cr-Commit-Position: refs/heads/master@{#294685}

Matches what we have in AudioRendererImpl, which is our only other
TimeSource implementation.

TBR=xhwang

Review URL: https://codereview.chromium.org/551273004

Cr-Commit-Position: refs/heads/master@{#294684}

The perf dashboard expects that for values of the form x.y that are per-page,
the computed summary x.y (i.e., the value having that name but not associated
with any particular Page object) will be displayed but the per-page x.y's will
be ignored.

Previously, the per-page x.y's were being named as x: <pagename> in the
buildbot convention; it was the job of the log processing step to make sure
that these extraneous, ambiguously-named values were ignored. The Chart JSON
output formatter, on the other hand, explicitly guards against adding values
with duplicate names, and so extra checks are necessary to throw away such
extraneous values.

This patch adds handling to the Chart JSON output formatter to address this
issue, and updates the tests to check for correctness in this scenario.

R=sullivan,qyearsley,tonyg

Review URL: https://codereview.chromium.org/551063005

Cr-Commit-Position: refs/heads/master@{#294683}

1. add uma metrics related to the new android signin promo
2. add a method to SigninManager to get the finch experiment for promo

Downstream changes at https://chrome-internal-review.googlesource.com/#/c/175857/

BUG=406614
TBR=rogerta@chromium.org

Review URL: https://codereview.chromium.org/568603002

Cr-Commit-Position: refs/heads/master@{#294682}

Also fix some controlled settings indicators.

BUG=409938
R=dbeam@chromium.org

Review URL: https://codereview.chromium.org/539383003

Cr-Commit-Position: refs/heads/master@{#294681}

This was added to fix the component build on Linux, but Android doesn't have this library.

R=jamesr@chromium.org
TBR=jamesr

Review URL: https://codereview.chromium.org/567073002

Cr-Commit-Position: refs/heads/master@{#294680}