- 18 Sep, 2019 40 commits
-
-
James Cook authored
By default, clicking on the People > Profile row will open the Chrome OS account manager in a new window. Change the row to use the "link out" arrow icon. Screenshot: http://screen/UBHW5acnie0 If ChromeOSAccountManager is disabled, it does nothing on click, like before. If SplitSettings is disabled, it opens the profile picture picker, like before. Bug: 1004446 Test: added to browser_tests Change-Id: Ia537bdc4fa841ec1995496b87c4650e0b1e761a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1811862Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#697820}
-
Charlene Yan authored
Bug: 1003765 Change-Id: If6e35db7a420a77ee2f532e3545ab1c1626cf54e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807575 Commit-Queue: Charlene Yan <cyan@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#697819}
-
Giovanni Ortuño Urquidi authored
Enums were initialized before the interface's namespace which caused an error when trying to add the enum to the namespace. This CL fixes the issue by moving enum initialization after the interface's namespace is initialized. Bug: 1004822 Change-Id: I6e8328ebc7cccee744388bb32939dfe1bdfcbd42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810170Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#697818}
-
Rakib M. Hasan authored
TBR=crouleau@chromium.org Bug: chromium:999335 Change-Id: I2030d0d319ef1c091b29a725198c4f99cc4b66c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1811997Reviewed-by:
Rakib Hasan <rmhasan@google.com> Commit-Queue: Rakib Hasan <rmhasan@google.com> Cr-Commit-Position: refs/heads/master@{#697817}
-
Xianzhu Wang authored
After crrev.com/c/1799701, non-backdrop-filter mask layers become normal layers with DstIn blend mode, thus they can be tiled normally to avoid the problems caused by single tile before (e.g. too much memory usage for huge masks, no benefits of tile management). Bug: 1003414 Change-Id: Ic0c5d318bc3e657de861f6c7246c417399900209 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1805468Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Malay Keshav <malaykeshav@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#697816}
-
Andrew Xu authored
ShelfWidget's bounds are offset to leave space for the navigation widget even when the login shelf shows. It leads to the wrong layout of the login shelf. This CL fixes such an issue. Bug: 994424 Change-Id: I2f422e2a53e7d40f76ebbbb53204e1619ccc95e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1811642Reviewed-by:
-
Henrique Ferreiro authored
Convert the implementation and all users of the mojom::InterventionsInternalsPageHandler and InterventionsInternalsPage interfaces. Bug: 955171 Change-Id: I7a11210d5c392bc8b11ae2ef283f66222d1c17cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808860Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Ben Greenstein <bengr@chromium.org> Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Cr-Commit-Position: refs/heads/master@{#697814}
-
Jack Lynch authored
This CL sets the alt attribute of images shown within the Performance panel Event Log based on their source URLs. Screenshot of details panel showing image: https://gyazo.com/ec6d3643fc657c635da5fd37b3c630bc Bug: 963183 Change-Id: I1071611f824dd00ccadaadcbf364d66dbcf01028 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721187 Commit-Queue: Jack Lynch <jalyn@microsoft.com> Reviewed-by:
Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#697813}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/8baaec47e3bd..c6be56ecedf9 git log 8baaec47e3bd..c6be56ecedf9 --date=short --no-merges --format='%ad %ae %s' 2019-09-18 ehmaldonado@chromium.org Revert "Set core.trustctime=false during git checkout operations." Created with: gclient setdep -r src/third_party/depot_tools@c6be56ecedf9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: chromium:330461,chromium:642711,chromium:746763,chromium:740301. Change-Id: Ibb66873a15733dce75176b95b005efefeb4edc49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1811978Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#697812}
-
danakj authored
This is a reland of 55474752 Original change's description: > Revert "Move page zoom level responsibility into RenderViewImpl." > > This reverts commit 6876fb4f. > > Reason for revert: Breaks layout tests even though they passed in the CQ??? > > Linux: > animations/animationworklet/worklet-animation-responsive-to-zoom.html > svg/as-image/img-zoom-svg-stylesheet.html > fast/media/mq-width-pagezoom.html > > Windows: > animations/responsive/zoom-responsive-translate-animation.html > fast/media/mq-resolution-pagezoom.html > fast/backgrounds/tiny-tile-zoomed.html > > animations/animationworklet/worklet-animation-responsive-to-zoom.html > svg/as-image/img-zoom-svg-stylesheet.html > fast/media/mq-resolution-pagezoom.html > > > Original change's description: > > Move page zoom level responsibility into RenderViewImpl. > > > > Page zoom level is a page/view concept, but the code to manage it is > > currently in RenderFrameImpl, though only run when it is the root frame. > > > > This doesn't dramatically change ownership of responsibility but moves > > the code up into RenderViewImpl. RenderWidget still goes through > > RenderFrameImpl (though more explicitly) to set the zoom level on the > > RenderView. And RenderWidget takes responsibility for closing the page > > popup instead of having multiple "set page zoom" methods on > > RenderViewImpl. > > > > This uncovered some spooky action-at-a-distance and makes it more > > explicit and documented, though no less unfortunate. A local root > > LocalFrame does not initialize with the correct page zoom value because > > it has no parent to read it from. We (accidentally?) worked around that > > by setting the RenderView's page zoom to its current value when > > navigating a (new) LocalFrame, which would call into blink's WebView > > and walk through the entire frame tree setting the value on everything, > > eventually also on the new LocalFrame. > > > > Now on navigation, for a local root, we call RenderWidget's > > UpdateWebViewWithDeviceScaleFactor() which does the same thing by > > re-setting the WebView's page zoom factor. This was done when making > > a new main frame in multiple places (RenderView and RenderFrame both > > called it in the same CreateFrame() callstack). Now it is consolidated > > to a single place on navigation for the main frame and child frames > > giving them more consistent behaviour, and going explicitly through > > this method that should go away if things were well designed, rather > > than re-setting the RenderView to its own value. > > > > Remove calls to UpdateWebViewWithDeviceScaleFactor() scattered > > throughout RenderViewImpl and RenderFrameImpl. What we need is for > > 1) The Page to be updated with PreferCompositingToLCDText when the > > device scale factor changes. > > 2) The WebView to be updated when the device scale factor changes. > > 3) The LocalFrame of a local root needs its page zoom set by poking > > the WebViewImpl to walk through all frames and set it. > > > > R=erikchen@chromium.org > > > > Bug: 419087 > > Change-Id: I97c0e287be8f96a4ac632d63b981c190169dc1a9 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1799386 > > Reviewed-by: Avi Drissman <avi@chromium.org> > > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > > Reviewed-by: Erik Chen <erikchen@chromium.org> > > Commit-Queue: danakj <danakj@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#697687} > > R=avi@chromium.org, dcheng@chromium.org, erikchen@chromium.org > TBR=danakj@chromium.org > > Change-Id: I3177d7f7a601b6692fd931623ca749bacce051c9 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 419087 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1811937 > Reviewed-by: danakj <danakj@chromium.org> > Commit-Queue: danakj <danakj@chromium.org> > Cr-Commit-Position: refs/heads/master@{#697766} TBR= Bug: 419087 Change-Id: Ida285bb065092d369f3cf263986343e200a8ed41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1811864 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#697811}
-
Patrick Monette authored
Also changes NotifiesOnlyOnChangesWithPreviousValue to pass the previous value by const-ref. Bug: 999594 Change-Id: I63ce2cdb1d085ac68a7abb2a7b8211be0a353c56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787727 Commit-Queue: Patrick Monette <pmonette@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#697810}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/46e424ec..f1aa36df Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I16ae6795658d51264ae80cafe1b32fb1bbed1cf6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1811181Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#697809}
-
Xianzhu Wang authored
We ignored position of mask layers before crrev.com/697315 by always setting the mask layer's offset_to_transform_parent and property tree state to the same as the masked layer. As we removed the special handling code for mask layers from PropertyTreeBuilder, now we ignore position of mask layers in Layer::SetPosition() to keep the original behavior. Bug: 100532 Change-Id: I2c9def5e139ea6a3c798593f8f0c2a219d2bdc8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810844Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/7c1b59b7b8a9..edf199a0b96c git log 7c1b59b7b8a9..edf199a0b96c --date=short --no-merges --format='%ad %ae %s' 2019-09-18 treehugger-gerrit@google.com Merge "Re-enable heapprofd CTS on x86." 2019-09-18 treehugger-gerrit@google.com Merge "Implement command queue in adb socket controller" Created with: gclient setdep -r src/third_party/perfetto@edf199a0b96c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: I2a03b597593e2029af7579b0906431b59b177d5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1811979Reviewed-by:
-
Dale Curtis authored
The pulseaudio source code checks pa_context and pa_stream state while waiting for operation completion. Lets do the same thing on the off chance that's the source of our hangs. See CHECK_DEAD_GOTO macro upstream: https://github.com/pulseaudio/pulseaudio/blob/master/src/pulse/simple.c#L68 This change modifies the WaitForOperationCompletion() method to take an optional pa_stream and/or pa_context and checks their state while waiting. In cases where failure could be signaled as an error upstream, a bool status code is used to do so. BUG=986021 R=tguilbert Change-Id: I7075293d1f74ad12f6c596bce39bbf0bba2c9a73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1811698 Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#697806}
-
Connie Wan authored
The underline is composed of two parts: 1) A straight underline, painted by TabStrip, extending from the group header to the last time (minus some inset). 2) A stroke above the active tab, painted by TabStyleViews, which (along with the active tab background) is layered over the straight underline. The underline is still missing the following polish: - Half-rounded edges. - Potential redesign of the stroke above the active tab. Screenshots are in the attached bug. Bug: 905491 Change-Id: I4a99a67f9637b8a879bba7589feb848edb30deee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809546 Commit-Queue: Connie Wan <connily@chromium.org> Reviewed-by:
Taylor Bergquist <tbergquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#697805}
-
Ana Salazar Maldonado authored
Users should be able to rename a folder by tapping on the folder name or in any area near it. Bug: 997364 Change-Id: Id2fd2e04fdce99e8323a8cdbd55d18e120e38e24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1791630Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Commit-Queue: Ana Salazar <anasalazar@chromium.org> Cr-Commit-Position: refs/heads/master@{#697804}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/9d3a62e82627..3681d5f8b5d7 git log 9d3a62e82627..3681d5f8b5d7 --date=short --no-merges --format='%ad %ae %s' 2019-09-18 thestig@chromium.org Add CPDF_Array::GetBooleanAt(). 2019-09-18 thestig@chromium.org Add yet another pixel test for invalid glyph ID. 2019-09-18 thestig@chromium.org Consistently declare operator=. 2019-09-18 thestig@chromium.org Sync third_party/freetype/OWNERS with Chromium's. Created with: gclient setdep -r src/third_party/pdfium@3681d5f8b5d7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=pdfium-deps-rolls@chromium.org Bug: None Change-Id: I6ed43661a048368120eb0d47def1cd02d0f9f29d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1811857Reviewed-by:
-
Tom Anderson authored
https://chromium.googlesource.com/external/fontconfig.git/+log/ba206df9b9a7..65087ac7ce4c $ git log ba206df9b..65087ac7c --date=short --no-merges --format='%ad %ae %s' 2019-08-29 jtojnar conf: Add JoyPixels emoji font 2019-08-28 akira Do not return FcFalse from FcConfigParseAndLoad*() if complain is set to false 2019-08-21 Szunti Add missing return type for FcFontSet* functions 2019-08-09 akira Affect FC_FONT_HAS_HINT property to score on matcher 2019-08-07 akira Improve the performance a bit 2019-07-31 akira Fix the fails of make check when SOURCE_DATE_EPOCH is set 2019-07-29 akira Fix failing the check of prep table in some fonts 2019-07-29 akira Add FC_FONT_HAS_HINT property to see if font has hinting or not. 2019-07-26 akira Add 35-lang-normalize.conf 2019-07-26 akira Fix a memory leak in FcFreeTypeQuery*() 2019-07-23 akira Fix memory leaks 2019-07-23 akira Fix the fail on fc-cache 2019-07-23 akira Add docs for missing properties 2019-07-23 akira Clean up temporary directory for tests 2019-07-22 akira FcConfigParseAndLoad*() should returns false on config errors 2019-07-09 akira Add English name first into a cache 2019-07-09 akira Fix a typo 2019-07-08 akira Improve the performance a bit 2019-07-02 akira Fix a crash when running with FC_DEBUG=256 2019-06-24 akira Fix obtaining real path from pre-defined names for Win32 2019-06-21 akira Don't clean up pre-built docs if no docbook installed. 2019-06-19 egmont Fix the linear interpolation during weight mapping 2019-06-18 akira Fix a typo on masking face id 2019-06-10 akira Bump version to 2.13.91 2019-06-10 akira Fix endianness on generating MD5 cache name 2019-06-06 akira Fix a typo in the description of FcWeightFromOpenTypeDouble 2019-06-03 akira Correct the comment for FC_LANG in fontconfig.h 2019-05-09 akira fc-validate: returns an error code when missing some glyphs 2019-05-08 akira Update CaseFolding.txt to Unicode 12.1 2019-04-15 jon.turney Only use test wrapper-script if host is MinGW 2019-04-15 akira Distribute archive in xz instead of bz2 2019-04-04 akira Update the test case that is looking for uuid based on host 2019-04-04 akira No need to remap for uuid based 2019-04-04 akira Fallback uuid-based name to read a cache if no MD5-based cache available 2019-04-04 akira Fix unexpected cache name by double-slash in path 2019-04-04 akira Don't show salt in debugging message if salt is null 2019-04-03 akira Allow overriding salt with new one coming later 2019-04-02 akira fc-cache: Show font directories to generate cache with -v 2019-04-02 akira Oops, Terminate string 2019-04-02 akira Add some debugging output 2019-04-02 akira Don't warn if path can't be converted with prefix 2019-03-26 akira Don't share fonts and cache dir for testing 2019-03-25 akira Add more data to artifacts for debugging purpose 2019-03-25 akira Fix make check fail on MinGW again 2019-03-25 akira Use alternative function for realpath on Win32 2019-03-25 akira Fix build issues on MinGW 2019-03-25 akira Add back if !OS_WIN32 line 2019-02-01 akira trivial testcase update 2019-02-01 akira Update doc for salt 2019-01-31 akira Add salt attribute to dir and remap-dir elements (...) 2019-01-28 akira Fix make check fail on run-test-conf.sh 2019-01-28 akira Drop a line to include uuid.h 2019-01-28 akira Add FcDirCacheCreateUUID doc back to pass make check 2018-10-29 keithp Replace UUID file mechanism with per-directory 'map' attribute [v2] 2018-10-29 keithp Remove UUID-related tests 2018-10-29 keithp Add delays to test-bz106632, check UptoDate separately 2018-10-29 keithp Remove '-u' option from run-test-conf.sh 2018-10-29 keithp Fetch FONTCONFIG_SYSROOT in FcConfigCreate 2019-04-03 akira Reset errno to do error handling properly 2019-03-23 akira Don't test bind-mount thing for MinGW 2019-03-23 akira Install wine for CI on MinGW 2019-03-23 akira Correct configure option to cross-compile 2019-03-23 akira Update requirement for gettext 2019-03-23 akira Fix make distcheck error 2019-03-22 akira Add build test for MinGW 2019-03-22 akira Fix make check on cross-compiled env 2019-03-22 akira Ifdef'ed unnecessary code for Win32 2019-03-22 akira autogen.sh: Make AUTORECONF_FLAGS overwritable 2019-03-19 akira Fix build issue on Win32. 2019-03-15 akira Fix misleading summary in docs for FcStrStrIgnoreCase 2018-09-25 akira Add system-ui generic family 2019-02-19 bungeman Better document sysroot. 2019-01-25 liezhi.yang src/fccache.c: Fix define for HAVE_POSIX_FADVISE 2019-01-23 akira Fix a crash with invalid matrix element 2018-11-30 akira Fix a dereference of a null pointer 2018-11-30 akira covscan: fix compiler warnings 2018-11-30 akira Don't call unlink_dirs if basedir is null 2018-11-12 akira covscan fix: get rid of unnecessary condition check 2018-11-30 akira Warn when constant name is used for unexpected object 2018-11-27 akira Add a test case for FcFontList 2018-11-27 akira Fix FcFontList doesn't return a font with FC_COLOR=true 2018-11-26 cjmcdonald Lowered temporary rooted_dir variable inside loop 2018-11-19 cjmcdonald Respect sysroot option for file path passed to stat 2018-11-15 akira Add doc for description element and update fonts.dtd 2018-11-13 akira Use Rachana instead of Meera for Malayalam 2018-11-06 akira Use FC_PATH_MAX instead of PATH_MAX 2018-11-06 akira Enable bubblewrap test case 2018-10-29 akira Drop Mitra Mono from 65-nonlatin.conf 2018-10-24 behdad Fix name-table language code mapping for Mongolian 2018-10-25 akira Do not run a test case for .uuid deletion 2018-10-17 keithp Do not remove UUID file when a scanned directory is empty 2018-10-01 akira Do not try updating mtime when unlink was failed 2018-09-28 akira Do not update mtime when removing .uuid file 2018-10-04 akira CI: Add more logs 2018-10-04 akira Fix test case 2018-10-04 akira add missing the case of prefix="default" as documented 2018-10-04 akira Update docs for 1aa8b700 2018-10-04 akira Update fonts.dtd for last commit 2018-10-02 akira Add more prefix support in <dir> element 2018-09-28 akira Fix CI Created with: roll-dep src/third_party/fontconfig/src BUG=843886,1004254 R=spang,dnicoara Change-Id: If6853404f1e87de4f95a24f6231282543814bd63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809892Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Michael Spang <spang@chromium.org> Reviewed-by:
Etienne Bergeron <etienneb@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#697802}
-
Maksym Onufriienko authored
Bug: 1001667 Change-Id: Iff50ac71a25d3dd33b81f08f8e38d6d2d9df6f67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1802023Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Maksym Onufriienko <monufriienko@chromium.org> Cr-Commit-Position: refs/heads/master@{#697801}
-
Chromium WPT Sync authored
Using wpt-import in Chromium d5e9cf22. With Chromium commits locally applied on WPT: 13765318 "[WPT/common/security-features] Introduce iframe-blank source context" bda4c129 "Revert "Re-land: Fix `Referer` for descendant module scripts and worklets"" 55a477b6 "Implement word boundary matching" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: dgrogan@chromium.org: external/wpt/css/css-tables drott@chromium.org, kojii@chromium.org: external/wpt/css/css-fonts ericwilligers@chromium.org: external/wpt/css/motion foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools kojii@chromium.org: external/wpt/css/css-writing-modes mkwst@chromium.org, andypaicu@chromium.org: external/wpt/content-security-policy rego@igalia.com: external/wpt/css/css-grid skobes@chromium.org: external/wpt/css/css-scroll-anchoring NOAUTOREVERT=true TBR=lukebjerring No-Export: true Change-Id: I0baf91bfb20c2e9932e72356cb41079da94f26c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1811180Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#697800}
-
Matt Wolenetz authored
Reports (up to once per page) if any SourceBuffer's coded frame processing encountered a problematic scenario where the group end timestamp decreases within a media segment. The spec doesn't expect this to occur, nor does media element duration update at the last step of the coded frame processing algorithm allow for this situation (the resulting duration could be less than what was actually buffered, for example). In Chrome, the buffered ranges calculation algorithm has subsequent problems. Current discussion on this in the MSE spec (https://github.com/w3c/media-source/issues/203) could benefit from understanding if this is indeed a common or uncommon scenario to scope clarification work to improve interoperability and reduce spec ambiguity for this scenario. BUG=920853 TEST=FrameProcessorTest.GroupEndTimestampDecreaseWithinMediaSegmentShouldWarn Change-Id: Id8bf00adee32bc9d3e3d3bb18e9176b0b789fb24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810330Reviewed-by:
-
Henrique Nakashima authored
These methods were added for crbug.com/358708 but the usage was Reverted shortly after and they were not cleaned up. This is a reland of https://chromium-review.googlesource.com/c/chromium/src/+/1808082 which was reverted because IDS_UPDATE_FROM_MARKET because an unused resource in builds with arcore disabled. The fix is to move the resource into a section of the strings protected by '<if expr="enable_arcore">', see https://chromium-review.googlesource.com/c/chromium/src/+/1810847/2..3 TBR=dmazzoni@chromium.org,twellington@chromium.org Bug: 995916, 1005188 Change-Id: Ida0ec91096293735e0112d4a5fcc74a406befc99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810847Reviewed-by:
Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#697798}
-
Jenny Zhang authored
Bug: 1004922 Change-Id: I0662c2010e0914f46be0a9f1ae4ed9e711adc3db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810842Reviewed-by:
-
Austin Eng authored
Mapped buffers may still hold onto shared memory when the page is torn down. We first need to destroy all API objects, and then ensure that any shared memory allocations are freed. Bug: chromium:1005284 Change-Id: Ie080e4a26e2b572988a7d219ba0aed2dc61cdc37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1811345Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Austin Eng <enga@chromium.org> Cr-Commit-Position: refs/heads/master@{#697796}
-
Jeroen Dhollander authored
This allows us adding unittests to AssistantManagerServiceImpl. This has been done by moving most accessors in a |ServiceContext| object. I also moved a call to |EnableHotword| from |AssistantManagerServiceImpl| to |Service|, and I introduced a new |AssistantCommunicationErrorObserver| so the |Service| now knows about communication failures when communicating with libassistant (and can request a new authentication token when required). Finally I replaced all calls to the singletons |CrasAudioHandler::Get()| and |PowerManagerClient::Get()| with method calls on the |ServiceContext| object. This again should make it easier to unittest things, as it makes it easier to spot the fact that a lot of classes use these objects. Change-Id: Icc1cbbe02b771c59785204bd43cd6a8d3672b748 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1802030 Commit-Queue: Jeroen Dhollander <jeroendh@google.com> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#697795}
-
Lukasz Anforowicz authored
Before this CL, ExtensionNavigationThrottle would more-or-less ignore main frame navigations (except for special-casing some GuestView scenarios). This allowed some undesirable navigations as pointed out in https://crbug.com/442579. After this CL the throttle continues with WebAccessibleResources checks even for main frames. Before this CL, ExtensionNavigationThrottle would check if the target is one of WebAccessibleResources iff the frame being navigated has an ancestor that has a different origin than the target of the navigation. This doesn't work for main frames (which have no parent). This could be addressed by also going over opener relationship, but the right fix here is to directly consider |initiator_origin| (which is trustworthy and browser-verified). After this CL, |initiator_origin| is considered. Applying the throttle checks to more navigations means that the throttle has to replicate some exceptions from ChromeContentBrowserClientExtensionsPart::ShouldAllowOpenURL. Specifically, the throttle needs to ignore navigations ignored by origins with chrome://, chrome-search:// and devtools:// schemes. Additionally the changes mean that opaque origins (even if they have been derived from an extension origin) cannot navigate to non-WebAccessibleResources. This requires tweaking the sandboxed_pages_csp test. Bug: 442579 Change-Id: Iebc72b05fece9d0936214f5f8e00802b59e84fd1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776854 Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Kevin McNee <mcnee@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#697794}
-
Jan Wilken Dörrie authored
This change renames base::CheckedRandomAccess(Const)Iterator to base::CheckedContiguous(Const)Iterator. This change is motivated by the fact that this iterator not only fulfils the requirements of RandomAccessIterator [1], but also ContiguousIterator [2]. Furthermore, the implementation of the iterator assumes it is pointing into a single contiguous array, and thus is unsuitable for containers that have random access, but don't operate on an underlying array, such as std::deque. [1] https://en.cppreference.com/w/cpp/named_req/RandomAccessIterator [2] https://en.cppreference.com/w/cpp/named_req/ContiguousIterator Bug: 817982 Change-Id: I7186dfc3b2849818b9f83d62e05ebc5a79aaf5ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1811377 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Chris Palmer <palmer@chromium.org> Cr-Commit-Position: refs/heads/master@{#697793}
-
Tao Bai authored
In debug build, there is assert to verify the expected callback is larger than zero, so the previous test won't work. This patch simulates user triggering autofill and verifies autofill is triggered once, that proves javascript change didn't trigger the autofill. Bug: 1001309 Change-Id: I2cb9e384f14e98cee9380ccef51b3cc8b8bbc2f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1802683 Commit-Queue: Tao Bai <michaelbai@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Cr-Commit-Position: refs/heads/master@{#697792}
-
Sunny Sachanandani authored
Animating infobars during startup is speculated to cause regressions and noise in rendering benchmarks. This CL disables animations for bad flag and automation infobars by allowing the InfoBarDelegate to control if the infobar animates or not. Bug: 804324 Change-Id: I2c1067e122cf031ab151a1f51d9d11bc6bac60e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808297Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#697791}
-
Nathan Zabriskie authored
This CL adds SwapTimings to FrameTimingDetails which is sent to Viz clients on each begin frame. The information in SwapTimings will be used in a future CL to add viz-stage histograms to CompositorFrameReporter. Bug: 963787, 963780 Change-Id: I6df2d9654d54e7ef5772e32e6b8a95cd741d485c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764515 Commit-Queue: Nathan Zabriskie <nazabris@microsoft.com> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Daniel Libby <dlibby@microsoft.com> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Cr-Commit-Position: refs/heads/master@{#697790}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/e70432574670..017dfff534a5 git log e70432574670..017dfff534a5 --date=short --no-merges --format='%ad %ae %s' 2019-09-18 chrisforbes@google.com Implement alpha blend support for VK_FORMAT_A2B10G10R10_UNORM_PACK32 Created with: gclient setdep -r src/third_party/swiftshader@017dfff534a5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Bug: None Change-Id: Ida810f3d27bbde13e22c1eac99a09fa27b3344da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1811296Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/e34564bafe83..db09eb68b9de git log e34564bafe83..db09eb68b9de --date=short --no-merges --format='%ad %ae %s' 2019-09-18 amaiorano@google.com Increase the max fence wait time in debug builds Created with: gclient setdep -r src/third_party/angle@db09eb68b9de If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC geofflang@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@chromium.org Bug: None Change-Id: I840aad49c3854ed9158a579578efa40059db4978 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1811327Reviewed-by:
-
Juanmi Huertas authored
When we transferToImageBitmap and we do a flush in the Snapshot, it can be that the skImage was null due to some issue. We are adding a new check to ensure that we are not returning a null skImage contained in a valid imagebitmap. Bug: 980057 Change-Id: I91e6b1688ec54b6029bcdd051db3d045421786cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1811157Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Commit-Queue: Juanmi Huertas <juanmihd@chromium.org> Cr-Commit-Position: refs/heads/master@{#697787}
-
Yuly Novikov authored
Since they currently run the same OS version as the Release bots. TBR=kbr Bug: 1005378 Change-Id: I20fc3b846c4e1622a48207aca732cc539d1d607d No-try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809991 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Reviewed-by:
-
danakj authored
Make Init() private, add an InitForPepperFullscreen() and InitForMainFrame() that RenderWidgetFullscreenPepper and RenderViewImpl and RenderFrameImpl make use of. Now every callsite declares its intentions. Remove comments about RenderWidget being self-referencing, it is not ref counted any longer. Use render_widget_ instead of GetWidget() in RenderViewImpl. It is the same thing but it makes code more clear about where it is ending up. Especially interesting is the lines: RenderWidget* closing_widget = render_widget_.get(); closing_widget->Close(std::move(render_widget_)); Some cleanups in the RenderWidgetFullscreenPepper code around construction and use of the new RenderWidget Init api. And also in RenderFrameImpl. R=avi@chromium.org Bug: 419087 Change-Id: Ifa1bc6b63d57b557ea14a21cb45e5b42cb903df2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1811519 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#697785}
-
Stephen Martinis authored
This fix seems to have worked for //build/config/ios/codesign.py. Try applying this fix to plist_util.py. See bug for more details. Bug: 1005190 Change-Id: I0858a521ae5027f9d2c09a25f32961490dcd9eb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809893Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Auto-Submit: Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#697784}
-
John Abd-El-Malek authored
Change-Id: Ifa1b255302e05ca9ee01fdce39e707d6af2deb4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1811965 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org> Auto-Submit: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#697783}
-
Andrew Grieve authored
Bug: 1000763, 1005230 Change-Id: Iec51aec1348b96c156cb4689b06c26e445cf3b20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1811644 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Commit-Queue: Eric Stevenson <estevenson@chromium.org> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#697782}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/cbc960899a68..6a17fd7fb73b git log cbc960899a68..6a17fd7fb73b --date=short --no-merges --format='%ad %ae %s' 2019-09-18 rmhasan@google.com [Typ] Raise ValueError from setters when tag validation is enabled Created with: gclient setdep -r src/third_party/catapult@6a17fd7fb73b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC skyostil@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=skyostil@google.com Bug: chromium:999335 Change-Id: I5a31a873eaff7535e17aa8a88f7d90beaa2ae3e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1811558Reviewed-by:
-
