GitLab

Before this patch, passing duplicate shipping option identifiers into
web payments API was silently treated as an indicator of invalid
shipping address. This matches the spec, but the web developer may be
confused.

The fix is to add a warning message in console:
  "Duplicate shipping option identifier '<id>' is treated as an invalid
  address indicator."

Spec:
https://w3c.github.io/browser-payment-api/#constructor
(See step 8, "Process shipping options.")

BUG=711677

Review-Url: https://codereview.chromium.org/2830683002
Cr-Commit-Position: refs/heads/master@{#465751}

https://codereview.chromium.org/2771793003 moved the the timer for downloading
an icon from webapk_installer.cc to webapk_icon_hasher.cc The CL did not
provide a way of making the timeout shorter similar to
WebApkInstaller::SetTimeoutMs(). This was causing
WebApkInstallerTest.BestPrimaryIconUrlDownloadTimesOut and
WebApkInstallerTest.BestBadgeIconUrlDownloadTimesOut to take over a minute each.

This CL:
- Introduces a new static method
WebApkIconHasher::DownloadAndComputeMurmur2HashWithTimeout() which takes a
custom timeout.
- Removes the tests about the icon download timing out from
webapk_installer_unittest.cc since this scenario is already tested in
webapk_icon_hasher_unittest.cc

Review-Url: https://codereview.chromium.org/2822883002
Cr-Commit-Position: refs/heads/master@{#465750}

[CrOS Tether] Add tether network properties (battery percentage, carrier, and signal strength) to the Chrome OS networking stack.

This change is composed of several related parts:
(1) Update the chrome.networkingPrivate API to include tethering properties as part of NetworkProperties, ManagedNetworkProperties, and NetworkStateProperties.
(2) Add ONC properties for the new tethering properties.
(3) Add ONC validation for tether networks.
(4) Add "fake" Shill tethering properties (since tethering networks are really normal Wi-Fi networks, Shill does not actually ever use the properties).
(5) Add translation from Shill tethering properties to ONC tethering properties.
(6) Update the settings page's chrome.networkingPrivate.getNetworks() call site to handle tether networks properly.

BUG=672263
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2818593003
Cr-Commit-Position: refs/heads/master@{#465749}

Reland of Disable flaky WebNavigationApiTest.CrossProcessHistory. (patchset #1 id:1 of https://codereview.chromium.org/2830813002/ )

Reason for revert:
The flakiness came back upon landing this revert.

So, reverting the revert.

Original issue's description:
> Revert of Disable flaky WebNavigationApiTest.CrossProcessHistory. (patchset #1 id:1 of https://codereview.chromium.org/2790383002/ )
>
> Reason for revert:
> What I believe was the underlying issue has been reverted, so it should be safe to reenable this test back.
>
> Original issue's description:
> > Disable flaky WebNavigationApiTest.CrossProcessHistory.
> >
> > TBR=nasko@chromium.org
> > BUG=708139
> >
> > Review-Url: https://codereview.chromium.org/2790383002
> > Cr-Commit-Position: refs/heads/master@{#461690}
> > Committed: https://chromium.googlesource.com/chromium/src/+/656fccff69eae8da012f0f83bcd3fc89214c5258
>
> TBR=maxmorin@chromium.org
> # Not skipping CQ checks because original CL landed more than 1 days ago.
> BUG=708139
>
> Review-Url: https://codereview.chromium.org/2830813002
> Cr-Commit-Position: refs/heads/master@{#465709}
> Committed: https://chromium.googlesource.com/chromium/src/+/ccdcc6ef79a614b1b1c87a78a883d9c5b19ffde2

TBR=maxmorin@chromium.org,nasko@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=708139

Review-Url: https://codereview.chromium.org/2828903002
Cr-Commit-Position: refs/heads/master@{#465748}

When an ARIA grid or treegrid is used, pass that role through while still supporting the table interface. Essentially, the grid/treegrid roles can be understood as a subclass of a table role. Also do some cleanup for table/grid/treegrid handling.

BUG=532670

Review-Url: https://codereview.chromium.org/2825803002
Cr-Commit-Position: refs/heads/master@{#465747}

We've been painting them after text. This is incorrect per:

https://www.w3.org/TR/css-text-decor-3/#painting-order

BUG=547174
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2820743003
Cr-Commit-Position: refs/heads/master@{#465746}

content::Manifest::kInvalidOrMissingColor has a value which takes up more than
32 bits. This CL fixes truncation to 32 bits which was occurring in
webapk_update_manager.cc sizeof(long) = 4 sizeof(int64_t) = 8

BUG=711519

Review-Url: https://codereview.chromium.org/2822623002
Cr-Commit-Position: refs/heads/master@{#465745}

https://boringssl.googlesource.com/boringssl/+log/bc6a76b0e0ed252af1688423584f7cd9161f6dee..777fdd6443d5f01420b67137118febdf56a1c8e4

BUG=none

Review-Url: https://codereview.chromium.org/2829743002
Cr-Commit-Position: refs/heads/master@{#465744}

This removes most of the experiment flags and launches the "Update Chrome"
menu item. Command line flags were left testing and an experiment flag
was left for setting a custom summary in case there is a need in the
future.

BUG=712827

Review-Url: https://codereview.chromium.org/2825173002
Cr-Commit-Position: refs/heads/master@{#465743}

BUG=602666

Review-Url: https://codereview.chromium.org/2830733004
Cr-Commit-Position: refs/heads/master@{#465742}

When populating a resource request, before upgrading an insecure request
if appropriate, we now check report-only CSP headers, to ensure that
CSP report-only violations are reported before any modifications of the
request. After modifying the request, we check the enforced CSP headers to
ensure that the request is still allowed.

This is as described in the upgrade-insecure-requests spec:
https://w3c.github.io/webappsec-upgrade-insecure-requests/#reporting-upgrades

Patch stolen from mkwst@

BUG=625156
TEST=added web platform test upgrade-insecure-requests-reporting.https.html

Review-Url: https://codereview.chromium.org/2790693002
Cr-Commit-Position: refs/heads/master@{#465741}

Throwing an unchecked runtime.lastError results in an uncaught
exception, which can prevent future JS from properly running in
somewhat unpredictable ways. These errors should be logged as console
errors, rather than being thrown as exceptions.

Add tests to a) check errors being logged and b) check that chaining
API calls and callbacks works even when there are uncheked last errors.

BUG=653596

Review-Url: https://codereview.chromium.org/2819683002
Cr-Commit-Position: refs/heads/master@{#465740}

Now that blink lives in the src repo, there's no need to generate a
separate LASTCHANGE file for it.

The LASTCHANGE line makes it into the user agent. LASTCHANGE.blink
used --git-hash-only to only have the git hash in there.  Remove
that now-unused flag and use version.py's -e flag to get the same
effect for webkit_version.h

Reverts parts of https://chromiumcodereview.appspot.com/14973005/
No intended behavior change.

BUG=none

Review-Url: https://codereview.chromium.org/1982423002
Cr-Commit-Position: refs/heads/master@{#465739}

This reduces number of reads and reallocations if UrlRequest::Read has more data available.

Change QuicTestServer to return simple response without HTTP/2 trailers, so it doesn't break the QuicHttpStream.

BUG=706515
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:ios-simulator-cronet

Review-Url: https://codereview.chromium.org/2776583004
Cr-Commit-Position: refs/heads/master@{#465738}

This CL disables EG synchronization when dealing with the onload JS
dialog.

BUG=711291

Review-Url: https://codereview.chromium.org/2825673003
Cr-Commit-Position: refs/heads/master@{#465737}

Similar to functions, API events can be restricted on a per-context
basis. Apply the same deletion logic to them if they are unavailable
in the given context.

Modify APIBinding unittests to reflect this, and add more comprehensive
tests in NativeExtensionBindingsSystem to test APIs that can be
partially-available to websites.

BUG=653596

Review-Url: https://codereview.chromium.org/2821793003
Cr-Commit-Position: refs/heads/master@{#465736}

Move custom request handling from registering a method in the
APIBindingHooks to a delegate call to match CreateCustomEvent.
Add a APIBindingHooksTestDelegate for use in unittests to avoid having
a bunch of one-off subclasses.

BUG=653596

Review-Url: https://codereview.chromium.org/2831453002
Cr-Commit-Position: refs/heads/master@{#465735}

We have a file in extensions/ [1] that depends on Media Router mojo definitions
from chrome/browser/. To remove this dependency from extensions/ to
chrome/browser/, this CL moves that file to chrome/renderer/, and Media Router
mojo interfaces to chrome/common/media_router/mojo/. Media Router typemaps and
related C++ structs are also moved to chrome/common/media_router/.

[1] extensions/renderer/resources/media_router_bindings.js

BUG=704958

Review-Url: https://codereview.chromium.org/2771413003
Cr-Commit-Position: refs/heads/master@{#465734}

and correct the component.

BUG=none

Review-Url: https://codereview.chromium.org/2821623002
Cr-Commit-Position: refs/heads/master@{#465733}

Delay 100 ms before closing the window to give some time for
rendering jobs to be done.

BUG=649218
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2826753002
Cr-Commit-Position: refs/heads/master@{#465732}

The consumer ContentVerifyJob, calls this only once and ContentVerifier
is ref counted, so this is a good thing to do.

BUG=712945
Test=No visible changes expected.

Review-Url: https://codereview.chromium.org/2824333003
Cr-Commit-Position: refs/heads/master@{#465731}

This removes the duplicate functionality in DeviceClassManager.

BUG=

Review-Url: https://codereview.chromium.org/2826203003
Cr-Commit-Position: refs/heads/master@{#465730}

BUG=706324

Review-Url: https://codereview.chromium.org/2806123002
Cr-Commit-Position: refs/heads/master@{#465729}

In particular, it's a follow up to
https://chromium-review.googlesource.com/472192.

This CL is just to fix the bots. I will follow up with proper
changes to the allocator which will eliminate the need for the
blacklist entry.

BUG=713293

Review-Url: https://codereview.chromium.org/2834513002
Cr-Commit-Position: refs/heads/master@{#465728}

This CL lands part of server change 153489255.

BUG=488484

Review-Url: https://codereview.chromium.org/2829463002
Cr-Commit-Position: refs/heads/master@{#465727}

Revert of [Home] Close the BottomSheet when a URL is loaded on the NTP (patchset #1 id:1 of https://codereview.chromium.org/2829523002/ )

Reason for revert:
Broke Lollipop Tester

junit.framework.AssertionFailedError: Sheet should be at half height expected:<1> but was:<3>
	at org.chromium.chrome.browser.ntp.ChromeHomeNewTabPageTest.validateState(ChromeHomeNewTabPageTest.java:197)
	at org.chromium.chrome.browser.ntp.ChromeHomeNewTabPageTest.createNewTab(ChromeHomeNewTabPageTest.java:168)
	at org.chromium.chrome.browser.ntp.ChromeHomeNewTabPageTest.testCloseNTP_TwoTabs(ChromeHomeNewTabPageTest.java:92)
	at android.test.InstrumentationTestCase.runMethod(InstrumentationTestCase.java:214)
	at android.test.InstrumentationTestCase.runTest(InstrumentationTestCase.java:199)
	at android.test.ActivityInstrumentationTestCase2.runTest(ActivityInstrumentationTestCase2.java:192)
	at org.chromium.chrome.test.ChromeActivityTestCaseBase.runTest(ChromeActivityTestCaseBase.java:758)
	at org.chromium.base.test.BaseTestResult.runParameterized(BaseTestResult.java:161)
	at org.chromium.base.test.BaseTestResult.run(BaseTestResult.java:124)
	at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:191)
	at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:176)
	at android.test.InstrumentationTestRunner.onStart(InstrumentationTestRunner.java:555)
	at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1853)

Original issue's description:
> [Home] Close the BottomSheet when a URL is loaded on the NTP
>
> This ensures that a click on the doodle will close the BottomSheet.
>
> BUG=712607
>
> Review-Url: https://codereview.chromium.org/2829523002
> Cr-Commit-Position: refs/heads/master@{#465604}
> Committed: https://chromium.googlesource.com/chromium/src/+/2a80017ed38340c00d1d214a3a2445acf5a9ed05

TBR=mvanouwerkerk@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=712607

Review-Url: https://codereview.chromium.org/2830743003
Cr-Commit-Position: refs/heads/master@{#465726}

File writes happen on a file thread. This CL waits for the file thread to flush
writes to disk.

BUG=712307
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

Review-Url: https://codereview.chromium.org/2827673002
Cr-Commit-Position: refs/heads/master@{#465725}

BUG=500085

Review-Url: https://codereview.chromium.org/2824033003
Cr-Commit-Position: refs/heads/master@{#465724}

ffe4c1018c1b net: Update Blink source code references
e04194afd91d win: Wrap TerminateProcess() to accept cdecl patches on x86
74fddc3fed2a win: Wrap test::ChildLauncher::Start() in
             ASSERT_NO_FATAL_FAILURE()
f487da4ff2c4 win handler: Move test targets to handler_test.gyp

BUG=crashpad:179

Review-Url: https://codereview.chromium.org/2833533003
Cr-Commit-Position: refs/heads/master@{#465723}

BUG=713260
TBR=sullivan@chromium.org

Review-Url: https://codereview.chromium.org/2834503002
Cr-Commit-Position: refs/heads/master@{#465722}

Flakiness has expanded from just Windows and memory bots to Mac and
Linux as well.

Broadly disabling the test.

BUG=641400
TBR=michaelpg@chromium.org

Review-Url: https://codereview.chromium.org/2828063002
Cr-Commit-Position: refs/heads/master@{#465721}

The proposed fix is to notify the parent views when a child enables layering. The parent in
this case the ScrollView overrides the newly added notification OnChildLayerChanged() and enables
viewport layering. This ensures that the ring gets clipped.

Longer term it seems like the focus ring should really be a property of the view and should not
be instantiated by different controls all over the place.

That for a later patchset.

BUG=665412, 656198
TEST=Covered by test ViewObserverTest.ScrollViewChildAddLayerTest and ViewObserverTest.ChildViewLayerNotificationTest

Review-Url: https://codereview.chromium.org/2813353002
Cr-Commit-Position: refs/heads/master@{#465720}

BUG=713201
TBR=mkolom@yandex-team.ru, creis@chromium.org, sky@chromium.org, dgozman@chromium.org

Review-Url: https://codereview.chromium.org/2829773002
Cr-Commit-Position: refs/heads/master@{#465719}

https://chromium.googlesource.com/angle/angle.git/+log/b36e539..b812669

BUG=

TBR=geofflang@chromium.org

TEST=bots

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2832583002
Cr-Commit-Position: refs/heads/master@{#465718}

Retry request upon receiving a GOAWAY frame with error code NO_ERROR
and with Last-Stream-ID lower than stream id corresponding to request.

BUG=681477

Review-Url: https://codereview.chromium.org/2820163004
Cr-Commit-Position: refs/heads/master@{#465717}

This change finishes support for AX_ACTION_HIT_TEST in AXHostDelegate
so that you can send a hit test request on the root of the whole automation
tree and get a hit test on either views or web content.

Switches Select-to-speak to use this new API.  A follow-up change will
change the way select-to-speak works so that it sends the mouse event
to the extension and the hit test comes from there, but this is a
self-contained change that can land first.

BUG=699617

Review-Url: https://codereview.chromium.org/2813083003
Cr-Commit-Position: refs/heads/master@{#465716}

The three chrome help URL constants incorrectly used OFFICIAL_BUILD
for a feature that should only be in Google-branded builds.

BUG=none
TEST=Build browser with is_official_build=true and target_os=chromeos. Click the help button in the system menu, verify it shows a support.google.com URL instead of the genius app.

Review-Url: https://codereview.chromium.org/2825513002
Cr-Commit-Position: refs/heads/master@{#465715}

BUG=678663,703441

Review-Url: https://codereview.chromium.org/2819273005
Cr-Commit-Position: refs/heads/master@{#465714}

This reverts commit 1e2d5ea4.

BUG=705135

Reason: Bot came back online
Review-Url: https://codereview.chromium.org/2831693002
Cr-Commit-Position: refs/heads/master@{#465713}

BUG=712479

Review-Url: https://codereview.chromium.org/2825493005
Cr-Commit-Position: refs/heads/master@{#465712}