GitLab

BUG=105129
TEST=PanelTest.PanelOpenLarge should no longer run on Aura + chromeos


Review URL: http://codereview.chromium.org/8632013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113093 0039d316-1c4b-4281-b951-d872f2087c98

BUG=104396
TEST=more tests passes in interactive_ui_tests passes on aura


Review URL: http://codereview.chromium.org/8808001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113092 0039d316-1c4b-4281-b951-d872f2087c98

xinput1_3.dll is a Microsoft DirectX redist file. Unfortunately it's shipped
without /NXCOMPAT and /DYNAMICBASE.

This DLL is only be loaded when the user interacts with a gamepad.

BUG=79050

Review URL: http://codereview.chromium.org/8806020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113091 0039d316-1c4b-4281-b951-d872f2087c98

Add abstract GetGroupsToChange() method to ModelChangingSyncerCommand.
Use that to figure out which worker threads to post work on (instead of
posting on all of them).

Implement GetGroupsToChange() for each ModelChangingSyncerCommand.

Add GetEnabledGroups() and GetEnabledGroupsWithConflicts() functions to SyncSession.

Key unapplied updates index by type for ApplyUpdatesCommand.

Make the abstract methods of ModelChangingSyncerCommand protected.

Add HasCustomGroupsToChange() method to ModelChangingSyncerCommand and have all
commands default to returning false to track down the perf regression introduced
by the last couple of times this was landed (112178, 112815).

BUG=97832
TEST=

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112178

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112743

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112815

Review URL: http://codereview.chromium.org/8637006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113090 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113089 0039d316-1c4b-4281-b951-d872f2087c98

1) Wait for extension popup to load
2) Wait for extensions hosts to load in WaitForAllViews
3) Allow more than one browser action to be visible in views.
4) Add explicit IsPageActionVisible method
BUG=93571
TEST=none

Review URL: http://codereview.chromium.org/8804011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113088 0039d316-1c4b-4281-b951-d872f2087c98

BUG=106229
TEST=Ran without my change and saw that the avatar icon would not change. Applied my fix and verified that the avatar icon changed.

Review URL: http://codereview.chromium.org/8796003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113087 0039d316-1c4b-4281-b951-d872f2087c98

- Refactoring and bug fixes 
- Remove global variables of class type.

NOTE: I'm landing this for Ronghua since he's on leave.  The change has already been reviewed here: http://codereview.chromium.org/8790011/
but I had to create a new issue in order to resolve merge conflicts.



TBR=sergeyu

Review URL: http://codereview.chromium.org/8802019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113086 0039d316-1c4b-4281-b951-d872f2087c98

used except in tests.

Review URL: http://codereview.chromium.org/8567011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113085 0039d316-1c4b-4281-b951-d872f2087c98

BUG=101214


Review URL: http://codereview.chromium.org/8697006

TBR=rdsmith@chromium.org
Review URL: http://codereview.chromium.org/8817005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113084 0039d316-1c4b-4281-b951-d872f2087c98

Revert 113075 (requested by asvitkine) (requested by asvitkine) (requested by asvitkine) (requested by asvitkine) (requested by asvitkine) (requested by asvitkine) (requested by asvitkine) (requested by asvitkine) (requested by asvitkine) - Improve RenderTextWin font fallback.

Don't use SCRIPT_UNDEFINED in the case of font fallback,
unless font fallback actually fails to return a script
that can display the characters. This fixes the problem
of some scripts not being properly displayed.

This actually makes RenderTextWin properly validate whether
a text position accepts a cursor, which caused several tests
to fail and revealed some additional issues in RenderTextWin.

The CL includes some modifications to address this.

Some tests are disabled under XP, see:
http://crbug.com/106450

Also, fixes some lint warnings.

BUG=90426
TEST=Run chrome.exe --use-pure-views and paste some Bengali
text into the omnibox. It should show up properly.

Review URL: http://codereview.chromium.org/8575020

TBR=asvitkine@chromium.org
Review URL: http://codereview.chromium.org/8819001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113083 0039d316-1c4b-4281-b951-d872f2087c98

r113078 was done with "drover --revert 113074".
It failed to restore one of the removed files.

TBR=mpcomplete@chromium.org

BUG= none
TEST= none

Review URL: http://codereview.chromium.org/8803030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113081 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113079 0039d316-1c4b-4281-b951-d872f2087c98

These sources have been moved over to the native_client repository.
Remove them from chromium/src altogether and just make the gyp files
refer to the native_client stuff.

BUG= none
TEST= linux still builds

R=sehr@google.com,noelallen@chromium.org

Review URL: http://codereview.chromium.org/8799016

TBR=mcgrathr@chromium.org
Review URL: http://codereview.chromium.org/8811002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113078 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113077 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/8733008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113076 0039d316-1c4b-4281-b951-d872f2087c98

Don't use SCRIPT_UNDEFINED in the case of font fallback,
unless font fallback actually fails to return a script
that can display the characters. This fixes the problem
of some scripts not being properly displayed.

This actually makes RenderTextWin properly validate whether
a text position accepts a cursor, which caused several tests
to fail and revealed some additional issues in RenderTextWin.

The CL includes some modifications to address this.

Some tests are disabled under XP, see:
http://crbug.com/106450

Also, fixes some lint warnings.

BUG=90426
TEST=Run chrome.exe --use-pure-views and paste some Bengali
text into the omnibox. It should show up properly.

Review URL: http://codereview.chromium.org/8575020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113075 0039d316-1c4b-4281-b951-d872f2087c98

These sources have been moved over to the native_client repository.
Remove them from chromium/src altogether and just make the gyp files
refer to the native_client stuff.

BUG= none
TEST= linux still builds

R=sehr@google.com,noelallen@chromium.org

Review URL: http://codereview.chromium.org/8799016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113074 0039d316-1c4b-4281-b951-d872f2087c98

Re-landing r113010 with clang style fixes.

R=tony@chromium.org

Review URL: http://codereview.chromium.org/8805027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113073 0039d316-1c4b-4281-b951-d872f2087c98

BUG=102144
TEST=NONE


Review URL: http://codereview.chromium.org/8763007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113072 0039d316-1c4b-4281-b951-d872f2087c98

It broke ExtensionManagementApiBrowserTest.LaunchApp.

Make ExtensionSet iterate like a set instead of a map.

BUG=104091
TEST=existing tests

Review URL: http://codereview.chromium.org/8733004

TBR=yoz@chromium.org
Review URL: http://codereview.chromium.org/8789018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113071 0039d316-1c4b-4281-b951-d872f2087c98

BUG=105028
TEST=none


Review URL: http://codereview.chromium.org/8801012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113070 0039d316-1c4b-4281-b951-d872f2087c98

Changed some API names. Wrapped existing UDPClientSocket. Added one unit test for controller. The socket API itself isn't tested for two reasons: (1) this is an interim checkin, where Part 2 will add UDP receiving, and that will likely involve some API changes, so I didn't bother constructing a whole extension built on a temporary API; and (2) the wrapper itself is so thin around the existing UDPClientSocket API that a unit test of the wrapper wouldn't accomplish much.

BUG=none
TEST=see above.


Review URL: http://codereview.chromium.org/8743017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113069 0039d316-1c4b-4281-b951-d872f2087c98

If an extension A tries to redirect a request to http://foo and an extension B tries to redirect a request to data://..., we consider the redirect of extension B as an attempt to cancel the request. As cancelling a request is considered to take precedence over redirects, this does not generate a conflict message any more.


BUG=106431
TEST=no


Review URL: http://codereview.chromium.org/8802017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113068 0039d316-1c4b-4281-b951-d872f2087c98

BUG=106481
TEST=Manual

Review URL: http://codereview.chromium.org/8801033

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113067 0039d316-1c4b-4281-b951-d872f2087c98

Some of this code is based on Cory Maccarrone's html terminal, developed
internally in Google as part of a different project.  Thanks to Cory for
allowing us to repurpose it here!

This gets us to a point where we have the core classes largely fleshed out.  The code passes 45 tests, mostly related to correct handling of vt100 escape sequences.

Still to come: network connectivity, keyboard input, and text attributes!

BUG=chromium-os:23271
TEST=test_harness.html:45/45 tests passed.


Review URL: http://codereview.chromium.org/8680034

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113066 0039d316-1c4b-4281-b951-d872f2087c98

Also fixes a leak that was accidentally introduced in http://src.chromium.org/viewvc/chrome?view=rev&revision=113018.

BUG=31037,106472
TEST=manual testing

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113040

Review URL: http://codereview.chromium.org/8802004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113064 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
NOTRY=true

Review URL: http://codereview.chromium.org/8812001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113063 0039d316-1c4b-4281-b951-d872f2087c98

Don't move the cursor back to the center of the view unless it approaches the border.

BUG=106054
TEST=None


Review URL: http://codereview.chromium.org/8791001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113061 0039d316-1c4b-4281-b951-d872f2087c98

(and other disposition modifiers)

BUG=7678
TEST=trybots

Review URL: http://codereview.chromium.org/8662051

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113059 0039d316-1c4b-4281-b951-d872f2087c98

- Remove the CWS service and token generation for that.
- Remove StartFetchingMissingTokens method
- Remove unit test for removed code.
Review URL: http://codereview.chromium.org/8769053

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113058 0039d316-1c4b-4281-b951-d872f2087c98

Also clean up some unnecessary complexity in history HTML, and
move history-specific CSS from old_webui.css to history.css.

BUG=None.
TEST=Manual test of functionality on history and downloads pages.

Review URL: http://codereview.chromium.org/8772046

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113056 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/8805016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113054 0039d316-1c4b-4281-b951-d872f2087c98

1) Moving mouse to left screen edge causes the expanded overflow panels to shrink back.
2) Overflow panel is brought to normal area cannot be dragged correctly.

BUG=106434
TEST=Enable overflow test plus manual test by moving mouse to left screen edge or clicking on overflow panel

Review URL: http://codereview.chromium.org/8802021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113053 0039d316-1c4b-4281-b951-d872f2087c98

next_proto to net-internals log.

In net internal logs, we will log proto in the following
manner:

(P) t=1323112212350 [st=463]     
    HTTP_STREAM_REQUEST_PROTO             
        --> next_proto_status = "negotiated"
        --> proto = "spdy/2"                
        --> server_protos = "spdy/2,http/1.1"

BUG=62064
TEST=network unit tests
R=willchan

The following was the original CL:
http://codereview.chromium.org/8676046/
Review URL: http://codereview.chromium.org/8787011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113052 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:23476
TBR=kmixter@chromium.org
Review URL: http://codereview.chromium.org/8806027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113051 0039d316-1c4b-4281-b951-d872f2087c98

Make TestTabContents::TestDidNavigate not take a ViewHostMsg_FrameNavigate_Params, since that's an internal content IPC struct.

BUG=98716
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113006
Review URL: http://codereview.chromium.org/8801003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113050 0039d316-1c4b-4281-b951-d872f2087c98

Turn on flag to check cookies when updating NTP Promo.
Review URL: http://codereview.chromium.org/8772063

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113049 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/8803026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113048 0039d316-1c4b-4281-b951-d872f2087c98

Make ExtensionSet iterate like a set instead of a map.

BUG=104091
TEST=existing tests

Review URL: http://codereview.chromium.org/8733004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113047 0039d316-1c4b-4281-b951-d872f2087c98