- 17 Jul, 2020 40 commits
-
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8428d2664eb5..c648f63ca9e2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC mkwst@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: mkwst@google.com Change-Id: I6413a81c969892e5855ddc88e2f581cf0292fd2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304364Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#789424}
-
David Roger authored
This CL adds strings and buttons to the signin interception WebUI bubble Screenshot with this CL: https://drive.google.com/file/d/1dpWiA-o3ktL5eRaYqMt2kMd2h7IC09t_/view?usp=sharing Mock: https://drive.google.com/file/d/134DKn6B_QIX2rJ91kSWS4zpRpm3XUmy5/view?usp=sharing Bug: 1076880 Change-Id: Ib0d4d2e3768bf2cbcb92beb335de8e87cd6f8c9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279751 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#789423}
-
Sigurd Schneider authored
Change-Id: Iee09385689779f70903de9c998639f115f4b9ce7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302171 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#789422}
-
Carlos Caballero authored
Get rid of all references to MessageLoopCurrent(ForIO|ForUI) This is a mechanical change. Just ran the following commands mffr.py base/message_loop/message_loop_current base/task/current_thread mffr.py -f MessageLoopCurrentForUI CurrentUIThread mffr.py -f MessageLoopCurrentForIO CurrentIOThread mffr.py -f MessageLoopCurrent CurrentThread rm base/message_loop/message_loop_current.h This patch will be reviewed according to https://chromium.googlesource.com/chromium/src/+/master/docs/code_reviews.md#mechanical-changes TBR=gab@chromium.org Bug: 891670 Change-Id: If3892558ad71333f93a4698ac5411f141ccd5657 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279990 Commit-Queue: Carlos Caballero <carlscab@google.com> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#789421}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/b8c03e40673f..13fbc08b938e 2020-07-17 dharmesh.r.chauhan@gmail.com Explicitly set presentation style to full screen, because, If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Iacf4b7f4e444c400f4942d520db29bba39d2458e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304368Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#789420}
-
Makoto Shimazu authored
Bug: 1092515 Change-Id: Iafa16e996334b01a5b7048f2905a263ec3180fc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2301709 Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#789419}
-
dizg authored
Added profile_creation_flow/BUILD.gn, updated profile_picker/BUILD.gn, added profile_type_choice.html and added this file to the profile_picker_resources.grd as include. R=droger@chromium.org, msalama@chromium.org, rbpotter@chromium.org Bug: 1105865 Change-Id: I778223d1f7f576502e02c7fba4d20be805537c05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300109 Commit-Queue: Diana Zagidullina <dizg@google.com> Reviewed-by:
Monica Basta <msalama@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#789418}
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: Iabcfdc536849d91574a6438f7bd7d3a6625a69f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304529Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#789417}
-
Eugene But authored
This is a follow up to: https://chromium-review.googlesource.com/c/chromium/src/+/2300834/1/ios/chrome/browser/ui/download/download_manager_coordinator_unittest.mm#708 CL updates comments which explain the reason for wrapping certain code into @autorelease block. Bug: None Change-Id: Ie31e5701f81d6f3fdd8d5347e81441732c1afa75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303033 Auto-Submit: Eugene But <eugenebut@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#789416}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/e8e089ad282e..450b6f4f844d 2020-07-17 cwallez@chromium.org Use MapAsync callback for server->client map callbacks. 2020-07-17 enga@chromium.org Vulkan: Fix MemoryServiceZirconHandle CreateImage 2020-07-17 enga@chromium.org D3D12: Bucket descriptor allocation by powers of two If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I4c74fe221aaa09a2b25b43e54385b16e5c3cceb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304367Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/7221ccf85e26..680c77fa6c81 2020-07-16 vasniktel@gmail.com spirv-fuzz: Add support for OpBitcast to TransformationEquationInstruction (#3523) 2020-07-16 vasniktel@gmail.com spirv-fuzz: Add support for OpConvert to TransformationEquationInstruction (#3472) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Tbr: radial-bots+chrome-roll@google.com,jonahr@google.com Change-Id: I62a78468303abdacfb993aac5d0d2549e3aa60e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304363Reviewed-by:
-
Eliot Courtney authored
This increases performance for linux chrome on chromeos, when linux chrome is displayed in a hardware overlay. See crrev.com/c/2286093 for details. Bug: 1062529 Test: Run linux chrome on chromeos Test: run ozone linux chrome on Weston, software and hw accel Change-Id: Id601e301797067be410a52c4afbb499ab9706ab3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288717 Commit-Queue: Eliot Courtney <edcourtney@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Cr-Commit-Position: refs/heads/master@{#789413}
-
Antonio Sartori authored
The Content-Security-Policy parser in services/network was silently ignoring all parsing errors. This is not an issue, since CSPs are being parsed again in blink, where errors are reported to the console. However, after we bring CSPEE out-of-blink, the frame csp attribute will not be parsed in blink anymore, so we will need validation from the network CSP parser. This change implements it. Bug: 1094909 Change-Id: I38e572900afcc9a4e55148e206690a16345cd99a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279976Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Antonio Sartori <antoniosartori@chromium.org> Cr-Commit-Position: refs/heads/master@{#789412}
-
Fredrik Söderqvist authored
The test virtual/threaded-no-composited-antialiasing/animations/svg-attribute-interpolation/svg-d-interpolation.html has not flaked after fixes were made. Tbr: pdr@chromium.org Fixed: 1099657 Change-Id: I08d7ee25f0192bb05c73e3e0ba2c35e6638d7215 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303434Reviewed-by:
Fredrik Söderquist <fs@opera.com> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#789411}
-
Wojciech Dzierżanowski authored
Replace active_audio_players_, active_video_players_ with a PlayerInfo map keyed by MediaPlayerId. This is easier to manage. The next steps will add more fields to PlayerInfo. Bug: 1091203 Change-Id: Iee2b54f810bec3ecad5e57eb8c840bd649b43ae8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283216 Commit-Queue: Wojciech Dzierżanowski <wdzierzanowski@opera.com> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#789410}
-
Yifan Luo authored
Add a new event listener `beforecreatepolicy` to TrustedTypePolicyFactory::createPolicy which allow people to track or block the creation process for Trusted Types. Bug: 1075601 Change-Id: Ib885e7adc740999ba0e39037b7f4a90af6ff6aef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260594 Commit-Queue: Yifan Luo <lyf@chromium.org> Reviewed-by:
Daniel Vogelheim <vogelheim@chromium.org> Reviewed-by:
-
Jan Wilken Dörrie authored
This change enables Touch To Fill by default. TTF will be launched in M84, so this change also cleans up experimentation code and removes branding messages, which will no longer be needed. TBR=koerber@google.com Bug: 957532 Change-Id: Ia37863b7562b5b7d5578be4c7f90367fd089ae2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300440Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#789408}
-
Nigel Tao authored
This creates a common place for current and future use_wuffs_xxx_parser GN args. Change-Id: I8e08522cab23a7bded2206f04cda916cca450b82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299688Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Nigel Tao <nigeltao@chromium.org> Cr-Commit-Position: refs/heads/master@{#789407}
-
Chih-Hsuan Kuo authored
On Chromecast, the media renderer should be CastRenderer. So, when CastRenderer is enabled, Receiver, the remoting renderer, should be able to use CastRenderer to play remoting media. Bug: 1097701 Test: Tested on Chromecast Change-Id: Ief7774cf25832e373428f324985364b671ef920d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2256923Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Commit-Queue: Chih-Hsuan Kuo <chkuo@google.com> Auto-Submit: Chih-Hsuan Kuo <chkuo@google.com> Cr-Commit-Position: refs/heads/master@{#789406}
-
Kuo Jen Wei authored
To add sound effect to pause/resume UI, new 'recording-ui-paused' state is introduced to control the UI transition. Bug: 1072706 Test: Run "tast run 'camera.CCAUIRecordVideo'", check if sound effect is applied. Change-Id: I7e6305e302cea55a14a1174b484a5dc24b06fabf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2296548Reviewed-by:
Wei Lee <wtlee@chromium.org> Commit-Queue: Kuo Jen Wei <inker@chromium.org> Auto-Submit: Kuo Jen Wei <inker@chromium.org> Cr-Commit-Position: refs/heads/master@{#789405}
-
Alex Rudenko authored
According to the crash report, the owner document could be a nullptr. This CL adds a check if an owner document is available and sets the execution_context to nullptr if it's not available. CSSStyleDeclaration::setCSSText that receives the execution context can handle nullptr values. Fixed: 1090899 Change-Id: I2e0b1a56e6b25e98c043f576dbd230f50c062516 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300382Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Mathias Bynens <mathias@chromium.org> Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Alex Rudenko <alexrudenko@chromium.org> Cr-Commit-Position: refs/heads/master@{#789404}
-
Wolfgang Beyer authored
Relevant DevTools CL: https://crrev.com/c/2297420 Bug: https://crbug.com/1101262 Change-Id: I0ff6f03b1946f2d24da995107e4d5eb774a332b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299622 Commit-Queue: Wolfgang Beyer <wolfi@chromium.org> Reviewed-by:
-
Mike Dougherty authored
Using the EarlGrey or XCUITest helpers to type do not trigger software keyboard pressed which are needed in order to dismiss the popover in this test. Replace grey_typeText with grey_tap on an arbitrary keyboard key to dismiss the credit card popover. Fixed: 1099432 Change-Id: If23c886437b264893700b943b86039f9a31a8f5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303046 Auto-Submit: Mike Dougherty <michaeldo@chromium.org> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#789402}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/0c5f244817c2..b8c03e40673f 2020-07-17 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision d8502113..b8a4405e (789218:789356) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I30a52cb72a3a2afb617ed15456f4502bb45cfe3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304360Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1594943787-51a385cad6026d977d7d0e8c786de56f21cce493.profdata to chrome-mac-master-1594963977-810cedbe35bd1c6db444ce1374d5ffa7453d77c9.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: Ie1ca35034d1af5b278afce031e33b61fa54bd0c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304355Reviewed-by:
-
Oleh Lamzin authored
Respect FrameSrc directive in WebUI, otherwise WebUIs use wider ChildSrc CSP to be able to embed iframes. In many places we are using 'frame-src' CSP with ChildSrc directive which is wrong. We have to either use 'frame-src' with FrameSrc or 'child-src' with ChildSrc. Mostly we just need to be able to embed iframe and do not need web workers, so 'frame-src' will be enough. Bug: 1105408 Change-Id: I6d7bd555f6411971db24fdfe9e3f299bf83a8a0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302990Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Commit-Queue: Oleh Lamzin <lamzin@google.com> Cr-Commit-Position: refs/heads/master@{#789399}
-
Mike West authored
This test is quite flaky[1] as far back as the dashboard lets me see, with no discernable cause. [1]: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=TranslateManagerWithMainFrameLanguageDetectionBrowserTest.TranslateIframe&testType=browser_tests TBR: groby@chromium.org Bug: 1106446 Change-Id: Ib9f420e5c844575460c028f2aba94ea9f0b0d180 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303433Reviewed-by:
-
Viktor Semeniuk authored
This change displays number of compromised credentials in the Passwords screen using plural string. Bug: 1075494 Change-Id: Ic155353280f2f40834fef78e26a1d4b12a6477a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2301142Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Viktor Semeniuk <vsemeniuk@google.com> Cr-Commit-Position: refs/heads/master@{#789397}
-
Frank Liberato authored
In addition to that, this CL also allows Status(kOk), so that return StatusCode::kOk; and return OkStatus(); are equivalent. Previously, the former reported !is_ok(). Bug: 1043289 Change-Id: I59d1b57dfde82f87b69a30a951a3c8f9c9f4aaed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288838Reviewed-by:
Ted Meyer <tmathmeyer@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Commit-Queue: Ted Meyer <tmathmeyer@chromium.org> Commit-Queue: Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#789396}
-
Anand K Mistry authored
DictionaryValue::RemoveWithoutPathExpansion() is deprecated. For the case where nullptr is passed for the output argument, Value::RemoveKey() is a trivial replacement. Mostly done with the following command line, plus a bit of finesse: % git grep -l RemoveWithoutPathExpansion | \ xargs sed -E -i 's/RemoveWithoutPathExpansion\((.*), nullptr/RemoveKey\(\1/g' Bug: 646113 This CL was uploaded by git cl split. R=apotapchuk@chromium.org Change-Id: I3ab03d08aae2f344e9a59057b5e3a70cb82cb6d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298839 Auto-Submit: Anand K Mistry <amistry@chromium.org> Reviewed-by:
Anatoliy Potapchuk <apotapchuk@chromium.org> Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org> Cr-Commit-Position: refs/heads/master@{#789395}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/832dab01db1d..4cbb6ef49709 2020-07-17 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: If27ad984838287eaa453a01fcf4d8bcd47186e4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304351Reviewed-by:
-
Ella Ge authored
This CL makes the DecidePermission check if it is possible to get a InstalledWebappGeolocationContext instead of checking the InstalledWebappBridge::ShouldDelegateLocationPermission GetInstalledWebappGeolocationContext() returns nullptr when either not running in TWA mode or should not delegate geolocation to it. It's mostly the same logic as the one in InstalledWebappBridge, except checking the current customtabsactivity instead of the LastTrackedFocusedTwaCustomTabActivity. so it's better using this one. Bug: 1106391 Change-Id: If66b10b44d71d30358088c00245c315be5c15829 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303049Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#789393}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/587380c5809d..8428d2664eb5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC patricialor@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: patricialor@google.com Change-Id: Ia750b6b2c186376c98299eda533e21a7e264e317 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304373Reviewed-by:
-
Mike West authored
This reverts commit b5bdc990. Reason for revert: `MediaRouterViewsUITest.RouteCreationTimeoutForDesktop` started failing after this CL in https://ci.chromium.org/p/chromium/builders/ci/Mac10.15%20Tests/2446?blamelist=1#blamelist-tab. The error message in the related test is https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8874579294717582880/+/steps/unit_tests_on_Mac-10.15/0/logs/Deterministic_failure:_MediaRouterViewsUITest.RouteCreationTimeoutForDesktop__status_CRASH_/0: ``` Actual function call count doesn't match EXPECT_CALL(*mock_router_, CreateRouteInternal( _, _, _, _, _, base::TimeDelta::FromSeconds(timeout_seconds), false))... Expected: to be called once Actual: never called - unsatisfied and active Stack trace: 0 unit_tests 0x000000010fcfba8c testing::internal::GoogleTestFailureReporter::ReportFailure(testing::internal::FailureReporterInterface::FailureType, char const*, int, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&) + 92 1 unit_tests 0x000000010fcffc05 testing::internal::UntypedFunctionMockerBase::VerifyAndClearExpectationsLocked() + 597 2 unit_tests 0x000000010fd00521 testing::Mock::VerifyAndClearExpectationsLocked(void*) + 401 3 unit_tests 0x000000010fd00371 testing::Mock::VerifyAndClearExpectations(void*) + 33 4 unit_tests 0x000000010f26566b media_router::MediaRouterViewsUITest::StartCastingAndExpectTimeout(media_router::MediaCastMode, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, int) + 2491 5 unit_tests 0x000000010f2659a4 media_router::MediaRouterViewsUITest_RouteCreationTimeoutForDesktop_Test::TestBody() + 52 Received signal 11 SEGV_MAPERR 000000000008 [0x000114431eb9] [0x000114377dc3] [0x000114431dd1] [0x7fff70e295fd] [0x7fff70de9297] [0x00010f2659a4] [0x00010fd1860d] [0x00010fd193cf] [0x00010fd19d47] [0x00010fd283a7] [0x00010fd27e1f] [0x00011384b7fb] [0x0001138623b3] [0x00011386225f] [0x000113835f25] [0x7fff70c30cc9] [end of stack trace] ``` Bug: 1106647 Original change's description: > [MediaRouter] Add warning for invalid permissions > > This patch adds a new check to the media router views UI that, on Mac OS > X 10.15+ (Catalina), checks if the screen capture permission has been > granted, and shows a warning message and fails to cast if so. > > Bug: 1087236 > Change-Id: I3afdfdb06a011fee3e6fd5f199d375d0ab6eef88 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298479 > Commit-Queue: Jordan Bayles <jophba@chromium.org> > Reviewed-by: Takumi Fujimoto <takumif@chromium.org> > Cr-Commit-Position: refs/heads/master@{#789194} TBR=mfoltz@chromium.org,takumif@chromium.org,jophba@chromium.org Change-Id: I64651c90503bf90a2f9cfca99f7929efd35b4c23 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1087236 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302613Reviewed-by:
-
Corentin Wallez authored
Use the concept of "permissions" and "allowed paths" that make the code clearer as well as more inclusive. Bug: chromium:1101491 Change-Id: I374bc95250a97efbd3190d22c82261a6c31a03af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302195Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#789390}
-
Adam Rice authored
The transferable streams implementation assumed that two kPull messages couldn't be sent without an intervening chunk. This wasn't true in the case of a compromised renderer, and since https://chromium-review.googlesource.com/c/chromium/src/+/2291180 hasn't been true in general. This change aligns the implementation with the proposed standard at https://chromium-review.googlesource.com/c/chromium/src/+/2291180. This fixes flakiness in the http/tests/streams/transferable/worker.html test. BUG=1106239,1106239 Change-Id: I12c9d011c4a42c8178fcaffa4ddd23e38fb82d9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303329Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#789389}
-
Zufeng Wang authored
CIPD package: https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/help_app/app/+/vqT-WqhwS504vwcLdBC9Y998VXTrAydEbVVHCjdZSPMC Release notes: http://go/help_app-x20/relnotes/Nightly/help_app_nightly_202007160800_RC00.html Cq-Include-Trybots: chrome/try:linux-chromeos-chrome Change-Id: Iaa9b1d2fae90f6118a7c79ba45192441ea066f55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303335Reviewed-by:
Rachel Carpenter <carpenterr@chromium.org> Commit-Queue: Zufeng Wang <zufeng@google.com> Cr-Commit-Position: refs/heads/master@{#789388}
-
Joanmarie Diggs authored
This is a reland of a6bb85c6, which had been reverted due to a unit test failure. The new failure turned out to be a side effect of how the test runner bundles tests and addressed via 0144ebea. This reland includes additional improvements: Treating all style changes on containers with selectable children the same as we do for kListBox, and adding a sanity check for style changes coming from detached objects. Bug: 904977, 1062063, 1085481 AX-Relnotes: Windows and Linux assistive technologies are now notified when text attributes have been changed. This allows them to update any cached information they may have so as not to present stale/inaccurate data about text appearance. In addition, because a notification is emitted when a newly-typed word has a spelling or grammar error, the Orca screen reader now announces when the error indicator appears. Original change's description: > Emit accessible text-attribute-changed events > > * Add TEXT_ATTRIBUTE_CHANGED event so platforms can distinguish this > event from the more generic OTHER_ATTRIBUTE_CHANGED event that was > being fired. > > * Fire TEXT_ATTRIBUTE_CHANGED from the AXEventGenerator for: > - kBackgroundColor > - kColor > - kFontFamily > - kFontSize > - kFontWeight > - kMarkerTypes (e.g. for spelling and grammar errors) > - kTextDirection > - kTextPosition > - kTextStyle > - kTextOverlineStyle > - kTextStrikethroughStyle > - kTextUnderlineStyle > > * Fire state-change event for ATK when ATK_STATE_ENABLED changes. > (Detected as a side effect of debugging an issue with the above) > > * Eliminate some extraneous accessibility events resulting from the > ignored state being changed on an element. > > Bug: 904977, 1062063, 1085481 > > AX-Relnotes: > > Windows and Linux assistive technologies are now notified when text > attributes have been changed. This allows them to update any cached > information they may have so as not to present stale/inaccurate data > about text appearance. > > In addition, because a notification is emitted when a newly-typed word > has a spelling or grammar error, the Orca screen reader now announces > when the error indicator appears. > > Change-Id: I6a070154304f185dcd6343baadb728b0a4beec35 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211224 > Reviewed-by: Kurt Catti-Schmidt <kschmi@microsoft.com> > Reviewed-by: Benjamin Beaudry <benjamin.beaudry@microsoft.com> > Reviewed-by: Javier Fernandez <jfernandez@igalia.com> > Reviewed-by: Nektarios Paisios <nektar@chromium.org> > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> > Commit-Queue: Joanmarie Diggs <jdiggs@igalia.com> > Cr-Commit-Position: refs/heads/master@{#778437} Change-Id: I776b86bbb7b691f42d0d2be01f6bd6877009c4ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279799Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Javier Fernandez <jfernandez@igalia.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Commit-Queue: Joanmarie Diggs <jdiggs@igalia.com> Cr-Commit-Position: refs/heads/master@{#789387}
-
Mike West authored
This reverts commit 3d677a19. Reason for revert: `linux-chromeos-dbg` began failing in https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-dbg/19625, with errors along the lines of https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8874588910239798816/+/steps/browser_tests/0/logs/Deterministic_failure:_CrElementsFingerprintProgressArcV3Test.Fingerprint__status_CRASH_/0: ``` [9471:9471:0716/140802.869423:FATAL:dedicated_worker_host_factory.mojom.cc(574)] Check failed: !connected. DedicatedWorkerHostFactory::CreateWorkerHostCallback was destroyed without first either being run or its corresponding binding being closed. It is an error to drop response callbacks which still correspond to an open interface pipe. #0 0x7f0d6306d98f base::debug::CollectStackTrace() #1 0x7f0d62e1600d base::debug::StackTrace::StackTrace() #2 0x7f0d62e15fc8 base::debug::StackTrace::StackTrace() #3 0x7f0d62e5751b logging::LogMessage::~LogMessage() #4 0x7f0d62e57dfc logging::LogMessage::~LogMessage() #5 0x7f0d62dddf4e logging::CheckError::~CheckError() #6 0x7f0d5b24076d blink::mojom::DedicatedWorkerHostFactory_CreateWorkerHost_ProxyToResponder::OnIsConnectedComplete() ... ``` This CL is the most suspicious in the range. Reverting to see if the bot recovers. Original change's description: > Introduce DedicatedWorkerToken. > > Subsequent CLs will migrate Shared and Service workers to use similar > tokens. This is in support of the performance.measureMemory API, endowing > workers with tokens that can be used as an identifier when communicating > information regarding V8 memory usage. > > BUG=1085129, 1096617 > > Change-Id: I184eabcd1a421ffcfb561f388f620eaf9471d9f8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2297702 > Reviewed-by: Ahmed Fakhry <afakhry@chromium.org> > Reviewed-by: Matt Falkenhagen <falken@chromium.org> > Reviewed-by: Will Harris <wfh@chromium.org> > Commit-Queue: Chris Hamilton <chrisha@chromium.org> > Cr-Commit-Position: refs/heads/master@{#789141} TBR=falken@chromium.org,chrisha@chromium.org,dtapuska@chromium.org,afakhry@chromium.org,wfh@chromium.org Change-Id: I420aba017ab4a7ac28d94f296355fb434d24cb96 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1085129 Bug: 1096617 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302693Reviewed-by:
-
zengqiang authored
If an android application registers the PROCESS_TEXT intent but the exported value of Activity is false, the Chrome android or android webView still displays this menu item. If you click these menu items to start the external activity, the 'java.lang.SecurityException: Permission Denial: start Intent' crash occurs. Bug: 1105292 Change-Id: Ie4a033de25e43d67ec76284e3c21a7c3548b3045 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2291567 Commit-Queue: Shimi Zhang <ctzsm@chromium.org> Reviewed-by:
Shimi Zhang <ctzsm@chromium.org> Auto-Submit: Qiang Zeng <zengqiang1@huawei.com> Cr-Commit-Position: refs/heads/master@{#789385}
-
