- 14 Aug, 2020 40 commits
-
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/241a4a92fb96..4c3752c7f677 2020-08-14 taylori@google.com Merge "perfetto-ui: Add analytics" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: Iecb00ddb68899473e74110c36af097a80c1a5776 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355839Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#798103}
-
Sophie Chang authored
Change-Id: Ieaca21d9bec003c5431fb4876d1e442eba50037c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355099Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Commit-Queue: Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/master@{#798102}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/d315022be5b7..24b5971b84c0 2020-08-14 cwallez@chromium.org Remove deprecated wgpu::BufferCopyView members If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: Idda3dbae3d6d04d6f3b26f3ed539d2b0b6233735 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355833Reviewed-by:
-
Glen Robertson authored
Also ran update_use_counter_feature_enum.py to update enums.xml. Bug: 1061503 Change-Id: Ic476333cad72038ed84ea0c80940c2e159bf77c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352303 Commit-Queue: Glen Robertson <glenrob@chromium.org> Auto-Submit: Glen Robertson <glenrob@chromium.org> Reviewed-by:
Matt Giuca <mgiuca@chromium.org> Cr-Commit-Position: refs/heads/master@{#798100}
-
Irina Fedorova authored
This CL updates usage of ShowPasswordBehavior in password_edit_dialog by overriding some methods. Is allows as to use ShowPasswordBehavior not only in Details dialog, but also in Edit Password correctly. Before this changes, there were some problems with password changing, for example, if a user opens password_edit_dialog and changes the password, then clicking the "Show password" button will reset the change. Bug: 377410 Change-Id: Ice957cb7e1aa0301f4ac0798e9233d1415b7ec49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346291 Commit-Queue: Irina Fedorova <irfedorova@google.com> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#798099}
-
Clemens Arbesser authored
This adds a lite_service that is able to perform a single call to GetActions, containing the trigger script path (only if MSBB flag is on). A set of new trigger parameters controls whether autofill_assistant should start with the lite service or the regular one. This CL also adds a workaround for an issue with BottomSheet, where setting new sheet contents will sometimes cause the sheet to go into PEEK mode. Bug: b/162223457 Bug: b/162222884 Bug: b/162222405 Bug: b/162223434 Bug: b/160859107 Change-Id: I15361c72a6893cafbb13543467ab36e0c9f5cf87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332711 Commit-Queue: Clemens Arbesser <arbesser@google.com> Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Cr-Commit-Position: refs/heads/master@{#798098}
-
dizg authored
in the profile creation flow Bug: 1105865 Change-Id: Ie0b4d9f57be1edb784c108f774905ecf2d687c9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339315 Commit-Queue: Diana Zagidullina <dizg@google.com> Reviewed-by:
Monica Basta <msalama@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#798097}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I6150b206191d4a4f04565af1c639137f5da7b9b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355840Reviewed-by:
-
Fergus Dall authored
This increases the default size to 10 lines (from 6) by hiding the empty progress-message box in the error state. This also makes the error logs line up with where the progress message was, and equalizes the margins above and below the error logs. Bug: 1110165 Change-Id: Iffb922a9a06eae67b2d6674015d18da302211ac4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352260 Commit-Queue: Fergus Dall <sidereal@google.com> Reviewed-by:
David Munro <davidmunro@google.com> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#798095}
-
Juanmi Huertas authored
This reverts commit dd116903. Reason for revert: It seems that this build does not compile on mac-arm64-rel Original change's description: > Using vector icons for launcher search provider > > Currently LauncherSearchProvider use png as the format for the result. > This CL changes the format to vector icons (.icon). > > Bug: 1067326 > Change-Id: I55fb11ed50906a5199bc28339de42d4903433b36 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352290 > Reviewed-by: Austin Tankiang <austinct@chromium.org> > Reviewed-by: Noel Gordon <noel@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Reviewed-by: Jia Meng <jiameng@chromium.org> > Reviewed-by: Tony Yeoman <tby@chromium.org> > Commit-Queue: Thanh Nguyen <thanhdng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#798087} TBR=xiyuan@chromium.org,noel@chromium.org,jiameng@chromium.org,tby@chromium.org,thanhdng@chromium.org,austinct@chromium.org Change-Id: I18582a947cf1ee287b3beaf81dbb549a9dace9a7 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1067326 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354307Reviewed-by:
Juanmi Huertas <juanmihd@chromium.org> Commit-Queue: Juanmi Huertas <juanmihd@chromium.org> Cr-Commit-Position: refs/heads/master@{#798094}
-
Andrey Zaytsev authored
Bug: 1070620 Change-Id: I6b6c41eaaabf3a1e7c8ca59fcf7fbbce18f30cc8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352742 Auto-Submit: Andrey Zaytsev <andzaytsev@google.com> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Commit-Queue: Andrey Zaytsev <andzaytsev@google.com> Cr-Commit-Position: refs/heads/master@{#798093}
-
Peter E Conn authored
Change-Id: Ieb903ebc9e4e17b0c755dfcaf1403eea8e92e96a Bug: 1110494 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352817Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#798092}
-
Elly Fong-Jones authored
We don't yet understand why the window position is wrong on macOS 11, so disable that part of the test for now. Bug: 1101398 Change-Id: Ic6c29b60fb5c80ee8efb2be8dc1caef8d206e3bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354418Reviewed-by:
Leonard Grey <lgrey@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#798091}
-
Ewann authored
This CL updates the custom separator thickness to match the 'default' separator. Bug: 1106669 Change-Id: I49f8e0c1df6169826e27dfff0685ea9395922a05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352734 Commit-Queue: Ewann Pellé <ewannpv@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#798090}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1597363129-a36e46938cb7f6611b8efddbaf720b98c4f2f1a3.profdata to chrome-mac-master-1597384369-5af373c8a15e3096c063e440b85721943db04b1b.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC liaoyuke@google.com,sebmarchand+pgo_roller@google.com,jeffyoon@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: liaoyuke@google.com,sebmarchand+pgo_roller@google.com,jeffyoon@google.com Change-Id: If2bdeb5b394ff697a48e3c826e5d3f073fdc8d2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355829Reviewed-by:
-
Rainhard Findling authored
* Makes the safety check Chrome cleaner child automatically update from CCT state changes by registering it as a CCT observer. Bug: 1087263 Change-Id: I0549e961c0e6afe0f34efff73c8381b4d551fa3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353259Reviewed-by:
Andrey Zaytsev <andzaytsev@google.com> Commit-Queue: Rainhard Findling <rainhard@chromium.org> Cr-Commit-Position: refs/heads/master@{#798088}
-
Thanh Nguyen authored
Currently LauncherSearchProvider use png as the format for the result. This CL changes the format to vector icons (.icon). Bug: 1067326 Change-Id: I55fb11ed50906a5199bc28339de42d4903433b36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352290Reviewed-by:
Austin Tankiang <austinct@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Jia Meng <jiameng@chromium.org> Reviewed-by:
Tony Yeoman <tby@chromium.org> Commit-Queue: Thanh Nguyen <thanhdng@chromium.org> Cr-Commit-Position: refs/heads/master@{#798087}
-
Boris Sazonov authored
This reverts commit 3fafebb6. Reason for revert: https://ci.chromium.org/p/chromium/builders/ci/Lollipop%20Phone%20Tester/26557 Original change's description: > Enable Permissions Tests on L > > https://crrev.com/c/2352519 stopped attempting to load the GvrKeyboard, > and the original bug that it fixed had the same error stack as seen in > this bug. Re-enable the Permissions Tests that were failing with the > same error. > > Fixed: 1091800 > Change-Id: Icc2bf2d29ddd8ffbf0016df2be6e9e6d310a1ac3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354721 > Commit-Queue: Alexander Cooper <alcooper@chromium.org> > Commit-Queue: Brian Sheedy <bsheedy@chromium.org> > Auto-Submit: Alexander Cooper <alcooper@chromium.org> > Reviewed-by: Brian Sheedy <bsheedy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#797967} TBR=bsheedy@chromium.org,alcooper@chromium.org Change-Id: I12545b8305fe531473d0c290695e4eec39807b6c No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355949Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#798086}
-
arthursonzogni authored
COOP access reporting will ship only in 'reporting-only'. Support for the 'enforced-mode' has been dropped for now. This patch remove all the tests related to the part dropped. Bug: 1090273 Change-Id: If3081929f2409e33afe9891353afb5045df07662 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352809Reviewed-by:
Pâris Meuleman <pmeuleman@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#798085}
-
David Roger authored
Bug: 1076880 Change-Id: I40a5944ab6f2679dcd26d4d793e2646e81d7a053 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352805Reviewed-by:
Alex Ilin <alexilin@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#798084}
-
Camille Lamy authored
This CL changes the handling of redirects in COOP to match https://github.com/whatwg/html/pull/5739. Instead of comparing a response to the current document, we will compare it to the last entry in the redirect chain. Change-Id: I73a3926a8827733974d7c08b7f3553da06435ac3 Bug: 1108292 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339988 Commit-Queue: Camille Lamy <clamy@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
-
Chris Hamilton authored
Like workers, this defines a collection of tokens for identifying distinct Worklets. This also updates ExecutionContextToken so that it is able to name all possible ExecutionContext types. All of these token types will be used by the performance.measureMemory API. BUG=1085129 Change-Id: I8ad41aeac689278f1e47502c98855dd4aec41b3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354451Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#798082}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/b6ce6baf7a7a..c184cf36092f 2020-08-14 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from ffe84295 to 00c099ff (445 revisions) 2020-08-14 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from cc958e0e8703 to eb85c0213d43 (10 revisions) 2020-08-14 skia-autoroll@skia-public.iam.gserviceaccount.com Roll dawn from 4a486be696b4 to d315022be5b7 (7 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC fmalita@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: fmalita@google.com Test: Test: Test: FramebufferTest_ES31::MultisampleResolveIntoMipMapWithBlit() Change-Id: I50f63a62789554e601a635232fd8ee7c51df29de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355827Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/df859f77dab3..b4c4da3e7606 2020-08-13 alanbaker@google.com Improve non-semantic instruction handling in the optimizer (#3693) 2020-08-13 vasniktel@gmail.com Fix the bug (#3680) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Tbr: radial-bots+chrome-roll@google.com,ynovikov@google.com Change-Id: I62a79cab9ab50e60dd910c68d356e8d3d44729a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355586Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/cfad71e98305..477f9ae93304 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC cfroussios@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: cfroussios@google.com Change-Id: I38b33248cc87a6e8d4843f7455902985dc9535ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355587Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#798079}
-
Rakina Zata Amni authored
Currently we always try to do a proactive BI swap on navigations even if the page is not eligible for bfcache. If the ProactivelySwapBrowsingInstance flag is not explicitly turned on but BackForwardCache is enabled, we should try to do a proactive BI swap only if the page is eligible for bfcache. Note that if the ProactivelySwapBrowsingInstance flag is turned on, we will still try to do a proactive BI swap on every navigation. Bug: 977562 Change-Id: I2106dd12461c9e9723ccf6f2af9007248729cff1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340453 Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#798078}
-
Austin Tankiang authored
Bug: 1115028 Change-Id: I56e07ed021b97ab36a93ffb1e8724c2c49a7a2ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355709Reviewed-by:
Sergei Datsenko <dats@chromium.org> Commit-Queue: Austin Tankiang <austinct@chromium.org> Cr-Commit-Position: refs/heads/master@{#798077}
-
Viviane Yang authored
This CL implements the capability to fire a`pushsubscriptionchange` event when a permission is revoked for the associated origin. The runtime enabled flag PushMessagingSubscriptionChange defined in third_party/blink/renderer/platform/runtime_enabled_features.json5 is hooked up with the content feature flag kPushSubscriptionChangeEvent in content/public/common/content_features.h To enable the flag, you can run chrome with `chrome --enable-features=PushSubscriptionChangeEvent` after this CL. BUG: 646721 TEST: browser_tests --gtest_filter=PushSubscriptionChangeEventTest* Change-Id: I78249de1aa524735f733bcf174ceb2c5ed4d19bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341636 Commit-Queue: Viviane Yang <viviy@google.com> Reviewed-by:
Richard Knoll <knollr@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#798076}
-
Jan Wilken Dörrie authored
This change adds the PasswordCheckReauthenticationHelper class which handles reauthentication requests in the password check prior to editing or viewing a compromised password. Translation Screenshots: IDS_PASSWORD_CHECK_LOCKSCREEN_DESCRIPTION_EDIT: https://storage.cloud.google.com/chromium-translation-screenshots/318cdb4018154327b82c482e6efc3b7e75aaeca7 IDS_PASSWORD_CHECK_LOCKSCREEN_DESCRIPTION_VIEW: https: //storage.cloud.google.com/chromium-translation-screenshots/202b0c83bad016e36816426996b4ecefce4d2657 Bug: 1114720 Change-Id: I72b197783db6686efd7a1c0bf119c190a0e7ef85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352801 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#798075}
-
Morten Stenshorne authored
Although the rendered legend always is a child of the anonymous fieldset content wrapper (the only child of the fieldset) in the layout tree, the NG fragment for the legend is a direct child of the fragment for the fieldset itself. Match this better on the layout object side, by skipping over the anonymous content wrapper (and also the flow thread, if present) when looking for the containing block. The fieldset will now act as the containing block of a rendered legend, even if there's no direct parent-child relationship on the layout side. This is kind of similar to how it works for out-of-flow positioned objects. Also add special code in pre paint for this. This is only needed when traversing the layout object tree; when we switch over to walking the NG fragment tree (LayoutNGFragmentTraversal feature), this special code won't be needed. A more elegant solution might be to add another ContainingBlockContext member for this to ContainingBlockContext in PaintPropertyTreeBuilderFragmentContext (so that we'd reset the state to the one we had at the fieldset, when entering the rendered legend), but it doesn't seem worth it, given that layout object tree walking will be replaced by NG fragment walking at some point. No intended behavior changes currently, but this code change is required in order to handle scrollable fieldsets correctly (which will be added shortly). When a fieldset is scrollable, the legend shouldn't scroll along with the contents (since a legend is part of the border, essentially). We'll therefore establish a scrollable layer on the anonymous wrapper, NOT on the legend. Bug: 875235, 786475 Change-Id: Id31ed3391dcfdbd8ed15b927de69a963368fef13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351973Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#798074}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/eb85c0213d43..6a652f1ab5d7 2020-08-14 ynovikov@chromium.org Create dummy DEPS entry for Chromium. 2020-08-14 ynovikov@chromium.org Reenable AttributeLayout end2end tests on Linux SwANGLE If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: ynovikov@google.com Change-Id: Id14a1c0bacdf3ca3211992288ab30454534cb137 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355584Reviewed-by:
-
Mugdha Lakhani authored
If the page is being invisible, we now defer media playback in the background. I've moved this logic to a shared location so Chrome and WebLayer can reuse it and stay in sync. Bug: 1096088 Change-Id: I61465da4717d28ff8e9f6f83fd2a75fe79fc44ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352819 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#798072}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/a5f2b95badf5..765a9826cde1 2020-08-14 tmathmeyer@chromium.org Media Tab: Remove unused sections 2020-08-14 changhaohan@chromium.org Fix adorner dark mode styles 2020-08-14 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1116310 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I0091a3e4599fd47f1dd5fcbed75a4ead40142605 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355582Reviewed-by:
-
Christos Froussios authored
This reverts commit 67a4df6f. Reason for revert: Speculative revert Suspected of breaking session.RetrieveActiveSessions on chrome_all_tast_tests on chromeos-betty-pi-arc-cfi-thin-lto-chrome https://ci.chromium.org/p/chrome/builders/ci/chromeos-betty-pi-arc-cfi-thin-lto-chrome/7903 bug: 1116379 Original change's description: > LoginScreen: Show TPM lock status. > > If TPM is locked show banner with steps on how to fix this issue. > > Bug: 1114656 > Change-Id: I85dab0f4ce003ac3dad61c318efb3333457993ac > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346266 > Reviewed-by: Toni Baržić <tbarzic@chromium.org> > Commit-Queue: Roman Aleksandrov <raleksandrov@google.com> > Cr-Commit-Position: refs/heads/master@{#797992} TBR=tbarzic@chromium.org,antrim@chromium.org,raleksandrov@google.com Change-Id: Ia81ff22352481c3699928f235a2471a5f47cbff0 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1114656 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352741Reviewed-by:
Christos Froussios <cfroussios@chromium.org> Commit-Queue: Christos Froussios <cfroussios@chromium.org> Cr-Commit-Position: refs/heads/master@{#798070}
-
Glen Robertson authored
No new icon_effects applied as a result of is_maskable parameter. Leaving further updates to app_icon_factory to Nancy. Bug: 1102701 Change-Id: I09b2c3de4da958d22153b187531f1e3c51a25e3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351263Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Commit-Queue: Glen Robertson <glenrob@chromium.org> Cr-Commit-Position: refs/heads/master@{#798069}
-
Rainhard Findling authored
* Only fetch the CCL status when a safety check is run to mitigate crbug.com/1115650. * I'll re-add the observer in a follow-up CL. Bug: 1087263, 1115650 Change-Id: Ib13de19d244328e267100ff83ed12fc41646cc2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353337Reviewed-by:
Joe Mason <joenotcharles@chromium.org> Commit-Queue: Rainhard Findling <rainhard@chromium.org> Cr-Commit-Position: refs/heads/master@{#798068}
-
Matt Falkenhagen authored
This reverts commit da054331. The code review was https://chromium-review.googlesource.com/c/chromium/src/+/2227103 Super speculative revert since we have no other clues about the perf regression which started in a range the CL landed in. Bug: 1096423, 1059157 Tbr: dcheng Change-Id: Ia291b0c16c0cacfcdd40387a6b8badd135fcf7b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355630 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#798067}
-
Josh Nohle authored
Bug: 1113850 Change-Id: I9d82f7a8074b0a0d2fe918bff8125f046e120ad8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353876 Commit-Queue: Josh Nohle <nohle@chromium.org> Reviewed-by:
Himanshu Jaju <himanshujaju@chromium.org> Cr-Commit-Position: refs/heads/master@{#798066}
-
Luca Hunkeler authored
Change-Id: Id59efac059eea817650c5c9c3163ac372d1df875 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352919Reviewed-by:
Clemens Arbesser <arbesser@google.com> Commit-Queue: Luca Hunkeler <hluca@google.com> Cr-Commit-Position: refs/heads/master@{#798065}
-
Jan Wilken Dörrie authored
This change uses base::flat_map instead of std::unordered_map in zxcvbn's RankedDicts in order to reduce memory usage. Since a base::flat_map requires its elements to be move assignable, the mapped_type is changed from a reference to a pointer. Bug: 1115878 Change-Id: I97eada4b85bfbbf0b47a9a73c6c9219f112380c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352735 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
-
