GitLab

The Add to Homescreen feature will now consider "maskable" icons from
the web app manifest [1]. If a maskable icon is present and we are on
an Android O+ device, turn that "maskable" icon into an Android Adaptive
icon [2].

The icon is scaled to ensure that the safe zone is preserved [3].

[1]: https://w3c.github.io/manifest/#purpose-member
[2]: https://developer.android.com/guide/practices/ui_guidelines/icon_design_adaptive
[3]: https://github.com/w3c/manifest/issues/555#issuecomment-404097653

Bug: 904354
Change-Id: Iedfe61ace0fda4ca7f3ed3da6a5d07f2bff81443
Reviewed-on: https://chromium-review.googlesource.com/c/1341998
Commit-Queue: Peter Conn <peconn@chromium.org>
Reviewed-by: Matt Giuca <mgiuca@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612218}

Also cleanup the test names to be more descriptive of what parameter were used.

Bug: 907443
Change-Id: I4a42d1aad2856beda89911e63256ea8d0f67bb54
Reviewed-on: https://chromium-review.googlesource.com/c/1349751Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Joe Mason <joenotcharles@google.com>
Commit-Queue: Chris Sharp <csharp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612217}

This CL is implementing the Phase 1 described in this doc:
https://docs.google.com/document/d/1v-k8Ck7x_2kpBfgaVmqg2NvQRvD1PqyOt50rdO141Wc/edit#

Basically, it redefines the StylePropertyMapReadOnly to be a pure
interface. Then it renames the existing StylePropertyMapReadOnly to
StylePropertyMapReadOnlyMainThread. Then it makes all subclasses of
StylePropertyMapReadOnly to be subclasses of
StylePropertyMapReadOnlyMainThread.

This CL should not introduce any behavior change.

Bug: 895579
Change-Id: I400981d1745ab3ee80b9ba9b77c3e3406cd0c1e7
Reviewed-on: https://chromium-review.googlesource.com/c/1354118
Commit-Queue: Xida Chen <xidachen@chromium.org>
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612216}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f9b825600fd5..73b3bde2659f


Created with:
  gclient setdep -r src-internal@73b3bde2659f

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: I08d3f91a6e9df0b9fae9c87647e6eef01b3fd175
Reviewed-on: https://chromium-review.googlesource.com/c/1354987Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#612215}

This CL moves the tests in http/tests/event-timing to external/wpt/event-timing.
The slow image is change from php based to python based. The click is now
handled by test driver. and setTimeout is replaced with step_timeout.

Bug: 841224, 908187, 907948, 907949
Change-Id: Ia6359878666cfb96645aa3b7cd7736ce9df97683
Reviewed-on: https://chromium-review.googlesource.com/c/1352617Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612214}

Point to paths that actually exist after the great Blink mv from a while
ago.

TBR=haraken

Change-Id: I22431a1abdf786ad9fe98188df5002e60733a182
Reviewed-on: https://chromium-review.googlesource.com/c/1355165Reviewed-by: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
Cr-Commit-Position: refs/heads/master@{#612213}

R=khorimoto@chromium.org

Bug: none
Test: none
Change-Id: I4056cee71621cb850d86d2a4e42d8c99ef90374d
Reviewed-on: https://chromium-review.googlesource.com/c/1354644Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: James Hawkins <jhawkins@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612212}

Specifics:
       +66,536 bytes main lib size
      +470,476 bytes main dex size
      +759,062 bytes normalized apk size
InstallSize:
      +291,292 bytes APK size
      +841,749 bytes Estimated installed size (Android Go)
    +2,192,016 bytes Estimated installed size
InstallBreakdown (+2,192,664 bytes):
        +2,706 bytes unwind_cfi (dev and canary only) size
        +2,690 bytes Non-compiled Android resources size
       +66,536 bytes Native code size
          +580 bytes Package metadata size
    +2,104,848 bytes Java code size
       +15,304 bytes Compiled Android resources size
Dex:
        +2,412 entries fields
        +3,295 entries methods
          +777 entries types
        +1,694 entries strings

Bug: 908594, 907155, 907085
Change-Id: I80b5466e726baa76aa05ecc9a01269094f0046ba
Reviewed-on: https://chromium-review.googlesource.com/c/1354350
Commit-Queue: Sky Malice <skym@chromium.org>
Reviewed-by: Filip Gorski <fgorski@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612211}

* Use dist_jar() rather than a custom script
  * Avoids needing to extract .jars.
  * Avoids needing to reference ".javac.jar" files, which
    are somewhat of an implementation detail.

* Added jar_excluded_patterns support to dist_jar()

* Merges zip.py and dist_jar.py, since they were doing the
  same thing.

Spot checked that these two jars are the same before/after:
* cronet/cronet_impl_common_java.jar
* cronet/cronet_impl_native_java.jar

Change-Id: I4d5a5f495ce0376ef2e53b6d4e3c9ebbc3d75ae1
Reviewed-on: https://chromium-review.googlesource.com/c/1349872Reviewed-by: Paul Jensen <pauljensen@chromium.org>
Reviewed-by: Eric Stevenson <estevenson@chromium.org>
Commit-Queue: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612210}

This CL makes sure that the omnibox suggestions labels width is taking
into account the presence of the "switch to open tab" button.

Bug: 908874
Change-Id: I92ce30dabadc511a319b43879baa125fa080e0f8
Reviewed-on: https://chromium-review.googlesource.com/c/1353940
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612209}

base::ContainsValue tries to compare the value to the element in
container. Unfortunately for a map, this isn't possible since the
returned element is a pair<>.

Bug: None
Test: Compile cast_shell
Change-Id: I3d072442f7d9e9c895adc934133f626abe104a88
Reviewed-on: https://chromium-review.googlesource.com/c/1354348Reviewed-by: Alex Sakhartchouk <alexst@chromium.org>
Commit-Queue: Daniel Nicoara <dnicoara@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612208}

MessageLoop will go away, eventually.

BUG=891670

Change-Id: I6b2246cf59b8454ab0a6522bc7825bbcd9e76e12
Reviewed-on: https://chromium-review.googlesource.com/c/1352368Reviewed-by: Marc Treib <treib@chromium.org>
Commit-Queue: Carlos Caballero <carlscab@google.com>
Cr-Commit-Position: refs/heads/master@{#612207}

Bug: 908834
Change-Id: I3b0b80f8fd31c88d29bafa5bcaff0f2f6ef104a7
Reviewed-on: https://chromium-review.googlesource.com/c/1355180Reviewed-by: Finnur Thorarinsson <finnur@chromium.org>
Commit-Queue: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612206}

This CL converts ImportDataCollectionViewController to use UITableView
instead of MDCCollectionViewController.

Bug: 894791
Change-Id: I38a99ae849ef2b30d90820b197f4ba56edadabba
Reviewed-on: https://chromium-review.googlesource.com/c/1352156
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612205}

Adding // namespace xxx after namespace definition.
This is simplify a little:
https://chromium-review.googlesource.com/c/chromium/src/+/1280249/68/ios/chrome/browser/signin/gaia_auth_fetcher_ios.h

Change-Id: Icd3b07d450ed2af65662587359bf036966f5f1f4
Reviewed-on: https://chromium-review.googlesource.com/c/1355100Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Commit-Queue: Jérôme Lebel <jlebel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612204}

Change-Id: If915537bcca19f6b67ba8d70d8a9a944885faa8c
Reviewed-on: https://chromium-review.googlesource.com/c/1353926Reviewed-by: Benoit L <lizeb@chromium.org>
Reviewed-by: Peter Conn <peconn@chromium.org>
Commit-Queue: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612203}

LLVM r347097 introduced a lit test that requires sort.

Bug: 904337
Change-Id: I2daaea742207a3b5a77a0b95571352928641c287
Reviewed-on: https://chromium-review.googlesource.com/c/1354939Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Hans Wennborg <hans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612202}

Also add new third_party/harfbuzz-ng/src/roll-harfbuzz.sh roll script.

https://chromium.googlesource.com/external/github.com/harfbuzz/harfbuzz.git/+log/574d888c8a40..e0307de818ad

$ git log 574d888c8..e0307de81 --date=short --no-merges --format='%ad %ae %s'
2018-11-29 ebrahim [test][aat.kern] More (#1427)
2018-11-28 mbutterick update simple shaping example (closes #298)
2018-11-29 ebrahim [test][aat] Update expectency
2018-11-29 ebrahim [test] Add test for format2 kern (#1423)
2018-11-28 behdad [kerx] Fix Format2 index calc again
2018-11-28 behdad [kern] Fix kern table Format2 offsetToIndex
2018-11-28 behdad [kerx] Fix ClassTable implementation for 'kern' table Format 2
2018-11-28 behdad [aat] Towards adding two ClassTable's
2018-11-28 ebrahim [test][aat] Add a test and make macOS runners faster (#1422)
2018-11-27 behdad Comment
2018-11-20 adenilson.cavalcanti Optimize harfbuzz big integer conversions
2018-11-26 ebrahim [ci] Add .codecov.yml
2018-11-26 ebrahim [test][aat] Enable Tamil MN test (#1414)

Created with:
  roll-dep src/third_party/harfbuzz-ng/src
R=bashi@chromium.org,behdad@chromium.org,behdad@google.com,drott@chromium.org,eae@chromium.org,jshin@chromium.org

Bug: 909875
Change-Id: I89f631b6c2655e0b8777820a45b0018b89ab67fa
Reviewed-on: https://chromium-review.googlesource.com/c/1354451Reviewed-by: Ben Wagner <bungeman@chromium.org>
Commit-Queue: Ben Wagner <bungeman@chromium.org>
Commit-Queue: Dominik Röttsches <drott@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612201}

This reverts commit b9385fec.

Reason for revert: OpenTypeCapsSupportTest.SmallCapsForSFNSText
has failed the 2 times it was run since that CL was landed:

https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.10%20Tests/36813
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.10%20Tests/36814

Original change's description:
> Enable small-caps font feature in AAT system fonts on Mac
> 
> Shaping code relies on feature detection to determine whether the font
> has small-caps support or not. If not, small capitals are synthesized
> from uppercased letters with scaled-down font size. Add feature
> detection for AAT fonts on Mac. Now the shaping code can enable the
> built-in small-caps glyphs for a set of system font that have them.
> 
> Tests: open_type_caps_support_test.cc unit test for feature
> detection, fast/text/small-caps-aat.html layout test.
> 
> Bug: 900955
> Change-Id: I9bb31719b0a1b5e81a428030cfdeaf91b8e6d17e
> Reviewed-on: https://chromium-review.googlesource.com/c/1353927
> Commit-Queue: Dominik Röttsches <drott@chromium.org>
> Reviewed-by: Emil A Eklund <eae@chromium.org>
> Reviewed-by: Behdad Esfahbod <behdad@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#612171}

TBR=eae@chromium.org,kojii@chromium.org,drott@chromium.org,behdad@google.com,behdad@chromium.org

Change-Id: Ie6931d9b4442fd61b8f347e4616e7bd571d44ce5
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 900955
Reviewed-on: https://chromium-review.googlesource.com/c/1354411Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612200}

I made a mistake in my previous patch and actually removed dimensions
for chromium.webrtc.fyi. That's fine though, it made sense to do
anyway. Here is the correct fix.

Bug: 877018
Change-Id: Ia45c80a3c4bb2487198766e936c28f953c4a4e41
Reviewed-on: https://chromium-review.googlesource.com/c/1355182Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Patrik Höglund <phoglund@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612199}

Instead of compressing only the start of the data to report smaller chunks
compression ratios, compress all the data chunk by chunk.

This is meant to accurately represent the impact of larger block sizes on
compression ratios, highlighting the impact of compressing whole scripts rather
than individual pages.

On Pixel (1st generation):

Gzip
 Size = 4096
 Compression
  Compression ratio = 2.2817
  Throughput = 21.2864MB/s
  Latency (size = 4096) = 192.423us
4096,21.2864,192.423
 Decompression
  Throughput = 143.899MB/s
  Latency (size = 4096) = 28.4645us
4096,143.899,28.4645
 Size = 8192
 Compression
  Compression ratio = 2.44109
  Throughput = 22.9597MB/s
  Latency (size = 8192) = 356.799us
8192,22.9597,356.799
 Decompression
  Throughput = 175.248MB/s
  Latency (size = 8192) = 46.7452us
8192,175.248,46.7452
 Size = 16384
 Compression
  Compression ratio = 2.56997
  Throughput = 22.1722MB/s
  Latency (size = 16384) = 738.942us
16384,22.1722,738.942
 Decompression
  Throughput = 206.567MB/s
  Latency (size = 16384) = 79.3158us
16384,206.567,79.3158
 Size = 32768
 Compression
  Compression ratio = 2.67076
  Throughput = 19.6633MB/s
  Latency (size = 32768) = 1666.46us
32768,19.6633,1666.46
 Decompression
  Throughput = 229.605MB/s
  Latency (size = 32768) = 142.715us
32768,229.605,142.715
 Size = 65536
 Compression
  Compression ratio = 2.74245
  Throughput = 17.4527MB/s
  Latency (size = 65536) = 3755.06us
65536,17.4527,3755.06
[...]

Bug: 907489
Change-Id: I71654f91980ad10f1b43fcb774bfb3808bffdaf4
Reviewed-on: https://chromium-review.googlesource.com/c/1352175Reviewed-by: Egor Pasko <pasko@chromium.org>
Commit-Queue: Benoit L <lizeb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612198}

find_in_page.js.

This CL fixes remaining trivial problems like comments, naming issues of
variables and functions, and makes a small change on DFS.

Bug: 228585
Change-Id: I2df40f675e86fea099fedb987d815b00307417ec
Reviewed-on: https://chromium-review.googlesource.com/c/1355119
Commit-Queue: Yi Su <mrsuyi@chromium.org>
Reviewed-by: Peter Lee <pkl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612197}

https://chromium-review.googlesource.com/c/chromium/src/+/1163620/
migrated ProfileDownloader to IdentityManager. As part of doing so, it
naturally checked the |is_valid| parameter in ProfileDownloader::
OnRefreshTokenUpdatedForAccount(). However, this check is actually
incorrect, as the being migrated *away from* was not making the
equivalent check (which would have been checking PO2TS::GetAuthError()
explicitly). I discovered this while going through the codebase to
remove the |is_valid| parameter from this observer callback precisely
to avoid this kind of confusion :).

Bug: 909734
Change-Id: Iace1fbe14326aedbdd54e6e59db9ec466d8ffcdc
Reviewed-on: https://chromium-review.googlesource.com/c/1353982Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Commit-Queue: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612196}

We can likey remove the ability to disable this feature by M73.

Bug: None
Change-Id: I352eb60fb3f6915c140691f24a497df983a2b9c2
Reviewed-on: https://chromium-review.googlesource.com/c/1354261Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612195}

Removing bzanotti from ios/chrome/browser/signin/OWNERS.

Change-Id: Ie50fefddfa33e0b178b94d2e3eb08536ce803933
Reviewed-on: https://chromium-review.googlesource.com/c/1355123Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Commit-Queue: Jérôme Lebel <jlebel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612194}

TransportSecurityState::DeleteAllDynamicDataSince provides no way to
wait until the deletion is finished and written to disk.
This adds a callback, so that clients can be informed when the deletion
is finished.

Bug: 795872
Change-Id: Ia0af06926d0ccfed07e229cd53b9d8ae587781c5
Reviewed-on: https://chromium-review.googlesource.com/c/1335939
Commit-Queue: Christian Dullweber <dullweber@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Reviewed-by: Chris Palmer <palmer@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612193}

Introduce AXEventManager to maintain an ObserverList of objects
interested in views accessibility events.

This makes testing easier by eliminating the need for several
TestViewsDelegates.

BUG=908884
TEST=views_unittests, views_mus_unittests, browser_tests

Change-Id: Ic7017444fec7e694675ad675e0fefaf78b622130
Reviewed-on: https://chromium-review.googlesource.com/c/1352265Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612192}

Bug: 813093
Change-Id: I1a8b89036efc304c04f0d97aa0131ff21fa91876
Reviewed-on: https://chromium-review.googlesource.com/c/1344828
Commit-Queue: David Bienvenu <davidbienvenu@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612191}

Renames RunUntilTermination to RunAsyncUntilTermination to
(hopefully) clarify that the call does not block the caller until
the service terminates.

TBR=sky@chromium.org

Bug: None
Change-Id: I04e059a0332b76d565625059baf11dd077275aa3
Reviewed-on: https://chromium-review.googlesource.com/c/1351537
Commit-Queue: Ken Rockot <rockot@google.com>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Ken Rockot <rockot@google.com>
Cr-Commit-Position: refs/heads/master@{#612190}

Simple change making the article agree with its noun.  Twice.

TBR=yigu@chromium.org

Change-Id: I113e3ac0f7700e57c9df3b95a2d7ab155ed5542f
Reviewed-on: https://chromium-review.googlesource.com/c/1354228Reviewed-by: Peter Mayo <petermayo@chromium.org>
Reviewed-by: Yi Gu <yigu@chromium.org>
Commit-Queue: Peter Mayo <petermayo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612189}

- Record settings histogram also when unified consent is disabled.

- Add browser test class for the UnifiedConsentService and add
  tests for the settings histogram.
  Note: More tests for the consent service will be added in a
  follow-up CL. Test support for Android and ChromeOS will be
  added in the future.

Bug: 908061, 888527
Change-Id: I4fa3ade5b8d3147c40032a3da631523e94ca09a3
Reviewed-on: https://chromium-review.googlesource.com/c/1352255
Commit-Queue: Thomas Tangl <tangltom@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612188}

This migrates ws and related IME service tests away from the deprecated
ServiceTest framework in favor of regular unit tests using newer
Service Manager test helpers.

Since this is the final set of tests which was using ServiceTest in
services_unittests, the target is also replaced with a plain old gtest
suite and the global catalog configuration junk is removed.

Bug: 906239
Change-Id: Ic85c7be164fde2b6a9883d0af547600c71f446b5
Reviewed-on: https://chromium-review.googlesource.com/c/1352695
Commit-Queue: Ken Rockot <rockot@google.com>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612187}

MessageLoop will go away, eventually.

BUG=891670

Change-Id: I7b07813a9fe1a48bfe4f268d96c5cbe3fb0f8542
Reviewed-on: https://chromium-review.googlesource.com/c/1352777Reviewed-by: Peng Huang <penghuang@chromium.org>
Commit-Queue: Carlos Caballero <carlscab@google.com>
Cr-Commit-Position: refs/heads/master@{#612186}

This will enable us to start trialing the MessageLoop replacement by
SequenceManager.

We only do this in the Blink main thread for now. There is some work
needed around SequenceManager ownership to be done before this can be
enabled in worker threads.


Bug: 891670
Change-Id: I1e59784ff35c87883a66d9b315435bf47cd0f809
Reviewed-on: https://chromium-review.googlesource.com/c/1349316Reviewed-by: Alex Clarke <alexclarke@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Commit-Queue: Carlos Caballero <carlscab@google.com>
Cr-Commit-Position: refs/heads/master@{#612185}

This reverts commit cf071719.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 612160 as the
culprit for flakes in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vY2YwNzE3MTk1ZWQ1Nzk4YzE5NzBmNDg5NzY4MmExNTE3YzIyOWU3NQw

Sample Failed Build: https://ci.chromium.org/buildbot/chromium.linux/linux-xenial-rel/5253

Sample Failed Step: network_service_content_browsertests on Ubuntu-16.04

Sample Flaky Test: DumpAccessibilityTreeTest.AccessibilityVideoControls

Original change's description:
> [Accessibility] Volume slider reads out level in percentages.
> 
> This CL makes it such that the volume level is read out as a percentage
> in aria. This CL also amplifies how the accessibility information is
> given to aria, by setting attributes instead of explicitly creating
> accessibility nodes.
> 
> Bug: 905024
> Change-Id: I0ee5a91215669f39c7394d3c8f113ae83a74cf00
> Reviewed-on: https://chromium-review.googlesource.com/c/1337298
> Reviewed-by: Nico Weber <thakis@chromium.org>
> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
> Commit-Queue: CJ DiMeglio <lethalantidote@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#612160}

Change-Id: I06f47bd929725e2176c9cc9a48e20993d1cb78f9
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 905024, 910123
Reviewed-on: https://chromium-review.googlesource.com/c/1354196
Cr-Commit-Position: refs/heads/master@{#612184}

These are called WindowsServer2008 and Windows-2012ServerR2-SP0 and
stuff like that nowadays. This CL just drops the OS dimension since
bots.cfg ensures each builder runs on the right OS, anyway.

Tbr: jbudorick@chromium.org
Bug: 877018
Change-Id: Ib71ee5f1d26ed90b38fb0b9868994f4bd0c29ad3
Reviewed-on: https://chromium-review.googlesource.com/c/1354924Reviewed-by: Patrik Höglund <phoglund@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Patrik Höglund <phoglund@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612183}

IdentityManagerObserverBridge provides a bridge from C++ to
Objective-C for IdentityManager::Observer but lacked methods
that were recently added.

Fixes this by adding missing overrides.

Bug: none
Change-Id: I5004e23b18e043a8d8bd5736d394aa1d8222a72d
Reviewed-on: https://chromium-review.googlesource.com/c/1354920
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612182}

This CL extends the existing simple IdentityTestEnvinroment ctor by
supplying an optional TestingPrefServiceSyncable instance. This way
tests could still tweak the PrefService instance they hold and
other objects, eg PO2TS, SigninManager, AccountTrackerService would be
hidden from the tests.

BUG=908810

Change-Id: If8257ddc6bdc22481d3530197025592264ffe256
Reviewed-on: https://chromium-review.googlesource.com/c/1351160
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612181}

Only internal data type differences and such things.

TBR=atotic@chromium.org,kojii@chromium.org

Bug: 889721, 835484
Change-Id: I1b46bb16b5ab39da52ad7b20241441f7a99d0fa2
Reviewed-on: https://chromium-review.googlesource.com/c/1354925Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612180}

A series of async steps need to be performed for migrating existing
users to Chrome OS Account Manager. Please see the attached bug for a
Design Document.

Add a utility for sequentially running a series of async migration
steps, which are run only if the previous step was completed
successfully.

This utility allows us to specify the migration steps in a declarative
style with clear dependencies instead of creating a complex web of
callbacks.

Bug: 904128
Test: unit_tests --gtest_filter="*MigrationRunnerTest*"
Change-Id: I5bd5ddc1fb59060577e535fb115bd4689adfaaa7
Reviewed-on: https://chromium-review.googlesource.com/c/1329964Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Pavol Marko <pmarko@chromium.org>
Commit-Queue: Kush Sinha <sinhak@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612179}