GitLab

BUG=110610

Review URL: https://codereview.chromium.org/535723002

Cr-Commit-Position: refs/heads/master@{#293170}

This reverts commit 9ed04f3e258e8f1ffdef74be2418fd87b1a47dfc.

Reason for revert: did a bad git merge in the original branch merge. :(

BUG=405056
TBR=noms@chromium.org

Review URL: https://codereview.chromium.org/533153003

Cr-Commit-Position: refs/heads/master@{#293169}

Annotate postCallbackOnMainThread() method with @CalledByNative,
and LibInfo fields with @AccessedByNative, for ProGuard.

BUG=

Review URL: https://codereview.chromium.org/539523003

Cr-Commit-Position: refs/heads/master@{#293168}

This brings in:
5f8a503 Check m_nComponents when using JBIG2Decode
1d7dc1b Add m_pDocument in CPDF_Color and check if page date has been forced clear
49c41ac Tidy up opj_ callback functions in fx_codec_jpx_obj.cpp
9f810e7 Remove the GetValidBpc check in application callers and move it to where m_bpc is assigned.
d0c3650 Remove unused fields and stack locals.

TBR=thakis@chromium.org
TBR=inferno@chromium.org

Review URL: https://codereview.chromium.org/535623003

Cr-Commit-Position: refs/heads/master@{#293167}

BUG=380349

Review URL: https://codereview.chromium.org/479873002

Cr-Commit-Position: refs/heads/master@{#293166}

(By request of the site.)

BUG=410377

Cr-Commit-Position: refs/heads/master@{#293165}

When CreateSharedRelro fails, the file descriptor read by LibInfo from the parcel will be null, but
the child processes are trying to call its methods anyway. Added a check to avoid NPE.

BUG=409826

Review URL: https://codereview.chromium.org/538543002

Cr-Commit-Position: refs/heads/master@{#293164}

The recipe magic expands the test failure trie using '/' as the
separator in contrast to '.', which is the separator in the test case's
id.

BUG=264859
R=robertshield@chromium.org

Review URL: https://codereview.chromium.org/534303002

Cr-Commit-Position: refs/heads/master@{#293163}

Used 10ms native buffer size for webrtc audio renderer on Linux and Mac. And also remove some useless buffer size uma stat code.

BUG=410258
TEST=content_unittests --gtest_filter="*WebRtcAudioRenderer*"

Review URL: https://codereview.chromium.org/539453003

Cr-Commit-Position: refs/heads/master@{#293162}

This change adds a GetModeSize() method that returns the size of the
HDC's output as a convenience.

TEST=Boot chrome on link_freon (and attach an external display.)
BUG=None

Review URL: https://codereview.chromium.org/535963002

Cr-Commit-Position: refs/heads/master@{#293161}

Changes:
1) Run clang-format through source and header files.
2) Rename data member variables to use unix_hacker_ style.
3) Rename methods to use CamelCase style.
4) Rename file name to test_plugin.

BUG=331299

Review URL: https://codereview.chromium.org/469943003

Cr-Commit-Position: refs/heads/master@{#293160}

BUG=110610
TBR=sky@chromium.org

Review URL: https://codereview.chromium.org/532833003

Cr-Commit-Position: refs/heads/master@{#293159}

BUG=378909, 381233, 381233
TBR=eugenis@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/536023002

Cr-Commit-Position: refs/heads/master@{#293158}

MessageLoopProxy is deprecated.

This basically does a search and replace:

MessageLoopProxy::current() -> ThreadTaskRunnerHandle::Get().

BUG=391045
TEST=unittests
R=sky@chromium.org

Review URL: https://codereview.chromium.org/516173002

Cr-Commit-Position: refs/heads/master@{#293157}

Revert of Reland  501823002: Used native deinterleaved and float point format for the input streams (patchset #4 id:80001 of https://codereview.chromium.org/510073002/)

Reason for revert:
It is speculated that this CL is blamed for crbug/409819, I temporarily revert it to be able to verify it on canary.

Original issue's description:
> Used native deinterleaved and float point format for the input streams.
>
> If we call GetProperty of kAudioUnitProperty_StreamFormat before setting the format, the device will report kAudioFormatFlagsNativeFloatPacked | kLinearPCMFormatFlagIsNonInterleaved as the native format of the device, which is the same as the output.
>
> This patch changes the format to use kAudioFormatFlagsNativeFloatPacked | kLinearPCMFormatFlagIsNonInterleaved to open the device, so that we will avoid format flipping back and forth. Hope this optimization will help increase the stability of the input audio on Mac.
>
> TBR=DaleCurtis@chromium.org
>
> BUG=404884
> TEST=media_unittests && https://webrtc.googlecode.com/svn-history/r5497/trunk/samples/js/demos/html/pc1.html, https://www.google.com/intl/en/chrome/demos/speech.html
>
> Committed: https://chromium.googlesource.com/chromium/src/+/2c732c000e18a6decd1da8da24e1f5f9e5f16833

TBR=dalecurtis@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=404884

Review URL: https://codereview.chromium.org/532303002

Cr-Commit-Position: refs/heads/master@{#293156}

The bug causing failure of the test has been fixed (crbug.com/245441).

BUG=394338
TBR=zhaoqin

Review URL: https://codereview.chromium.org/537593002

Cr-Commit-Position: refs/heads/master@{#293155}

BUG=390894
TEST=N/A

Review URL: https://codereview.chromium.org/509283003

Cr-Commit-Position: refs/heads/master@{#293154}

Since the indication of an active script running won't always be tied to the
location bar, it doesn't make sense for ActiveScriptController to be owned by
LocationBarController.

Since the "generated" actions were also only used for display
in the location bar, move that logic to the LocationBarController.

And, since we're there, also add a bit more testing for LocationBarController.

BUG=408676
TBR=avi@chromium.org (for method name change in cocoa)

Review URL: https://codereview.chromium.org/527963003

Cr-Commit-Position: refs/heads/master@{#293153}

TBR=zhaoqin@chromium.org
BUG=NONE
NOTRY=true

Review URL: https://codereview.chromium.org/539533003

Cr-Commit-Position: refs/heads/master@{#293152}

Cleanup:  https://crrev.com/516443002/ obsoleted PrerenderCondition* classes.

BUG=406583

Review URL: https://codereview.chromium.org/517843005

Cr-Commit-Position: refs/heads/master@{#293151}

Newer mobile devices may support the Open GL extension
EXT_disjoint_timer_query, these devices can now be traced in Chrome.

R=vmiura@chromium.org
BUG= https://code.google.com/p/chromium/issues/detail?id=397294
TEST= trybots

Review URL: https://codereview.chromium.org/509723002

Cr-Commit-Position: refs/heads/master@{#293150}

The only user of this interface has been folded into
NetworkMetricsProvider.

BUG=409872

Review URL: https://codereview.chromium.org/532623003

Cr-Commit-Position: refs/heads/master@{#293149}

Revert of [fsp] Enable the File System Provider API for extensions. (patchset #2 id:20001 of https://codereview.chromium.org/527663002/)

Reason for revert:
Speculative revert, failed ChromiumOS browser_tests.

[1422/1422] FileSystemProviderApiTest.Extension (11555 ms)
1 test failed:
    FileSystemProviderApiTest.Extension

http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%282%29/builds/11812

Original issue's description:
> [fsp] Enable the File System Provider API for extensions.
>
> Previously, only apps were allowed to use this api, however most clients will
> be actually written as extensions.
>
> TEST=browser_tests: *FileSystemProvider*Extension*
> BUG=409487
>
> Committed: https://chromium.googlesource.com/chromium/src/+/4acb869459901c6fa627473bb15b8a0f6190cc11

TBR=benwells@chromium.org,kalman@chromium.org,mtomasz@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=409487

Review URL: https://codereview.chromium.org/537603002

Cr-Commit-Position: refs/heads/master@{#293148}

BUG=410327
TBR=tkent,rvargas

Review URL: https://codereview.chromium.org/539473004

Cr-Commit-Position: refs/heads/master@{#293147}

This reverts commit 69538c3b.

As described in the bug, the proposed approach is invalid, as Blink's bindings
code isn't ready to deal with terminated scripts properly, resulting in random
crashes. Hence reverting the patch.

BUG=390906

Review URL: https://codereview.chromium.org/534093004

Cr-Commit-Position: refs/heads/master@{#293146}

The bug has long been fixed so can remove this workaround.

BUG=353687
TBR=thakis@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/536903003

Cr-Commit-Position: refs/heads/master@{#293145}

The deadlock occurs because we hold lock when posting flush tasks.
If MessageLoop::PostTask() also calls TRACE_EVENT and the TRACE_EVENT
has never been reached before, the TRACE_EVENT will try to get the
category enabled flag which will also need a lock.

Copy thread_message_loops into a temporary vector of
scoped_refptr<SingleProcessTaskRunner> to avoid lock when calling
PostTask().

BUG=397022
TEST=Existing tests and ThreadSanitizer

Review URL: https://codereview.chromium.org/491393002

Cr-Commit-Position: refs/heads/master@{#293144}

Rather than being a subscriber to DTAB port forwarding becomes part of it so that DTAB could stop discovering new devices when chrome://inspect is closed.

BUG=387067

Review URL: https://codereview.chromium.org/500373004

Cr-Commit-Position: refs/heads/master@{#293143}

Update rules2 in app_resource_rules.plist.in to a set of rules that ought to work on 10.9.5 and 10.10, with the latest Gatekeeper policy changes.

This removes the “nested” tag from the live versioned directory, so that
it will be treated as data instead of code. There are problems with
“nested” validation of unversioned frameworks. There are other problems
with “nested” allowing components to be replaced, although these can be
overcome by creatively applying designated requirements to the nested
components. The non-“nested” version allows us to not version the
frameworks, which would introduce symbolic links and weaken v1 code
signature validation as done by pre-10.9 systems because v1 code
signatures do not consider symbolic links. This non-“nested” version is
also the simplest change to the existing set of resource rules that
works. The v2 rules2 dictionary is now identical to the v1 rules
dictionary.

In order for rules2 to be honored and for a v2 signature to be produced,
the app must be signed on 10.9 or later. (This will also produce a v1
signature to be validated on pre-10.9 systems.)

BUG=399276
R=rsesek@chromium.org

Review URL: https://codereview.chromium.org/533943003

Cr-Commit-Position: refs/heads/master@{#293142}

This was useful to reduce the log output when Clang's Windows
support was less mature.

BUG=82385
R=thakis@chromium.org

Review URL: https://codereview.chromium.org/539473003

Cr-Commit-Position: refs/heads/master@{#293141}

In case the address is a negative 32-bit integer (greater than 0x80000000), it
is converted into 64-bit preserving the sign so all the leading bits are set.
This results in an invalid 64-bit address.

The conversion must be done via an unsigned 32-bit integer (uintptr_t).

BUG=409826

Review URL: https://codereview.chromium.org/533173002

Cr-Commit-Position: refs/heads/master@{#293140}

I changed analyzer such that if a gyp file (or an included gypi file)
changes all targets in the gyp file are marked as changed. This means
I should no longer have to special case gyp files. I'm leaving the
exception in place for any gyp files in build as any change to those
really needs to recompile the world.

BUG=109173
TEST=none
R=thakis@chromium.org

Committed to pending queue: https://chromium.googlesource.com/chromium/src/+/5110e8b

Review URL: https://codereview.chromium.org/512693004

Cr-Commit-Position: refs/heads/master@{#293139}

disable browser_tests RequestContentScriptAPITest.PermissionMatcherAgreementInjection on Dr.Memory bots

TBR=bruening@chromium.org
BUG=none
NOTRY=true

Review URL: https://codereview.chromium.org/528353002

Cr-Commit-Position: refs/heads/master@{#293138}

BUG=382367

Review URL: https://codereview.chromium.org/466983004

Cr-Commit-Position: refs/heads/master@{#293137}

Revert of Recorded additional tough_energy_cases. (patchset #1 id:1 of https://codereview.chromium.org/506063002/)

Reason for revert:
Errors: "WARNING:root:The page set archives for some pages are missing. Someone forgot to check them in, or they were deleted. Skipping those pages. To fix this, record those pages using record_wpr. To ignore this warning and run against live sites, pass the flag --use-live-sites."

Example: http://chromegw/i/chromium.perf/builders/Win%208%20Perf%20%282%29/builds/3086/steps/tab_switching.tough_energy_cases/logs/stdio

Original issue's description:
> PERF SHERIFF: This CL changes the tough_energy_cases test.
>
> Recorded additional tough_energy_cases.
> Moved all test cases to codepen, so they're easy to edit and all http.
>
> BUG= 386152
>
> Committed: https://chromium.googlesource.com/chromium/src/+/f4919a56f8dde79db10d158940bab9b5a95688f0

TBR=tonyg@chromium.org,jeremy@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG= 386152

Review URL: https://codereview.chromium.org/535153003

Cr-Commit-Position: refs/heads/master@{#293136}

The declared output was incorrect, forcing a systematic rebuild.

R=dzhioev@chromium.org

Review URL: https://codereview.chromium.org/534263002

Cr-Commit-Position: refs/heads/master@{#293135}

Original description from commit 63e36e6b:

ui: Move ui_unittests.gyp into ui/base.

ui_unittests.gyp -> ui_base_tests.gyp (follow gfx_tests.gyp pattern).
ui_unittests_bundle.gypi -> ui/base/ui_base_tests_bundle.gypi
ui_unittests.isolate -> ui_base_tests.isolate

Add a TODO assigned to me to rename ui_unittests target to
ui_base_unittests when buildbot is updated.

It was reverted in commit 6297a2f1,
because a test from ui_unittests in ios_dbg_simulator started to
failing.

BUG=331829,373148,299841,103304
TEST=ui_unittests
R=sky@chromium.org,rohitrao@chromium.org

Review URL: https://codereview.chromium.org/518423002

Cr-Commit-Position: refs/heads/master@{#293134}

The unit test framework brings up blink, so we have an initialized
isolate we can just use.

BUG=none
R=andrewhayden@chromium.org,dmichael@chromium.org

Review URL: https://codereview.chromium.org/537543002

Cr-Commit-Position: refs/heads/master@{#293133}

UserMediaClientImpl's purpose is to implement blink::WebUserMediaClient and does not implement a MediaStream. Thus the class is renamed to reflect this.

BUG=409560

Review URL: https://codereview.chromium.org/524363003

Cr-Commit-Position: refs/heads/master@{#293132}

Review URL: https://codereview.chromium.org/538443003

Cr-Commit-Position: refs/heads/master@{#293131}