GitLab

BUG=350540

Review URL: https://codereview.chromium.org/191883002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255815 0039d316-1c4b-4281-b951-d872f2087c98

BUG=347900

Review URL: https://codereview.chromium.org/190203003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255814 0039d316-1c4b-4281-b951-d872f2087c98

The EventRewriter itself is a MessagePumpObserver now, so it does not have
to depend on XInputHierarchyChangedEventListener to know what device a key
event came from. Remove the relevant method from DeviceHierarchyObserver
interface.

BUG=none
R=derat@chromium.org

Review URL: https://codereview.chromium.org/192123002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255813 0039d316-1c4b-4281-b951-d872f2087c98

This CL implements a different animation for the experimental app list.
The change will allow more views to be added with a default animation
when switching the contents view.

BUG=349727

Review URL: https://codereview.chromium.org/187083004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255812 0039d316-1c4b-4281-b951-d872f2087c98

BUG=347900

Review URL: https://codereview.chromium.org/190423002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255811 0039d316-1c4b-4281-b951-d872f2087c98

This CL adds an ImageView that displays the icon to the
BookmarkAppBubbleView. It also moves the "Open as tab" checkbox to the
same line as the buttons to save on vertical space which was consumed
by the square icon.

BUG=318607

Review URL: https://codereview.chromium.org/184213006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255810 0039d316-1c4b-4281-b951-d872f2087c98

This CL removes all remaining references to the deprecated
device::BluetoothAdapter::StartDiscovering and
device::BluetoothAdapter::StopDiscovering methods. This CL also does
a minor refactor, so that BluetoothAdapter now only tracks active
discovery sessions.

BUG=346985
TEST=Compile chrome; run device_unittests.

Review URL: https://codereview.chromium.org/188473002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255809 0039d316-1c4b-4281-b951-d872f2087c98

They DCHECK during telemetry unittests which run with dchecks enabled.

BUG=350684
NOTRY=True
TBR=ernstm@chromium.org

Review URL: https://codereview.chromium.org/192173002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255808 0039d316-1c4b-4281-b951-d872f2087c98

(*) A "for irt" library, that will get linked into the IRT.
That library just has the auto-generated pnacl_shim.c file.
Also modify ppapi_proxy to include a "irt_shim_ppapi.c",
which makes use of the pnacl_shim.c file to define a private
hook, parallel to the hook provided by irt_ppapi.c.

(*) A "for the browser" library, that the browser-tester
and the PNaCl packager will include for PNaCl-in-the-browser.
This is still called "libpnacl_irt_shim.a" so that we don't
need to change the in-browser linker's commandline. However,
it will be placed in a different directory so that the
Chrome PNaCl packager can pick it up separately from
the AOT library. This for-browser library uses the new hook.

(*) A "AOT" library, that will go into the SDK for offline
pexe -> nexe translation. Still called "libpnacl_irt_shim.a"
as well, confusingly enough, so that we don't need to change
the pnacl-nativeld.py commandlines. Placed in a different
directory from the for-browser library. Does not use the
new hook, so that it only depends on stable interfaces.

BUG= https://code.google.com/p/nativeclient/issues/detail?id=3783
R=binji@chromium.org, dmichael@chromium.org, mseaborn@chromium.org

Review URL: https://codereview.chromium.org/164373010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255807 0039d316-1c4b-4281-b951-d872f2087c98

It fails consistently there.

BUG=350692
NOTRY=True
TBR=alancutter@chromium.org

Review URL: https://codereview.chromium.org/190543007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255806 0039d316-1c4b-4281-b951-d872f2087c98

Similar to the TabCaptureApi.EndToEnd test: An extension is run that generates a rotating cycle of colors and audio tones, and the result is captured and streamed to an in-process Cast receiver.  In addition:

1. Refactored existing code out of the cast_receiver_app into a shared InProcessReceiver class.
2. Added a convenient StandaloneCastEnvironment for test apps.
3. Got rid of the cast_receiver_app prompts since the defaults are used >99% of the time.  Using the --enable-prompts command line arg will show them again.
4. Minor clean-ups in files touched.

NOTE: The new EndToEnd test is being submitted as disabled while outstanding bugs are worked by the team.  Will re-enable once the implementation is sufficiently stable for the bots.

R=hubbe@chromium.org, kalman@chromium.org

Review URL: https://codereview.chromium.org/184813009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255805 0039d316-1c4b-4281-b951-d872f2087c98

(It was only ever given a "true" value once, and even that seemed dubious.)

R=phajdan.jr@chromium.org
TBR=darin@chromium.org, jeremy@chromium.org

Review URL: https://codereview.chromium.org/191483002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255801 0039d316-1c4b-4281-b951-d872f2087c98

R=yzshen@chromium.org

Review URL: https://codereview.chromium.org/190973008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255800 0039d316-1c4b-4281-b951-d872f2087c98

Disabling various IRT interfaces under PNaCl is now done in the NaCl
repo by irt_interfaces.c, as long as pnacl_mode is set to true in
nacl_listener.cc.

BUG=https://code.google.com/p/nativeclient/issues/detail?id=3803
TEST=PnaclExceptionHandlingDisabled, PnaclDyncodeSyscallDisabled
R=jvoung@chromium.org

Review URL: https://codereview.chromium.org/191503002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255799 0039d316-1c4b-4281-b951-d872f2087c98

Because inheritance sucks.

R=sky@chromium.org

Review URL: https://codereview.chromium.org/190943003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255798 0039d316-1c4b-4281-b951-d872f2087c98

According to `purge; sample -wait Chromium` and launching
out/Release/Chromium.app/Contents/MacOS with 30 wikipedia tabs, this reduces
time spent creating the TaskManagerModel (which happens on the IO thread, in
response to raw bytes arriving from the network) from ~100 samples to ~1 sample.
The icon looks slightly different from the icon that Activity Monitor displays,
but a) it looks arguably nicer now (sharp) and b) most people never open the
task manager.

BUG=none
NOTRY=true

Review URL: https://codereview.chromium.org/190533009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255797 0039d316-1c4b-4281-b951-d872f2087c98

Don't force people who want to write multiprocess tests to derive their
test fixture from MultiProcessTest.

TBR=phajdan.jr@chromium.org

Review URL: https://codereview.chromium.org/189373002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255796 0039d316-1c4b-4281-b951-d872f2087c98

We will now use the domAutomationController rather than looking at the
page title. This will confer the following advantages:

- Tests will fail right away when the js detects an error, rather than
  timing out.
- We will get a lot better stack traces when errors do occur.
- The communication path to the tests becomes more flexible with
  possibility for custom return values (for instance if we need to
  verify something in the C++ code or have a multi-stage test).

BUG=None
NOTRY=True

(doing notry since CQ gets stuck on telemetry test on mac_rel)

Review URL: https://codereview.chromium.org/190563002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255795 0039d316-1c4b-4281-b951-d872f2087c98

This fixed the Mac non-component build.

BUG=346766
TEST=Mojo tests (non-component build) work on Mac
R=thakis@chromium.org, viettrungluu@chromium.org

Review URL: https://codereview.chromium.org/188693006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255791 0039d316-1c4b-4281-b951-d872f2087c98

BUG=350517
TBR=ben@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/191863002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255790 0039d316-1c4b-4281-b951-d872f2087c98

Closer inspection of MotionEventAndroid usage revealed that several uncached
properties were being accessed on average 2x or more times per event, incurring
significant JNI costs.  Address this by caching these properties (pointer id,
touch size and touch position) for the most common touch scenarios (scroll and
pinch).  This reduces the time spent processing touch events in the browser by
~20% (.1ms) during scrolling, and ~40% (.2ms) during pinching on a typical
Android device.

BUG=341613
NOTRY=true

Review URL: https://codereview.chromium.org/189693002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255789 0039d316-1c4b-4281-b951-d872f2087c98

BUG=skia:2239
NOTRY=True

TBR=pfeldman@chromium.org

only failing trybot is mac_rel:telemetry_perfm, which has been failing for a while now. This CL is not related to that area, so skipping that try to land it.

Review URL: https://codereview.chromium.org/191333002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255788 0039d316-1c4b-4281-b951-d872f2087c98

This switches the default touch scrolling mode from 'touch cancel on scroll' to our new 'touch move absorption' behavior.  Briefly: touchmove events still aren't sent during active scrolling (for performance reasons), but will be sent when overscrolling.  See https://docs.google.com/a/chromium.org/document/d/1MGuCb0Lb7UfaDmH44bp9YKVG-CVfH6WtKTZl93BXwQw/edit# for details.

This exposes the touch scrolling mode in chrome://flags/#touch-scrolling-mode so that we can easily switch back to the old behavior for diagnostics purposes.  This will be removed after this has reached stable (crbug.com/350430).

Fixes a bug where (depending on timing) we could send one or more extra touchmove events at the start of a scroll sequence.  Now we start every scroll with moves being absorbed and switch to sending move events only after we've seen an unconsumed GestureScrollUpdate.

Fixes a bug where scrolling the top controls (Android) wouldn't mark the GestureScrollUpdate event as consumed.  Adds a unit test covering this and other basic parts of LayerTreeHostImpl's scrolling behavior with respect to top controls.

Updates some tests to support both the original "touchcancel" mode and the new "touchmove absorption" mode.  This way if we uncover problems after branch, we can simply flip the default mode (rather than reverting this entire CL).

BUG=346693
R=aelias@chromium.org, jdduke@chromium.org

Review URL: https://codereview.chromium.org/183013010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255787 0039d316-1c4b-4281-b951-d872f2087c98

It was added in case a test harness needed to point at 
a mock PNaCl component, but that can be done without
the commandline switch.

BUG=none (flags cleanup)

Review URL: https://codereview.chromium.org/189853002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255786 0039d316-1c4b-4281-b951-d872f2087c98

default for writable.

BUG=None
Test=No visible change, cleanup only.
Updated and ran
browser_tests:WebViewTest.Shim_TestWebRequestAPIExistence

Review URL: https://codereview.chromium.org/190483002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255785 0039d316-1c4b-4281-b951-d872f2087c98

It's totally unnecessary (and named shared memory is now deprecated).

R=jam@chromium.org

Review URL: https://codereview.chromium.org/189843009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255784 0039d316-1c4b-4281-b951-d872f2087c98

connection whose handshake was not confirmed when that connection is
closed.

Review URL: https://codereview.chromium.org/183853028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255783 0039d316-1c4b-4281-b951-d872f2087c98

The --nacl-loader-cmd-prefix is no longer useful in practice for injecting a
debugger after this:
https://code.google.com/p/chromium/issues/detail?id=118263
https://src.chromium.org/viewvc/chrome?view=rev&revision=230891

We should drop the switch from chromium.

BUG=350158
TEST=None
NOTRY=true

Review URL: https://codereview.chromium.org/189623003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255782 0039d316-1c4b-4281-b951-d872f2087c98

Reason for revert: caused unit test failures on Mac ASAN bots, eg:
http://build.chromium.org/p/chromium.memory/builders/Mac%20ASan%2064%20Tests%20%281%29/builds/69/steps/base_unittests/logs/FormatNSInteger

> Define print format macros for NSInteger & NSUInteger
> 
> The size of NSInteger and NSUInteger varies between 32-bit and 64-bit
> architectures, however does not provides macro to safely format them
> and instead recommend casting the value to the larger version that is
> used on 64-bit architecture.
> 
> Using a cast could cause some formatting to be missed (if the type of
> a variable changes), so instead we define our own macros to format those
> types safely.
> 
> BUG=349458
> 
> Review URL: https://codereview.chromium.org/187793003

TBR=sdefresne@chromium.org

Review URL: https://codereview.chromium.org/192023002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255781 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255773 0039d316-1c4b-4281-b951-d872f2087c98

BUG=341526

Review URL: https://codereview.chromium.org/180273015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255771 0039d316-1c4b-4281-b951-d872f2087c98

BUG=350446
TEST=none
TBR=sky

Review URL: https://codereview.chromium.org/191233002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255770 0039d316-1c4b-4281-b951-d872f2087c98

The code will run behind the kEnableAudioTrackProcessor flag and the behaviour will be compatible with the existing behaviours.

Since AEC dump can be started only once, so we can't re-create a new instance of MediaStreamAudioProcessor when the format changes. This CL will create the MediaStreamAudioProcessor in the constructor of WebRtcAudioCapturer and call OnCaptureFormatChanged() to the MediaStreamAudioProcessor when the format changes.

BUG=264611
TEST=manual enable aec dump in chrome://webrtc-internals and verify the aec dump audio files.

Review URL: https://codereview.chromium.org/187913002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255769 0039d316-1c4b-4281-b951-d872f2087c98

BUG=348324

Review URL: https://codereview.chromium.org/184223003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255768 0039d316-1c4b-4281-b951-d872f2087c98

If creating the temporary file failed, don't try to open it. If we can't open
it for some reason, delete the temporary so the caller can assume strong
exception safety and not have to delete the file on error.

BUG=none

Review URL: https://codereview.chromium.org/183003009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255767 0039d316-1c4b-4281-b951-d872f2087c98

Add a config.h for FreeBSD, generated by running "../configure" in third_party/libevent/freebsd/ on a FreeBSD 10.0-amd64 system.

For 32-bit FreeBSD systems, SIZEOF_LONG would be 4, but since both systems
have a strtoll() function this does not matter (see libevent/evutil.c).
Taking 8 for SIZEOF_LONG is also in sync with _EVENT_SIZEOF_LONG as
defined in libevent/freebsd/event-config.h

BUG=350396
TBR=cpu

Review URL: https://codereview.chromium.org/183803011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255766 0039d316-1c4b-4281-b951-d872f2087c98

All unit tests suites are now opted into using real NullDraw GL
contexts instead of fake "test contexts". So remove the code to
create test contexts.

Removes the --disable-test-compositor flag as this does nothing
now that no tests use test contexts.

R=sievers@chromium.org
BUG=270918

Review URL: https://codereview.chromium.org/183743014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255765 0039d316-1c4b-4281-b951-d872f2087c98

1. Change the graph from bar-chart to area chat.
Now x-axis shows time line.  It is instinctive.

2. Enable to choose policies in GUI.
It is a waste of time to apply many policies and make different HTML files.
Now it can be done with clicks.  No need to specify a policy in converting json to HTML.

Usage:
$ dmprof /path/to/first.heap > temp.json
$ graph.py temp.json > graph.html  # no need to specify a poilcy
$ chrome graph.html    # open the HTML file in Chrome


BUG=None
NOTRY=true

Review URL: https://codereview.chromium.org/189623009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255764 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255763 0039d316-1c4b-4281-b951-d872f2087c98

0. Roll icu to r249466 to copy Android-specific icudtl.dat
1. Turn it in build/common.gypi by default except for android webview build. Move it inside L2 var dict and pull it up to the top level var dict to make 'Google Chrome' build on Android happy. 
2. Add an entry for icudtl.dat to chrome/chrome_android_paks.gypi so that
it's copied to assets directory for Chrome and related targets. 
3. Extract icudtl.dat from the asset and copy to DIR_ANDROID_APP_DATA and make it world-readable so that child processes (sandboxed with uid) can read it. 
4. Add icudtl.dat to MANDATORY_PAKS list in various Android build targets 

Google Chrome has #4 but in a separate CL ( https://chrome-internal-review.googlesource.com/#/c/155554/ ). That CL will land before this CL. 

This also depends on a Blink change https://codereview.chromium.org/183013006/ 

TBR=avi@chromium.org
BUG=72633
TEST=base_unittests:*Convers*, net_unittests:*IDN*, browser tests on all platforms.
TEST=On Android, 1. Layout tests 
2. build/android/test_runner.py gtest -s webkit_unit_tests 
--gtest_filter=WebFrameTest.SelectRange*

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=253938

Review URL: https://codereview.chromium.org/156333002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255762 0039d316-1c4b-4281-b951-d872f2087c98