- 29 Jul, 2020 40 commits
-
-
zhaoyangli authored
Added the flag to build XCTest based unit test targets to some iOS fyi builders. Will sent follow up CLs to build the targets in all iOS builders. Ignore-CQ-Freeze: true Bug: 1001667 Change-Id: I8521ddafaafcc4424294a27da54e070a2ec4ba94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315638Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org> Cr-Commit-Position: refs/heads/master@{#792552}
-
shrekshao authored
https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/803227b..c1d5cef Tbr: kbr@chromium.org Bug: 1108588, 1110449 Cq-Include-Trybots: luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64 Change-Id: Ifb676b5aec5d658754040f41dac09d6153897e48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2323722Reviewed-by:
Shrek Shao <shrekshao@google.com> Auto-Submit: Shrek Shao <shrekshao@google.com> Commit-Queue: Shrek Shao <shrekshao@google.com> Cr-Commit-Position: refs/heads/master@{#792551}
-
Jared Saul authored
Fixed: 1109857 Change-Id: Ic2d5fe9f43877c488a34c3da06fb405cc38319a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324565Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#792550}
-
Steven Bennetts authored
This includes a small amount of cleanup in the defails page and network-config-toggle. BUG=1093135 Change-Id: I4cfab202ff03cfa544ce13a6152f7fc108882f72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324804 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#792549}
-
Lei Zhang authored
Bug: 477699, 1021350 Change-Id: Iaac4c933d2da01d566c06b3c06b4fa34b306c053 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324865Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#792548}
-
Dale Curtis authored
Mostly just worked already, the way that MIPS scaling was implemented was unnecessarily over-complicated though. Simply always using the Y plane size when scaling yields the same results. This also fixes some typos in the AVIF test file names as well as adds a README.md file for the ones I've updated. Some of which actually needed to be recreated since they were incorrectly labeled. Fixed: 915972 Test: Updated unittests. Change-Id: I7582a41f8dce6af21aaa1b1d2dda182f640297d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2318056Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#792547}
-
Weilun Shi authored
We should set CrOS in os.name for ChromeOS to better identify ChromeOS machines. Bug: 1109204 Change-Id: I7808ff53ef0743aa35eff888a145f2d53206b100 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315433 Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Auto-Submit: Weilun Shi <sweilun@chromium.org> Cr-Commit-Position: refs/heads/master@{#792546}
-
Claude van der Merwe authored
BSSID was displayed as lower case because of missing localization in chromeos_strings.grdp Bug: 1041699 Change-Id: Ic16c307d639559a645f84d49dba5d3360b700b6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324171 Commit-Queue: Claude van der Merwe <cvandermerwe@google.com> Reviewed-by:
Jon Mann <jonmann@chromium.org> Cr-Commit-Position: refs/heads/master@{#792545}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/b394db45e6e6..39d1c1ebb607 2020-07-28 reed@google.com Revert "Never share pixels when we make a subset image" 2020-07-28 reed@google.com Never share pixels when we make a subset image 2020-07-28 johnstiles@google.com Use SkScalar type where appropriate. 2020-07-28 johnstiles@google.com Add missing #includes. 2020-07-28 robertphillips@google.com Skip the compressed_texture* GMs on the Pixel3 2020-07-28 mtklein@google.com JIT functions taking six pointers 2020-07-28 mtklein@google.com fix r12 2020-07-28 robertphillips@google.com Fix up image-cacherator-from-* GMs for direct context If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC borenet@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: borenet@google.com Change-Id: I690f2e10ae66160e23b756d7a43712cb873df491 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324308Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#792544}
-
Junji Watanabe authored
This reverts commit 93873650. Reason for revert: The mixin isn't necessary anymore. Ignore-CQ-Freeze: true Original change's description: > [mac-rel-swarming] add arm-64 Mac to the target bots > > ARM Mac bots have 'arm64' cpu dimension. > https://chromium-swarm-dev.appspot.com/bot?id=build201-a9 > > Adding Ignore-CQ-Freeze because this isn't for production. > > Ignore-CQ-Freeze: true > Bug: 1103470 > Change-Id: I3d3713909994a88224aec6c9eaf48e9d0890d2ab > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320714 > Commit-Queue: Junji Watanabe <jwata@google.com> > Reviewed-by: Ben Pastene <bpastene@chromium.org> > Reviewed-by: Erik Staab <estaab@chromium.org> > Reviewed-by: Takuto Ikuta <tikuta@chromium.org> > Auto-Submit: Junji Watanabe <jwata@google.com> > Cr-Commit-Position: refs/heads/master@{#792461} TBR=estaab@chromium.org,martiniss@chromium.org,tikuta@chromium.org,bpastene@chromium.org,jwata@google.com,yekuang@google.com Change-Id: Ic96fb6dbb7934065cffeb637c132d23ff3202c0f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1103470 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2325452 Auto-Submit: Junji Watanabe <jwata@google.com> Reviewed-by:
Erik Staab <estaab@chromium.org> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Erik Staab <estaab@chromium.org> Cr-Commit-Position: refs/heads/master@{#792543}
-
Mehran Mahmoudi authored
This records the remaining required histogram and user actins for the startup experiment. Bug: 1109991 Change-Id: Id1875ba20e61f667d4de15d7448222099a287d96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320888 Commit-Queue: Mehran Mahmoudi <mahmoudi@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Calder Kitagawa <ckitagawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#792542}
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/8c11e26c0dfd..d6a5a2271e6e 2020-07-29 mfoltz@chromium.org [Open Screen] Adds a unit test for logging macros. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jophba@chromium.org Change-Id: Ie3c22038cf315a34bfc5eca926fca9d4bd683a36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2325241Reviewed-by:
-
Yury Semikhatsky authored
After calling Browser.setWindowBounds values of the window.outerWidth/outerHeight are now updated to reflect new bounds. In headless browser WebContentsViewMac is created with null WebContentsViewDelegate hence there is no top level native window. In this change we pretend that there is such window and propagate its using newly introduced SetWindowFrameInScreen method. Bug: none Change-Id: I3bb4338ed28c2d477736bc1cc5976b873a3061d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321409 Commit-Queue: Yury Semikhatsky <yurys@chromium.org> Auto-Submit: Yury Semikhatsky <yurys@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#792540}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ie205fb21acb4c9047996ee73f73155d4e17bbb8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324970Reviewed-by:
-
Lukasz Anforowicz authored
Bug: 1110458 Change-Id: I3d3d6b42fec5c872c84c0e72c07da1d634b53769 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324885 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#792538}
-
David Maunder authored
UserData is a pattern to enable fields to be moved out of Tab to classes which implement the UserData interface to avoid Tab becoming too large. Bug: 1105236 Change-Id: Ia3a2bf65a4860d5eeee9d01b01c9274c03ea85c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306214 Commit-Queue: David Maunder <davidjm@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#792537}
-
rbpotter authored
In an attempt to not match the setting too easily and restore a size the printer didn't support (see https://crbug.com/924488), Print Preview required two media sizes from different printers to match exactly, or the size would be reset to the printer default when the destination was changed. This CL allows any media sizes reporting the exact same dimensions to match, which will allow the user's selected paper size to be persisted across different destinations more often. Note that in certain cases, different destinations have similarly named paper sizes that may correspond to the same standardized size, but report slightly different dimensions for these sizes to Print Preview. This CL does not change the behavior for those cases, as it may be infeasible to distinguish such cases from printers with very similar reported sizes that correspond to different physical paper sizes, particularly given that custom user paper sizes are supported by a large number of printers. Bug: 1108661 Change-Id: I42794fd1b80f34bcd277c111a66aeeb49239e71d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321965 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/12c9d4ac61f2..4e39779a5662 2020-07-28 amaiorano@google.com Add CMake script to setup and build ANGLE 2020-07-28 amaiorano@google.com Add ANGLE as submodule If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: Id9dfd94a53362ef99a22d3f3dab756055e697eed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324862Reviewed-by:
-
Brian Sheedy authored
Disables the Telemetry minidump symbolization tests on Mac, as they are currently failing on some 10.15.5 machines due to Xcode not being set up properly for Telemetry tests, and newly reinstalled machines do not have a system-wide installation anymore. TBR=johnchen@chromium.org Bug: 1110441 Change-Id: I2e9f3d33a1086db24c07f167f5ab376a2a564146 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324606Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#792534}
-
Yuchen Liu authored
Add "app", "multizone", which are needed when talking to chromecast service. Bug: internal b/161738703 Test: Run cast_shell without crash Change-Id: I47082f4b48ed167d29db1c8ce5f63027fd8eeea2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324761Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Yuchen Liu <yucliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#792533}
-
Sebastien Marchand authored
This memory pressure handler has been observed to be quite slow some times, this will let us diagnose how much of a problem this is in practice. Bug: 1109982 Change-Id: Id967ec8a79abd25c2a294002f852583bc49714ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320411 Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#792532}
-
Will Harris authored
This avoids the delay load helper being run inside the closure callback which can cause CFG violations. BUG=1110484 Change-Id: Iff7fd304f99662b0204ac4d2e1b1fc4b896cc990 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324570 Commit-Queue: Will Harris <wfh@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#792531}
-
Kenichi Ishibashi authored
This CL: * Pack extension in PRE_EventsAfterRestart to prevent reloading an extension quickly, similar to crrev.com/c/2318508 * Disable TabsQuery* and TabsOnUpdated* tests as these become flaky when mojofied service worker storage is used These are preparations for using mojo version of service worker storage's GetNewRegistrationId(). Bug: 1091141 Change-Id: I1239627087ec321af794a75788d43270f7c31fc9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321988Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#792530}
-
James Cook authored
The Chrome OS default for "On Startup" is "Continue where I left off". Use the same default for Lacros. In theory we would get this for free when Lacros starts using the OS_CHROMEOS macro. However, I think the macro conversion process is going to start with a bulk conversion of UI-layer Chrome OS code to IS_ASH, so I suspect we'll need the IS_LACROS check anyway. Bug: 1109050 Test: with a new profile, "Continue where I left off" is the default Change-Id: I5015ea9bfcaaa4108a147c0cb3c0347fe0acdabf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316804Reviewed-by:
Darin Fisher <darin@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#792529}
-
Rakina Zata Amni authored
This reverts commit f672068e. Reason for revert: Caused failing test https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-rel/40039 Original change's description: > [LiteVideo] Rework UKM to record on DidFinish and WCO destruction. > > This change resolves the UKM recording and ties it just to the > mainframe decision and result. It also flushes when the web contents > observer destructs. A future change will update the event on > rebuffers and consider more events for subframes. > > Bug: 1109068 > Change-Id: Iacd04920811d96c4eedd3290309a8bad93777b58 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321520 > Auto-Submit: Michael Crouse <mcrouse@chromium.org> > Commit-Queue: rajendrant <rajendrant@chromium.org> > Reviewed-by: rajendrant <rajendrant@chromium.org> > Reviewed-by: Tarun Bansal <tbansal@chromium.org> > Cr-Commit-Position: refs/heads/master@{#792513} TBR=tbansal@chromium.org,rajendrant@chromium.org,mcrouse@chromium.org Change-Id: Ic8ccef2431cb402a285edd00b29cf78d44b03ab9 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1109068, 1110739 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2325295Reviewed-by:
Rakina Zata Amni <rakina@chromium.org> Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Cr-Commit-Position: refs/heads/master@{#792528}
-
Nicholas Verne authored
Hide the illustration when there's a progress bar. This is to stop the visual noise when the illustration moves downwards. Bug: 1103505 Change-Id: I9d144abe21207ff3ab0fec0f7258d15eea317db0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321887 Auto-Submit: Nicholas Verne <nverne@chromium.org> Commit-Queue: David Munro <davidmunro@google.com> Reviewed-by:
David Munro <davidmunro@google.com> Cr-Commit-Position: refs/heads/master@{#792527}
-
Sara Kato authored
Test: AccessibilityNodeInfoDataWrapperTest, AXTreeSourceArcTest passes Bug: b/162279773 Change-Id: Ib89e771a0da05ec5ee629b13a810e423ef052a1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2322287Reviewed-by:
Hiroki Sato <hirokisato@chromium.org> Commit-Queue: Sara Kato <sarakato@chromium.org> Cr-Commit-Position: refs/heads/master@{#792526}
-
Hirokazu Honda authored
media/gpu/video_decode_accelerator_tests: Use a parser to check if a bitstream has a stream configuration EncodedDataHelper::HasConfigInfo() checks if a vp8 and vp9 stream has a stream configuration by checking the first bit of the stream. This is correct for vp8, but wrong for vp9. Thus it always returns true in vp9 stream. This bug is not critical because video_decode_accelerator_tests checks if there is a stream configuration, but doesn't check the count. This CL fixes the bug by using parsers for vp8 and vp9 both as well as for h264. Bug: None Test: video_decode_accelerator_tests on atlas Change-Id: Id1b784e087a102ece40b704d876f0796c0edbc53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2319519 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
David Staessens <dstaessens@chromium.org> Cr-Commit-Position: refs/heads/master@{#792525}
-
Joe DeBlasio authored
This CL makes a tiny tweak to safety tips to ensure that the reputation callback aborts on error pages, even when reputation is checked on visibility change. It also fixes a race condition in the tests that somehow hadn't made the existing tests flaky, but came up in the new test. Fixed: 1019228 Change-Id: Ic31c66cf2db6db2ca59c12a0a33f7173fded438a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324866 Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#792524}
-
David Black authored
Bug: 1109819, 1109820, 1109842, 1109843, 1109844 Bug: 1109845, 1109846, 1109847, 1109848, 1109849 Bug: 1109850 Change-Id: Ie117ac625c9e8573145823f30d39337bef568dbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320988Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
-
Rakina Zata Amni authored
This reverts commit e22976af. Reason for revert: Causes test failure at https://ci.chromium.org/p/chromium/builders/ci/linux-blink-cors-rel/7409 Original change's description: > [Nearby] Add NearbyShareSettings mojo for use in settings and webui > > |NearbyShareSettings| provides a strongly typed wrapper over the raw > user prefs and allows clients to observe individual changes. This class > also implements a mojo interface to allow multiple WebUIs to access > settings (OSSettingsUI, NearbyShareDialog, and eventually SettingsUI). > > This CL achieves sharing of mojos and the components that depend on them > outside of chrome://resources by having the shared resources hosted in > chrome://nearby and re-registering them in chrome://os-settings. This > gets around having to include explicit references to the mojo generated > resources in //content which required a DEPS exception that was not > acceptable to //content/OWNERS. > > Many other options were considered to solve this shared resource > problem. Please see the dicussion thread for more context: > http://g/chrome-webui/Q8WGiGO7h-E > > Change-Id: I831044176ed71b15fb7df0be8f1c393e574254f1 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317166 > Commit-Queue: James Vecore <vecore@google.com> > Reviewed-by: James Vecore <vecore@google.com> > Reviewed-by: Alex Gough <ajgo@chromium.org> > Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> > Reviewed-by: Josh Nohle <nohle@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Richard Knoll <knollr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#792503} TBR=sky@chromium.org,khorimoto@chromium.org,nohle@chromium.org,knollr@chromium.org,ajgo@chromium.org,vecore@google.com Change-Id: I6168c5dbc8419370bac8c87fb7caa43068ad90c7 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1110578 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2325433Reviewed-by:
-
David Roger authored
This CL: - plumbs the account info from C++ to javascript - updates the javascript to show the avatar and name - implements the WebUI handler and listen to account changes Screenshot: https://drive.google.com/file/d/1um4ddQvSLoDidpdOWKjk5gHDmfWG5vSy/view?usp=sharing Screenshot in dark mode: https://drive.google.com/file/d/1GstEo8oYBI7wLuTdxprIwJGlH4yiYWyR/view?usp=sharing (Note that the account name does not have enough contrast, this will be fixed later) Bug: 1076880 Change-Id: I81f2b90723fafa25b33b4e326e6b2a17fc28dbb0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315136 Commit-Queue: David Roger <droger@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Monica Basta <msalama@chromium.org> Auto-Submit: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#792521}
-
Dale Curtis authored
Per discussion when we tried to enable these for VAAPI: https://chromium-review.googlesource.com/c/chromium/src/+/2303676 Many of these workarounds are specific to early VP9 decoder hardware, not VP8. Since we are enabling VP8 decode now, we should be precise about what needs to be disabled. R=tmathmeyer, zmo Bug: 1066176, 654111, 616318, 1062849 Test: None. Change-Id: I7615a279e451cb7acef62c74cb0fc2e21ba898d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2325091 Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Ted Meyer <tmathmeyer@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#792520}
-
Eugene But authored
Logs are 100% true. Replaced metric with call to check, so next time if this crash we know that ChromeBrowserProvider is not a culprit. Bug: 1097827 Change-Id: Ib0107fe9a8495c71843cb9d8055a19c0b341e598 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320808Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
-
Travis Skare authored
Bug: 1109649 Change-Id: I319cebee36eee81087bf8b19f2f04bc0bac8190a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321766 Commit-Queue: Travis Skare <skare@chromium.org> Reviewed-by:
Tanya Gupta <tgupta@chromium.org> Cr-Commit-Position: refs/heads/master@{#792518}
-
Jing Wang authored
The cases are given by laurentt@ in https://docs.google.com/spreadsheets/d/1zcRwSCQUbiA4Czp9JBY_QpFl-f1Mtulm9hL6GOY-c7Q/edit#gid=1364923800 No longer emit kPersonalNumber metrics, merged it into kPersonalPhoneNumber metrics. Refactor ProposeAssistiveAction a bit by using early return. Randomly add some new cases in tests. Bug: 1109073 Change-Id: I6ed3de18eafcf9fae30eade609187ff6c47faa31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2318491 Commit-Queue: Jing Wang <jiwan@chromium.org> Reviewed-by:
David Vallet <dvallet@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#792517}
-
Rachel Carpenter authored
We just wanted to experiment with a group of users in M85, all new users from M86 onwards should get the default behaviour. We do still want the users that are already part of an experiment group to continue to see the changed behaviour for a couple of milestones to check longer term usage. Will clean up/remove the trial after that. Bug: b/161170571,b/158540665 Change-Id: I85ea81c42b7b9d7439c6128a1e4f5830546d88d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324090 Commit-Queue: Rachel Carpenter <carpenterr@chromium.org> Reviewed-by:
-
Avi Drissman authored
Bug: 1105907 Change-Id: I4592e1b2a5bf1ebb69a176049a7cfd1126138c91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2325239Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#792515}
-
Avi Drissman authored
Bug: 1105907 Change-Id: I6d51dab7e6c30fbc1a9fca20255ad3b1d92b89d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324896Reviewed-by:
-
Michael Crouse authored
This change resolves the UKM recording and ties it just to the mainframe decision and result. It also flushes when the web contents observer destructs. A future change will update the event on rebuffers and consider more events for subframes. Bug: 1109068 Change-Id: Iacd04920811d96c4eedd3290309a8bad93777b58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321520 Auto-Submit: Michael Crouse <mcrouse@chromium.org> Commit-Queue: rajendrant <rajendrant@chromium.org> Reviewed-by:
rajendrant <rajendrant@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#792513}
-
