- 26 Sep, 2018 40 commits
-
-
Zhongyi Shi authored
Add finch config param for cronet and Chrome to retry QUIC connection on the alternate network before handshake. The feature will be controlled by "retry_on_alternate_network_before_handshake". Bug: 790547 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;master.tryserver.chromium.android:android_cronet_tester Change-Id: I5812083fe317f996313adce49f9bbd1d14b22f37 Reviewed-on: https://chromium-review.googlesource.com/1242038Reviewed-by:
Misha Efimov <mef@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Misha Efimov <mef@chromium.org> Cr-Commit-Position: refs/heads/master@{#594386}
-
Joanmarie Diggs authored
* Implement support for Event::LOAD_COMPLETE, firing AtkDocument load- complete and AtkObject state-change events. * Create Event::LOAD_START, and fire AtkObject state-change events. * Try to filter out load changes we don't want to fire an event for, e.g. pages which lack size. This saves each AT from having to filter these (presumed) irrelevant events out. TBR=slan@chromium.org Bug: 866331, 866333 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I2f97563b5c2160793a09588481bd2bacf0f0eae1 Reviewed-on: https://chromium-review.googlesource.com/1234228 Commit-Queue: Joanmarie Diggs <joanmarie.diggs@gmail.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#594385}
-
Doug Arnett authored
Checks experiment_name field on Optimization defined at PageHint level and only whitelists if that experiment name is enabled for the client. Bug: 888666 Change-Id: I42425aaf9403a023d684c94ce94860cba27513f2 Reviewed-on: https://chromium-review.googlesource.com/1241214Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Doug Arnett <dougarnett@chromium.org> Cr-Commit-Position: refs/heads/master@{#594384}
-
erikchen authored
By default, webkit_layout_test failurse are retried 3 times. But when '--test-list' is passed, the retry count defaults to 0. To simplify the logic, this CL makes it so that webkit_layout_test failures are always retried 3 times. Bug: 888734 Change-Id: I46d15d71c979e5f12f334f5dcff41637f3f3aef4 Reviewed-on: https://chromium-review.googlesource.com/1244018 Commit-Queue: Erik Chen <erikchen@chromium.org> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#594383}
-
Ahmed Fakhry authored
Despite the fact that the docked magnifier feature is enabled by default, some users may explicitly disable it, which will cause crashes if the docked magnifier controller is accessed without checking that it exists. BUG=880428 Change-Id: I551edf47184e7c2fa79c4ebf72843758e5ef948c Reviewed-on: https://chromium-review.googlesource.com/1245731 Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#594382}
-
Evan Stade authored
Disabling due to flake: NavigationControllerBrowserTest.UtilizationOfSpareRenderProcessHost TBR=xiyuan@chromium.org Bug: 888156 Change-Id: Ice1001691d141c2ffb2cec2399dffe8855acdf3a Reviewed-on: https://chromium-review.googlesource.com/1246145Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#594381}
-
Saman Sami authored
Updating the fallback lowerbound is not necessary anymore and will just waste time by causing an unnecessary commit and draw. Bug: 870456 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: Icd553c179c5a2eb98c1608524d9c1caf42a27835 Reviewed-on: https://chromium-review.googlesource.com/1226366 Commit-Queue: Saman Sami <samans@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#594380}
-
Evan Stade authored
TBR=dpapad@chromium.org Bug: 887721,711256 Change-Id: I57a9bac7415bf0a3439c6b85e8f1228ceca7d41b Reviewed-on: https://chromium-review.googlesource.com/1246142Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#594379}
-
Morten Stenshorne authored
We want to test this with LayoutNG. Skip failing tests on NG (there are two). Bug: 889449 Change-Id: I3b80eb07d9dc359d24ab63417c3ca2ac228c1496 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Reviewed-on: https://chromium-review.googlesource.com/1245793Reviewed-by:
Steve Kobes <skobes@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#594378}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/a602f9064b3e..c84510f4a313 git log a602f9064b3e..c84510f4a313 --date=short --no-merges --format='%ad %ae %s' 2018-09-26 estevenson@chromium.org Angle: Remove obsolete requires_sdk_api_level_23 from BUILD.gn. Created with: gclient setdep -r src/third_party/angle@c84510f4a313 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:688465 TBR=syoussefi@chromium.org Change-Id: I5b9c1211a44f0edb8f7ff124c7def44604595ff2 Reviewed-on: https://chromium-review.googlesource.com/1246261Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#594377}
-
Fredrik Söderquist authored
Markers don't actually have any per-client caches, so all this code does is trigger a call to SetNeedsBoundariesUpdate - but if a marker was changed this flag would already be set. Hence worst case we may end up updating more than need (update the shape when only the transform changed for instance.) Not generally a huge deal, but also not good. Bug: 225808, 534817 Change-Id: I4d958cbc700c101a471c4ced1d79591cd1f2ebc9 Reviewed-on: https://chromium-review.googlesource.com/1245709Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#594376}
-
Nico Weber authored
Bug: 832676 Change-Id: I9b56c47523765af4b33a997b65fe2a48a9da7f29 Reviewed-on: https://chromium-review.googlesource.com/1246324Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#594375}
-
Theresa authored
BUG=889285 Change-Id: If0210b1b934a2651e664af3d18268f453872d591 Reviewed-on: https://chromium-review.googlesource.com/1246143Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#594374}
-
Olivier Robin authored
This feature will still be controlled by frame messaging. Bug: 881364 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Ibdf1c1c6ed616475a1d6d2c45929831a2c5fe5e9 Reviewed-on: https://chromium-review.googlesource.com/1245728Reviewed-by:
Eric Noyau <noyau@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#594373}
-
Moe Ahmadi authored
This reverts commit dfd34b91. Reason for revert: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Fuchsia%20ARM64%20Cast%20Audio/37042 https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Fuchsia%20x64%20Cast%20Audio/36915 Original change's description: > [fuchsia] Generate BUILD.gn from SDK metadata, migrate FIDL targets. > > This script uses the metadata JSON files in the SDK to generate a > BUILD.gn in //third_party/fuchsia-sdk/sdk. The build file is > regenerated whenever a new SDK is downloaded using "gclient sync". > > Only FIDL libraries are migrated for now. Additional metadata types can > be migrated in followup CLs. > > > Bug: 888753 > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel > Change-Id: If87010006cd23e90d970da4cb84e6de35804b7dd > Reviewed-on: https://chromium-review.googlesource.com/1241842 > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Sergey Ulanov <sergeyu@chromium.org> > Reviewed-by: Scott Graham <scottmg@chromium.org> > Commit-Queue: Kevin Marshall <kmarshall@chromium.org> > Cr-Commit-Position: refs/heads/master@{#594360} TBR=sky@chromium.org,kmarshall@chromium.org,sergeyu@chromium.org,scottmg@chromium.org Change-Id: If818310da713c18990fbed0f6c006bb90d41100d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 888753 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/1246296Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/ad59bc2906ca..09a2951f46c3 git log ad59bc2906ca..09a2951f46c3 --date=short --no-merges --format='%ad %ae %s' 2018-09-26 lalitm@google.com Merge "trace_processor: make schema more explicit in tables" Created with: gclient setdep -r src/third_party/perfetto@09a2951f46c3 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: Id385b0e45ea5343f1175dc47f6272355ae3b47a8 Reviewed-on: https://chromium-review.googlesource.com/1246223Reviewed-by:
-
Evan Stade authored
on single process mash browser tests. TBR=lethalantidote@chromium.org Bug: 887175 Change-Id: I9c9963dfafff46e082fd6a4748e66549b7094dd4 Reviewed-on: https://chromium-review.googlesource.com/1246288 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/29447ec5203f..4977a156c2fc Created with: gclient setdep -r src-internal@4977a156c2fc The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I48c3a068aee52785070e8c865b82bda327055511 Reviewed-on: https://chromium-review.googlesource.com/1246121Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#594369}
-
Steven Valdez authored
Change-Id: I9618c48fbdaa277070e67f3f1371eba341df00e8 Reviewed-on: https://chromium-review.googlesource.com/1244556Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Commit-Queue: Steven Valdez <svaldez@chromium.org> Cr-Commit-Position: refs/heads/master@{#594368}
-
Eugene But authored
This will allow to offer more extensions in Open In... dialog. F.e. after this change Contacts extension will be offered for VCF files. Uniform type identifiers (UTIs) provide a unified way to identify data handled within the system, such as documents, pasteboard data, and bundles: https://developer.apple.com/library/archive/documentation/FileManagement/Conceptual/understanding_utis/understand_utis_conc/understand_utis_conc.html Bug: 604533 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I75a0864633023a1cd844582f08b5034bc447a65b Reviewed-on: https://chromium-review.googlesource.com/1244606 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#594367}
-
Kevin Marshall authored
Now that the SDK has all of the necessary dependencies to run Chromium WebRunner, the install procedure is now reasonable and can be documented. Change-Id: I009a74d48673c3ea4126cc593db177ba23ede715 Reviewed-on: https://chromium-review.googlesource.com/1226461 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#594366}
-
Leonard Grey authored
macOS 10.14 changed the method signature of a block parameter to application:continueUserActivity:restorationHandler: by introducing a lightweight generic. Since the parameter is unused and the protocol specified by the new generic is 10.14+, this change ignores the mismatched parameter. Bug: 887214 Change-Id: I4a111cdb69ac4fcc22a78448b3efb5bc7c0536e9 Reviewed-on: https://chromium-review.googlesource.com/1246322Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#594365}
-
Torne (Richard Coles) authored
Remove the old variable names now that downstream is using the new, consistent-with-Chrome names. Change-Id: I55a3e80c25b30b505504ff5268ec86da39a0e2c5 Reviewed-on: https://chromium-review.googlesource.com/1241015Reviewed-by:
Changwan Ryu <changwan@chromium.org> Commit-Queue: Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#594364}
-
Hans Wennborg authored
The builds were failing like: ERROR at //third_party/crashpad/crashpad/util/BUILD.gn:657:20: Item not found sources -= [ "stdlib/string_number_conversion_test.cc" ] ^---------------------------------------- You were trying to remove "stdlib/string_number_conversion_test.cc" from the list but it wasn't there. See //chrome/installer/setup/BUILD.gn:114:7: which caused the file to be included. "//third_party/crashpad/crashpad/util", ^------------------------------------- GN gen failed: 1 thakis excluded this file in https://chromium-review.googlesource.com/1113664 jperaza then upstreamed that in https://chromium-review.googlesource.com/c/crashpad/crashpad/+/1195567 but put it outside the crashpad_is_win clause When the upstream change was rolled into chromium in https://chromium-review.googlesource.com/c/chromium/src/+/1195670 we ended up with the file exclusion *both* in the crashpad_is_win_clause and outside it, causing this gn error. Bug: 856174 Change-Id: I5b812567e6a9be54ce622b9a221b61dc6a27f1b6 Reviewed-on: https://chromium-review.googlesource.com/1245463Reviewed-by:Scott Graham <scottmg@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#594363}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/bdf1431686c2..90b47106a6e1 git log bdf1431686c2..90b47106a6e1 --date=short --no-merges --format='%ad %ae %s' 2018-09-26 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 6aad6a769d20..d73b871379e0 (1 commits) 2018-09-26 jvanverth@google.com Make line distance more robust Created with: gclient setdep -r src/third_party/skia@90b47106a6e1 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=bsalomon@chromium.org Change-Id: I1e5ef576cbe8fd2299e449f717a2a2b50832cf7b Reviewed-on: https://chromium-review.googlesource.com/1246262Reviewed-by:
-
Peter E Conn authored
Bug: 871266 Change-Id: I142b570be0a17df00d9b43cf96fddc8c09c21a0d Reviewed-on: https://chromium-review.googlesource.com/1238463 Commit-Queue: Peter Conn <peconn@chromium.org> Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#594361}
-
Kevin Marshall authored
This script uses the metadata JSON files in the SDK to generate a BUILD.gn in //third_party/fuchsia-sdk/sdk. The build file is regenerated whenever a new SDK is downloaded using "gclient sync". Only FIDL libraries are migrated for now. Additional metadata types can be migrated in followup CLs. Bug: 888753 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: If87010006cd23e90d970da4cb84e6de35804b7dd Reviewed-on: https://chromium-review.googlesource.com/1241842Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
-
Mohamed Amir Yosef authored
Android instrumentation tests detect folder by the absence of the url field in the produced JSON for debugging. Therefore, the produce specifics from BookmarkNode shouldn't have url set at all instead of assigning an empty url. Bug: 516866 Change-Id: Ia61ebf6d67c04c2b2accad5f8ffc73c9125f0355 Reviewed-on: https://chromium-review.googlesource.com/1243810 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#594359}
-
Becky Zhou authored
Bug: 888129 Change-Id: I4000a8b4f25e1a853d882090cdc3a09e8719dd7b Reviewed-on: https://chromium-review.googlesource.com/1246464Reviewed-by:
-
Daniel Bratell authored
This caused a link error, duplicate symbols, in a jumbo build experiment. How it ever worked in normal builds we'll never know. Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I4136a153aa989f2187d745f291658ac4e05fa6db Reviewed-on: https://chromium-review.googlesource.com/1244461Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/d9004e51..ba614d6f Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: If55c7a37c139e0af92164493d8ea90dcd1ac8e1c Reviewed-on: https://chromium-review.googlesource.com/1246242Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#594356}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/846ae9bff247..8498332d304e git log 846ae9bff247..8498332d304e --date=short --no-merges --format='%ad %ae %s' 2018-09-26 cphlipot0@gmail.com trace-viewer: Fix crash in timeline process filter. Created with: gclient setdep -r src/third_party/catapult@8498332d304e The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I912956dea10c8a919992c0999d4e53e4620834f2 Reviewed-on: https://chromium-review.googlesource.com/1246141Reviewed-by:
-
Devlin Cronin authored
As mentioned here: https://chromium-review.googlesource.com/c/chromium/src/+/1222917/5/chrome/browser/apps/platform_apps/api/easy_unlock_private/easy_unlock_private_api.h#36 TBR=thestig@chromium.org (c/b/browser_process_impl.cc, c/test/base/, c/common/) TBR=msarda@chromium.org (c/b/profiles/) TBR=achuith@chromium.org (c/b/chromeos/login/) Bug: None Change-Id: I37d5fc0aec77e539e7decbd6de3b948e0205bda8 Reviewed-on: https://chromium-review.googlesource.com/1228949 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#594354}
-
danakj authored
This moves RenderViewImpl-specific code out of RenderWidget up into RenderViewImpl. RenderViewImpl does the message to the ViewHost to get the RenderWidget's routing id, and sets up the ShowCallback to itself. This also centralizes the widget creation responsibility in RenderView as we have done for the RenderViewHost side. R=ajwong@chromium.org, dcheng@chromium.org, piman@chromium.org Bug: 419087 Change-Id: Ic4fa4a1a1c73368f108550db4c15dc2b23e842ce Reviewed-on: https://chromium-review.googlesource.com/1231825Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Albert J. Wong <ajwong@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#594353}
-
Roman Sorokin authored
* Use oobe-dialog instead of gaia-card To try follow go/streamlinesteps BUG=chromium:865474, chromium:853571 TEST=manual + existing tests TBR=poromov@chromium.org Change-Id: Ibd59001096b5378f69a61a41cb7a9e14a7c5f32f Reviewed-on: https://chromium-review.googlesource.com/1151305 Commit-Queue: Roman Sorokin <rsorokin@chromium.org> Reviewed-by:
Roman Sorokin <rsorokin@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#594352}
-
Nicolas Pena authored
There is a spike in M69 in crashes caused by assuming that |document_loader| is not null during a call to WindowPerformance::CreateNavigationTimingInstance. Remove the DCHECK and add a null check. Bug: 889020 Change-Id: Ib07ca35810f4512cb251311fb82aee5b5cce17d8 Reviewed-on: https://chromium-review.googlesource.com/1246081Reviewed-by:
-
Max Moroz authored
This requires that fuzz targets use "-fsanitize=fuzzer-no-link" instead of "-fsanitize=fuzzer". All Chromium fuzz targets should do this already; projects rolling in this change need to change from the latter to the former. Removes 1.7MB library on Linux, 1.5MB on Mac, 7.7MB on Windows Bug: 870331 Change-Id: I124207477d0e8338f0502a794200edcd5102bd45 Reviewed-on: https://chromium-review.googlesource.com/1244802 Commit-Queue: Max Moroz <mmoroz@chromium.org> Reviewed-by:
Jonathan Metzman <metzman@chromium.org> Cr-Commit-Position: refs/heads/master@{#594350}
-
Sylvain Defresne authored
To allow incremental conversion from function pointer to callbacks, add overloads to BKCSF's SetTestingFactory and SetTestingFactoryAndUse that receive a base::Callback<> instead of a function pointer. Bug: 809610 Change-Id: I6d29e85a6711ba99b0d84aa5cb7355b26fbb4779 Reviewed-on: https://chromium-review.googlesource.com/1243072 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#594349}
-
Ivan Šandrk authored
Currently the description incorrectly states that the policy defaults to the old "Public Sessions" behaviour (it actually defaults to the new "Managed Sessions" behaviour), correct it. The policy is named DeviceLocalAccountManagedSessionEnabled. Bug: 865947 Change-Id: I018f6cf2769e7b860682a0f2e61fe814d2566811 Reviewed-on: https://chromium-review.googlesource.com/1240537Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Ivan Šandrk <isandrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#594348}
-
Sigurdur Asgeirsson authored
Bug: 874968 Change-Id: Ifefec30eb6701cd6da584c54682fd4488a7e3527 Reviewed-on: https://chromium-review.googlesource.com/1246282Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#594347}
-
