- 14 Nov, 2019 22 commits
-
-
Alexey Baskakov authored
Improve WebAppSyncBridge::UpdateSync to use both current_state (before commit) and new_state (to be commit). In the future, it will help to skip local updates which don't touch sync data. Add WebAppSyncBridge::CommitUpdate unit tests (a.k.a. Local Changes). These tests is a promised follow up for this CL: https://chromium-review.googlesource.com/c/chromium/src/+/1830494 This code is disabled by default behind kDesktopPWAsWithoutExtensions and kDesktopPWAsUSS base features. Bug: 860583 Change-Id: I51dfda8b6364e15f9b5eb398321d6010241b0ae9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1914005Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#715133}
-
Nate Fischer authored
This configures AwMetricsServiceClient to "wake up" the MetricsService the same way Chrome's client does. This listens to the content-layer events for page load start/stop, renderer hangs, and closed renderer processes. This also adds an integration test to verify this works as expected (for the page load start case), and adds plumbing to configure the upload interval in the test (because the commandline switch is rate-limited to a 20 second minimum to avoid DOS'ing the server). Bug: 1003204 Test: run_webview_instrumentation_test_apk -f AwMetricsIntegrationTest.* Test: Manual - verify renderer hang case by using the AndroidX demo app Test: (which supports triggering and recovering from renderer hangs) Change-Id: I1f19f89cbc3625d4911755a2b17dd82908c2bb62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900613 Commit-Queue: Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Cr-Commit-Position: refs/heads/master@{#715132}
-
Karan Bhatia authored
This CL moves some logic from ExtensionUrlPatternIndexMatcher to its base class, the RulesetMatcherInterface. In a subsequent CL, this common logic will also be used by RegexRulesMatcher, which will evaluate regex rules. This CL is split off of https://chromium-review.googlesource.com/c/chromium/src/+/1892132 for ease of review. It has no behavior change. BUG=974391 Change-Id: I2073ed480e5f15611ce2ba4eb1ea29cf7de7f0a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1910875 Auto-Submit: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#715131}
-
Christopher Grant authored
The last change to this script had issues in cases where an APK can't be found or isn't specified. TBR'ing Andrew to get this in quickly, as it's trivial fixes but potentially disruptive to bots. TBR=agrieve@chromium.org Bug: 1015159 Change-Id: Iddd45829abdd11478cd3c9aacb4176ea72e49258 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1914826Reviewed-by:
Christopher Grant <cjgrant@chromium.org> Commit-Queue: Christopher Grant <cjgrant@chromium.org> Auto-Submit: Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#715130}
-
Min Qin authored
This reverts commit e1946c92. Reason for revert: <INSERT REASONING HERE> Original change's description: > Revert "Move DownloadManagerBridge to chrome/browser/download" > > This reverts commit fdf71331. > > Reason for revert: compile failure:https://ci.chromium.org/p/chrome/builders/ci/android_arm64-builder-perf/129178 > > Original change's description: > > Move DownloadManagerBridge to chrome/browser/download > > > > Part of the modulization effort. > > > > Bug: 1013759 > > Change-Id: I3a250fb293925ebe3c98fc068003b32568112ff9 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902072 > > Reviewed-by: Shakti Sahu <shaktisahu@chromium.org> > > Reviewed-by: David Trainor <dtrainor@chromium.org> > > Commit-Queue: Min Qin <qinmin@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#715066} > > TBR=dtrainor@chromium.org,qinmin@chromium.org,shaktisahu@chromium.org > > Change-Id: I8751d6528d8b800a409657b3fdbd9a8c7897e0ae > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1013759 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1915219 > Reviewed-by: Tommy Steimel <steimel@chromium.org> > Commit-Queue: Tommy Steimel <steimel@chromium.org> > Cr-Commit-Position: refs/heads/master@{#715097} TBR=dtrainor@chromium.org,qinmin@chromium.org,shaktisahu@chromium.org,steimel@chromium.org Change-Id: I762766e0a307a5d6ad12bd702d072bacd5680b73 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1013759 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1915290Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#715129}
-
John Lee authored
If a swipe gesture gets canceled by a pointerleave event, the animation needs to be reset. If it is not reset, the next pointerup event will calculate the pixels swiped and the velocity based on an animation time from a previous gesture. This occurs most frequently in cases where a user is swiping diagonally on the tab strip to scroll. The diagonal swipe causes the TabSwiper to map a few of the first initial pixels as a tab swipe, which gets canceled by a pointerleave event caused by the scroll. The next time the user taps on a TabElement, the pointerup event will do its calcs based on the previous diagonal swipe since the animation remains in a state modified by the diagonal swipe. Bug: 1014679 Change-Id: I5ef44578f104152793af4c4750e4a493d7d908b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913572Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#715128}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/63e5e057851d..5043101ccdf5 git log 63e5e057851d..5043101ccdf5 --date=short --no-merges --format='%ad %ae %s' 2019-11-13 dneto@google.com Android.mk: Fix detection of spirv-headers directory (#887) Created with: gclient setdep -r src/third_party/shaderc/src@5043101ccdf5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Please CC radial-bots+chrome-roll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=radial-bots+chrome-roll@google.com Bug: None Change-Id: I0c7de6a584e290df869d8c02320e725456fb9a31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1914861Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#715127}
-
Sharon Yang authored
This is a reland of fc5589ac A BUILD.gn dep has been added back, which was causing linker failures. Control flow in AccessibilityBridgeBrowsertests has been updated so tests are no longer failing. Original change's description: > [Fuchsia] Send Chrome a11y updates to Fuchsia SemanticsManager > > This change adds functionality to the Accessibility Bridge: > * Listens for change in AccessibilityMode from Fuchsia > * Gets the semantic tree from Chrome accessibility and sends it to the > SemanticsManager > * Sends live updates when nodes are added, updated or removed > > To send updates, this change includes the following: > * Creates a ViewRefPair and registers it with the SemanticsManager > * Initialize an AccessibilityBridge > * Listen for changes in the Chrome Accessibility tree, serializes them > to Fuchsia data structures and sends that data to the Fuchsia > SemanticsManager > > Testing: Added AccessibilityBridge browsertests. > > Bug: 973095 > Change-Id: I89658288b846b6b9ce84a04e49434ec266b84dfc > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787171 > Commit-Queue: Sharon Yang <yangsharon@chromium.org> > Reviewed-by: Kevin Marshall <kmarshall@chromium.org> > Cr-Commit-Position: refs/heads/master@{#714588} Bug: 973095 Change-Id: Ie6eeb74146682838efaefb0e1051d3e9442f0d86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913569Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#715126}
-
Yun Liu authored
Bug: 1024608 Change-Id: I850aed610eb3abdd3459d7f083efd51f7bc1e4c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1914837Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Yun Liu <yliuyliu@google.com> Cr-Commit-Position: refs/heads/master@{#715125}
-
Ahmed Mehfooz authored
Bug: 1022559 Change-Id: Ib13a8d519b4d2d09f4411d5a729ef66d17f0cab6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904620Reviewed-by:
Tim Song <tengs@chromium.org> Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Cr-Commit-Position: refs/heads/master@{#715124}
-
Brandon Wylie authored
Bug: 1024062 Change-Id: I95c548a23c2a4903c57d724e124a5af0bf4b7966 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913712 Commit-Queue: Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#715123}
-
Saman Sami authored
This is a temporary CHECK that should help us diagnose deserialization failures in SubmitCompositorFrame. Bug: 1022565, 979564 Change-Id: I60da30e82cc39edd791800f4cc2dd0293d05fda1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913657Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#715122}
-
Azeem Arshad authored
This CL adds aria labels for host and port input fields in manual proxy configuration section in network details page. Also adds labels for proxy exception input field. Bug: 1024355 Change-Id: I0fe751e248b9f51916d83bb5ca7ae92ee14ac3e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913097Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Azeem Arshad <azeemarshad@chromium.org> Cr-Commit-Position: refs/heads/master@{#715121}
-
Anand K. Mistry authored
Also convert usages of Bind -> Bind{Once,Repeating}. Bug: 1007814 Change-Id: Ib242b593fe7b0870bf5953fa5e614aa092aa6a02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913233Reviewed-by:Oksana Zhuravlova <oksamyt@chromium.org> Commit-Queue: Anand Mistry <amistry@chromium.org> Cr-Commit-Position: refs/heads/master@{#715120}
-
Steve Becker authored
Updates FileSystemDirectoryHandle.getSystemDirectory() and chooseFileSystemEntries() to reject with a SecurityError when called by a sandboxed window. This change also adds a WPT test that accesses the NativeFileSystem from opaque origins. The test includes a data URI iframe, sandboxed iframe and a sandboxed opened window. Unlike sandboxed iframes, for data URI iframes, the NativeFileSystem API is undefined because data URI iframes do not provide a secure context. This change gives the NativeFileSystem the same behavior as other web platform storage with write operations. LocalStorage, indexedDB, and cacheStorage all fail with SecurityErrors when accessed from a sandbox. However, sandboxes can read files using <input type=file> and drag&drop. In the future, if a read-only sandbox scenario emerges, we can consider loosening this policy for the NativeFileSystem. Bug: 1014248 Change-Id: Ibeafcdbf102275f2cd45f3cd7dbd8ed592c850c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1907278Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Olivier Yiptong <oyiptong@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Steve Becker <stevebe@microsoft.com> Cr-Commit-Position: refs/heads/master@{#715119}
-
Anand K. Mistry authored
Bug: 1007814 Change-Id: I6f3bfac9b4a0d68a53339aef8471fae379c924c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913234Reviewed-by:
-
Ahmed Mehfooz authored
The order of the stacked notifications icons can be broken if a notification is added / removed from the middle of the stacked notifications. This fix prevents it by removing a notification's icon through id lookup when a notification is removed and resetting the notification_icons_container_ if a new notification is added while the tray is open. Change-Id: I108c983dcb1b42be67354598064e5e1daa299697 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913877 Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
-
Xianzhu Wang authored
We create multiple FragmentData objects for all fragmented layout objects, not just self-painting layers. Change-Id: Ib95bda3415b3bd7570f74f26746adcea8c35eafe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913096Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#715116}
-
arthursonzogni authored
about:srcdoc document is always loaded inside an iframe and is same-SiteInstance with its parent. This is checked in CommitNavigation. As a precautionary measure, this initially landed as a DumpWithoutCrashing() to avoid hurting canary/dev/beta users if those check were violated. It was planned to remove the DumpWithoutCrashing for M79 if there was no reported DumpWithoutCrashing. There are none of them: https://crash.corp.google.com/browse?q=product_name%3D%22Chrome%22+AND+STRPOS%28expanded_custom_data.ChromeCrashProto.magic_signature_1.name%2C+%27CommitNavigation%27%29+%3E+0+AND+expanded_custom_data.ChromeCrashProto.magic_signature_1.name%3D%27content%3A%3ARenderFrameHostImpl%3A%3ACommitNavigation%27+AND+product.Version%3E%3D%2778.0.3904.63%27&stbtiq=&reportid=70db5bbe497238ba&index=9#4 Bug: None Change-Id: Iee51ddcb31fd3a7b1b7155c02f726e24c160f31c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913401 Auto-Submit: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#715115}
-
Brandon Wylie authored
Bug: 1022504 Change-Id: Ia1d34e69ed8d90fd17bb74207f38d48770d2e0f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904765 Commit-Queue: Brandon Wylie <wylieb@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/9e7107eb96af..321c12255e73 git log 9e7107eb96af..321c12255e73 --date=short --no-merges --format='%ad %ae %s' 2019-11-13 cwallez@chromium.org Remove the "Base" from pure-frontend dawn_native types Created with: gclient setdep -r src/third_party/dawn@321c12255e73 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel TBR=cwallez@google.com Bug: None Change-Id: I5ca499d938b09fe467df5e10e8af7d142f11fa00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1914615Reviewed-by:
-
Josh Karlin authored
Reverted in https://chromium-review.googlesource.com/c/chromium/src/+/1906860 What changed: I missed a test that needed to be updated. TBR=csharrison@chromium.org Change-Id: I2621da585a94b31a11730bd7f64492a525ab648e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1914972 Commit-Queue: Josh Karlin <jkarlin@chromium.org> Reviewed-by:
John Delaney <johnidel@chromium.org> Cr-Commit-Position: refs/heads/master@{#715112}
-
- 13 Nov, 2019 18 commits
-
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/4f32a29a69b4..6006105f67c3 git log 4f32a29a69b4..6006105f67c3 --date=short --no-merges --format='%ad %ae %s' 2019-11-13 csmartdalton@google.com Implement mixed samples support in vulkan 2019-11-13 csmartdalton@google.com Enforce extra constraints for mixed samples at GrCaps level 2019-11-13 emircan@google.com Disable VkProtectedContext_DDLMakeRenderTargetTest Created with: gclient setdep -r src/third_party/skia@6006105f67c3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC halcanary@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=halcanary@google.com Bug: None Change-Id: I29f4ac39facf9a2e7010b265e4f43275867383d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1914614Reviewed-by:
-
Karan Bhatia authored
This helps debugging in tests when some rules fail to index correctly. BUG=696822 Change-Id: I38be0f707e7de7b5a4be49aacb037b7d9bd42fbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911279 Commit-Queue: Kelvin Jiang <kelvinjiang@chromium.org> Auto-Submit: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Kelvin Jiang <kelvinjiang@chromium.org> Cr-Commit-Position: refs/heads/master@{#715110}
-
Ana Salazar authored
Measures Presentation Time and Max Latency on Clamshell and Tablet Mode. On Tablet Mode we also measure in-app and not in-app shelf. Bug: 1020386 Change-Id: I03bfe4fb1422195326fe3ce46280b7cb45a45846 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1910878 Commit-Queue: Ana Salazar <anasalazar@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Matthew Mourgos <mmourgos@chromium.org> Cr-Commit-Position: refs/heads/master@{#715109}
-
Ovidio Henriquez authored
This change converts all of the uses of base::Bind and base::Callback in device/bluetooth/device.{cc,h} to use the Once version. This is part of the Chrome Code Health rotation. Bug: 1007780 Change-Id: Ie1a19a4447c777ab7ecd067da695bda0a2566a6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900665Reviewed-by:Reilly Grant <reillyg@chromium.org> Commit-Queue: Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Cr-Commit-Position: refs/heads/master@{#715108}
-
Rob Schonberger authored
This is the actual parameters of the model that is checked in, rather than the current 1/1. I.e. there's a bug in submitted code that shows when executing. Apologies. Bug: 1009290 Change-Id: I3bcbe8eed8a81cb6979029f5f52f350b50c2e765 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913683 Auto-Submit: Rob Schonberger <robsc@chromium.org> Reviewed-by:
Sean O'Brien <seobrien@chromium.org> Reviewed-by:
Michael Spang <spang@chromium.org> Commit-Queue: Rob Schonberger <robsc@chromium.org> Cr-Commit-Position: refs/heads/master@{#715107}
-
Dan Beam authored
Partially borrowed from https://crrev.com/c/1836021 by Archana Simha <archanasihma@chromium.org> Bug: 1020025 Change-Id: I7de22a41d872ec624f25d1633782d27448988c58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893824 Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Auto-Submit: Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#715106}
-
Sammie Quon authored
Gave the parent a rect that has x-bounds, but still using the parent's parent width, resulting in a overflow. Test: manual Bug: 1020539 Change-Id: I983cf0813c6b99a74960761c8c8fd241b2995e0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1914942Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#715105}
-
Alice Boxhall authored
Bug: 1015529 Change-Id: I59c9991f3fd50582553883d4d27668960b4a6481 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911064Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Alice Boxhall <aboxhall@chromium.org> Cr-Commit-Position: refs/heads/master@{#715104}
-
John Williams authored
Bug: 972751 Change-Id: I37adf77ed0c9de8f73d2467f2d57f7db0ba9df10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1770433 Commit-Queue: John Williams <jrw@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/master@{#715103}
-
rbpotter authored
Autogenerate a JS module version of FindShortcutBehavior, its dependencies (KeyboardShortcutList), and its browser test. This is a prerequisite for migrating pages that depend on this behavior to Polymer 3 (e.g. bookmarks). Bug: 1022213 Change-Id: Ifbf2680c5f044474de68b11da9a434c96a13381e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913510 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/9dab499b2b5b..fa6d4dc30478 git log 9dab499b2b5b..fa6d4dc30478 --date=short --no-merges --format='%ad %ae %s' 2019-11-13 alexclarke@chromium.org Add android-weblayer as a target browser Created with: gclient setdep -r src/third_party/catapult@fa6d4dc30478 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC sadrul@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sadrul@google.com Bug: chromium:1022812 Change-Id: Ie7fa454800e8f1010a2b99ef1cfcee6da4976c38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1914612Reviewed-by:
-
Peter Kasting authored
This makes it clearer (everywhere) that the animation is simply animating the alpha value of a single alert color. Bug: none Change-Id: Iad30d326dd3af811cc0e065d10ef637d32e5a94b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1914963 Commit-Queue: Peter Kasting <pkasting@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#715100}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/c062acf6a20a..d85c18b05dcf git log c062acf6a20a..d85c18b05dcf --date=short --no-merges --format='%ad %ae %s' 2019-11-13 dburger@chromium.org Stop scheduling master-paladin. Created with: gclient setdep -r src/third_party/chromite@d85c18b05dcf If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I85d42e47f6e7b2788c6d63c40b54fb3bf291cbc1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1914611Reviewed-by:
-
Dominic Mazzoni authored
TalkBack doesn't yet consume these yet, but this matches the same way native Android TextViews expose misspelled words, whether from typing, or from dictation with multiple suggestions. Bug: 524654 Change-Id: I3a78b78f12a5a9c67b15718422d7c3c6cc524376 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881695 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#715098}
-
Tommy Steimel authored
This reverts commit fdf71331. Reason for revert: compile failure:https://ci.chromium.org/p/chrome/builders/ci/android_arm64-builder-perf/129178 Original change's description: > Move DownloadManagerBridge to chrome/browser/download > > Part of the modulization effort. > > Bug: 1013759 > Change-Id: I3a250fb293925ebe3c98fc068003b32568112ff9 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902072 > Reviewed-by: Shakti Sahu <shaktisahu@chromium.org> > Reviewed-by: David Trainor <dtrainor@chromium.org> > Commit-Queue: Min Qin <qinmin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#715066} TBR=dtrainor@chromium.org,qinmin@chromium.org,shaktisahu@chromium.org Change-Id: I8751d6528d8b800a409657b3fdbd9a8c7897e0ae No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1013759 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1915219Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#715097}
-
Sasha McIntosh authored
When working with YUV images, uses the stride of the plane when creating pixmaps for each plane. Bug: 919627 Bug: 1023090 Change-Id: I1bf1dd5f0ac96a2eac5a8f4bb2f73453042fe7df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906954 Commit-Queue: Sasha McIntosh <sashamcintosh@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#715096}
-
Yulun Wu authored
Bug: 1024509 Change-Id: Ic34e1871aa9b828926f22b847e9001f2c5a2aa8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1914971Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Yulun Wu <yulunwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#715095}
-
Reilly Grant authored
This collects effectively the same data but uses the more modern infrastructure. Bug: 1017844 Change-Id: Ibafe3991d5129faf0481bef7acb8e7cd157cae12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895946 Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Auto-Submit: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#715094}
-
