GitLab

Deactivates XRFrame objects once the relevant callback returns, which
causes future calls to the object methods to throw an exception.

Bug: 906842
Change-Id: I192453f9f23b1b4d9a404daca352ab80a5393753
Reviewed-on: https://chromium-review.googlesource.com/c/1343065
Commit-Queue: Brandon Jones <bajones@chromium.org>
Reviewed-by: Klaus Weidner <klausw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612887}

For CompositeAfterPaint, during paint, for each link highlighted
fragment, create a ForeignLayerDisplayItems, in a property tree state
with transform and clip the same as those of the object's local border
box properties, and the LinkHighlightEffect.

Change-Id: Ic3256ee508628dbd82dde149b6fbfe29aa4d9ca8
Reviewed-on: https://chromium-review.googlesource.com/c/1355858
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612886}

TableView: Adds keyboard and programmatic support for navigating through, selecting and resizing columns

A followup patch will add AXVirtualView objects for every row, column and table cell, and refine the accessibility actions further.
R=dmazzoni@chromium.org

Change-Id: I0d1d599ef8cc63f3965bbcbc5d01281912707e51
Bug: 101762
Reviewed-on: https://chromium-review.googlesource.com/c/1320974Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Nektarios Paisios <nektar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612885}

Bug: 908243
Change-Id: Ic049c51f0c631699a2117a4f3e275e4d51e8d91c
Reviewed-on: https://chromium-review.googlesource.com/c/1357545Reviewed-by: Andrey Lushnikov <lushnikov@chromium.org>
Commit-Queue: Joel Einbinder <einbinder@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612884}

This moves the mojom enum to be a standard c++ enum class in
content/public/browser/. It's used by chrome/browser and
content/browser, as well as content/shell/test_runner, though the
latter one will be removed.

This enum is no longer used by the renderer code nor sent over IPC so
not need to be in blink or as a mojo enum.

R=avi@chromium.org, dcheng@chromium.org
TBR=dcheng

Change-Id: I18a81513332338ae36fe789ab4d289061335c4c3
Bug: 908582
Reviewed-on: https://chromium-review.googlesource.com/c/1357507
Commit-Queue: danakj <danakj@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612883}

It looks like Blink can report an invalid selection range back to the
browser. This change treats invalid ranges like the empty string for the
purpose of generating suggestions, and adds a DCHECK for this condition.

Bug: 893038
Change-Id: I2afa5065d7eeebb6cc61030277f86b488a69388b
Reviewed-on: https://chromium-review.googlesource.com/c/1351530
Commit-Queue: Sidney San Martín <sdy@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612882}

Bug: 909720
Change-Id: Ie88f31f58de2094583722884bb25fbbbee8a85ee
Reviewed-on: https://chromium-review.googlesource.com/c/1357575
Commit-Queue: Vitaly Buka <vitalybuka@chromium.org>
Reviewed-by: Vitaly Buka <vitalybuka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612881}

ScrollingCoordinator accounts for some of the time in MainFrame
update time. Record how much.

As a side effect, move the macro for local frame UKM scoped recording
into the aggregator class so that it can be shared across classes.
This is to avoid relocating the UMA metric recording site in a way that
would skew the data toward zero, a lot.

R=pdr@chromium.org,rkaplow@chromium.org
BUG=910635

Change-Id: Id527efb7f30cc69de8ee45e27c616621059ef544
Reviewed-on: https://chromium-review.googlesource.com/c/1356888
Commit-Queue: Stephen Chenney <schenney@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612880}

This test was using a net::URLRequestInterceptor so was not actually
working correctly with network service. The interceptor it was using
also assumes it is on the IO thread which was causing issues when
running NS in-process on its own thread.

Bug: 908993
Change-Id: I009ddf13b53cecac9615c4d2019405ddede57c69
Reviewed-on: https://chromium-review.googlesource.com/c/1357405Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612879}

Bug: None
Change-Id: Ib9fc01329d733c1b2a64081771659852530a84e6
Reviewed-on: https://chromium-review.googlesource.com/c/1345427
Commit-Queue: Sean Kau <skau@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612878}

Experiment showed that limiting media preloading generally
slows things down rather than speed things up, presumably because
there are a lot of other things loading as well.

Bug: 884820
Change-Id: I5baa15c465ef83a73eecbdad77c5cb0ad589e5d6
Reviewed-on: https://chromium-review.googlesource.com/c/1355257Reviewed-by: Jesse Doherty <jwd@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Fredrik Hubinette <hubbe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612877}

Bug: 910754
Change-Id: I6306a138923c709ec31cf7ee5c5fe907c6ed35ad
Reviewed-on: https://chromium-review.googlesource.com/c/1357566Reviewed-by: Filip Gorski <fgorski@chromium.org>
Commit-Queue: Sky Malice <skym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612876}

This reverts commit 246dedf4.

Reason for revert: "no such option: --failures" fixed by https://chromium-review.googlesource.com/c/chromium/tools/build/+/1357359

Original change's description:
> Revert "Move static initializer check to a testing script"
>
> This reverts commit 7268f2d1.
>
> Reason for revert: Breaks sizes step of Google Chrome Mac and Windows
>
> https://ci.chromium.org/buildbot/chromium.chrome/Google%20Chrome%20Mac/39214
>
> sizes.py: error: no such option: --failures
>
> Original change's description:
> > Move static initializer check to a testing script
> >
> > R=​thakis,dpranke
> >
> > Bug: 110002
> > Change-Id: I8da8e50930e973bd4bfac261571a66b7bad92778
> > Cq-Include-Trybots: luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng;luci.chromium.try:win_archive;luci.chromium.try:win_x64_archive;master.tryserver.chromium.android:android_archive_rel_ng
> > Reviewed-on: https://chromium-review.googlesource.com/c/1351716
> > Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
> > Reviewed-by: Dirk Pranke <dpranke@chromium.org>
> > Reviewed-by: Nico Weber <thakis@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#612544}
>
> TBR=thakis@chromium.org,dpranke@chromium.org,thomasanderson@chromium.org
>
> Change-Id: I3bfdb124c0fd18ba422553be8a78bc370d6e35f2
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 110002
> Cq-Include-Trybots: luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng;luci.chromium.try:win_archive;luci.chromium.try:win_x64_archive;master.tryserver.chromium.android:android_archive_rel_ng
> Reviewed-on: https://chromium-review.googlesource.com/c/1356439
> Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#612573}

TBR=thakis@chromium.org,dpranke@chromium.org,ortuno@chromium.org,thomasanderson@chromium.org

Change-Id: Iea1db2c9f9e0bd642677ebcc479bbb99ce763b08
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 110002
Cq-Include-Trybots: luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng;luci.chromium.try:win_archive;luci.chromium.try:win_x64_archive;master.tryserver.chromium.android:android_archive_rel_ng
Reviewed-on: https://chromium-review.googlesource.com/c/1357648
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612875}

In most cases, when a list is blurred and focus returns to the list,
focus returns to the last item that was blurred. However, in certain
cases like the linked bug, it is possible for focus to return to the
list but to a different item than the last one blurred. As a result,
the boolean tracking whether focus has left the list needs to be
shared by all items in the list. This CL changes it from a private
variable to a Polymer property data-bound to one parent property to
allow all items to access and update the same value.

Bug: 910056
Change-Id: I763e0a11c87536aab6b189a2c71c18e6fa7d83e1
Reviewed-on: https://chromium-review.googlesource.com/c/1356233
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Scott Chen <scottchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612874}

Also remove a suppression is not needed.

TBR=kbr@chromium.org

Bug: 907599,906889
Change-Id: I7f232d58a6dcec4879a0a62a58957f1e35dbda3a
Reviewed-on: https://chromium-review.googlesource.com/c/1357573Reviewed-by: Saman Sami <samans@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Saman Sami <samans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612873}

Otherwise if there is a commit request and we early out due to being invisible
before commiting, and we set the max+requested_pipeline_stage_ to
NO_PIPELINE_STAGE, then that commit is lost. For flash this results in a commit
never receiving callback, and the next commit can never be requested, thus
rendering is stalled.

BUG=890008
TEST=cc_unittests
R=piman@chromium,enne@chromium.org,danakj@chromium.org

Change-Id: I240be7bb5496f28c0217ee7ef86533509bafcd16
Reviewed-on: https://chromium-review.googlesource.com/c/1343048
Commit-Queue: Zhenyao Mo <zmo@chromium.org>
Reviewed-by: enne <enne@chromium.org>
Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612872}

This is based in part on qyearsley's earlier iteration in
https://chromium-review.googlesource.com/595041, but it uses different
builds of Apache and PHP, which seem to work better.

UCRT DLLs (api-ms-crt-* and ucrtbase) are included. Although
Microsoft's documentation states that Windows should install them
automatically via Windows Update, some Windows bots are missing
ucrtbase.dll. See https://crbug.com/910745.

Fixes to tests needed:

- HttpProtocolOptions Unsafe detection logic did not handle Apache
  erroring due to the config file being bad or missing. Along the way,
  pass -t to further make sure it does not start serving.

- image-load-in-unload-handler.html did not pass ?test=blah, which
  resulted in save-Ping.php, etc., trying to rename a file to "test.".
  The new PHP on Windows appears to get offended by this.

This means we can remove the TLS 1.0/1.1 deprecation suppression in
Windows layout tests.

Bug: 747666, 801270
Change-Id: Ib61b74ad9cf3e3f88666089594b013c247691695
Reviewed-on: https://chromium-review.googlesource.com/c/1338939
Commit-Queue: David Benjamin <davidben@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612871}

This pushes more functionality out of //chrome and down into
//ui/views. It will make it easier to share the code with
//ash, and possibly also for chromecast.

There are AXTreeSourceAura unit tests in //chrome that exercise
the integration of AXTreeSource with AXRootObjWrapper. I left
those in place but converted to ChromeViewsTestBase. This
eliminates a chrome-to-ash dependency. The tests can be moved
into //ui/views in a follow-up CL. I didn't do it now so the
diffs would be easier to read.

BUG=910672
TEST=unit_tests, views_unittests

Change-Id: Ib1483bc6b8e792409b106e0cdd12bff415032ef6
Reviewed-on: https://chromium-review.googlesource.com/c/1357499Reviewed-by: Sergey Volk <servolk@chromium.org>
Reviewed-by: David Tseng <dtseng@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612870}

Using wpt-import in Chromium bdffcf67.

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

NOAUTOREVERT=true
TBR=kyleju

No-Export: true
Change-Id: Ib9209eaa3e9f7427382785e03dfa97366ab94279
Reviewed-on: https://chromium-review.googlesource.com/c/1357504
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#612869}

Without this Chrome is pushed out of the list of suggested apps
very soon after the profile creation and never comes back even
after it is launched.

Bug: 894898
Test: manual
Change-Id: I7d12958c1522336bf831d31b9288a6084cc5f974
Reviewed-on: https://chromium-review.googlesource.com/c/1338472
Commit-Queue: Vladislav Kaznacheev <kaznacheev@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Yury Khmel <khmel@chromium.org>
Reviewed-by: Alex Newcomer <newcomer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612868}

Bug: 633246
Change-Id: Id6c302696c955401a991c0235d86f05d03019036
Reviewed-on: https://chromium-review.googlesource.com/c/1355045Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Commit-Queue: Alexander Alekseev <alemate@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612867}

Bug: 875053
Change-Id: If25cd61692ec30ef590c8edf67c6960213196ff4
Reviewed-on: https://chromium-review.googlesource.com/c/1351710
Commit-Queue: Nick Harper <nharper@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612866}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b26f97ac1d28..2b881d5ca610


Created with:
  gclient setdep -r src-internal@2b881d5ca610

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:448088
TBR=mmoss@chromium.org

Change-Id: I1989164dfa570547ca9d40755e61bba8f3dc8867
Reviewed-on: https://chromium-review.googlesource.com/c/1357427Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#612865}

Previously CacheStorage used some very large macros to record a number
of scheduler related histograms.  These macros produce a lot of code
bloat and are difficult to read.  This CL addresses those issues by
replacing the macros with functions.

Bug: 909894
Change-Id: Icc3adc91d72de2aeaac0f927c13f3e2bfb557e77
Reviewed-on: https://chromium-review.googlesource.com/c/1357400
Commit-Queue: Ben Kelly <wanderview@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612864}

This reverts commit 8121da4a.

Reason for revert: Builder turned green while the revert was in flight, and the revert seems to have broken it.

Original change's description:
> Revert "[protoc] Use protoc's lite java plugin and runtime"
> 
> This reverts commit 8aa669ef.
> 
> Reason for revert: crbug.com/910759
> 
> Original change's description:
> > [protoc] Use protoc's lite java plugin and runtime
> > 
> > protoc the protobuf compiler now requires using a separate plugin for
> > compiling protos for the java lite runtime. The lite java runtime is now
> > also separate from the main java runtime and is distributed separately.
> > 
> > This cl switches java proto compilation for lite protos to this new
> > mode.
> > 
> > TBR=android_webview/BUILD.gn
> > 
> > Bug: 782237, 800281
> > Change-Id: I31c2d073bed51109dffeea133495679deef3186b
> > Reviewed-on: https://chromium-review.googlesource.com/c/1340522
> > Commit-Queue: Mohamed Heikal <mheikal@chromium.org>
> > Reviewed-by: Pavel Yatsuk <pavely@chromium.org>
> > Reviewed-by: Peter Kasting <pkasting@chromium.org>
> > Reviewed-by: agrieve <agrieve@chromium.org>
> > Reviewed-by: Peter Wen <wnwen@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#612720}
> 
> TBR=pkasting@chromium.org,michaelbai@chromium.org,wnwen@chromium.org,pavely@chromium.org,agrieve@chromium.org,mheikal@chromium.org
> 
> Change-Id: Ie2dce6e8c5ad03e6a75607a02e234c813f3072a5
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 782237, 800281
> Reviewed-on: https://chromium-review.googlesource.com/c/1357571
> Reviewed-by: oysteine <oysteine@chromium.org>
> Commit-Queue: oysteine <oysteine@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#612826}

TBR=pkasting@chromium.org,michaelbai@chromium.org,wnwen@chromium.org,oysteine@chromium.org,pavely@chromium.org,agrieve@chromium.org,mheikal@chromium.org

Change-Id: Ia8b508fd7ab9c7c42cc976dc0827683da81a435f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 782237, 800281
Reviewed-on: https://chromium-review.googlesource.com/c/1357641Reviewed-by: oysteine <oysteine@chromium.org>
Commit-Queue: oysteine <oysteine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612863}

If the same URL is suggested multiple times at once, it should only be added
once. I stumbled into this condition when using the test data for Feed.

Bug: 841516
Change-Id: I26b95e4c1b4e7ace1516e0a84187d9960d327aaa
Reviewed-on: https://chromium-review.googlesource.com/c/1351275
Commit-Queue: Dan H <harringtond@google.com>
Reviewed-by: Carlos Knippschild <carlosk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612862}

This is a reland of d20781e1

The cl was reverted due to an internal dependency issue, which has been resolved. So TBR for the reland.
TBR=sammc@chromium.com, xiaohuic@chromium.com

Original change's description:
> Handle Open/Verify android apps for Assistant
>
> Bug: b/117793081
> Test: Manual Test
> Change-Id: If747d3317cb163715ff907839203e0c0eee57a1c
> Reviewed-on: https://chromium-review.googlesource.com/c/1352341
> Commit-Queue: Yue Li <updowndota@chromium.org>
> Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
> Reviewed-by: Sam McNally <sammc@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#612448}

Bug: b/117793081
Change-Id: I19268f1ad40deb7b77f68bb0f9a87e98154d55b9
Reviewed-on: https://chromium-review.googlesource.com/c/1356326Reviewed-by: Yue Li <updowndota@chromium.org>
Commit-Queue: Yue Li <updowndota@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612861}

Replace LearningTaskControllerImpl's do-nothing initial
implementation with one that:
  - constructs the training callback based on the learning task
  - collects training examples as they're added
  - re-train the model periodically.
  - record stats about model performance

Change-Id: I6a949e6188c71d00be5449dc9539508254c7d74a
Reviewed-on: https://chromium-review.googlesource.com/c/1355434
Commit-Queue: Frank Liberato <liberato@chromium.org>
Reviewed-by: Fredrik Hubinette <hubbe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612860}

Adds an inset when the shelf is auto hidden because we want the grid to
be centered as if the shelf is fully visible.

Test: ash_unittests WindowSelectorTest.GridBounds
Bug: 908679, 908982
Change-Id: Ibccfb0bab70d68a463c3325fa8ca3b7912d0dc65
Reviewed-on: https://chromium-review.googlesource.com/c/1354355Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612859}

Convert ConditionalCacheDeletionHelperBrowserTest to not depend on URLRequestContext when network service is enabled.

Bug: 837753
Change-Id: I35b75299bcea1cc2b93a3c47dcbea036cc4e2d03
Reviewed-on: https://chromium-review.googlesource.com/c/1357567Reviewed-by: Clark DuVall <cduvall@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612858}

The problem here is that between CachedImageFetcherImpl's FetchImage
invocation and completion, destroy was called on
InMemoryCachedImageFetcher. This causes an attempt to store the image
in a null bitmap cache. This just checks if the bitmap cache is null
before attempting to store an image.

Bug: 910080
Change-Id: I28b7aaee8588d883cfaf98328e2e58478d452375
Reviewed-on: https://chromium-review.googlesource.com/c/1355770Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Sky Malice <skym@chromium.org>
Reviewed-by: Filip Gorski <fgorski@chromium.org>
Commit-Queue: Brandon Wylie <wylieb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612857}

This now searches for new-style URL and title pairs as well as
the old pboardtype.

BUG=851326

Change-Id: I00afe5ce5a3ca7e54648194bbf686b0fd85dad62
Reviewed-on: https://chromium-review.googlesource.com/c/1354259Reviewed-by: Sidney San Martín <sdy@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612856}

Previously the logging was done in ToolbarPhone. This meant that
Duet wasn't logging any of the new tab button clicks. This moves
the logging to the click handler.

Bug: 910682
Change-Id: I318ccdeffdb453e97cca8e3a203177b5db2f1791
Reviewed-on: https://chromium-review.googlesource.com/c/1357381
Commit-Queue: Pedro Amaral <amaralp@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612855}

It's not used any more.

BUG=none

Change-Id: I796312bbb32c0dcdef33ab0ea5b2c8472c7e853d
Reviewed-on: https://chromium-review.googlesource.com/c/1355612
Commit-Queue: Sidney San Martín <sdy@chromium.org>
Reviewed-by: Sidney San Martín <sdy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612854}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/020b59722ab0..b0ee5ee22d88


git log 020b59722ab0..b0ee5ee22d88 --date=short --no-merges --format='%ad %ae %s'
2018-11-30 recipe-roller@chromium.org Roll recipe dependencies (nontrivial).


Created with:
  gclient setdep -r src/third_party/depot_tools@b0ee5ee22d88

The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=agable@chromium.org

Change-Id: I79c58b720add301baf7b40ab14c85cb50859ea35
Reviewed-on: https://chromium-review.googlesource.com/c/1357420Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#612853}

This CL adds the functionality to have an aec group ID, which allow
Chromium to take actions that is specific for the echo canceller
parameter set that is being used in the Chrome Audio Server.

BUG=chromium:907917
CQ-DEPEND=CL:1349280,CL:1349353

Change-Id: I391fd0a65858a2635c8927dc2a8816dfb9cd4221
Reviewed-on: https://chromium-review.googlesource.com/c/1349260Reviewed-by: Jenny Zhang <jennyz@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Max Morin <maxmorin@chromium.org>
Commit-Queue: Per Åhgren <peah@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612852}

Change-Id: Idea90b5d7c13a961f9eeb0d144f0960f362b761f
Reviewed-on: https://chromium-review.googlesource.com/c/1357430Reviewed-by: danakj <danakj@chromium.org>
Commit-Queue: enne <enne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612851}

Add uninstall menu option to Crostini apps that can be uninstalled from
the container.

BUG=chromium:822514
TEST=Apps from .desktop files associated with a package now have
'uninstall' on right-click menu; Apps from .desktop files I created do
not have 'uninstall'

R=timloh@chromium.org

Change-Id: If7bcd69c08a806b98a4200d2de7ca4f550c57c21
Reviewed-on: https://chromium-review.googlesource.com/c/1213519
Commit-Queue: Ian Barkley-Yeung <iby@chromium.org>
Reviewed-by: Timothy Loh <timloh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612850}

Change all PageVisibilityState enums to be just booleans of hidden or
not in the renderer side code. Prerender state is not needed any more
there for correctness. The only places that check explictly for
prerender are to generate strings, or in RenderFrameImpl in order to
pass a bool along. We can remove the former and pass along the bool
more explicitly in the latter case since RenderFrameImpl can query if
prerendering is taking place for the frame.

There are a few places that check for == kVisible or != kVisible. For
the == kVisible, prerendering is only used while the frame is not
visible per the comment being deleted in prerender_helper.h. So this
should not change behaviour as prerender == hidden from this
perspective.

For places that check == kHidden or != kHidden it could be a new
behaviour when it would have been kPrerender before:

Document::DispatchUnloadEvents() would if !kHidden then dispatch
a visibility change event. This would have occured if going to
prerender during unload. Since prerender is for pre-loading this
seems okay to not happen anymore.

LocalFrameView::ShouldSetCursor() would return true during prerender.
This is part of event handling which is after the page is transitioned
out of prerender state, so it should be okay to return false during
prerender now.

This also removes "prerender" from layout tests. Layout tests set a
prerender visibility state, which would just set to hidden internally,
and verify it works like hidden. Since prerender no longer exists in
the renderer, these tests would just be testing hidden twice, and
we can remove the prerender bits.

R=avi@chromium.org, dcheng@chromium.org, pasko@chromium.org
TBR=avi

Change-Id: I914f47f49b41cbf8080ff6271c2896c1a5dbf569
Bug: 908582
Reviewed-on: https://chromium-review.googlesource.com/c/1356120Reviewed-by: danakj <danakj@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Egor Pasko <pasko@chromium.org>
Commit-Queue: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612849}

Previously the scheduler was being directly called by the
ChromeBrowsingDataRemoverDelegate when history was deleted. When this
happened, we cleared internal state and suppressed refreshes. This
sometimes coincided with when the FeedAppLifecycle cleared all stored
articles, but not very well. Particularly, when:
* Signing in
* Signing out
* Clear the cache

So instead, the scheduler is notified by the FeedAppLifecycle exactly
when all articles are cleared. A boolean is also passed along to inform
the scheduler which of the two states are we in. Did something get cleared
and we should suppress refreshing? Or do we now have no data and need to
refresh immediately.

Bug: 905959
Change-Id: I25c57022a0da52cc42746d265beae1c55f84d3ec
Reviewed-on: https://chromium-review.googlesource.com/c/1355994
Commit-Queue: Sky Malice <skym@chromium.org>
Reviewed-by: Filip Gorski <fgorski@chromium.org>
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612848}