GitLab

createCrossThreadTask and ExecutionContextTask are deprecated in favor
of crossThreadBind and CrossThreadClosure respectively. This patch
removes the deprecated versions. This patch also changes the code to
post tasks to WebTaskRunner instead of ExecutionContext, but the
behavour remains the same as Document::postTask already forwards tasks to
WebTaskRunner of the LocalFrame in the Document.

BUG=625927

Review-Url: https://codereview.chromium.org/2741443003
Cr-Commit-Position: refs/heads/master@{#456043}

createCrossThreadTask and ExecutionContextTask are deprecated in favor
of crossThreadBind and CrossThreadClosure respectively. This patch
removes the deprecated versions. This patch also changes the code to
post tasks to WebTaskRunner instead of ExecutionContext, but the
behavour remains the same as Document::postTask already forwards tasks to
WebTaskRunner of the LocalFrame in the Document.

BUG=625927

Review-Url: https://codereview.chromium.org/2738823004
Cr-Commit-Position: refs/heads/master@{#456042}

This is a temporary set of reverts so they can go into M58.

Revert "clean up LayoutTestNotificationManager overrides"
This reverts commit 0e9764ee.
Revert "Test the platform notification context synchronize operation"
This reverts commit f3f824cd.
Revert "Fix a couple of notification TODOs"
This reverts commit e50bfa20.

BUG=571056,700343

Review-Url: https://codereview.chromium.org/2739943006
Cr-Commit-Position: refs/heads/master@{#456041}

The page zoom factor is not applied to the ICB for printing, yet the
ICB basis for media queries and viewport units were. Use 1 as a page
zoom factor in viewportSizeForViewportUnits and use that method to get
the size for the ICB for evaluating media queries.

BUG=699014,699910

Review-Url: https://codereview.chromium.org/2738173002
Cr-Commit-Position: refs/heads/master@{#456040}

This CL adds another device attribute to the report which is uploaded to admin console.

More context can be found by reading the design doc go/remote-audio-management

BUG=699589

Review-Url: https://codereview.chromium.org/2736903004
Cr-Commit-Position: refs/heads/master@{#456039}

In the Custom Tabs benchmark, in the case where mayLaunchUrl isn't
called, launchUrl shouldn't be called immediately. This change causes
launchUrl to be called after the delay specified by delayToLaunchUrl.

BUG=655980

Review-Url: https://codereview.chromium.org/2742563003
Cr-Commit-Position: refs/heads/master@{#456038}

Our implementation had unnecessary precondition check for detached
CharacterData, and it's not defined by the DOM standard. This CL removes it.

* fast/dom/Range/31684.html: Removed
 This CL changes the exception message in this test. We remove this because
 It's well tested in WPT.

BUG=700275

Review-Url: https://codereview.chromium.org/2740293002
Cr-Commit-Position: refs/heads/master@{#456037}

Reland of duce copying of local data structures in GeometryMapper and PaintLayerClipper. (patchset #1 id:1 of https://codereview.chromium.org/2743733004/ )

Reason for revert:
Was likely a false alarm.

Original issue's description:
> Revert of Reduce copying of local data structures in GeometryMapper and PaintLayerClipper. (patchset #10 id:170001 of https://codereview.chromium.org/2745563004/ )
>
> Reason for revert:
> Speculative revert, it doesn't look related but am trying changes in the blame range.
>
> Will update if the revert has changed things / will revert the revert otherwise.
>
> https://build.chromium.org/p/chromium.win/builders/Win10%20Tests%20x64/builds/9030
>
> Test: SitePerProcessHighDPIExpiredCertBrowserTest.InterstitialLoadsWithCorrectDeviceScaleFactor
>
> Original issue's description:
> > Reduce copying of local data structures in GeometryMapper and PaintLayerClipper.
> >
> > In particular, changes return values from FloatClipRect to const FloatClipRect&,
> > to avoid extra data structure copies.
> >
> > In local testing, this CL produces up to a 10% improvement on the
> > rasterize_and_record_micro.partial_invalidation benchmark.
> >
> > BUG=692614
> > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
> >
> > Review-Url: https://codereview.chromium.org/2745563004
> > Cr-Commit-Position: refs/heads/master@{#456011}
> > Committed: https://chromium.googlesource.com/chromium/src/+/05c00d2035047fa9d210d95afedf8bd063bccc33
>
> TBR=pdr@chromium.org,wangxianzhu@chromium.org,chrishtr@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=692614
>
> Review-Url: https://codereview.chromium.org/2743733004
> Cr-Commit-Position: refs/heads/master@{#456032}
> Committed: https://chromium.googlesource.com/chromium/src/+/a2c9dcac6e64411adf0b6f047125d5ba415cce54

TBR=pdr@chromium.org,wangxianzhu@chromium.org,chrishtr@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=692614

Review-Url: https://codereview.chromium.org/2741103005
Cr-Commit-Position: refs/heads/master@{#456036}

Review-Url: https://codereview.chromium.org/2743893002
Cr-Commit-Position: refs/heads/master@{#456035}

Mac10.11
https://build.chromium.org/p/chromium.webkit/buildstatus?builder=WebKit%20Mac10.11&number=17334
https://build.chromium.org/p/chromium.webkit/buildstatus?builder=WebKit%20Mac10.11&number=17335

Mac10.10
https://build.chromium.org/p/chromium.webkit/buildstatus?builder=WebKit%20Mac10.10&number=31189

BUG=402805
NOTRY=true
TBR=enne@chromium.org

Review-Url: https://codereview.chromium.org/2744803002
Cr-Commit-Position: refs/heads/master@{#456034}

Also, change some apostrophes.

BUG=699932

Review-Url: https://codereview.chromium.org/2740113002
Cr-Commit-Position: refs/heads/master@{#456033}

Revert of Reduce copying of local data structures in GeometryMapper and PaintLayerClipper. (patchset #10 id:170001 of https://codereview.chromium.org/2745563004/ )

Reason for revert:
Speculative revert, it doesn't look related but am trying changes in the blame range.

Will update if the revert has changed things / will revert the revert otherwise.

https://build.chromium.org/p/chromium.win/builders/Win10%20Tests%20x64/builds/9030

Test: SitePerProcessHighDPIExpiredCertBrowserTest.InterstitialLoadsWithCorrectDeviceScaleFactor

Original issue's description:
> Reduce copying of local data structures in GeometryMapper and PaintLayerClipper.
>
> In particular, changes return values from FloatClipRect to const FloatClipRect&,
> to avoid extra data structure copies.
>
> In local testing, this CL produces up to a 10% improvement on the
> rasterize_and_record_micro.partial_invalidation benchmark.
>
> BUG=692614
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
>
> Review-Url: https://codereview.chromium.org/2745563004
> Cr-Commit-Position: refs/heads/master@{#456011}
> Committed: https://chromium.googlesource.com/chromium/src/+/05c00d2035047fa9d210d95afedf8bd063bccc33

TBR=pdr@chromium.org,wangxianzhu@chromium.org,chrishtr@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=692614

Review-Url: https://codereview.chromium.org/2743733004
Cr-Commit-Position: refs/heads/master@{#456032}

R=stgao@chromium.org, tandrii@chromium.org
BUG=665059

Review-Url: https://codereview.chromium.org/2738123003
Cr-Commit-Position: refs/heads/master@{#456031}

BUG=402805
NOTRY=true
TBR=enne@chromium.org

Review-Url: https://codereview.chromium.org/2742713006
Cr-Commit-Position: refs/heads/master@{#456030}

To diagnose an audio thread crash condition, verify that the lock
over audio consumers that MediaStreamSource keeps, isn't held when it is
being finalized. If it is, then the audio thread is active using the
MediaStreamSource object..which is not a well-formed state to be in.

R=
BUG=682945

Review-Url: https://codereview.chromium.org/2741663004
Cr-Commit-Position: refs/heads/master@{#456029}

BUG=none

Review-Url: https://codereview.chromium.org/2740953004
Cr-Commit-Position: refs/heads/master@{#456028}

BUG=517741
TEST=Tested manually that reloading is fast.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2737383003
Cr-Commit-Position: refs/heads/master@{#456027}

MFStartup() usually returns S_OK.  However, being a system library
function it doesn't have to, and we have no control over it.  It can
return an error when something goes wrong within Media Foundation, or
simply on an "N" edition of Windows that doesn't even have Media
Foundation.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2735783002
Cr-Commit-Position: refs/heads/master@{#456026}

The edited spec is here:
https://drafts.css-houdini.org/css-typed-om/#the-stylepropertymap

Broadly, the changes are:

- Rename ImmutableStylePropertyMap -> StylePropertyMapReadonly
- Switch StylePropertyMap to inherit from StylePropertyMapReadonly
instead of the other way around
- Update all references appropriately

BUG=545318

Review-Url: https://codereview.chromium.org/2730633004
Cr-Commit-Position: refs/heads/master@{#456025}

Network traffic annotation is added to network request of
NetMetricsLogUploader.

BUG=656607

Review-Url: https://codereview.chromium.org/2703363002
Cr-Commit-Position: refs/heads/master@{#456024}

This patch enables AnimatableValues to be created from registered
custom property CSSValues. This does not enable interpolation of
the registered custom properties via AnimatableValues, this is only
required because AnimatableValues are still used by CSSTransitions
as a way of testing equality between animation keyframes and
computed style values.

This patch is a refactor and does not change behaviour.

BUG=671904

Review-Url: https://codereview.chromium.org/2723883005
Cr-Commit-Position: refs/heads/master@{#456023}

BUG=None

Review-Url: https://codereview.chromium.org/2736233002
Cr-Commit-Position: refs/heads/master@{#456022}

CryptString is intended for secret data, such as passwords, and the
memory is cleared on deallocation. However, where it is used in
libjingle_xmpp, the password is copied to other objects without any
magic clearing, so the security benefit is questionable.

In addition, CryptString is yet another string class, it's unused
within webrtc, and essentially unmaintained. If we can replace its use
in Chrome, it will be deleted.

BUG=webrtc:6424

Review-Url: https://codereview.chromium.org/2738973004
Cr-Commit-Position: refs/heads/master@{#456021}

This patch replaces
 FrameSeleciton::computeVisibleSelectionInDOMTree().isDirectional()
to
 FrameSeleciton::selectionInDOMTree().isDirectional()
since visible position normalization does not affect selection directional,
to simplify source code for improving code health.

BUG=698633
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2740893003
Cr-Commit-Position: refs/heads/master@{#456020}

Revert of Update DevTools animation timeline to handle TransitionKeyframeEffectModels (patchset #3 id:40001 of https://codereview.chromium.org/2732223002/ )

Reason for revert:
Looks like the test still keeps failing on Mac10.11.  Could look into this?

https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.11%20%28dbg%29/builds/7814

https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.11%20%28dbg%29/builds/7815

Original issue's description:
> Update DevTools animation timeline to handle TransitionKeyframeEffectModels
>
> CSS Transitions was refactored to use TransitionKeyframes instead of
> AnimatableValueKeyframes in https://codereview.chromium.org/2680923005.
> This patch updates the DevTools animation timeline to handle the new
> data type for transitions.
>
> BUG=698669
>
> Review-Url: https://codereview.chromium.org/2732223002
> Cr-Original-Commit-Position: refs/heads/master@{#455333}
> Committed: https://chromium.googlesource.com/chromium/src/+/a7a57ecd7c36b7bd579d45e0f199f7679edc5197
> Review-Url: https://codereview.chromium.org/2732223002
> Cr-Commit-Position: refs/heads/master@{#455995}
> Committed: https://chromium.googlesource.com/chromium/src/+/d20b39ee5745592e03e549d4576783ae03f5d3a9

TBR=dgozman@chromium.org,samli@chromium.org,alancutter@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=698669

Review-Url: https://codereview.chromium.org/2738983005
Cr-Commit-Position: refs/heads/master@{#456019}

Headers generated by IDL compiler bring a lot of binding headers. We should avoid
to include such headers in popular base classes such as EventTarget and Node.

Review-Url: https://codereview.chromium.org/2742573005
Cr-Commit-Position: refs/heads/master@{#456018}

Our implementation checked childTypeAllowed() beforehand.  However, this is not
defined by the DOM standard, and caused some test failures. This CL removes it.

Also, this CL corrects the order of step 3 and step 4 because the above removal
regressed some passing tests, and the order correction recovers them.

BUG=700266

Review-Url: https://codereview.chromium.org/2745533004
Cr-Commit-Position: refs/heads/master@{#456017}

This changes the DCHECKs in disposeContext() to CHECKs and adds a new
CHECK in setGlobal(). This should help catch situations where:
- an already initialized global proxy object is overwritten but not
  reinitialized: this can happen during WebFrame::swap() if the
  embedder tries to access other script contexts, leading to out of sync
  state.
- the global proxy object that WindowProxy retains and the global proxy
  object retained by the v8::Context differ, also leading to out of sync
  state.

BUG=700077

Review-Url: https://codereview.chromium.org/2741923002
Cr-Commit-Position: refs/heads/master@{#456016}

Reland of Added HardwareAccelerationEnabled() function (patchset #1 id:1 of https://codereview.chromium.org/2745733002/ )

Reason for revert:
Ok, looks like this was the wrong one.

Original issue's description:
> Revert of Added HardwareAccelerationEnabled() function (patchset #1 id:1 of https://codereview.chromium.org/2737273003/ )
>
> Reason for revert:
> Speculative revert (will re-revert if false alarm)
>
> To see if reverting this fixes CloudPolicyManagerTest breakage
>
> Original issue's description:
> > Added HardwareAccelerationEnabled() function
> >
> > Added a new utility function to clarify and simplify checking whether
> > hardware acceleration is currently being used.
> >
> > R=emaxx@chromium.org, piman@chromium.org, jbauman@chromium.org
> > BUG=630728
> >
> > Review-Url: https://codereview.chromium.org/2737273003
> > Cr-Commit-Position: refs/heads/master@{#455947}
> > Committed: https://chromium.googlesource.com/chromium/src/+/c0d9fe79fd4582f8170cef92d1e3ad211b5f8518
>
> TBR=emaxx@chromium.org,jbauman@chromium.org,piman@chromium.org,sugoi@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=630728
>
> Review-Url: https://codereview.chromium.org/2745733002
> Cr-Commit-Position: refs/heads/master@{#456006}
> Committed: https://chromium.googlesource.com/chromium/src/+/7fc3177eec8f28989f48e1f45d4cdaec4566890a

TBR=emaxx@chromium.org,jbauman@chromium.org,piman@chromium.org,sugoi@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=630728

Review-Url: https://codereview.chromium.org/2743563005
Cr-Commit-Position: refs/heads/master@{#456015}

The feature has been disabled in M57
(https://codereview.chromium.org/2719473002). Therefore, now we add
fieldtrial_testing_config for the experiment.

BUG=646841

Review-Url: https://codereview.chromium.org/2746453002
Cr-Commit-Position: refs/heads/master@{#456014}

Revert of Statically link libprotobuf_lite on Linux (patchset #2 id:20001 of https://codereview.chromium.org/2746493002/ )

Reason for revert:
Not sure why, but it looks this starts to cause CloudPolicyManagerTest failures.

(Confirmed that locally reverting this CL fixed them)

https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29%2832%29/builds/39213

https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29%2832%29/builds/39214

CloudPolicyManagerTest.Register
CloudPolicyManagerTest.RegisterWithRetry
failed to process gtest output JSON
CloudPolicyProtoTest.VerifyProtobufEquivalence

Original issue's description:
> Statically link libprotobuf_lite on Linux
>
> Chrome has a direct dependency on a custom libprotobuf_lite in
> third_party, but Xenial and Yakkety add a dependency on the system
> libprotobuf-lite via Mir (which gets loaded from Gtk).
>
> Our third_party protobuf is not compatible with the upstream protobuf.
> Combine this with the fact that Xenial uses version 2 while Yakkety
> uses version 3, and it's basically impossible to make our third_party
> protobuf cooperate with the system one.  The solution is to always
> statically link protobuf on Linux.
>
> BUG=79722,700120
> R=pkasting@chromium.org
> TBR=bengr@chromium.org
> CC=dpranke@chromium.org,rsimha@chromium.org
>
> Review-Url: https://codereview.chromium.org/2746493002
> Cr-Commit-Position: refs/heads/master@{#455936}
> Committed: https://chromium.googlesource.com/chromium/src/+/4af1264005620a483a209f4344c3782f62eee69a

TBR=pkasting@chromium.org,bengr@chromium.org,thomasanderson@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=79722,700120

Review-Url: https://codereview.chromium.org/2739203004
Cr-Commit-Position: refs/heads/master@{#456013}

This fixes artifacts in copied textures caused by insufficient precision in
"mediump" floats when used for sampling textures. On a Pixel XL, a mediump
only has 10 bits precision in fragment shaders, that apparently only works
fully for texture dimensions < 1024 pixels. Use "highp" if both GL_ES
and GL_FRAGMENT_PRECISION_HIGH are set for the shader.

(See the bug for more discussion and a proposed alternative patch.)

BUG=700031
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2744793002
Cr-Commit-Position: refs/heads/master@{#456012}

In particular, changes return values from FloatClipRect to const FloatClipRect&,
to avoid extra data structure copies.

In local testing, this CL produces up to a 10% improvement on the
rasterize_and_record_micro.partial_invalidation benchmark.

BUG=692614
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2745563004
Cr-Commit-Position: refs/heads/master@{#456011}

Make TopDocumentRootScrollerController store a Member<Page> instead of
a WeakMember<Page>. TopDocumentRootScrollerController and Page should
live and die at the same time, so this can just be a Member<Page>.

BUG=NONE

Review-Url: https://codereview.chromium.org/2742583002
Cr-Commit-Position: refs/heads/master@{#456010}

A MessageEvent's data value will in some cases hold on to significant
amounts of off-heap memory, so we take care of registering that
external allocation with v8, so that it can be taken into consideration
by the GC triggering logic.

However, when posting a message to another context, we must arrange for
its total 'external allocation' to be associated with the target context.
Including the sizes of any transferables (array buffers), so balance the
books more accurately by also transferring the external allocation cost
of those transferables.

R=
BUG=698981

Review-Url: https://codereview.chromium.org/2734173002
Cr-Commit-Position: refs/heads/master@{#456009}

Also some redundant code is removed.

BUG=698986

Review-Url: https://codereview.chromium.org/2734933006
Cr-Commit-Position: refs/heads/master@{#456008}

TEST=No change in behavior

Review-Url: https://codereview.chromium.org/2740273002
Cr-Commit-Position: refs/heads/master@{#456007}

Revert of Added HardwareAccelerationEnabled() function (patchset #1 id:1 of https://codereview.chromium.org/2737273003/ )

Reason for revert:
Speculative revert (will re-revert if false alarm)

To see if reverting this fixes CloudPolicyManagerTest breakage

Original issue's description:
> Added HardwareAccelerationEnabled() function
>
> Added a new utility function to clarify and simplify checking whether
> hardware acceleration is currently being used.
>
> R=emaxx@chromium.org, piman@chromium.org, jbauman@chromium.org
> BUG=630728
>
> Review-Url: https://codereview.chromium.org/2737273003
> Cr-Commit-Position: refs/heads/master@{#455947}
> Committed: https://chromium.googlesource.com/chromium/src/+/c0d9fe79fd4582f8170cef92d1e3ad211b5f8518

TBR=emaxx@chromium.org,jbauman@chromium.org,piman@chromium.org,sugoi@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=630728

Review-Url: https://codereview.chromium.org/2745733002
Cr-Commit-Position: refs/heads/master@{#456006}

BUG=698853
R=mcasas@chromium.org

Change-Id: I5d9b9e4f1dc7e985fe48a2392afb24eedae45b59
Reviewed-on: https://chromium-review.googlesource.com/452138Reviewed-by: Miguel Casas-Sanchez <mcasas@chromium.org>
Commit-Queue: Philip Jägenstedt <foolip@chromium.org>
Cr-Commit-Position: refs/heads/master@{#456005}

Add a new callback from native CompositorImpl that corresponds to all
swap buffers. Then plumb it up to CompositorView and use it to implement
the draw completion imlementation for the SurfaceView.

Reland: fix bug causing crash when argument is evaluated out of order.

BUG=512636

Review-Url: https://codereview.chromium.org/2716193002
Cr-Original-Commit-Position: refs/heads/master@{#453965}
Committed: https://chromium.googlesource.com/chromium/src/+/eddd0d4f361b16d62eae38b198d6cedde1626186
Review-Url: https://codereview.chromium.org/2716193002
Cr-Commit-Position: refs/heads/master@{#456004}