GitLab

WebRTC 8220:8286
Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/cfe4b49..e898b13

Libjingle 8221:8277
Changes: https://chromium.googlesource.com/external/webrtc/trunk/talk.git/+log/18f533d..e361ce8

TBR=magjed@chromium.org

Review URL: https://codereview.chromium.org/905133002

Cr-Commit-Position: refs/heads/master@{#315221}

This reverts commit 4cf59ffa.

This patch appears to break the contentshell_instrumentation_tests on
the chromium.webkit waterfall. I'm not sure what to do about this,
as the .webkit tests appear to be run in a completely different
way than the .linux (main waterfall) tests, but I'm reverting this
for now and we can sort it out later.

TBR=jbudorick@chromium.org, maruel@chromium.org
BUG=400499

> Author: jbudorick <jbudorick@chromium.org>
> Date:   Fri Feb 6 16:43:24 2015 -0800
>
>     [Android] Convert ContentShellTest.apk to isolate.
>
>     We were previously using --test-data to push files from
>     //content/test/data/android/device_files to
>     $EXTERNAL_STORAGE/chrome/test/data/content. Switching to isolate lets
>     us handle all of our instrumentation and gtest data dependencies in the
>     same way. It will also facilitate using isolate to optimize transfers
>     between builders and testers.
>
>     BUG=400499
>     TBR=maruel@chromium.org
>
>     Review URL: https://codereview.chromium.org/878163004
>
>     Cr-Commit-Position: refs/heads/master@{#315148}

Review URL: https://codereview.chromium.org/886993003

Cr-Commit-Position: refs/heads/master@{#315220}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/fad7ce8..57bdc6e

TBR=

Review URL: https://codereview.chromium.org/907673002

Cr-Commit-Position: refs/heads/master@{#315219}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/5cc0f6c..01d3319

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=stephana@google.com

Review URL: https://codereview.chromium.org/907663002

Cr-Commit-Position: refs/heads/master@{#315218}

Revert of Temporary commit to evaluate perf impact of prototype CPU profiler (patchset #10 id:170001 of https://codereview.chromium.org/888923004/)

Reason for revert:
Reverting temporary commit.

Original issue's description:
> Temporary commit to evaluate perf impact of prototype CPU profiler
>
> Design doc: https://docs.google.com/document/d/1Bv-I1yM9AjgY3t27ixdyWHCAW9IpVx02YQ-nSbIqccc
>
> BUG=
>
> Committed: https://crrev.com/47c6093645b62fbc9f68cf50375fc0626e32516c
> Cr-Commit-Position: refs/heads/master@{#315196}

TBR=cpu@chromium.org,wfh@chromium.org,vadimt@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=

Review URL: https://codereview.chromium.org/904233002

Cr-Commit-Position: refs/heads/master@{#315217}

Since top controls height can now be changed, storing top controls
offset as an absolute value causes problems.  Normalizing its format to
(0, 1) means we we don't need to adjust it when the height changes.  It
also improves readability and means TopControlsManager will compute
correctly even when the height is currently 0.

This patch also switches top controls to use SyncedProperty.

See also Blink-side patch: https://codereview.chromium.org/882683003

BUG=430635

Review URL: https://codereview.chromium.org/901813002

Cr-Commit-Position: refs/heads/master@{#315216}

Follow-up to http://crrev.com/870053006 (which added the methods that accept user-supplied timestamps) and http://crrev.com/892463004 (which modified Blink to use the user-supplied timestamps).

BUG=345845

Review URL: https://codereview.chromium.org/894913006

Cr-Commit-Position: refs/heads/master@{#315215}

BUG=452592

Review URL: https://codereview.chromium.org/909633002

Cr-Commit-Position: refs/heads/master@{#315214}

TBR=machenbach@chromium.org

Review URL: https://codereview.chromium.org/907643002

Cr-Commit-Position: refs/heads/master@{#315213}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/5f27c14..fad7ce8

TBR=

Review URL: https://codereview.chromium.org/903763005

Cr-Commit-Position: refs/heads/master@{#315212}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/1c71d0a..5f27c14

TBR=

Review URL: https://codereview.chromium.org/906763002

Cr-Commit-Position: refs/heads/master@{#315211}

The current crash handler prints a message on logcat of the form
"### WebView crash. Version ..." whenever a crash is detected in an
Android app which happens to have a WebView.
Due to the in-process nature of the WebView, the crash handler is
triggered regardless of the actual cause of the crash, which might be
totally unrelated with the WebView or the chromium codebase at all.
The current wording is misleading as it erroneously suggests that the
crash is always due to the WebView.

BUG=456485
TBR=torne@chromium.org

Review URL: https://codereview.chromium.org/903363003

Cr-Commit-Position: refs/heads/master@{#315210}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/f087214..1c71d0a

TBR=

Review URL: https://codereview.chromium.org/906713003

Cr-Commit-Position: refs/heads/master@{#315209}

Revert of Added MockPresentationClient to use in layout tests. (patchset #1 id:1 of https://codereview.chromium.org/905823004/)

Reason for revert:
This is causing layout failures on the blink bots. They're crashing with the following assertion:

STDERR: [17800:1287:0207/062834:4514258387182:FATAL:mock_presentation_client.cc(34)] Check failed: controller_ != controller && (!controller || !controller_).

Original issue's description:
> Added MockPresentationClient to use in layout tests.
>
> Blink change with the test follows: https://codereview.chromium.org/906673002/
>
> BUG=412331
>
> Committed: https://crrev.com/49a225f6ecb52b805a99d55e9e37ed7e21ef7c1b
> Cr-Commit-Position: refs/heads/master@{#315204}

TBR=mkwst@chromium.org,peter@chromium.org,avayvod@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=412331

Review URL: https://codereview.chromium.org/906753002

Cr-Commit-Position: refs/heads/master@{#315208}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/0692c5f..5cc0f6c

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=stephana@google.com

Review URL: https://codereview.chromium.org/905463008

Cr-Commit-Position: refs/heads/master@{#315207}

Cr-Commit-Position: refs/heads/master@{#315206}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/9c87e95..f087214

TBR=

Review URL: https://codereview.chromium.org/905073002

Cr-Commit-Position: refs/heads/master@{#315205}

Blink change with the test follows: https://codereview.chromium.org/906673002/

BUG=412331

Review URL: https://codereview.chromium.org/905823004

Cr-Commit-Position: refs/heads/master@{#315204}

Revert of Refactored pixel format resize operations in  media/video/capture into a function called VideoCaptu… (patchset #13 id:240001 of https://codereview.chromium.org/897483002/)

Reason for revert:
This breaks the WebRTC real webcam tests on Windows. See for instance http://chromegw.corp.google.com/i/internal.chromium.webrtc/builders/Win7%20Tester/builds/13860. The error is

[2292:2232:0206/211958:997267:FATAL:video_capture_controller.cc(474)] Check failed: static_cast<size_t>(length) >= frame_format.ImageAllocationSize() (0 vs. 614400)

The Win bots are equipped with C920 webcams. I logged into the bot to make sure the webcam was working right - it is as far I can see.

Original issue's description:
> Refactored pixel format resize operations in  media/video/capture into a function called VideoCaptureFormat::GetSizeForVideoPixelFormat().
>
> BUG=
>
> TEST=VideoCaptureDeviceTest.* in media_unittests pass.
>
> Committed: https://crrev.com/79288ba0b63021e8731e0401b8a4a9055d33fa10
> Cr-Commit-Position: refs/heads/master@{#315175}

TBR=mcasas@chromium.org,perkj@chromium.org,emircan@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=

Review URL: https://codereview.chromium.org/898803004

Cr-Commit-Position: refs/heads/master@{#315203}

TBR=machenbach@chromium.org

Review URL: https://codereview.chromium.org/882063009

Cr-Commit-Position: refs/heads/master@{#315202}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/c319d07..0692c5f

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=stephana@google.com

Review URL: https://codereview.chromium.org/889173003

Cr-Commit-Position: refs/heads/master@{#315201}

Track the number of "early" frames received in a QUIC stream.

This will help measure the amount of head of line blocking of the
headers stream that QUIC sees.

Merge internal change: 85643187
https://codereview.chromium.org/893323004/

Remove QUIC's ReceiveAlgorithmInterface now that it does nothing.
No functionality change.

Merge internal change: 85621906
https://codereview.chromium.org/908673002/

Fixing a bug where 0-round-trip connection establishment was conflated
with zero-second-round-trip-time in faster.

Chromium side change is only a comment change.

Merge internal change: 85554888
https://codereview.chromium.org/904993004/

Remove FLAGS_quic_allow_silent_close.

Merge internal change: 85387940
https://codereview.chromium.org/902243003/

Keep an instance of QuicAckFrame in QuicConnection in order to reduce
memory allocations.

Saves 1.5% of the CPU according to profiles.  May be slightly more on
clients.

Merge internal change: 85351635
https://codereview.chromium.org/876313009/

Fix compile errors introduced when editing QuicFramerTest during the
presubmit.

Merge internal change: 85182632
https://codereview.chromium.org/905033002/

Move is_fec_packet from QuicPacket to SerializedPacket in order to allow
QuicSerializedPacket to contain a QuicEncryptedPacket instead in a future CL.

Merge internal change: 85181879
https://codereview.chromium.org/887243005/

R=rch@chromium.org

Review URL: https://codereview.chromium.org/908493004

Cr-Commit-Position: refs/heads/master@{#315200}

As a follow-up for filesystem: URL patch:
https://code.google.com/p/chromium/issues/detail?id=453982

As of http://src.chromium.org/viewvc/blink?view=revision&revision=189570
we started to check non-HTTP(s) schemes in renderer process, so
any requests for registering non-HTTP(s) schemes in the browser
should be considererd malicious / invalid and we should just do
BadMessageReceived().

BUG=455115
TEST=ServiceWorkerDispatcherHostTest.*
TEST=no layout tests should crash swith this change

Review URL: https://codereview.chromium.org/906453002

Cr-Commit-Position: refs/heads/master@{#315199}

WebRtcBrowserTest.RunsAudioVideoWebRTCCallInTwoTabs is assuming that DOM attributes are own properties on a JS obejct, which is not correct.  Blink (binding) team is working to move DOM attributes from own properties to properties on prototype chains, and then this test will break.

This CL fixes the test so that it stringifies not only own properties but also attributes on prototype chains.

BUG=43394

Review URL: https://codereview.chromium.org/904823002

Cr-Commit-Position: refs/heads/master@{#315198}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/551f72a..9c87e95

TBR=apavlov@chromium.org,dpranke@chromium.org

Review URL: https://codereview.chromium.org/905903004

Cr-Commit-Position: refs/heads/master@{#315197}

Design doc: https://docs.google.com/document/d/1Bv-I1yM9AjgY3t27ixdyWHCAW9IpVx02YQ-nSbIqccc

BUG=

Review URL: https://codereview.chromium.org/888923004

Cr-Commit-Position: refs/heads/master@{#315196}

This makes InfoBarLayout more flexible and uses that flexibility to
implement the app banner view.

BUG=442690

Review URL: https://codereview.chromium.org/868663009

Cr-Commit-Position: refs/heads/master@{#315195}

BUG=None
TEST=no functional changes
R=sky@chromium.org

Review URL: https://codereview.chromium.org/867493003

Cr-Commit-Position: refs/heads/master@{#315194}

The banner can fail to be shown for any number of reasons,
from a user navigation to a failed icon fetch.  Record that
the banner could have been shown only right before the
infobar is created.

This fixes situations where a user already had a native app
installed and the website requested a banner for it, which
permanently fills a slot in app dictionary for the site --
even if the Play Store tells the AppBannerManager that the
app is installed and no banner should be shown.

BUG=453170,452825

Review URL: https://codereview.chromium.org/905913002

Cr-Commit-Position: refs/heads/master@{#315193}

Revert of Removing silence trimming from WebRTC quality test. (patchset #5 id:80001 of https://codereview.chromium.org/890893004/)

Reason for revert:
This actually made the score worse by about 0.4 on all bots except one, and one bot is still not helped by this. I will try to solve this through other means, like forcing the volume to the right level on the bots where we get bad scores.

Original issue's description:
> Removing silence trimming from WebRTC quality test
>
> It turns out PESQ can deal with delays, so we don't need to
> silence-trim the files to get them to line up. This solves another
> problem where the silence-trimming becomes too aggressive on Windows
> with the new ref file.
>
> I also need to monitor if the new ref file, which is a lot lower
> in volume than the old one, unfairly punishes the score. The
> speaker volume is a bit random on the bots so the recording could
> end up being quite low. Tests on my workstation suggests that PESQ
> is actually pretty good about ignoring that too though. There will
> be a slight effect on the score (like 0.4 MOS), which I think is
> acceptable. Otherwise we need to find a way to control the speaker
> volume on the bots much more stringently.
>
> BUG=446859
>
> Committed: https://crrev.com/36d358e0cdff201a99501e9c986a8a26f8965a40
> Cr-Commit-Position: refs/heads/master@{#314797}

TBR=henrika@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=446859

Review URL: https://codereview.chromium.org/908703002

Cr-Commit-Position: refs/heads/master@{#315192}

Revert of Added bluetooth LE support on Mac platform (patchset #13 id:340001 of https://codereview.chromium.org/791763005/)

Reason for revert:
Breaks compile:
http://build.chromium.org/p/chromium.mac/builders/Mac%20Builder/builds/17750

../../device/bluetooth/bluetooth_low_energy_discovery_manager_mac.mm:119:30: error: class method '+UUIDWithString:' not found (return type defaults to 'id') [-Werror,-Wobjc-method-access]
      CBUUID* uuid = [CBUUID UUIDWithString:uuidString];
                             ^~~~~~~~~~~~~~

../../device/bluetooth/bluetooth_low_energy_device_mac.mm:82:39: error: use of undeclared identifier 'CBAdvertisementDataIsConnectable'
      [advertisementData objectForKey:CBAdvertisementDataIsConnectable];
                                      ^
../../device/bluetooth/bluetooth_low_energy_device_mac.mm:85:39: error: use of undeclared identifier 'CBAdvertisementDataServiceDataKey'
      [advertisementData objectForKey:CBAdvertisementDataServiceDataKey];
                                      ^
2 errors generated.

Original issue's description:
> Added bluetooth LE support on Mac platform
>
> BUG=449682
>
> Committed: https://crrev.com/42f79f8b08a99190627f3a67e86a378987104a4a
> Cr-Commit-Position: refs/heads/master@{#315190}

TBR=armansito@chromium.org,avi@chromium.org,groby@chromium.org,dvh@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=449682

Review URL: https://codereview.chromium.org/871843009

Cr-Commit-Position: refs/heads/master@{#315191}

BUG=449682

Review URL: https://codereview.chromium.org/791763005

Cr-Commit-Position: refs/heads/master@{#315190}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/d9e63a2..551f72a

TBR=apavlov@chromium.org,dpranke@chromium.org

Review URL: https://codereview.chromium.org/907523004

Cr-Commit-Position: refs/heads/master@{#315189}

Add an API to extract a color transform lookup table in BGRA format, with
(z,y,x) sampling order (B changes the slowest, R the fastest).

See r314425 for speed results, noting that qcms_chain_transform takes 8ms
for a 32-cube since floating-point is used to compute the color transform
to maintain transform precision.

The float data produced by qcms_chain_transform() is stored in the output
in BGRA order (color components are rounded to the nearest 8-bit integer)
with time cost 0.000031 secs. Note that if the data needed re-indexing to
(x,y,z) sampled, RGBA order on writing to the output, the time cost would
be 0.00056 secs (18 times slower) [1].

[1] See r314425 review comments about sampling and pixel order.

BUG=443863

Review URL: https://codereview.chromium.org/892413005

Cr-Commit-Position: refs/heads/master@{#315188}

1. Renamed the CastInitializationStatus enum to OperationalStatus.
2. Renamed CastInitializationCallback to StatusChangeCallback.
3. Documented use of enum and callback.
4. Callbacks may now be run repeatedly to indicate when codec reinit
   occurs (e.g., for a frame size change), and whether runtime errors
   occur after initialization.

BUG=451277

Review URL: https://codereview.chromium.org/901833004

Cr-Commit-Position: refs/heads/master@{#315187}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/d231f16..d9e63a2

TBR=apavlov@chromium.org,dpranke@chromium.org

Review URL: https://codereview.chromium.org/904033009

Cr-Commit-Position: refs/heads/master@{#315186}

TBR=machenbach@chromium.org

Review URL: https://codereview.chromium.org/908683002

Cr-Commit-Position: refs/heads/master@{#315185}

This change bundles together a few minor UI improvements to the bookmark
app creation flow:
- The language for opening as a window vs. a tab is now always 'open as
window', instead of sometimes being 'open as tab'.
- The menu item is now called 'Add to XXXX' where XXXX is the platform
specific shelf / dock / taskbar / desktop.
- The app is now added to the shelf / dock / taskbar / desktop
- Empty or only-whitespace names can no longer be provided.

BUG=452830,450102,447385,447384

Review URL: https://codereview.chromium.org/907473002

Cr-Commit-Position: refs/heads/master@{#315184}

BUG=442930

Review URL: https://codereview.chromium.org/882343004

Cr-Commit-Position: refs/heads/master@{#315183}

* Button cycles between "Install", "Installing", and "Open",
  depending on the installation status of the app being promoted.

* Clicking on the icon or the title of the AppBannerInfoBar should
  send the user to see details about the app that is being promoted.

* Open up access to LinkClicked() from ConfirmInfoBar.
  Piggyback on LinkClicked() to determine that the user wants to
  see the link related to the app.

* Add an ID to the icon of the infobar so it can be retrieved and
  have an OnClickListener attached to it.

* Update the status of the button when the user hops in and out
  of the Chrome application.

BUG=453170

Review URL: https://codereview.chromium.org/871103004

Cr-Commit-Position: refs/heads/master@{#315182}