- 11 Jul, 2018 40 commits
-
-
rbpotter authored
Focus the search box when the dialog is shown. Also add an interactive UI test to verify the behavior and fix the same issue in the advanced settings dialog. Bug: 860139 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I925ba10d10a477dfc526d860d5db108534f4254f Reviewed-on: https://chromium-review.googlesource.com/1130659Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#574079}
-
Min Qin authored
RenderFrameImpl::DownloadUrl() can be abused to trigger a large number of download to overwhelm the browser process. This CL rate limits the number of download to a maximum of 10 per second. Bug: 860045 Change-Id: I490ae3a99eb59aef709b9f1e6be5eb0f787354f4 Reviewed-on: https://chromium-review.googlesource.com/1132485 Commit-Queue: Min Qin <qinmin@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#574078}
-
Tatsuhisa Yamaguchi authored
Close the system tray bubble when these actions are taken. - Switch to another user - Sign in another user - Lock screen Bug: 859041 Test: verified manually Change-Id: Id70d71e73a5c261212bbbb13d52f376275da8002 Reviewed-on: https://chromium-review.googlesource.com/1127914Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Cr-Commit-Position: refs/heads/master@{#574077}
-
Victor Costan authored
LifecycleNotifier currently exposes its internal state (observers_, iteration_state_) to subclasses, and relies on the subclasses to correctly update iteration_state_ while iterating over observers_, like PageVisibilityNotifier::NotifyPageVisibilityChanged() does. Sadly, it's easy to get this wrong, as shown by SynchronousMutationNotifier (does not update iteration_state_ at all) and ContextLifecycleNotifier (only updates iteration_state_ in some cases). This CL makes the LifecycleNotifier state private, and adds a ForEachObserver() method that safely iterates over observers_, encapsulating the needed changes to iteration_state_ and a cast from LifecycleObserverBase* to the desired observer type. Change-Id: Ibb23f2c7e2bba9bdf08d49e8569a354934ed4e11 Reviewed-on: https://chromium-review.googlesource.com/1132674Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#574076}
-
Zhongyi Shi authored
Close non-migratable streams but migrate the rest of the steams when QUIC connection migration migrates to an alternate network. Bug: 791886 Change-Id: Idf803b0e7453ffc1ef44de3209e7cda74e58f64d Reviewed-on: https://chromium-review.googlesource.com/1125525 Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#574075}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/1230eb961dc4..10041796ae14 git log 1230eb961dc4..10041796ae14 --date=short --no-merges --format='%ad %ae %s' 2018-07-11 cphlipot0@gmail.com [ftrace importer] Use tid instead of pid for kernel threads 2018-07-11 cphlipot0@gmail.com [ftrace importer] Fix recursive binder reply arguments 2018-07-11 eakuefner@chromium.org [TBMv2] Implement deduplication fast path for GenericSet 2018-07-10 dtu@chromium.org [pinpoint] Add stubs for Commit and Change. Created with: gclient setdep -r src/third_party/catapult@10041796ae14 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:857283 TBR=sullivan@chromium.org Change-Id: Ieb82b740e4d4b458f5bc5a80efb511d22ff6d36f Reviewed-on: https://chromium-review.googlesource.com/1132444Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#574074}
-
Patti authored
An extremely large number of sites may appear in All Sites, so make sure the client doesn't need to render any more site-entries than required at any one time by converting it to use an iron-list. Also introduce a couple other polish fixes, such as scrolling to a site-entry when it's expanded, or scrolling to the same site-entry previously selected (if any) when navigating back to All Sites from a different route. Bug: 835712 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Ifca117ac6739aed927ca61efeaadcb9057487f5d Reviewed-on: https://chromium-review.googlesource.com/1116204Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Patti <patricialor@chromium.org> Cr-Commit-Position: refs/heads/master@{#574073}
-
David Dorwin authored
Bug: 860549 Change-Id: I803fa84db79846b52daa6430b5864eccac0c57a2 Reviewed-on: https://chromium-review.googlesource.com/1132539Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: David Dorwin <ddorwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#574072}
-
Karan Bhatia authored
This CL ensures that the reserved _metadata folder is not included in the packed extension package. This should be safe as: - Webstore already disallows packages with a _metadata folder. - We already disallow loading unpacked extensions with non-reserved files in the _metadata folder (r502478). This should help ensure that unpacked extensions using the Declarative Net Request API don't have the indexed ruleset in the crx package. BUG=858848 Change-Id: I6d175eae16457531a54818c2d801852dc41df8bc Reviewed-on: https://chromium-review.googlesource.com/1132544 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#574071}
-
Wez authored
Replace call to ZX_DLOG_IF(), which won't reference |result| in builds in which DCHECKs are disabled. Bug: 852541 TBR: rockot Change-Id: I0b8ff421a690691277a4f73730f4c756faf5a17e Reviewed-on: https://chromium-review.googlesource.com/1132488Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#574070}
-
Ryan Sleevi authored
Now that CRLSets no longer use a bespoke delta update mechanism, reduce the amount of internal state that needs to be tracked by the CRLSet. This avoids a duplicating the issuer key hashes. Bug: None Change-Id: Id6d1ba752972b63ac4109a91d2a9e17794cf3b1e Reviewed-on: https://chromium-review.googlesource.com/1132105 Commit-Queue: Ryan Sleevi <rsleevi@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#574069}
-
Alice Boxhall authored
This reverts commit d2099edb. Reason for revert: Seems to be causing test failures, e.g. https://logs.chromium.org/v/?s=chromium%2Fbuildbucket%2Fcr-buildbucket.appspot.com%2F8941335040754288672%2F%2B%2Fsteps%2Fbrowser_tests%2F0%2Flogs%2FCrExtensionsItemsTest.DeveloperState%2F0 Original change's description: > Extensions: remove dependency on iron-icons > > By not including the entire svg sets from iron-icons/ the resulting > md_extensions/vulcanized.html file size reduced from 232.8 kB to > 144.4 kB. > > As a side clean-up thing, the "store" icon is removed from the icons.html > since it's no longer used. > > Bug: 855205 > Cq-Include-Trybots: luci.chromium.try:closure_compilation > Change-Id: Ia19bd8b61425cbff0e3d70cc08a1201856fe0276 > Reviewed-on: https://chromium-review.googlesource.com/1123164 > Commit-Queue: Scott Chen <scottchen@chromium.org> > Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> > Cr-Commit-Position: refs/heads/master@{#574005} TBR=dpapad@chromium.org,scottchen@chromium.org Change-Id: I8182c9d62e79688c8396852440e6367052fd08e8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 855205 Cq-Include-Trybots: luci.chromium.try:closure_compilation Reviewed-on: https://chromium-review.googlesource.com/1132734Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Commit-Queue: Alice Boxhall <aboxhall@chromium.org> Cr-Commit-Position: refs/heads/master@{#574068}
-
Victor Costan authored
instance is LifecycleObserver::iteration_state_. The kAllowPendingRemoval member (bit 2) is not used in assignments to iteration_state_. It follows that code gated on checking for kAllowPendingRemoval to be set will never be called and can be removed, together with kAllowPendingRemoval itself. LifecycleObserver: :IterationState is a bit field enum, and its only Change-Id: I20102103611c27034a6cf10ddbba2b3a498cf642 Reviewed-on: https://chromium-review.googlesource.com/1132614Reviewed-by:
-
Alice Boxhall authored
This reverts commit f8fc8377. Reason for revert: Seems to have caused test failure, e.g: https://logs.chromium.org/v/?s=chromium%2Fbuildbucket%2Fcr-buildbucket.appspot.com%2F8941333431923070448%2F%2B%2Fsteps%2Fheadless_browsertests_on_Ubuntu-16.04%2F0%2Flogs%2FHeadlessProtocolBrowserTest.VirtualTimeDetachFrame%2F0 https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-xenial-rel/1570 Original change's description: > DevTools headless harness: allow loadScript. > > TBR: kvitekp > Change-Id: Ib8fec97ff936788c9e783686531a98929c4b801f > Reviewed-on: https://chromium-review.googlesource.com/1132621 > Reviewed-by: Pavel Feldman <pfeldman@chromium.org> > Commit-Queue: Pavel Feldman <pfeldman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#574035} TBR=pfeldman@chromium.org,kvitekp@chromium.org Change-Id: If4a0971a3d7518597687db68391c87cc880248eb No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/1132635Reviewed-by:
-
Yutaka Hirano authored
This reverts commit 8057f58c. Reason for revert: Crashing. See https://crbug.com/862440. Original change's description: > [Fetch] Use wrapper tracing to express references between wrappers > > BodyStreamBuffer has a ReadableStream instance, but because it's > implemented in V8Extra we cannot holds it as a member (i.e., as a > ScriptValue). Instead, we attach the value to the JS wrapper of the > C++ object. This required us to maintain chains of wrappers, > FetchEvent -> Request -> BodyStreamBuffer for example, manually. > > This CL replaces that mechanism with wrapper tracing. > > Bug: None > Change-Id: I889ef0d0442d62ad50826a4b487ec234f041a982 > Reviewed-on: https://chromium-review.googlesource.com/1124270 > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Adam Rice <ricea@chromium.org> > Reviewed-by: Matt Falkenhagen <falken@chromium.org> > Reviewed-by: Yuki Shiino <yukishiino@chromium.org> > Commit-Queue: Yutaka Hirano <yhirano@chromium.org> > Cr-Commit-Position: refs/heads/master@{#573533} TBR=falken@chromium.org,ricea@chromium.org,yukishiino@chromium.org,yhirano@chromium.org,haraken@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 862440 Change-Id: I4c1bd85ff5f4b078b4c0c56474e279fe83fc5eaa Reviewed-on: https://chromium-review.googlesource.com/1132634 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#574065}
-
Han Leon authored
This CL removes ServiceWorkerUtils::IsServicificationEnabled() and uses blink::ServiceWorkerUtils::IsServicificationEnabled() instead. BUG=789854 Change-Id: I89031cec6ccaa23a8ea0d711fb0e7684d9a370b1 Reviewed-on: https://chromium-review.googlesource.com/1125535Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Han Leon <leon.han@intel.com> Cr-Commit-Position: refs/heads/master@{#574064}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 848b3f07. With Chromium commits locally applied on WPT: a9045946 "Add a fail-fast for longtask layouttests" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/21162 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: guidou@chromium.org: external/wpt/mediacapture-streams meade@chromium.org: external/wpt/web-animations ortuno@chromium.org: external/wpt/bluetooth TBR=kereliuk No-Export: true Change-Id: I6a56a92beb02c28e2459c2488af6ee4d3f531088 Reviewed-on: https://chromium-review.googlesource.com/1132596 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#574063}
-
nacl-chromium-autoroll authored
https://chromium.googlesource.com/native_client/src/native_client.git/+log/030b88a205c9..0ba35b21089a git log 030b88a205c9..0ba35b21089a --date=short --no-merges --format='%ad %ae %s' 2018-07-11 thomasanderson@chromium.org Trigger a buildbot cycle on client.nacl.toolchain Created with: gclient setdep -r src/native_client@0ba35b21089a The AutoRoll server is located here: https://nacl-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:None TBR=mseaborn@chromium.org Change-Id: I054b30fe62eac3fced0f551faf41327f1f903d65 Reviewed-on: https://chromium-review.googlesource.com/1132442Reviewed-by:
nacl-chromium-autoroll <nacl-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: nacl-chromium-autoroll <nacl-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#574062}
-
Yutaka Hirano authored
With this CL, CORSURLLoader doesn't make a preflight request when - The request mode is no-cors, or - cors_preflight_policy is kPreventPreflight . Bug: 736308, 803766 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: If0476052f5ad15cc978187dffc984783719c3d2f Reviewed-on: https://chromium-review.googlesource.com/1126840Reviewed-by:
-
Luciano Pacheco authored
Also fix to be able to open Downloads from RHS. Add |name| attribute for crostini FakeEntry so it can display it on RHS. Add |file-name| attribute on FileTable rows to make it easier to select a single row on tests. Fix crash due to DCHECK on getFileTasksInternal::FileManagerPrivateInternalGetFileTasksFunction where it would fail with entries being empty when we send an array with only FilesAppEntry instances, because the API binding discards objects that aren't native Entry. So we remove non-native entries before calling |FileManagerPrivate.getFileTasks|. Change DirectoryContentScanner to not check for FakeEntry but instead check for the availability of the desired method |createReader| since FilesAppEntry also implements it even though they're non-native (aka FakeEntry). This fixes My Files to display its children on RHS. Change FileFilter to check for attributes existence (filesystem and fullPath) before operating on it. This fixes crostini FakeEntry to be able to be displayed on RHS. Change DirectoryModel to check for non-null VolumeInfo. This fixes this function running for My Files and crostini entries. Bug: 846587, 857335 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Id3cfd1e957db57114c97de1d34a10494dcaaeedb Reviewed-on: https://chromium-review.googlesource.com/1130559 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Sasha Morrissey <sashab@chromium.org> Cr-Commit-Position: refs/heads/master@{#574060}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/1fb73122..88ca18ba Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Icd2f2570cca7f6db120ed430d6c641ba7e3cb5b8 Reviewed-on: https://chromium-review.googlesource.com/1132629Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#574059}
-
Drew Davenport authored
MD5 of RGB thumbnail rendered version of test-25fps.h264, as collected from the logs of a failing test after verifying the thumbnail is correct. TEST=deploy change to device, run test_that video_VideoDecodeAccelerator.h2264 BUG=b:77606672 Change-Id: I9f3d23ce4925c9ca89b37923d2273cf9d1347065 Reviewed-on: https://chromium-review.googlesource.com/1132487Reviewed-by:
Pawel Osciak <posciak@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#574058}
-
Alice Boxhall authored
This reverts commit 3e126191. Reason for revert: Seems to be causing test failures: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.13%20Tests%20%28dbg%29 https://logs.chromium.org/v/?s=chromium%2Fbuildbucket%2Fcr-buildbucket.appspot.com%2F8941340516261567504%2F%2B%2Fsteps%2Fipc_tests%2F0%2Flogs%2FIPCChannelMojoTest.SendFailWithPendingMessages%2F0 Original change's description: > Use BigBuffer for legacy IPC messages > > This replaces use of ReadOnlyBuffer with a new mojom Message type > specific to //ipc. This type maps to another new C++ MessageView type > which in turn wraps a BigBufferView. > > This allows us to transparently fall back onto shared memory for large > IPC messages without increasing the number of copies during send or > receive in any (small- or large-message) cases. > > In order to avoid introducing more mojo-base targets, this also removes > the remaining [Native] structs from mojo_base mojom (LOGFONT and > FileInfo) and replaces them with real mojom structures + StructTraits, > thus allowing //ipc to depend on mojo/public/*/base in its entirety. > > Also fixes random missing public_deps entries for a > chrome/services/file_util typemap, because it decided to start breaking > all of my local builds. :3 > > Bug: 784069 > Change-Id: I359b964ffc1fe44ffd6aa704405ea63156f4fbc9 > Reviewed-on: https://chromium-review.googlesource.com/1131685 > Commit-Queue: Ken Rockot <rockot@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#573956} TBR=dcheng@chromium.org,rockot@chromium.org Change-Id: Id30a64213605fb645e46632589d5ce2a4fbc0077 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 784069 Reviewed-on: https://chromium-review.googlesource.com/1132495Reviewed-by:
-
Zhongyi Shi authored
Currently |migration_pending_| is mixing three invariants together: - connection migration is triggered but no alternate network is available for migration. - connection migration on write error posted, but other direct migration completes, prevent the posted task from being executed. - connection migration on write error is in progress, read error should be ignored. This change explicitly separate out those three invariants: - |wait_for_new_network_| tracks if a migration is triggered and no alternate network is available - MigrateSessionOnWriteError(posted task to handle write error) takes the writer which encountered the write error, and compares with the active writer in use to determine if the migration should be aborted. - |ignore_read_error_| tracks if read error should be ignored. Bug: 818050 Change-Id: Ic6d1c4c95f9da2207901ba985fb662ab0d4abc3c Reviewed-on: https://chromium-review.googlesource.com/1129549 Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
-
Ned Nguyen authored
Bug: 860677 Change-Id: I1eddedd3f751380236854156033bb324ec365581 No-Presubmit: true Reviewed-on: https://chromium-review.googlesource.com/1127845 Commit-Queue: Ned Nguyen <nednguyen@google.com> Reviewed-by:
Emily Hanley <eyaich@chromium.org> Cr-Commit-Position: refs/heads/master@{#574055}
-
Xi Han authored
The service manager thread and (TODO) ServiceManager might be created before the full browser starts, and we want to reuse them when starting the full browser. Therefore, we add a pointer of BrowserStartupData in MainFunctionParams. Particularly, in this CL, ContentMainRunnerImpl creates and owns a BrowserStartupData object. It passes a pointer of the BrowserStartupData through the main function parameter to BrowserMainLoop. The BrowserStartupData interface was introduced in: https://crrev.com/c/1117471. Bug: 846846, 853308 Change-Id: Ie11063227a670cd8d72935131e854ee2b5c46e4e Reviewed-on: https://chromium-review.googlesource.com/1108178 Commit-Queue: Xi Han <hanxi@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#574054}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=govind@chromium.org Change-Id: I5a16cdd72ed714a8eca9b68b5cd919583d54c3f5 Reviewed-on: https://chromium-review.googlesource.com/1132703Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#574053}
-
Andrew Grieve authored
Removes the tool from third_party, as well as gni references to it. This does not remove the logic from the "stack" script, since that may still be useful for running on stacks from older chrome binaries. Bug: 861887 Change-Id: Ifc5372846d41f0e8b013524dd463eb023af1ec00 Reviewed-on: https://chromium-review.googlesource.com/1130005 Commit-Queue: agrieve <agrieve@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#574052}
-
Lily Houghton authored
This CL creates a NetworkService implementation of the PreconnectionStreams function for use in the predictor. Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I5d9ca41e47d96b0a044cb82ca8e07e91a090cbb6 Reviewed-on: https://chromium-review.googlesource.com/1097627 Commit-Queue: Lily Houghton <lilyhoughton@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Helen Li <xunjieli@chromium.org> Cr-Commit-Position: refs/heads/master@{#574051}
-
Tetsui Ohkubo authored
This CL replaces detailed view header icons in UnifiedSystemTray by new ones. Help icon is still not ready on UX side. TEST=manual BUG=842079 Change-Id: Ib8418c2c3ee31d58f1636a01f8a338d4d6a4fa1d Reviewed-on: https://chromium-review.googlesource.com/1127505Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#574050}
-
Lei Zhang authored
The top-level win8 directory does not exist anymore. Change-Id: Iab412299a10e72aa786c789b281f4625baca1ffa Reviewed-on: https://chromium-review.googlesource.com/1132535Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#574049}
-
Gabriel Charette authored
This was extracted from https://chromium-review.googlesource.com/c/chromium/src/+/1088762/17 in an attempt to simplify it (and is now a precursor to it). (MessageLoop::Controller was IncomingTaskQueue::MessageLoopController there but after grokking the resulting CL it's simpler under MessageLoop as done in this CL) This CL splits the logic in IncomingTaskQueue which took care of scheduling the MessageLoop into a dedicated class. In that follow-up CL: MessageLoopTaskRunner will interact directly with the task Observer and take IncomingTaskQueue completely out of the picture (merely a data structure holding various task queues at that point). IncomingTaskQueue also took care of detaching on MessageLoop shutdown which was moved to the new Controller class as well. message_loop.cc is the best place for this extracted logic as it all pertains precisely to MessageLoop's implementation detail (how ScheduleWork should be invoked). This CL simplifies locking as well by having a clear separation between the two locks instead of two locks in the same class used interchangibly. |incoming_queue_lock_| is now strictly for incoming tasks. |message_loop_lock_| is now strictly for ScheduleWork()/DisconnectFromParent(). Note: |message_loop_scheduled_| was dropped as it was redundant (always equal to |!was_empty|). Performance wise, the perf tests show that this change is a noop : * While BasicPostTaskPerfTest became simpler (executed less code) with this CL : The new BasicPostTaskPerfTest w/ MockObserverSimulatingOverhead reintroduces that overhead to show that it's still the same (or slightly in favor of this CL). * And the IntegratedPostTaskPerfTest are the same. * Augmented perf tests to 30 seconds which yields more reliable results. (and ran old ones under 30s mode too when comparing) * Results : https://docs.google.com/spreadsheets/d/100wYvbCI_dJ7gRnQiSsYaTb5OJnbF_muL6LyQWJLXSU/edit Bug: 860252 Change-Id: I22de2409d52414524cc125b0e2fe08e2c516fcbe Reviewed-on: https://chromium-review.googlesource.com/1127262 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#574048}
-
Luciano Pacheco authored
Add both icons for My Files active and inactive. Bug: 846593, 846587 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I718f3374868686ed0aa9480deb83ebf96e9717e4 Reviewed-on: https://chromium-review.googlesource.com/1130557Reviewed-by:
-
Luciano Pacheco authored
During tree update, DirectoryTree expects the NavigationModelItem to be the same instance to be able to find the item in the tree, so this CL changes NavigationListModel to not create a new model instance on |orderAndNestItems_|. Add unittest to VolumeEntry for rootEntry null and resolveDisplayRoot. Add unittest to NavigationListModel to check that MyFiles model is the same across multiple calls to |orderAndNestItems_|. Add integration_test to cover the tree update when an USB volume is mounted. Fix |isDescendantyEntry| to use const instead of let and to work with VolumeEntry with non-resolved rootEntry. Bug: 861978 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I92f76749dd56a134c4b33517dfa3333ed4f01cca Reviewed-on: https://chromium-review.googlesource.com/1130957Reviewed-by:
-
Dirk Pranke authored
It's quite flaky. TBR=martiniss@chromium.org BUG=861730 Change-Id: Id1ec406b75c54451244976108fd44fc1937a1419 Reviewed-on: https://chromium-review.googlesource.com/1132600Reviewed-by:
-
Orin Jaworski authored
This CL will swap the two rows of an answer/entity if the answers are excepted. It is a duplicate of change at crrev.com/c/1112730 but with merge conflict resolved and owner changed. Bug: 855783 Change-Id: I17950c6daa489d7b42c0954195f4bf823383e31b Reviewed-on: https://chromium-review.googlesource.com/1132550Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Orin Jaworski <orinj@chromium.org> Cr-Commit-Position: refs/heads/master@{#574044}
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/144107d3ca6d..cbed949bee84 git log 144107d3ca6d..cbed949bee84 --date=short --no-merges --format='%ad %ae %s' 2018-07-10 hnakashima@chromium.org Add test for reading marked content with an indirect dict. Created with: gclient setdep -r src/third_party/pdfium@cbed949bee84 The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Idd130f58c12c3b6652bec27de47fa5178786d183 Reviewed-on: https://chromium-review.googlesource.com/1132437Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#574043}
-
tzik authored
This CL replaces base::Timer with its subclasses. As base::Timer changes its behavior subject to its construction time flags, that makes hard to see the actual timer behavior, especially it's unclear when a timer is injected from other components. Also, that OnceCallback support of base::Timer is hard to implement on the dynamically determined invocation pattern. Bug: 850247 Change-Id: I699518b6d70fe9f41a6516e11b68997ae7e6fda9 Reviewed-on: https://chromium-review.googlesource.com/1125718Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#574042}
-
Devlin Cronin authored
Add ScriptingPermissionsModifier::RemoveAllGrantedHostPermissions() to revoke all host permissions that were granted to an extension with the runtime host permissions feature. This includes hosts granted through the runtime host permissions feature (using ScriptingPermissionsModifier methods) and hosts granted through optional permissions using the permissions API. This will be used when adjusting extension host permissions in the chrome://extensions page. Bug: 844128 Change-Id: If45bf0024cb31946cba72e1abf06c27b3ed857b5 Reviewed-on: https://chromium-review.googlesource.com/1128381 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#574041}
-
Jinsuk Kim authored
https://crrev.com/c/1112950 didn't quite fix one of the reported bugs https://crbug.com/854499 about webview not getting key input. This CL aims to address it by replacing WebContentsView::RenderFrameSwappedIn with WCV::RenderViewHostChanged, and letting WebContentsImpl call it upon NotifyViewSwapped. Verified, with the change above, that updating focus/native view tree takes effect as expected: - Build/install webview apk: ninja -C out/Default webview_system_apk - Open Gmail or Amazon app - Go to account creation page - Verify that click on input form brings up keyboard, and letters can be typed in Bug: 860173, 860235 Change-Id: Iaf2013bcb2990b70ba8197eee86f0ababca54088 Reviewed-on: https://chromium-review.googlesource.com/1126580Reviewed-by:
Charlie Reis <creis@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#574040}
-
