- 13 Sep, 2017 40 commits
-
-
Bugs Nash authored
This patch - Deleted custom implementations of ParseSingleValue and ParseShorthand since all the properties handled here have been implemented in property APIs. - Added default implementation to generated CSSProprtyAPI header instead - Deleted CSSPropertyAPIBaseCustom.cpp as it was now empty. Bug: 668012 Change-Id: Ib969064802eb2724556f1bfffc12761263d98081 Reviewed-on: https://chromium-review.googlesource.com/664457Reviewed-by:
Jia Meng <jiameng@chromium.org> Commit-Queue: Bugs Nash <bugsnash@chromium.org> Cr-Commit-Position: refs/heads/master@{#501547}
-
Ryo Hashimoto authored
BUG=740063 TEST=build Change-Id: Idbb52590a586dbc55bba52979eec8a2790d8ac60 Reviewed-on: https://chromium-review.googlesource.com/593427Reviewed-by:
Satoru Takabayashi <satorux@chromium.org> Commit-Queue: Ryo Hashimoto <hashimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#501546}
-
Reilly Grant authored
Like mojo::edk::WatcherDispatcher the map within a WatcherSet typically only contains 2 entries and thus a base::flat_map is more appropriate than a full std::map. Change-Id: I7e93ea95c4037468512aa5991672779f8636f8ea Reviewed-on: https://chromium-review.googlesource.com/664179Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#501545}
-
Michael Nordman authored
[AppCache + NetworkService] Support retrieval of appcached resources for navigations that redirect to new locations. Bug: 715632 Change-Id: I675c1ab44cf53121077f87d4beb1abf496e638a6 Reviewed-on: https://chromium-review.googlesource.com/654143Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#501544}
-
Tetsui Ohkubo authored
As a workaround for M62, we were setting default context title |display_source| for some specific notifications. For the detailed background, see the original CL https://crrev.com/c/662501 and the bug https://crbug.com/761900 . As all the caller side fixes have been landed, and the workaround is merged to M62 release branch, we can now remove this. Caller side fix CLs: * ARC notifications https://crrev.com/c/647391 https://crrev.com/c/654119 * Sign-in error notifications https://crrev.com/c/648891 https://crrev.com/c/657138 * HaTS notification https://crrev.com/c/646413 * CUPS notification https://crrev.com/c/648539 TEST=manual BUG=none Change-Id: Ie358b8a2070ff3870629d0b6d46e2a2b2fc9f5ba Reviewed-on: https://chromium-review.googlesource.com/662485Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#501543}
-
Maajid authored
Bug: 763147 Change-Id: I208cb359494aec7c49faa1ced7586532f96b4708 Reviewed-on: https://chromium-review.googlesource.com/656757 Commit-Queue: Maajid <maajid@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Cr-Commit-Position: refs/heads/master@{#501542}
-
Naoki Fukino authored
Fixing a regression by https://codereview.chromium.org/2952043002/. Print Preview requires native paths to write PDF files. I explicitly set NATIVE_PATH as the restriction for save-as dialog, and added a comment about the Google Drive handling of Chrome OS save-as dialog as it is a bit tricky. Bug: 761576 Change-Id: Ibabd428e26cfd0d96a1f65dadc5c0fa4b565e956 Reviewed-on: https://chromium-review.googlesource.com/662920Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Commit-Queue: Naoki Fukino <fukino@chromium.org> Cr-Commit-Position: refs/heads/master@{#501541}
-
Alexandre Elias authored
This reverts commit bfe88542. Reason for revert: Still causes MSAN to fail, theory as to why was wrong. Original change's description: > Reland "Scale heights of BrowserControls in compositor by DSF" > > This is a reland of 030794ca > with deviceScaleFactor obtained from global device to avoid > MSAN problem. > > Original change's description: > > Scale heights of BrowserControls in compositor by DSF > > > > Bug: 737777 > > Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel > > Change-Id: I711e05e8747850041f2c799d3b482da34e7e520d > > Reviewed-on: https://chromium-review.googlesource.com/645906 > > Commit-Queue: Jaebaek Seo <jaebaek@chromium.org> > > Reviewed-by: Alexandre Elias <aelias@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#500841} > > Bug: 737777 > Change-Id: I6a27221ce5baac8573e0f074895a657eaf21183f > Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel > Reviewed-on: https://chromium-review.googlesource.com/662500 > Reviewed-by: Alexandre Elias <aelias@chromium.org> > Commit-Queue: Jaebaek Seo <jaebaek@chromium.org> > Cr-Commit-Position: refs/heads/master@{#501482} TBR=aelias@chromium.org,jaebaek@chromium.org Change-Id: Iad497cd293392108c42d7155ec2ac697f38fcccd No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 737777 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/663569Reviewed-by:
Alexandre Elias <aelias@chromium.org> Commit-Queue: Alexandre Elias <aelias@chromium.org> Cr-Commit-Position: refs/heads/master@{#501540}
-
Kent Tamura authored
Affected *.py are mainly for C++-code generators. This will fix #include paths in generated code. _update_basename() replaces only basenames of checked-in files. So we need to update V8Foo.h individually. Bug: 578345, 760462 Change-Id: I65ebabc2d11f2a50d60bd11b9242adaffc4030c5 Reviewed-on: https://chromium-review.googlesource.com/662877 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#501539}
-
Kenneth Russell authored
BUG=764583 TBR=dpranke@chromium.org Change-Id: Iecad83e72eead668d7ea06f414ebed3d55c6171e Reviewed-on: https://chromium-review.googlesource.com/664437Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#501538}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/36e9ca06..9e197dff Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org Change-Id: I034eada40a15977b7b85540b13c943665cf1a9a7 Reviewed-on: https://chromium-review.googlesource.com/664005Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#501537}
-
Ryan Landay authored
TextSuggestionMenuTest#menuDismissesWhenTappingOutside() was broken in the original CL. It tried to send a touch directly to the WebContents view, bypassing the SuggestionsPopupWindow. In debug builds, this caused a DCHECK from trying to add a second active suggestion marker overlapping the first one, which was actually counted as a test pass. In release builds, the DCHECK wasn't hit, and the menu would close very briefly and reopen, causing a test failure. I talked to changwan@ about if we should fix the test by sending the tap to the SuggestionPopupWindow's content view, and he advised that since dismissing a PopupWindow when tapping outside is built-in behavior, it's sufficient to test that calling SuggestionsPopupWindow.dismiss() behaves properly. This is a reland of 3fc7721d Original change's description: > Add support for Android SuggestionSpans > > This is the final CL to add support for Android SuggestionSpans (at least ones > not marked with FLAG_MISSPELLING; there will be one or more additional CLs to > add support for those). This CL includes: > > - Changes to ImeAdapter to make it pass SuggestionSpans into > InputMethodController > > - Changes to InputMethodController to make it create suggestion markers from the > passed-in SuggestionSpans > > - Additional methods in TextSuggestionController for getting the list of text > suggestions under the cursor, and applying a suggestion > > - More Mojo code to pass information about text suggestions back-and-forth > between browser and renderer code > > - Changes to SuggestionsPopupWindow and TextSuggestionHost so we can show either > a spell check or a text suggestion menu > > Bug: 672259 > Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 > Change-Id: I3f30543586901baec4648d265874a303efafbd44 > Reviewed-on: https://chromium-review.googlesource.com/627172 > Commit-Queue: Ryan Landay <rlanday@chromium.org> > Reviewed-by: Ted Choc <tedchoc@chromium.org> > Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> > Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org> > Reviewed-by: Robert Sesek <rsesek@chromium.org> > Reviewed-by: Alexandre Elias <aelias@chromium.org> > Cr-Commit-Position: refs/heads/master@{#501335} Bug: 672259 Change-Id: I4c893fc7dd74d2a31d032454385ff8e83e7c13a8 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 TBR=tedchoc@chromium.org,yosin@chromium.org,xiaochengh@chromium.org,rsesek@chromium.org,aelias@chromium.org,changwan@chromium.org Change-Id: I4c893fc7dd74d2a31d032454385ff8e83e7c13a8 Reviewed-on: https://chromium-review.googlesource.com/664089 Commit-Queue: Ryan Landay <rlanday@chromium.org> Reviewed-by:
Ryan Landay <rlanday@chromium.org> Cr-Commit-Position: refs/heads/master@{#501536}
-
Andrew Grieve authored
Also adds a test, and a --logcat flag for better matching of logcat lines. Bug: 713710 Change-Id: Ie21030b3c4e68d02cfb2e0d65d2c4c4f00624a80 Reviewed-on: https://chromium-review.googlesource.com/657265Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#501535}
-
Hiroki Nakagawa authored
Before this CL, in ServiceWorkerScriptURLLoader, ServiceWorkerVersion::SetMainScriptHttpResponseInfo() is called regardless of a resource request type. As the function name indicates, that must be called only when the main script of the service worker is being loaded. This CL fixes it. Bug: 748415 Change-Id: Idcf2a295340eaa03bccd4f49b8759cf149665fa9 Reviewed-on: https://chromium-review.googlesource.com/662957 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#501534}
-
Hitoshi Yoshida authored
This change can disable the feature on some environments which are going well, but this is a simple fix to fix the build error on "32-bit ASAN V8 ARM Builders" bots. Bug: 760120 Change-Id: I09dc29b61118409baf7f7b538ce376574df175be Reviewed-on: https://chromium-review.googlesource.com/662962Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#501533}
-
Kunihiko Sakamoto authored
Preload for <script type="module"> was disabled to prevent duplicate loads due to credentials mode mismatch. This patch teaches the preload scanner to set correct fetch parameters for module scripts (credentials mode and always use UTF-8) and re-enable preload. Change-Id: I0defc0b87681357eaccf24dd8f7a4250a0fa86f4 Reviewed-on: https://chromium-review.googlesource.com/658016 Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#501532}
-
chrome-release-bot authored
TBR=anantha@chromium.org Change-Id: I145512480eb7dd7000e529069239cf3884b2dd5c Reviewed-on: https://chromium-review.googlesource.com/664119Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#501531}
-
Han Leon authored
BUG=758151 Change-Id: I3b53764330d046aa95f23f8a388df97408b61111 Reviewed-on: https://chromium-review.googlesource.com/662579Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Han Leon <leon.han@intel.com> Cr-Commit-Position: refs/heads/master@{#501530}
-
Justin Cohen authored
Note this keeps xcode_clang builders on beta 6 until GOMA is updated. This also updates the ability to override the toolchain revision with [IOS|MAC]_TOOLCHAIN_REVISION instead of simply MAC_TOOLCHAIN_REVISION. Bug: Change-Id: I88ba7b1a8c96cf3399e4397bf05611a57bc15b04 Reviewed-on: https://chromium-review.googlesource.com/663410 Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Mike Baxley <baxley@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Reviewed-by:
Sergey Berezin <sergeyberezin@chromium.org> Reviewed-by:
Shenghua Zhang <shenghuazhang@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#501529}
-
Jinsuk Kim authored
ViewAndroid creates a new instance of MotionEventAndroid with a touch point adjusted with the offset of each VA. Since VA now all has zero offset, it is possible to recycle the original MEA instantiated by EventForwarder. This CL implements the logic to avoid unnecessary instantiation of MEA. Bug: 726426 Change-Id: Id780c2ca646dc7f216acf27da9ccfa255a986d36 Reviewed-on: https://chromium-review.googlesource.com/657790 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#501528}
-
Hector Carmona authored
Bug: NONE Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I8d1860a2d4bc144bafa0bbb2a3341d23d6bf1a44 Reviewed-on: https://chromium-review.googlesource.com/625068Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Commit-Queue: Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#501527}
-
Kevin Cernekee authored
If a VPN connection is being managed by the OS, we do not want to let the user connect manually, manipulate its settings, delete it, or get a notification when it disconnects. BUG=696865 TEST=manually create an arcvpn and play around with the UI Change-Id: I6853df43b8e1cc3896c277c761f8de01c498ab99 Reviewed-on: https://chromium-review.googlesource.com/592544 Commit-Queue: Kevin Cernekee <cernekee@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#501526}
-
Yoshifumi Inoue authored
This patch introduces |InsertStyleElement(style_rules)| in |EditingTestBase| for ease of writing test cases using selection text with same STYLE element. Example: InsertStyleElement("p::first-letter { color: red; }"); // Test cases for positions in first-letter part and remaining part. // Following test cases replaces document.body.innerHTML and use style // in HEAD section. EXPECT_EQ("<p>|foo</p>", ... SetSelectionTextToBody("<p>f|oo</p>") ...); EXPECT_EQ("<p>f|oo</p>", ... SetSelectionTextToBody("<p>fo|o</p>") ...); See VisibleUnitsWordTest.StartOfWordBasic for real example. This patch is suggested in the review of patch[1]. [1] http://crrev.com/c/658166 Make SimplifiedBackwardsTextIterator::CopyTextTo() to work correctly for range ending in first-letter part Change-Id: Ied451e1376005f5d2086cc84b3343d7714f1ce1e Reviewed-on: https://chromium-review.googlesource.com/662482Reviewed-by:Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#501525}
-
Ken MacKay authored
Optionally call GetCurrentPTS() for every call to GetMediaTime(), instead of every 250ms. Also update the ALSA version of GetCurrentPts() to be more accurate. BUG= internal b/64273974 Change-Id: I8fbbae970baba8b6207838756f8ed3513ee629a2 Reviewed-on: https://chromium-review.googlesource.com/661717Reviewed-by:
Sergey Volk <servolk@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: Kenneth MacKay <kmackay@chromium.org> Cr-Commit-Position: refs/heads/master@{#501524}
-
Devlin Cronin authored
This test was disabled for being flaky on XP. XP is dead. The test now passes 100 runs on Windows. Bug: 248821 Change-Id: Icda344e6c7c26b5046cbf1d51929cd200792ca6f Reviewed-on: https://chromium-review.googlesource.com/663607Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#501523}
-
Hyungwook Lee authored
Bug: 710276 Change-Id: Iccfad531196cd9789e0cc21d52b06e4205249cd4 Reviewed-on: https://chromium-review.googlesource.com/657998Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#501522}
-
Aidan Wolter authored
This CL adds the required test changes for the recent CL that added the headless argument to CastWebContentsComponent. Bug: None Test: None Change-Id: I7e6a2d229b5c7c78067c158547662463b690f93e Reviewed-on: https://chromium-review.googlesource.com/663300 Commit-Queue: Aidan Wolter <awolter@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#501521}
-
Tom Anderson authored
Now that the Linux packages are going to be built on all of the linux CQ bots, we shouldn't spam the console with miscellaneous info. This CL guards all of the logging behing the VERBOSE flag, but still prints command stdout and stderr when the return code is nonzero. BUG=758654 R=thestig@chromium.org Change-Id: Ia037371b836cbf059d37131a602037c5b972c182 Reviewed-on: https://chromium-review.googlesource.com/656566Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#501520}
-
Brett Wilson authored
Cleans up the remaining references and removes the temporary using statement. Bug: 763556 Change-Id: I25f3cc449bfb7b0da0bd113da3171105d2594188 Reviewed-on: https://chromium-review.googlesource.com/663792 Commit-Queue: Brett Wilson <brettw@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Brett Wilson <brettw@chromium.org> Cr-Commit-Position: refs/heads/master@{#501519}
-
Ahmed Fakhry authored
TaskManager rewrite fixed the assert failure hit by this test. It no longer needs to be disbled. TBR=pkasting@chromium.org BUG=469717 Change-Id: Ifcd406a631953491123792fa61caaf5628d52223 Reviewed-on: https://chromium-review.googlesource.com/663303Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#501518}
-
Alex Moshchuk authored
DevTools audits trigger a ViewMsg_EnableDeviceEmulation on a pending RenderFrameHost (see EmulationHandler::UpdateDeviceEmulationState, via RenderFrameDevToolsAgentHost::AboutToNavigateRenderFrame), which is processed by the frame's widget (WebViewFrameWidget) before the frame commits. In that state, RenderWidget::OnOrientationChange crashed, because even though IsWebFrameWidget() was true for this widget, WebViewFrameWidget::LocalRoot() returned null, since the frame wasn't swapped into the tree yet. The LocalRoot() was then used to send screen orientation change events. It doesn't make sense to fire events on a frame that hasn't committed and isn't in the frame tree yet, so work around this by null-checking LocalRoot(). Bug: 764202, 764206 Change-Id: I26c1c9ce938abb7b18757b88356559a30aa08fec Reviewed-on: https://chromium-review.googlesource.com/662904 Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#501517}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/db91c6e7fbfc..79a3aafc34c1 $ git log db91c6e7f..79a3aafc3 --date=short --no-merges --format='%ad %ae %s' 2017-09-12 benjaminwagner Add Clang GPU tasks. Created with: roll-dep src/third_party/skia Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=stephana@chromium.org Change-Id: I8d472a0dc2385d6f22843a114b26e82963c67d64 Reviewed-on: https://chromium-review.googlesource.com/663894Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#501516}
-
Daichi Hirono authored
Bug: 750997 Test: exo_unittests --gtest_filter=DataOfferTest.* Change-Id: Ic5d06494ae73d7b22e9463a5b303fb7c6a950259 Reviewed-on: https://chromium-review.googlesource.com/625513 Commit-Queue: Daichi Hirono <hirono@chromium.org> Reviewed-by:
David Reveman <reveman@chromium.org> Cr-Commit-Position: refs/heads/master@{#501515}
-
Tetsui Ohkubo authored
This CL adds new material design icon to locale change notification. This CL also adds the notification title and shortens the message based on UX review (https://crbug.com/726241#c20). The icon and the accent color is effective only when chrome://flags/#enable-message-center-new-style-notification is Enabled (which is ToT default). TEST=manual BUG=726241 Change-Id: I16ac609c9f453064e27441c149ef2e4bcfa08d31 Reviewed-on: https://chromium-review.googlesource.com/662917Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#501514}
-
Stephen Martinis authored
TBR=rnephew Bug: 764543 Change-Id: I3d1bb5798f2de5f366a5ef4249d15696866c9586 Reviewed-on: https://chromium-review.googlesource.com/664351Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Reviewed-by:
Walter Korman <wkorman@chromium.org> Reviewed-by:
rnephew <rnephew@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#501513}
-
Chris Cunningham authored
All supported video streams types should map to some VideoCodecProfile. This should be true even for "simple" codecs strings (e.g. VP8 and Theora) that only have one profile (or no formal notion of profile). This allows all codecs to be described simply by the VideoCodecProfile. For instance, media capabilities storage/querying of decode statistics is keyed by VideoCodecProfile. This change adds a profile entry for Theora and ensures that mime parsing code correctly maps to a profile for VP8 and Theora. BUG=695264 TEST=unit test Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I7b48dfc6ab97d436820dae57606a4cf53d92af31 Reviewed-on: https://chromium-review.googlesource.com/658408Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#501512}
-
pdfium-deps-roller@chromium.org authored
https://pdfium.googlesource.com/pdfium.git/+log/5b2092a1ec59..f2ca50ffa2d2 $ git log 5b2092a1e..f2ca50ffa --date=short --no-merges --format='%ad %ae %s' 2017-09-12 tsepez Avoid double va_list traversal in CFX_WideString::FormatV Created with: roll-dep src/third_party/pdfium Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls TBR=dsinclair@chromium.org Change-Id: I987609ebe506e6a02904fa571f0ef37abb30d937 Reviewed-on: https://chromium-review.googlesource.com/663834 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#501511}
-
Philip Jägenstedt authored
Missing teams and components were identified using an ad-hoc script: https://chromium-review.googlesource.com/c/chromium/src/+/657580 Change-Id: I73c13f927f69df3d387ebd182091bc9a55dfff8c Reviewed-on: https://chromium-review.googlesource.com/659017 Commit-Queue: Philip Jägenstedt <foolip@chromium.org> Reviewed-by:
Takeshi Yoshino <tyoshino@chromium.org> Cr-Commit-Position: refs/heads/master@{#501510}
-
Evan Stade authored
message_center::NotificationDelegates. The Chrome specialization of this class just adds an id, but that id is always piped through to the underlying notification as the notification's id, so it's redundant. This patch introduces a new ctor for Chrome's Notification and switches over a couple of delegates. It also removes the delegate_id() pass through from Chrome's Notification since it's always the same as id(). Only a couple of NotificationDelegates are switched to extend message_center::NotificationDelegate, the rest are TODOs. It remains to be seen whether we can remove Chrome's Notification tag, but since the JS provided tag is cooked into the ID and for most non-web notifications the tag is identical to the id, I'm hopeful. TBR=stevenjb@chromium.org Bug: 763426 Change-Id: I69ced05e25129d428318fd10232eb20e7a8c4d0c Reviewed-on: https://chromium-review.googlesource.com/657599 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#501509}
-
Stephen Martinis authored
Bug: 717394 Change-Id: I4f3851f290d996746f209760f00ea8668e6091c8 Reviewed-on: https://chromium-review.googlesource.com/639577Reviewed-by:
Ned Nguyen <nednguyen@google.com> Reviewed-by:
Sean McCullough <seanmccullough@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#501508}
-