- 03 Nov, 2020 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/ed8bd0453f73..d550bebee919 2020-11-03 courtneygo@google.com Fix build error with Chromium & ANGLE (#2446) 2020-11-02 dev@creatingtrouble.com Add new SpirvToolsDisassemble API interface + Improve Doc on existing API interface (#2442) 2020-11-02 justsid@widerwille.com Support for CapabilityShaderViewportIndex and CapabilityShaderLayer (#2432) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Tbr: radial-bots+chrome-roll@google.com,courtneygo@google.com Change-Id: I23d0f1bd2ee18ebc9b77832e8bfb6a7e7e8df8d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517600Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#823581}
-
Clemens Arbesser authored
The intended use case is for a single instance of this class to be shared with all trigger scripts. The combined set of selector conditions will be extracted and is then repeatedly evaluated as necessary. Trigger scripts will simply access the cached results, rather than invoke their computation themselves. This keeps the actual element lookup separate from the trigger scripts, and should also be much more efficient for the common use case where two trigger scripts only differ by is_first_time_user or some other static trigger condition. Bug: b/171776026 Change-Id: I48fad77e32abdfbf39f9414d159b31047b6fba32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514422 Commit-Queue: Clemens Arbesser <arbesser@google.com> Reviewed-by:
Marian Fechete <marianfe@google.com> Cr-Commit-Position: refs/heads/master@{#823580}
-
Michael Checo authored
Spec: http://shortn/_3CsQ13LODA Screenshot: http://shortn/_wsgjicXnSz Bug: 1059779 Test: browser_tests --gtest_filter=ScanningAppBrowserTest.All Change-Id: Ifc823668a2576e3dc36d08494c06f75db53d83db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2511490 Commit-Queue: Michael Checo <michaelcheco@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#823579}
-
Mark Yacoub authored
Make the name more explicit. BUG=N/A TEST=ozone_unittests Change-Id: I99d670333dae9244c34e02ea62e869c7b4e85644 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517419Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Commit-Queue: Mark Yacoub <markyacoub@google.com> Cr-Commit-Position: refs/heads/master@{#823578}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/9bed95f88a26..df4236e338ac 2020-11-03 aerotwist@chromium.org TypeScriptify LiveHeapProfile.js 2020-11-03 jacktfranklin@chromium.org Introduce enableLegacyPatching flag for CSS patching 2020-11-03 tvanderlippe@chromium.org Use TypeScript-authored files in issues/ 2020-11-03 aerotwist@chromium.org TypeScriptify GCActionDelegate.js 2020-11-03 aerotwist@chromium.org TypeScriptify Layers3DView.js If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1122511,chromium:1127902 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I6f53f7466e97b151624a42cf7e47877638eb341f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2516918Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/86f1234a4be8..df4c267aa2c7 2020-11-03 chrome-bot@chromium.org Update config settings by config-updater. 2020-11-03 ziegs@chromium.org ambassador: add ambassador to puff branch builder 2020-11-03 chrome-bot@chromium.org Update config settings by config-updater. 2020-11-02 chrome-bot@chromium.org Update config settings by config-updater. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel Tbr: chrome-os-gardeners@google.com Change-Id: I7610fe85db86e5fce31dc29e33493c455cb3c9f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517599Reviewed-by:
-
Michael Thiessen authored
This reverts commit 9f35be80. Reason for revert: clank rolls all failed, not sure why the clank bot I added didn't fail on my change. Original change's description: > Remove content/ CriteriaNotSatisfiedException > > Part 3 of a 3-sided change to move CriteriaNotSatisfiedException to > base/ > > Bug: 1134178 > Change-Id: Ie76869351d8a09bd92205e3aef3ffea65220c01a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515520 > Reviewed-by: Yaron Friedman <yfriedman@chromium.org> > Commit-Queue: Michael Thiessen <mthiesse@chromium.org> > Cr-Commit-Position: refs/heads/master@{#823553} TBR=yfriedman@chromium.org,mthiesse@chromium.org Change-Id: I0ae020b9af62053f500a9f304c8fb9f9552c657e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1134178 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517382Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#823575}
-
Chris Sharp authored
Specify defaults for: DeviceAllowRedeemChromeOsRegistrationOffers ExternalProtocolDialogShowAlwaysOpenCheckbox MaxInvalidationFetchDelay NtlmV2Enabled SafeBrowsingForTrustedSourcesEnabled SamlInSessionPasswordChangeEnabled ShowAppsShortcutInBookmarkBar SpellcheckEnabled SpellcheckServiceEnabled WPADQuickCheckEnabled Bug: 1139046 Change-Id: Ic3c3b568baa61dd691e94daff631471540221bd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2512549Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Chris Sharp <csharp@chromium.org> Cr-Commit-Position: refs/heads/master@{#823574}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/a77ad8657484..eb999bce4f0f 2020-11-03 robertphillips@google.com Fix GrThreadSafeCache's abandonContext behavior If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bsalomon@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: bsalomon@google.com Change-Id: Ie82b7f9131b3b7f71c09e4ef87e06feb2deea77c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2516914Reviewed-by:
-
Mario Bianucci authored
Delegated ink trails should only ever been drawn on the root render pass as all of their points are transformed to be in the root coordinate space and they are drawn on top of everything. Therefore, make sure that they are only drawn on the root render pass. Bug: 1144354 Change-Id: Ic954e7d9b93895b493c03a89d4fab4e3711b1ca1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2511757Reviewed-by:
weiliangc <weiliangc@chromium.org> Reviewed-by:
Daniel Libby <dlibby@microsoft.com> Commit-Queue: Mario Bianucci <mabian@microsoft.com> Cr-Commit-Position: refs/heads/master@{#823572}
-
Etienne Bergeron authored
Linux requires the presence of a base::DiscardableMemoryAllocator for some fonts handling. This initialization code is taken from the gfx_unittest harness see: ui/gfx/test/run_all_unittests.cc The fuzzer incorrectly reports them as bugs since a nullptr is deferenced. Bug: 1144855 Change-Id: Idfc0888b69fac8a3380659b5469bff0acaa6e806 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2511697 Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#823571}
-
Ian Kilpatrick authored
This patch adds tests for -webkit-fill-available, and changes the legacy implementation to behave like NG does. Bug: 981321 Change-Id: If45f4021c2bcc6d738b7b4cadb24eb285f599860 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514381 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#823570}
-
Jeffrey Kardatzke authored
This adds the H265Decoder (modeled after the H264Decoder) with only handling of SPS/SPS. BUG=chromium:1141237,b:153111783 TEST=media_unittests Change-Id: Ia2dc95675b9c200626e96c500ed91fb4ba27b6dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515040Reviewed-by:
Sergey Volk <servolk@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com> Cr-Commit-Position: refs/heads/master@{#823569}
-
Clemens Arbesser authored
This CL also adds more log messages to make debugging those kinds of errors easier in the future. The bug was introduced in a refactoring some time ago, where the special handling for empty access tokens was lost and there was no unit test to catch this. Bug: b/170934170 Change-Id: Ib251a84fd032f6b72b278bc87aad2a8f48c8df9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517441 Commit-Queue: Clemens Arbesser <arbesser@google.com> Reviewed-by:
Sandro Maggi <sandromaggi@google.com> Cr-Commit-Position: refs/heads/master@{#823568}
-
Majid Valipour authored
Matchs content/public/android/java/src/org/chromium/content/browser/sms/OWNERS Bug: None Change-Id: I95165d25f01225c2ba07f3e749d6a9c085d918f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517380 Auto-Submit: Majid Valipour <majidvp@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#823567}
-
James Hollyer authored
Pointer Lock Options was not set up to run tests while enabled. This CL fixes that and then fixes the necessary tests so that all runs smoothly when the flag is enabled by default. Bug: 1124396 Change-Id: Ie1d9b431b89a4cce77023d9c3aadad4e2d824be2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431459Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: James Hollyer <jameshollyer@chromium.org> Cr-Commit-Position: refs/heads/master@{#823566}
-
Chris Sharp authored
List the defaults for: AccessibilityImageLabelsEnabled AdsSettingForIntrusiveAdsSites AllowScreenWakeLocks ClientCertificateManagementAllowed CrostiniArcAdbSideloadingAllowed DeviceCrostiniArcAdbSideloadingAllowed Bug: 1139046 Change-Id: Ib9325f5739f1c353356af4fd574d126db3f2042b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514619 Commit-Queue: Chris Sharp <csharp@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#823565}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/33fdba02..ba40ae7e Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I2f3e4f59a04026e3030436bec38e7a683ec63fd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517140Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#823564}
-
Peter Kasting authored
Bug: 772945 Change-Id: I44ef7ea9c2e4e7f770860016fc5f1e205e2d1212 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2516882 Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#823563}
-
Aleks Totic authored
Make all rows share the same TableConstraintSpaceData by replacing it if we are reusing the fragment. Bug: 958381 Change-Id: I7647d69d930218f1dfaac2cefdd8a49ba936ceaf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2511431 Commit-Queue: Aleks Totic <atotic@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#823562}
-
chromium-internal-autoroll authored
Release_Notes: http://go/media_app-x20/relnotes/Main/media_app_202011030600_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/W59w4eCMof8bZydvlzS33CNelnDp1ZjryOeIUy5x1Z8C If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/media-app-chromium-autoroll Please CC media-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: b/162468431,b/170172788 Tbr: media-app@grotations.appspotmail.com Change-Id: Idb89546d3bfe436d6bd94717a2810598af329c2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2516912Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#823561}
-
Jan Wilken Dörrie authored
This change implements checking a password for weakness after it has been modified in the Desktop Password Check UI. In case the new password is / remains weak, and will be added / kept in the section of weak passwords. Fixed: 1142377 Change-Id: I03ffc9c087059926fe3f12a50594317235f5383b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514379 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#823560}
-
Denis Kuznetsov authored
Bug: 1144159 Change-Id: I8e945efe328bface5181a3e42155b88801a1c794 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510134 Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Renato Silva <rrsilva@google.com> Cr-Commit-Position: refs/heads/master@{#823559}
-
David Van Cleve authored
The CSP data structures in Blink currently use a value of 0 to denote an unspecified or default-valued port in CSP source expressions. However, origins can also have ports explicitly set to 0. In order to resolve behavior inconsistencies between blink::SecurityOrigin, which currently doesn't support port 0, and url::Origin, which does, we're updating blink::SecurityOrigin to distinguish port-0 origins from origins with unspecified (default-valued) ports. This makes SourceListDirectiveTest.GetSources CSP tests fail, because it means that a "self" CSPSource created by ContentSecurityPolicy::SetupSelf from an origin with the default port will no longer have the same port as a CSPSource created by parsing a host-source source expression with no port. To fix this, we update CSPSource's port_ member to have a new default state denoting an unspecified or default-valued port, distinct from the value 0 which now specifically represents port 0. Bug: 1136678 Change-Id: Ic386fc2ba31e13c95676ecf050e24874d4af132e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2477044 Commit-Queue: David Van Cleve <davidvc@chromium.org> Reviewed-by:
Andy Paicu <andypaicu@chromium.org> Cr-Commit-Position: refs/heads/master@{#823558}
-
Vidhan authored
Added tests for inserting the states data consisting of UTf8 strings in AlternativeStateNameMapUpdater. Bug: 1111960 Change-Id: Iee96de3ceb3b6c3726d7bffc685aab29293c23f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2513215Reviewed-by:
Matthias Körber <koerber@google.com> Reviewed-by:
Christoph Schwering <schwering@google.com> Commit-Queue: Vidhan Jain <vidhanj@google.com> Cr-Commit-Position: refs/heads/master@{#823557}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 2c5003d7. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: rego@igalia.com: external/wpt/css/selectors NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-payments-fyi-rel Change-Id: I6bc3af89ca1ffbb19e1bc550c2822535eba1e2f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517139Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#823556}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: I25cb100a0724ae4d66aa8759f97124d9fcfb3b70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515135Reviewed-by:
Ben Mason <benmason@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#823555}
-
Caitlin Fischer authored
The status quo test compares the actual header with the header returned by GetClientDataHeaders(). However, as discussed in [1], the important thing to verify is that the GOOGLE_WEB_PROPERTIES_SIGNED_ID-associated VariationID is included in the header when expected. Similarly, update the UserNotSignedIn test to check that the ID is not included in the header. Also, remove CreateTrialAndAssociateId() from the browser test file since it now exists in variations_test_utils.h. [1] https://chromium-review.googlesource.com/c/chromium/src/+/2461906/comment/d6233bfd_454a08ff/ Bug: 1134444 Change-Id: I22101a138f930e2b1cfaf4ba3f74211eb87c9a49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508338Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Cr-Commit-Position: refs/heads/master@{#823554}
-
Michael Thiessen authored
Part 3 of a 3-sided change to move CriteriaNotSatisfiedException to base/ Bug: 1134178 Change-Id: Ie76869351d8a09bd92205e3aef3ffea65220c01a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515520Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#823553}
-
Michael Checo authored
Spec: http://shortn/_O6M4tRc5EQ Screenshot: http://shortn/_mosolq202i Bug: 1059779 Test: browser_tests --gtest_filter=ScanningAppBrowserTest.All Change-Id: Icb29009332fea0de87eefacd82259ab695109a21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506302 Commit-Queue: Michael Checo <michaelcheco@google.com> Reviewed-by:
Jimmy Gong <jimmyxgong@chromium.org> Cr-Commit-Position: refs/heads/master@{#823552}
-
Peter Marshall authored
We are no longer passing the API key to the frontend to perform the survey so this CL deletes getAPIKey which is not used. The devtools frontend now triggers the existing Chrome HaTS impl to run the survey. CanShowSurvey will be used to determine whether we show the survey link in the devtools frontend, and then ShowSurvey will be used when the link is clicked. Bug: 1112738 Change-Id: Ia456e419c2678cfe6c90976d82af8d37f1ac435f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2509570 Commit-Queue: Peter Marshall <petermarshall@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#823551}
-
Rainhard Findling authored
Bug: 1087263 Change-Id: Ie404c10b503f7951007ec6eba445fdffe8ab2a3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2513655Reviewed-by:
Joe Mason <joenotcharles@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Commit-Queue: Rainhard Findling <rainhard@chromium.org> Cr-Commit-Position: refs/heads/master@{#823550}
-
Owen Min authored
When previous real time extension request is generated less than 1 minute or haven't got response from the server, all new requests will be batched and wait. In case of any error, the throttler will stop working until the next successfully upload. In case of policy change, the throllter will be deleted or created. The throttle creation is also behind the feature flag. Bug: 1137964 Change-Id: I6b3e7158163959211abc13a77ae07058c8ef99dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505445Reviewed-by:
-
Dave Tapuska authored
This reverts commit f86eb723. Reason for revert: Rolling back for now due to concerns over Service Workers Original change's description: > Enable disallowdocumentaccess > > Allow the ability to restrict same origin documents. > Approved intent to ship https://groups.google.com/a/chromium.org/g/blink-dev/c/TzuPAx9ZOk0/m/5num2KNACAAJ > > https://chromestatus.com/feature/5648946183536640 > > BUG=961448 > > Change-Id: Ic3996eb5015484fd3d3220b357d5b17d50413d60 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417099 > Reviewed-by: Philip Jägenstedt <foolip@chromium.org> > Commit-Queue: Dave Tapuska <dtapuska@chromium.org> > Cr-Commit-Position: refs/heads/master@{#809355} TBR=dtapuska@chromium.org,foolip@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 961448 Change-Id: Idaf3961f6dd1ff3449a75ea1b0a2db6dbb9211a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514962Reviewed-by:
-
Joe Mason authored
Make WebMemoryAggregator owned by its callback instead of by itself so that it is also deleted if the callback is dropped. R=ulan Bug: 1085129 Change-Id: I4a7dcdd208c1b02933cf9e94cfcc6bd84502b3ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515042Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Joe Mason <joenotcharles@chromium.org> Cr-Commit-Position: refs/heads/master@{#823547}
-
Anders Hartvoll Ruud authored
Fixed: 1114808 Change-Id: I75c1afb4158703af75fe53d4b59155730e289e0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2513601Reviewed-by:
Kevin Ellis <kevers@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#823546}
-
Karandeep Bhatia authored
Currently when an optional property fails to parse and error generation is enabled for the schema, the auto-generated Populate function continues parsing the type but still populates error. This CL changes the code to ensure that we raise an error in these cases. We also don't raise an error on unrecognized keys any longer since we shouldn't be raising an error while returning a parse success: Most consumers currently don't distinguish between the two cases and this can lead to the returned error being a concatenation of unrelated errors, which is not ideal. We now enforce the constraint that Populate only returns an error iff there is a parse failure. We DCHECK the same in the auto-generated FromValue function. This also brings the code more in-line with what we do for auto-generated manifest parsing. Currently only 3 schemas use error generation: - declarative_net_request.idl - extensions_manifest_types.json - manifest_types.json The latter two may be affected by the change. In particular, parsing manifest types declared by them may lead to a hard error when an optional property can't be parsed now. BUG=1113513 Change-Id: I63966389e25f7591b4425815d32d9da59d35c3fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500425 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#823545}
-
Stephane Zermatten authored
Before this change, some actions manipulated the Selectors that they were given to add a requirement that the element has a bounding box. This change removes that. Actions use the selectors that were created by the backend, unmodified. This change relies on the backend taking responsibility for generating selector with the appropriate visibility requirement. Bug: b/164956746 Change-Id: Ifeb29d3b61b44b2c0e5a666fc72df79e1da35b96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503553 Commit-Queue: Stephane Zermatten <szermatt@chromium.org> Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Cr-Commit-Position: refs/heads/master@{#823544}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/89cf59f82a6b..9bed95f88a26 2020-11-03 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I363f2307528226b42d5c305940e5f56df34b552f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2516900Reviewed-by:
-
Eric Orth authored
Only significant change is to ignore any params received with alias records. Bug: 1138620 Change-Id: I5d30127b07a5347c6215077ebfb49d0dc8f19b1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515560 Auto-Submit: Eric Orth <ericorth@chromium.org> Commit-Queue: Dan McArdle <dmcardle@chromium.org> Reviewed-by:
Dan McArdle <dmcardle@chromium.org> Cr-Commit-Position: refs/heads/master@{#823542}
-
