GitLab

NOTRY=true

Review URL: https://codereview.chromium.org/400633003

git-svn-id: svn://svn.chromium.org/blink/trunk@178447 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Original patch by Eric Seidel, after a discussion with Behdad.
I rebased it on top of my font fallback fix in r176765, without
which this caching logic would regress (see crbug.com/272006).

Quoting Eric's initial changelog entry:

"The old code used to query FontConfig with the
char and locale for every time Blink needed
a fallback font for a character.

The new code only queries FontConfig once for each
locale, saves the resulting FcFontSet.  When we need
to know the correct font for a char, we walk the
fonts in the set asking each if they have a glyph for
that character.

The existing logic had a bunch of code to work around
bugs where FontConfig would return invalid fonts.
To avoid walking invalid fonts for each lookup
we create a Vector of FontCache objects at CachedFontSet
creation time and only walk valid CachedFonts at
lookup time."

For the list of page_cycler.intl_ja_zh sites,
I locally get the following speedups in warm_times results:
(full data attached to the bug):

3.8397612488521577 www.baidu.com 2090.750000ms 544.500000ms
3.447672499174645 www.yahoo.co.jp 2610.750000ms 757.250000ms
3.268197920237687 cn.yahoo.com 7150.000000ms 2187.750000ms
2.5949379270522566 zol.com.cn 6741.000000ms 2597.750000ms
2.2926255669410383 goo.ne.jp 3412.000000ms 1488.250000ms
2.2606811489527194 www.sina.com.cn 10172.500000ms 4499.750000ms
2.218289901154351 www.qq.com 8023.000000ms 3616.750000ms
2.1029045643153528 2ch.net 633.500000ms 301.250000ms
1.9500301628795496 kakaku.com 4848.750000ms 2486.500000ms
1.844571008634944 fc2.com_ja 2510.000000ms 1360.750000ms
1.8037104522113632 www.google.com.hk 2722.250000ms 1509.250000ms
1.79902755267423 jugem.jp 4162.500000ms 2313.750000ms
1.778485665278118 www.taobao.com_index_global.ph 3629.000000ms 2040.500000ms
1.7573505120581434 ruten.com.tw 5319.500000ms 3027.000000ms
1.7528028651510432 dtiblog.com 5628.250000ms 3211.000000ms
1.5707825244286522 udn.com_NEWS_mainpage.shtm 4862.750000ms 3095.750000ms
1.517787031528852 hatena.ne.jp 3189.250000ms 2101.250000ms
1.5078812316715542 www.amazon.co.j 2056.750000ms 1364.000000ms
1.4083924349881796 mixi.jp 1191.500000ms 846.000000ms

BUG=266214
R=behdad,eae,eseidel

Review URL: https://codereview.chromium.org/342823005

git-svn-id: svn://svn.chromium.org/blink/trunk@178446 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=395127
TBR=tonyg@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/398423005

git-svn-id: svn://svn.chromium.org/blink/trunk@178445 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Should an empty LocalFrame be used, handle this gracefully.

R=
BUG=395032

Review URL: https://codereview.chromium.org/392223003

git-svn-id: svn://svn.chromium.org/blink/trunk@178444 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Review URL: https://codereview.chromium.org/401743004

git-svn-id: svn://svn.chromium.org/blink/trunk@178442 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=

Review URL: https://codereview.chromium.org/399643002

git-svn-id: svn://svn.chromium.org/blink/trunk@178441 bbb929c8-8fbe-4397-9dbb-9b2b20218538

webkit_unit_test_support.h's functions are just thin wrappers that just
call the functions from webkit_support.h. So instead of having this
unnecessary indirection, just call the functions from webkit_support.h
directly.

This is a two side patch. After this lands, Chromium will be update to
remove webkit_unit_test_support.*

BUG=None
TEST=webkit_unit_tests
R=jochen@chromium.org

Review URL: https://codereview.chromium.org/393123005

git-svn-id: svn://svn.chromium.org/blink/trunk@178440 bbb929c8-8fbe-4397-9dbb-9b2b20218538

With http://crrev.com/406523002 making GarbageCollectedMixin a non-abstract
class, MSVC elicits a warning that DLL exported GCMixin classes have a
base class that isn't DLL exported.

Add the needed annotation to GarbageCollectedMixin to address (as warnings
are considered as errors.)

R=haraken@chromium.org,wibling@chromium.org
BUG=382557
NOTRY=true

Review URL: https://codereview.chromium.org/396153003

git-svn-id: svn://svn.chromium.org/blink/trunk@178439 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=johnme@chromium.org
BUG=395103
NOTRY=true

Review URL: https://codereview.chromium.org/400983002

git-svn-id: svn://svn.chromium.org/blink/trunk@178437 bbb929c8-8fbe-4397-9dbb-9b2b20218538

compositing/overflow/scroll-parent-with-non-stacking-context-composited-ancestor.html

BUG=395103
TBR=vollick@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/402893002

git-svn-id: svn://svn.chromium.org/blink/trunk@178436 bbb929c8-8fbe-4397-9dbb-9b2b20218538

With my previous fix for some of the websocket crashes I didn't propagated the fact that the context was destroyed to the base class. This resulted in some cases where we called unobserveContext with where the lifecycle context was actually dead, crashing since further down the stack since it ended up calling on zapped memory. This change should fix that.

R=ager@chromium.org, erik.corry@gmail.com, haraken@chromium.org, oilpan-reviews@chromium.org, tkent@chromium.org, vegorov@chromium.org, zerny@chromium.org
BUG=

Review URL: https://codereview.chromium.org/407493003

git-svn-id: svn://svn.chromium.org/blink/trunk@178435 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=361045

Review URL: https://codereview.chromium.org/405563003

git-svn-id: svn://svn.chromium.org/blink/trunk@178434 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This is following the current state of the specification.

BUG=162827

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178406

Review URL: https://codereview.chromium.org/400703003

git-svn-id: svn://svn.chromium.org/blink/trunk@178433 bbb929c8-8fbe-4397-9dbb-9b2b20218538

If importScripts() evaluation fails, we report the exception wrt the
URL and location of the failing script. Extend that to handle the
nested case, propagating any inner importScripts-induced error event
outwards rather than construct a new one wrt the outer script URL.

R=haraken@chromium.org
BUG=394615

Review URL: https://codereview.chromium.org/404513002

git-svn-id: svn://svn.chromium.org/blink/trunk@178432 bbb929c8-8fbe-4397-9dbb-9b2b20218538

vtable entries for the trace method.

If we get garbage collection during construction of an object with
a virtual trace method we need to make sure that all vtables in
the inheritance hierarchy have entries for the trace method.
Otherwise, we can get out-of-bounds access of a super class vtable.

R=erik.corry@gmail.com, haraken@chromium.org, wibling@chromium.org
BUG=382557

Review URL: https://codereview.chromium.org/406523002

git-svn-id: svn://svn.chromium.org/blink/trunk@178431 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Sources Panel triggered creation of "Sources Panel" section in shortcuts
panel. The variable haven't being used anywhere in the code, and we don't
have a "Sources Panel" any more, thus its safe to remove it.

R=vsevik

Review URL: https://codereview.chromium.org/405583002

git-svn-id: svn://svn.chromium.org/blink/trunk@178430 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=394823

Review URL: https://codereview.chromium.org/400783002

git-svn-id: svn://svn.chromium.org/blink/trunk@178429 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Currently, deletion of a single letter in the end of the
word will trigger autocompletion (if any). As this is considered
disturbing, this patch switches off autocompletion summoning for
this case.

R=vsevik, pfeldman

Review URL: https://codereview.chromium.org/399193002

git-svn-id: svn://svn.chromium.org/blink/trunk@178427 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Follow up r178274 and have FileReader handle the case when it becomes
detached from its document and its frame. Read operations can no longer
go ahead when that is the case, as the throttling controller isn't
available.

R=haraken@chromium.org,horo@chromium.org,nhiroki@chromium.org,kinuko@chromium.org
BUG=394828

Review URL: https://codereview.chromium.org/399863002

git-svn-id: svn://svn.chromium.org/blink/trunk@178426 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Now that corresponding experiment was removed there is no way to see the view. Also removing TimelineFlameChartDataProvider which is not used in tracing based Timeline and we don't show flame chart in other modes.

BUG=361045,394762
R=alph@chromium.org

Review URL: https://codereview.chromium.org/402653002

git-svn-id: svn://svn.chromium.org/blink/trunk@178425 bbb929c8-8fbe-4397-9dbb-9b2b20218538

It's not used.

BUG=394234

Review URL: https://codereview.chromium.org/403673002

git-svn-id: svn://svn.chromium.org/blink/trunk@178424 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This test confirms that changing an input's value on blur event does not cause
 re-focus.

BUG=393168

Review URL: https://codereview.chromium.org/403533002

git-svn-id: svn://svn.chromium.org/blink/trunk@178423 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Currently, ViewportControl uses clientHeight of its main element to
estimate visible viewport height. This falls shortly under the following
scenario:
1. ViewportControl has its "stickToBottom" flag set to true and just
scrolled to bottom as its "refresh" method got executed. Note, that
this refresh has scheduled one more scroll as it "scrolls to bottom".
2. The "refresh" method call figured out that there's a necessity to
render one more element in the beginning of viewport, and this new
element happen to add a horizontal scroll to the console.
3. Another "refresh" method gets executed (it was scheduled in #1)
4. The method figures out that client height changed (due to added
horizontal scroller), thus first element not needed any more and
gets removed from viewport.
5. Goto #1.

This change migrates from using clientHeight to using offsetHeight
which doesn't change as horizontal scroller gets added or removed in
result of viewport rendering.

BUG=387465

Review URL: https://codereview.chromium.org/396853005

git-svn-id: svn://svn.chromium.org/blink/trunk@178422 bbb929c8-8fbe-4397-9dbb-9b2b20218538

If the scrollbar theme changes from being opaque to non-opaque (as happen
when unplugging an external mouse on Mac), a situation results where the
scrollbar layers think they were opaque (because they were when they were
created), but the content that they draw assumes that it is not opaque, and
black scrollbars result.

BUG=383205

Review URL: https://codereview.chromium.org/383603002

git-svn-id: svn://svn.chromium.org/blink/trunk@178421 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The video-specific fullscreen API can hopefully be retired soon, but
if it can't it would still be valuable to get rid of this exemption,
which could incentivise people to use the API.

BUG=346236
R=falken@chromium.org

Review URL: https://codereview.chromium.org/399933002

git-svn-id: svn://svn.chromium.org/blink/trunk@178420 bbb929c8-8fbe-4397-9dbb-9b2b20218538

PartitionAlloc manages memory chunks which are pre-allocated
and re-assigned to the caller which requests memory allocation.
so the top point of stack unwinding is always inside PartitionAlloc
in blink. this can make profiler know wrong allocation point.

if this gyp flag is set, blink uses base allocator.
so that it can show exact callstack where actual allocation is
requested.

Bug=None

Review URL: https://codereview.chromium.org/399333002

git-svn-id: svn://svn.chromium.org/blink/trunk@178419 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=178400

TBR=vollick@chromium.org

Review URL: https://codereview.chromium.org/404673002

git-svn-id: svn://svn.chromium.org/blink/trunk@178417 bbb929c8-8fbe-4397-9dbb-9b2b20218538

base's TestSuite already does this for us, so we can just let it handle
that detail, instead of doing this twice.

BUG=None
TEST=webkit_unit_tests
R=abarth@chromium.org

Review URL: https://codereview.chromium.org/401733002

git-svn-id: svn://svn.chromium.org/blink/trunk@178416 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The Chromium change in question https://codereview.chromium.org/379383002/ will change two JWK errors, requiring the test to be rebased.

BUG=374912
R=rsleevi@chromium.org

Review URL: https://codereview.chromium.org/400533008

git-svn-id: svn://svn.chromium.org/blink/trunk@178414 bbb929c8-8fbe-4397-9dbb-9b2b20218538

If any transition-elements metatags are present, we signal Chrome that this is a transition navigation and serialize the HTML elements designated by the selectors in the transitions-elements metatag.

The isTransitionNavigation flag needs to be passed through both WebFrameClient::decidePolicyForNavigation and WebFrameClient::dispatchDidStartProvisionalLoad to cover both same-origin and different-origin navigation paths.

Requires https://codereview.chromium.org/281383006/

R=esprehn,eseidel
BUG=281383006

Review URL: https://codereview.chromium.org/319573008

git-svn-id: svn://svn.chromium.org/blink/trunk@178413 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=oysteine@chromium.org,oilpan-reviews@chromium.org
BUG=

Review URL: https://codereview.chromium.org/404563006

git-svn-id: svn://svn.chromium.org/blink/trunk@178412 bbb929c8-8fbe-4397-9dbb-9b2b20218538

[Blink] XMLTreeViewer should load resources from blink_resources.grd instead of relying upon xxd.py (Part-1)

Blink should make use of blink_resources.grd for the inline resources for displaying XML tree view.
This removes the dependency upon using xxd.py which embeds the resources as strings.

BUG=312586

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178214

Review URL: https://codereview.chromium.org/394003002

git-svn-id: svn://svn.chromium.org/blink/trunk@178411 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We can simplify the code by createCrossThreadTask.

BUG=392788

Review URL: https://codereview.chromium.org/398293003

git-svn-id: svn://svn.chromium.org/blink/trunk@178409 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Revert of Resolve screen.orientation.lock() promise with undefined. (https://codereview.chromium.org/400703003/)

Reason for revert:
Chromium unit tests fail to compile with this patch on Windows.

http://build.chromium.org/p/chromium.webkit/builders/Win%20Builder/builds/58418

Compilation error:
FAILED: ninja -t msvc -e environment.x86 -- C:\b\build\goma/gomacc "C:\b\depot_tools\win_toolchain\vs2013_files\VC\bin\amd64_x86\cl.exe" /nologo /showIncludes /FC @obj\content\renderer\screen_orientation\content_unittests.screen_orientation_dispatcher_unittest.obj.rsp /c ..\..\content\renderer\screen_orientation\screen_orientation_dispatcher_unittest.cc /Foobj\content\renderer\screen_orientation\content_unittests.screen_orientation_dispatcher_unittest.obj /Fdobj\content\content_unittests.cc.pdb 
c:\b\build\slave\win-latest-rel\build\src\content\renderer\screen_orientation\screen_orientation_dispatcher_unittest.cc(121) :error C2259: 'content::MockLockOrientationCallback' : cannot instantiate abstract class
        due to following members:
        'void blink::WebLockOrientationCallback::onSuccess(void)' : is abstract
        c:\b\build\slave\win-latest-rel\build\src\third_party\webkit\public\platform\weblockorientationcallback.h(26) : see declaration of 'blink::WebLockOrientationCallback::onSuccess'


Original issue's description:
> Resolve screen.orientation.lock() promise with undefined.
> 
> This is following the current state of the specification.
> 
> BUG=162827
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178406

TBR=abarth@chromium.org,mvanouwerkerk@chromium.org,mlamouri@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=162827

Review URL: https://codereview.chromium.org/400623004

git-svn-id: svn://svn.chromium.org/blink/trunk@178408 bbb929c8-8fbe-4397-9dbb-9b2b20218538

In order to allow MediaKeySession to be created only when resolving
the promise, add the ability to set the client callback interface on
WebContentDecryptionModuleSession after the object is created.

BUG=358271
TEST=EME layouts tests pass

Review URL: https://codereview.chromium.org/379343003

git-svn-id: svn://svn.chromium.org/blink/trunk@178407 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This is following the current state of the specification.

BUG=162827

Review URL: https://codereview.chromium.org/400703003

git-svn-id: svn://svn.chromium.org/blink/trunk@178406 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Review URL: https://codereview.chromium.org/396993003

git-svn-id: svn://svn.chromium.org/blink/trunk@178405 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The new GYP/GN variable blink_asserts_always_on (mirroring Chromium's
dcheck_always_on) can be set to 1 to enable assertions in Release
builds.

Tests of NDEBUG related to assertions have been changed to test
ENABLE(ASSERT). Printing/debugging-only code is still guarded under
NDEBUG. Debug-only fields and counters remain debug-only.

Once this CL lands, Blink's assertions will be enabled on the GPU
bots, which only test Release builds (with dcheck_always_on).

Tested:
 - WebGL conformance tests, Release build, asserts on
 - Release build, asserts on, inserted ASSERT(FALSE) guarded under
   ENABLE(ASSERT), verified it was triggered
 - Release build, asserts on, inserted ASSERT(FALSE) guarded under
   ENABLE(SECURITY_ASSERT), verified it was triggered
 - WebGL conformance/context tests, Release build, asserts on, with
   https://codereview.chromium.org/251373005, verified assertion
   failure was triggered
 - WebGL conformance/context tests, Debug build, default assertion
   behavior, with https://codereview.chromium.org/251373005, verified
   assertion failure was triggered
 - wtf_unittests, Release build, asserts on

BUG=393838

Review URL: https://codereview.chromium.org/397733004

git-svn-id: svn://svn.chromium.org/blink/trunk@178404 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This will be used to serialize markup for transition elements, which is then sent to the transition layer.

BUG=370696

Review URL: https://codereview.chromium.org/281383006

git-svn-id: svn://svn.chromium.org/blink/trunk@178403 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Clang does treat the in-class initialization as a definition, just like MSVC.
The problem was that Clang failed to emit the definition unless it was referenced,
which broke the components build. This has been fixed in Clang r213304.

The work-around was added in Blink r176469, and this patch effectively removes that.

BUG=82385

Review URL: https://codereview.chromium.org/397323002

git-svn-id: svn://svn.chromium.org/blink/trunk@178401 bbb929c8-8fbe-4397-9dbb-9b2b20218538