- 16 Sep, 2020 40 commits
-
-
Aaron Colwell authored
This change introduces the ability to differentiate between an invalid process lock (i.e. default constructed) from one that is explicitly willing to allow any site to be placed within it. Historically it was not possible to differentiate these two cases despite the fact that we might want to treat them differently for security purposes. This change introduces code that represents the new concepts and updates the locking code to explicitly transition a process from the invalid state to the "allow_any_site" state. SiteInstanceImpl behavior has changed as follows: 1. Previously, if a SiteInstance didn't require a dedicated process, its process wasn't locked to anything at all, and its lock remained empty. Now, such a SiteInstance will *also* lock its process to the new allow_any_site type of lock. Hence, after this change, any process that has rendered web content *should* have a valid process lock, either an allow_any_site lock or the traditional site-specific lock. Legacy code that still depends on ProcessLock::is_empty() will still work as before because invalid and allow_any_site locks are both considered empty. This will be updated in follow-up changes. 2. Previously, we used to only lock the process *once*, at the first time where we had both the site and the process set. Now, LockProcessIfNeeded() could be called twice for a single process, once when the process is locked to an allow_any_site lock (when a siteless SiteInstance gets a process assigned in SetProcessInternal), and later when the lock is "upgraded" to a site-specific lock (when the SiteInstance calls SetSite). Bug: 1085275 Change-Id: I6c87ab12bd55a05451165943b008d7dc8b09226f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410662 Commit-Queue: Aaron Colwell <acolwell@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Auto-Submit: Aaron Colwell <acolwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#807657}
-
Akihiro Ota authored
This change allows a user to turn ChromeVox off, even if UserActionMonitor is active. This is useful in the tutorial, where some lessons block ChromeVox execution. This change also fixes a closure error in tts_background.js. Bug: 1126135 Change-Id: I583c572dd5017e373022aa6614086dc839e1c9b1 AX-Relnotes: N/A Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412631 Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#807656}
-
Reilly Grant authored
This change implements permissions prompts for the "idle-detection" permission on desktop and Android as well as the necessary site settings UI. Bug: 878979 Change-Id: If5e91bf6fe19ba93c4439ff4eec7fee0ef5fc1d8 TBR: hkamila@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360485 Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Theodore Olsauskas-Warren <sauski@google.com> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#807655}
-
Dale Curtis authored
This reverts commit 3f2f2acf. Reason for revert: https://ci.chromium.org/p/chromium/builders/ci/android-archive-rel/14962? Original change's description: > Android: Add lint regression test > > New API related checks are some of our most valuable lint checks, as > triggering an error causes a crash directly. > > This CL adds compile test targets to ensure that code with API level > errors trigger lint warnings. This prevents lint being accidentally > turned off. > > Also delete now obsolete //build/android/lint directory and remove some > already-fixed suppressions from lint-suppressions.xml. > > Bug: 1108309 > Change-Id: I87e68c85ae6670b1c8a1f0691600e021477c2ff4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412808 > Commit-Queue: Peter Wen <wnwen@chromium.org> > Reviewed-by: Mohamed Heikal <mheikal@chromium.org> > Auto-Submit: Peter Wen <wnwen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#807625} TBR=wnwen@chromium.org,mheikal@chromium.org Change-Id: I7d9d8ed518861233f1f65095fa614ce88c0f2778 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1108309 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414846Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#807654}
-
Thomas Guilbert authored
Currently, when we enter an immersive XRSession, window.rAF calls stops, which means we no longer deliver video.requestVideoFrameCallback calls. This CL adds video.rVFC support to immersive XRSessions. If we find an immersive XRSession, we schedule video.rVFC callbacks there instead of the ScriptedAnimationController (SAC). There can only be one immersive XRSession. If we don't find a session, but we find that the XRFrameProvider exists, we request to be notified when an immersive session start. This allows us to keep callbacks going if the callbacks were already scheduled in the SAC when starting an XRSession. Simmilarly, if the session ends when callbacks were pending in the XRSession, we reschedule ourselves in the SAC. Bug: 1107578 Change-Id: If0acf9445bb789bc848e0043908fc9b769cc5bdd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406522 Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#807653}
-
Carlos Frias authored
This CL updates the OsIntegrationManager::UninstallOsHooks() method to accept an additional |os_hooks| parameter to specify which OS Hooks to uninstall. This CL is in preparation to allow Run on OS Login to be enabled/disabled by the user after the web app is installed, via the OsIntegrationManager::UninstallOsHooks() API. Currently there is no way to uninstall an OS Hook (i.e. Run on OS Login) individually. This CL consists of the following changes: 1. Update OsIntegrationManager::UninstallOsHooks() to honor the passed |os_hooks| and only uninstall the specified OS hooks. 2. Add OsIntegrationManager::UninstallAllOsHooks() API to be replaced in places that currently call UninstallOsHooks() with the intention to effectively uninstall all OS hooks. Bug: 1121372 Change-Id: Ie294f61b9518e997bf4192ac1bdcb7db5bf819fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372819 Commit-Queue: Carlos Frias <carlos.frias@microsoft.com> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#807652}
-
Adrienne Walker authored
Given the uncertainty around whether the probabilistic finch-controlled feature can be rolled out to all users before the existing date, move this date forward another six months. This does overlap with the removal of AppCache and the end of the AppCache origin trial (M90) and so hopefully between AppCache being removed and the finch feature rollout, this is the last time this date will need to be moved. Bug: 582750 Change-Id: I8b21da18ba5a39632542aa8dad168ace15564afb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414988 Commit-Queue: enne <enne@chromium.org> Auto-Submit: enne <enne@chromium.org> Reviewed-by:
Chase Phillips <cmp@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#807651}
-
Irina Fedorova authored
This CL renames and updates GetPlaintextCompromisedPassword, ChangeCompromisedCredential and RemoveCompromisedCredential functions to support both weak and compromised credentials. Bug: 1119752 Change-Id: I88cfdbfc6c4628d624fea401a6fb9b687a6e6e2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410135Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Irina Fedorova <irfedorova@google.com> Cr-Commit-Position: refs/heads/master@{#807650}
-
Xiaohan Wang authored
This reverts commit a98a8fa4. Reason for revert: causing test failure Original change's description: > media: Trigger Infobar on Mac ARM on EME query failure > > CDM on Mac ARM is not ready yet. When requestMediaKeySystemAccess() > fails on Mac ARM, we reject the promise with "Unsupported platform" and > trigger an infobar to notify user. The infobar will be triggered at most > once per render process. > > Since the infobar can only be triggered in the browser process, a new > mojo service CdmInfobarService is added. Note that even though there > already exists KeySystemSupport service, which is also implemented in > the browser process, we cannot trigger the infobar there, because the > infobar requires a WebContents context, while the KeySystemSupport > service is bound to a render process instead of a render frame. > > Change-Id: Ia85a1f2b097b0c2d26d12cc3e9363c34a25691a3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404716 > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> > Reviewed-by: John Rummell <jrummell@chromium.org> > Commit-Queue: Xiaohan Wang <xhwang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#807631} TBR=ellyjones@chromium.org,dcheng@chromium.org,xhwang@chromium.org,jrummell@chromium.org Change-Id: Ia3e06b8685f70b3e3e000df2bbf24054bcc97ada No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414759Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#807649}
-
Ryan Hansberry authored
Includes tweaks to ClientProxy subclasses and the tests that use them, because ClientProxy::OnBandwidthChanged() signature changed. Includes tweaks to BleMedium implementation to account for addition of Fast Advertisement feature, but does not correctly implement their expectations -- that will be done in a subsequent CL. Change-Id: I71fb3f8314abc3439350096243f544cc63e79c02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410652 Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Alex Gough <ajgo@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Cr-Commit-Position: refs/heads/master@{#807648}
-
Mirko Bonadei authored
This CL will allow projects (like WebRTC, see [1]) to configure whether to use XCtest or not on a target by target basis instead of doing it at build level with the GN arg 'enable_run_ios_unittests_with_xctest'. [1] - https://webrtc-review.googlesource.com/c/src/+/184360 Bug: webrtc:11937 Change-Id: Ia227b2f5eb268dc59cfbe5617dbfc4836e6ae372 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414169Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Cr-Commit-Position: refs/heads/master@{#807647}
-
Dirk Pranke authored
The GN template was generating a wrapper using a name different than what we'd expect it to be using. Bug: 1128390 Change-Id: I1f9b0d3c6b4cdcacd2c27d24f87fa3b891d31f98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414918Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Commit-Queue: Dirk Pranke <dpranke@google.com> Cr-Commit-Position: refs/heads/master@{#807646}
-
Carlos IL authored
This also adapts ssl_browsertest.cc with the new behavior (i.e. not removing the lock icon for mixed forms if mixed form warnings are enabled) and removed mixed content from autofill_interactive_uitest.cc Bug: 1105210 Change-Id: I39f6910ac3bdfbbc7d33b719c1d9eca3b7b8ee43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405555 Auto-Submit: Carlos IL <carlosil@chromium.org> Commit-Queue: Jesse Doherty <jwd@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#807645}
-
Hans Wennborg authored
This makes LLD faster, especially when performing ThinLTO. Reduces link time of chrome.dll with 34% in official builds with ThinLTO enabled. It also makes regular (non-goma) builds 6% faster. Bug: 1111798 Change-Id: I12870d5b14bf559b333260347dbb93c7e4fe8a5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398685 Commit-Queue: Hans Wennborg <hans@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Auto-Submit: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#807644}
-
John Williams authored
Bug: 1126456, b/168119924 Change-Id: Ibf372f4eb7c2a75479626a8f542e5b15de461f2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405632Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Commit-Queue: John Williams <jrw@chromium.org> Cr-Commit-Position: refs/heads/master@{#807643}
-
Bo Liu authored
If fragment is stopped due to config change, then there is no need check whether views are attached for visibility since we want to maintain that the active tab is visible in that case. And remove the call to destroy attachment in detach, which is not needed anymore to maintain visibility. And it's probably the source of some crashes caused by destroying attachment too early before all views are detached and the activity destroyed. Bug: 1127246 Change-Id: I863ae612d1015dee433fbabd16dc7c81d82e60c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414668 Commit-Queue: Bo <boliu@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#807642}
-
Maksim Ivanov authored
Fix use-after-move (potential) bug found by the "bugprone-use-after-move" clang-tidy check. Bug: 1122844 Change-Id: Ia0015d61694c30022302375b282dad8ade781c99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2385381Reviewed-by:
Eric Orth <ericorth@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#807641}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/5c4c28f111eb..a787cd5e158b 2020-09-16 gavinmak@google.com Update man files related to merge-base with better description If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: If80b8483f261caae82b6cdd5c5cf561b49ef660d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2415014Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#807640}
-
dpapad authored
Fixed: 1128156 Change-Id: I877090bafdab7708e98747e3375e65d22314823b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411564 Commit-Queue: John Lee <johntlee@chromium.org> Auto-Submit: dpapad <dpapad@chromium.org> Reviewed-by:
John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#807639}
-
Patrick Noland authored
As a consequence of removing getMenuButton, this CL also reduces direct usage of MenuButton in ToolbarPhone/ToolbarTablet, although a few exceptions (getNextFocusForward, animations) remain. Bug: 1086676 Change-Id: Ic1f13733b48a06b34d9ec2484ca2971f79f2f19f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412702Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Patrick Noland <pnoland@chromium.org> Cr-Commit-Position: refs/heads/master@{#807638}
-
Sunny Sachanandani authored
|swap_chain_format_| should be initialized to prevent crashes when calling strlen() on the return value DxgiFormatToString(). Initializing to BGRA matches the behavior prior to adding |swap_chain_format_|. Also guard against such crashes by returning a valid string instead of nullptr from DxgiFormatToString(). Bug: 1129031 Change-Id: I113bca2b7a5899dc270f97089f94c6222b2a71cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414654Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Zhenyao Mo <zmo@chromium.org> Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Auto-Submit: Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#807637}
-
Dale Curtis authored
TBR=sky Bug: 1128183 Change-Id: Iff477f6c3f314a6be1237d59f66916e31786f2d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2415129Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#807636}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/5d45ebc33fa8..587c24edf8c9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC bcwhite@google.com,dalecurtis@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1099917,chromium:1124873,chromium:1127616,chromium:1128831 Tbr: bcwhite@google.com,dalecurtis@google.com Change-Id: I821e42560b9d8a5ab9be07eeea3ed1a06c47a70f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2415013Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#807635}
-
Erik Staab authored
This regressed after crrev.com/c/2106349. Bug: 1127003 Change-Id: I02633c4afadbee3c338d2bc7b4d7a04fac9e545a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405746 Commit-Queue: Erik Staab <estaab@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#807634}
-
Corentin Wallez authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Cross.git/+log/7778792aec71..16d9fea77c37 $ git log 7778792ae..16d9fea77 --date=short --no-merges --format='%ad %ae %s' 2020-09-14 post Implement a simple evaluator of specialization constants. 2020-09-04 cwallez Fix -Wduplicate-enum and -Wrange-for-analysis. 2020-09-04 post Roll glslang/SPIRV-Tools deps. 2020-09-04 post Handle OpUndef %void. 2020-08-27 cdavis MSL: Support layered input attachments. 2020-09-02 post MSL: Fix OpCompositeInsert and OpVectorInsertDynamic. 2020-08-23 cdavis MSL: Don't set the layer for multiview if the device doesn't support it. 2020-08-07 cdavis MSL: Fix multiview view index calculation with a non-zero base instance. 2020-08-24 post Run format_all.sh. 2020-08-24 post Work around annoying warning on GCC 10.2. 2020-08-21 post Overhaul how we deal with reserved identifiers. 2020-08-20 post HLSL: Fix FragCoord.w. 2020-08-20 post HLSL: Deal with partially filled 16-byte word in cbuffers. 2020-08-20 post HLSL: Fix bug in is_packing_standard for cbuffer. 2020-08-13 lehoangq Fix #1445: MSL: Enclose args when convert distance(a,b) to abs(a-b) 2020-08-03 cdavis MSL: Fix handling of matrices and structs in the output control point array. 2020-07-29 post Add some test cases for complex type aliasing scenario. 2020-07-29 post Ensure that we use primary alias type when emitting flattened members. 2020-07-29 post GLSL: Be more aggressive about using type_alias. 2020-07-29 post Only rewrite type aliases for the base type. Created with: roll-dep src/third_party/spirv-cross/spirv-cross Bug: chromium:1126617 Change-Id: I584d429efd6f90b8c1fadb2105d36588e48c4bd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414275 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Commit-Queue: dsinclair <dsinclair@chromium.org> Auto-Submit: Corentin Wallez <cwallez@chromium.org> Reviewed-by:
dsinclair <dsinclair@chromium.org> Cr-Commit-Position: refs/heads/master@{#807633}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1600273595-fec2fba6dfa6bd9b7e3dd69b0eab2bf1cda7b0a9.profdata to chrome-linux-master-1600279142-24a6b7614c1fc4b5002795ef657956153ec745b6.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com,chrome-brapp-engprod@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com,chrome-brapp-engprod@google.com Change-Id: If737bda22fc7ca466e3b3ec95f5f84722970ed3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2415015Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#807632}
-
Xiaohan Wang authored
CDM on Mac ARM is not ready yet. When requestMediaKeySystemAccess() fails on Mac ARM, we reject the promise with "Unsupported platform" and trigger an infobar to notify user. The infobar will be triggered at most once per render process. Since the infobar can only be triggered in the browser process, a new mojo service CdmInfobarService is added. Note that even though there already exists KeySystemSupport service, which is also implemented in the browser process, we cannot trigger the infobar there, because the infobar requires a WebContents context, while the KeySystemSupport service is bound to a render process instead of a render frame. Change-Id: Ia85a1f2b097b0c2d26d12cc3e9363c34a25691a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404716Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
John Rummell <jrummell@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#807631}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: Ia36232871ff71d8ab53dacae15da8759c2163656 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414832Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#807630}
-
Scott Violet authored
With some tips for writing APIs. BUG=none TEST=doc only change Change-Id: I0db43a7a3900d2c951aac245970ddd33ae400a5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412637Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#807629}
-
Patrick Monette authored
This CL refactors WorkerWatcher and adds a ServiceWorkerClient class that will facilitate adding support for service worker clients in the graph. This CL was split from https://chromium-review.googlesource.com/c/chromium/src/+/2355089, which had to be reverted because of crashes on canary. Bug: 993029 Change-Id: Ia2386a8611547dbd9a629ed18fdbee67a8d942aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411652Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Commit-Queue: Patrick Monette <pmonette@chromium.org> Cr-Commit-Position: refs/heads/master@{#807628}
-
Dale Curtis authored
TBR=wychen Bug: 1128345 Change-Id: I8acacd7a065cccd5895f14b8185e88d50dc2644f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414839Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#807627}
-
evliu authored
This CL adds a feature that will be used to dogfood the Speech On-Device API (SODA), which will power the Chrome Live Caption feature. Bug: 1128723 Change-Id: I99724f7ada8117eb6b664e888bd840572169cdb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411341 Commit-Queue: Evan Liu <evliu@google.com> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#807626}
-
Peter Wen authored
New API related checks are some of our most valuable lint checks, as triggering an error causes a crash directly. This CL adds compile test targets to ensure that code with API level errors trigger lint warnings. This prevents lint being accidentally turned off. Also delete now obsolete //build/android/lint directory and remove some already-fixed suppressions from lint-suppressions.xml. Bug: 1108309 Change-Id: I87e68c85ae6670b1c8a1f0691600e021477c2ff4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412808 Commit-Queue: Peter Wen <wnwen@chromium.org> Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Auto-Submit: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#807625}
-
Dale Curtis authored
TBR=timvolodine Bug: 1128184 Change-Id: I6706ce9037397f745a96925898aa48196f40273e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414840Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#807624}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: I0bd3fe7701e87e03395214ba2f16a2cf9743e86f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2415011Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#807623}
-
chinsenj authored
With the InteractiveWindowCycleList flag enabled, hovering an item in the window cycle list scrolls the list to that item and moves the selector over it. This causes an issue if the window cycle list extends past the screen and a user hovers over an item on one of the ends of the list. To address this issue, this CL makes it so hovering an item only moves the selector. Test: Manual Bug: 1067327 Change-Id: Iaba916d7e24391ea8cff6d82c4a405c1e89ccd75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409604 Commit-Queue: Jeremy Chinsen <chinsenj@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#807622}
-
Adam Langley authored
This change mostly updates FidoTunnelDevice to add support for state-assisted (i.e. paired) transactions. That also involves some handshaking updates because the state information signs the claimed public key and so the handshake needs to export a binding value to sign over. BUG=1002262 Change-Id: Ib84886baacef24a8f55014b1a9b33617d0122d11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406834 Commit-Queue: Adam Langley <agl@chromium.org> Auto-Submit: Adam Langley <agl@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#807621}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/1592361414e0..7b1620f36648 2020-09-16 mtklein@google.com refactor skvx min/max 2020-09-16 ethannicholas@google.com moved BinaryExpression's data into IRNode 2020-09-16 michaelludwig@google.com Revert "Enable novel GrClipStack on bots, disable elsewhere" 2020-09-16 mtklein@google.com in fm_bot, use -foo to remove a source 2020-09-16 michaelludwig@google.com Enable novel GrClipStack on bots, disable elsewhere 2020-09-16 mtklein@google.com add another q14x2 test 2020-09-16 robertphillips@google.com Add initial GrThreadSafeUniquelyKeyedProxyViewCache implementation 2020-09-16 nifong@google.com Add a method of returning the list of commands that use an image 2020-09-16 brianosman@google.com Move constant swizzle handling into the IR generator 2020-09-16 johnstiles@google.com Align default values of GrShaderCaps with StandaloneShaderCaps. 2020-09-16 csmartdalton@google.com Add a quadratic cusp to trickycubicstrokes 2020-09-16 johnstiles@google.com Add support for ShaderCapsFactory to skslc. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC scroggo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: chromium:1108408 Tbr: scroggo@google.com Change-Id: Icb58fcc9b4dbb5aed522480400d9fc189238a4fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414854Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#807620}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/78e9acd96726..804db2dde3f1 2020-09-16 kwiberg@webrtc.org UntypedFunction: Eliminate an unnecessary indirection in the implementation 2020-09-16 hta@webrtc.org Test for negotiating pre-stopped M-sections. 2020-09-16 peah@webrtc.org Allow the SwapQueue to utilize user-define swap capability 2020-09-16 hta@webrtc.org Don't expect a transceiver for stopped m-sections If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1127625 Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ib273380e67f4ec6b635087f301fd64ea343d4371 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2415010Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#807619}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/b14a3f7cf6d0..3504e85b742c 2020-09-16 fmayer@google.com Merge changes I26d1c6e5,I9ceaa1ff If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: Ie23dc2b1a791138130c08f5892abc42299b010cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414542Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#807618}
-