- 05 Dec, 2017 40 commits
-
-
Henrique Nakashima authored
Bug: 768982 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I030f371dcbc1fbef3bcc01ce1daa110cd5b6ad1f Reviewed-on: https://chromium-review.googlesource.com/807144Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
dsinclair <dsinclair@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#521845}
-
Wez authored
This test appears to timeout 100% of the time under Linux, so adding the Timeout expectation to prevent it from causing try-bot failures until the issue is addressed. No-Try: true Bug: 789533 Change-Id: I384d355689004eadcf16d6357ed164fca05760a4 Reviewed-on: https://chromium-review.googlesource.com/809826Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Justin Novosad <junov@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#521844}
-
Lukasz Anforowicz authored
Bug: 792162 Change-Id: I9e7fbe7484e914a3af14f808c4a9eb81d2b98228 Reviewed-on: https://chromium-review.googlesource.com/808754Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#521843}
-
Dirk Pranke authored
We are busily converting over the test configs for the waterfalls to the new `generate_buildbot_json` tooling; until everything is converted, and we have docs written for how to use this, we want only a very small number of people making changes to these files. R=kbr@chromium.org, jbudorick@chromium.org BUG=662541 Change-Id: I45432632c914a721fc2704e1b57a02399c624a2f Reviewed-on: https://chromium-review.googlesource.com/809684Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#521842}
-
Xi Han authored
In Chrome: - WebAPK's channel is set under "Sites" notification group and "readable origin" as the channel, the same channel as Webapps. - If the device is Android o+, Chrome will set a channel to the notification. In WebAPK: - WebApkServiceImpl#notifyNotification() is deprecated. Chrome calls notifyNotificationWithChannel() instead. - If on Android O+, WebAPK will ensure the notification channel is created if its notifications have a channel id. To test this change, we need to make sure the following cases all work: - New WebAPK, new Chrome; - New WebAPK, old Chrome; - Old WebAPK, new Chrome. Bug: 700228 Change-Id: I176a8d45f021a33ea441837476b1ca09e973a48b Reviewed-on: https://chromium-review.googlesource.com/786300Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Anita Woodruff <awdf@chromium.org> Commit-Queue: Xi Han <hanxi@chromium.org> Cr-Commit-Position: refs/heads/master@{#521841}
-
Sandra Sun authored
As the first step of ScrollSnapPoints, this patch implements it on main thread at GestureScrollEnd. It introduces necessary data structures: SnapAreaData and SnapContainerData, updates the data after style change and layout, implements a naive algorithm to select snap points at intended-end-position, adds unit-tests for logic and adds sim-tests for behavior. Bug: 778257 Change-Id: I307d51254bd9ab9b7a42b0614d181adac662fa47 Reviewed-on: https://chromium-review.googlesource.com/756887Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Commit-Queue: Sandra Sun <sunyunjia@chromium.org> Cr-Commit-Position: refs/heads/master@{#521840}
-
Mikel Astiz authored
Regression recently introduced in https://chromium-review.googlesource.com/c/chromium/src/+/782563 without apparent failing tests. Bug: Change-Id: I68dfebce4597234d88428bae7a37d10dd99b93d8 Reviewed-on: https://chromium-review.googlesource.com/808928Reviewed-by:
-
Lukasz Anforowicz authored
The CL tweaks StoragePartitonInterceptor (in isolated_origin_browsertest.cc) so that it can be configured to inject different origins, depending on needs of individual tests. This tweak is supported by changes in base/lazy_instance.h (adding of inequality operator implemented on top of the already existing equality operator), and in render_process_host_impl.cc/.h (to support creating a test-only StoragePartitionService via a base::Callback, rather than via a function pointer). Tweaks of StoragePartitonInterceptor allow forking of IsolatedOriginTest.LocalStorageOriginEnforcement test into 2 separate tests: - LocalStorageOriginEnforcement_IsolatedAccessingNonIsolated - LocalStorageOriginEnforcement_NonIsolatedAccessingIsolated The second test is introduced by this CL and was failing before this CL. Tweaks of ChildProcessSecurityPolicyImpl::CanAccessDataForOrigin disallow requests from non-isolated renderers (in which case CheckOriginLock will return NO_LOCK) if the request is for an isolated origin. This makes the new test pass. Bug: 509125, 764958 Change-Id: Ibfff2c91cb2ac51966e1d89295f10592a3814c08 Reviewed-on: https://chromium-review.googlesource.com/775060 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
-
Pavel Feldman authored
DevTools: roll the inspector_protocol to allows crlf in protocol descriptions, update headless generator. Change-Id: I299a8172b86e0b456f12b245077986ae52f4c594 Reviewed-on: https://chromium-review.googlesource.com/807245Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Reviewed-by:
Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#521837}
-
Xi Han authored
Introduce an optional param "raw_manifest_flags" in shell Apk AndroidManifest.xml. It can be filled with: <uses-feature android:name="android.hardware.ram.low" android:required="true" /> if an unbound WebAPK is targeting low ram devices. Bug: 791080 Change-Id: Ie9968ec477a0dbd0694d37aae72f7454fc797ef2 Reviewed-on: https://chromium-review.googlesource.com/809088Reviewed-by:
Glenn Hartmann <hartmanng@chromium.org> Reviewed-by:
-
Jayson Adams authored
In RTL mode a tab transitioning from non-pinned to pinned ends up with no visible favicon. This cl fixes this problem, and also uses the correct tab width to calculate the iconview's position in non-pinned RTL mode. Bug: 789347 Change-Id: I972ef71c47811f9b2a5cf6ca2ac5f2c654d0c2bc Reviewed-on: https://chromium-review.googlesource.com/795151Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Jayson Adams <shrike@chromium.org> Cr-Commit-Position: refs/heads/master@{#521835}
-
Michael van Ouwerkerk authored
In the scenario provided in the bug, the size is initially small like the video popup. All the lifecycle events happen, and then a fresh layout occurs with the full size, making space for the toolbar. Bug: 789958 Change-Id: I528ae2b94f51dd25bc1d259697d35cfc201b6ed7 Reviewed-on: https://chromium-review.googlesource.com/809016Reviewed-by:
Nicolas Dossou-Gbété <dgn@chromium.org> Commit-Queue: Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Cr-Commit-Position: refs/heads/master@{#521834}
-
gogerald authored
IsPossibleNumberImpl is doing exact the same operations as IsPossibleNumberForString Bug: 736387 Change-Id: I093bb9c10befdac73ae67b4a36ad7857e163813e Reviewed-on: https://chromium-review.googlesource.com/809200Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Commit-Queue: Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#521833}
-
Herb Derby authored
Change-Id: I8bcc0d0ff3fec11c2e0dd037a65e025e9c40d607 Reviewed-on: https://chromium-review.googlesource.com/809084Reviewed-by:
Florin Malita <fmalita@chromium.org> Commit-Queue: Herb Derby <herb@chromium.org> Cr-Commit-Position: refs/heads/master@{#521832}
-
Dan Sanders authored
This CL defines a new interface, VideoFrameReleaser, and adds a channel in MojoVideoDecoder to use it, in a way that can outlive the VideoDecoder. On the renderer side, MojoVideoFrameReleaser is ref counted, and will live as long as there are outstanding VideoFrames. On the gpu side, VideoFrameHandleReleaserImpl maintains a map of outstanding VideoFrames, and will live until the map is empty. The old path, with special methods on mojom::VideoDecoder, is removed. VideoDecoder implementations can now attach regular mailbox release callbacks to their VideoFrames and expect normal results. Bug: 737220, 733828 Change-Id: I3c26e1e98c61f180246815fcc79f6731d8a26ed4 Reviewed-on: https://chromium-review.googlesource.com/762104 Commit-Queue: Dan Sanders <sandersd@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#521831}
-
Owen Min authored
Metrics to count whether the verification request will be sent when profile is loaded. Metrics to count the amount of time from profile loaded to verification finished. Bug: 791171 Change-Id: I693eb5bd2289fc7ba7c295dbd45309d1b04ffe26 Reviewed-on: https://chromium-review.googlesource.com/804754Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#521830}
-
Bruce Dawson authored
Chrome cannot build with VS 2015 anymore. Having it listed as a supported compiler can lead to confusion for new Chromium developers. This change scrubs inappropriate '2015' references from the Chromium repo. Bug: 683729 Change-Id: I2e02bc31ae8fd57a31ac65f1bb8a45eb5a5cd433 Reviewed-on: https://chromium-review.googlesource.com/807526 Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#521829}
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/catapult.git/+log/6b77e41141aa..37c17ee783f3 $ git log 6b77e4114..37c17ee78 --date=short --no-merges --format='%ad %ae %s' 2017-12-05 eakuefner [TBMv2] Implement TagMap equality in Python 2017-12-05 perezju [Telemetry] Raise AppCrashException on multiple browser PIDs Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: If1b9b65d1b4a96cc161e28a33ebc9b1868d40f6f Reviewed-on: https://chromium-review.googlesource.com/809532 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#521828}
-
Vlad Tsyrklevich authored
This is a reland of d0de1771 now that crrev.com/00fb4b7e landed fixing the lock-up issue we previously saw. Original change's description: > [CFI] Use ProtectedMemory in CertVerifyProcNSS > > Because CertVerifyProcNSS dynamically resolves a pointer to the function > CERT_CacheOCSPResponseFromSideChannel(), Control Flow Integrity [1] > indirect call (cfi-icall) checking can not verify that it is the > intended target for that function pointer call site. > > Since we can not use cfi-icall to check the function pointer, instead we > place the pointer in ProtectedMemory, a wrapper for keeping variables in > read-only memory except for when they are initialized. After setting the > pointer in protected memory we can use the UnsanitizedCfiCall wrapper to > disable cfi-icall checking when calling it since we know it can not be > tampered with. > > [1] https://www.chromium.org/developers/testing/control-flow-integrity > > Bug: 771365 > Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet > Change-Id: I5d65b3591681f3daa917b6516eec1e5e47513d12 > Reviewed-on: https://chromium-review.googlesource.com/765098 > Reviewed-by: Peter Collingbourne <pcc@chromium.org> > Reviewed-by: Eric Roman <eroman@chromium.org> > Commit-Queue: Peter Collingbourne <pcc@chromium.org> > Cr-Commit-Position: refs/heads/master@{#517169} Bug: 771365 Change-Id: I908d37ce805f6673f96f7eebdba22be45fe96912 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Reviewed-on: https://chromium-review.googlesource.com/783590Reviewed-by:
Eric Roman <eroman@chromium.org> Reviewed-by:
Peter Collingbourne <pcc@chromium.org> Commit-Queue: Peter Collingbourne <pcc@chromium.org> Cr-Commit-Position: refs/heads/master@{#521827}
-
Wez authored
This preference was used to allow NPAPI plugins to be always-authorized, and following their removal only affected whether crashy plugins would continue to be re-loaded. Bug: 418069 Change-Id: I1a50121ca2d2453823e56ddd4a803caa24ee271a Reviewed-on: https://chromium-review.googlesource.com/775911Reviewed-by:
Drew Wilson <atwilson@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#521826}
-
chrome://flagsCharles Harrison authored
Bug: 661629 Change-Id: I39858457456e28ecf4fdf5e7d3c1c875746dae78 Reviewed-on: https://chromium-review.googlesource.com/809201Reviewed-by:
-
Erik Luo authored
Bug: 667560 Change-Id: Id0d481cde735bffe33504486f1378a5f9fbaaec4 Reviewed-on: https://chromium-review.googlesource.com/807401 Commit-Queue: Erik Luo <luoe@chromium.org> Reviewed-by:
Will Chen <chenwilliam@chromium.org> Cr-Commit-Position: refs/heads/master@{#521824}
-
xlai authored
This CL removes RecordingImageBufferSurface. Bug: 776806 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I01e3d77702d92beef2fe73d7ecf7ad51df7ac86d Reviewed-on: https://chromium-review.googlesource.com/809189 Commit-Queue: Olivia Lai <xlai@chromium.org> Reviewed-by:
-
John Abd-El-Malek authored
This isn't needed anymore with URLLoaderInterceptor. Bug: 776589 Change-Id: Ic2a7dd35175e052be7874bc0105e2f758bca26a9 Reviewed-on: https://chromium-review.googlesource.com/809533Reviewed-by:
Yuzhu Shen <yzshen@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#521822}
-
Tibor Goldschwendt authored
Bug: 792098 Change-Id: If75e986571a3490c4d70e22a4748e43b517ba857 Reviewed-on: https://chromium-review.googlesource.com/809099Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#521821}
-
Zhiling Huang authored
llvm symbolizer is a more efficient symbolizer than addr2line, objdump, etc. In this cl, I 1)created a wrapper instance to interact with llvm symbolizer, 2)made the stack script to use llvm symbolizer instance, and then 3)added llvm symbolizer into isolated inputs. Bug: 774267 Change-Id: I971fb808b97f3a569eb9615f99efa41e3a56f3cb Reviewed-on: https://chromium-review.googlesource.com/789376Reviewed-by:
agrieve <agrieve@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Zhiling Huang <hzl@chromium.org> Cr-Commit-Position: refs/heads/master@{#521820}
-
angle-deps-roller@chromium.org authored
https://chromium.googlesource.com/angle/angle.git/+log/4fba4a97bc08..12a18ad357bc $ git log 4fba4a97b..12a18ad35 --date=short --no-merges --format='%ad %ae %s' 2017-12-01 oetuaho Simplify interface block instance recording 2017-12-01 cwallez Add PackedEnumBitSet, use it for buffer binding validation Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=geofflang@chromium.org Change-Id: Iacf96120475548f6001870a1f790ba7986917093 Reviewed-on: https://chromium-review.googlesource.com/809539Reviewed-by:
angle-deps-roller . <angle-deps-roller@chromium.org> Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#521819}
-
Yuwei Huang authored
* Removed the no-goma assertion since the bug has already been resolved. * Changed the CC and CXX command to reflect the changes in the analyzer wrapper script. (crrev.com/2667853004 and crrev.com/2748793004) Bug: 791239 Change-Id: I0c7470213eb769e19f4db64fbb0421ee99a9a06e Reviewed-on: https://chromium-review.googlesource.com/804607Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Yuwei Huang <yuweih@chromium.org> Cr-Commit-Position: refs/heads/master@{#521818}
-
CrystalFaith authored
Content script and Page Action sample extension that demos auto/programmatic insertion by highlighting html elements that contain user inserted words. Bug: None Change-Id: I4d4887777dfdc4d76f45ad923b2bb5d297faed39 Reviewed-on: https://chromium-review.googlesource.com/707296 Commit-Queue: Crystal Lambert <crystallambert@chromium.org> Reviewed-by:
-
Jonathan Backer authored
This CL is part of the effort to have a separate RasterInterface implementation in the the GPU process. After this CL, --enable-raster-decoder will cause - a RasterInterface client to have a RasterCmdBuffStub on the server side and - a GLES2Interface client to have a GLES2CmdBuffStub on the server side With this CL, RasterCmdBuffStub and GLES2CmdBuffStub only differ in that RasterCmdBuffStub insists on being associated with an offscreen context. In the future, {Raster,GLES2}CmdBuffStub will diverge. Soon RasterCmdBuffStub will have a special RasterDecoder decoder. Bug: 789238 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I313868192ccbd1c17c102ae1bb91c46a528b178d Reviewed-on: https://chromium-review.googlesource.com/796951Reviewed-by:Victor Miura <vmiura@chromium.org> Commit-Queue: Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#521816}
-
Ovidio Henriquez authored
This change updates the filter-matches.html test to use the Web Bluetooth Test interface. This will help us migrate the test to the wpt/ directory, since testRunner is not going to be used anymore. BUG=509038 Change-Id: Id53632e8b3c7a979c29904f53fbea2d5a5f7f3bc Reviewed-on: https://chromium-review.googlesource.com/783498 Commit-Queue: Ovidio Henriquez <odejesush@google.com> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Vincent Scheib <scheib@chromium.org> Reviewed-by:
Conley Owens <cco3@chromium.org> Cr-Commit-Position: refs/heads/master@{#521815}
-
Paul Jensen authored
NetworkHandles should be supported in Lollipop and newer releases. Change-Id: Ia19095b883926daf97456d81201a3e8d93859467 Reviewed-on: https://chromium-review.googlesource.com/809224 Commit-Queue: Paul Jensen <pauljensen@chromium.org> Reviewed-by:
Helen Li <xunjieli@chromium.org> Cr-Commit-Position: refs/heads/master@{#521814}
-
Scott Violet authored
Previously the code queried TestScreen. This is problematic as content_browsertests uses TestScreen, which *always* returns a display id of 2000. When mus gets the event the event is then dropped (because it doesn't know about 2000). This changes EventInjector to query WindowTreeHost and has WindowTreeHostMus override GetDisplayId() to return the real display id. BUG=786453 TEST=none Change-Id: I01b9ce9096a0a3e7d6ca9cf85706afb0213035a7 Reviewed-on: https://chromium-review.googlesource.com/809493Reviewed-by:
Elliot Glaysher <erg@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#521813}
-
Dale Curtis authored
This has been unnecessary in the past with YouTube VP9 encodings, but for some reason other VP9 encoding types show artifacts if the configuration change is not processed. BUG=729600 TEST=no more artifacts on http://dashjs.eb.epiclabs.io/ Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Id91f112ff8a1f1877cade3e8a86af39b05ff80a0 Reviewed-on: https://chromium-review.googlesource.com/802629 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#521812}
-
Nate Fischer authored
This removes the final use of BuildInfo.isAtLeastO from chromium code. This was previously blocked on robolectric not supporting O (but this has since been resolved by crbug.com/729135). Bug: 783418 Test: ninja chrome_junit_tests Change-Id: Ib7d4af9ff74912ccadfa3c9cae57553f3a217e94 Reviewed-on: https://chromium-review.googlesource.com/806745Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#521811}
-
Chromium WPT Sync authored
Using wpt-import in Chromium a3ce2d31. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/6949 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md TBR=qyearsley No-Export: true Change-Id: I1855fb7a5a8fdc38751eea78ed990db382a84f5f Reviewed-on: https://chromium-review.googlesource.com/809188 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#521810}
-
Hiroshige Hayashizaki authored
This CL only adds |const| to SecurityOrigin and thus doesn't change the behavior. This CL replaces most of - WebPrivatePtr<SecurityOrigin> -> WebPrivatePtr<const SecurityOrigin> - scoped_refptr<SecurityOrigin> -> scoped_refptr<const SecurityOrigin> - SecurityOrigin* -> const SecurityOrigin* - SecurityOrigin& -> const SecurityOrigin& Most of the modifications are done mechanically by PCRE: s/(WebPrivatePtr<|scoped_refptr<|((?<!const)\s+)|\(|^)((::)?blink::)?SecurityOrigin([&\*>])/$1const $3SecurityOrigin$5/g The following SecurityOrigin references remain non-const: - SecurityContext::security_origin_ - SecurityContext::GetMutableSecurityOrigin() - ExecutionContext::GetMutableSecurityOrigin() - Document::UpdateSecurityOrigin() - RemoteSecurityContext::SetReplicatedOrigin() - SecurityOrigin::IsolatedCopy() - Some local variables - Some methods in unit tests (For isolated world SecurityOrigin for XHRs) - IsolatedWorldSecurityOriginMap - XMLHttpRequest()::isolated_world_security_origin_ - XMLHttpRequest::XMLHttpRequest() - XMLHttpRequest::GetMutableSecurityOrigin() - DOMWrapperWorld::IsolatedWorldSecurityOrigin() - DOMWrapperWorld::SetIsolatedWorldSecurityOrigin() (For blob SecurityOrigins) - BlobURLOriginMap - SecurityOrigin::Create.*() - URLRegistry::RegisterURL() - BlobRegistry::RegisterPublicBlobURL() - URLSecurityOriginMap::GetOrigin() Bug: 779730 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ie4a1a5cc2add20c1c1b9d0d6d5dff9ea9ec46240 Reviewed-on: https://chromium-review.googlesource.com/744586 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#521809}
-
Lei Zhang authored
Also rewrite some if-else statements without if (!cond). Change-Id: If70a32a7baa5d2e70480831646ebf46eea8b8993 Reviewed-on: https://chromium-review.googlesource.com/804833Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#521808}
-
Thoren Paulson authored
Before, we weren't packaging localized pak files with the Android cast shell, and ResourceBundle wasn't looking in the APK assets for these pak files. Bug: internal b/70031131 Test: CQ and tried it out with an Android build Change-Id: I65adbaf552dfce6be62c4c4035d221f42b330c4d Reviewed-on: https://chromium-review.googlesource.com/807406Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: Thoren Paulson <thoren@chromium.org> Cr-Commit-Position: refs/heads/master@{#521807}
-
Vladimir Levin authored
This patch ensures that we initialize all font creation params before reading them and abort creating a typeface if the reader is invalid. R=enne@chromium.org, ericrk@chromium.org Bug: 785675 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I7baabeb460c9cb06026c8a82989c7c6f7e970f8f Reviewed-on: https://chromium-review.googlesource.com/808748Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#521806}
-
