GitLab

Ran `./tools/clang/scripts/upload_revision.py 64a362e7216a43e3ad44e50a89265e72aeb14294`.

...and fix one last Chrome OS-only new -Wtautological-compare warning.

Bug: 1006756,1007367
Change-Id: Id87271c20d8ca66a9a498de8fb716d818d279b48
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835192
Auto-Submit: Nico Weber <thakis@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702167}

This CL does two things:

1) exposes if Vulkan is enabled on chrome://gpu

2) adds vulkan feature which can be disabled by
gpu/config/software_rendering_list.json file based on environment.

Bug: 1002166,887018
Change-Id: Iee4b4e38e5e3761aeba1530a0d64d128f5aa9ae8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832293Reviewed-by: Jonathan Backer <backer@chromium.org>
Commit-Queue: Peng Huang <penghuang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702166}

The intrinsic dependencies encountered along the way made it difficult
(less effective) to break up this CL into multiple smaller CLs
(apologies to the reviewers in advance).

To simplify its understanding, please refer to the following doc:
https://docs.google.com/document/d/1ClZglFQroV53zSYEGIZ7yca8KIsPHGBmzMCbtreu5lg

The following are the major points to review:
- refactoring of the infra into builder, installer, logger, observer, util
- new design (IoC driven) for installers to enable for easy testability
- new design for emitted modules (cross-package communication)

Out-of-scope (following CLs):
- removal of bytecode processing for third-party activities (no longer needed)
- move code from ModuleInstallerConfig.java into BuildConfig.java
- unit tests for the remaining module_installer classes

Testing: this change was verified with vr, ar, autofill_assistant, dev_ui,
and test_dummy modules. It was tested with both -m and -f command line args.

Bug: 1005802
Change-Id: Icf357c06c4b71a96ed9fa0584f6322d6dc6143d7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1813520Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Peter Wen <wnwen@chromium.org>
Commit-Queue: Fred Mello <fredmello@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702165}

base::Bind/base::Callback are deprecated in favor of either
base::BindOnce/base::OnceCallback or base::BindRepeating/
base::RepeatingCallback (depending on whether the callback
is invoked once or multiple time).

Convert all uses of base::Bind/base::Callback in sandbox/{win,linux}
to the recommended methods/types.

Bug: 1007829, 1007830
Change-Id: I5a6e03e2b823f1c2b3f48317b0451911f192b99f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835581
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Auto-Submit: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Will Harris <wfh@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702164}

This makes it easier to grep for TestDummyImpl results without requiring
physical access to the test device.

Bug: None
Change-Id: I35efca8d54a7fec9385262ca4bc6908b8692115d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835706
Commit-Queue: Peter Wen <wnwen@chromium.org>
Auto-Submit: Peter Wen <wnwen@chromium.org>
Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702163}

WrapReverse is implemented in LayoutFlexibleBox instead of
FlexLayoutAlgorithm. This CL implements those parts for LayoutNG.

Bug: 845235
Change-Id: I53245d2c7bb4680d846dc5ef4b8b4a3002d95126
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808496
Commit-Queue: David Grogan <dgrogan@chromium.org>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702162}

Bug: 1005217
Change-Id: Ia30a45781b719dd53fee3736982b63114ee191dd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835163
Auto-Submit: Lily Chen <chlily@chromium.org>
Reviewed-by: Eric Roman <eroman@chromium.org>
Commit-Queue: Lily Chen <chlily@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702161}

Remove call to SetShouldDoFullPaintInvalidation()
in LayoutBlockFlow::DetermineStartPosition() that was done just after
SetNeedsLayoutAndFullPaintInvalidation(), as this is already called
at the end of that method.

Change-Id: If53e4e3e5aba9a6f3c424d3f5b805151fd9223b7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834084Reviewed-by: Emil A Eklund <eae@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: Manuel Rego <rego@igalia.com>
Cr-Commit-Position: refs/heads/master@{#702160}

This adds an X close button on removable suggestions, assuming the
user has the kOmniboxSuggestionTransparencyOptions flag enabled.

A followup CL will remove the context menu, so there will be no code
duplication.

Bug: 1205, 929477
Change-Id: I7c921c6051dc4f53fc55e9bd5922d827968735da
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834247
Commit-Queue: Tommy Li <tommycli@chromium.org>
Reviewed-by: Kevin Bailey <krb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702159}

This object is never null so a reference is more appropriate.

Change-Id: Ib3129973c6b6c226ca4e7ba8df0b14baab26bdea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829795Reviewed-by: David Bokan <bokan@chromium.org>
Commit-Queue: Majid Valipour <majidvp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702158}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/2458b31208f8..6b4c2a88f36e

git log 2458b31208f8..6b4c2a88f36e --date=short --no-merges --format='%ad %ae %s'
2019-10-02 mmoss@google.com Run git_cl commands as a python step.

Created with:
  gclient setdep -r src/third_party/depot_tools@6b4c2a88f36e

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/depot-tools-chromium-autoroll
Please CC agable@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

TBR=agable@chromium.org

Bug: chromium:726111
Change-Id: I4dcda75155e4617243c37676b667a7cdf81255c4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835702Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#702157}

Bug: 1010561
Change-Id: Ic6b0d656af1944d9dbb16f5fb96d70fe1ad90f14
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835157
Auto-Submit: Nico Weber <thakis@chromium.org>
Commit-Queue: Dan Beam <dbeam@chromium.org>
Reviewed-by: Dan Beam <dbeam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702156}

No change to logic.

This adds two header files which this C++ file was depending on
transitively (for base::TimeDelta and OS_ANDROID/OS_IOS).

Bug: 1010369
Test: N/A
Change-Id: I16ceb2d05beaca66ea254f1e1c7ddd541b8ff05c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835132Reviewed-by: Brian White <bcwhite@chromium.org>
Commit-Queue: Nate Fischer <ntfschr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702155}

The --force-enable-metrics-reporting switch was previously implemented
to override sampling, but didn't correctly override user consent. This
fixes that, and modifies the unittests to verify correct behavior by
checking the metrics service actual starts up.

To accommodate privacy concerns, this flag does not override app
consent. We separate user and app consent to plumb both values down, and
we add a test case to verify the flag respects app consent.

This also splits the previous test case into multiple cases, which is
necessary in order to initialize the client under two different sets of
conditions.

Bug: 994418
Test: run_android_webview_unittests --gtest_filter=AwMetricsServiceClientTest.*
Test: Opt-out of metrics in settings, AwMetricsLogUploader is called
Test: Opt-out WebView shell in manifest, AwMetricsLogUploader is not called
Change-Id: I1e177bd5e3a5622c694e2275f18408d946b69397
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815545Reviewed-by: Tao Bai <michaelbai@chromium.org>
Commit-Queue: Nate Fischer <ntfschr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702154}

Adds support for base::TimeDelta in PerfResultReporter. This is due to
many perf tests reporting time taken from a TimeDelta, and handling the
conversion from TimeDelta to double in PerfResultReporter makes its use
less error-prone since users no longer need to worry about matching the
registered units to the correct TimeDelta::In*seconds calls.

Bug: 923564
Change-Id: I30dd6bcf0f11489b671f20e6e776fbad4659729e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815081Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Auto-Submit: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702153}

Set the UseWindowsSystemColors and LinkSystemColors flags to stable
and update test expectations.

Spec: https://drafts.csswg.org/css-color-4/#css-system-colors

Bug: 970285
Change-Id: I1c65b09cbec6a6408c0056ac2f088df2bdcd9f4b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829645
Commit-Queue: Alison Maher <almaher@microsoft.com>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702152}

FIDL's StringPtr and VectorPtr will no longer be implicitly converted to

std: :string and std::vector.
Change-Id: I4626ee0e0e6c2c24dc586e965bebbfa416d89bf8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834267
Commit-Queue: Ian McKellar <ianloic@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702151}

One more abspos edge case:
Replaced element, with no intrinsic size, but with
intrinsic aspect ratio.

The example problem here is an SVG with aspect ratio,
but no intinsic size. According to the spec, its
inline size should fill container, and block size
should be derived from inline size and aspect ratio.

Existing code did not handle this case. If element
had no size, its size would be computed and get clamped
by minmax.

A replaced element with no size gets a default minmax of
300x150, so elements would effectively get clamped to minmax.

My fix is a bit of a hack. It uses absence of minmax as a signal
that size should not be clamped.

The intrinsic size handling is surprisingly complex for replaced
elements. I wonder if there  are any other parts of NG that
need a close look in how replaced with aspect ratio/no size
are handled.

FF handles this correctly. Legacy does not.

Bug: 1003545
Change-Id: I1510611ff84a99a26bcade74cace2855e022f997
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1830326
Commit-Queue: Aleks Totic <atotic@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702150}

This is the new, simpler function to calculate a SHA1 that easily works
with base::HexEncode(). Fix nits in the test file along the way.

Change-Id: I725f1c5618dc7427fa01d75b42115185252dfbe9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827744Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702149}

We already account for this when doing direct capture on tab switch;
this makes the same adjustment when capturing video from a background
tab.

Change-Id: I19791a5761ac4539b5eee8be37a189af75e922b7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835273
Commit-Queue: Dana Fried <dfried@chromium.org>
Reviewed-by: Collin Baker <collinbaker@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702148}

Needed for PostTaskHere and base::CurrentThread trait. This has the same
lifetime as SequencedTaskRunnerHandle & ThreadTaskRunnerHandle.

Bug: 835323
Change-Id: I5a4b4d9c69ce14c962e79a2a0f6adaf0c247b523
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832815Reviewed-by: François Doray <fdoray@chromium.org>
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Commit-Queue: Alex Clarke <alexclarke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702147}

Some code was left when we separated paint invalidation and raster
invalidation. Some perhaps were caused by cleaning up for raster
invalidation and root-layer-scrolling at the same time.

Change-Id: I8d26291941f17f555c1e09ba0483d41c4c4bfe47
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1826994Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702146}

TBR=govind
TBR_REASON=Breaking translation script.

Change-Id: Ica247a1637b8dd4a2961c6ac45f111039e028c0a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834907Reviewed-by: Ben Mason <benmason@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702145}

This feature allows tracking frame throughput during video playbacks.
This frame sequence tracker is a special case in that its tracking
process occurs in video_frame_submitter, unlike most other frame
sequence trackers that operate mainly in layer_tree_host_impl.

This reland CL includes a fix for flaky test failures caused by the
original CL (Change-Id: I9a41861e59bbe16d652b49de6b802ccc89833906).
See https://crbug.com/1001364 .

Bug: chromium:986300
Change-Id: I47e2ef9f21e417af8198f0669eaaf18c8e1daa33
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1818467
Commit-Queue: Mingjing Zhang <mjzhang@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Frank Liberato <liberato@chromium.org>
Reviewed-by: Stephen Chenney <schenney@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702144}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/929f3ba81e6e..0a784e03b0f0

git log 929f3ba81e6e..0a784e03b0f0 --date=short --no-merges --format='%ad %ae %s'
2019-10-02 lamontjones@chromium.org CrosSigningTestStage: test the correct branch.

Created with:
  gclient setdep -r src/third_party/chromite@0a784e03b0f0

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromite-chromium-autoroll
Please CC chrome-os-gardeners@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel
TBR=chrome-os-gardeners@google.com

Bug: None
Change-Id: I4ab95480c9de1a2f2940e271f74c0ebc93414b01
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835700Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#702143}

Windows printing path is being modernized from using the pre-WinXP
GDI print API to an XPS-based API.  This was first introduced
introduced Windows 7 and was deprecated in favor of OpenXPS in
Windows 8 and beyond.  Some Windows 7 installations may be capable of
OpenXPS if they have been sufficiently patched [1].

Need ability to determine the Windows XPS API version required for
interfacing with the print subsystem.

[1] https://docs.microsoft.com/en-us/windows/win32/printdocs/app-support-for-openxps-printing#sending-xps-data-to-the-print-system

Bug: 1008222
Change-Id: Ieb82ec5ef13ecff17c10b16284132bc45aa64dc3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1826006Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Alan Screen <awscreen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702142}

Most .mojom files don't use [Native] structs or enums, but the bindings
generator includes native_struct_serialization.h and native_enum.h in
all generated headers. Unfortunately native_struct_serialization.h is
expensive to include because it transitively includes a generated
mojom.h file.

Change the mojo bindings generator to only generate includes of for
native type headers when the underlying mojom file uses native structs
or enums.

Fix the include-what-you-use errors this reveals.

This results in 272,000 fewer transitive includes (out of 18M total)
in a Linux "all" build, a 1.4% reduction.

For IWYU fixes per mechanical change code review policy:
TBR=rockot@google.com

Bug: 922875
Test: compiles
Change-Id: If58d7002d944b8a131533750fa8a79514b6e9a09
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833069Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Ken Rockot <rockot@google.com>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702141}

Bug: 1006946
Change-Id: I855cf75c86af27d090ba854f4de3b4a31a17b850
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835278
Auto-Submit: Collin Baker <collinbaker@chromium.org>
Commit-Queue: Collin Baker <collinbaker@chromium.org>
Commit-Queue: Peter Boström <pbos@chromium.org>
Reviewed-by: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702140}

Bug: 900581
Change-Id: I227b90e5ab5088f76d4b51caa971b7edcc3a8a26
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1830592Reviewed-by: Stephen McGruer <smcgruer@chromium.org>
Commit-Queue: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702139}

This CL allows to add new printing enum policies handlers by providing
only policy and pref names and map from policy string value to enum.

Bug: 1008941
Change-Id: I25be44e38b0b76dd378c2640d491bd3e4e17165b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832805Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Sergey Poromov <poromov@chromium.org>
Commit-Queue: Nikita Podguzov <nikitapodguzov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702138}

https://imgur.com/a/4zjGLka

Bug: 1004981
Change-Id: I8b4b04d2f85247e342ac4311bc93aff79a0ab872
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835146Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: John Lee <johntlee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702137}

This change:
1) Removes the title from the group containing the site's name.
   Before this change, that group would have read as:
     group, one item, https://the.full.hostname.here..., displayed.hostname
   After this change, it reads as:
     link, displayed.hostname
2) Adds an ARIA label for the username field, which is otherwise read
   as the username text without context
3) ARIA-hides the table headers, since the corresponding cells of the
   table are now either self-explanatory or labelled

Bug: 956434
Change-Id: If9dc5b5ccac83adf3375feb461fce0f0299172d7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829777Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702136}

This CL is mostly a no-op because the new method is not called during regular workflow.
A follow-up CL will switch to calling buildbucket instead of git-cl.

There is further work to refactor this into its own class (outside of git-cl.py) and
potentially add more functionality to also start try jobs.

Main change is to generate a LUCI auth token earlier in the flow,
but this should be a no-op as well.

Bug: 1005801
Change-Id: I2353b3ad0b24d86a5c55da93dd5c1c1eec280f19
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831979
Commit-Queue: Luke Z <lpz@chromium.org>
Reviewed-by: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702135}

In a following CL I'll also add the necessary code to aggregate the use
of WebLocks and IndexedDB locks within a frame and I'll update the
corresponding page properties.

Bug: 980533
Change-Id: Ia22686215963415f586b3bcf20c363f305aaf591
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832318
Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702134}

base::Bind/base::Callback are deprecated in favor of either
base::BindOnce/base::OnceCallback or base::BindRepeating/
base::RepeatingCallback (depending on whether the callback
is invoked once or multiple time).

Convert all uses of base::Bind/base::Callback in tools/android
to the recommended methods/types.

Bug: 1007843
Change-Id: Ia955cfe01bc7e23c73e7deda469d9408aa3c90ca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832213
Commit-Queue: David Turner <digit@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Auto-Submit: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: David Turner <digit@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702133}

Bug: 878706
Change-Id: I5c3bd7d4393fe6c002171ff9937ad70d2b1ba191
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833297
Auto-Submit: Garrett Beaty <gbeaty@chromium.org>
Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Commit-Queue: Stephen Martinis <martiniss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702132}

To reflect go/request-chrome-resources.

Change-Id: Iecd7438482cc62ac7570e4b4b11d67a8af449cd2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834827Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702131}

Added some VLOG messages to
ChromeCrashReporterClient::GetCollectStatsConsent to explain why it is
returning false. Crash-related tests on ChromeOS have been flaky; this
is part of understanding why.

BUG=chromium:994987,chromium:984807
TEST=Ran Chrome with and without consent, and Chromium with and without
consent. Ensured crash dumps produced only for Chrome with consent, and
that (with --vmodule=chrome_crash_reporter_client=1), expected messages
were generated.

Change-Id: Iecf77fd78a7aee0c5eb2ba852ad576d84cac6b71
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833929Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Ian Barkley-Yeung <iby@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702130}

Bug: 856383
Change-Id: I5d4f4f5667c27c518dedb50304ab94246e0960de
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834424Reviewed-by: Min Qin <qinmin@chromium.org>
Commit-Queue: Shakti Sahu <shaktisahu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702129}

Also, Crashpad for Android can't yet monitor itself in the various
configurations that Chrome packages it, so remove references to the
flag from crashpad_android.cc to avoid accidentally turning it on.

Bug: 942279
Change-Id: I1afae5fd433f9e2b1475e8fa3e883547542eb6cf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834401Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Joshua Peraza <jperaza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702128}