- 26 Jun, 2019 40 commits
-
-
François Doray authored
This histogram is already scheduled to expire in M77 due to nobody looking at it. Bug: 970008 Change-Id: I746704ffc678233635e751af09d4a52261710865 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649686 Commit-Queue: Steven Holte <holte@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Auto-Submit: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#672692}
-
Nicolás Peña Moreno authored
The timestamp captured at onload does not seem to always be smaller than the render timestamp. This CL changes the lower bound so the test is no longer flaky. Bug: 978587 Change-Id: I48c058ac0abb684cb4406617500356d0aae019e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1678836 Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Reviewed-by:
Yoav Weiss <yoavweiss@chromium.org> Cr-Commit-Position: refs/heads/master@{#672691}
-
Edward Jung authored
- Billing - Look alike URLs - Supervised users Screenshots can be see in: https://bugs.chromium.org/p/chromium/issues/detail?id=947840#c29 Bug: 947840,978833 Change-Id: I02ee5364bbf5747158090568b6959caead36265a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1676130Reviewed-by:
Carlos IL <carlosil@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Edward Jung (EMEA) <edwardjung@chromium.org> Cr-Commit-Position: refs/heads/master@{#672690}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/11cf0a3029ed..cff2a5619b04 git log 11cf0a3029ed..cff2a5619b04 --date=short --no-merges --format='%ad %ae %s' 2019-06-26 zoddicus@users.noreply.github.com Catch low level exceptions instead of crash (#744) Created with: gclient setdep -r src/third_party/shaderc/src@cff2a5619b04 The AutoRoll server is located here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=radial-bots+chrome-roll@google.com Change-Id: Iad56a981d9550fcecf74ca4323d5040ae72dddf3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1678853Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#672689}
-
Joe DeBlasio authored
Previously, the Page Info bubble maintained a single variable to identify all reasons that a page might have a non-standard status. This lead to the display logic making assumptions about, for instance, the validity of a certificate when the page was flagged by Safe Browsing. This CL separates out the Safe Browsing status from the site identity status so that the page info bubble can inform the user that the site's certificate is invalid, even if it's also flagged by Safe Browsing. This reland includes fixes to prevent use of uninitialized memory. Bug: 869925 TBR: meacer@chromium.org TBR: bsep@chromium.org Change-Id: I237da104427002cce6972b3fdc30656c682b5e6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1678818 Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> Reviewed-by:
Joe DeBlasio <jdeblasio@chromium.org> Cr-Commit-Position: refs/heads/master@{#672688}
-
Andres Medina authored
Allowed a new type of media block that blocks cast_renderer initialization instead of webmediaplayer loading. Test: Manual test blocking is happening at the renderer by inspecting device logs Bug: b/134961542 Change-Id: I97b0e59a6752c43d14b8e96327079aa8669b1c00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1673829Reviewed-by:
Sean Topping <seantopping@chromium.org> Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Auto-Submit: Andres Medina <medinaandres@chromium.org> Commit-Queue: Andres Medina <medinaandres@chromium.org> Cr-Commit-Position: refs/heads/master@{#672687}
-
Dale Curtis authored
We almost never have a valid pixel format anymore, so many places just hardcode it to I420 regardless of what's in the file. It's not used for anything, so just go ahead and remove it from the VideoDecoderConfig. What we do need is a signal about the presence of an alpha channel, so just use that directly instead of guessing at it based on the format. BUG=none TEST=bots pass R=sandersd Change-Id: Ifbd2357255650366d2bae0fa1fba1cfcbf01671d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1673582 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Cr-Commit-Position: refs/heads/master@{#672686}
-
Kurt Horimoto authored
Previously, when the OverlayPresentationContext's coordinator is reset, the presented UI was dismissed without notifying the presenter. This CL updates the implementation to have OverlayPresenter drive the dismissal when the coordinator is reset. This allows for the presenter to be aware of all presentation/dismissal events so that its observers can be notified when they occur (e.g. at the end of the tab grid => BVC transition animation). To pipe this information back to OverlayPresenter, the presentation context exposes IsActive(), which describes whether the context is currently able to present. When a coordinator is provided to the context implementation, it notifies the presenter via observation that it has become active, which triggers presentation. When the coordinator is reset to nil upon the BVC leaving the window, the presenter is again notified via observation that the context is deactivating, which triggers dismissal. Bug: 941745 Change-Id: If06a9cd2aed18f34cf820423b42f24df78d22eea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1672173 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#672685}
-
Mohamed Heikal authored
Latest aapt2 is required for enabling resource path shortening. This also fixes an xml resources size regression for bundles where raw xml values were being unnecessarily kept. reason for reland: Fixed data_dep on removed libc++.so Original CL: > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1669171 > Cr-Commit-Position: refs/heads/master@{#671827} This reverts commit f063a96b. Bug: 978664, 753402, 912804 Change-Id: Ifaa6fb44fe9fd3bebd388d88aa53a581cebae543 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1678944 Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Auto-Submit: Mohamed Heikal <mheikal@chromium.org> Cr-Commit-Position: refs/heads/master@{#672684}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/2e6505e6392f..b46998c50dd4 Created with: gclient setdep -r src-internal@b46998c50dd4 The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=reillyg@google.com,yhirano@google.com,futhark@google.com Change-Id: Ia8e8aeb0a782a5454f11143f08b0a05f27973e91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1678854Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#672683}
-
Dale Curtis authored
ReadyState has never been suficient to test whether a video frame is actually present. Instead we need to know when the frame has actually been delivered to the compositor. This patch updates HTMLVideoElement to query a new WebMediaPlayer method which exposes the compositor's knowledge of the video frame. Note: This patch also fixes some spurious logs and HTMLVideoElement tests that were silently doing nothing. BUG=974012,974190 TEST=new unittest. TBR=eae Change-Id: I1df54491c1fd7c2246ce0f60bc6e794b8b84476a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1659490 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#672682}
-
Aaron Colwell authored
- Added code that enables the default SiteInstance to use an unmatched service worker process for a site that is handled by the default SiteInstance. - Remove default SiteInstance specific conditions from tests that were testing process reuse and unmatched service worker process behavior. - Added code to BrowsingInstance that tracks what site URLs are associated with its default SiteInstance. This allows process reuse to be constrained to sites explicitly associated with a specific default SiteInstance. Bug: 958060 Change-Id: I9ce95dbd5ecc192cba8cd4e6046787d248ff3532 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1668449Reviewed-by:
Charlie Reis <creis@chromium.org> Commit-Queue: Aaron Colwell <acolwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#672681}
-
Lukasz Anforowicz authored
Bug: 940785 Change-Id: I46be52c2b5e9a6e1311681f25b9a38e1562a23a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1678161 Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#672680}
-
Xiaocheng Hu authored
Intent to implement and ship: http://bit.ly/2J75JAQ Bug: 825895 Change-Id: Ib5ed82072e189f8c99f5ebc157127d389bf87375 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1678883 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Auto-Submit: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#672679}
-
James Cook authored
Web page translations are a browser feature, not an OS setting. This code isn't used by OS settings, so remove it. There is more to remove here (language ordering in particular), but this is a first step. Bug: 967965 Test: manual, closure compiler Change-Id: Id7f95e2a6c88d9b5d086944736630aa38d4bc3ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1676616 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#672678}
-
Sebastien Marchand authored
There's still a few left that I'll clean when moving this to performance_manager/ Bug: 977554 Change-Id: I6590c7cd188d656e0d36dd9aa7568f3d54e57d56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1670308 Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#672677}
-
Ken Rockot authored
ServiceProcessHost allows Content and its embedders to launch a new service process for any given mojom service interface. This CL wires up the support and converts a single test-only service to use ServiceProcessHost instead of integrating with Service Manager. Bug: 977637 Change-Id: I63e846bf816c51ba2c557bfdc8b41189a92d2890 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1673922Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#672676}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/751252e3724b..ebcf0d31c012 git log 751252e3724b..ebcf0d31c012 --date=short --no-merges --format='%ad %ae %s' 2019-06-26 cwallez@chromium.org Add missing Reference count in null Device. Created with: gclient setdep -r src/third_party/dawn@ebcf0d31c012 The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel BUG=chromium:976573 TBR=cwallez@google.com Change-Id: Ic2ed74c088756b027ecc388ccde190c88dfa6d6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1678268Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#672675}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/6e269a0babac..1ff9ce92d17a git log 6e269a0babac..1ff9ce92d17a --date=short --no-merges --format='%ad %ae %s' 2019-06-26 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@1ff9ce92d17a The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I518b74baaf32f63e05668cce649a84c7defb5f31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1678272Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#672674}
-
Ben Kelly authored
In order to move cache_storage off the IO thread we must implement some cross-sequence glue code with the blob subsystem. Response and request bodies are returned as blobs. The blob subsystem, however, only works on the IO thread. This CL makes the DiskCacheBlobEntry a cross-sequence object that receives read requests from the blob code on the IO thread and then executes the operation on the cache_storage sequence. This CL also refactors the CacheStorageCacheEntryHandler a bit to reduce code duplication between cache_storage and background_fetch by moving it into the CreateBlob*() methods. Having a single place for creating blobs also makes it easier to support the cross-sequence initialization. This CL also fixes some problems with the cache_storage initialization code. It needs to make an explicit task hop to the IO thread to get the BlobStorageContext WeakPtr before passing it on to the manager. Bug: 960012 Change-Id: Ib9e57c9a637498e73a1f0a334d1cd90ff9450554 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1667623Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Ben Kelly <wanderview@chromium.org> Cr-Commit-Position: refs/heads/master@{#672673}
-
Maks Orlovich authored
It's only used in some tests, and for those PartialCompare is sufficient, as it looks at all the fields for the key of the cookie database. Change-Id: I8b7fa9f86a21e4ed9afc85bd2e1f89e246fef83f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1678758Reviewed-by:
Lily Chen <chlily@chromium.org> Commit-Queue: Maks Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#672672}
-
Peter Boström authored
Prevents GetWidget()->GetRootView() returning null during views hierarchy teardown. Bug: None Change-Id: I98833cb660ef6b9d30600e3805560926b186593c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1679349Reviewed-by:
Robert Liao <robliao@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#672671}
-
Will Harris authored
Removed: ChildProcess.InvalidSandboxStateCrash.NoStartupWindow Windows.InCompatibilityMode These are all still used for stability regressions: BrowserRenderProcessHost.DisconnectedAlive BrowserRenderProcessHost.ChildLaunchFailureCodes ChildProcess.DisconnectedAlive2 BUG=975997,975199,975095 Change-Id: I4a63a9aa327b3994454c0ee4d81628335c7802d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662975Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#672670}
-
danakj authored
Without this, state persists between tests, which of course causes failures. R=sky@chromium.org Bug: 961849 Change-Id: Ie74936ebfed4bacfa721dcba446905f4fe770faa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1677591 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#672669}
-
Evan Stade authored
This was used to close the collected cookies dialog (accessible from OIB) when clicking on the link in the content settings bubble. To test, 1. block some cookies on some site 2. reload site 3. open OIB, click Cookies 4. click on blocked cookie icon to open bubble 5. click on the link (which attempts to show the already-open dialog) Previously, this would destroy the dialog and re-create it. Now, we just focus the already existing window. The NotificationService notification wasn't very useful as it immediately preceded the call to open the new dialog, and hence can pretty much just be dropped. The rest of the changes here are polish. Bug: 268984 Change-Id: Ib88b7fd7f9a9eaba394498ca7147e116aafe4936 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674707Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#672668}
-
Lucas Furukawa Gadani authored
Change-Id: I841ad1a15facad1b9a59b9ef75d803b3d132b233 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1679221Reviewed-by:
Adithya Srinivasan <adithyas@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Lucas Gadani <lfg@chromium.org> Cr-Commit-Position: refs/heads/master@{#672667}
-
Tatiana Buldina authored
Return heap snapshot as a string instead of JSON object. This resolves two issues: * The snapshot sometimes uses characters not allowed by our JSON parser. * Chrome's snapshot reader is sensitive to the ordering of properties in the snapshot. Converting the snapshot into JSON object and then re-serialize into string often results in a file not loadable by the snapshot reader. Bug: chromedriver:2964, chromedriver:1616 Change-Id: Ia721c28ed78a085d567111459c9e50d8bc26f81d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1679224Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Tatiana Buldina <buldina@chromium.org> Cr-Commit-Position: refs/heads/master@{#672666}
-
Alex Cooper authored
This is the first step to convert the types in the vr_service.mojom to common gfx.mojom geometry types. By adding typemaps from the gfx.mojom geometry types on the blink side, we can have cleaner and consistent code across both sides of the mojom pipe. Bug: 977008 Change-Id: I1eafdc938be9d5dc7e67ecd5c964d07a90bc6d29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1668569Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Bill Orr <billorr@chromium.org> Commit-Queue: Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#672665}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/7bf0ecb40e23..2b2367291125 git log 7bf0ecb40e23..2b2367291125 --date=short --no-merges --format='%ad %ae %s' 2019-06-26 saklein@chromium.org Build API: Add validation decorators. Created with: gclient setdep -r src/third_party/chromite@2b2367291125 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Change-Id: Ia9196f22f2a8d88cc8d9b23091fec85eb2e13dcd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1678265Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#672664}
-
Xiaocheng Hu authored
Intent to implement and ship: http://bit.ly/2J75JAQ Bug: 825895 Change-Id: I404323bc50dc6ad0362de6c7385edae9a85caefa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1679132 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Auto-Submit: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#672663}
-
Yue Li authored
Since we recently turn the flag back to default off and plan to rollout the feature after M77 stable, update the expiry milestone to M78. Bug: None Test: Local Build Change-Id: Ib51fb7b148dfab90a3d1d52000eaf050b8e3b7bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1677546Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Yue Li <updowndota@chromium.org> Cr-Commit-Position: refs/heads/master@{#672662}
-
Edward Wang authored
Https is quite heavy for periodic connectivity check. Change to http version to reduce the server load after initial https check passsed. Bug: b/135769650 Test: Verified the check change to http one after last check succeed. Change-Id: I73d0c9ffaa6a22d0319d6782ed17ee1152045894 Signed-off-by:
Edward Wang <wangedward@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1677263Reviewed-by:
Sergey Volk <servolk@chromium.org> Cr-Commit-Position: refs/heads/master@{#672661}
-
Kurt Horimoto authored
This CL creates a separate file for OverlayPresenter::UIDelegate (renamed to OverlayPresentationContext). This was done because the presentation context will need to support observation so that the presenter can be aware of when it has a coordinator in which to present overlay UI. The class was renamed because it seems like an anti-pattern for a delegate to support observation. This CL also moves OverlayPresenter::Observer to a separate file for consistency. Bug: 941745 Change-Id: I92208a28a84a450d3a00aa08c7dfbf546bb7ff98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1671028Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#672660}
-
Johannes Henkel authored
Change-Id: Ic99de0b23ec2b1c4d1c4f6477eb727f2b87c23c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1677240 Commit-Queue: Johannes Henkel <johannes@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#672659}
-
Nicolas Norvez authored
"Contributing" doc has moved from dev.chromium.org to Markdown file, update the link. Bug: None Change-Id: I8574dec9fb980b347a024f067c0aa59637e6eaca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1678286Reviewed-by:
Xiaochu Liu <xiaochu@chromium.org> Commit-Queue: Xiaochu Liu <xiaochu@chromium.org> Cr-Commit-Position: refs/heads/master@{#672658}
-
Yuke Liao authored
The clang_coverage recipe module was renamed to code_coverage in https://chromium-review.googlesource.com/c/chromium/tools/build/+/1670914. This CL updates the references at chromium/src side accordingly. Bug: 977032 Change-Id: I2059b978cbc75d3f8621e7c14880ee6d40a92f85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1669984 Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#672657}
-
Dana Fried authored
Followup to: https://chromium-review.googlesource.com/c/chromium/src/+/1674290 UX decided that moving the hit test area was better than moving the hover card. Bug: 972582 Change-Id: Icbe87ad28d1c5c040bd2b3a5ea5635cc12f2b2d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1679129Reviewed-by:
Caroline Rising <corising@chromium.org> Commit-Queue: Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#672656}
-
Fabrice de Gans-Riberi authored
* Modify WebComponent and WebContentRunner to take optional extra headers to pass to LoadUrl(). Bug: 977753 Change-Id: I7d23b57629831b775e23ca19a0d0d96886155e6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1672528 Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#672655}
-
Xiaochu Liu authored
ComponentUpdater.ChromeOS.MountTime is measuring perf of a system service (imageloader) which is used by component updater and DLC project which many other features in Chrome (on Chrome OS) depend on. Set expiration date for 2 years from now. BUG=chromium:975957 TEST=None Change-Id: I970d4bca9e4df9153f49ad465886d625de9bdd87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1679219Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Xiaochu Liu <xiaochu@chromium.org> Cr-Commit-Position: refs/heads/master@{#672654}
-
Mostyn Bramley-Moore authored
This sysroot setup makes it easier to make hermetic 32bit linux Clang builds, in a way that also works with Goma. BUG=978360 Change-Id: I6fe5622fcade9c66726ac34f3832c2e670ce4795 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1675349Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Mostyn Bramley-Moore <mostynb@vewd.com> Cr-Commit-Position: refs/heads/master@{#672653}
-