- 08 Sep, 2020 40 commits
-
-
Anatoliy Potapchuk authored
Sometimes, while the icon was not loaded yet, we would end up in the state where the crx file is corrupt and we would hide the app from the list, causing some confusion in users. Now, in all cases when crx file is corrupted, we will still display the app. Also, adding more logs for STATUS_ERROR failures. Bug: 1035860 Change-Id: I4adf66bdc5fca2a3139c2e02577ebd278d84913f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2397576Reviewed-by:
Anqing Zhao <anqing@chromium.org> Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org> Cr-Commit-Position: refs/heads/master@{#804990}
-
Josip Sokcevic authored
code.google.com redirects no longer work. This CL replaces links in /build/android to source.chromium.org equivalent. This CL was uploaded by git cl split. R=tiborg@chromium.org Change-Id: I0862b5c23da99ee793239f19baf0f4fffbfefe81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392760 Auto-Submit: Josip Sokcevic <sokcevic@google.com> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#804989}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/2b3b35f8381b..e659214bc6cf 2020-09-08 ethannicholas@google.com Revamped handling of SkSL node kinds 2020-09-08 bsalomon@google.com Re-enable use of sampler objects on ANGLE. 2020-09-08 johnstiles@google.com Change Inliner signature in preparation for analyzer pass. 2020-09-08 bsalomon@google.com SK_API on SkYUVAPixmaps::SupportedDataTypes. 2020-09-08 cwallez@chromium.org Fix Dawn's path to spirv-cross. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC reed@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: reed@google.com Change-Id: Id6dd97fba2b67057e5aac37381978517105ddd6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398805Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#804988}
-
Dan Harrington authored
- Use make-gtest-filter.py to build a gtest filter automatically. - Allow testing a full directory. - --run-all: allow testing multiple targets in one run, instead of asking the user to pick. - Speed it up if a file path is specified, by skipping the file search. - Cache gn refs output, to make follow-up runs faster. - Add --line option, to run a test at specific line number. - Change call to ninja build so that output is streamed - Switch to printing errors end then exiting for non-exceptional errors. This makes user errors more readable. Change-Id: Ib3660123f5a7fe5c3ef3369d360c3ea3218d233a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391209 Commit-Queue: Dan H <harringtond@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#804987}
-
Daniel Rubery authored
This reverts commit 0c95e24c. Reason for revert: The alternate strings turned out not to be needed. Original change's description: > Land alternate strings for APP deep scanning > > This CL lands new strings that may be used for Advanced Protection > Program users to send their downloads for deep scanning: "file.exe is > unknown. Advanced Protection recommends sending this file to Google > for scanning." as well as changing the button from "Send" to "Scan" > > Screenshot: https://screenshot.googleplex.com/Mh8PfqxvHMy.png > Bug: 1115142 > Change-Id: Ib43a25bd68c51bf86f3a86836c1afc6e31697d2c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350383 > Reviewed-by: Varun Khaneja <vakh@chromium.org> > Commit-Queue: Daniel Rubery <drubery@chromium.org> > Cr-Commit-Position: refs/heads/master@{#797044} TBR=vakh@chromium.org,drubery@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1115142 Change-Id: I10852def75769ac24aa273ccbbe3658fddbb2764 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399001Reviewed-by:
Daniel Rubery <drubery@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#804986}
-
Alison Maher authored
As resolved by the CSSWG [1], we should respect system color rules set by the author/user in Forced Colors Mode. This CL is the second of several changes to make this happen. Currently, in order to force colors in Forced Colors Mode, we revert the related properties at the author origin. This logic is now removed from the spec [2]. To accommodate the above changes, the plan is to simulate a revert at the end of the cascade, but only if the computed value for a given property is not already a system color and forced-color-adjust is set to auto. This CL moves the logic for reverting properties that are affected by Forced Colors Mode to the end of the cascade using the ForceColors() method (which was added here [3]). [1] https://github.com/w3c/csswg-drafts/issues/4178 [2] https://github.com/w3c/csswg-drafts/commit/7c154ddc7f196df9b40a34a5f63bf6d157b1011b [3] https://chromium-review.googlesource.com/c/chromium/src/+/2376666 Bug: 970285 Change-Id: I5039fdaf5ce6d5917a258e593fb2f527581c72e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388991 Commit-Queue: Alison Maher <almaher@microsoft.com> Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#804985}
-
Michael Crouse authored
This change allows LiteVideos to be shown on Forward-Back navigations. Video sites have an increased rate of this navigations so the signal is noisy to blocklist on. This adds Finch control to experiment with turning on LiteVideos for Forward-Back navigations. Bug: 1124949 Change-Id: I1f483d948545e5414ffbcc5791d99fcb5a5e56da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393241Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Sophie Chang <sophiechang@chromium.org> Commit-Queue: Michael Crouse <mcrouse@chromium.org> Cr-Commit-Position: refs/heads/master@{#804984}
-
Andrew Grieve authored
Cronet is now setting default_min_sdk_version via GN arg, so these targets do not need special-casing. Bug: 1119402 Change-Id: I1a402e770ff4588b0fe06d5f5847258f8193fa96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367738Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#804983}
-
Mansi Awasthi authored
Currently AXPlatformNodeTextProviderWin::GetSelection() populates selection SAFEARRAY as nullptr if the selection is a degenerate range on a non editable node. Hence correct selection range is not returned on deselecting the selected character. This CL adds the change to return a valid selection for a degenerate range. It also adds the conditions in AXPlatformNodeTextRangeProviderWin::Select() to prevent selections inside of a list marker. Relevant unit tests are added to validate the change. AX-Relnotes: Fixed an issue with character selection for Narrator users. Bug: 1114779 Change-Id: I882ca2c6ade013678b948548918b02417d85aee6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346095 Commit-Queue: Kurt Catti-Schmidt <kschmi@microsoft.com> Reviewed-by:
Kurt Catti-Schmidt <kschmi@microsoft.com> Reviewed-by:
Benjamin Beaudry <benjamin.beaudry@microsoft.com> Cr-Commit-Position: refs/heads/master@{#804982}
-
Alison Maher authored
Previous to CL:2376666, pseudo element background-colors were not getting overridden in Forced Colors Mode. CL:2376666 fixes this issue. This CL adds a new web test to ensure that this behavior doesn't regress in future changes. Bug: 970285,1124362 Change-Id: Iebb16a3233bf4257d0acced9f6c00dcce4cfe983 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393779 Commit-Queue: Alison Maher <almaher@microsoft.com> Reviewed-by:
-
Volodymyr Riazantsev authored
If audio stream is not in float format we can process audio buffers by taking the same route as an audio data processing. This can happen if audio buffers are supplied within the same process and we are using external buffer pool. Bug: internal b/159173611 Test: cast_audio_backend_unittests; run GVA config on the reference device Signed-off-by:
Volodymyr Riazantsev <riazantsevv@google.com> Change-Id: I0548fc81960313f95f1c609f9e3676da0af3774e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391284Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Cr-Commit-Position: refs/heads/master@{#804980}
-
Mohamed Heikal authored
With all current targets setting create_srcjar=false, we can remove all code that creates srcjars in prepare resources so that no new usages are created. TBR= #cced OWNERS, just a mechanical deprecation change (for the files outside of build). Bug: 1073476 Change-Id: I102744c75f9be1ee8e78203a524a12a474f55390 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392740 Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Reviewed-by:
-
Evan Stade authored
The show() invocation got lost in the shuffle of crrev.com/6d9b12cf Bug: 1125450 Change-Id: Ia0203fc3586b4b0b787e5f9b162b25e45fbef29e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398885Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#804978}
-
Christian Biesinger authored
For reuse in computing intrinsic sizes. R=ikilpatrick@chromium.org Bug: 1083010 Change-Id: I335a51c5fa5e4e578010b40602fc93d7b9b07ffb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380736 Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Auto-Submit: Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#804977}
-
Andrew Grieve authored
We only support 21+, so we should build for it. Bug: 1116198 Change-Id: I552a946b245de0f54485ea985e08b53b92186bb1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367984Reviewed-by:
Ben Mason <benmason@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Auto-Submit: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#804976}
-
Rouslan Solomakhin authored
This patch adds a test for JSON serialization of a very long fallbackUrl string being passed into PaymentRequest API. Bug: 1110324, 1115091 Change-Id: Iac3f0197038199451ebe5276e11c10e53cb62a2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346973 Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Nick Burris <nburris@chromium.org> Cr-Commit-Position: refs/heads/master@{#804975}
-
Eric Robinson authored
This CL removes some of the AdsPageLoadMetricsObserver unit test functions that could be replaced by calling accessors and then functionality directly on those. Change-Id: I483baa317258b76ecc4a438774660799c791c4ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390875Reviewed-by:
John Delaney <johnidel@chromium.org> Commit-Queue: Eric Robinson <ericrobinson@chromium.org> Cr-Commit-Position: refs/heads/master@{#804974}
-
Rohit Agarwal authored
private. The IncognitoInterstitialDelegate methods should be used in conjunction with the IncognitoInterstitial MVC. Currently, it's possible to create instance of the IncognitoInterstitialDelegate and invoke its methods from outside of package scope. This CL changes the scope of these methods to package private and moves the IncognitoInterstitialDelegateTest to the same package. Bug: 1103262 Change-Id: Id0a87b386e4f0c3414c744e5bd51da6f61bc9922 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398480Reviewed-by:
Alice Wang <aliceywang@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Commit-Queue: Rohit Agarwal <roagarwal@chromium.org> Cr-Commit-Position: refs/heads/master@{#804973}
-
Daniel Hosseinian authored
GetPDFDocInfo() and GetPDFPageSizeByIndex() call PDFium APIs underneath that use single precision, not double precision. Change their signatures to reflect that fact. Meanwhile, change the output of GetPDFPageSizeByIndex() from two pointer parameters to a base::Optional<gfx::SizeF> return value. Change-Id: I91e3645027f2345f930c6ee8ca886f84deed6897 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393013Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#804972}
-
Tim Sergeant authored
This is necessary for mocking calls to `onGoogleAccountsRequest` in tests. Change-Id: Ia7a99ce052071b8728f30710491194d8da6a8b96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2396158 Auto-Submit: Tim Sergeant <tsergeant@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Clark DuVall <cduvall@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#804971}
-
Liquan (Max) Gu authored
The PaymentHandler UI used to have a workaround to get the bottomsheet padding for content height computation. Now that CL[1] has fixed the bottom-sheet height computation issue, the workaround caused "overfix" and so need to be dropped. [1] https://chromium-review.googlesource.com/c/chromium/src/+/2372811 Bug: 1125515, 1059269 Change-Id: I9fd7701c5cd658ebb9ea87fe0825e0ce050a49a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398959Reviewed-by:
Sahel Sharify <sahel@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#804970}
-
David Tseng authored
SA should handle reload (pref didn't change, but the profile changed). Similar to STS and ChromeVox. R=anastasi@google.com, dmazzoni@chromium.org AX-Relnotes: n/a Fixed: 1125211 Test: manual; on-device Change-Id: I0ab62e970d2cf948512bf49947a48bd1d7aacda9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398939Reviewed-by:
Anastasia Helfinstein <anastasi@google.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#804969}
-
Fergus Dall authored
This target is used by the CQ to typecheck javascript Bug: none Change-Id: I7655a135ac9816dbbf7b84b9d5c0331fda5d0ef0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379441 Auto-Submit: Fergus Dall <sidereal@google.com> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#804968}
-
rajendrant authored
Fixed: 1124785 Change-Id: I88e275c933ec12ee1d8630797f2c1dd3462bcb19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2397535 Commit-Queue: rajendrant <rajendrant@chromium.org> Reviewed-by:
Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#804967}
-
Sebastien Marchand authored
Manual roll as we don't have the autoroller yet. Change-Id: Ia704ba1f057834f5e466b46fd60f0175db59fc84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392960 Auto-Submit: Sébastien Marchand <sebmarchand@chromium.org> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#804966}
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/afdo-chromium-autoroll Please CC gbiv@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: gbiv@chromium.org Change-Id: Ia9e2925577e875262cf0ec6d84d789667a211700 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398808Reviewed-by:
-
Luke Zielinski authored
This rolls up to d7d965cb51cb8a87ff9f87668f00b242e597d499 Major change is support for using mojo JS in tests Change-Id: I0aea49dfc7c046a5a1d38accf029691548350e62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392408Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Luke Z <lpz@chromium.org> Cr-Commit-Position: refs/heads/master@{#804964}
-
Benoit Lize authored
LockImpl::Unlock() is inlined, but not LockImpl::Lock(). Separately, Lock() calls Try() before locking, to increase uncontended performance. This code is duplicated between POSIX and Windows. This commit: - Merges the two paths - Inlines Lock() and Try(), partly for symmetry, and partly for performance On a Linux Xeon "Haswell" workstation (E5-2690v4), this improves uncontended acquire/release pairs by 8%. These numbers are collected from a non-PGO build, and the impact on a PGO one is likely smaller. This was assessed by running the performance test 50 times with: $ out/Release-desktop/base_perftests \ --gtest_filter="LockPerfTest.Simple" --gtest_repeat=50 \ | grep RESULT | sed -e 's/.*= //;s/ .*//' Results are summarized below (numbers are runs/s, higher is better): trunk: Mean = 4.534e+07 Standard Deviation = 6.234e+05 This CL: Mean = 4.900e+07 Standard Deviation = 6.681e+05 That is, this patch makes it 8.08% faster, and given the standard deviation, the difference is likely significant. Bug: 1061437 Change-Id: Ibfb3f1f07598c22f1c9446c02e16a883bf328d20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386738Reviewed-by:Wez <wez@chromium.org> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#804963}
-
Nico Weber authored
Ran `./tools/clang/scripts/upload_revision.py d0abc757495349fd053beeaea81cd954c2e457e7`. Bug: 1123467 Change-Id: If7a73ab5897485e8ac991c56363ba560db882842 Cq-Include-Trybots: chromium/try:chromeos-amd64-generic-cfi-thin-lto-rel Cq-Include-Trybots: chromium/try:dawn-win10-x86-deps-rel Cq-Include-Trybots: chromium/try:linux-chromeos-dbg Cq-Include-Trybots: chromium/try:linux_angle_deqp_rel_ng Cq-Include-Trybots: chromium/try:linux_chromium_chromeos_msan_rel_ng Cq-Include-Trybots: chromium/try:linux_chromium_compile_dbg_32_ng Cq-Include-Trybots: chromium/try:linux_chromium_msan_rel_ng Cq-Include-Trybots: chromium/try:mac-arm64-rel,mac_chromium_asan_rel_ng Cq-Include-Trybots: chromium/try:win-angle-deqp-rel-64 Cq-Include-Trybots: chromium/try:win-asan,win-angle-deqp-rel-32 Cq-Include-Trybots: chrome/try:iphone-device,ipad-device Cq-Include-Trybots: chrome/try:linux-chromeos-chrome Cq-Include-Trybots: chrome/try:win64-chrome,mac-chrome Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2394517 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#804962}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/6b0afc48ae3d..0e8358a4dead 2020-09-08 fmayer@google.com Merge "Support Windows in heap_profiling script." 2020-09-08 lalitm@google.com Merge "tp: temporarily disable duplicate proto check" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I2afb60b0cb3ecf9a23c68c1307311e44cd849bed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398804Reviewed-by:
-
chromium-internal-autoroll authored
Release_Notes: http://go/media_app-x20/relnotes/Main/media_app_202009080800_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/rUtprFyuBDz2yCzSepkGBxhzVtRer7AGDgUw2DZL4KgC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/media-app-chromium-autoroll Please CC media-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: b/138961540,b/13961540,b/144538064,b/147395281,b/152803847,b/162270429,b/162696369,b/162704759,b/162791694,b/163921403,b/167638697,b/167642410,b/167643682,b/167933026,b/167945927 Tbr: media-app@grotations.appspotmail.com Change-Id: Id7d058343e491ad5077d0bfbc461e4ae734a1aad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398803Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#804960}
-
Chris Lu authored
This is a reland of 5f4895f5 Original change's description: > [ios] Turn on FullscreenControllerBrowserScoped by default > > Bug: 790886 > Change-Id: Ide1eee5634376b90cfa820bb61644c871969ff86 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358589 > Reviewed-by: Sergio Collazos <sczs@chromium.org> > Commit-Queue: Chris Lu <thegreenfrog@chromium.org> > Auto-Submit: Chris Lu <thegreenfrog@chromium.org> > Cr-Commit-Position: refs/heads/master@{#800354} Bug: 790886 Change-Id: I24ea5c47f97e1060dc1c2dd4e83f4447595611b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380138 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Auto-Submit: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#804959}
-
Sorin Jianu authored
This is an iteration to make the implementation of --install cross-platform. SplashScreen and AppInstallController are injected by MakeAppInstall implementation using two closures. The Windows code has working objects for the two, while the other platforms use do-nothing stubs. There is a small change in the integration test to invoke Wake for the Windows execution path. The tests pass without the change and removing this platform difference in the test execution seems useful. Change-Id: Ie3c75d52742aafc7f2f96e16cc64583f501018f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2385896 Commit-Queue: Sorin Jianu <sorin@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#804958}
-
Alex Turner authored
Currently in FontMatchingMetrics, the check_type and is_loading_fallback flag are included as part of the output digest. However, these do not represent an output. Instead, they represent different kinds of lookup or a temporary state. By including them in the output digest, we cannot determine if two lookups at different points in the font matching process resulted in the same font or not. We remove check_type and instead split the IdentifiableSurface::Type to account for different kinds of lookup, including splitting lookups that can match only unique font names (i.e. src:local specifiers) and lookups that can also match family names (i.e. font-family specifiers). We adapt FontMatchingMetrics' HashMaps accordingly. We also ensure other lookup values are appropriate by: - including FontFallbackPriority for lookups by fallback character, - handling FontDescription::GenericFamilyType properly, - considering font names to be case-insensitive, and - ignoring any lookups where is_loading_fallback is true. Bug: 1121669 Change-Id: I398ad1359c5c6bae51b8bb8b4f236c1944c3e000 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376037 Commit-Queue: Alex Turner <alexmt@chromium.org> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Reviewed-by:
Asanka Herath <asanka@chromium.org> Cr-Commit-Position: refs/heads/master@{#804957}
-
cfredric authored
SSLErrorAssistantComponentInstaller. Change-Id: Ie7de9cdc89acb05e8d9781d6da3d1706d921fef8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392989 Commit-Queue: Chris Fredrickson <cfredric@google.com> Commit-Queue: Sorin Jianu <sorin@chromium.org> Auto-Submit: Chris Fredrickson <cfredric@google.com> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#804956}
-
Abigail Klein authored
Screenshots: Chrome accessibility page: https://screenshot.googleplex.com/5vU2bhoKpJvoruY ChromeOS accessibility page: https://screenshot.googleplex.com/ALQB78FPBjvhEqD Captions settings page: https://screenshot.googleplex.com/3LUrCWPny6kv954 AX-Relnotes: Clarified the names of captions strings in settings Bug: 1055150 Change-Id: Ia645b35626b1e5a30e5115882362b7e0c632f60f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398980Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Abigail Klein <abigailbklein@google.com> Cr-Commit-Position: refs/heads/master@{#804955}
-
Matt Menke authored
Back in the days when humanity was yet young, and IE roamed the Earth, URLRequestJobManager had a global list of factory functions, one for each scheme. Through the mighty work of the intern shalev, most of these were converted into ProtocolHandlers, which were added to a URLRequestJobFactoryImpl, which sat at the bottom of a stack of URLRequestJobFactories used by various modules to to intercept requests. However, the zombie URLRequestJobManager remained. It called into the top URLRequestJobFactory to give it the first shot at creating a URLRequestJob, and it still had the factory functions for HTTP[S] and WS[S]. There were reasons for this, though I can't quite remember why - URLRequest::IsSupportedScheme (removed a while back) was likely one of those reasons. There may have been others. At this point, we've removed almost all ProtocolHandlers (only FTP and chrome (iOS only)) remain, and the intercepting URLRequestJobFactories that sat on top of it are also gone. This CL finally removes URLRequestJobManager and moves all of its logic down to URLRequestJobFactoryImpl. Fixed: 354158 Change-Id: Ic1f364bd6bf9c37ed6e139a668da1de2bb301bd0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392995Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Reviewed-by:
Yuwei Huang <yuweih@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#804954}
-
Michael Crouse authored
The LiteVideoObserver observes media rebuffering events and sends a stop throttling message to the hints agent. This should only happen if LiteVideos were allowed and a hint sent in the first place. This also removes the dcheck in the hints agent as the design changed so the DCHECK is not needed. Bug: 1125922 Change-Id: I3b65a78acc54bd267ecbabd03e8fd23bea99aad7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398958Reviewed-by:
rajendrant <rajendrant@chromium.org> Commit-Queue: rajendrant <rajendrant@chromium.org> Auto-Submit: Michael Crouse <mcrouse@chromium.org> Cr-Commit-Position: refs/heads/master@{#804953}
-
Sylvain Defresne authored
base::CancelableTaskTracker is sequence-affine. Since it is not possible to ensure that -dealloc is called at a specific point in time nor on a specific thread for an Objective-C instance, change _largeIconTaskTracker to be heap allocated and stored in a std::unique_ptr<> so that it can be destroyed from -shutdown. Add DCHECK that method accessing _largeIconTaskTracker are not called after -shutdown as been called (as they would otherwise try to dereference null which is Undefined Behaviour). Convert _pendingTasks to a std::set<URL> since the value are never used, and check that the scheduling of the task was a success before storing the object in _pendingTasks (failure probably mean that the sequence has been shutdown which only happen at app shutdown, so it is okay to do nothing in that case). Bug: 1122991 Change-Id: I9f312bf6b8ac844e6a28d4e10042e9b9c1a7b529 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388061 Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#804952}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1599540720-2c8a746fd34db3cbe60ec0abca5753030633ccf0.profdata to chrome-win32-master-1599551854-84903541b1ee77a3a0a009f1d73fc84d0ed1091a.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: Ie4c1c9d42c93e53293a03cb3c0da0956dba107ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2397673Reviewed-by:
-
