GitLab

Bug: 1010568
Change-Id: I7f360ee361e486451aca2b21138c3a493a7d36a5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846474
Commit-Queue: Sven Zheng <svenzheng@chromium.org>
Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#703905}

This test was originally part of
https://chromium-review.googlesource.com/c/chromium/src/+/1783717
and added there because the earlier version of the change
introduced a regression; but the test seems worthwhile
regardless of where we do the session id surgery and I figure
we may as well submit the test now.

Change-Id: If7935aa4b4d46f898233d8cee9cadca0b7835f06
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845669Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Commit-Queue: Johannes Henkel <johannes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#703904}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/a3b4ceff..8fcfd612

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I58bc6647ad2680eab1c9798256422572255905e2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847735Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#703903}

The check rules does not work for playing media intent. Update the rule
to also check the ref part.

Bug: b/142075916
Test: Manual Test
Change-Id: I67d4e75efb038bb024560799d6466b7220751c54
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838977
Commit-Queue: Yue Li <updowndota@chromium.org>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#703902}

Bug: 1000764
Change-Id: I70ad53d49a5f4f266fe94f58cf2b4b2d35b78f18
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1843775Reviewed-by: Manu Cornet <manucornet@chromium.org>
Commit-Queue: Andrew Xu <andrewxu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#703901}

Using 'requests' instead of 'unit'.

Change-Id: I01ea466ab5b68b258f769ce373f9c71b7a5c4432
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838715Reviewed-by: Jesse Doherty <jwd@chromium.org>
Commit-Queue: Owen Min <zmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#703900}

This broke for M77 and got fixed again after the branch point. Looks
like we had no test coverage for it, but it affected WhatsApp for web.

A phantom line [1] was also required to reproduce the bug.

[1] https://www.w3.org/TR/CSS22/visuren.html#phantom-line-box

Bug: 1003810
Change-Id: I942aea83bbf71a247cf73332dcf62af7c9343106
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845759
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#703899}

This reverts commit 956f8294.

Reason for revert: The previous version of this change caused an access
violation when sandbox/win/src/target_interceptions.cc::
TargetNtMapViewOfSection() tried to access constant
kApplicationVerifierDllName, which was declared in base/win/win_util.h
and defined in win_util.cc.

This access violation happened because base.dll, from which the constant
was imported, is not yet resolved by the time TargetNtMapViewOfSection()
is called. This function, as well as the others in
target_interceptions.cc, can't reference any non-static variables or
functions in other modules besides those exposed via the g_nt structure.

To address this, the constant kApplicationVerifierDllName was moved into
the base_static build rule, whose source files are statically linked
into code that depends on them (rather than dynamically linked via
dllexport).

Original change's description:
> Revert "Use consistent DLL to detect Application Verifier"
>
> This reverts commit fd8fe93c.
>
> Reason for revert: this change is causing chrome.exe to crash on
> startup. I received a report that chrome.exe looked for the string
> constant in memory and encountered some kind of error which caused it
> to crash. I will roll back for now to investigate.
>
> Original change's description:
> > Use consistent DLL to detect Application Verifier
> >
> > To detect whether Application Verifier is running,
> > sandbox/win/src/target_interceptions.cc checks if vrfcore.dll is loaded,
> > while sandbox/win/src/handle_closer_agent.cc checks for verifier.dll.
> >
> > This change makes both use verifier.dll, to be consistent and remove any
> > confusion around whether these two are checking for the same thing (they
> > are).
> >
> >       Open Application Verifier
> >       File > Add Application > chrome.exe (any chrome.exe binary works)
> >       Under 'Tests', uncheck everything but Basics > Handles, then Save
> >       Run chrome.exe with this change; it works normally
> >         (on versions without lines 176-177, no pages will load)
> >       Return to Application Verifier
> >       Right-click chrome.exe > Delete Application, then Save
> >         (so Chrome runs normally again)
> >
> > Test: Manual
> > Change-Id: If97a1115373c394f0cbbf1d31d3ca7b60549bbee
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776781
> > Commit-Queue: Jesse McKenna <jessemckenna@google.com>
> > Reviewed-by: Greg Thompson <grt@chromium.org>
> > Reviewed-by: Will Harris <wfh@chromium.org>
> > Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#700323}
>
> TBR=brucedawson@chromium.org,wfh@chromium.org,grt@chromium.org,jessemckenna@google.com
>
> Change-Id: I79f41f6e93813befaf4e49604f7dcc1f8c1ddb48
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1828234
> Reviewed-by: David Bienvenu <davidbienvenu@chromium.org>
> Commit-Queue: Jesse McKenna <jessemckenna@google.com>
> Cr-Commit-Position: refs/heads/master@{#700493}

Change-Id: I0c43a20433dbbb54ebdf8d1a2ec71e09adb8afa9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829544Reviewed-by: Will Harris <wfh@chromium.org>
Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Greg Thompson <grt@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Auto-Submit: Jesse McKenna <jessemckenna@google.com>
Cr-Commit-Position: refs/heads/master@{#703898}

This copy was needed because dawn_wire did not previously support
volatile pointers.

Bug: dawn:230
Change-Id: Ib5baff5c3e5da129086c40ef5b22a6d840f9f65b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846657Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Austin Eng <enga@chromium.org>
Cr-Commit-Position: refs/heads/master@{#703897}

Fixed: 1010869
Change-Id: I04e05c34e6a2ad163bf61d48ec66736a15972e5d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846712Reviewed-by: Kyle Milka <kmilka@chromium.org>
Commit-Queue: Dan Beam <dbeam@chromium.org>
Auto-Submit: Dan Beam <dbeam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#703896}

Use more C++11 features and fix nits.

Change-Id: I85f4c34190301cd8117095632430cdc991477567
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1843259Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#703895}

Bug: 1008556
Change-Id: If6cdaa711a8fd498652edf980395383b9318abe2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841656
Commit-Queue: Hector Carmona <hcarmona@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#703894}

I added a sentence defining the intended audience for the "Commit
Checklist for Chromium Workflow" documentation.

Bug: None
Change-Id: Ia2f48d4120e99735c6370c864c52f0b89f6d1feb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846396Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Commit-Queue: Toby Huang <tobyhuang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#703893}

This reverts commit 755ae1b5.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 703882 as the
culprit for failures in the build cycles as shown on:
https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzc1NWFlMWI1M2IzYmNmZDM2ODRjNzNjMzdhYTFmOTg2NmU1ODU3ZjMM

Sample Failed Build: https://ci.chromium.org/buildbot/chromium/win32-archive-rel/5847

Sample Failed Step: compile

Original change's description:
> SuperSize: C++ implementation of .size format parser
> 
> Preliminary work as part of investigating converting the SuperSize Tiger
> Viewer web worker to parse and serve .size files instead of .ndjson
> files.
> 
> For now, for ease of development and testing, it's packaged as a binary.
> 
> Change-Id: Ie016922f121e78ae421f8f3720d427bf6d02b5ca
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841742
> Commit-Queue: Jasper Chapman-Black <jaspercb@chromium.org>
> Reviewed-by: Samuel Huang <huangs@chromium.org>
> Reviewed-by: Mike Klein <mtklein@chromium.org>
> Reviewed-by: Andrew Grieve <agrieve@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#703882}


Change-Id: I3df43d427998a51ebb5bf41bb5178ad5b3195865
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848351
Cr-Commit-Position: refs/heads/master@{#703892}

None of those headers are set often enough in the field to make blocking
them problematic. Also remove logging of those headers, User-Agent,
and Content-Transfer-Encoding. The latter two are now allowed to be set
by the latest version of the fetch spec.

Also remove Content-Transfer-Encoding from the network stack's
kForbiddenHeaderFields (for the aforementioned reason), but leave in
User-Agent, since there's an issue around ServiceWorkers allowing it to
be set on cross-site requests. Also add "DNT" to the list, to match
the fetch spec.

"DNT" is not added to the block list, since it's currently set in the
renderer.

Bug: 974911
Change-Id: Ie0f75ccd6f6c225031157db34c6e9a2d3be9972f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827383Reviewed-by: Shakti Sahu <shaktisahu@chromium.org>
Reviewed-by: Bill Budge <bbudge@chromium.org>
Reviewed-by: Asanka Herath <asanka@chromium.org>
Commit-Queue: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#703891}

Do not expose ARIA annotation roles unless runtime flag is used.

Platform feature status entry:
https://www.chromestatus.com/feature/4666935918723072

To enable from command line, use
--enable-features=AccessibilityExposeARIAAnnotations

NOTRY=true

Bug: 1006767
Change-Id: Id781168be1e5dfd963c753d4b176d39e4af63588
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841616
Commit-Queue: Aaron Leventhal <aleventhal@chromium.org>
Auto-Submit: Aaron Leventhal <aleventhal@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#703890}

Previously FuchsiaCdm wasn't handling NO_KEY error properly. This change
includes the following fixes to resolve this issue:
 1. Added FuchsiaDecryptor::RegisterNewKeyCB() implementation.
 2. Updated SysmemBufferWriterQueue now keeps outgoing buffers in
    |pending_buffers_| until they have been processed. This allows to pause
    and restart the stream when waiting for the key.
 3. Updated FuchsiaSecureStreamDecryptor to pause the stream after
    getting NO_KEY error.
 4. Updated FuchsiaVideoDecoder::OnDecryptorNoKey() to call WaitingCB instead
    of failing the decoder.

Test: Shaka player in WebRunner
Bug: 1007519
Change-Id: I1b2c6f00e32f83298924150ad0b0200d85d99d51
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836435
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: David Dorwin <ddorwin@chromium.org>
Auto-Submit: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#703889}

Bug: b:139355993
Change-Id: If5a0ddae8b277f7487b7a3a4aa744a312a574181
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841946Reviewed-by: Zachary Kuznia <zork@chromium.org>
Commit-Queue: Juan Pablo De Lima <jpdelima@chromium.org>
Auto-Submit: Juan Pablo De Lima <jpdelima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#703888}

This allows us to run CELab tests on Chrome.
"Choose tryjobs" now has two flavors of celab bots (chromium & chrome).

Chrome tests are needed for certain scenarios,
e.g. CloudManagementEnrollmentTokenTest: https://crrev.com/c/1779440

Config based on our existing Chromium bots, but added
'official' to get official chrome-branded builds:
  https://crrev.com/c/1841581

Which now works with the new bot & config:
  https://crrev.com/c/1836153

Based on https://crrev.com/i/1930512.

Bug: 1004563
Change-Id: Ia00cef7be4b0a6164e15b250052d867376edc139
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836602Reviewed-by: Aaron Gable <agable@chromium.org>
Commit-Queue: Mathieu Binette <mbinette@google.com>
Cr-Commit-Position: refs/heads/master@{#703887}

This change allows injection of CastContentWindow instances into
CastWebViewDefault

Bug: b/136460199
Test: Build cast_shell
Change-Id: I6c8903371f0d899936a2b5daa21bbbd125ce03b3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836132Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
Reviewed-by: Sean Topping <seantopping@chromium.org>
Commit-Queue: Shawn Gallea <sagallea@google.com>
Cr-Commit-Position: refs/heads/master@{#703886}

The added blur will only be visible when the "shelf-hotseat" flag
is enabled.

Bug: 1006965
Change-Id: I58d27a7701b22de83590fdc7ce27f402c95baf71
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834762
Commit-Queue: Matthew Mourgos <mmourgos@chromium.org>
Reviewed-by: Manu Cornet <manucornet@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#703885}

Add support for file output to the SwiftShader backend for the headless
platform.

Bug: None
Test: Manually
Change-Id: I5d1f9fce3cd493ceba8c9f3a882bd3fc0586931d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842678Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Commit-Queue: Daniel Nicoara <dnicoara@chromium.org>
Cr-Commit-Position: refs/heads/master@{#703884}

Bug: 1002733
Change-Id: I2dc14d088240c2ad0e77b70886d34c701e74a82e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845595Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Commit-Queue: Min Chen <minch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#703883}

Preliminary work as part of investigating converting the SuperSize Tiger
Viewer web worker to parse and serve .size files instead of .ndjson
files.

For now, for ease of development and testing, it's packaged as a binary.

Change-Id: Ie016922f121e78ae421f8f3720d427bf6d02b5ca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841742
Commit-Queue: Jasper Chapman-Black <jaspercb@chromium.org>
Reviewed-by: Samuel Huang <huangs@chromium.org>
Reviewed-by: Mike Klein <mtklein@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#703882}

Adds a parameter to kMarkHttpAsFeature for this experiment.

Bug: 1008218
Change-Id: I6731c8e6609ccaffd6e5654ddc121a95d88f9cc7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846560Reviewed-by: Christopher Thompson <cthomp@chromium.org>
Commit-Queue: Livvie Lin <livvielin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#703881}

Add Let's Encrypt Oak 2019, 2020, 2021, 2022 CT Logs as Qualified CT
Logs. Additionally, remove DNS API Endpoints from log_list.json now that
they are no longer used.

Bug: 963693
Change-Id: I9542ef6d6e4ecc87bdddcc59192a2bcce80f87a0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846049Reviewed-by: Ryan Sleevi <rsleevi@chromium.org>
Commit-Queue: Devon O'Brien <asymmetric@chromium.org>
Cr-Commit-Position: refs/heads/master@{#703880}

This change was reviewed earlier here https://chromium-review.googlesource.com/c/chromium/src/+/1686452 was broken down as below
1. Make copy color in color picker keyboard accessible https://chromium-review.googlesource.com/c/chromium/src/+/1817416
2. Make copy color in color picker screen-reader accessible https://chromium-review.googlesource.com/c/chromium/src/+/1818297

Gif showing UI with this change split from original change https://imgur.com/faSS7PO

Bug: 963183
Change-Id: If06b18bb640c8171343d60a743a65d062895cdde
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1818297
Commit-Queue: Chandani Shrestha <chshrest@microsoft.com>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Reviewed-by: John Emau <John.Emau@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#703879}

Do not rely on `codesign` to sign pkg files; it's the wrong tool
for the job (see https://crbug.com/913074#c12).

In addition, the correct way to build an installer package for
the end-user is to make a component package, and then wrap it
into a product package. This now correctly builds product packages.

BUG=913074

Change-Id: Ifbdba65b4d1896fdf478f276c6134182dae8e0c5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834843Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#703878}

https://pdfium.googlesource.com/pdfium.git/+log/e5c62b37f645..74dbc8af75f9

git log e5c62b37f645..74dbc8af75f9 --date=short --no-merges --format='%ad %ae %s'
2019-10-08 thestig@chromium.org Roll third_party/freetype/src/ 839a02361..5a1a79c0e (7 commits)
2019-10-08 thestig@chromium.org Remove all remaining PDFium infrastructure for V8 natives.
2019-10-03 thestig@chromium.org Roll build/ 84f457cd3..381237e19 (102 commits)
2019-10-03 thestig@chromium.org Roll tools/clang/ 51c4acfab..22ecf175f (16 commits)
2019-10-03 thestig@chromium.org Roll third_party/skia/ 8590026db..9241a6d39 (1489 commits; 340 trivial rolls)

Created with:
  gclient setdep -r src/third_party/pdfium@74dbc8af75f9

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pdfium-autoroll
Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

TBR=pdfium-deps-rolls@chromium.org

Bug: None
Change-Id: If9ab6a85cb494de40700e3d2868c6500174cdc90
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847779Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#703877}

Change Receiver_ to receiver_ to match the initialization from constructor

Change-Id: Ibe26bcc9333c9b8bac7a9e687ca5814d9453ca95
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782967Reviewed-by: Ian Clelland <iclelland@chromium.org>
Commit-Queue: Charlie Hu <chenleihu@google.com>
Cr-Commit-Position: refs/heads/master@{#703876}

Since User Timing L3 is the default, we don't need the CustomUserTiming
runtime enabled feature anymore. With this removal, we can remove
the L2 code as well as simplify the IDL for performance.mark()
and performance.measure().

Bug: 805566
Change-Id: Ifaec5f5c50aed0d50d140751c32cf80cd95a2fbd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831561Reviewed-by: Nicolás Peña Moreno <npm@chromium.org>
Reviewed-by: Steve Kobes <skobes@chromium.org>
Commit-Queue: Tom McKee <tommckee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#703875}

This reverts commit 2c483e93.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 703720 as the
culprit for failures in the build cycles as shown on:
https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzJjNDgzZTkzODU4MTgyODM3MTdiNDUxZjEwMjdmOWM1NzFhYzVjNDYM

Sample Failed Build: https://ci.chromium.org/buildbot/chromium.memory/Linux%20MSan%20Tests/19798

Sample Failed Step: browser_tests

Original change's description:
> [Paint Preview] Inject PaintPreviewTracker
> 
> Adds the ability to inject paint_preview::PaintPreviewTracker into
> blink::GraphicsContext to act similarly to printing::MetafileSkia.
> This class will track various metadata about the Paint Preview
> capture process.
> 
> Design Doc: go/fdt-design (internal)
> Part of Landing: crrev/1786583
> 
> Bug: 1008885
> Change-Id: Iba2819491bee7b284de62a1bf888aa9486c788cf
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829277
> Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org>
> Reviewed-by: Ian Vollick <vollick@chromium.org>
> Auto-Submit: Calder Kitagawa <ckitagawa@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#703720}


Change-Id: Id0364a41756df743ed5af5aa64e991da34ba2e1b
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1008885
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846727
Cr-Commit-Position: refs/heads/master@{#703874}

Enable data reduction proxy config service fetch
when lite page redirect is enabled.

Currently, the fetch is disabled if the user is in
the DRP holdback group even if lite page redirect
feature is enabled.

Change-Id: I4c8ee78207182979761fa16cef7955ea9ae2af04
Bug: 1012299
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846753
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Robert Ogden <robertogden@chromium.org>
Cr-Commit-Position: refs/heads/master@{#703873}

https://chromium.googlesource.com/angle/angle.git/+log/e600ac2a03bb..d5735c1814f7

git log e600ac2a03bb..d5735c1814f7 --date=short --no-merges --format='%ad %ae %s'
2019-10-08 jmadill@chromium.org Roll angle-internal.
2019-10-08 jmadill@chromium.org Vulkan: Get rid of "fetch" level/layer image views.
2019-10-08 jmadill@chromium.org Vulkan: Get rid of level layer "storage" views.
2019-10-08 courtneygo@google.com Vulkan: Update depth/stencil expectations

Created with:
  gclient setdep -r src/third_party/angle@d5735c1814f7

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC geofflang@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=geofflang@google.com

Bug: None
Change-Id: I2690a9f199c8ba32dc2820a75744efc2c2472a20
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847887Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#703872}

Changes:
 - Added context menu option for "Reveal in Sources Panel" on data grid entries that contain source links

Context menu on entry with source link:
https://imgur.com/PnIQF7z

Context menu on entry without source link:
https://imgur.com/xoNwSIX

Bug: 963183

Change-Id: I4c94ab2d3115704d1a8740b81161633b25b547e1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717317
Commit-Queue: Michael Liao <michael.liao@microsoft.com>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#703871}

This will be used in the ANGLE Metal back-end.

Bug: angleproject:2634
Tbr: brucedawson@chromium.org
Change-Id: I356fc8b7829c0d875dfbd0013de460a6f535ac05
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846089Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Cr-Commit-Position: refs/heads/master@{#703870}

Replaces the lower_term column in the keyword search terms table which
contains search term in lower case, with a new normalized_term column
containing the search term in lower case with the whitespaces collapsed
which will be used as a key to delete entries in addition to prefix search.

Depending on whether a search is initiated from the omnibox or the web,
the search term stored in this table may or may not have its whitespaces
collapsed. Since both of the following searches result in the same
zero-prefix suggestion, the new column can be used as a key to delete
both entries.

Omnibox search:
https://www.google.com/search?q=WEEKLY+NEWS&oq=WEEKLY+++NEWS+&sourceid=chrome...

Web search:
https://www.google.com/search?q=WEEKLY+++NEWS+++&oq=WEEKLY+++NEWS+++&...

Bug: 996516
Change-Id: I7ae5bd6a6992480b3e394499a9b94ca11d1fc8ca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832903
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#703869}

We currently only do this to disable GMBs but allocating any texture
greater than this size is not possible.

R=fserb@chromium.org

Change-Id: I9c453258eafe9ea963bf5bbe405b9ea623188b27
Bug: 952853
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846476
Commit-Queue: Khushal <khushalsagar@chromium.org>
Commit-Queue: Fernando Serboncini <fserb@chromium.org>
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Auto-Submit: Khushal <khushalsagar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#703868}

Use testdriver Action API to automate wpt tests with two touch fingers,
pointerevent_touch-action_two-finger_interaction.html.


Bug: 606367
Change-Id: Ia5a0977b3bda9c506dae99c7bfe500fe2a887cad
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1839017Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
Commit-Queue: Lan Wei <lanwei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#703867}

Previously, we used bitwise operations on booleans to keep track of
whether we are 32-bit aligned. This code ran afoul of Clang's new
-Wbool-operation and didn't implement the intended behavior. This
change fixes the bug uncovered by the warning and implements the
intended logic using boolean operations.

Bug: 1011810
Change-Id: I4a7275a4e8da274115fa8ae85c90448c036200ff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846481Reviewed-by: Samuel Huang <huangs@chromium.org>
Reviewed-by: Etienne Pierre-Doray <etiennep@chromium.org>
Commit-Queue: Bob Haarman <inglorion@chromium.org>
Cr-Commit-Position: refs/heads/master@{#703866}