GitLab

BUG=0

Review URL: https://codereview.chromium.org/1031833005

Cr-Commit-Position: refs/heads/master@{#322004}

Check all out-of-bounds errors in ELF header parsing.

BUG= none
TEST= courgette_unittests

Review URL: https://codereview.chromium.org/1031513002

Cr-Commit-Position: refs/heads/master@{#322003}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/92b47c4..62a320c

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=hcm@google.com
NOTRY=True
only failure can be layouttest, which has already been marked for rebaseline

Review URL: https://codereview.chromium.org/1022673008

Cr-Commit-Position: refs/heads/master@{#322002}

Need to initialize the WindowHostManager before the DrmCursor since the
DrmCursor depends on the WindowHostManager.

BUG=468485,467822

Review URL: https://codereview.chromium.org/1011533003

Cr-Commit-Position: refs/heads/master@{#322001}

BUG=462660

Review URL: https://codereview.chromium.org/1019063004

Cr-Commit-Position: refs/heads/master@{#322000}

BUG=406277

Review URL: https://codereview.chromium.org/1029823002

Cr-Commit-Position: refs/heads/master@{#321999}

Also, move instrumented-libraries-related stuff to a separate
.isolate file.

BUG=462636
TBR=maruel@chromium.org

Review URL: https://codereview.chromium.org/1026183003

Cr-Commit-Position: refs/heads/master@{#321998}

This patch supports the new 'First-Party-Only' cookie attribute by
changing the "Send for:" value in the cookies WebUI table to one of the
following:

* "Any kind of connection"
* "Secure connections only"
* "First-party connections only"
* "Secure first-party connections only"

BUG=468709

Review URL: https://codereview.chromium.org/1024503002

Cr-Commit-Position: refs/heads/master@{#321997}

Crashpad maintains the client ID on its own and is responsible for
sending this form parameter to the Breakpad server during report upload.
When using Crashpad as its crash-reporting implementation, Chrome does
not need to set this crash key.

When Chrome does attempt to set this crash key on its own,
crashpad_handler produces these harmless log messages:

[mmdd/hhmmss:WARNING:crash_report_upload_thread.cc(44)] duplicate key
guid, discarding value 0123456789ABCDEF0123456789ABCDEF

There are valid reasons to provide the metrics client ID along with
the crash report, so this is placed in a distinct crash key,
"metrics_client_id".

BUG=466964
R=cpu@chromium.org, isherman@chromium.org, rsesek@chromium.org

Review URL: https://codereview.chromium.org/1000203007

Cr-Commit-Position: refs/heads/master@{#321996}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/374a4c3..92b47c4

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=hcm@google.com

Review URL: https://codereview.chromium.org/1017593006

Cr-Commit-Position: refs/heads/master@{#321995}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/230d131d..19b29c5c

Please follow these instructions for assigning/CC'ing issues:
https://code.google.com/p/v8-wiki/wiki/TriagingIssues

TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org

Review URL: https://codereview.chromium.org/1033603003

Cr-Commit-Position: refs/heads/master@{#321994}

NTP_DESIGN has 3 colors that were specified in RRGGBBAA format. These
values were injected into title.html iframe via query param. The recent
fast local NTP takes rgba(r,g,b,a) format. Rather than writing converter
from RRGBBAA to 4-component, we simply store NTP_DESIGN colors in
4-component (like themes), and use existing converters in old NTP
and fast NTP where needed. Also fixing title color bug in fast NTP.

BUG=

Review URL: https://codereview.chromium.org/1007323008

Cr-Commit-Position: refs/heads/master@{#321993}

BUG=
TBR=fmalita@chromium.org

Review URL: https://codereview.chromium.org/1010433008

Cr-Commit-Position: refs/heads/master@{#321992}

This CL follows https://codereview.chromium.org/971653004/ and clarifies the
use of the various NavigationParams. In particular it merges the
CommitNavigationParams and the HistoryNavigationParams since they are generated
and sent always by pair.

BUG=459033

Review URL: https://codereview.chromium.org/1018383002

Cr-Commit-Position: refs/heads/master@{#321991}

The button state is being updated in the backButton event.
It remains hidden until the first such event and after each
click, so the <webview> can always control if the button is
needed at all.

BUG=462660

Review URL: https://codereview.chromium.org/1029053002

Cr-Commit-Position: refs/heads/master@{#321990}

Make sure Blink WebRTCSessionDescriptionRequest and WebRTCVoidRequest are deleted on the correct thread in RTCPeerConnectionHandler.
Blink objects must always be destroyed on the main render thread. Since the object holding WebRTCSessionDescriptionRequest and WebRTCVoidRequest in rtc_peerconnection_handler.cc are refcounted, the destructor is not ensured to run on the main render thread.

BUG=470047

Review URL: https://codereview.chromium.org/1023443007

Cr-Commit-Position: refs/heads/master@{#321989}

Parallel to the default content setting dictionary pref, I added N individual integer prefs. Syncable preferences are kept in sync with the matching dictionary entries, so that they can be synced to/from old versions of Chrome.

Default provider used the following, somewhat complicated, logic:
- when we read from a dictionary and there is no value for a particular content type, we reset the value to default, except if default=CONTENT_SETTING_DEFAULT, then we reset it to NULL
- when someone calls SetWebsiteSetting() with value NULL, we reset the value to default, except if default=CONTENT_SETTING_DEFAULT, then we keep NULL

I kept this logic when working with the individual preferences, which explains why there are a lot of "if NULL" and "if default==..." checks.

To make sure that we don't forget these checks on any read/write, I added two pairs of methods for reading to/writing from individual prefs/dictionary pref:

(Read|Write)(Individual|Dictionary)Pref\(\)

and a wrapper for writing to the cache

ChangeSetting().

BUG=452388
TESTED=Between trunk and old M40 stable. Syncable settings are synced both ways. Nonsyncable settings are not synced either way.

Review URL: https://codereview.chromium.org/1004733003

Cr-Commit-Position: refs/heads/master@{#321988}

BUG=438525

Review URL: https://codereview.chromium.org/1023063004

Cr-Commit-Position: refs/heads/master@{#321987}

BUG=460949
R=jochen@chromium.org

Review URL: https://codereview.chromium.org/1033433003

Cr-Commit-Position: refs/heads/master@{#321986}

Cr-Commit-Position: refs/heads/master@{#321985}

The CL destroys VPN configurations created by an extension when
the extension is disabled.

BUG=468477

Review URL: https://codereview.chromium.org/1028213002

Cr-Commit-Position: refs/heads/master@{#321984}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/7f4313b..5875d93

TBR=alph@chromium.org

Review URL: https://codereview.chromium.org/1027423003

Cr-Commit-Position: refs/heads/master@{#321983}

Potentially, client callbacks invoked inside the loop may touch
the container indirectly. This patch takes such cases just in case.

BUG=469416
TEST=LayoutTests/webmidi

Review URL: https://codereview.chromium.org/1033603002

Cr-Commit-Position: refs/heads/master@{#321982}

BUG=none
R=hpayer@chromium.org,dcarney@chromium.org

Review URL: https://codereview.chromium.org/1028373002

Cr-Commit-Position: refs/heads/master@{#321981}

 - suppress a NULL deref in blink::FocusController::focusedOrMainFrame() (issue 470055)
 - extend the suppression for leaks from content::ServiceRegistryImpl::Bind (issue 455732)

BUG=470055,455732
TBR=thakis@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/1033573003

Cr-Commit-Position: refs/heads/master@{#321980}

Red on the Nexus4 Perf bot.

BUG=470071
TBR=rune@opera.com
NOTRY=true

Review URL: https://codereview.chromium.org/1033663002

Cr-Commit-Position: refs/heads/master@{#321979}

Causing redness on Nexus 10 perf bot.

BUG=470071
TBR=dtu@chromium.org,rune@opera.com
NOTRY=true

Review URL: https://codereview.chromium.org/1022543004

Cr-Commit-Position: refs/heads/master@{#321978}

Revert of Revert of Unflake V8 sampling profiler tests. (patchset #1 id:1 of https://codereview.chromium.org/1017183004/)

Reason for revert:
Suspecting goma flake. Relanding.

Original issue's description:
> Revert of Unflake V8 sampling profiler tests. (patchset #1 id:1 of https://codereview.chromium.org/1032633002/)
>
> Reason for revert:
> Broke compilation on Mac Builder:
> https://build.chromium.org/p/chromium.mac/builders/Mac%20Builder/builds/19512/steps/compile/logs/stdio
>
> when compiling content/renderer/devtools/v8_sampling_profiler_browsertest.cc
>
> Original issue's description:
> > Unflake V8 sampling profiler tests.
> >
> > BUG=406277
> >
> > Committed: https://crrev.com/d6493ce2a4ed6f346a31597ac27748a3429a1d95
> > Cr-Commit-Position: refs/heads/master@{#321970}
>
> TBR=yurys@chromium.org,alph@chromium.org
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=406277
>
> Committed: https://crrev.com/3703085199a63732add21d955c6280765e3c480e
> Cr-Commit-Position: refs/heads/master@{#321975}

TBR=yurys@chromium.org,pneubeck@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=406277

Review URL: https://codereview.chromium.org/1029353002

Cr-Commit-Position: refs/heads/master@{#321977}

If a canonical server advertises an alternative service without an explicit
hostname, or an alternative protocol, then it is implied that the same
alternative service works on other hosts.  This CL adds a test to verify that if
SetAlternativeService is called with an empty host (denoting no explicit
hostname in the alternative service advertisement), then
GetAlternativeService(origin) returns alternative services with host ==
origin.host().  This will be important once HttpServerProperties starts storing
alternative services with hostname to make sure current behavior is preserved.

BUG=392576

Review URL: https://codereview.chromium.org/1029633002

Cr-Commit-Position: refs/heads/master@{#321976}

Revert of Unflake V8 sampling profiler tests. (patchset #1 id:1 of https://codereview.chromium.org/1032633002/)

Reason for revert:
Broke compilation on Mac Builder:
https://build.chromium.org/p/chromium.mac/builders/Mac%20Builder/builds/19512/steps/compile/logs/stdio

when compiling content/renderer/devtools/v8_sampling_profiler_browsertest.cc

Original issue's description:
> Unflake V8 sampling profiler tests.
>
> BUG=406277
>
> Committed: https://crrev.com/d6493ce2a4ed6f346a31597ac27748a3429a1d95
> Cr-Commit-Position: refs/heads/master@{#321970}

TBR=yurys@chromium.org,alph@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=406277

Review URL: https://codereview.chromium.org/1017183004

Cr-Commit-Position: refs/heads/master@{#321975}

From the documentation:
"Provides the Apple-recommended user-visible name for an endpoint, by combining the device and endpoint names."

This fixes the problem of port names of "Out Port 1", "Out Port 2" without a sense of the device it belongs to.

Review URL: https://codereview.chromium.org/1025903003

Cr-Commit-Position: refs/heads/master@{#321974}

This benchmark is causing redness on the perf tree.

BUG=470071
TBR=dtu@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/1029603005

Cr-Commit-Position: refs/heads/master@{#321973}

BUG=439423

Review URL: https://codereview.chromium.org/1019243007

Cr-Commit-Position: refs/heads/master@{#321972}

This reverts commit 82072cae.

The benchmark doesn't fail anymore with the new V8 roll.

BUG=469146

TBR=sullivan@chromium.org

Review URL: https://codereview.chromium.org/1026303002

Cr-Commit-Position: refs/heads/master@{#321971}

BUG=406277

Review URL: https://codereview.chromium.org/1032633002

Cr-Commit-Position: refs/heads/master@{#321970}

R=isherman@chromium.org
BUG=

Review URL: https://codereview.chromium.org/1022383003

Cr-Commit-Position: refs/heads/master@{#321969}

BUG=468778

Review URL: https://codereview.chromium.org/1014003004

Cr-Commit-Position: refs/heads/master@{#321968}

BUG=432280

Review URL: https://codereview.chromium.org/1006913004

Cr-Commit-Position: refs/heads/master@{#321967}

The predictor usually serializes its state on a clean shutdown, so doesn't on
Android. This fixes it.

BUG=467007

Review URL: https://codereview.chromium.org/1004093003

Cr-Commit-Position: refs/heads/master@{#321966}

Some pages contain a login form and a sign-up form squashed in one <form> element. While that is a bad practice, Chrome should be able to distinguish these forms from change-password forms (the difference being that the former will have at least one non-password text field between the login-part password field and the sign-up part password fields). This distinction enables Chrome to work on the login forms.

BUG=449714

Review URL: https://codereview.chromium.org/1014683006

Cr-Commit-Position: refs/heads/master@{#321965}