- 14 Aug, 2020 40 commits
-
-
Mike Dougherty authored
This DCHECK occasionally triggers, but for unknown reasons. Update the DCHECK to exclude re-registering the same main web frame. This will separate the issue from the same frame being re-registered which will be caught by the next, already existing DCHECK. Bug: 1014227 Change-Id: Ic5a248f12467812e2b6b287565aa37f675935661 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354713 Auto-Submit: Mike Dougherty <michaeldo@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#798205}
-
Yuke Liao authored
This CL adds an optional linux-lacros-rel try builder, and it will replace linux-lacros-compile-rel in the future. Bug: 1116180 Change-Id: I46f3827848ff64ade1773d18d146a888312b4bd1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354723Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#798204}
-
Peter E Conn authored
The AGA experiment id changes in: https://chromium-review.googlesource.com/c/chromium/src/+/2338934 does not work when the StartupTabPreloader is used. Since the StartupTabPreloader launches the navigation before all of native is loaded, fixing this isn't simply a matter of moving the experiment reading code earlier - it would involve changing Chrome's startup logic. This change allows clients to disable the StartupTabPreloader to ensure that the experiment logic in the linked CL is triggered (at the cost of a longer time to navigation on cold start). Change-Id: Ie83b4f38705084c567d7c20821600de7cdf15695 Bug: 1111941 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2356505 Commit-Queue: Peter Conn <peconn@chromium.org> Commit-Queue: Yaron Friedman <yfriedman@chromium.org> Auto-Submit: Peter Conn <peconn@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#798203}
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/afdo-chromium-autoroll Please CC gbiv@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: gbiv@chromium.org Change-Id: I31ae2e232712c31a7f85476af1aa59ae14c6a585 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2356545 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#798202}
-
Alan Screen authored
Instantiating a PrintBackend class is done through a CreateInstance() call. This call has included a parameter to optionally seed the new instance with some initial values different from the defaults. This parameter is never made use of in the existing code. Cleanup of this parameter will ease the effort to mojoify the PrintBackend class. Bug: 809738 Change-Id: I460e3edd14c2fd830d9d8f126b84619ec9e53597 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354541Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Commit-Queue: Alan Screen <awscreen@chromium.org> Cr-Commit-Position: refs/heads/master@{#798201}
-
Ryan Hansberry authored
Use the new bluetooth::mojom::Adapter::SetDiscoverable() to implement Nearby Connections' BluetoothAdapter::SetScanMode(). Notably, BluetoothAdapter::SetScanMode() can only toggle discoverability on or off; it cannot be used to power Bluetooth on or off. This aligns to the actual usage of this method by Nearby Connections. See go/nearby-chrome-bt for more information. Bug: b:154848416, b:154845584, b:154847207 Change-Id: I5802372d8f47d99af4fa1879efa89a3c0de52e32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350388Reviewed-by:
James Vecore <vecore@google.com> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#798200}
-
Nate Fischer authored
This reverts commit 4feae4d0. Reason for revert: this is failing on the official tester on M86, https://crbug.com/1112409#c9 Original change's description: > Revert "Marking SiteSettingsTest.testClearDomainCookies as flaky test." > > This reverts commit 1d4d72e9. > > Reason for revert: I don't see flakiness on testers for trunk. Maybe the issue got fixed already and only exists in M85. > > Original change's description: > > Marking SiteSettingsTest.testClearDomainCookies as flaky test. > > > > TBR=dullweber@chromium.org > > > > Bug: 1112409 > > Change-Id: Idf31c4a8d709ddc3f4f87cff63d63881f0198424 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346853 > > Reviewed-by: Ben Mason <benmason@chromium.org> > > Commit-Queue: Ben Mason <benmason@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#796524} > > TBR=benmason@chromium.org > > Change-Id: Idbbd6d8947bc9d986a16ccd094775e49bd7243d4 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1112409 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348769 > Reviewed-by: Christian Dullweber <dullweber@chromium.org> > Commit-Queue: Christian Dullweber <dullweber@chromium.org> > Cr-Commit-Position: refs/heads/master@{#796769} TBR=dullweber@chromium.org,benmason@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1112409 Change-Id: I7a20044bbae961197c6b3354b815bea6c645f238 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357072Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#798199}
-
Wen-Chien Wang authored
Previously the only way to pin an unpinned open app in shelf is to use the context menu. In this update, we enable the feature that dragging an unpinned open app to the pinned app side is available to pin the app. Bug: 1084856 Change-Id: I559a8967942a1c4d6ee7eb370cd81181b173c361 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321065Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Commit-Queue: Wen-Chien Wang <wcwang@google.com> Cr-Commit-Position: refs/heads/master@{#798198}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/ec709593d585..3bd3c99b4d5c 2020-08-14 Han) Zhang Reland "Modified git cl format for distributed histograms" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: I84e5cc48426dfa1b13b533edd4f520de458f4eb1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354780Reviewed-by:
-
Tamir Duberstein authored
This allows the flags field to be changed to a FIDL |bits| type without breaking the Chromium build. The |static_cast|s introduced in this change will be removed after the next Fuchsia SDK roll. Bug: 1099393 Change-Id: Ie0628ac0dbe7dd8dd407d5907b0ef38cbd839da8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353295 Commit-Queue: Tamir Duberstein <tamird@google.com> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#798196}
-
Brian Sheedy authored
Switches RenderTestRule to exclusively use the new naming scheme that does not include device model or OS in the test name. Bug: 1077274 Change-Id: I3dd4e4088151732e83d8ac7fe5a52e10cfe6252c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354715Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#798195}
-
Dan Harrington authored
This change ensures that the surface can't be opened more than once, and only closes after opening. Also verifies that all conditions are met prior to opening. While testing this, I noticed scroll restore wasn't working. I've fixed this by waiting until the recycler view adapter has the right number of items before attempting to restore. Bug: 1115213 Change-Id: I86bae811926fa4a6c1caf1f8dce8e32e80152613 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354656Reviewed-by:
Vincent Boisselle <vincb@google.com> Commit-Queue: Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#798194}
-
Ben Joyce authored
CQ bots generate an html report using this script and we won't know if the developer needs the host or device report, so generate both. BUG: 1116208 Change-Id: Idd2a841c495b87d6f382acb1771b9f2842908508 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355571Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Commit-Queue: benjamin joyce <bjoyce@chromium.org> Cr-Commit-Position: refs/heads/master@{#798193}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/goldctl-linux-chromium-autoroll Please CC bsheedy@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: bsheedy@chromium.org Change-Id: Ic0167dca9bf05c30ec795a5f02fd220618b58e5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355523Reviewed-by:
-
Xiaohui Chen authored
* Previously display idle event will restart ambient mode. Fixed the unittest that should have caught this. * Also added some DVLOG for future debugging. Bug: None Change-Id: I49cc798f4d975a3449e506b835469bd740b4308f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354945 Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#798191}
-
Thomas Lukaszewicz authored
This CL amends the units used on the histogram Tabs.TabSearch.WindowDisplayedDuration from the incorrect units "seconds" to the correct units "ms". Bug: None Change-Id: I80364b76d862834036a3eceaae586579e7a31560 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354774Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Cr-Commit-Position: refs/heads/master@{#798190}
-
David Van Cleve authored
This change cleans up some temporary crash keys used while investigating crbug.com/1111735. R=lukasza Bug: 1111735 Change-Id: I441744d269f8afc508930b51623b992194d1327a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355293Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Auto-Submit: David Van Cleve <davidvc@chromium.org> Cr-Commit-Position: refs/heads/master@{#798189}
-
sczs authored
Bug: 1085419 Change-Id: I545fec75952e76b449179f3ec7e676df16db6bc0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354602Reviewed-by:
-
Samuel Huang authored
This CL adds the script and the target needed to extract Lacros binary / resource size histogram JSON files, which are needed for size monitoring on Chrome Performance Dashboard. Following the methodology of how Android Chrome creates resource size histograms (in //build/android), the key parts are: * Target "resource_sizes_lacros_chrome" to create wrapper script in $OUT_DIR/bin for the main script. This will be called by build bots (hook to be added in follow-up). * lacros_resource_sizes.py to read Lacros build artifact sizes, and to export the result to histogram JSON files. lacros_resource_sizes.py is specialized for Lacros to simplify code. The script accounts for each file in the ZIP file created by the chromeos-amd64-generic-lacros-rel builder, but files can be aggregated by a list and/or by directories. Changes in ZIP file content will require updates to lacros_resource_sizes.py for proper size accounting. Bug: 1106626 Change-Id: I9e42eeb2d54105b47fe37730ba098256bd67de54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346910Reviewed-by:
Samuel Huang <huangs@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Reviewed-by:
Erik Chen <erikchen@chromium.org> Reviewed-by:
-
Hazim Mohamed authored
Change NativeFS Drag & Drop from a 'test' runtime enabled feature to an 'experimental' runtime enabled feature. This will enable NativeFS drag and drop by default if enable-experimental-web-platform-features flag is set. Bug: 1080811 Change-Id: Ie3fcc4a28f22a3287cf64607b90e44a0f7767607 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2356188Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Hazim Mohamed <hazimmohamed@google.com> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Auto-Submit: Hazim Mohamed <hazimmohamed@google.com> Cr-Commit-Position: refs/heads/master@{#798186}
-
Jesse Schettler authored
Scanning is no longer going to be a part of the print management app, so remove its code from that app and create a new scanning web app. The empty app can be opened from chrome://scanning and is hidden behind a feature flag that is disabled by default. A subsequent CL will convert the app to a system web app (SWA). Bug: 1059779 Change-Id: I6d64886ea6e32be85cb265f03af173a0262fdc3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346922 Auto-Submit: Jesse Schettler <jschettler@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Jimmy Gong <jimmyxgong@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#798185}
-
James Vecore authored
This CL mocks the IsProfileActive method on the |MockNearbyProcessManager| so we don't need to depended on calling singleton methods in tests and tear down. Change-Id: If690f77baee8ae7e106be2b9ca3a618a058437d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354990 Commit-Queue: James Vecore <vecore@google.com> Reviewed-by:
Alex Chau <alexchau@chromium.org> Auto-Submit: James Vecore <vecore@google.com> Cr-Commit-Position: refs/heads/master@{#798184}
-
Peter Boström authored
This removes UpdateAccelerators() as calls to View::ResetAccelerators() remove dialog buttons' VKEY_RETURN default handlers as well. Removing UpdateAccelerators() works as DialogModelField accelerators are const on construction so they never need to be updated. Bug: 1106422 Change-Id: I1d39cc3d72c6ab043381f8a5c858b1b2ed828558 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355290 Commit-Queue: Peter Boström <pbos@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#798183}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/6f6dc9f3..b5bfc190 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I03ff9e5060573a97e2d332eabe865096d2dcb3cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2356184Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#798182}
-
Thomas Lukaszewicz authored
WebAppFrameToolbarView now invalidates its layout when in fullscreen on Mac, necessary since the frame needs to layout toolbar buttons and remains visible in Mac's fullscreen mode. Fixed a related FindBar bug incorrectly anchoring to the web app frame when the frame was not visible. Bug: 1063304 Change-Id: Ic6ae3ffbeaa32bd548bcf010f3218455073d7afc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2176603 Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#798181}
-
Yunke Zhou authored
Bug: 1101318 Change-Id: I4750459cbdf3a069c76ca8726ed75c647ac5d387 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352894 Commit-Queue: Yunke Zhou <yunkez@google.com> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#798180}
-
Lijin Shen authored
Remove the incorrect assumption which causes consistent assertion failure on multi-instance tab merging. Bug: 1100460, 1080810 Change-Id: Ief512fa3450e0999fdd9588a5ec6b7b6536691d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2318446Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Lijin Shen <lazzzis@google.com> Cr-Commit-Position: refs/heads/master@{#798179}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-chrome TBR=chrome-os-gardeners@google.com Change-Id: I593804596b1ed7045636d9a37b19d92d28c9f9ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2356048Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#798178}
-
Hitoshi Yoshida authored
We redesigned fooOr() APIs to be available with some limited types. This CL applies the design as following. - numeric types, IDL enum : T fooOr(T) - (nullable) string types : String fooOr(const String&) - (nullable) IDL dictionary : const T* fooOr(nullptr_t) - (nullable) other IDL definitions : T* fooOr(nullptr_t) - types converted to base::Optional : base::Optional<T> fooOr(base::nullopt_t) Bug: 839389 Change-Id: Iba6ab3812f023a573c428ad96117d78544351121 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2319090 Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#798177}
-
Weilun Shi authored
This is a hacky way to fix the regression problem after using the unsafe appendChild. We need to convert the merged doc back and forth to make sure it builds indexes for the later pretty-print. Bug: 1115727 Change-Id: I9225999aec8132e3a069fe79cacc8b1377e99af7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354206Reviewed-by:
-
Maksim Sisov authored
These packages are required by the Ozone/Wayland build and will make the step that checks lib deps for chrome binary happy ones the browser is compiled with use_x11 && use_ozone (and ozone_platform_wayland=true, of course (set by default)). Test: built installer step for use_x11 && use_ozone config Bug: 1116384 Change-Id: I724537766815def49bb1269485433f5f4c2c8e8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352884Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Maksim Sisov (GMT+3) <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#798175}
-
David Bienvenu authored
This prefixes the PWA AppUserModelId with GetBaseAppId(), to distinguish between different Chrome channels, and different browsers. Existing chrome proxy shortcuts pinned to the taskbar will get migrated by MigrateTaskbarPins on startup - GetExpectedAppId looks at the shortcut commandline and prefixes the expected app id with install_static::GetBaseAppId() if the command line has a kApp or kAppId switch. Bug: 1084751 Change-Id: I91d21069c8313e1e274cbde22ba3d203c288287d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285399 Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#798174}
-
Ben Pastene authored
Testing what a description will look like on Milo for a staging builder. Bug: None Change-Id: I22cb9374ba60bdddc24879567d3abe6890eb68dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355275Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Erik Staab <estaab@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#798173}
-
Maksim Sisov authored
ChromeOS switched to Ozone quite some time ago and no longer supports non-Ozone/X11. However, when I started to enable use_ozone for is_linux, is_chromeos started to build use_x11 as well, which is not correct. Atm, use_x11 is not built for is_chromeos, because use_ozone = is_chromeos, and this line is just redundant. Bug: None Change-Id: I38ad54cd2febd5a8cce57bc29d092525e07cb715 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353265 Auto-Submit: Maksim Sisov (GMT+3) <msisov@igalia.com> Commit-Queue: Dirk Pranke <dpranke@google.com> Reviewed-by:
-
chromium-internal-autoroll authored
Release_Notes:http://go/help_app-x20/relnotes/Nightly/help_app_nightly_202008140800_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/help_app/app/+/Fa2uaWyUkyfb0dZlfDu9CiOQue9NyZDytZiTrkZdzm0C If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/help-app-chromium-autoroll Please CC help-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: b/163673595,b/163960769 Tbr: help-app@grotations.appspotmail.com Change-Id: Ieb24c0a2a545c73ec8d767418daf5faf1f08682d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355563Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#798171}
-
Maksim Sisov authored
Change-Id: I94756241300ec1d90fdc87391ec57c2dabc7b512 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355951Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Commit-Queue: Maksim Sisov (GMT+3) <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#798170}
-
Lexi Stavrakos authored
Binds quota_host_ in AddedChangeListener() if not already bound so that StartObserving() can pass the listener back to the browser side. Bug: 1116316 Change-Id: I43e5bed0dc6cb931c3f950faee05b1c1f3e60ea8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2356284Reviewed-by:
Jarryd Goodman <jarrydg@chromium.org> Commit-Queue: Lexi Stavrakos <astavrakos@google.com> Cr-Commit-Position: refs/heads/master@{#798169}
-
Scott Violet authored
I was surprised to see occluded_region is in the coordiantes of the root window. This renames Window::occluded_region to make this more obvious. This also removes the SkRegion argument of WindowDelegate::OnWindowOcclusionChanged() as it's unused. I'm doing this as it is unused, but also because the coordinates are rather confusing. BUG=none TEST=none Change-Id: I99910e29e9efb1abf8c7854ae57d3d7dcc636763 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336058Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#798168}
-
Yuke Liao authored
The goal is to set up a linux-lacros-rel try builder that that runs a subset of test suites from linux-lacros-tester-rel, so this CL creates a virtual CI builder for linux-lacros-rel to mirror. Bug: 1116180 Change-Id: Id9fba6c6c20d7437e4bc8b22b14dcaf28e60ee37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355003Reviewed-by:
-
Joe Downing authored
The current value for this policy indicates that it applies to all ChromeOS versions after M41 however this isn't right as that policy was not read on ChromeOS prior to a change I made in M86. This CL updates the 'supported on' value to match what the product actually supports. BYPASS_POLICY_COMPATIBILITY_CHECK=The previous value was incorrect but setting the correct value causes the policy checker to complain. Change-Id: I50e21fe9828cb54f6cfaa11a9a120c0f4b89ad40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354593 Commit-Queue: Joe Downing <joedow@chromium.org> Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#798166}
-
