GitLab

Limit form-less Autofilling to pages that look like checkout pages.

This should hopefully stem the tide of false positives on non-checkout pages, while preserving desired behavior on Best Buy and Apple checkout.

Fixing FormStructureBrowserTests: I went back and added <form>s that were present in the source pages but not in the local copies. I also added the original <title> tags, except for ones that did /not/ include any of the checkout keywords. For these, I added the checkout keywords to the title, so that the test still had some value (instead of passing trivially because the title was "Google Calendar" and not something like "Payment information").

BUG=471090, 477466
original review: https://codereview.chromium.org/1081803003/
TBR=brettw@chromium.org, thestig@chromium.org

Review URL: https://codereview.chromium.org/1111583002

Cr-Commit-Position: refs/heads/master@{#327215}

For now, this only happens in debug builds.

BUG=369661
TEST=NavigationControllerBrowserTest.NavigationTypeClassification_*
TEST=Every other test on the planet.

Committed: https://crrev.com/d8d93348bbd8c646c337bdaa40fc0c64204fc5ff
Cr-Commit-Position: refs/heads/master@{#327122}

Reverted: https://crrev.com/5348e920f4119aff9a4eb76c0965725dc85a66cc
Cr-Revert-Position: refs/heads/master@{#327152}

Review URL: https://codereview.chromium.org/1002803002

Cr-Commit-Position: refs/heads/master@{#327214}

In libevent, socketpair() is used. However, it will be prohibited
by seccomp-bpf in nacl_helper_nonsfi. As its preparation, this CL
stubs out signal.c, which is the only module calling socketpair().

TEST=Ran bots.
BUG=358417
CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_chromium_trusty32_rel,linux_arm
TBR=darin@chromium.org

Review URL: https://codereview.chromium.org/1093113002

Cr-Commit-Position: refs/heads/master@{#327213}

These three binaries still don't quite build.

TBR=phajdan.jr@chromium.org
BUG=463528

Review URL: https://codereview.chromium.org/1106403002

Cr-Commit-Position: refs/heads/master@{#327212}

Previously, Display would read the device scale factor from the command
line in its ctor, but then screen would clobber it.  This meant that
the force device scale factor command line flag was silently ignored.

R=oshima@chromium.org,ccameron@chromium.org

Review URL: https://codereview.chromium.org/1111543003

Cr-Commit-Position: refs/heads/master@{#327211}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/12c2339..649b7e8b

TBR=tkent@chromium.org,pdr@chromium.org

Review URL: https://codereview.chromium.org/1108983003

Cr-Commit-Position: refs/heads/master@{#327210}

Make sure that we always include the dashboard reset link in any passphrase
prompt. Also ensure we use the term "sync passphrase" rather than "google
password". Lastly, use the passphrase time if its available.

BUG=481224

Review URL: https://codereview.chromium.org/1101373002

Cr-Commit-Position: refs/heads/master@{#327209}

Looks like it was there on the initial commit.

Review URL: https://codereview.chromium.org/1102673004

Cr-Commit-Position: refs/heads/master@{#327208}

This implements support for Rappor metrics which contain
multiple fields that support correlation analysis.
Example:
scoped_ptr<Sample> sample = rappor_service->CreateSample(COARSE_RAPPOR_TYPE);
sample->SetStringField("Domain", "google.com");
sample->SetFlagsField("Flags", 0x10, 8 /* # of bits */);
rappor_service->RecordSampleObj("MyMetric", sample.Pass());

This change also removes metric_name from the personalization string for the PRR.  This means that two different metrics which report the same value will use the same PRR, which will improve privacy when multiple metrics report the same value.

BUG=451647

Review URL: https://codereview.chromium.org/1090683003

Cr-Commit-Position: refs/heads/master@{#327207}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/d7c014f..95cc012

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=humper@google.com

Review URL: https://codereview.chromium.org/1104423002

Cr-Commit-Position: refs/heads/master@{#327206}

Recent refactoring allows us to remove many CRD-specific files from
the set of "common" JS files. This cl moves the CRD UI JS files
out of the AppRemoting build. This is in preparation for removing
Application.Mode in a follow-up cl.

Requires that crrev.com/1109453005 land first.

BUG=

Review URL: https://codereview.chromium.org/1095203010

Cr-Commit-Position: refs/heads/master@{#327205}

If a script inserts text into an input field without a user gesture,
then do not show the autofill popup.

TEST=AutofillRendererTest.IgnoreNonUserGestureTextFieldChanges
BUG=353001

Review URL: https://codereview.chromium.org/1026493002

Cr-Commit-Position: refs/heads/master@{#327204}

Run the GotDataCallback for distiller feedback responses.

BUG=

Review URL: https://codereview.chromium.org/1106293004

Cr-Commit-Position: refs/heads/master@{#327203}

Note that this is only partial implementation.

BUG=481184,480709
TEST=gpu_unittests
R=piman@chromium.org

Review URL: https://codereview.chromium.org/1106833002

Cr-Commit-Position: refs/heads/master@{#327202}

Add a listener on the ExtensionList object for when the count of extensions
moves from 0 to 1, or from 1 to 0 - i.e., when we should show or hide the
list.

BUG=480110

Review URL: https://codereview.chromium.org/1105683003

Cr-Commit-Position: refs/heads/master@{#327201}

Sign-in button on sign-in promotion panel can be clicked multiple times,
which can lead to a crash. We should make sure that signing in logic only
happens once.

BUG=477139

Review URL: https://codereview.chromium.org/1073943003

Cr-Commit-Position: refs/heads/master@{#327200}

CacheStorageListener and CacheStorageDispatcher are now in a 1:1 relationship
and the indirection is no longer necessary. As a first step of merge, this CL
moves message handlers for CacheStorage API from the listener to the dispatcher.

BUG=474233
TEST=content_unittests --gtest_filter=CacheStorage*

Review URL: https://codereview.chromium.org/1101733005

Cr-Commit-Position: refs/heads/master@{#327199}

If the first character of an extension api enum is a digit (we know that the
enums can only be composed of a-zA-Z0-9_ now), then precede it with a digit
so that people can do chrome.fooApi._345_CRAZY_ENUM.

BUG=463184

Review URL: https://codereview.chromium.org/1107223002

Cr-Commit-Position: refs/heads/master@{#327198}

* This fixes some glitches in the decoder where we were not ending up
with the correct 'context lost' reason, such as calling things in
the wrong order or calling glGetGraphicsResetStatus() while we might
not have the correct context current.

* Add context lost reasons for when the context group is forcibly lost
when GL_OUT_OF_MEMORY is detected and when MakeCurrent fails.

* Also communicate parse errors to the client.

* Record UMA histograms for each context type
(for example 'browser compositor') with the context lost reason.

* Always lose (client-side) share-group if we force-lose
a context so we don't leak resources.

* Fix a bug where we weren't deleting GL resources if the context was
lost although we might still be able to make it current.

Add a bunch of tests.

BUG=475676

Review URL: https://codereview.chromium.org/1095893002

Cr-Commit-Position: refs/heads/master@{#327197}

Call registerToReceiveNotificationsAlways in CastBrowserHelper.
Cast shell expects to receive network notifications at all times to
properly update network state.

R=gunsch@chromium.org
BUG=internal b/20641901

Review URL: https://codereview.chromium.org/1106363003

Cr-Commit-Position: refs/heads/master@{#327196}

Now that we theoretically have fixed the compile problems
in #327164, we should try to build all of the normal test targets.

This reverts commit 724dc580 (#326955).

TBR=phajdan.jr@chromium.org
BUG=463528
CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_chromium_gn_chromeos_dbg

Review URL: https://codereview.chromium.org/1108203002

Cr-Commit-Position: refs/heads/master@{#327195}

TBR=paulmeyer@chromium.org
BUG=481651
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_msan_rel_ng

Review URL: https://codereview.chromium.org/1102403003

Cr-Commit-Position: refs/heads/master@{#327194}

Previously, the flag was being used for both debug and release builds.

BUG=480622

Review URL: https://codereview.chromium.org/1108933002

Cr-Commit-Position: refs/heads/master@{#327193}

BUG=473837,431717
TBR=bengr@chromium.org

Review URL: https://codereview.chromium.org/1103293003

Cr-Commit-Position: refs/heads/master@{#327192}

This reverts commit 7a15c817, bringing
back the following changes:

[Mac] Always sets the status bubble to 1pt wide when hidden.

When the status bubble is in state kBubbleHidden, its width is now always 1pt.
This prevents us from wasting time resizing and redrawing a hidden bubble.

[Mac] Cleans up the StatusBubbleMac code.

This CL reduces unnecessary work in StatusBubbleMac and replaces it with some
logging to track down when invariants are violated.  (The presumed invariant
here is that we set kWindowSizeDeterminedLater once, when state is set to
kBubbleHidden, and the size stays that way until the bubble transitions to a
different state.  If that invariant held, then we wouldn't need to constantly
re-set the size for a hidden bubble.  This invariant is being violated on the
GPU bots, so the logging is in place to try to find and fix the cause.)

BUG=454502
BUG=467998
TEST=No visible impact.  Status bubble should continue to show when hovering over links and resize properly when the window size is changed.
TEST=No visible impact.  Status bubble should continue to show, expand, and hide properly.

Review URL: https://codereview.chromium.org/1103323002

Cr-Commit-Position: refs/heads/master@{#327191}

Fixes breaks from two recent CLs:
  https://codereview.chromium.org/1091513005
  https://codereview.chromium.org/1109943002

BUG=NONE
TEST=ToT builds mojo and mandoline.
R=sky@chromium.org
TBR=jam@chromium.org,ben@chromium.org

Review URL: https://codereview.chromium.org/1110823002

Cr-Commit-Position: refs/heads/master@{#327190}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/9b3210f..12c2339

TBR=tkent@chromium.org,pdr@chromium.org

Review URL: https://codereview.chromium.org/1103263005

Cr-Commit-Position: refs/heads/master@{#327189}

Previously, //content/test:test_support depended directly on *_sources
targets. In component builds, this caused the browser_tests and
content_browsertests binaries to include their own copies of content as
well as depend on libcontent.so. This caused browser_tests and
content_browsertests to crash on startup. This CL changes test_support
to depend on the targets that forward to //content in component builds
and introduces such targets for gpu and ppapi_plugin.

The test_support changes also exposed underspecified dependencies in
extensions/renderer/BUILD.gn and third_party/libjingle/BUILD.gn, and
incorrect generated file dependencies in content/browser/devtools; the
generated files depend on other non-generated files so have to be
directly included in //content/browser.

BUG=432959

Review URL: https://codereview.chromium.org/1104973002

Cr-Commit-Position: refs/heads/master@{#327188}

These directories were added here:
https://codereview.chromium.org/1085233004/

R=ben@chromium.org,erg@chromium.org,msw@chromium.org
TBR=ben@chromium.org

Review URL: https://codereview.chromium.org/1105303002

Cr-Commit-Position: refs/heads/master@{#327187}

Add logic to make sure that page sets paired with
smoothness/repaint only have interaction records with same label & they have repeatable flags enabled.

To make sure that this doesn't crash any smoothness
benchmarks, I modified benchmark_smoke_unittest to run all
smoothness benchmarks (including ones that only support
android) in patch #3. To validate the test runs, see
telemetry_perf_unittest's result in patch #5

smoothness.key_silk_cases: https://codereview.chromium.org/1111543002/

smoothness.polymer:
https://codereview.chromium.org/1060583012

BUG=444701,444703

Review URL: https://codereview.chromium.org/1104573002

Cr-Commit-Position: refs/heads/master@{#327186}

R=rdsmith@chromium.org
BUG=481664

Review URL: https://codereview.chromium.org/1111593002

Cr-Commit-Position: refs/heads/master@{#327185}

Skip native_viewport's init of gfx::GLSurface when headless.
Remove the unused --use-osmesa flag (--use-test-config suffices?).
Re-enable the window_manager_apptests again; fingers crossed.

BUG=480040
TEST=Bot passes window_manager_apptests.
R=sky@chromium.org
TBR=jochen@chromium.org

Review URL: https://codereview.chromium.org/1103413002

Cr-Commit-Position: refs/heads/master@{#327184}

The -Oz flag enables more aggressive size optimizations. Shrinks the
libchromeshell.so DSO by around 2.5MB.

BUG=481675
R=thakis@chromium.org

Review URL: https://codereview.chromium.org/1103393002

Cr-Commit-Position: refs/heads/master@{#327183}

No test because SigninManager is low on my list of things to write tests
for. I've filed http://crbug.com/481099 to track it.

BUG=478597

Review URL: https://codereview.chromium.org/1100983005

Cr-Commit-Position: refs/heads/master@{#327182}

BUG=471322
TEST=EME tests pass

Review URL: https://codereview.chromium.org/1050823009

Cr-Commit-Position: refs/heads/master@{#327181}

Modify initial the offscreen size if empty
DCHECK to assert that we don't run into this situation again

BUG=481035

Review URL: https://codereview.chromium.org/1106773002

Cr-Commit-Position: refs/heads/master@{#327180}

Mac Chromium.app sizes expectations were last updated after the switch
to 64-bit which had a large increase (r305043 and
http://crbug.com/435576).

Later, there was a large drop for Chromium.app in r314575 due to the PDF
plugin being combined into the ChromiumFramework. The perf expectations
for ChromiumFramework were updated, but not Chromium.app.

This has meant that large jumps are unlikely to affect the Mac sizes
tree-closers, since they are absorbed into the gains from r314575.
Instead, large jumps are getting picked up late because they are triaged
from perf graphs rather than the Chrome waterfall.

Chrome has been growing about 1MB per month on average. Set the
tolerance to 1% (rather than 5%) for something likely to detect the
recent large erroneous jumps.

After this, Chromium.app will close the tree once it gets to 159,128kB.
The prior threshold was 165,929kB. Chromium.app currently reports
157,589kB

Also update ChromiumFramework. It's not out of whack, but it makes sense
for it to share a common threshold tolerance with Chromium.app.

BUG=468637

Review URL: https://codereview.chromium.org/1101133004

Cr-Commit-Position: refs/heads/master@{#327179}

BUG=463245

Review URL: https://codereview.chromium.org/1104883002

Cr-Commit-Position: refs/heads/master@{#327178}

Currently the dumpsys power monitor uses a static value of 4.0 for the voltage
when determining the power usage. This changes it to get the voltage from the
device to make the power measurements more accurate.

BUG=476043

Review URL: https://codereview.chromium.org/1107173002

Cr-Commit-Position: refs/heads/master@{#327177}

Add a comment to UpdateProcThreadAttribute() to note that its parameter needs
to outlive this.

BUG=476316

Review URL: https://codereview.chromium.org/1106263002

Cr-Commit-Position: refs/heads/master@{#327176}