GitLab

Adds a "sync" trace event category that traces the following events:
- model association time
- time spent in each step of the syncer state machine
- transactions

Also included is a "sync_lock_contention" category that tracks the time spent
acquiring the sync lock. This information would normally clutter up the logs,
but it is useful information when we suspect lock contention is an issue.

To trace model association tracing, I needed to have a set of strings with
application lifetime representing each model type.  I have changed the
return type of ModelTypeToString from std::string to const char* to meet this
need.

In the interest of avoiding duplicate functionality, this change also removes
other mechanisms for tracing transaction time. In particular, some of the log
messages around acquiring and releasing transactions have been removed.

BUG=104353
TEST=Run with '--trace-startup=sync,sync_lock_contention', open resulting
chrometrace.log in about:tracing.


Review URL: http://codereview.chromium.org/8573011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111265 0039d316-1c4b-4281-b951-d872f2087c98

aura::Window::StackChildAbove() and ui::Layer::StackAbove()
stacked entity A directly above entity B... unless A was
already somewhere above B in the stack, in which case they'd
do nothing.  I see the caveat as making these methods less
useful, and I'm unable to think of any benefits from it, so
this change makes the methods place A directly above B in
all cases (possibly lowering A in the stacking order if it
was previously far above B).

This also fixes an issue in the Aura shell's shadow-stacking
code where ShadowController could inadvertently raise a
window to the top of the stacking order.

BUG=101977
TEST=added

Review URL: http://codereview.chromium.org/8653005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111264 0039d316-1c4b-4281-b951-d872f2087c98

Convert callbacks to base::Callback:
  PhishingTermFeatureExtractor::DoneCallback
  PhishingDOMFeatureExtractor::DoneCallback
  ClientSideDetectionService::ClientReportPhishingRequestCallback
  BrowserFeatureExtractor::DoneCallback
  PhishingClassifier::DoneCallback

Convert ClientSideDetectionHost::cb_factory_ to base::WeakPtrFactory.

Also some easy NewRunnableMethod->base::Bind() conversions in
client_side_detection_host.cc.


Review URL: http://codereview.chromium.org/8573018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111263 0039d316-1c4b-4281-b951-d872f2087c98

BUG=79050


Review URL: http://codereview.chromium.org/8637025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111262 0039d316-1c4b-4281-b951-d872f2087c98

BUG=91241
TEST=


Review URL: http://codereview.chromium.org/8587023

TBR=sail@chromium.org
Review URL: http://codereview.chromium.org/8673003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111261 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/8665005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111259 0039d316-1c4b-4281-b951-d872f2087c98

The test loads the Angry Birds webapp, lets it run for a minute, then measures
CPU utilization and v8 heap size.

BUG=chromium-os:23230
TEST=None

Review URL: http://codereview.chromium.org/8566053

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111258 0039d316-1c4b-4281-b951-d872f2087c98

Ran 100 times without failure.

R=dennisjeffrey@chromium.org
BUG=99944
TEST=

Review URL: http://codereview.chromium.org/8666004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111257 0039d316-1c4b-4281-b951-d872f2087c98

MHTMLGenerationManager now uses a callback instead of a notification.

BUG=None
TEST=MHTML generation (via extension API should still work).

Review URL: http://codereview.chromium.org/8566016

TBR=jcivelli@chromium.org
Review URL: http://codereview.chromium.org/8672001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111256 0039d316-1c4b-4281-b951-d872f2087c98

Disables failing GViewRequestInterceptorTest.DoNotInterceptPdfWhenEnabled test under Heapcheck.

BUG=104566
TEST=Heapcheck goes green.
TBR=tbarzic@chromium.org

Review URL: http://codereview.chromium.org/8665003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111255 0039d316-1c4b-4281-b951-d872f2087c98

BUG=91241
TEST=


Review URL: http://codereview.chromium.org/8587023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111254 0039d316-1c4b-4281-b951-d872f2087c98

this patch also adds a comment that describes why
EAI_NODATA is disabled on FreeBSD

BUG=
TEST=
TBR=wtc

Review URL: http://codereview.chromium.org/8598010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111253 0039d316-1c4b-4281-b951-d872f2087c98

MHTMLGenerationManager now uses a callback instead of a notification.

BUG=None
TEST=MHTML generation (via extension API should still work).

Review URL: http://codereview.chromium.org/8566016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111252 0039d316-1c4b-4281-b951-d872f2087c98

Disables failing ProcessWatcherTest.ImmediateTermination test under Heapcheck.

BUG=93027
TEST=Heapcheck goes green
TBR=timurrrr@chromium.org

Review URL: http://codereview.chromium.org/8671001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111250 0039d316-1c4b-4281-b951-d872f2087c98

This CL makes the first parameter of the experimental savePage.saveAsMHTML API
a dictionary, so the API can easily be extended in the future.

BUG=None
TEST=browser_tests should pass.


Review URL: http://codereview.chromium.org/8631017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111249 0039d316-1c4b-4281-b951-d872f2087c98

Part of libcros removal.  Directly writing to the prefs file, instead of going
thru libcros.

BUG=chromium-os:16558
TEST=Go to VT2 and make sure /var/lib/power_manager/lock_on_idle_suspend does not exist (delete if it does).  Type 'stop powerd'.  Sign in as a user.  Press power button to lock screen.  Go to VT2 and look at /var/lib/power_manager/lock_on_idle_suspend.  The file should have been created.
Signed-off-by: Simon Que <sque@chromium.org>

R=satorux@chromium.org,stevenjb@chromium.org


Review URL: http://codereview.chromium.org/8573025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111248 0039d316-1c4b-4281-b951-d872f2087c98

BUG=97845
TEST=DragDropControllerTest.ViewRemovedWhileInDragDropTest


Review URL: http://codereview.chromium.org/8631015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111247 0039d316-1c4b-4281-b951-d872f2087c98

Reland 110355 - Use shared D3D9 texture to transport the compositor's backing buffer to the browser process for presentation.

Implemented ImageTransportSurface for Linux (without texture sharing), XP, Vista and 7. XP. The non-texture sharing Linux and XP paths just present directly to the compositing child window owned by the browser process as before.

PassThroughImageTransportSurface still needs a proper name. I will move it into its own file once that is decided.

I moved AcceleratedSurfaceBuffersSwapped outside of the platform specific ifdefs and made the signature the same on all platforms for greater consistency.

I removed the code related to sharing surfaces between processes and synchronizing resize and swapping out of GpuCommandBufferStub. It is all now in ImageTransportSurface implementations.
Original Review URL: http://codereview.chromium.org/8060045
Review URL: http://codereview.chromium.org/8622004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111246 0039d316-1c4b-4281-b951-d872f2087c98

Ran 100 times without failure.

BUG=99865
TEST=pyauto waterfall should be green

R=dennisjeffrey@chromium.org

Review URL: http://codereview.chromium.org/8668001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111245 0039d316-1c4b-4281-b951-d872f2087c98

* Fix a DCHECK due to a negative width when resizing the right edge past the left one, and vice versa.
* Fix the window moving when resizing its left edge past the minimum size, ditto for top edge.
* Add unit tests for above.
* Add GetMinimizeSize() method to aura::WindowDelegate interface.

BUG=104245
TEST=aura_shell_unittests, manual

Review URL: http://codereview.chromium.org/8618009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111244 0039d316-1c4b-4281-b951-d872f2087c98

Move ChromeOS bubble setup code to window.cc.
This code is also in the original bubble code. 
msw: Update name to CreateViewsBubbleAboveLockScreen.

BUG=98322
TEST=None

Review URL: http://codereview.chromium.org/8650001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111243 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
Review URL: http://codereview.chromium.org/8642006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111242 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
Review URL: http://codereview.chromium.org/8603007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111241 0039d316-1c4b-4281-b951-d872f2087c98

This is the first attempt at moving some of the Autofill logic out of the 
autofillagent in the renderer and into the external delegate in the browser.
I just focused on OnSuggestionsReturned, so the browser side should be able to 
correcrtly create the list of suggestions to show. There are still features that
need to be moved, such as the ability to select an item, which I will address in
future cls.

BUG=51644
TEST=


Review URL: http://codereview.chromium.org/8488011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111240 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
TEST=


Review URL: http://codereview.chromium.org/8468015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111239 0039d316-1c4b-4281-b951-d872f2087c98

Disables ALL PPAPITest.* tests under ASAN.  Increasing timeouts and selective
per-test disablement did not work.  So ifdef'ing out the whole bunch under ASAN.

BUG=104832
TEST=ASAN bot runs green
TBR=glider@chromium.org

Review URL: http://codereview.chromium.org/8658004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111238 0039d316-1c4b-4281-b951-d872f2087c98

BUG=105179
TBR=mihaip@chromium.org

Review URL: http://codereview.chromium.org/8663001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111237 0039d316-1c4b-4281-b951-d872f2087c98

BUG=98716
Review URL: http://codereview.chromium.org/8636023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111236 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=manually


Review URL: http://codereview.chromium.org/8633021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111235 0039d316-1c4b-4281-b951-d872f2087c98

BUG=73206
TEST=manually


Review URL: http://codereview.chromium.org/8616004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111234 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/8641003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111233 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=existing


Review URL: http://codereview.chromium.org/8637019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111232 0039d316-1c4b-4281-b951-d872f2087c98

BUG=91715
TEST=no


Review URL: http://codereview.chromium.org/8633011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111231 0039d316-1c4b-4281-b951-d872f2087c98

Disables OutOfProcessPPAPITest.Crypto test on ASAN.

BUG=104832
TEST=ASAN bot runs green
TBR=dmichael@chromium.org, noelallen@chromium.org

Review URL: http://codereview.chromium.org/8550004

TBR=dhollowa@chromium.org
Review URL: http://codereview.chromium.org/8656003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111230 0039d316-1c4b-4281-b951-d872f2087c98

Disables OutOfProcessPPAPITest.Crypto test on ASAN.

BUG=104832
TEST=ASAN bot runs green
TBR=glider@chromium.org

Review URL: http://codereview.chromium.org/8618002

TBR=dhollowa@chromium.org
Review URL: http://codereview.chromium.org/8649006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111229 0039d316-1c4b-4281-b951-d872f2087c98

Increases the ASAN timeout multiplier in an attempt to avoid timeout errors in OutOfProcessPPAPITest.* test when running under ASAN.

BUG=104832
TEST=ASAN bot runs green
TBR=glider@chromium.org

Review URL: http://codereview.chromium.org/8618014

TBR=dhollowa@chromium.org
Review URL: http://codereview.chromium.org/8653002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111228 0039d316-1c4b-4281-b951-d872f2087c98

R=ivankr@chromium.org
BUG=102765
TEST=Check that Protector is enabled by default.

Review URL: http://codereview.chromium.org/8632014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111227 0039d316-1c4b-4281-b951-d872f2087c98

Disables more failing OutOfProcessPPAPITest.* tests under ASAN.

BUG=104832
TEST=ASAN bot runs green
TBR=glider@chromium.org

Review URL: http://codereview.chromium.org/8636024

TBR=dhollowa@chromium.org
Review URL: http://codereview.chromium.org/8649005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111226 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111225 0039d316-1c4b-4281-b951-d872f2087c98

Mark as always-failing two already-flaky inspector tests after WebKit r100991.

BUG=89845,100538
TBR=koz

Review URL: http://codereview.chromium.org/8642003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111224 0039d316-1c4b-4281-b951-d872f2087c98