GitLab

Revert of After detach, there's no document to notify parsing is finished. (patchset #3 id:40001 of https://codereview.chromium.org/2537043002/ )

Reason for revert:
Speculative revert for crbug.com/669435

Original issue's description:
> After detach, there's no document to notify parsing is finished.
>
> HTMLViewSourceParser was tripping the DCHECK in
> DocumentParser::document when it recieved the last bytes of the
> document it was parsing after it was detached.
>
> BUG=664915
>
> Committed: https://crrev.com/8e59e2d6feaa38b37836837e996b9ad91c0b3745
> Cr-Commit-Position: refs/heads/master@{#434937}

TBR=tkent@chromium.org,yoichio@chromium.org,yosin@chromium.org,dominicc@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=664915

Review-Url: https://codereview.chromium.org/2538473004
Cr-Commit-Position: refs/heads/master@{#434954}

Recording this metric gives insight into how many people update their
settings after seeing the disclosure.

BUG=661011

Review-Url: https://codereview.chromium.org/2518963002
Cr-Commit-Position: refs/heads/master@{#434953}

Previously, for a multipart image,
- ResourceClient::notifyFinished() and
- ImageResourceObserver::imageNotifyFinished()
might be called twice:
1. When the first part is loaded, and
2. When the whole loading is finished.

This CL removes the second case to make callback/observer control consistent
and simpler, as preparation for https://codereview.chromium.org/2469873002/.

Behavior change:
Previously, multipart images are replaced with broken images when cancelled
after the first part is loaded.
After this CL, multipart images remains as-is in such cases.
https://codereview.chromium.org/1840933002 fixes layout tests for this change.

BUG=668598

Review-Url: https://codereview.chromium.org/2513413008
Cr-Commit-Position: refs/heads/master@{#434952}

This eliminates one of the sources of flakiness in
ResourcePrefetchPredictorBrowserTest.
It seems impossible to avoid an emergence of several requests belonging to the
same subresource but we could just ignore them as real code does.
The real code also ignores repeating entries of the same subresource but doesn't
modify collection passing to test observer.

BUG=650253

Review-Url: https://codereview.chromium.org/2529263003
Cr-Commit-Position: refs/heads/master@{#434951}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/a72be232..2ef8719e

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2536123002
Cr-Commit-Position: refs/heads/master@{#434950}

Remove future and deprecated policies from app_restrictions.xml and
restriction_values.xml, hence making them invisible to Android policy
managers. Also include all lines of multiline descriptions of policies.

BUG=616800
BUG=616801

Review-Url: https://codereview.chromium.org/2529383003
Cr-Commit-Position: refs/heads/master@{#434949}

BUG=667751

Review-Url: https://codereview.chromium.org/2525303002
Cr-Commit-Position: refs/heads/master@{#434948}

Preparation for https://codereview.chromium.org/2513413008.

This CL introduces Internals::isLoading() and make the tests to use
isLoading() instead of size checks for detecting broken images.

BUG=668598

Review-Url: https://codereview.chromium.org/1840933002
Cr-Commit-Position: refs/heads/master@{#434947}

This plumbing was never actually used, and we're now getting rid of the pings completely.

BUG=646308

Review-Url: https://codereview.chromium.org/2525653002
Cr-Commit-Position: refs/heads/master@{#434946}

Revert of win: Remove unneeded references to visual_studio_version now that it's always 2015. (patchset #4 id:60001 of https://codereview.chromium.org/2450933002/ )

Reason for revert:
V8 relies on this.

Original issue's description:
> win: Remove unneeded references to visual_studio_version now that it's always 2015.
>
> BUG=
>
> Committed: https://crrev.com/a628db5056deb88589224bd68dcd9ec029932c83
> Cr-Commit-Position: refs/heads/master@{#427463}

TBR=scottmg@chromium.org,thakis@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=

Review-Url: https://codereview.chromium.org/2531333004
Cr-Commit-Position: refs/heads/master@{#434945}

Reland after revert in 1b8f4236,
previous CL https://codereview.chromium.org/2530153002/
Previously failing Win10 test needs a rebaseline.

Issue 618178 describes an example where a Burmese text run starts with a
leading punctuation character followed by a combining spacing mark. This
grapheme cannot be shaped with the default font, since Times for example
cannot display the combination of a left quote with a Burmese combining
mark. Our fallback code attempts to find a fallback font based on the
first character at the beginning of an extracted unshaped sub-run, which
does not lead to finding a font suitable for Myanmar text in this case.
So in a way it runs into a fallback trap, where no fallback hint helps
to find the right fallback font and the whole run ends up as notdef
glyphs.

This CL attempts to resolve this by looking for a better fallback hint
character, which is not script common or inherited, if such is
available. This improves the situation for the Burmese text from the
issue report.

In addition, as a better fix we should give higher importance to the
locale information in font fallback, filed as issue 668706.

BUG=618178
TBR=eae,kojii,behdad

Review-Url: https://codereview.chromium.org/2539733002
Cr-Commit-Position: refs/heads/master@{#434944}

This patch moves "core/editing/*Test.cpp" to "core/editing/BUILD.gn" from
"core/BUILD.gn" to reduce size of "core/BUILD.gn" and ease of adding new test
for improving development experience.

BUG=n/a
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2533213002
Cr-Commit-Position: refs/heads/master@{#434943}

Makes non-cross-origin accessible attributes be accessor
properties.

[CachedAccessor] already made window.document an accessor
property, and this CL doesn't affect it.

Cross-origin accessible attributes remain being data
properties.

The previous attempt was http://crrev.com/1380503002

BUG=475556

Review-Url: https://codereview.chromium.org/2506393004
Cr-Commit-Position: refs/heads/master@{#434942}

Revert of Hook up views/widgets to AshDevToolsDOMAgent (patchset #3 id:40001 of https://codereview.chromium.org/2529553002/ )

Reason for revert:
Reverting due to a memory leak. See http://crbug.com/648701#c26

Original issue's description:
> Hook up views/widgets to AshDevToolsDOMAgent
>
> - This CL adds AshDevToolsDOMAgent as an observer to all widgets and views.
> The WidgetRemovalObserver is specifically to remove the RootView subtree,
> while the ViewObserver is to update any other descendant views.
> AddViewTree was created so that whenever any |view| is added, it can
> be pushed to the frontend.
> - Add tests for when views are inserted, removed, rearranged,
> removed & inserted.
> - Add test to check if a widget owned by a native widget is represented
> properly in the DOM.
>
> BUG=648701
>
> Committed: https://crrev.com/b4ce166c6eb7bf65dedbdb6947e23fbf2992e251
> Cr-Commit-Position: refs/heads/master@{#434863}

TBR=sadrul@chromium.org,mhashmi@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=648701

Review-Url: https://codereview.chromium.org/2532243003
Cr-Commit-Position: refs/heads/master@{#434941}

When we need to recollect active stylesheets for all scopes, have an
explicit markAllTreeScopesDirty method instead of relying on
FullStyleUpdate which will go away for async active stylesheet updates.

This CL does not contain functional changes.

R=meade@chromium.org
BUG=567021

Review-Url: https://codereview.chromium.org/2534863002
Cr-Commit-Position: refs/heads/master@{#434940}

The third parameter of "launchApp" is only used for the webstore app,
and used to append utm_source=chrome-ntp-icon to the app URL.
But the launchApp handler did not validate that the URL is safe.
To fix that issue, I specialize the parameter for launchApp: It now takes the
source string ("chrome-ntp-icon") instead of a URL without validation.

BUG=668665
TEST=Manually using test case from bug report. Also opened the app launcher and
verified that clicking on the Webstore icon still leads to the same place.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2527413002
Cr-Commit-Position: refs/heads/master@{#434939}

This patch adds AddRequestTask with its tests to ensure request queue
operations are properly sequenced.

BUG=651238

Review-Url: https://codereview.chromium.org/2527293002
Cr-Commit-Position: refs/heads/master@{#434938}

HTMLViewSourceParser was tripping the DCHECK in
DocumentParser::document when it recieved the last bytes of the
document it was parsing after it was detached.

BUG=664915

Review-Url: https://codereview.chromium.org/2537043002
Cr-Commit-Position: refs/heads/master@{#434937}

SourceStream::prepareDataOnMainThread() seems to be called after
ScriptStreamer::cancel() and thus SourceStream()::cancel() are called.

BUG=668611

Review-Url: https://codereview.chromium.org/2539683002
Cr-Commit-Position: refs/heads/master@{#434936}

Before this CL, we had a duplicated tracking flag
HTMLScriptRunner::m_hasScriptsWaitingForResources.

This CL removes the flag in HTMLScriptRunner and changes code so it checks
Document::isScriptExecutionReady() state instead.

This CL also removes a comment referring to HTMLDocumentParser::executeScriptsWaitingForResources
being called when it hasScriptsWaitingForResources as it should never happen
and replaces it with a DCHECK

BUG=None

Review-Url: https://codereview.chromium.org/2536753003
Cr-Commit-Position: refs/heads/master@{#434935}

This makes 'transform', 'gradientTransform' and 'patternTransform'
presentation attributes on SVGGraphicsElements, SVGGradientElements
and SVGPatternElements respectively.

Spec:

 http://www.w3.org/TR/css3-transforms/#svg-transform
 http://www.w3.org/TR/css3-transforms/#svg-syntax
 http://www.w3.org/TR/css3-transforms/#svg-gradient-transform-pattern-transform

Salvaged from https://codereview.chromium.org/423093014, but takes a
different approach to bridge the syntax gap and avoid crbug.com/577219.

The strategy taken here is to use the SVGTransformList to generate a
CSSValue for the presentation attribute style, and hence postponing
both support for the full transform syntax and a way around the bug
mentioned above. Essentially softening the blow. These two "features"
are expected to be implemented eventually, so this is just a "first
step".

BUG=369942
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2478233002
Cr-Commit-Position: refs/heads/master@{#434934}

Make minidump uploading test utility more useful/accessible to WebView
to allow for testing the WebView-implementation of minidump uploading.

BUG=665448

Review-Url: https://codereview.chromium.org/2532133002
Cr-Commit-Position: refs/heads/master@{#434933}

Review-Url: https://codereview.chromium.org/2539443002
Cr-Commit-Position: refs/heads/master@{#434932}

Follow up on r420711 (crbug.com/589632) and adjust the expected lower
bound on ".elapsedTime" to also include zero for 'start' events.

TBR=dmazzoni
BUG=660448

Review-Url: https://codereview.chromium.org/2540623002
Cr-Commit-Position: refs/heads/master@{#434931}

ReplaceSelectionCommand::doApply repeatedly rewrites the DOM to fix up
the content it is inserting. One of those modifications--removing
redundant inline styles--may end up deleting the very span it is
tracking the insertion of.

This moves the node of interest into the InsertedNodes collection. As
the inserted nodes collection is modified, it adjusts the node of
interest to a surviving node.

BUG=668808

Review-Url: https://codereview.chromium.org/2533703002
Cr-Commit-Position: refs/heads/master@{#434930}

- Moved the BubbleDecoration one pt to the left
- Moved the Omnibox text one pt to the left

BUG=666990, 666977

Review-Url: https://codereview.chromium.org/2520003007
Cr-Commit-Position: refs/heads/master@{#434929}

Cr-Commit-Position: refs/heads/master@{#434928}

The ASAN bots say this causes a crash; I can't replicate it locally, but
I believe that the combination of `document.write` and synchronous
`javascript:` URL navigation could cause the auditor to trigger while the
document is detaching. This patch adds a small check.

BUG=668772

Review-Url: https://codereview.chromium.org/2531253002
Cr-Commit-Position: refs/heads/master@{#434927}

This resolves performance issue when uploading video to e.g. FLOAT or
UNSIGNED_SHORT textures.  If canUseCopyTextureCHROMIUM returns false, we
shouldn't create AcceleratedImageBufferSurface, call paintCurrentFrame and
texImage2DBase since they would not be used.  This is because imageBuffer->
copyToPlatformTexture is not supported when canUseCopyTextureCHROMIUM is false
and it would early return false.

BUG=624436
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2527343002
Cr-Commit-Position: refs/heads/master@{#434926}

BUG=545399
TEST=manual test by the repro steps in the bug
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2535713003
Cr-Commit-Position: refs/heads/master@{#434925}

This patch migrates all of the smallIcons usages in consoleView.css onto
UI.Icon.

BUG=669323
R=dgozman

Review-Url: https://codereview.chromium.org/2538673002
Cr-Commit-Position: refs/heads/master@{#434924}

Review-Url: https://codereview.chromium.org/2528263004
Cr-Commit-Position: refs/heads/master@{#434923}

https://helpx.adobe.com/security/products/flash-player/apsb16-37.html

BUG=412078
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
TBR=jschuh@chromium.org

Review-Url: https://codereview.chromium.org/2534103002
Cr-Commit-Position: refs/heads/master@{#434922}

R=jyquinn@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2494853003
Cr-Commit-Position: refs/heads/master@{#434921}

R=dpapad@chromium.org
BUG=614265
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2528523002
Cr-Commit-Position: refs/heads/master@{#434920}

Previously we had a provider, which was not connected to any data
source. This CL connects it to PhysicalWebDataSource,rewrites the
existing test and adds a new one.

BUG=635893

Review-Url: https://codereview.chromium.org/2517113005
Cr-Commit-Position: refs/heads/master@{#434919}

To avoid data copies in many places.

BUG=593251
TEST=user image and wallpaper stuff works as before

Review-Url: https://codereview.chromium.org/2517053004
Cr-Commit-Position: refs/heads/master@{#434918}

In the previous patch https://codereview.chromium.org/2233543002/, we missed to check if the
touch events which we will make uncancelable when there is an active fling are on the
same layer as the current active scroll layer or its descendants.

Now, we add the scroll layer check here to minimize the breaking cases and also match with other
browsers' behavior, such as Safaris and Firefox.

This code has two parts:
1. Delete the is_fling flag we used on https://codereview.chromium.org/1923973002/
to indicate if the actice fling is happening.
2. Add check to the touch start if it hits on the same layer as the current active scroll layer.

BUG=595327

Review-Url: https://codereview.chromium.org/2471523002
Cr-Commit-Position: refs/heads/master@{#434917}

`ProfileManager::GetLastUsedProfile` creates a profile if it does not exist. `HttpsEngagementMetricsProvider::ProvideGeneralMetrics` can be called in `PostMainMessageLoopRun`, and it will try to create a profile, which is not what you'd want during shutdown.

BUG=

Review-Url: https://codereview.chromium.org/2531023002
Cr-Commit-Position: refs/heads/master@{#434916}

print_preview_ui.cc previously specified different specified a system
print dialog shortcut message of "(Ctrl+Shift+P)" for Windows and
ChromeOS, and "(Shift+Ctrl+P)" for everything else except Mac OSX. These
have been unified such that everything besides Mac OSX uses
"(Ctrl+Shift+P)".

Review-Url: https://codereview.chromium.org/2534733002
Cr-Commit-Position: refs/heads/master@{#434915}