- 25 Nov, 2019 40 commits
-
-
Arthur Hemery authored
In order to reuse COEP in other objects, we move its definition into an easy to include single struct mojo file. It replaces the massive network_context.mojom include. Change-Id: I245d68d3fe1880b369c3c65801c502a1aee8b027 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930738Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Pâris Meuleman <pmeuleman@chromium.org> Commit-Queue: Arthur Hemery <ahemery@chromium.org> Cr-Commit-Position: refs/heads/master@{#718655}
-
Egor Pasko authored
Pushing to internal repo does not require a netrc any more (uses a more fancy auth with role accounts and ACLs). Hence removing the support code for it. A downstream test instantiates the OrderfileUpdater. Make the constructor argument optional to avoid changing downstream code simultaneously. Bug: 1021528 Change-Id: Ie902bdd1d7272f7d884f6ce2e99e9983a1aa5166 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1934330Reviewed-by:
Benoit L <lizeb@chromium.org> Commit-Queue: Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#718654}
-
Kevin Ellis authored
GetPlayState is a reasonably efficient method and there appears to be little benefit in caching its value. Previously, we had 3 variants of the play state cached: the last state used for devtools notifications, and 2 for tracking the extended and spec-compliant play state. The devtools one is still needed to avoid spamming devtools notifications; however, the later two can be removed as part of the refactoring effort. The extended play state (internal_play_state) is required as long as PlayStateUpdateScope is in use. This patch removes use of animation_play_state_. A minor bug was exposed and fixed in removing this variable. Previously we explicitly marked an animation as finished after calling the finished method (what else could it be?) rather than computing the new play state. Per spec, the start time is not set if there is no active timeline and thus the animation transitions to paused and not finished. https://drafts.csswg.org/web-animations-1/#finishing-an-animation-section Bug: 960944 Change-Id: Ia07213d83bb9645251849a548b19b37dd30b3086 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931158 Commit-Queue: Kevin Ellis <kevers@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Cr-Commit-Position: refs/heads/master@{#718653}
-
David Roger authored
This is a reland of https://chromium-review.googlesource.com/c/chromium/src/+/1930818 Change-Id: I974c44b0cbffc5621f1fd9b0c9f7358061f907a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932801Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#718652}
-
Hans Wennborg authored
while we figure out how to handle this new warning. TBR=rnk Bug: 1028110 Change-Id: I88be5c763bd0f2fcb40ebecc20990f96853d70c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932804Reviewed-by:
Hans Wennborg <hans@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#718651}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/b245e85651eb..74637ca12a6a git log b245e85651eb..74637ca12a6a --date=short --no-merges --format='%ad %ae %s' 2019-11-25 rsavitski@google.com Merge "traced_perf: build in-tree (i.e. add to Android.bp)" Created with: gclient setdep -r src/third_party/perfetto@74637ca12a6a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I0b8f91dac1a95380a813fc853f4c5650bd0aa061 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1934105Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#718650}
-
Leon Han authored
Previously we only supported ArrayBuffer, this CL adds the support for ArrayBufferView. BUG=1027023 Change-Id: Ib3a27e62fb333d4b3dc6a2dd0e5395ae51da5264 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930452 Auto-Submit: Leon Han <leon.han@intel.com> Reviewed-by:
Rijubrata Bhaumik <rijubrata.bhaumik@intel.com> Commit-Queue: Leon Han <leon.han@intel.com> Cr-Commit-Position: refs/heads/master@{#718649}
-
Steve Kobes authored
Bug: 984109 Change-Id: Ie31c63995f63f8acbfa26d97966ffe30016edd3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925447 Commit-Queue: Steve Kobes <skobes@chromium.org> Reviewed-by:
Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#718648}
-
Ilia Samsonov authored
googletest will no longer support empty prefix for parameterized INSTANTIATE_TEST_SUITE_P. Adding "All" prefix to existing empty prefix test suites. This CL was uploaded by git cl split. R=jkarlin@chromium.org Bug: 1023677 Change-Id: I8dc8a4be989cd4c2d443e211d330f5280fe1d7c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926806 Auto-Submit: Ilia Samsonov <isamsonov@google.com> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Commit-Queue: Josh Karlin <jkarlin@chromium.org> Cr-Commit-Position: refs/heads/master@{#718647}
-
Brian Salomon authored
Bug: 1028116 Change-Id: Ib369f8d9779a313473277f522d020baab09d6b17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933730Reviewed-by:
Robert Phillips <robertphillips@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com> Cr-Commit-Position: refs/heads/master@{#718646}
-
Ilia Samsonov authored
googletest will no longer support empty prefix for parameterized INSTANTIATE_TEST_SUITE_P. Adding "All" prefix to existing empty prefix test suites. This CL was uploaded by git cl split. R=jkarlin@chromium.org Bug: 1023677 Change-Id: I5c5e1351aded5e80e53e0e57096a1ea9d7056bb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925736 Auto-Submit: Ilia Samsonov <isamsonov@google.com> Reviewed-by:
-
Rob Buis authored
MathML depends on LayoutNG to work, so skip MathML tests when LayoutNG is disabled. Bug: 6606 Change-Id: I95c3c5763d54f2a774415bb3a12611795067ee94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932779 Commit-Queue: Rob Buis <rbuis@igalia.com> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#718644}
-
Vasiliy Telezhnikov authored
This CL implements browser side fling for viz for webview Bug: 805739 Change-Id: I0a5cf29330690da797ec3a3f6ce1e440dec6255a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930681 Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#718643}
-
James Cook authored
This keeps them out of the public pref_names.h header and makes it more obvious that they are obsolete. This reveals that the Android ChromeBackupAgent has been backing up empty prefs since 1/2019. Stop backing up those prefs. Based on my reading of the backup and restore code this should work OK. The restore code already checks to make sure all the prefs being restored are still valid names. Bug: 906611 Change-Id: I962ddc0f52f06f38247647bffeabba85a0721ef2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929974 Commit-Queue: Marc Treib <treib@chromium.org> Auto-Submit: James Cook <jamescook@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#718642}
-
Mike West authored
The portal tests are timing out on wpt.fyi because portals aren't behind the experimental web platform test flag. This patch adds an `assert_precondition` call to ensure that we're not waiting around for a test that will never pass. Change-Id: I6541460d5116de411fe30956d56b41d4d773e106 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932782Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Commit-Queue: Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#718641}
-
Mike Reed authored
Removes using a legacy skia flag Bug: skia:9663 Change-Id: I85b728fb987c2304ac51e8a6a7d84da62f625774 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928209Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Florin Malita <fmalita@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Mike Reed <reed@google.com> Cr-Commit-Position: refs/heads/master@{#718640}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/9c0c92b2db86..dd5ba942eb1e git log 9c0c92b2db86..dd5ba942eb1e --date=short --no-merges --format='%ad %ae %s' 2019-11-25 fmalita@chromium.org [skottie] Use seekFrame in skottie2movie Created with: gclient setdep -r src/third_party/skia@dd5ba942eb1e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bungeman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: bungeman@google.com Change-Id: Ie5e01f2a8956a67fc65b662c51d1ee23305cf9df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1934103Reviewed-by:
-
Denis Kuznetsov authored
Bug: 1023591 Change-Id: I60e13fea207828ce8760cea1c529d4743a0ff909 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932546Reviewed-by:
Roman Aleksandrov <raleksandrov@google.com> Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#718638}
-
Ilia Samsonov authored
googletest will no longer support empty prefix for parameterized INSTANTIATE_TEST_SUITE_P. Adding "All" prefix to existing empty prefix test suites. This CL was uploaded by git cl split. R=mcasas@chromium.org Bug: 1023677 Change-Id: Ib685f8d5159bdbbeed15bf098e07d3843acd45d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926991 Auto-Submit: Ilia Samsonov <isamsonov@google.com> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#718637}
-
Mario Sanchez Prada authored
This CL migrates code to the new BrowserInterfaceBroker class, allowing the renderer process to retrieve the remote implementation without relying on FrameClient's InterfaceProvider. Bug: 955171, 978694, 936482 Change-Id: I96e820ea03e1f55c41ef107bc7c8d031ed6f3652 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844990 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Ben Kelly <wanderview@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#718636}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/204f9ad496e5..b4b5033445f5 git log 204f9ad496e5..b4b5033445f5 --date=short --no-merges --format='%ad %ae %s' 2019-11-25 yangguo@chromium.org Roll protocol changes from Chromium Created with: gclient setdep -r src/third_party/devtools-frontend/src@b4b5033445f5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Iac2a81717bc6db75eb3fcdfc562ee315006ca349 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1934104Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/eac63e7e0262..912b3b83b380 git log eac63e7e0262..912b3b83b380 --date=short --no-merges --format='%ad %ae %s' 2019-11-25 danilchap@webrtc.org Make rtc::Thread a TaskQueue 2019-11-25 titovartem@webrtc.org Semiautomatic attempt to clean test/BUILD.gn deps 2019-11-25 kron@webrtc.org Add totalInterFrameDelay to RTCInboundRTPStreamStats 2019-11-25 danilchap@webrtc.org Add fuzzer test for RtpDepacketizerAv1::AssembleFrame function Created with: gclient setdep -r src/third_party/webrtc@912b3b83b380 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:b/144982320,chromium:None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I41b684cb2fa9d4d11b1a799ea36bb29ae509f782 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1934102Reviewed-by:
-
Ilia Samsonov authored
googletest will no longer support empty prefix for parameterized INSTANTIATE_TEST_SUITE_P. Adding "All" prefix to existing empty prefix test suites. This CL was uploaded by git cl split. R=mcasas@chromium.org Bug: 1023677 Change-Id: Iaa163d01189aba67fadcf2b14bfcadd622283228 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1927048 Auto-Submit: Ilia Samsonov <isamsonov@google.com> Reviewed-by:
-
Etienne Pierre-doray authored
DCHECK is triggered in base::internal::CheckedLockImpl::Acquire from: base::FeatureList::IsFeatureEnabled(base::Feature const &) base::FeatureList::IsEnabled(base::Feature const &) base::internal::ThreadGroupImpl::Start This is probably related to MayBlockWithoutDelay feature recently enabled on canary. Fix: Move lock's scope to exclude IsEnabled. Bug: 1027333 Change-Id: I7663ee109a4c26b0ca500760394748da2572802d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929865Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#718632}
-
Javier Ernesto Flores Robles authored
Adds a help icon to the top toolbar, which will open the help center. Bug: 1028095 Change-Id: I10320d8f65c687d8959f67b3bdaa0f43d2663ca2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932903Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#718631}
-
Ilia Samsonov authored
googletest will no longer support empty prefix for parameterized INSTANTIATE_TEST_SUITE_P. Adding "All" prefix to existing empty prefix test suites. This CL was uploaded by git cl split. R=mcasas@chromium.org Bug: 1023677 Change-Id: I20f0bf799ee87047605bb384db6483025a817dd5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926863 Auto-Submit: Ilia Samsonov <isamsonov@google.com> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f1d198eaf22f..f26135c33f22 Created with: gclient setdep -r src-internal@f26135c33f22 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:None Tbr: jbudorick@google.com Change-Id: I2b0852b961a82607a5d3923198dc9323b169d4e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1934164Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#718629}
-
Chromium WPT Sync authored
Using wpt-import in Chromium a2ebcd22. With Chromium commits locally applied on WPT: e83dd93c "Limit backtracking on regexp called from blink." 500a74f5 "Add a runtime flag to enforce strict MIME type checks for workers." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: Ib6f556fdd1b0b3fd7ee6096ec603beefafb5b49b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933483Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#718628}
-
Andreas Haas authored
The next data structure we change to size_t. R=haraken@chromium.org Bug: chromium:1008840 Change-Id: I586fcb0c0fcbc7be30c6c617eeab037b64af7c2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930826Reviewed-by:
-
Francois Doray authored
Testing in a slow build (e.g. debug) shows that there can be nested main frame navigations in a WebContents. For example: WebContentsObserver::DidStartNavigation() a.com WebContentsObserver::DidStartNavigation() b.com WebContentsObserver::DidFinishNavigation() a.com WebContentsObserver::DidFinishNavigation() b.com Also, FirstWebContentsProfiler may be created when DidStartNavigation() has not been dispatched yet. This CL handles this by tracking the first top-level navigation id observed by DidStartNavigation() or DidFinishNavigation(). Once the first top-level navigation id is set, if DidStartNavigation() observes a different top-level navigation id, profiling is aborted. Bug: 1026053, 1022492 Change-Id: Ieff3e67ddd1a5a8ce5f2406a10cfe137a083d2ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1924699 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#718626}
-
Ilia Samsonov authored
googletest will no longer support empty prefix for parameterized INSTANTIATE_TEST_SUITE_P. Adding "All" prefix to existing empty prefix test suites. This CL was uploaded by git cl split. R=mcasas@chromium.org Bug: 1023677 Change-Id: I1e859f39bbeff1f234af35f21c6194ad74014dcc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1924805 Auto-Submit: Ilia Samsonov <isamsonov@google.com> Reviewed-by:
-
Ilia Samsonov authored
googletest will no longer support empty prefix for parameterized INSTANTIATE_TEST_SUITE_P. Adding "All" prefix to existing empty prefix test suites. This CL was uploaded by git cl split. R=mcasas@chromium.org Bug: 1023677 Change-Id: Ie3adc120e44ee5e9a758a2dad85b65d76bf334c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1927010 Auto-Submit: Ilia Samsonov <isamsonov@google.com> Reviewed-by:
-
Renato Silva authored
Moves the error messages from the footer-container in 'oobe-dialog' to the subtitle area. Tested locally. Bug: 994515 Change-Id: Ice89a651298a7872797bcab6bd02a49b628f452c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1921980 Commit-Queue: Renato Silva <rrsilva@google.com> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#718623}
-
Maksim Moskvitin authored
In case some datatype entries changes too often they could bypass nudge delay and trigger infinite (or too long) commit cycle. This happened because we asked for contributions in a cycle until we have no entries to commit. This CL changes this behavior: commit cycle is exited once we committed less than max_commit_batch_size() and it wasn't caused by Nigori commit (which blocks contributions from regular datatypes). There are some small refactorings to avoid API misuse in the future: CommitProcessor is now owned by BuildAndPostCommits() and there is no way to change commit_types in the middle of commit construction. kSyncPreventCommitsBypassingNudgeDelay can be used to revert behavioral changes in case there are some unexpected side effects. Bug: 1022293 Change-Id: I19f2bba09396cde0cf0d415e929f34189e80ac0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904068 Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Reviewed-by:
-
Friedrich Horschig authored
The linked bug shows crashes that might have to causes: * without focused frame, creating the factory fails * the factory is created successfully but the manager is invalid (this might be the default case for Android WebViews) This CL aims to fix both crashes by returning early in all methods that require a frame or manager to do their work. Bug: 1023241 Change-Id: I14ff3ef96a4d0bef22059b12cc5f872fb1d7897b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932899Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#718621}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/4a5ee9541e55..b245e85651eb git log 4a5ee9541e55..b245e85651eb --date=short --no-merges --format='%ad %ae %s' 2019-11-25 fmayer@google.com Merge "Add data source names to data_source_config proto." Created with: gclient setdep -r src/third_party/perfetto@b245e85651eb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: Ib833f1cfb6ecc7f2e70c1cdc8d77215d6d0de220 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1934098Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/ad9d72b765c5..204f9ad496e5 git log ad9d72b765c5..204f9ad496e5 --date=short --no-merges --format='%ad %ae %s' 2019-11-25 almuthanna@google.com Create Karma tests for Progress.js 2019-11-25 tvanderlippe@chromium.org Add TypeScript Ninja integration 2019-11-25 janscheffler@chromium.org Show cookies after reloading a single resource 2019-11-25 almuthanna@google.com Revert "Cover find function and modify Karma reporting" Created with: gclient setdep -r src/third_party/devtools-frontend/src@204f9ad496e5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1011811 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ic5c8bac792d406e068dc6df9c77c117ef68423f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1934101Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/8f2a89dc..7b44da5f Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I843da5456272955b8afa55bdda464ff81d2e7467 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933482Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#718618}
-
Wei-Cheng Xiao authored
We'll keep using the metrics to track number of parallel tasks in cryptohome, so keep the historgram. Bug: 1025885 Change-Id: Idb9e038565a82036b3a0a372dbe31728b2b286e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1924335Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Wei-Cheng Xiao <garryxiao@chromium.org> Auto-Submit: Wei-Cheng Xiao <garryxiao@chromium.org> Cr-Commit-Position: refs/heads/master@{#718617}
-
Mathias Carlen authored
This patch waits for the initial loadUrl to be done before running the rest of the direct action availability tests. Running this 20x locally resulted in no flakes. R=arbesser@google.com Bug: 1027688 Change-Id: I04cd376160b8a62dd475a94abfb3311d2890b206 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932898Reviewed-by:
Clemens Arbesser <arbesser@google.com> Commit-Queue: Mathias Carlen <mcarlen@chromium.org> Cr-Commit-Position: refs/heads/master@{#718616}
-
