- 04 Jun, 2019 40 commits
-
-
A Olsen authored
Change-Id: I831192ae4d928137486098272df4969a5a7463bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643547Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: A Olsen <olsen@chromium.org> Cr-Commit-Position: refs/heads/master@{#665899}
-
Henrique Ferreiro authored
After recent changes, SigninManager exposes no public API surfaces over SigninManagerBase. This CL eliminates nearly all usage of signin_manager.h and in particular eliminates the no-longer needed SigninManager::FromSigninManagerBase() method. The remaining usage is for sites that *construct* SigninManager instances. These sites will need to remain as such until SigninManager is actually merged into SigninManagerBase. This is a step in eliminating the inheritance relationship between SigninManager and SigninManagerBase, as motivated in this design doc: https://docs.google.com/document/d/15y-Db27BV08vrIyelHB-3CwiAfDYh-FigNKGXrqSWto/edit#heading=h.8jjdy95t6p7x and described concretely here: https://docs.google.com/document/d/15y-Db27BV08vrIyelHB-3CwiAfDYh-FigNKGXrqSWto/edit#heading=h.mbkrv9nkb93w TBR=rohitrao@chromium.org Bug: 952766, 883648 Change-Id: Icb114b11dc2c74d8b49cfd77baba33b707a4157e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1565316 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#665898}
-
Koji Ishii authored
Following bot results are included. 20678 20690 20695 20706 20716 20724 20730 20736 20743 20757 20769 20782 20787 20794 20798 0 lines were removed and 2 lines were deflaked by consecutive results since 20706. TBR=eae@chromium.org, mstensho@chromium.org NOTRY=true Bug: 591099 Change-Id: I5b1fd09607b9f68295b83f5a9573a4998c28451e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1640140Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#665897}
-
Findit authored
This reverts commit 631cf612. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 665876 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzYzMWNmNjEyZTg4YmUzZWIyMWQ0MmY2ZTFjYzYxZjk3NDlmYWY3OGUM Sample Failed Build: https://ci.chromium.org/buildbot/chromium.memory/Mac%20ASan%2064%20Tests%20%281%29/53748 Sample Failed Step: content_browsertests Original change's description: > Test: MHTML document loaded inside a data-URL parent. > > In an MHTML document, blink::DocumentLoader::archive_ is transmitted > from parent to children. data-URL aren't loaded from the MHTML archive. > In this case, does it means children of data-URL aren't able to be > loaded from the MHTML archive? Hopefully, it is currently working. They > are able to load from the MHTML document, because |archive_| continue to > be transmitted. > > This CL adds a test to ensure this continue to work in the future. > > Bug: None. > Change-Id: Icb51dc48691112cf9e45dfe8cb81d389544a0c41 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635669 > Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Cr-Commit-Position: refs/heads/master@{#665876} Change-Id: Iab5a838b789e845537a3a81a8f87cd54516b1162 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: None. Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643089 Cr-Commit-Position: refs/heads/master@{#665896}
-
Sergio Villar authored
This reverts commit 7d714d6a. Reason for revert: Makes NotificationImageLoaderTest.TimeoutTest fail on a couple of bots Original change's description: > Reland "Remove time overrides from TestingPlatformSupportWithMockScheduler" > > This is a reland of f75182ab > > TBR=jbroman@chromium.org, dcheng@chromium.org > > Original change's description: > > Remove time overrides from TestingPlatformSupportWithMockScheduler > > > > TestingPlatformSupportWithMockScheduler used time overrides to control time in > > tests. Time overrides are removed as part of the OnionSoup effort. Tests should > > use the mock clock from the TestTaskRunner provided by the platform. > > > > Bug: 919383 > > Change-Id: Idf3d44ed2aeff8c73de09671b50b779419146d3b > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1591634 > > Reviewed-by: Jeremy Roman <jbroman@chromium.org> > > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > > Commit-Queue: Sergio Villar <svillar@igalia.com> > > Cr-Commit-Position: refs/heads/master@{#665724} > > Bug: 919383 > Change-Id: I76d14136b8f239b90dde32442af3cca0c4efe044 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642554 > Reviewed-by: Sergio Villar <svillar@igalia.com> > Commit-Queue: Sergio Villar <svillar@igalia.com> > Cr-Commit-Position: refs/heads/master@{#665888} TBR=dcheng@chromium.org,jbroman@chromium.org,svillar@igalia.com Change-Id: I38e49a621387933b03ed228ccdb3ca8f62e084ba No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 919383 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643468Reviewed-by:
Sergio Villar <svillar@igalia.com> Commit-Queue: Sergio Villar <svillar@igalia.com> Cr-Commit-Position: refs/heads/master@{#665895}
-
sebsg authored
This reverts commit 197a1362. Reason for revert: Unable to add card entries under chrome://settings/payments Original change's description: > Send only 1 event from AutofillPrivate to the JS > > OnAddressListChanged, OnCreditCardsChanged > Instead it should have a single OnPersonalDataChanged call > > Bug: 923868 > Change-Id: Ie6bc51cf71f82228df32db551489bf66168a54e6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631451 > Commit-Queue: sebsg <sebsg@chromium.org> > Reviewed-by: sebsg <sebsg@chromium.org> > Reviewed-by: Steven Bennetts <stevenjb@chromium.org> > Auto-Submit: Jaeyong Bae <jdragon.bae@gmail.com> > Cr-Commit-Position: refs/heads/master@{#664246} TBR=stevenjb@chromium.org,sebsg@chromium.org,jdragon.bae@gmail.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 923868, 968426 Change-Id: Idfcee169a82c3836b70173d8669b29a45cd47c5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643408Reviewed-by:
sebsg <sebsg@chromium.org> Commit-Queue: sebsg <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#665894}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/60695f091d91..5e67c8e8ef64 Created with: gclient setdep -r src-internal@5e67c8e8ef64 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=harringtond@google.com,orphis@google.com,shend@google.com Change-Id: I70d453b95fe2e3633d6588d41a471ba461dc1537 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643487Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#665893}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/12818515b5a3..525aa0ca60c8 git log 12818515b5a3..525aa0ca60c8 --date=short --no-merges --format='%ad %ae %s' 2019-06-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src f75363e4..ce989eac (360 commits) 2019-06-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 98f2167125a8..2dd40a44d1a6 (8 commits) Created with: gclient setdep -r src/third_party/skia@525aa0ca60c8 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jcgregorio@google.com Change-Id: I08a8a84740235cd33d1d7314dd6c40dda2adbd19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643077Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#665892}
-
Tanmoy Mollik authored
The multilogin code assumes that accountID is Gaia ID which is not true for chromeOS. GaiaCookieManagerService does not have any way to get gaia_id from account_id. It is created from AccountsCookieMutatorImpl. So AccountsCookieMutatorImpl now takes a account_tracker_service pointer and passes a vector of pairs (CoreAccountId, std::string gaia_id) to the GaiaCookieManagerService. This is the first part of the cl to fix the bug. The second part is to fix OauthMultiLoginHelper class. Bug: 956503 Change-Id: I6ff7ceafb6a1a3ca29e8f7630596ceb659d8ea73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1624189Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
John Wu <jzw@chromium.org> Commit-Queue: Tanmoy Mollik <triploblastic@google.com> Cr-Commit-Position: refs/heads/master@{#665891}
-
Sylvain Defresne authored
As base::Callback is deprecated, change both callbacks in BrowserFeatureExtractor to be base::OnceCallback. This is possible since 1. gmock now supports move-only objects 2. HistoryService has been refactored to use base::OnceCallback instead of base::Callback too (thus it is possible to move the callback without using base::AdaptCallbackForRepeating) Also pass the request as std::unique_ptr<...> as the reason stated in the implementation (impossible to mock method that uses std::unique_ptr<...>) is not longer true. Bug: 714018, 812523 Change-Id: I46bbceb0b85efbeee390eb11f050edf1bfd896af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632257 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:Nathan Parker <nparker@chromium.org> Cr-Commit-Position: refs/heads/master@{#665890}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Ibb6562f2e8265154c24270dc64df281eb28073d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643075Reviewed-by:
-
Sergio Villar Senin authored
This is a reland of f75182ab TBR=jbroman@chromium.org, dcheng@chromium.org Original change's description: > Remove time overrides from TestingPlatformSupportWithMockScheduler > > TestingPlatformSupportWithMockScheduler used time overrides to control time in > tests. Time overrides are removed as part of the OnionSoup effort. Tests should > use the mock clock from the TestTaskRunner provided by the platform. > > Bug: 919383 > Change-Id: Idf3d44ed2aeff8c73de09671b50b779419146d3b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1591634 > Reviewed-by: Jeremy Roman <jbroman@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Commit-Queue: Sergio Villar <svillar@igalia.com> > Cr-Commit-Position: refs/heads/master@{#665724} Bug: 919383 Change-Id: I76d14136b8f239b90dde32442af3cca0c4efe044 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642554Reviewed-by:
-
Morten Stenshorne authored
The state machinery inside multicol layout keeps track of the current LayoutMultiColumnSet being worked on, so we cannot simply enter an arbitrary element, so some work, and leave again. Bug: 967180 Change-Id: Id40be07e20c1f575c07161127937e0cc9fa75ba8 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1640416 Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#665887}
-
Henrique Ferreiro authored
After https://crrev.com/c/1344089, SigninManagerBase::Observer doesn't have any private methods, so SigninManager no longer needs to be a friend. Change-Id: I87ddfb4c25657476bd00f734a8d22c07f5b05a0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642047Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Cr-Commit-Position: refs/heads/master@{#665886}
-
Henrique Ferreiro authored
After https://codereview.chromium.org/14630003, there are no uses of SigninManagerBase's weak pointer. Change-Id: I3ed342d5434d40ee63be3a4ae8cf785e49fb21da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642553Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/d7092831..d4e26bda Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ib1255768660fa3bedff87b9b066a5032f11c3cdb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642950Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#665884}
-
Leon Han authored
We do not need an extra blink::ControllerServiceWorker class to implement blink.mojom.ControllerServiceWorker interface because it just asks blink::ServiceWorkerGlobalScope for doing any actual work. This CL removes blink::ControllerServiceWorker and just lets ServiceWorkerGlobalScope impl blink.mojom.ControllerServiceWorker instead. As ServiceWorkerGlobalScope is already overriding DispatchFetchEvent() for blink.mojom.ServiceWorker, and blink.mojom.ControllerServiceWorker also has a method DispatchFetchEvent() with exactly the same signature, to avoid naming collision, this CL also renames them as below: blink.mojom.ServiceWorker.DispatchFetchEventForMainResource() blink.mojom.ControllerServiceWorker.DispatchFetchEventForSubresource() BUG=922376 Change-Id: I37d52c15f0290407b6ddba56911b70cef09fb3d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636970 Commit-Queue: Leon Han <leon.han@intel.com> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#665883}
-
Richard Knoll authored
This is a small refactoring to make the path through displayNotification a bit easier to read and extend. Bug: None Change-Id: I0bc05f3a19f03b755dd26a080961b66d567d0960 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642729 Commit-Queue: Richard Knoll <knollr@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#665882}
-
Javier Ernesto Flores Robles authored
Bug: 845472 Change-Id: I96451e8ef3a7a4d6b07782f2aa02d94f1ca86d63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1613178 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#665881}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4976a2236cd3..60695f091d91 Created with: gclient setdep -r src-internal@60695f091d91 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=harringtond@google.com,orphis@google.com,shend@google.com Change-Id: Ifc803934cc549ef8278a693816e0af9d843e829b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643073Reviewed-by:
-
Gabriel Charette authored
Used while debugging https://chromium-review.googlesource.com/c/chromium/src/+/1635473 and I think it'll be a nice general purpose debugging tool for developers. R=alexclarke@chromium.org Bug: 946657 Change-Id: I479eb51d00b835bf8a4a75a1b044ab5db12aae13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639389Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Auto-Submit: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#665879}
-
Lukasz Suder authored
The top padding can be specified either by the Pixels or ratio relative to the height of the window. Bug: 806868 Bug: b/132758584 Change-Id: I2d3f77b04a9ca319634fe2ec1325d24c0052d100 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631607Reviewed-by:
Stephane Zermatten <szermatt@chromium.org> Commit-Queue: Lukasz Suder <lsuder@chromium.org> Cr-Commit-Position: refs/heads/master@{#665878}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/455e2d59031c..9dff8a104051 git log 455e2d59031c..9dff8a104051 --date=short --no-merges --format='%ad %ae %s' 2019-06-04 bmgordon@chromium.org cros lint: Run shellcheck in script's directory Created with: gclient setdep -r src/third_party/chromite@9dff8a104051 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Change-Id: I60eae7c62c61abd034642140d6d011ac9cefb1a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643347Reviewed-by:
-
arthursonzogni authored
In an MHTML document, blink::DocumentLoader::archive_ is transmitted from parent to children. data-URL aren't loaded from the MHTML archive. In this case, does it means children of data-URL aren't able to be loaded from the MHTML archive? Hopefully, it is currently working. They are able to load from the MHTML document, because |archive_| continue to be transmitted. This CL adds a test to ensure this continue to work in the future. Bug: None. Change-Id: Icb51dc48691112cf9e45dfe8cb81d389544a0c41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635669 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
-
Pavel Shmakov authored
Bug: 970184 Change-Id: I7e18eddffa5a99df17b329a4331c65c3254dd335 TBR=twellington@chromium.org Change-Id: I7e18eddffa5a99df17b329a4331c65c3254dd335 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642636 Commit-Queue: Pavel Shmakov <pshmakov@chromium.org> Reviewed-by:
Pavel Shmakov <pshmakov@chromium.org> Cr-Commit-Position: refs/heads/master@{#665875}
-
Julie Jeongeun Kim authored
This CL is a precursor CL to moving WebApplicationCacheHostImpl to loader. It removes ApplicationCacheHost::ResourceInfoList. ApplicationCacheHost and InspectorApplicationCacheAgent use mojom::blink::AppCacheResourceInfo directly instead of having conversion for these types. It has still conversion between WebApplicationCacheHost::ResourceInfo and mojom::blink::AppCacheResourceInfo for Web interface but it will be also removed at the CL for moving WebApplicationCacheHostImpl to loader. Bug: 950159 Change-Id: I6ca488c4007ff8214e525c46344246777714c013 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642613Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#665874}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 2de200e4. With Chromium commits locally applied on WPT: e90c6ef0 "NG/DL: Implement size containment (and display lock) for NG fieldset algo" abf2ac5e "webrtc wpt: avoid race conditions" 1bbbd106 "Add feature policy for client hints, used for third-party subresources." ab94a58b "Add the remaining Client Hints to Feature Policy." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=foolip No-Export: true Change-Id: I8cb5f2f1431e563c0c9af81dae405ffbc506bb90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643289Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#665873}
-
Nikita Podguzov authored
Bug: 948273 Change-Id: I7615c9a1ec5912363b977bb0a2d1a272e26a1a31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639392 Commit-Queue: Nikita Podguzov <nikitapodguzov@google.com> Reviewed-by:
Lutz Justen <ljusten@chromium.org> Cr-Commit-Position: refs/heads/master@{#665872}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/bd002715a898..c8501f7ae392 git log bd002715a898..c8501f7ae392 --date=short --no-merges --format='%ad %ae %s' 2019-06-04 barrerap@webrtc.org Fix bug in neteq_quality_test 2019-06-04 asapersson@webrtc.org Fix comment typo about degradation preference. Created with: gclient setdep -r src/third_party/webrtc@c8501f7ae392 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:none TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ia4e8c3b163a4853ddfa7fc49f3f7c37aa2ae3ed0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643290Reviewed-by:
-
Etienne Pierre-doray authored
This CL replaces ScopedNestableTaskAllower with kNestableTasksAllowed passed as argument to the RunLoop involved if any. Only native nested loops should use ScopedNestableTaskAllower (soon to be deprecated). For more details, see: https://cs.chromium.org/chromium/src/base/message_loop/message_loop_current.h?sq=package:chromium&dr=CSs&g=0&l=159 A small step towards deleting MessageLoop. This CL was generated with git cl split. Refer to the top-level CL if necessary : https://chromium-review.googlesource.com/c/chromium/src/+/1635819 Please CQ if LGTY! This CL was uploaded by git cl split. R=jam@chromium.org Bug: 766678 Change-Id: Ia1cd4759cde35f80b6ea0a6e5de78f1c91e3744f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635826 Auto-Submit: Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#665870}
-
Rune Lillesveen authored
Remove the methods from Node and ContainerNode to avoid confusion. This is not fixing 967548, but a part of trying to make sense of the active/hover code to make sure a fix will be sound. Bug: 967548 Change-Id: Ia60a3cda7ec66db63dec2acc939c91ecbfdf24ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1641842Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#665869}
-
Kush Sinha authored
Please check the attached bug for context. The screen needs to be: - Frameless (no title bar or 'X' button). - Non-draggable. to conform to other current Chrome OS welcome dialogs. Bug: 968143 Change-Id: Idcd85d37aa1985dd02002674d47996b76f96cc68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642067Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Kush Sinha <sinhak@chromium.org> Cr-Commit-Position: refs/heads/master@{#665868}
-
Yoichi Osato authored
This patch adds the flag that overrides default read buffer size (32k Bytes) for WebSocket. The buffer is the first pool to receive date from network socket. This flag will be used to investigate the performance issue. You can use this flag both on chrome and content_shell: $ ./chrome.exe --websocket-read-buffer-size=3000000 This flag sets the buffer size 300k Bytes. Bug: 865001 Change-Id: I57aeb9e2feb9b249f1265596d6da5524a63f801a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635079Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Adam Rice <ricea@chromium.org> Commit-Queue: Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#665867}
-
Etienne Pierre-doray authored
MessageLoopCurrent::task_runner() is depecated. This CL replaces it with with ThreadTaskRunnerHandle::Get(). A small step towards deleting MessageLoop. This CL was generated with git cl split. Refer to the top-level CL if necessary : https://chromium-review.googlesource.com/c/chromium/src/+/1631693 Please CQ if LGTY! This CL was uploaded by git cl split. R=jam@chromium.org Bug: 616447 Change-Id: Ib72f68278cfd05901c1a69c612feb5415485dae8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636059 Auto-Submit: Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4b1386c027fe..4976a2236cd3 Created with: gclient setdep -r src-internal@4976a2236cd3 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=harringtond@google.com,orphis@google.com,shend@google.com Change-Id: I0dad24532c7de77b9b151880cf0bf13094cc9763 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643149Reviewed-by:
-
Yi Su authored
This CL moves CRWWebController.pageTransitionFromNavigationType into CRWWKNavigationHandler. Bug: 956511 Change-Id: I7b9a9d906af0827569190aa4c7e3a391c3aac963 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639381Reviewed-by:
-
Sylvain Defresne authored
Uses of base::Callback<...> is deprecated in favor of either base::OnceCallback<...> or base::RepeatingCallback<...> (the former is preferred if possible). This is part 6 of a multi-CL refactoring and does: - use PostTaskAndReplyWithResult in HistoryService::GetVisibleVisitCountToHost thus removing a naked "new" and the use of base::Unretained and base::Owned to pass the value to both callbacks - change GetVisibleVisitCountToHostCallback callback to be invoked with VisibleVisitCountToHostResult passed by value instead as a const pointer thus allowing to remove an helper function - change GetVisibleVisitCountToHostCallback to a base::OnceCallback<...> - change HistoryBackend::GetVisibleVisitCountToHost to return the result by value instead of via an out parameter Bug: 812523, 714018 Change-Id: Ib6906436103d0014d523b5e4e6dc86fcb8e34d08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632152 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:Scott Violet <sky@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#665863}
-
Vasilii Sukhanov authored
PasswordManagerDriver::GeneratedPasswordAccepted is called directly by the pop- up. The CL changes the call to go through PasswordGenerationState. In the next CLs the class will perform disambiguation step before telling the renderer to fill the generated password. Bug: 936011 Change-Id: I5e38476dcd22384440feafe69b47179ef3a67628 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631281 Auto-Submit: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
-
Ian Kilpatrick authored
This makes style_ member within LayoutObject const! There is one const_cast added within: Node::MutableComputedStyleForEditingDeprecated This method is used within the editing codebase which is non-trivial to remove at the moment. Bug: 813068 Change-Id: Ia248932c8789d7405ec64a5fd2c86b701cb37d35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636554 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#665861}
-
arthursonzogni authored
Navigation to MHTML document needs to be tested. There are some blink web tests, but no real browser tests. This adds the NavigationMhtmlBrowserTest set of tests. It contains an helper class to quickly build and use MHTML archives easily in tests. New tests: + NavigationMhtmlBrowserTest.IframeFound + NavigationMhtmlBrowserTest.IframeNotFound + NavigationMhtmlBrowserTest.IframeDataUrlNotFound + NavigationMhtmlBrowserTest.IframeDataUrlFound + NavigationMhtmlBrowserTest.IframeAboutSrcDocFound + NavigationMhtmlBrowserTest.IframeAboutSrcDocNotFound + NavigationMhtmlBrowserTest.IframeAboutBlankFound + NavigationMhtmlBrowserTest.IframeAboutBlankNotFound + NavigationMhtmlBrowserTest.IframeJavascriptUrlFound + NavigationMhtmlBrowserTest.IframeJavascriptUrlNotFound + NavigationMhtmlBrowserTest.IframeContentIdUrlFound + NavigationMhtmlBrowserTest.IframeContentIdUrlNotFound Some weird expectations have been found, but not investigated yet. The test NavigationMhtmlBrowserTest.IframeDataUrl is not enabled, because it reaches a DCHECK. See https://crbug.com/967307. It needs to be fixed in a follow up. The main goal for this CL is to prepare for: https://chromium-review.googlesource.com/c/chromium/src/+/1547521 New tests will make us a bit more confident. Bug: 967307, 936696 Change-Id: I71cee7a4377467126f10b22b9d828f539045e102 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631399 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#665860}
-
