GitLab

Introduces the NonBlockingTypeProcessor's sync logic.  When combined
with the NonBlockingTypeProcessorCore's sync logic (which will be
introduced in a follow-up commit), this will be an alternative to the
existing sync engine implemented with DirectoryUpdateHandler and
DirectoryCommitContributor.

Adds non_blocking_sync_common.h, which defines structs to be used to
pass messages between the processor and processor core.

Adds DataTypeState as a parameter to the processor to processor core
connection methods.  Eventually this will be used to initialize the
processor core with state that the processor loaded from disk.

Adds a lot of unit tests and unit test framework intrastructure.  The
NonBlockingTypeProcessor and NonBlockingTypeProcessorCore's
communications with each other will be very racy.  These tests are
intended to help manage the complexity this will cause by allowing us to
test all the possible race conditions individually.

BUG=351005

Review URL: https://codereview.chromium.org/280983002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272329 0039d316-1c4b-4281-b951-d872f2087c98

While 'gestureSourceTypeSupported' has not rolled into stable,
IsGestureSourceTypeSupported returns false for touch input when on Mac.

BUG=372714

Review URL: https://codereview.chromium.org/296113005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272328 0039d316-1c4b-4281-b951-d872f2087c98

Starting in r266097, we always used the insets provided by Gtk2Border. We had previously had a hacky solution where we tried to determine whether the button was a toolbar button by digging in its style, but that hack was removed because it overreached. We had this hack to deal with slightly larger icon assets that GTK handed us.

In r269180, there was a subtle timing change, which then meant  that buttons outside the toolbar started using the GTK insets, such as buttons in the extension removal dialog, the javascript alert dialog, etc.

Now, Gtk2Border always uses the insets provided by the views::LabelButtonBorder (and we no longer have a concept of "GTK insets"), and we explicitly set smaller insets that don't cause the clipping issues only in ToolbarButton. This lets both bugs be fixed at the same time.

BUG=372305
TEST=Using GTK+ theme mode, the left edge of the back button shouldn't be visually chopped off.
TEST=Using GTK+ theme mode, The OK button on a javascript alert shouldn't be vertically squashed.
TEST=Using the default theme, both of the above should look normal.
R=msw@chromium.org, sky@chromium.org

Review URL: https://codereview.chromium.org/292153008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272326 0039d316-1c4b-4281-b951-d872f2087c98

This makes it possible to add candidate configurations at either the
back (least-preferred) or front (most-preferred) of each channel's
candidate list.

This CL also disables VP9, by default, in candidate session
configurations, replaces DisableVideoCodec with 
EnableVideoCodec, and makes the Enable/Disable<foo>Codec
helpers members of CandidateSessionConfig..

Review URL: https://codereview.chromium.org/292093002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272324 0039d316-1c4b-4281-b951-d872f2087c98

Updating AppMenu back, forward, and star assets to the latest spec.

BUG=375379
R=dtrainor@chromium.org

Review URL: https://codereview.chromium.org/296693010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272323 0039d316-1c4b-4281-b951-d872f2087c98

Reland "Only dispatch menu events if they have a valid target. (https://codereview.chromium.org/284903002/)"

Clean up MenuController at end of tests and on subsequent RunMenu calls.

BUG=370162
TEST=MenuControllerTest.EventTargeter
TEST=In touchview, open wrench menu and press a key (i.e. 'T'), nothing should
happen.

Review URL: https://codereview.chromium.org/286933007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272322 0039d316-1c4b-4281-b951-d872f2087c98

Implements reflection blocking for the in-process fake sync server.

The notifications delivery system used in the real world will not
deliver notifications of new or modified items to the client that
originated that change.  This feature is known by the names
"reflection blocking" or "squelching".

Most of out integration tests expect reflection blocking to be
disabled, so we can't turn this on in all tests.  The default
is to leave it off.  Tests that want to enable reflection blocking
must override "TestUsesSelfNotifications" in their test framework
class.

BUG=323265

Review URL: https://codereview.chromium.org/296743005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272321 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
NOTRY=True

Review URL: https://codereview.chromium.org/295103009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272320 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Remove override of View::HitTestRect() from BookmarkBarView (https://chromiumcodereview.appspot.com/286313003/)

Reason for revert:
Items on the bookmark bar can still be highlighted and tooltips are shown when the omnibox popup is open. tdanderson@ will investigate.

Original issue's description:
> Remove override of View::HitTestRect() from BookmarkBarView
> 
> The override of View::HitTestRect() in BookmarkBarView checks
> for the state of the omnibox popup to determine whether or not the
> bookmark bar can accept events. Since this is unrelated to location,
> it is better to move this logic into an override of
> EventTarget::CanAcceptEvent() instead.
> 
> BUG=374340
> TEST=none
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272133

TBR=sadrul@chromium.org,sky@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=374340

Review URL: https://codereview.chromium.org/298653007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272318 0039d316-1c4b-4281-b951-d872f2087c98

BUG=376064



git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272317 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272316 0039d316-1c4b-4281-b951-d872f2087c98

This patch reverts r272117, which broke the prelight state on toolbar
buttons.

BUG=376478,374325
TBR=sadrul@chromium.org
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/296703012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272315 0039d316-1c4b-4281-b951-d872f2087c98

Specifically, edits font size and padding, and makes calculation of the close
button's origin clearer.

BUG=None

Review URL: https://codereview.chromium.org/294123002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272313 0039d316-1c4b-4281-b951-d872f2087c98

Right now we set the surface view background color everytime we create a new
surface and this causes a white flash everytime the activity is resumed

BUG=365589

Review URL: https://codereview.chromium.org/293983011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272312 0039d316-1c4b-4281-b951-d872f2087c98

Don't allow octal in default (and constant) values. (Or any other values
that may pop up.)

R=sky@chromium.org

Review URL: https://codereview.chromium.org/291173010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272311 0039d316-1c4b-4281-b951-d872f2087c98

BUG=357270
TEST=GestureProviderTest.AuraTripleTap

Review URL: https://codereview.chromium.org/289373009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272310 0039d316-1c4b-4281-b951-d872f2087c98

MediaStreamManager::SendMessageToNativeLog posts a task to the UI thread, which will attach the audio thread to the Android java VM. Unlike chrome created threads, the audio thread is owned by the OS and does not detach itself from the VM on exit, causing a crash.

The fix is to not call SendMessageToNativeLog on Android because webrtc logging is never enabled on Android due to the lack of extension.

BUG=365915

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271764

Review URL: https://codereview.chromium.org/294803003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272309 0039d316-1c4b-4281-b951-d872f2087c98

Resurrecting PrepareForShutdown as it can be implemented onl in ash.

BUG=None

Review URL: https://codereview.chromium.org/294073006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272308 0039d316-1c4b-4281-b951-d872f2087c98

Also make ActiveScriptController used for all extensions with pseudo-all-hosts (e.g., *://*.com/*).
Add unittests for ActiveScriptController (to complement the browsertests).

BUG=362353

Review URL: https://codereview.chromium.org/293003008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272307 0039d316-1c4b-4281-b951-d872f2087c98

No longer used/present.

R=reed@google.com

Review URL: https://codereview.chromium.org/298973006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272306 0039d316-1c4b-4281-b951-d872f2087c98

TBR=sadrul
NOTRY=true

Review URL: https://codereview.chromium.org/296903007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272304 0039d316-1c4b-4281-b951-d872f2087c98

Don't update username_element and password_element in UpdateLogin().

BUG=349138,344337

Review URL: https://codereview.chromium.org/299443002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272303 0039d316-1c4b-4281-b951-d872f2087c98

Sheriffs tend to get confused by stacks from intentional exceptions in gtest
output. This should avoid us chasing red herrings.

BUG=

Review URL: https://codereview.chromium.org/292743020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272302 0039d316-1c4b-4281-b951-d872f2087c98

Instead of using both Clock::IsPlaying() and waiting_for_clock_update_,
use a three-state representation so it's easier to determine the actual
state of both audio rendering and the clock when Pipeline is in its
playing state. Introduce some helpers to deal with transitioning between states.

This is needed for the upcoming BufferingState changes as Pipeline now
handles underflow/preroll.

BUG=370634

Review URL: https://codereview.chromium.org/294133003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272301 0039d316-1c4b-4281-b951-d872f2087c98

Schedule a task to run ShouldOfferMetricsReporting() on FILE thread. The reason of doing this is that GoogleUpdateSettings::GetCollectStatsConsent() can't be called from UI thread, but the bubble class function might be called from  UI thread. 

BUG=372060

Review URL: https://codereview.chromium.org/287653004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272300 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272299 0039d316-1c4b-4281-b951-d872f2087c98

This is in preparation for GCM componentization.

BUG=356716
TEST=existing tests
TBR=yoz@chromium.org

Review URL: https://codereview.chromium.org/292813007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272298 0039d316-1c4b-4281-b951-d872f2087c98

This pulls in the latency graph side panel.

BUG=None
TBR=nduca

Review URL: https://codereview.chromium.org/284313015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272297 0039d316-1c4b-4281-b951-d872f2087c98

BUG=374834

Review URL: https://codereview.chromium.org/293133002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272296 0039d316-1c4b-4281-b951-d872f2087c98

This CL is clean up of nacl_test_data.gyp file by supporting
nonsfi testing in ppapi_nacl_test_common.gypi.
For that purpose, this CL introduces a simple script
create_nonsfi_test_nmf.py, to generate .nmf files based on
gyp configurations.

TEST=Ran browser_tests --gtest_filter=NaClBrowserTest* locally, and ran trybots with --clobber.
BUG=368949

Review URL: https://codereview.chromium.org/294593005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272295 0039d316-1c4b-4281-b951-d872f2087c98

With this change, the webapp will install the host component (if it is not installed) on Windows when the user tries to share an IT2Me session. Also HostInstallDialog (instead of HostSetupDialog) now displays the installation progress dialog so it can be shared by both IT2Me and Me2Me.

The code around HostDispatcher and HostIt2MeDispatcher is still a bit ugly but it should look better after the removal of the NPAPI dispatching logic, which comes next.

BUG=134215

Review URL: https://codereview.chromium.org/291133004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272294 0039d316-1c4b-4281-b951-d872f2087c98

This profiler will take care of gathering the profiling data used by the PGO builders on Windows.

Because of the aggressive way Chrome shutdown its processes we need to manually call pgosweep.exe (http://msdn.microsoft.com/en-us/library/9hwkw6e8.aspx) to dump the profiling data into a PGC file. 

BUG=309849

Review URL: https://codereview.chromium.org/276683005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272293 0039d316-1c4b-4281-b951-d872f2087c98

Parsing /etc/issue is unreliable.

I tried logging into a compute engine bot to verify that
output of lsb_release and it reported precise correctly
(mine your the /etc/issue was also the same as precise
and didn't contain GCEL).

BUG=376363
R=thestig@chromium.org

Review URL: https://codereview.chromium.org/298863006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272292 0039d316-1c4b-4281-b951-d872f2087c98

BUG=245025

Review URL: https://codereview.chromium.org/267323009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272291 0039d316-1c4b-4281-b951-d872f2087c98

When the window is resized, some drivers clobber the back buffer.
Unfortunately that can happen in the middle of a frame, and so we lose part
of what we've drawn and don't know it until we swapped (resulting in
flashes).

So instead, we create a child window, with a CopyFromParent visual (to avoid
inducing extra blits in the driver), that we can resize exactly in Resize(),
correctly ordered with GL, so that the buffer clobber is at the beginning of the
frame, before we will draw anything to it.

BUG=326995

Review URL: https://codereview.chromium.org/296003010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272290 0039d316-1c4b-4281-b951-d872f2087c98

Otherwise the title change applies to the previous navigation entry and causes
trouble.

BUG=376034
TEST=Open settings. Click History, Extensions, Settings, History, Extensions,
    Settings, etc. Drag the back button down. Icons should match titles (and
    the pages the entries should be on).

Review URL: https://codereview.chromium.org/299703012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272289 0039d316-1c4b-4281-b951-d872f2087c98

Added code to enable/disable navigation buttons(prev/Next).
Prev button will be enable only if user can navigate in back direction and 
similarly Next button will be enable only if user can navigate in forward direction.



BUG=374702
NOTRY=true

Review URL: https://codereview.chromium.org/287373002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272288 0039d316-1c4b-4281-b951-d872f2087c98

BUG=353533
TEST=None
R=sky
TBR=benwells (For trivial change to apps/ui/views/native_app_window_views.cc)

Review URL: https://codereview.chromium.org/282133005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272287 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272286 0039d316-1c4b-4281-b951-d872f2087c98

> Roll pdfium to get fixes for build warnings.
> 
> a3f590b  Add Matt Giuca to AUTHORS.
> 4db62f5  Fixed or silenced all warnings and turned on warnings-as-errors.
> 2c4b046  cf2hints: Fix early loop termination causing hints to be ignored.
> 4fbe779  Add some blank lines at the end of 3 files to remove the "no newlines at end of file" warning.
> 6f9095f  Add my @chromium account in the AUTHORS file.
> 54c1825  Remove "using namespace agg" to make it clear which code is using agg, and also so we can turn compiler warnings into errors.
> 5ce98f5  Fix warning on Mac.
> 41f0590  Remove "using namespace v8" in header. This allows us to turn all warnings into errors. It also makes it clearer to find usage of v8 in the library.
> 
> R=thestig@chromium.org
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271905
> 
> Review URL: https://codereview.chromium.org/295983005

TBR=jam@chromium.org

Review URL: https://codereview.chromium.org/289083005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272285 0039d316-1c4b-4281-b951-d872f2087c98